[FFmpeg-devel] [PATCH v2] avformat/movenc: remove write_colr warning

2022-12-11 Thread Gyan Doshi
The old warning is no longer applicable after this block was recomposed in c5b20cfe19. The block is only active for supported formats. --- libavformat/movenc.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index 7b00e65cdd..d1bef25147 100644 --- a

[FFmpeg-devel] [PATCH] avformat/movenc: correct write_colr warning

2022-12-11 Thread Gyan Doshi
The old warning is no longer correct after this block was recomposed in c5b20cfe19. The block is only active for supported formats. --- libavformat/movenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index 7b00e65cdd..d3c823e4e6

Re: [FFmpeg-devel] [PATCH v2 2/2] avformat/mov: re-allow zero sample sizes if that is not the default

2022-12-11 Thread Chris Ribble
On Sun, Dec 11, 2022 at 5:55 AM Marton Balint wrote: > > Patch 03d81a044ad587ea83567f75dc36bc3d64278199 disallowed zero sample sizes, > but there are some files in the wild which have zero sized samples (e.g. > no audio in some part of a live recording). > > Fix this by simply ignoring a trun box

Re: [FFmpeg-devel] [PATCH v4] lavc: convert frame threading to the receive_frame() pattern

2022-12-11 Thread Michael Niedermayer
On Sat, Dec 10, 2022 at 09:10:18PM +0100, Timo Rothenpieler wrote: > On 10.12.2022 00:46, Michael Niedermayer wrote: > > On Fri, Dec 09, 2022 at 02:37:04PM +0100, Timo Rothenpieler wrote: > > > From: Anton Khirnov > > > > > > Reorganize the code such that the frame threading code does not call th

[FFmpeg-devel] [PATCH v2 3/3] fftools/ffmpeg_demux: fix stdin interaction condition

2022-12-11 Thread Zhao Zhili
From: Zhao Zhili Disable stdin interaction for pipe and fd protocols only if the file descriptor is explicitly or implicitly setting to zero. --- fftools/ffmpeg_demux.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/fftools/ffmpeg_demux.c b/fftools/ffmpeg_demux.c index e

[FFmpeg-devel] [PATCH v2 1/3] avformat/file: add fd protocol

2022-12-11 Thread Zhao Zhili
From: Zhao Zhili Unlike the pipe protocol, fd protocol has seek support if it corresponding to a regular file. --- v2: dup the file descriptor for safety doc/protocols.texi | 24 ++ libavformat/Makefile| 1 + libavformat/file.c | 55 +++

[FFmpeg-devel] [PATCH v2 2/3] avformat/file: dup file descriptor for pipe protocol

2022-12-11 Thread Zhao Zhili
From: Zhao Zhili This can fix read/write error when user close the file descriptor earlier. Now user can close the file descriptor earlier to avoid file descriptor leak. So it's safer in both way. --- libavformat/file.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/liba

Re: [FFmpeg-devel] [PATCH v7 0/3] 32bps FLAC patches

2022-12-11 Thread Martijn van Beurden
Op do 1 dec. 2022 om 13:31 schreef Paul B Mahol : > > On 11/25/22, Paul B Mahol wrote: > > On 10/11/22, Martijn van Beurden wrote: > >> Recently libFLAC gained the ability (first released in FLAC 1.4.0) > >> to create FLAC files containing 32-bit int PCM samples. To > >> keep complexity reasonabl

[FFmpeg-devel] [PATCH v2 2/2] avformat/mov: re-allow zero sample sizes if that is not the default

2022-12-11 Thread Marton Balint
Patch 03d81a044ad587ea83567f75dc36bc3d64278199 disallowed zero sample sizes, but there are some files in the wild which have zero sized samples (e.g. no audio in some part of a live recording). Fix this by simply ignoring a trun box with zero sized samples. This approach fixes the original timeout

Re: [FFmpeg-devel] [PATCH] Revert "avformat/mov: disallow a zero sample size in trun atoms"

2022-12-11 Thread Marton Balint
On Tue, 6 Dec 2022, Chris Ribble wrote: On Mon, Dec 5, 2022 at 12:04 PM Marton Balint wrote: Share the sample please. If the patch I proposed does not fix it, I am not sure what is the best approach here. Sure, I will send you the URL to the file so that you can try it. Ok, thanks, I

Re: [FFmpeg-devel] [PATCH] lavc/videotoolbox: validate vt context in the decoder callback

2022-12-11 Thread Alessandro Di Nepi
On 9 Dec 2022, 6:45 +0200, FFmpeg development discussions and patches , wrote: > Did you call av_videotoolbox_default_init() or > av_videotoolbox_default_init2()? Actually yes, I call `av_videotoolbox_default_init(context);` > I think that’s why avctx->internal->hwaccel_priv_data is NULL. That co