Re: [FFmpeg-devel] [PATCH v2 1/2] avutil: move bswapdsp from avcodec to avutil

2022-12-06 Thread Andreas Rheinhardt
Mark Reid: > On Tue, Dec 6, 2022 at 8:11 PM Andreas Rheinhardt < > andreas.rheinha...@outlook.com> wrote: > >> mindm...@gmail.com: >>> From: Mark Reid >>> >>> Also renamed bswap_buf to bswap32_buf >>> --- >>> configure | 56 --- >>> libavcodec/

Re: [FFmpeg-devel] [PATCH v2 1/2] avutil: move bswapdsp from avcodec to avutil

2022-12-06 Thread Mark Reid
On Tue, Dec 6, 2022 at 8:11 PM Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: > mindm...@gmail.com: > > From: Mark Reid > > > > Also renamed bswap_buf to bswap32_buf > > --- > > configure | 56 --- > > libavcodec/4xm.c

Re: [FFmpeg-devel] [PATCH] lavfi/vf_scale_qsv: remove PI, PHI and E

2022-12-06 Thread Gyan Doshi
On 2022-12-07 08:13 am, Xiang, Haihao wrote: From: Haihao Xiang PI, PHI and E are defined in libavutil/eval.c, and user may use these constants for scale_qsv filter, so we needn't re-define these variables in vf_scale_qsv.c LGTM. Signed-off-by: Haihao Xiang --- libavfilter/vf_scale_

Re: [FFmpeg-devel] [PATCH v2 1/2] avutil: move bswapdsp from avcodec to avutil

2022-12-06 Thread Andreas Rheinhardt
mindm...@gmail.com: > From: Mark Reid > > Also renamed bswap_buf to bswap32_buf > --- > configure | 56 --- > libavcodec/4xm.c | 14 ++--- > libavcodec/Makefile | 1 - > libavcodec/ac3dec.

Re: [FFmpeg-devel] [PATCH 1/2] lavc: add new minimize_copies hwaccel_flag

2022-12-06 Thread Andreas Rheinhardt
Timo Rothenpieler: > --- > doc/APIchanges | 3 +++ > libavcodec/avcodec.h | 11 +++ > libavcodec/options_table.h | 1 + > libavcodec/version.h | 2 +- > 4 files changed, 16 insertions(+), 1 deletion(-) > > diff --git a/doc/APIchanges b/doc/APIchanges > index ab7

[FFmpeg-devel] [PATCH] lavfi/vf_scale_qsv: remove PI, PHI and E

2022-12-06 Thread Xiang, Haihao
From: Haihao Xiang PI, PHI and E are defined in libavutil/eval.c, and user may use these constants for scale_qsv filter, so we needn't re-define these variables in vf_scale_qsv.c Signed-off-by: Haihao Xiang --- libavfilter/vf_scale_qsv.c | 9 - 1 file changed, 9 deletions(-) diff --gi

Re: [FFmpeg-devel] [PATCH v2] lavu/hwcontext_vaapi: Skip 'vgem' driver

2022-12-06 Thread Xiang, Haihao
On Ma, 2022-12-05 at 14:33 -0800, Brian Norris wrote: > There can be more than one available render node, and it's not > guaranteed the first node we come across is the correct one. In > particular, 'vgem' devices are common, and are > never VAAPI-enabled and thus not valid here. > > We have a 'ke

Re: [FFmpeg-devel] [PATCH] lavfi/vf_vpp_qsv: use macros for extra mfx parameter

2022-12-06 Thread Xiang, Haihao
On Ma, 2022-12-05 at 14:25 +0800, Xiang, Haihao wrote: > From: Haihao Xiang > > Make it easy to add new extra mfx parameter buffer. No functional > change. > > Signed-off-by: Haihao Xiang > --- > libavfilter/vf_vpp_qsv.c | 86 > 1 file changed, 34 inser

Re: [FFmpeg-devel] [PATCH v3] libavfilter/qsvvpp: Change the alignment to meet the requirement of YUV420P format

2022-12-06 Thread Xiang, Haihao
On Ma, 2022-12-05 at 14:32 +0800, wenbin.chen-at-intel@ffmpeg.org wrote: > From: Wenbin Chen > > When process yuv420 frames, FFmpeg uses same alignment on Y/U/V > planes. VPL and MSDK use Y plane's pitch / 2 as U/V planes's > pitch, which makes U/V planes 16-bytes aligned. We need to set > a

[FFmpeg-devel] [PATCH 2/2] avutil/tx_template: Use more unsigned ints to avoid undefined overflows

2022-12-06 Thread Michael Niedermayer
Fixes: signed integer overflow: 574590586 - -1875616554 cannot be represented in type 'int' Fixes: 53914/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_AAC_FIXED_fuzzer-5037125846564864 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed

[FFmpeg-devel] [PATCH 1/2] avcodec/dts2pts_bsf: Avoid searching for poc == INT_MIN-1

2022-12-06 Thread Michael Niedermayer
Fixes: signed integer overflow: -2147483648 - 1 cannot be represented in type 'int' Fixes: 53876/clusterfuzz-testcase-minimized-ffmpeg_BSF_DTS2PTS_fuzzer-6569754750222336 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael N

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/nvdec: make explicit copy of frames unless user requested otherwise

2022-12-06 Thread Philip Langdale
On Mon, 5 Dec 2022 23:25:59 +0100 Timo Rothenpieler wrote: > --- > libavcodec/nvdec.c | 13 +++-- > 1 file changed, 11 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/nvdec.c b/libavcodec/nvdec.c > index fbaedf0b6b..76ee395734 100644 > --- a/libavcodec/nvdec.c > +++ b/libavco

Re: [FFmpeg-devel] [PATCH 1/2] lavc: add new minimize_copies hwaccel_flag

2022-12-06 Thread Philip Langdale
On Mon, 5 Dec 2022 23:25:58 +0100 Timo Rothenpieler wrote: > --- > doc/APIchanges | 3 +++ > libavcodec/avcodec.h | 11 +++ > libavcodec/options_table.h | 1 + > libavcodec/version.h | 2 +- > 4 files changed, 16 insertions(+), 1 deletion(-) > > diff --git a/

Re: [FFmpeg-devel] [PATCH v2 1/2] avutil: move bswapdsp from avcodec to avutil

2022-12-06 Thread Mark Reid
On Tue, Dec 6, 2022 at 10:21 AM James Almer wrote: > On 12/5/2022 7:16 PM, mindm...@gmail.com wrote: > > diff --git a/libavcodec/bswapdsp.h b/libavutil/bswapdsp.h > > similarity index 71% > > rename from libavcodec/bswapdsp.h > > rename to libavutil/bswapdsp.h > > index 6f4db66115..b540560d6a 100

[FFmpeg-devel] Defect: MediaCodec Encoder - Pixel ColorSpace of many Adreno GPUs not supported

2022-12-06 Thread Ben Temple
MediaCodec Encoder: Pixel ColorSpace of many Adreno GPUs is not supported (<= Adreno 650 in our testing)What you were trying to accomplish? I am trying to transcode an MP4 file using the MediaCodec encoder support that was recently added by Zhao Zhili here

[FFmpeg-devel] [PATCH] avfilter: add corr video filter

2022-12-06 Thread Paul B Mahol
Adds yet another metric filter. Patch attached. From 47f30e54b184e4b96f2e9da78671ca5d85c83762 Mon Sep 17 00:00:00 2001 From: Paul B Mahol Date: Tue, 6 Dec 2022 21:31:33 +0100 Subject: [PATCH] avfilter: add corr video filter Signed-off-by: Paul B Mahol --- doc/filters.texi | 22 +++ li

Re: [FFmpeg-devel] [PATCH v2 1/2] avutil: move bswapdsp from avcodec to avutil

2022-12-06 Thread James Almer
On 12/5/2022 7:16 PM, mindm...@gmail.com wrote: diff --git a/libavcodec/bswapdsp.h b/libavutil/bswapdsp.h similarity index 71% rename from libavcodec/bswapdsp.h rename to libavutil/bswapdsp.h index 6f4db66115..b540560d6a 100644 --- a/libavcodec/bswapdsp.h +++ b/libavutil/bswapdsp.h @@ -16,18 +16,

Re: [FFmpeg-devel] [PATCH v2 1/2] avutil: move bswapdsp from avcodec to avutil

2022-12-06 Thread Michael Niedermayer
On Mon, Dec 05, 2022 at 02:16:40PM -0800, mindm...@gmail.com wrote: > From: Mark Reid > > Also renamed bswap_buf to bswap32_buf > --- > configure | 56 --- > libavcodec/4xm.c | 14 ++--- > libavcodec/Makefile

Re: [FFmpeg-devel] [PATCH v2 2/2] libswscale: add AVBSwapDSPContext and use

2022-12-06 Thread Michael Niedermayer
On Mon, Dec 05, 2022 at 02:16:41PM -0800, mindm...@gmail.com wrote: > From: Mark Reid > > There are some places in input.c that could use it too > but they aren't currently being pass the SwsContext > --- > libswscale/output.c | 36 +++ > libswscale/swsc

Re: [FFmpeg-devel] [PATCH] lavc/videotoolbox: validate vt context in the decoder callback

2022-12-06 Thread Alessandro Di Nepi
Got you; giving some context here, and you can find all the details in the ticket #10079 (http://trac.ffmpeg.org/ticket/10079). The issue has been introduced with the commit d7f4ad88a0df3c1339e142957bf2c40cd056b8ce. This patch basically changed: • In the function `videotoolbox_start(AVCodecCont

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/thread: add support for frame threading receive_frame based decoders

2022-12-06 Thread Anton Khirnov
Quoting Timo Rothenpieler (2022-12-06 16:08:49) > On 06/12/2022 15:43, Anton Khirnov wrote: > > Quoting Timo Rothenpieler (2022-12-06 15:39:50) > >> On 06/12/2022 15:37, Anton Khirnov wrote: > >>> Quoting Timo Rothenpieler (2022-12-05 14:39:37) > This is fairly basic and makes a lot of assumpt

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/thread: add support for frame threading receive_frame based decoders

2022-12-06 Thread Timo Rothenpieler
On 06/12/2022 15:43, Anton Khirnov wrote: Quoting Timo Rothenpieler (2022-12-06 15:39:50) On 06/12/2022 15:37, Anton Khirnov wrote: Quoting Timo Rothenpieler (2022-12-05 14:39:37) This is fairly basic and makes a lot of assumptions, but it works for the most simple cases. For one, it only eve

[FFmpeg-devel] [PATCH] avcodec/rawdec: remove redundant code setting frame properties

2022-12-06 Thread James Almer
These same values were already set in the ff_decode_frame_props() call above. Signed-off-by: James Almer --- libavcodec/rawdec.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/libavcodec/rawdec.c b/libavcodec/rawdec.c index 72cdd13916..c20c317fed 100644 --- a/libavcodec/rawdec.c +++ b/lib

[FFmpeg-devel] A question about http connections

2022-12-06 Thread Basel Sayeh
Hello I'm thinking of implementing code to check the server response for the hls/dash encoders (incase the output was a URL). Is it ok to implement it inside hlsenc_io_close/dashenc_io_close, and using blocking ffurl_read? ___ ffmpeg-devel mailing li

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/thread: add support for frame threading receive_frame based decoders

2022-12-06 Thread Anton Khirnov
Quoting Timo Rothenpieler (2022-12-06 15:39:50) > On 06/12/2022 15:37, Anton Khirnov wrote: > > Quoting Timo Rothenpieler (2022-12-05 14:39:37) > >> This is fairly basic and makes a lot of assumptions, but it works > >> for the most simple cases. > >> > >> For one, it only ever fetches exactly one

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/thread: add support for frame threading receive_frame based decoders

2022-12-06 Thread Timo Rothenpieler
On 06/12/2022 15:37, Anton Khirnov wrote: Quoting Timo Rothenpieler (2022-12-05 14:39:37) This is fairly basic and makes a lot of assumptions, but it works for the most simple cases. For one, it only ever fetches exactly one packet per call to receive_frame. Right now it's impossible for there

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/thread: add support for frame threading receive_frame based decoders

2022-12-06 Thread Anton Khirnov
Quoting Timo Rothenpieler (2022-12-05 14:39:37) > This is fairly basic and makes a lot of assumptions, but it works > for the most simple cases. > > For one, it only ever fetches exactly one packet per call to receive_frame. > Right now it's impossible for there to ever be more than one, but the A

[FFmpeg-devel] [PATCH v5 2/2] libavformat/dashenc: Enable HTTP persistent connections for dashenc_delete_file

2022-12-06 Thread Basel Sayeh
Signed-off-by: Basel Sayeh --- libavformat/dashenc.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c index 9c1bcad9e3..ba0eb913a1 100644 --- a/libavformat/dashenc.c +++ b/libavformat/dashenc.c @@ -179,6 +179,7 @@ ty

[FFmpeg-devel] [PATCH v5 1/2] libavformat/hlsenc: Enable HTTP persistent connections for hls_delete_file

2022-12-06 Thread Basel Sayeh
V5 hls_delete_file and dashenc_delete_file functions open a new HTTP connection regardless of the http_persistent value, So change their behaviour to keep http connections open if http_persistent is set Signed-off-by: Basel Sayeh --- libavformat/hlsenc.c | 18 +- 1 file changed,

Re: [FFmpeg-devel] [PATCH v4 1/2] libavformat/hlsenc: Enable HTTP persistent connections for for hls_delete_file

2022-12-06 Thread Basel Sayeh
mistakes keep on happening, please use v5 ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH v4 2/2] libavformat/dashenc: Enable HTTP persistent connections for for dashenc_delete_file

2022-12-06 Thread Basel Sayeh
Signed-off-by: Basel Sayeh --- libavformat/dashenc.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c index 9c1bcad9e3..ba0eb913a1 100644 --- a/libavformat/dashenc.c +++ b/libavformat/dashenc.c @@ -179,6 +179,7 @@ ty

[FFmpeg-devel] [PATCH v4 1/2] libavformat/hlsenc: Enable HTTP persistent connections for for hls_delete_file

2022-12-06 Thread Basel Sayeh
V4 hls_delete_file and dashenc_delete_file functions open a new HTTP connection regardless of the http_persistent value, So change their behaviour to keep http connections open if http_persistent is set Signed-off-by: Basel Sayeh --- libavformat/hlsenc.c | 18 +- 1 file changed,

Re: [FFmpeg-devel] [PATCH v3 1/2] libavformat/hlsenc: Enable HTTP persistent connections

2022-12-06 Thread Basel Sayeh
another mistake, Please see v4 ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 2/6] avcodec/wmadec: clear pts when returning a frame during flush

2022-12-06 Thread James Almer
On 12/6/2022 5:27 AM, Paul B Mahol wrote: On 12/6/22, James Almer wrote: This will be needed for the following commit, after which ff_get_buffer() will stop setting frame->pts to AV_NOPTS_VALUE. This can not be put into generic code? Decoders can set pts manually for frames returned after e

Re: [FFmpeg-devel] [PATCH 5/5] avcodec/mpeg4videodec: duplicate the last decoded frame when the last coded frame was skipped

2022-12-06 Thread James Almer
On 12/6/2022 6:17 AM, Andreas Rheinhardt wrote: James Almer: This ensures the video stream duration is not lost after decoding. Signed-off-by: James Almer --- libavcodec/h263dec.c | 13 + libavcodec/mpegvideo.h | 1 + 2 files changed, 14 insertions(+) diff --git a/libavcode

Re: [FFmpeg-devel] [PATCH 5/5] avcodec/mpeg4videodec: duplicate the last decoded frame when the last coded frame was skipped

2022-12-06 Thread Andreas Rheinhardt
James Almer: > This ensures the video stream duration is not lost after decoding. > > Signed-off-by: James Almer > --- > libavcodec/h263dec.c | 13 + > libavcodec/mpegvideo.h | 1 + > 2 files changed, 14 insertions(+) > > diff --git a/libavcodec/h263dec.c b/libavcodec/h263dec.c >

Re: [FFmpeg-devel] [PATCH v5 2/2] lavc/vaapi_decode: add support for HWACCEL_CAP_RESET_WITHOUT_UNINIT

2022-12-06 Thread Wang, Fei W
On Thu, 2022-12-01 at 09:55 +0800, Fei Wang wrote: > On Mon, 2022-11-28 at 13:20 +, Mark Thompson wrote: > > On 14/11/2022 01:16, Fei Wang wrote: > > > This can fix vp9 decode image corruption when the frame size is > > > change, > > > but the pervious frames still be referenced. > > > > > > S

Re: [FFmpeg-devel] Developer online meeting tomorrow Dec 2 16:00

2022-12-06 Thread Paul B Mahol
On 12/6/22, Anton Khirnov wrote: > Quoting Jean-Baptiste Kempf (2022-12-03 13:08:00) >> Thanks for all who attended online and in real life. > > Thank you for organizing it. > The work involved in making this happen is annoying and largely > thankless, and almost nobody wants to do it, even though

Re: [FFmpeg-devel] Developer online meeting tomorrow Dec 2 16:00

2022-12-06 Thread Anton Khirnov
Quoting Jean-Baptiste Kempf (2022-12-03 13:08:00) > Thanks for all who attended online and in real life. Thank you for organizing it. The work involved in making this happen is annoying and largely thankless, and almost nobody wants to do it, even though these meetings are IMO very valuable and we

Re: [FFmpeg-devel] [PATCH 2/6] avcodec/wmadec: clear pts when returning a frame during flush

2022-12-06 Thread Paul B Mahol
On 12/6/22, James Almer wrote: > This will be needed for the following commit, after which ff_get_buffer() > will > stop setting frame->pts to AV_NOPTS_VALUE. This can not be put into generic code? > > Signed-off-by: James Almer > --- > This one goes before '[PATCH 2/5] Revert "avcodec/decode: