Re: [FFmpeg-devel] [PATCH] libx265: support ATSC A/53 captions

2022-10-24 Thread Eran Kornblau
Ping From: Eran Kornblau Sent: Monday, 17 October 2022 19:29 To: FFmpeg development discussions and patches Subject: [PATCH] libx265: support ATSC A/53 captions Hi, The attached patch adds rendering of ATSC A/53 captions as HEVC SEI messages. The option name/implementation is aligned with the c

[FFmpeg-devel] [PATCH v6 3/3] avcodec/qsvdec: Implement SEI parsing for QSV decoders

2022-10-24 Thread softworkz
From: softworkz Signed-off-by: softworkz --- libavcodec/Makefile | 2 +- libavcodec/qsvdec.c | 321 2 files changed, 322 insertions(+), 1 deletion(-) diff --git a/libavcodec/Makefile b/libavcodec/Makefile index 90c7f113a3..cbddbb0ace 100644 --- a/

[FFmpeg-devel] [PATCH v6 0/3] Implement SEI parsing for QSV decoders

2022-10-24 Thread ffmpegagent
Missing SEI information has always been a major drawback when using the QSV decoders. It turned out that there's a hardly known api method that provides access to all SEI (h264/hevc) or user data (mpeg2video). This allows to get things like closed captions, frame packing, display orientation, HDR

[FFmpeg-devel] [PATCH v6 2/3] avcodec/h264dec: make h264_export_frame_props() accessible

2022-10-24 Thread softworkz
From: softworkz Signed-off-by: softworkz --- libavcodec/h264_sei.c | 197 libavcodec/h264_sei.h | 2 + libavcodec/h264_slice.c | 190 +- 3 files changed, 200 insertions(+), 189 deletions(-) diff --git a/libavcod

[FFmpeg-devel] [PATCH v6 1/3] avcodec/hevcdec: factor out ff_hevc_set_set_to_frame

2022-10-24 Thread softworkz
From: softworkz Signed-off-by: softworkz --- libavcodec/hevc_sei.c | 252 ++ libavcodec/hevc_sei.h | 3 + libavcodec/hevcdec.c | 249 + 3 files changed, 260 insertions(+), 244 deletions(-) diff --git a/libavcode

[FFmpeg-devel] [PATCH 2/2] avcodec/vpp_qsv: Copy side data from input to output frame

2022-10-24 Thread softworkz
From: softworkz Signed-off-by: softworkz --- libavfilter/qsvvpp.c | 6 ++ libavfilter/vf_overlay_qsv.c | 19 +++ 2 files changed, 21 insertions(+), 4 deletions(-) diff --git a/libavfilter/qsvvpp.c b/libavfilter/qsvvpp.c index 8428ee89ab..ae9766d12f 100644 --- a/lib

[FFmpeg-devel] [PATCH 1/2] avutil/frame: Add av_frame_copy_side_data() and av_frame_remove_all_side_data()

2022-10-24 Thread softworkz
From: softworkz Signed-off-by: softworkz Signed-off-by: Anton Khirnov --- doc/APIchanges | 4 +++ libavutil/frame.c | 67 +++-- libavutil/frame.h | 32 ++ libavutil/version.h | 4 +-- 4 files changed, 79 insertions(+), 28 d

[FFmpeg-devel] [PATCH 0/2] QSV Overlay Filter: Copy side data from input to output frame

2022-10-24 Thread ffmpegagent
This is split out from my earlier patchset "SEI parsing for QSV decoders" (https://github.com/ffstaging/FFmpeg/pull/31) as it is only logically related but not technically. The first patch had been reviewed and partially authored by Anton (I have indicated this with a signed-off line, please advis

[FFmpeg-devel] [PATCH 4/6 v2] avcodec/aac_ac3_parser: don't try to sync when the parser is configured to handle complete frames

2022-10-24 Thread James Almer
Should speed up parsing when the frames come from non raw containers. Signed-off-by: James Almer --- The got_frame variable can probably be removed. ff_combine_frame() should return success only if the end of a frame was found. Will look at that later. libavcodec/aac_ac3_parser.c | 5 + 1 f

[FFmpeg-devel] [PATCH] x86/intreadwrite: use intrinsics instead of inline asm for AV_ZERO128

2022-10-24 Thread James Almer
When called inside a loop, the inline asm version results in one pxor unnecessarely emitted per iteration, as the contents of the __asm__() block are opaque to the compiler's instruction scheduler. This is not the case with intrinsics, where pxor will be emitted once with any half decent compiler.

Re: [FFmpeg-devel] [PATCH v14 9/9] avcodec/evc: Changes in Changelog and MAINTAINERS files

2022-10-24 Thread James Almer
On 10/24/2022 12:56 PM, Lynne wrote: Oct 24, 2022, 09:42 by d.kozin...@samsung.com: - Changelog update - MAINTAINERS update Signed-off-by: Dawid Kozinski --- Changelog | 3 ++- MAINTAINERS | 5 + 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/Changelog b/Changelog ind

Re: [FFmpeg-devel] [PATCH v14 9/9] avcodec/evc: Changes in Changelog and MAINTAINERS files

2022-10-24 Thread Lynne
Oct 24, 2022, 09:42 by d.kozin...@samsung.com: > - Changelog update > - MAINTAINERS update > > Signed-off-by: Dawid Kozinski > --- > Changelog | 3 ++- > MAINTAINERS | 5 + > 2 files changed, 7 insertions(+), 1 deletion(-) > > diff --git a/Changelog b/Changelog > index ec9de1bd85..19e9ae3b

Re: [FFmpeg-devel] [PATCH 1/7] avcodec/snow_dwt: Fix left shifts of negative numbers

2022-10-24 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Affected the vsynth(1|2|_lena)-snow(|-hpel) tests. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/snow_dwt.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/libavcodec/snow_dwt.c b/libavcodec/snow_dwt.c > index 18b315ef66..965f409

Re: [FFmpeg-devel] [PATCH v2 03/10] avcodec: add bitstream parser for H266/VVC

2022-10-24 Thread James Almer
On 10/24/2022 11:06 AM, Thomas Siedel wrote: +static int combine_au(AVCodecParserContext *ctx, AVCodecContext *avctx, + const uint8_t **buf, int *buf_size) +{ This is being called only when you first assembled AUs from what's assumed to be raw input. When PARSER_FLAG_COMPL

Re: [FFmpeg-devel] [PATCH v2 08/10] avcodec: add external encoder libvvenc for H266/VVC

2022-10-24 Thread quietvoid
On 24/10/2022 10.06, Thomas Siedel wrote: Add external encoder VVenC for H266/VVC encoding. Register new encoder libvvencc Add libvvenc to wrap the vvenc interface into ffmpeg libvvenc implements encoder option: preset,qp,period,subjopt,vvenc-params,levelidc,tier Enable encoder by adding --ena

Re: [FFmpeg-devel] [PATCH v1 03/11] avcodec: enable cbs for H266/VVC

2022-10-24 Thread Thomas Siedel
On Thu, 20 Oct 2022 at 01:07, James Almer wrote: > On 10/19/2022 4:25 AM, thomas...@spin-digital.com wrote: > > From: Thomas Siedel > > > > Add ff_cbs_type_h266 to cbs types tables and AV_CODEC_ID_H266 to cbs > codec ids. > > Change CBS_MAX_UNIT_TYPES to 8 as VVC implements 8 different slice typ

Re: [FFmpeg-devel] [PATCH v1 06/11] avformat: add demuxer and probe support for H266/VVC

2022-10-24 Thread Thomas Siedel
On Wed, 19 Oct 2022 at 14:07, Michael Niedermayer wrote: > On Wed, Oct 19, 2022 at 09:25:03AM +0200, thomas...@spin-digital.com > wrote: > > From: Thomas Siedel > > > > Add demuxer to probe raw vvc and parse vvcc byte stream format. > > > > Signed-off-by: Thomas Siedel > > --- > > libavformat/

[FFmpeg-devel] [PATCH v2 07/10] avcodec: add external decoder libvvdec for H266/VVC

2022-10-24 Thread Thomas Siedel
Add external decoder VVdeC for H266/VVC decoding. Register new decoder libvvdec Add vvc_parse_extradata to support parse/probe of vvcC stream input Add vvc_paramset that implements the parser of vvcC configuration boxes Add libvvdec to wrap the vvdec interface into ffmpeg libvvdec implements decode

[FFmpeg-devel] [PATCH v2 10/10] avcodec: increase minor version for H266/VVC

2022-10-24 Thread Thomas Siedel
Increase avcodec minor version for vvc support. Signed-off-by: Thomas Siedel --- libavcodec/version.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/version.h b/libavcodec/version.h index f8abc803b6..86ac0f3871 100644 --- a/libavcodec/version.h +++ b/libavcodec/ve

[FFmpeg-devel] [PATCH v2 08/10] avcodec: add external encoder libvvenc for H266/VVC

2022-10-24 Thread Thomas Siedel
Add external encoder VVenC for H266/VVC encoding. Register new encoder libvvencc Add libvvenc to wrap the vvenc interface into ffmpeg libvvenc implements encoder option: preset,qp,period,subjopt,vvenc-params,levelidc,tier Enable encoder by adding --enable-libvvenc in configure step Signed-off-by:

[FFmpeg-devel] [PATCH v2 06/10] avformat: add muxer support for H266/VVC

2022-10-24 Thread Thomas Siedel
Add muxer for vvcc byte stream format. Add AV_CODEC_ID_VVC to ff_mp4_obj_type Add AV_CODEC_ID_VVC to ISO Media codec (VvcConfigurationBox vvi1, vvc1 defined in ISO/IEC 14496-15:2021) Add VvcConfigurationBox vvcC which extends FullBox type in ISO/IEC 14496-15:2021 Add ff_vvc_muxer to RAW muxers Si

[FFmpeg-devel] [PATCH v2 05/10] avformat: add demuxer and probe support for H266/VVC

2022-10-24 Thread Thomas Siedel
Add demuxer to probe raw vvc and parse vvcc byte stream format. Signed-off-by: Thomas Siedel --- libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/demux.c | 7 +- libavformat/vvc.c| 919 +++ libavformat/vvc.h

[FFmpeg-devel] [PATCH v2 09/10] avformat: add ts stream types for H266/VVC

2022-10-24 Thread Thomas Siedel
Add transport stream stream type 0x33 for vvc. Add STREAM_TYPE_VIDEO_VVC to MPEG-1/2 and MPEG-2 transport stream Add basic transport stream support for TS mux/demux Signed-off-by: Thomas Siedel --- configure | 2 +- libavformat/mpeg.c | 3 ++ libavformat/mpeg.h | 1 +

[FFmpeg-devel] [PATCH v2 04/10] avcodec: add MP4 to annexb support for H266/VVC

2022-10-24 Thread Thomas Siedel
Add parser for VVC MP4 to Annex B byte stream format. Signed-off-by: Thomas Siedel --- configure| 1 + libavcodec/Makefile | 2 + libavcodec/bitstream_filters.c | 2 + libavcodec/h266_metadata_bsf.c | 145 ++ libavcodec/vvc_mp4toannexb_b

[FFmpeg-devel] [PATCH v2 03/10] avcodec: add bitstream parser for H266/VVC

2022-10-24 Thread Thomas Siedel
Add nal parser ff_vvc_parser to parse vvc elementary bitstreams. Signed-off-by: Thomas Siedel --- configure| 3 + libavcodec/Makefile | 2 + libavcodec/h2645_parse.c | 71 - libavcodec/parsers.c | 1 + libavcodec/vvc_parser.c | 588 +++

[FFmpeg-devel] [PATCH v2 01/10] avcodec: add enum types for H266/VVC

2022-10-24 Thread Thomas Siedel
Add needed types as nal unit types, slice types and vvc typedefs needed for parsing vvc high-level syntax Signed-off-by: Thomas Siedel --- libavcodec/vvc.h | 142 +++ 1 file changed, 142 insertions(+) create mode 100644 libavcodec/vvc.h diff --git a

[FFmpeg-devel] [PATCH v2 00/10] Add support for H266/VVC

2022-10-24 Thread Thomas Siedel
This patch set adds H266/VVC support. This includes parsing, muxing, demuxing, decoding and encoding. Decoding is done using the external library VVdeC (https://github.com/fraunhoferhhi/vvdec.git) and can be enabled with --enable-libvvdec. Encoding is done using the external library VVenC (https://

Re: [FFmpeg-devel] [PATCH v13 2/9] avcodec/evc_parser: Added parser implementaion for EVC format

2022-10-24 Thread James Almer
On 10/24/2022 7:16 AM, Dawid Kozinski/Multimedia (PLT) /SRPOL/Staff Engineer/Samsung Electronics wrote: The parser should not return individual NAL units, but complete frames (access units in HEVC terminology, don't know if EVC defines something similar). [REPLY] Current EVC decoder implementati

Re: [FFmpeg-devel] [PATCH 4/4] sw_scale: Add specializations for hscale 16 to 19

2022-10-24 Thread Martin Storsjö
On Mon, 17 Oct 2022, Hubert Mazur wrote: Provide arm64 neon optimized implementations for hscale16To19 with filter sizes 4, 8 and X4. The tests and benchmarks run on AWS Graviton 2 instances. The results from a checkasm tool are shown below. hscale_16_to_19__fs_4_dstW_512_c: 6216.0 hscale_16_t

Re: [FFmpeg-devel] [PATCH 1/4] sw_scale: Add specializations for hscale 8 to 19

2022-10-24 Thread Martin Storsjö
On Mon, 17 Oct 2022, Hubert Mazur wrote: Add arm64 neon implementations for hscale 8 to 19 with filter sizes 4, 4X and 8. Both implementations are based on very similar ones dedicated to hscale 8 to 15. The major changes refer to saving the data - instead of writing the result as int16_t it is d

Re: [FFmpeg-devel] [PATCH v3] lavc/aarch64: add hevc horizontal qpel/uni/bi

2022-10-24 Thread Martin Storsjö
On Tue, 11 Oct 2022, J. Dekker wrote: checkasm benchmark on Ampere Altra (Neoverse N1): put_hevc_qpel_bi_h4_8_c: 170.7 put_hevc_qpel_bi_h4_8_neon: 64.5 put_hevc_qpel_bi_h6_8_c: 373.7 put_hevc_qpel_bi_h6_8_neon: 130.2 put_hevc_qpel_bi_h8_8_c: 662.0 put_hevc_qpel_bi_h8_8_neon: 138.5 put_hevc_qpel

Re: [FFmpeg-devel] [PATCH v13 2/9] avcodec/evc_parser: Added parser implementaion for EVC format

2022-10-24 Thread Dawid Kozinski/Multimedia (PLT) /SRPOL/Staff Engineer/Samsung Electronics
Hi, Anthon, thank you for your review. I've just submitted to the patchwork a new patchset (v14 https://patchwork.ffmpeg.org/project/ffmpeg/list/?series=7794) containing changes following your review. If something still needs to be changed please let me know. I will be grateful for your feedback.

Re: [FFmpeg-devel] [PATCH] avcodec/mss2: calculate draw region and revise split position

2022-10-24 Thread Peter Ross
On Thu, Oct 20, 2022 at 07:59:25PM +1100, Peter Ross wrote: > for videos with wmv9 rectangles, the region drawn by ff_mss12_decode_rect > may be less than the entire video area. the wmv9 rectangles are used to > calculate the ff_mss12_decode_rect draw region. > > Fixes tickets #3255 and #4043 > --

Re: [FFmpeg-devel] [PATCHv3] avcodec/jpegtables: remove duplicate luma and chroma quantization tables

2022-10-24 Thread Peter Ross
On Tue, Oct 18, 2022 at 08:06:02PM +1100, Peter Ross wrote: > Duplicates of the standard JPEG quantization tables were found in the > AGM, MSS34(dsp), NUV and VP31 codecs. This patch elimates those duplicates, > placing a single copy in jpegquanttables.c. > --- > added FF_VISIBILITY_xxx_HIDDEN stat

[FFmpeg-devel] [PATCH v14 9/9] avcodec/evc: Changes in Changelog and MAINTAINERS files

2022-10-24 Thread Dawid Kozinski
- Changelog update - MAINTAINERS update Signed-off-by: Dawid Kozinski --- Changelog | 3 ++- MAINTAINERS | 5 + 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/Changelog b/Changelog index ec9de1bd85..19e9ae3b1f 100644 --- a/Changelog +++ b/Changelog @@ -45,6 +45,8 @@ version

[FFmpeg-devel] [PATCH v14 8/9] avformat/mov_demuxer: Extended MOV demuxer to handle EVC video content

2022-10-24 Thread Dawid Kozinski
- Added evc extension to the list of extensions for ff_mov_demuxer Signed-off-by: Dawid Kozinski --- libavformat/demux.c | 1 + libavformat/mov.c | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/libavformat/demux.c b/libavformat/demux.c index 2dfd82a63c..f3ebe4d09b 100644

[FFmpeg-devel] [PATCH v14 7/9] avformat/mov_muxer: Extended MOV muxer to handle EVC video content

2022-10-24 Thread Dawid Kozinski
- Changes in mov_write_video_tag function to handle EVC elementary stream - Provided structure EVCDecoderConfigurationRecord that specifies the decoder configuration information for ISO/IEC 23094-1 video content Signed-off-by: Dawid Kozinski --- libavformat/Makefile| 2 +- libavformat/evc

[FFmpeg-devel] [PATCH v14 6/9] avcodec/evc_decoder: Provided support for EVC decoder

2022-10-24 Thread Dawid Kozinski
- Added EVC decoder wrapper - Changes in project configuration file and libavcodec Makefile - Added documentation for xevd wrapper Signed-off-by: Dawid Kozinski --- configure | 4 + doc/decoders.texi | 24 +++ doc/general_contents.texi | 10 +- libavcodec/Makefile

[FFmpeg-devel] [PATCH v14 5/9] avcodec/evc_encoder: Provided support for EVC encoder

2022-10-24 Thread Dawid Kozinski
- Added EVC encoder wrapper - Changes in project configuration file and libavcodec Makefile - Added documentation for xeve wrapper Signed-off-by: Dawid Kozinski --- configure | 4 + doc/encoders.texi | 69 + doc/general_contents.texi | 11 + libavcodec/Makefile

[FFmpeg-devel] [PATCH v14 4/9] avformat/evc_demuxer: Added demuxer to handle reading EVC video files

2022-10-24 Thread Dawid Kozinski
- Provided AVInputFormat structure describing EVC input format (ff_evc_demuxer) Signed-off-by: Dawid Kozinski --- libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/evcdec.c | 124 +++ 3 files changed, 126 insertions(+) create

[FFmpeg-devel] [PATCH v14 3/9] avformat/evc_muxer: Added muxer to handle writing EVC encoded data into file or output bytestream

2022-10-24 Thread Dawid Kozinski
- Provided AVOutputFormat structure describing EVC output format (ff_evc_muxer) - Added documentation for EVC muxer Signed-off-by: Dawid Kozinski --- doc/muxers.texi | 6 ++ libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/rawenc.c | 13

[FFmpeg-devel] [PATCH v14 2/9] avcodec/evc_parser: Added parser implementation for EVC format

2022-10-24 Thread Dawid Kozinski
Signed-off-by: Dawid Kozinski --- libavcodec/Makefile | 1 + libavcodec/evc.h| 155 + libavcodec/evc_parser.c | 740 libavcodec/parsers.c| 1 + 4 files changed, 897 insertions(+) create mode 100644 libavcodec/evc.h create mode

[FFmpeg-devel] [PATCH v14 1/9] avcodec/evc: MPEG-5 EVC codec registration

2022-10-24 Thread Dawid Kozinski
Added prerequisites that must be met before providing support for the MPEG-5 EVC codec - Added new entry to codec IDs list - Added new entry to the codec descriptor list - Bumped libavcodec minor version - Added profiles for EVC codec Signed-off-by: Dawid Kozinski --- libavcodec/avcodec.h|