Re: [FFmpeg-devel] [PATCH] avcodec: add a bsf to reorder DTS into PTS

2022-10-03 Thread James Almer
On 9/28/2022 12:39 PM, Anton Khirnov wrote: Quoting James Almer (2022-09-23 16:27:32) On 9/23/2022 10:06 AM, Anton Khirnov wrote: +static int dts2pts_filter(AVBSFContext *ctx, AVPacket *out) +{ +DTS2PTSContext *s = ctx->priv_data; +DTS2PTSNode *poc_node = NULL, *next[2] = { NULL, NULL }

Re: [FFmpeg-devel] [PATCH 1/1] Enable building with WSL and MSVC

2022-10-03 Thread Julio C. Rocha
On Mon, Oct 3, 2022 at 8:21 AM Pierre-Anthony Lemieux wrote: > On Mon, Oct 3, 2022 at 1:11 AM Julio C. Rocha wrote: > > > > On Sun, Oct 2, 2022 at 5:19 PM Pierre-Anthony Lemieux > > wrote: > > > > > On Sun, Oct 2, 2022 at 5:14 PM Timo Rothenpieler < > t...@rothenpieler.org> > > > wrote: > > > >

Re: [FFmpeg-devel] [PATCH 1/7] avcodec/sunrast: Use ptrdiff_t for stride

2022-10-03 Thread Andreas Rheinhardt
James Almer: > On 9/30/2022 2:02 PM, Andreas Rheinhardt wrote: >> Fixes segfaults with negative linesizes; in particular, >> this affected the sunraster-(1|8|24)bit-(raw|rle) and >> sunraster-8bit_gray-raw FATE tests. >> >> Signed-off-by: Andreas Rheinhardt >> --- >>   libavcodec/sunrast.c | 5 +++

Re: [FFmpeg-devel] [PATCH 1/7] avcodec/sunrast: Use ptrdiff_t for stride

2022-10-03 Thread James Almer
On 9/30/2022 2:02 PM, Andreas Rheinhardt wrote: Fixes segfaults with negative linesizes; in particular, this affected the sunraster-(1|8|24)bit-(raw|rle) and sunraster-8bit_gray-raw FATE tests. Signed-off-by: Andreas Rheinhardt --- libavcodec/sunrast.c | 5 +++-- 1 file changed, 3 insertions

[FFmpeg-devel] [PATCH 9/9] avcodec/opus: Move Silk declarations to a new header, opus_silk.h

2022-10-03 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/opus.h | 21 - libavcodec/opus_silk.c | 2 ++ libavcodec/opus_silk.h | 48 ++ libavcodec/opusdec.c | 2 ++ libavcodec/opusenc_utils.h | 3 +++ 5 files changed, 55 inserti

[FFmpeg-devel] [PATCH 8/9] avcodec/opus: Move defines to better places

2022-10-03 Thread Andreas Rheinhardt
Move ROUND_MUL* macros to their only users and the Celt macros to opus_celt.h. Also improve the other headers a bit while at it. Signed-off-by: Andreas Rheinhardt --- libavcodec/opus.h| 9 - libavcodec/opus_celt.c | 2 ++ libavcodec/opus_celt.h | 10 -- libavcodec/o

[FFmpeg-devel] [PATCH 7/9] avcodec/opus: Move remaining celt declarations to opus_celt.h

2022-10-03 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/opus.h | 8 libavcodec/opus_celt.h | 11 +-- 2 files changed, 9 insertions(+), 10 deletions(-) diff --git a/libavcodec/opus.h b/libavcodec/opus.h index c88bb89dde..023bc9daa1 100644 --- a/libavcodec/opus.h +++ b/libavcodec/o

[FFmpeg-devel] [PATCH 6/9] avcodec/opus_celt, opus_pvq: Move CeltPVQ typedef to opus_pvq.h

2022-10-03 Thread Andreas Rheinhardt
It is more natural that way. Signed-off-by: Andreas Rheinhardt --- libavcodec/opus_celt.h | 4 +--- libavcodec/opus_pvq.h | 4 ++-- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/libavcodec/opus_celt.h b/libavcodec/opus_celt.h index 19cf617652..c812b6645c 100644 --- a/libavcodec

[FFmpeg-devel] [PATCH 5/9] avcodec/opus_celt: Break cyclic inlusion of opus_celt.h<->opus_pvq.h

2022-10-03 Thread Andreas Rheinhardt
Simply don't include opus_pvq.h in opus_celt.h: The latter only uses pointers to CeltPVQ. Signed-off-by: Andreas Rheinhardt --- libavcodec/opus.c | 1 + libavcodec/opus_celt.h | 1 - 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/opus.c b/libavcodec/opus.c index 791

[FFmpeg-devel] [PATCH 4/9] avcodec/opus: Move stuff shared by decoder and parser to a new file

2022-10-03 Thread Andreas Rheinhardt
opus.h (which is used by all the Opus code) currently includes several structures only used by the parser and the decoder; several elements of OpusContext are even only used by the decoder. This commit therefore moves the part of OpusContext that is shared between these two components (and used by

[FFmpeg-devel] [PATCH 3/9] avcodec/opus: Move OpusStreamContext to its only user

2022-10-03 Thread Andreas Rheinhardt
Namely opusdec.c. Signed-off-by: Andreas Rheinhardt --- libavcodec/opus.h| 52 +--- libavcodec/opusdec.c | 47 +++ 2 files changed, 48 insertions(+), 51 deletions(-) diff --git a/libavcodec/opus.h b/libavcodec/opus.

[FFmpeg-devel] [PATCH 2/9] avcodec/opustab: Avoid indirection to access ff_celt_window

2022-10-03 Thread Andreas Rheinhardt
Currently, it is accessed via a pointer (ff_celt_window) exported from opustab.h which points inside a static array (ff_celt_window_padded) in opustab.h. Instead export ff_celt_window_padded directly and make opustab.h a static const pointer pointing inside ff_celt_window_padded. Also mark all the

[FFmpeg-devel] [PATCH 1/9] avutil/attributes_internal: Add visibility pragma

2022-10-03 Thread Andreas Rheinhardt
GCC 4.0 not only added a visibility attribute, but also a pragma to set it for a whole region of code.* This commit exposes this via macros. *: See https://gcc.gnu.org/gcc-4.0/changes.html Signed-off-by: Andreas Rheinhardt --- libavutil/attributes_internal.h | 4 1 file changed, 4 insertio

Re: [FFmpeg-devel] [PATCH 1/7] avcodec/sunrast: Use ptrdiff_t for stride

2022-10-03 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Fixes segfaults with negative linesizes; in particular, > this affected the sunraster-(1|8|24)bit-(raw|rle) and > sunraster-8bit_gray-raw FATE tests. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/sunrast.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions

Re: [FFmpeg-devel] [PATCH] avcodec/sbcdec: Remove always-false check

2022-10-03 Thread Andreas Rheinhardt
Andreas Rheinhardt: > We never guard against a user freeing/stealing the private context; > and returning AVERROR(EIO) is inappropriate. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/sbcdec.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/libavcodec/sbcdec.c b/libavcodec/

[FFmpeg-devel] Need to reduce size of ffmpeg.exe for version 5.0.1

2022-10-03 Thread Kumar, Rahul
Hi Team, We are working on a prototype which converts RTSP streams to HLS using ffmpeg transcoder. We are using below ffmpeg command to convert RTSP to HLS : cmd:- ffmpeg.exe -rtsp_transport tcp -re -i rtsp://:@172.31.67.223:554/axis-media/media.amp?videocodec=h264

[FFmpeg-devel] [PATCH] libavformat/mov: Add support for exporting poster time.

2022-10-03 Thread Bryce Chester Newman
From: Bryce Chester Newman Export the poster_time_location if available. The poster_time_location is calculated using the poster_time / time_scale = X seconds. The value of poster_time_location indicates where in the video the poster frame is. Addresses feedback from https://www.mail-archive.com

Re: [FFmpeg-devel] [PATCH 1/1] Enable building with WSL and MSVC

2022-10-03 Thread Pierre-Anthony Lemieux
On Mon, Oct 3, 2022 at 1:11 AM Julio C. Rocha wrote: > > On Sun, Oct 2, 2022 at 5:19 PM Pierre-Anthony Lemieux > wrote: > > > On Sun, Oct 2, 2022 at 5:14 PM Timo Rothenpieler > > wrote: > > > > > > On 03.10.2022 01:47, Julio C. Rocha wrote: > > > > --- > > > > configure | 7 ++- > > > > 1

[FFmpeg-devel] [PATCH] riscv: fix scalar product initialisation

2022-10-03 Thread remi
From: Rémi Denis-Courmont VSETVLI xd, x0, ...' has rather nonobvious semantics: - If xd is x0, then it preserves the current vector length. - If xd is not x0, it sets the vector length to the supported maximum. Also somewhat confusingly, while VMV.X.S always does its thing regardless of the sele

Re: [FFmpeg-devel] [PATCH] avcodec/bonk: Check step

2022-10-03 Thread Michael Niedermayer
On Sun, Oct 02, 2022 at 07:13:39PM +0300, Rémi Denis-Courmont wrote: > Le sunnuntaina 2. lokakuuta 2022, 18.43.23 EEST Michael Niedermayer a écrit : > > Fixes: signed integer overflow: 2040812214 + 255101526 cannot be represented > > in type 'int' Fixes: > > 51323/clusterfuzz-testcase-minimized-ffm

[FFmpeg-devel] [PATCH v2 7/7] aarch64: me_cmp: Improve scheduling in vsse_intra8

2022-10-03 Thread Grzegorz Bernacki
From: Martin Storsjö Before: Cortex A53A72A73 vsse_5_neon: 74.7 31.5 26.0 After: vsse_5_neon: 62.7 32.5 25.7 --- libavcodec/aarch64/me_cmp_neon.S | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/libavcodec/aarch64/me_cmp_neon.S b/libavcodec/aa

[FFmpeg-devel] [PATCH v2 6/7] lavc/aarch64: Add neon implementation for vsse_intra8

2022-10-03 Thread Grzegorz Bernacki
Provide optimized implementation for vsse_intra8 for arm64. Performance tests are shown below. - vsse_5_c: 87.7 - vsse_5_neon: 26.2 Benchmarks and tests are run with checkasm tool on AWS Graviton 3. --- libavcodec/aarch64/me_cmp_init_aarch64.c | 4 ++ libavcodec/aarch64/me_cmp_neon.S |

[FFmpeg-devel] [PATCH v2 5/7] lavc/aarch64: Provide optimized implementation of vsse8 for arm64.

2022-10-03 Thread Grzegorz Bernacki
Provide optimized implementation of vsse8 for arm64. Performance comparison tests are shown below. - vsse_1_c: 141.5 - vsse_1_neon: 32.5 Benchmarks and tests are run with checkasm tool on AWS Graviton 3. Signed-off-by: Grzegorz Bernacki --- libavcodec/aarch64/me_cmp_init_aarch64.c | 5 ++ lib

[FFmpeg-devel] [PATCH v2 4/7] lavc/aarch64: Provide neon implementation of nsse8

2022-10-03 Thread Grzegorz Bernacki
Add vectorized implementation of nsse8 function. Performance comparison tests are shown below. - nsse_1_c: 256.0 - nsse_1_neon: 82.7 Benchmarks and tests run with checkasm tool on AWS Graviton 3. Signed-off-by: Grzegorz Bernacki --- libavcodec/aarch64/me_cmp_init_aarch64.c | 15 libavcode

[FFmpeg-devel] [PATCH v2 3/7] aarch64: me_cmp: Fix up the prologue of ff_pix_abs8_xy2_neon

2022-10-03 Thread Grzegorz Bernacki
From: Martin Storsjö This initializes things properly if this were to be called with h < 4. --- libavcodec/aarch64/me_cmp_neon.S | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/aarch64/me_cmp_neon.S b/libavcodec/aarch64/me_cmp_neon.S index 3662419edf..cfba3eb33

[FFmpeg-devel] [PATCH v2 2/7] aarch64: me_cmp: Improve scheduling in ff_pix_abs8_y2_neon

2022-10-03 Thread Grzegorz Bernacki
From: Martin Storsjö Before: Cortex A53A72A73 pix_abs_1_2_neon: 73.7 31.0 25.7 After: pix_abs_1_2_neon: 61.7 30.2 24.7 Signed-off-by: Martin Storsjö --- libavcodec/aarch64/me_cmp_neon.S | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/

[FFmpeg-devel] [PATCH v2 1/7] lavc/aarch64: Add neon implementation for pix_abs8 functions.

2022-10-03 Thread Grzegorz Bernacki
Provide optimized implementation of pix_abs8 function for arm64. Performance comparison tests are shown below: pix_abs_1_1_c: 162.5 pix_abs_1_1_neon: 27.0 pix_abs_1_2_c: 174.0 pix_abs_1_2_neon: 23.5 pix_abs_1_3_c: 203.2 pix_abs_1_3_neon: 34.7 Benchmarks and tests are run with checkasm tool on AWS

[FFmpeg-devel] [PATCH v2 0/7] arm64 neon implementation for 8bits functions

2022-10-03 Thread Grzegorz Bernacki
Changes since v1: - changed tabs to spaces - modified branch instruction in vsse8 - apply Martin's patches with improved instructions scheduling Grzegorz Bernacki (4): lavc/aarch64: Add neon implementation for pix_abs8 functions. lavc/aarch64: Provide neon implementation of nsse8 lavc/aarc

Re: [FFmpeg-devel] [PATCH] Encrypted SMPTE DC MXF - additional UL needed to unpack EKLV packet

2022-10-03 Thread Richard Ayres
Thanks, Pierre-Anthony. I've updated the patch to remove the unnecessary UL and it's now using mxf_match_uid() to detect the EKLV packet. Signed-off-by: Richard Ayres --- libavformat/mxfdec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/mxfdec.c b/libavfor

[FFmpeg-devel] [PATCH] libavcodec: Fix a comment typo

2022-10-03 Thread Martin Storsjö
Signed-off-by: Martin Storsjö --- libavcodec/packet.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/packet.h b/libavcodec/packet.h index 404d520071..f28e7e7011 100644 --- a/libavcodec/packet.h +++ b/libavcodec/packet.h @@ -161,7 +161,7 @@ enum AVPacketSideDataType

Re: [FFmpeg-devel] [PATCH 1/1] Enable building with WSL and MSVC

2022-10-03 Thread Julio C. Rocha
On Sun, Oct 2, 2022 at 5:19 PM Pierre-Anthony Lemieux wrote: > On Sun, Oct 2, 2022 at 5:14 PM Timo Rothenpieler > wrote: > > > > On 03.10.2022 01:47, Julio C. Rocha wrote: > > > --- > > > configure | 7 ++- > > > 1 file changed, 6 insertions(+), 1 deletion(-) > > > > > > diff --git a/conf

Re: [FFmpeg-devel] [PATCH 1/1] Enable building with WSL and MSVC

2022-10-03 Thread Julio C. Rocha
On Sun, Oct 2, 2022 at 5:14 PM Timo Rothenpieler wrote: > On 03.10.2022 01:47, Julio C. Rocha wrote: > > --- > > configure | 7 ++- > > 1 file changed, 6 insertions(+), 1 deletion(-) > > > > diff --git a/configure b/configure > > index 6712d045d9..f5f5eb29dd 100755 > > --- a/configure > >