[FFmpeg-devel] [PATCH 2/2] avformat/mp3dec: remove a call to avio_tell()

2022-09-24 Thread Zhao Zhili
From: Zhao Zhili --- libavformat/mp3dec.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/libavformat/mp3dec.c b/libavformat/mp3dec.c index a9e494452d..05c13228bc 100644 --- a/libavformat/mp3dec.c +++ b/libavformat/mp3dec.c @@ -424,15 +424,14 @@ static int mp3_read_h

[FFmpeg-devel] [PATCH 1/2] avformat/mp3dec: avoid seek back and forth

2022-09-24 Thread Zhao Zhili
From: Zhao Zhili avio_seek() is called inside check(). Seeking to 'off' then seeking to 'off + i' is unefficient, and it can loop 64 * 1024 times in the worst case. When probe a malformed file over HTTP, it looks like stucked forvever. ffio_ensure_seekback() doesn't solve the issue when the strea

[FFmpeg-devel] [PATCH v3 54/54] avutil/samplefmt: document missing argument

2022-09-24 Thread Marvin Scholz
--- libavutil/samplefmt.h | 1 + 1 file changed, 1 insertion(+) diff --git a/libavutil/samplefmt.h b/libavutil/samplefmt.h index 1999c9bca6..6bad0e254a 100644 --- a/libavutil/samplefmt.h +++ b/libavutil/samplefmt.h @@ -213,6 +213,7 @@ int av_samples_fill_arrays(uint8_t **audio_data, int *linesiz

[FFmpeg-devel] [PATCH v3 53/54] avutil/aes_ctr: document some missing arguments

2022-09-24 Thread Marvin Scholz
--- libavutil/aes_ctr.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/libavutil/aes_ctr.h b/libavutil/aes_ctr.h index 4d80c71326..598926fdcf 100644 --- a/libavutil/aes_ctr.h +++ b/libavutil/aes_ctr.h @@ -44,17 +44,23 @@ struct AVAESCTR *av_aes_ctr_alloc(void); /** * Initialize an

[FFmpeg-devel] [PATCH v3 52/54] avutil/aes: document some missing arguments

2022-09-24 Thread Marvin Scholz
--- libavutil/aes.h | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/libavutil/aes.h b/libavutil/aes.h index d243286c86..4e73473688 100644 --- a/libavutil/aes.h +++ b/libavutil/aes.h @@ -42,6 +42,9 @@ struct AVAES *av_aes_alloc(void); /** * Initialize an AVAES context

[FFmpeg-devel] [PATCH v3 51/54] avcodec/bsf: document missing arguments

2022-09-24 Thread Marvin Scholz
--- libavcodec/bsf.h | 4 1 file changed, 4 insertions(+) diff --git a/libavcodec/bsf.h b/libavcodec/bsf.h index 69d91a16ab..17fa6141ee 100644 --- a/libavcodec/bsf.h +++ b/libavcodec/bsf.h @@ -164,6 +164,8 @@ int av_bsf_alloc(const AVBitStreamFilter *filter, AVBSFContext **ctx); /** * Pr

[FFmpeg-devel] [PATCH v3 50/54] swscale: document some missing arguments

2022-09-24 Thread Marvin Scholz
--- libswscale/swscale.h | 10 ++ 1 file changed, 10 insertions(+) diff --git a/libswscale/swscale.h b/libswscale/swscale.h index 9794f6a258..5410b9e0d2 100644 --- a/libswscale/swscale.h +++ b/libswscale/swscale.h @@ -234,6 +234,7 @@ int sws_scale(struct SwsContext *c, const uint8_t *cons

[FFmpeg-devel] [PATCH v3 49/54] avutil/imgutils: document some missing arguments

2022-09-24 Thread Marvin Scholz
--- libavutil/imgutils.h | 20 1 file changed, 20 insertions(+) diff --git a/libavutil/imgutils.h b/libavutil/imgutils.h index be53335568..e10ac14952 100644 --- a/libavutil/imgutils.h +++ b/libavutil/imgutils.h @@ -48,6 +48,7 @@ * component in the plane with the max pixel s

[FFmpeg-devel] [PATCH v3 48/54] avutil/crc: Add doxy for missing arguments

2022-09-24 Thread Marvin Scholz
--- libavutil/crc.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavutil/crc.h b/libavutil/crc.h index 24a2e3caed..7f59812a18 100644 --- a/libavutil/crc.h +++ b/libavutil/crc.h @@ -84,7 +84,10 @@ const AVCRC *av_crc_get_table(AVCRCId crc_id); /** * Calculate the CRC of a block. +

[FFmpeg-devel] [PATCH v3 47/54] avutil/des: Add doxy for missing arguments

2022-09-24 Thread Marvin Scholz
Additionally reorder so that the arguments list matches the order of the arguments in the function declaration. --- libavutil/des.h | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/libavutil/des.h b/libavutil/des.h index 4cf11f5bca..3a3e6fa47c 100644 --- a/libavutil/des.

[FFmpeg-devel] [PATCH v3 46/54] avutil/avstring: Add doxy for missing argument

2022-09-24 Thread Marvin Scholz
--- libavutil/avstring.h | 1 + 1 file changed, 1 insertion(+) diff --git a/libavutil/avstring.h b/libavutil/avstring.h index fae446c302..74aa4cd0e4 100644 --- a/libavutil/avstring.h +++ b/libavutil/avstring.h @@ -135,6 +135,7 @@ size_t av_strlcatf(char *dst, size_t size, const char *fmt, ...) a

[FFmpeg-devel] [PATCH v3 45/54] avutil/frame: Add doxy for missing argument

2022-09-24 Thread Marvin Scholz
--- libavutil/frame.h | 1 + 1 file changed, 1 insertion(+) diff --git a/libavutil/frame.h b/libavutil/frame.h index 6d9563bc5d..e60a82f6c0 100644 --- a/libavutil/frame.h +++ b/libavutil/frame.h @@ -864,6 +864,7 @@ int av_frame_copy_props(AVFrame *dst, const AVFrame *src); /** * Get the buffer

[FFmpeg-devel] [PATCH v3 44/54] avutil/rc4: Add doxy for missing arguments

2022-09-24 Thread Marvin Scholz
--- libavutil/rc4.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavutil/rc4.h b/libavutil/rc4.h index 029cd2ad58..bf0ca6e942 100644 --- a/libavutil/rc4.h +++ b/libavutil/rc4.h @@ -42,6 +42,8 @@ AVRC4 *av_rc4_alloc(void); /** * @brief Initializes an AVRC4 context. * + * @param d p

[FFmpeg-devel] [PATCH v3 43/54] avutil/uuid: Remove bogus doxy return doc

2022-09-24 Thread Marvin Scholz
The function returns void and no error code. --- libavutil/uuid.h | 1 - 1 file changed, 1 deletion(-) diff --git a/libavutil/uuid.h b/libavutil/uuid.h index 4b5088911c..748b7ed3c9 100644 --- a/libavutil/uuid.h +++ b/libavutil/uuid.h @@ -106,7 +106,6 @@ int av_uuid_parse_range(const char *in_star

[FFmpeg-devel] [PATCH v3 42/54] avutil/parseutils: Use inline code and properly escape

2022-09-24 Thread Marvin Scholz
For some reason doxygen needs the % to be escaped here, except for the %% in the inline code… --- libavutil/parseutils.h | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/libavutil/parseutils.h b/libavutil/parseutils.h index 2e9017cb43..dad5c2775b 100644 --- a/

[FFmpeg-devel] [PATCH v3 41/54] avutil/parseutils: Add doxy for missing arguments

2022-09-24 Thread Marvin Scholz
--- libavutil/parseutils.h | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/libavutil/parseutils.h b/libavutil/parseutils.h index e66d24b76e..2e9017cb43 100644 --- a/libavutil/parseutils.h +++ b/libavutil/parseutils.h @@ -79,6 +79,8 @@ int av_parse_video_rate(AVRational *ra

[FFmpeg-devel] [PATCH v3 40/54] avutil/hwcontext: Add doxy for missing argument

2022-09-24 Thread Marvin Scholz
--- libavutil/hwcontext.h | 1 + 1 file changed, 1 insertion(+) diff --git a/libavutil/hwcontext.h b/libavutil/hwcontext.h index efca17585e..7ff08c8608 100644 --- a/libavutil/hwcontext.h +++ b/libavutil/hwcontext.h @@ -591,6 +591,7 @@ int av_hwframe_map(AVFrame *dst, const AVFrame *src, int flag

[FFmpeg-devel] [PATCH v3 39/54] avutil/lfg: Minor doxy improvements

2022-09-24 Thread Marvin Scholz
Use inline code for sizeof and use proper @return directive. --- libavutil/lfg.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavutil/lfg.h b/libavutil/lfg.h index 16917827c6..e75a986f12 100644 --- a/libavutil/lfg.h +++ b/libavutil/lfg.h @@ -27,7 +27,7 @@ /** * Cont

[FFmpeg-devel] [PATCH v3 38/54] avutil/lfg: Add doxy for missing argument

2022-09-24 Thread Marvin Scholz
--- libavutil/lfg.h | 1 + 1 file changed, 1 insertion(+) diff --git a/libavutil/lfg.h b/libavutil/lfg.h index 9a1e277acd..16917827c6 100644 --- a/libavutil/lfg.h +++ b/libavutil/lfg.h @@ -73,6 +73,7 @@ static inline unsigned int av_mlfg_get(AVLFG *c){ * Get the next two numbers generated by a

[FFmpeg-devel] [PATCH v3 37/54] avutil/file: Add doxy for missing arguments

2022-09-24 Thread Marvin Scholz
--- libavutil/file.h | 4 1 file changed, 4 insertions(+) diff --git a/libavutil/file.h b/libavutil/file.h index 511c100db4..fc87a9cd6a 100644 --- a/libavutil/file.h +++ b/libavutil/file.h @@ -39,6 +39,9 @@ * case *bufptr will be set to NULL and *size will be set to 0. * The returned buf

[FFmpeg-devel] [PATCH v3 36/54] avutil/eval: Add doxy for missing arguments

2022-09-24 Thread Marvin Scholz
--- libavutil/eval.h | 5 + 1 file changed, 5 insertions(+) diff --git a/libavutil/eval.h b/libavutil/eval.h index 57afc2d562..ee8cffb057 100644 --- a/libavutil/eval.h +++ b/libavutil/eval.h @@ -42,6 +42,7 @@ typedef struct AVExpr AVExpr; * @param func2_names NULL terminated array of zero t

[FFmpeg-devel] [PATCH v3 35/54] avutil/detection_bbox: Add doxy for missing argument

2022-09-24 Thread Marvin Scholz
--- libavutil/detection_bbox.h | 1 + 1 file changed, 1 insertion(+) diff --git a/libavutil/detection_bbox.h b/libavutil/detection_bbox.h index c20c204a54..011988052c 100644 --- a/libavutil/detection_bbox.h +++ b/libavutil/detection_bbox.h @@ -93,6 +93,7 @@ av_get_detection_bbox(const AVDetection

[FFmpeg-devel] [PATCH v3 34/54] avformat/avio: Add doxy for missing argument

2022-09-24 Thread Marvin Scholz
--- libavformat/avio.h | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/avio.h b/libavformat/avio.h index 36c3d7b430..216cc2391e 100644 --- a/libavformat/avio.h +++ b/libavformat/avio.h @@ -464,6 +464,7 @@ int avio_put_str16be(AVIOContext *s, const char *str); * * Zero-length ra

[FFmpeg-devel] [PATCH v3 33/54] avfilter: Fix doxy references

2022-09-24 Thread Marvin Scholz
Doxygen does not properly form references that span multiple levels, so instead reword it a bit and manually add the references to what they should point to. --- libavfilter/avfilter.h | 21 ++--- 1 file changed, 14 insertions(+), 7 deletions(-) diff --git a/libavfilter/avfilter.h

[FFmpeg-devel] [PATCH v3 32/54] avutil/channel_layout: Document missing arguments

2022-09-24 Thread Marvin Scholz
--- libavutil/channel_layout.h | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/libavutil/channel_layout.h b/libavutil/channel_layout.h index ee32cc9ab9..46b501df7f 100644 --- a/libavutil/channel_layout.h +++ b/libavutil/channel_layout.h @@ -448,6 +448,8 @@ int av_ge

[FFmpeg-devel] [PATCH v3 31/54] avutil/channel_layout: Use inline code for Doxy

2022-09-24 Thread Marvin Scholz
This avoids Doxygen to interpret and others that look like XML tags as those, fixing a warning about unknown tags. --- libavutil/channel_layout.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavutil/channel_layout.h b/libavutil/channel_layout.h index 6415355662..ee3

[FFmpeg-devel] [PATCH v3 30/54] avutil/camellia: Fix doxy @param typo

2022-09-24 Thread Marvin Scholz
--- libavutil/camellia.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavutil/camellia.h b/libavutil/camellia.h index e674c9b9a4..96787102e2 100644 --- a/libavutil/camellia.h +++ b/libavutil/camellia.h @@ -59,7 +59,7 @@ int av_camellia_init(struct AVCAMELLIA *ctx, const ui

[FFmpeg-devel] [PATCH v3 29/54] swresample: Fix Doxy reference to AVOptions

2022-09-24 Thread Marvin Scholz
--- libswresample/swresample.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libswresample/swresample.h b/libswresample/swresample.h index 4c26468c63..d4dcaebdcf 100644 --- a/libswresample/swresample.h +++ b/libswresample/swresample.h @@ -73,7 +73,7 @@ * * Once all values

[FFmpeg-devel] [PATCH v3 28/54] avutil/bprint: Improve doxy documentation

2022-09-24 Thread Marvin Scholz
Declare proper group, add the file to that group, group the defines and document them. Use lists to represents lists of cases. --- libavutil/bprint.h | 78 -- 1 file changed, 55 insertions(+), 23 deletions(-) diff --git a/libavutil/bprint.h b/libavutil

[FFmpeg-devel] [PATCH v3 27/54] doc/Doxyfile: Add FF_PAD_STRUCTURE to PREDEFINED

2022-09-24 Thread Marvin Scholz
The FF_PAD_STRUCTURE is too complex for doxygen to be able to properly handle, resulting in completely broken AVBPrint documentation. To fix that, tell Doxygen what to expand that macro to. --- doc/Doxyfile | 1 + 1 file changed, 1 insertion(+) diff --git a/doc/Doxyfile b/doc/Doxyfile index 0891

[FFmpeg-devel] [PATCH v3 26/54] avcodec/mediacodec: link to related documentation

2022-09-24 Thread Marvin Scholz
--- libavcodec/mediacodec.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavcodec/mediacodec.h b/libavcodec/mediacodec.h index 845ade26eb..8bd5753e9a 100644 --- a/libavcodec/mediacodec.h +++ b/libavcodec/mediacodec.h @@ -90,11 +90,13 @@ int av_mediacodec_release_buffer(

[FFmpeg-devel] [PATCH v3 25/54] avcodec/mediacodec: use inline code for coderefs

2022-09-24 Thread Marvin Scholz
Avoids doxy to interpret these as internal references forced by the # character, fixing the warnings: warning: explicit link request to 'nanoTime()' could not be resolved warning: explicit link request to 'releaseOutputBuffer(int,long)' could not be resolved --- libavcodec/mediacodec.h | 6

[FFmpeg-devel] [PATCH v3 24/54] swscale: Fix bogus doxy comment #ifdefs

2022-09-24 Thread Marvin Scholz
The intention here was probably to document this as use of conditionals does not make sense in a comment. Fixes doxy warning: warning: explicit link request to 'if' could not be resolved --- libswscale/swscale.h | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git

[FFmpeg-devel] [PATCH v3 23/54] avutil/csp: Fix bogus doxy filename

2022-09-24 Thread Marvin Scholz
Separate the blocks to make the grouping easier to grasp, add the file properly to the group and fix the file description incorrectly used as filename, fixing the following doxy warning: warning: the name 'Colorspace' supplied as the argument in the \file statement is not an input file --- li

[FFmpeg-devel] [PATCH v3 22/54] avutil/stereo3d: Add file to doxy group

2022-09-24 Thread Marvin Scholz
This way the related file will be properly grouped with its corresponding group like it's done in other places in the doxy. --- libavutil/stereo3d.h | 1 + 1 file changed, 1 insertion(+) diff --git a/libavutil/stereo3d.h b/libavutil/stereo3d.h index 751d70b49a..3aab959b79 100644 --- a/libavutil/s

[FFmpeg-devel] [PATCH v3 21/54] avutil/stereo3d: consolidate group doxy

2022-09-24 Thread Marvin Scholz
Make it a bit easier to grasp the grouping when not unnecessarily splitting comment blocks. Additionally do not try to add lavu_video_stereo3d to itself, resolving the following doxy warning: warning: Refusing to add group lavu_video_stereo3d to itself --- libavutil/stereo3d.h | 15 +---

[FFmpeg-devel] [PATCH v3 20/54] avutil/spherical: Add file to doxy group

2022-09-24 Thread Marvin Scholz
This way the related file will be properly grouped with its corresponding group like it's done in other places in the doxy. --- libavutil/spherical.h | 1 + 1 file changed, 1 insertion(+) diff --git a/libavutil/spherical.h b/libavutil/spherical.h index 85a76a917e..828ac836da 100644 --- a/libavuti

[FFmpeg-devel] [PATCH v3 19/54] avutil/spherical: consolidate group doxy

2022-09-24 Thread Marvin Scholz
Make it a bit easier to grasp the grouping when not unnecessarily splitting comment blocks. Additionally do not try to add lavu_video_spherical to itself, resolving the following doxy warning: warning: Refusing to add group lavu_video_spherical to itself --- libavutil/spherical.h | 12 +++--

[FFmpeg-devel] [PATCH v3 18/54] avutil/display: Add file to doxy group

2022-09-24 Thread Marvin Scholz
This way the related file will be properly grouped with its corresponding group like it's done in other places in the doxy. --- libavutil/display.h | 1 + 1 file changed, 1 insertion(+) diff --git a/libavutil/display.h b/libavutil/display.h index 2d6f335960..aa280c4c0c 100644 --- a/libavutil/disp

[FFmpeg-devel] [PATCH v3 17/54] avutil/display: consolidate group doxy

2022-09-24 Thread Marvin Scholz
Make it a bit easier to grasp the grouping when not unnecessarily splitting comment blocks. Additionally do not try to add lavu_video_display to itself, resolving the following doxy warning: warning: Refusing to add group lavu_video_display to itself --- libavutil/display.h | 13 -

[FFmpeg-devel] [PATCH v3 16/54] avutil/aes_ctr: Add proper doxy group

2022-09-24 Thread Marvin Scholz
So it will be properly listed along the other crypto modules in the documentation. --- libavutil/aes_ctr.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/libavutil/aes_ctr.h b/libavutil/aes_ctr.h index 4e9fda7aca..4d80c71326 100644 --- a/libavutil/aes_ctr.h +++ b/libavutil/aes_ctr.h @@

[FFmpeg-devel] [PATCH v3 15/54] avcodec/videotoolbox: Add proper doxy group

2022-09-24 Thread Marvin Scholz
Same as done for other HW decoders, that way it will be properly listed on the relevant module page. --- libavcodec/videotoolbox.h | 9 + 1 file changed, 9 insertions(+) diff --git a/libavcodec/videotoolbox.h b/libavcodec/videotoolbox.h index fd8a5b7982..cc324faa52 100644 --- a/libavcodec

[FFmpeg-devel] [PATCH v3 14/54] avcodec/codec_par: Add missing doxy group opening

2022-09-24 Thread Marvin Scholz
--- libavcodec/codec_par.h | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/codec_par.h b/libavcodec/codec_par.h index fa132814b1..f51d27c590 100644 --- a/libavcodec/codec_par.h +++ b/libavcodec/codec_par.h @@ -32,6 +32,7 @@ /** * @addtogroup lavc_core + * @{ */ enum AVFiel

[FFmpeg-devel] [PATCH v3 13/54] avcodec/vdpau: Fix doxy comment typo

2022-09-24 Thread Marvin Scholz
This is clearly supposed to be a doxy comment and needed to properly close the group. --- libavcodec/vdpau.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/vdpau.h b/libavcodec/vdpau.h index 3010094d93..35c4b1096b 100644 --- a/libavcodec/vdpau.h +++ b/libavcodec/vdp

[FFmpeg-devel] [PATCH v3 09/54] avutil/channel_layout: Move to its own group

2022-09-24 Thread Marvin Scholz
Before it was cluttering the general avutil Audio group page. --- libavutil/channel_layout.h | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/libavutil/channel_layout.h b/libavutil/channel_layout.h index 74fe3a8328..070c98072b 100644 --- a/libavutil/channel_layout.h +

[FFmpeg-devel] [PATCH v3 12/54] avutil/twofish: Fix doxy @param typo

2022-09-24 Thread Marvin Scholz
--- libavutil/twofish.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavutil/twofish.h b/libavutil/twofish.h index 813cfecdf8..67f359e88c 100644 --- a/libavutil/twofish.h +++ b/libavutil/twofish.h @@ -59,7 +59,7 @@ int av_twofish_init(struct AVTWOFISH *ctx, const uint8_t

[FFmpeg-devel] [PATCH v3 08/54] avutil/channel_layout: Remove bogus closing group

2022-09-24 Thread Marvin Scholz
--- libavutil/channel_layout.h | 1 - 1 file changed, 1 deletion(-) diff --git a/libavutil/channel_layout.h b/libavutil/channel_layout.h index 9e685fab72..74fe3a8328 100644 --- a/libavutil/channel_layout.h +++ b/libavutil/channel_layout.h @@ -745,7 +745,6 @@ int av_channel_layout_check(const AVCh

[FFmpeg-devel] [PATCH v3 07/54] avcodec/avcodec: Escape Doxygen reference

2022-09-24 Thread Marvin Scholz
The # is interpreted as explicit reference request by Doxygen which is not desired here, use markdown inline code to avoid that. --- libavcodec/avcodec.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h index 9f79e61dc9..fb60331a31 100

[FFmpeg-devel] [PATCH v3 11/54] avutil/channel_layout: Group pre-defined channel layouts

2022-09-24 Thread Marvin Scholz
--- libavutil/channel_layout.h | 5 + 1 file changed, 5 insertions(+) diff --git a/libavutil/channel_layout.h b/libavutil/channel_layout.h index 52af52390c..6415355662 100644 --- a/libavutil/channel_layout.h +++ b/libavutil/channel_layout.h @@ -359,6 +359,10 @@ typedef struct AVChannelLayout

[FFmpeg-devel] [PATCH v3 06/54] avformat/avformat: Improve doxy style

2022-09-24 Thread Marvin Scholz
Mostly re-indenting and adding some missing references. --- libavformat/avformat.h | 180 +++-- 1 file changed, 103 insertions(+), 77 deletions(-) diff --git a/libavformat/avformat.h b/libavformat/avformat.h index c695cfc6de..1d97d56ac5 100644 --- a/libavformat

[FFmpeg-devel] [PATCH v3 10/54] avutil/channel_layout: Group deprecated functions

2022-09-24 Thread Marvin Scholz
Makes it a bit easier to spot the deprecated ones when looking at the overview. --- libavutil/channel_layout.h | 8 1 file changed, 8 insertions(+) diff --git a/libavutil/channel_layout.h b/libavutil/channel_layout.h index 070c98072b..52af52390c 100644 --- a/libavutil/channel_layout.h ++

[FFmpeg-devel] [PATCH v3 05/54] swresample/swresample: Fix mismatching argument names

2022-09-24 Thread Marvin Scholz
--- libswresample/swresample.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libswresample/swresample.h b/libswresample/swresample.h index 980be65783..4c26468c63 100644 --- a/libswresample/swresample.h +++ b/libswresample/swresample.h @@ -354,8 +354,8 @@ int swr_conve

[FFmpeg-devel] [PATCH v3 04/54] avutil: Fix mismatching argument names

2022-09-24 Thread Marvin Scholz
--- libavutil/hwcontext.h | 2 +- libavutil/mathematics.h | 6 -- libavutil/mem.h | 3 ++- libavutil/rational.h| 3 ++- 4 files changed, 9 insertions(+), 5 deletions(-) diff --git a/libavutil/hwcontext.h b/libavutil/hwcontext.h index c18b7e1e8b..efca17585e 100644 --- a/libavutil

[FFmpeg-devel] [PATCH v3 03/54] avformat/avformat: Fix mismatching argument names

2022-09-24 Thread Marvin Scholz
--- libavformat/avformat.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/avformat.h b/libavformat/avformat.h index 9d46875cce..c695cfc6de 100644 --- a/libavformat/avformat.h +++ b/libavformat/avformat.h @@ -2003,7 +2003,7 @@ AVProgram *av_new_program(AVFormatC

[FFmpeg-devel] [PATCH v3 02/54] avdevice/avdevice: Fix mismatching argument name

2022-09-24 Thread Marvin Scholz
--- libavdevice/avdevice.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavdevice/avdevice.h b/libavdevice/avdevice.h index 0b32e59fed..185593053f 100644 --- a/libavdevice/avdevice.h +++ b/libavdevice/avdevice.h @@ -494,7 +494,7 @@ int avdevice_list_devices(struct AVFormat

[FFmpeg-devel] [PATCH v3 01/54] avcodec: Fix Doxygen trailing brief comments

2022-09-24 Thread Marvin Scholz
The //< comment is not any magic comment supported by Doxygen, instead use ///< to mark them as doc for the members. --- libavcodec/avcodec.h | 8 libavcodec/codec_par.h | 8 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/libavcodec/avcodec.h b/libavcodec/avcode

[FFmpeg-devel] [PATCH v3 00/54] Various Doxygen fixes

2022-09-24 Thread Marvin Scholz
I've spent some more time to fix most of the issues and warnings reported by Doxygen. There are a few left, all undocumented arguments that were not immediately obvious to me what they do so I could not confidently document them. Changes since last version: - Use ///< in "Fix Doxygen trailing bri

Re: [FFmpeg-devel] [PATCH 2/5] avutil/pixdesc: Add av_chroma_location_(enum_to_pos|pos_to_enum)

2022-09-24 Thread Andreas Rheinhardt
Andreas Rheinhardt: > They are intended as replacements for avcodec_enum_to_chroma_pos() > and avcodec_chroma_pos_to_enum(). > > Signed-off-by: Andreas Rheinhardt > --- > Will add version bump upon applying. > (Honestly, I am not sure whether there is a need for a replacement > given that Matrosk

[FFmpeg-devel] [PATCH] avformat/mov: Speed up finding MOVFragmentIndexItem

2022-09-24 Thread Andreas Rheinhardt
The MOVFragmentIndexItems of a MOVFragmentIndex are ordered by increasing moof_offset; yet get_frag_stream_info_from_pkt() searched the array of index items linearly for the item with moof_offset <= pos < moof_offset of next index (if existing). This commit changes this: First, it is checked, whet

[FFmpeg-devel] [PATCH] fixed_dsp: add missing av_restrict qualifiers

2022-09-24 Thread Johannes Kauffmann
The butterflies_fixed function pointer declaration specifies av_restrict for the first two pointer arguments. So the corresponding function definitions should honor this declaration. MSVC emits warning C4113 for this. --- libavutil/fixed_dsp.c | 2 +- libavutil/x86/fixed_dsp_init.c | 2 +

Re: [FFmpeg-devel] [PATCH 1/6] opus: convert encoder and decoder to lavu/tx

2022-09-24 Thread Lynne
Sep 24, 2022, 21:40 by mar...@martin.st: > On Sat, 24 Sep 2022, Hendrik Leppkes wrote: > >> On Sat, Sep 24, 2022 at 9:26 PM Hendrik Leppkes wrote: >> >>> >>> On Sat, Sep 24, 2022 at 8:43 PM Martin Storsjö wrote: >>> > >>> > On Sat, 24 Sep 2022, Lynne wrote: >>> > >>> > > This commit changes both

[FFmpeg-devel] [PATCH] Makefile: Build complete doc with Doxygen

2022-09-24 Thread Marvin Scholz
Add DISABLEDINSTHEADERS, a variable containing the headers of disabled libraries. This is needed so that Doxygen does not generate incomplete documentation when a component is disabled, which is quite unexpected behaviour and results in warnings due to, among other things, broken references. --- M

Re: [FFmpeg-devel] [PATCH 1/6] opus: convert encoder and decoder to lavu/tx

2022-09-24 Thread Martin Storsjö
On Sat, 24 Sep 2022, Hendrik Leppkes wrote: On Sat, Sep 24, 2022 at 9:26 PM Hendrik Leppkes wrote: On Sat, Sep 24, 2022 at 8:43 PM Martin Storsjö wrote: > > On Sat, 24 Sep 2022, Lynne wrote: > > > This commit changes both the encoder and decoder to use the new lavu/tx code, > > which has fa

Re: [FFmpeg-devel] [PATCH 1/6] opus: convert encoder and decoder to lavu/tx

2022-09-24 Thread Hendrik Leppkes
On Sat, Sep 24, 2022 at 9:26 PM Hendrik Leppkes wrote: > > On Sat, Sep 24, 2022 at 8:43 PM Martin Storsjö wrote: > > > > On Sat, 24 Sep 2022, Lynne wrote: > > > > > This commit changes both the encoder and decoder to use the new lavu/tx > > > code, > > > which has faster C transforms and more as

Re: [FFmpeg-devel] [PATCH 1/6] opus: convert encoder and decoder to lavu/tx

2022-09-24 Thread Hendrik Leppkes
On Sat, Sep 24, 2022 at 8:43 PM Martin Storsjö wrote: > > On Sat, 24 Sep 2022, Lynne wrote: > > > This commit changes both the encoder and decoder to use the new lavu/tx > > code, > > which has faster C transforms and more assembly optimizations. > > What's the case of e.g. 32 bit arm - that does

Re: [FFmpeg-devel] [PATCH 1/6] opus: convert encoder and decoder to lavu/tx

2022-09-24 Thread Martin Storsjö
On Sat, 24 Sep 2022, Lynne wrote: This commit changes both the encoder and decoder to use the new lavu/tx code, which has faster C transforms and more assembly optimizations. What's the case of e.g. 32 bit arm - that does have a bunch of fft and mdct assembly, but is that something that ends

Re: [FFmpeg-devel] [PATCH] Update sample upload instructions

2022-09-24 Thread Marvin Scholz
On 17 May 2022, at 12:43, Marvin Scholz wrote: > The previous instructions do not work, there is no FTP server > running at upload.ffmpeg.org > (which is an alias for streams.videolan.org) > > Signed-off-by: Marvin Scholz > --- > src/bugreports | 16 +++- > 1 file changed, 7 insertio

[FFmpeg-devel] [PATCH v2 5/5] avutil/dict: Improve documentation

2022-09-24 Thread Marvin Scholz
Mostly consistent formatting and consistently ordering of warnings/notes to be next to the description. Additionally group the AV_DICT_* macros. --- libavutil/dict.h | 91 +--- 1 file changed, 55 insertions(+), 36 deletions(-) diff --git a/libavutil/di

[FFmpeg-devel] [PATCH v2 4/5] avutil/dict: Use av_dict_iterate in av_dict_get_string

2022-09-24 Thread Marvin Scholz
--- libavutil/dict.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavutil/dict.c b/libavutil/dict.c index 3c05ed4c84..122606e3aa 100644 --- a/libavutil/dict.c +++ b/libavutil/dict.c @@ -250,7 +250,7 @@ int av_dict_copy(AVDictionary **dst, const AVDictionary *src, int

[FFmpeg-devel] [PATCH v2 3/5] avutil/dict: Use av_dict_iterate in av_dict_copy

2022-09-24 Thread Marvin Scholz
--- libavutil/dict.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavutil/dict.c b/libavutil/dict.c index ea03590d0f..3c05ed4c84 100644 --- a/libavutil/dict.c +++ b/libavutil/dict.c @@ -236,9 +236,9 @@ void av_dict_free(AVDictionary **pm) int av_dict_copy(AVDictiona

[FFmpeg-devel] [PATCH v2 2/5] avutil/dict: Use av_dict_iterate in av_dict_get

2022-09-24 Thread Marvin Scholz
--- libavutil/dict.c | 16 ++-- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/libavutil/dict.c b/libavutil/dict.c index ee059d712c..ea03590d0f 100644 --- a/libavutil/dict.c +++ b/libavutil/dict.c @@ -60,18 +60,14 @@ const AVDictionaryEntry *av_dict_iterate(const AVDict

[FFmpeg-devel] [PATCH v2 1/5] avutil/dict: Add av_dict_iterate

2022-09-24 Thread Marvin Scholz
This is a more explicit iteration API rather than using the "magic" av_dict_get(d, "", t, AV_DICT_IGNORE_SUFFIX) which is not really trivial to grasp what it does when casually reading through code. --- libavutil/dict.c| 19 +++ libavutil/dict.h| 46

Re: [FFmpeg-devel] [PATCH v2 1/4] avcodec/h264_redundant_pps_bsf: Don't remove PPS

2022-09-24 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Andreas Rheinhardt: >> There is no check for whether these supposedly redundant PPS >> are actually redundant. One could check via memcmp which would >> work in practice* (because all content buffers are initially >> zero-allocated), but this is not portable as compilers may >

Re: [FFmpeg-devel] [PATCH v2 1/2] fftools: Remove unused qsv declarations

2022-09-24 Thread Andreas Rheinhardt
Marvin Scholz: > The code that uses these was removed in > ecee3b07cde23e05bcc6b4eaa55d860b62dbd2dc > --- > fftools/ffmpeg.h | 4 > 1 file changed, 4 deletions(-) > > diff --git a/fftools/ffmpeg.h b/fftools/ffmpeg.h > index ede0b2bd96..db7413adcd 100644 > --- a/fftools/ffmpeg.h > +++ b/fftoo

[FFmpeg-devel] [PATCH v2 2/2] fftools: Remove unused videotoolbox_init declaration

2022-09-24 Thread Marvin Scholz
The code that defined videotoolbox_init was removed in 4b54818981d2783af161c2ff670b658afbdda503 --- fftools/ffmpeg.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/fftools/ffmpeg.h b/fftools/ffmpeg.h index db7413adcd..701a211544 100644 --- a/fftools/ffmpeg.h +++ b/fftools/ffmpeg.h @@ -712,8

[FFmpeg-devel] [PATCH v2 1/2] fftools: Remove unused qsv declarations

2022-09-24 Thread Marvin Scholz
The code that uses these was removed in ecee3b07cde23e05bcc6b4eaa55d860b62dbd2dc --- fftools/ffmpeg.h | 4 1 file changed, 4 deletions(-) diff --git a/fftools/ffmpeg.h b/fftools/ffmpeg.h index ede0b2bd96..db7413adcd 100644 --- a/fftools/ffmpeg.h +++ b/fftools/ffmpeg.h @@ -686,9 +686,6 @@ ext

Re: [FFmpeg-devel] [PATCH 1/2] fftools: Remove unused qsv declarations

2022-09-24 Thread Andreas Rheinhardt
Marvin Scholz: > --- > fftools/ffmpeg.h | 4 > 1 file changed, 4 deletions(-) > > diff --git a/fftools/ffmpeg.h b/fftools/ffmpeg.h > index ede0b2bd96..db7413adcd 100644 > --- a/fftools/ffmpeg.h > +++ b/fftools/ffmpeg.h > @@ -686,9 +686,6 @@ extern int auto_conversion_filters; > extern const

[FFmpeg-devel] [PATCH 2/2] fftools: Remove unused videotoolbox_init declaration

2022-09-24 Thread Marvin Scholz
--- fftools/ffmpeg.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/fftools/ffmpeg.h b/fftools/ffmpeg.h index db7413adcd..701a211544 100644 --- a/fftools/ffmpeg.h +++ b/fftools/ffmpeg.h @@ -712,8 +712,6 @@ int ifilter_parameters_from_frame(InputFilter *ifilter, const AVFrame *frame); int

[FFmpeg-devel] [PATCH 1/2] fftools: Remove unused qsv declarations

2022-09-24 Thread Marvin Scholz
--- fftools/ffmpeg.h | 4 1 file changed, 4 deletions(-) diff --git a/fftools/ffmpeg.h b/fftools/ffmpeg.h index ede0b2bd96..db7413adcd 100644 --- a/fftools/ffmpeg.h +++ b/fftools/ffmpeg.h @@ -686,9 +686,6 @@ extern int auto_conversion_filters; extern const AVIOInterruptCB int_cb; extern