[FFmpeg-devel] [PATCH] avfilter/vf_drawbox: use the correct macro to fill rgb plane pointers

2022-09-14 Thread James Almer
Fixes ticket #9924 Signed-off-by: James Almer --- libavfilter/vf_drawbox.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/vf_drawbox.c b/libavfilter/vf_drawbox.c index 65bd039d65..64ce12 100644 --- a/libavfilter/vf_drawbox.c +++ b/libavfilter/vf_drawbox.c @@

Re: [FFmpeg-devel] [PATCH 5/7] swresample/swresample: Fix mismatching argument names

2022-09-14 Thread James Almer
On 9/14/2022 10:52 PM, Marvin Scholz wrote: --- libswresample/swresample.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libswresample/swresample.h b/libswresample/swresample.h index 980be65783..83821a0930 100644 --- a/libswresample/swresample.h +++ b/libswresampl

[FFmpeg-devel] [PATCH 3/7] avformat/avformat: Fix mismatching argument names

2022-09-14 Thread Marvin Scholz
--- libavformat/avformat.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/avformat.h b/libavformat/avformat.h index 9d46875cce..c695cfc6de 100644 --- a/libavformat/avformat.h +++ b/libavformat/avformat.h @@ -2003,7 +2003,7 @@ AVProgram *av_new_program(AVFormatC

[FFmpeg-devel] [PATCH 2/7] avdevice/avdevice: Fix mismatching argument name

2022-09-14 Thread Marvin Scholz
--- libavdevice/avdevice.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavdevice/avdevice.h b/libavdevice/avdevice.h index 0b32e59fed..185593053f 100644 --- a/libavdevice/avdevice.h +++ b/libavdevice/avdevice.h @@ -494,7 +494,7 @@ int avdevice_list_devices(struct AVFormat

[FFmpeg-devel] [PATCH 1/7] avcodec: Fix Doxygen trailing brief comments

2022-09-14 Thread Marvin Scholz
The //< comment is not any magic comment supported by Doxygen, instead use //!< to mark them as brief doc for the members. --- libavcodec/avcodec.h | 8 libavcodec/codec_par.h | 8 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/libavcodec/avcodec.h b/libavcodec/

[FFmpeg-devel] [PATCH 7/7] avcodec/avcodec: Escape Doxygen reference

2022-09-14 Thread Marvin Scholz
The # is interpreted as explicit reference request by Doxygen which is not desired here. Additionally use a typewriter font to make the inline code easier to distinguish. --- libavcodec/avcodec.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/avcodec.h b/libavcodec

[FFmpeg-devel] [PATCH 6/7] avformat/avformat: Improve doxy style

2022-09-14 Thread Marvin Scholz
Mostly re-indenting and adding some missing references. --- libavformat/avformat.h | 180 +++-- 1 file changed, 103 insertions(+), 77 deletions(-) diff --git a/libavformat/avformat.h b/libavformat/avformat.h index c695cfc6de..1d97d56ac5 100644 --- a/libavformat

[FFmpeg-devel] [PATCH 5/7] swresample/swresample: Fix mismatching argument names

2022-09-14 Thread Marvin Scholz
--- libswresample/swresample.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libswresample/swresample.h b/libswresample/swresample.h index 980be65783..83821a0930 100644 --- a/libswresample/swresample.h +++ b/libswresample/swresample.h @@ -354,8 +354,8 @@ int swr_conve

[FFmpeg-devel] [PATCH 4/7] avutil: Fix mismatching argument names

2022-09-14 Thread Marvin Scholz
--- libavutil/hwcontext.h | 2 +- libavutil/mathematics.h | 6 -- libavutil/mem.h | 3 ++- libavutil/rational.h| 3 ++- 4 files changed, 9 insertions(+), 5 deletions(-) diff --git a/libavutil/hwcontext.h b/libavutil/hwcontext.h index c18b7e1e8b..efca17585e 100644 --- a/libavutil

Re: [FFmpeg-devel] [PATCH 1/7] avcodec/iff: Split extract_header into extradata and packet part

2022-09-14 Thread Andreas Rheinhardt
Andreas Rheinhardt: > 183132872a1d8bc8a32e7fd8f994fa2f1b2d6bfc made the iff demuxer > output extradata and made the decoder parse said extradata. > To make this extradata extensible, it came with its own internal > length field (containing the offset of the palette at the end > of the extradata). F

Re: [FFmpeg-devel] [PATCH] lavu: header and documentation for AVWriter

2022-09-14 Thread Michael Niedermayer
On Wed, Sep 07, 2022 at 03:30:09PM +0200, Nicolas George wrote: > Anton Khirnov (12022-09-02): > > As I already said to you in private, I do not think the motivation and > > use cases for this have been sufficiently established. > > > > You claim this will bring massive advantages all over the pla

Re: [FFmpeg-devel] [PATCH] avfilter/vf_libvmaf: Update ssim, ms_ssim options description

2022-09-14 Thread Kyle Swanson
Hi, On Fri, Sep 9, 2022 at 10:58 AM Yondon Fu wrote: > Update description for ssim and ms_ssim libvmaf options to specify > feature=float_ssim and feature=float_ms_ssim which are used to request > ssim and ms_ssim values in the latest versions of libvmaf. > > Signed-off-by: Yondon Fu > --- > l

Re: [FFmpeg-devel] [PATCH] v2: lavu/pixdesc: favour formats where depth and subsampling exactly match

2022-09-14 Thread Michael Niedermayer
On Sat, Sep 10, 2022 at 12:23:30PM -0700, Philip Langdale wrote: > Since introducing the various packed formats used by VAAPI (and p012), > we've noticed that there's actually a gap in how > av_find_best_pix_fmt_of_2 works. It doesn't actually assign any value > to having the same bit depth as the

[FFmpeg-devel] [PATCH] avutil/dict: Error out in case of key == NULL

2022-09-14 Thread Andreas Rheinhardt
Up until now, using NULL as key in av_dict_get() on a non-empty AVDictionary would crash; using NULL as key in av_dict_set() would also crash for a non-empty AVDictionary unless AV_DICT_MULTIKEY was set; in case the dictionary was initially empty or AV_DICT_MULTIKEY was set, it was even possible fo

Re: [FFmpeg-devel] Bug in VMAF calculation for 10 bit comparison

2022-09-14 Thread Kyle Swanson
On Wed, Sep 14, 2022 at 12:02 PM Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: > Would it actually be possible to avoid the memcpy altogether? > There's no libvmaf API for user buffers yet, so no, not at this moment. ___ ffmpeg-devel maili

Re: [FFmpeg-devel] [PATCH 1/3] lavu: detect RISC-V F extension (i.e. float)

2022-09-14 Thread Rémi Denis-Courmont
Le keskiviikkona 14. syyskuuta 2022, 22.28.01 EEST Lynne a écrit : > Sep 14, 2022, 19:50 by r...@remlab.net: > > From: Rémi Denis-Courmont > > > > This introduces compile-tim and run-time CPU detection on RISC-V. In > > practice, I doubt that FFmpeg will ever see a RISC-V CPU without the F > > ex

Re: [FFmpeg-devel] [PATCH 1/3] lavu: detect RISC-V F extension (i.e. float)

2022-09-14 Thread Lynne
Sep 14, 2022, 19:50 by r...@remlab.net: > From: Rémi Denis-Courmont > > This introduces compile-tim and run-time CPU detection on RISC-V. In > practice, I doubt that FFmpeg will ever see a RISC-V CPU without the F > extension, and if it does, it probably won't have run-time detection. > So the fl

[FFmpeg-devel] Unsubscribe

2022-09-14 Thread Sam Davis
Unsubscribe On Wed, Sep 14, 2022, 11:14 Nicolas George wrote: > Li-Heng Chen (12022-09-13): > > This patch solves a potential EOF pts bug that can be triggered with > other filters: when placing select filter before fps filter, the EOF pts in > `f_select` always indicate the last input frame reg

Re: [FFmpeg-devel] Bug in VMAF calculation for 10 bit comparison

2022-09-14 Thread Andreas Rheinhardt
Kyle Swanson: > Hi, > > On Wed, Sep 14, 2022 at 9:52 AM wrote: >> >> Sure. sorry for that. Please find attached the patch file. >> > > Was about to test / review, but it looks like this is already pushed by Paul. > Would it actually be possible to avoid the memcpy altogether? - Andreas __

Re: [FFmpeg-devel] Bug in VMAF calculation for 10 bit comparison

2022-09-14 Thread Kyle Swanson
Hi, On Wed, Sep 14, 2022 at 9:52 AM wrote: > > Sure. sorry for that. Please find attached the patch file. > Was about to test / review, but it looks like this is already pushed by Paul. Thanks, Kyle ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.or

Re: [FFmpeg-devel] [PATCH] libavfilter/f_select: switch to activate and properly handle EOF pts

2022-09-14 Thread Nicolas George
Li-Heng Chen (12022-09-14): > Thanks for the comment, Nicolas! I've attached a new patch file which > should address the comments. I also want to mention that this patch is > similar to another one Paul had done for setpts filter: > http://git.videolan.org/?p=ffmpeg.git;a=commitdiff;h=2a546fb7d5722

Re: [FFmpeg-devel] [PATCH 3/3] lavc/audiodsp: add RISC-V F float vector clip

2022-09-14 Thread Rémi Denis-Courmont
Le keskiviikkona 14. syyskuuta 2022, 20.50.31 EEST r...@remlab.net a écrit : > From: Rémi Denis-Courmont > > RV64G supports MIN & MAX instructions natively only on floating point > registers, not general purpose ones. The later would require the Zbb > extension. Due to that, it is actually faster

[FFmpeg-devel] [PATCH 3/3] lavc/audiodsp: add RISC-V F float vector clip

2022-09-14 Thread remi
From: Rémi Denis-Courmont RV64G supports MIN & MAX instructions natively only on floating point registers, not general purpose ones. The later would require the Zbb extension. Due to that, it is actually faster to perform the clipping "properly" in FPU. Benchmarked on SiFive U74-MC: audiodsp.ve

[FFmpeg-devel] [PATCH 2/3] lavu/riscv: initial common header for assembler macros

2022-09-14 Thread remi
From: Rémi Denis-Courmont --- libavutil/riscv/asm.S | 74 +++ 1 file changed, 74 insertions(+) create mode 100644 libavutil/riscv/asm.S diff --git a/libavutil/riscv/asm.S b/libavutil/riscv/asm.S new file mode 100644 index 00..7623c161cf --- /dev/

[FFmpeg-devel] [PATCH 1/3] lavu: detect RISC-V F extension (i.e. float)

2022-09-14 Thread remi
From: Rémi Denis-Courmont This introduces compile-tim and run-time CPU detection on RISC-V. In practice, I doubt that FFmpeg will ever see a RISC-V CPU without the F extension, and if it does, it probably won't have run-time detection. So the flag is essentially always set. But as things stand,

[FFmpeg-devel] [RFC] [PATCH 0/3] RISC-V CPU detection

2022-09-14 Thread Rémi Denis-Courmont
Hi, This small series introduces the same CPU detection and assembler macros as the earlier V extension stuff but sticking to a scalar use case. Benchmark results are included in the last patch. Rémi Denis-Courmont (3): lavu:

Re: [FFmpeg-devel] [PATCH 1/1] lavu/riscv: fix av_clip_int16

2022-09-14 Thread James Almer
On 9/14/2022 2:34 PM, r...@remlab.net wrote: From: Rémi Denis-Courmont Some serious copy-paste / squash / rebase mismanipulation here. --- libavutil/riscv/intmath.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavutil/riscv/intmath.h b/libavutil/riscv/intmath.h i

[FFmpeg-devel] [PATCH 1/1] lavu/riscv: fix av_clip_int16

2022-09-14 Thread remi
From: Rémi Denis-Courmont Some serious copy-paste / squash / rebase mismanipulation here. --- libavutil/riscv/intmath.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavutil/riscv/intmath.h b/libavutil/riscv/intmath.h index 78f7ba930a..3263a79dc4 100644 --- a/libavuti

Re: [FFmpeg-devel] [PATCH] format/imfdec: improve error handling when selecting tracks for playback

2022-09-14 Thread Pierre-Anthony Lemieux
Ping. This patchset addresses a coverity issue #1512414. On Wed, Sep 7, 2022 at 1:02 PM wrote: > > From: Pierre-Anthony Lemieux > > Addresses coverity 1512414 > > --- > libavformat/imfdec.c | 15 --- > 1 file changed, 12 insertions(+), 3 deletions(-) > > diff --git a/libavformat/im

Re: [FFmpeg-devel] [PATCH v3 1/2] avformat/mxf: set stream frame rates for ST 422 essence containers

2022-09-14 Thread Pierre-Anthony Lemieux
Ping. All outstanding feedback has been addressed AFAIK. This patchset addresses https://trac.ffmpeg.org/ticket/9856 On Tue, Sep 6, 2022 at 2:51 PM wrote: > > From: Pierre-Anthony Lemieux > > The MXF demuxer does not currently set AVStream::avg_frame_rate and > ::r_frame_rate > when J2K essenc

Re: [FFmpeg-devel] [PATCH v4 1/2] libavcodec/flacdec: Implement decoding of 32 bit-per-sample PCM

2022-09-14 Thread Andreas Rheinhardt
Martijn van Beurden: > Op wo 14 sep. 2022 om 15:03 schreef Andreas Rheinhardt < > andreas.rheinha...@outlook.com>: > >>> --- a/libavcodec/flacdec.c >>> +++ b/libavcodec/flacdec.c >>> @@ -64,6 +64,9 @@ typedef struct FLACContext { >>> int32_t *decoded[FLAC_MAX_CHANNELS];///< decoded sample

Re: [FFmpeg-devel] Bug in VMAF calculation for 10 bit comparison

2022-09-14 Thread christian.feldmann
Sure. sorry for that. Please find attached the patch file. -Original Message- From: ffmpeg-devel On Behalf Of Paul B Mahol Sent: Wednesday, September 14, 2022 18:49 To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] Bug in VMAF calculation for 10 bit comparison

Re: [FFmpeg-devel] Bug in VMAF calculation for 10 bit comparison

2022-09-14 Thread Paul B Mahol
On 9/14/22, christian.feldm...@gmx.de wrote: > Hi, > > I was debugging some VMAF calculation in ffmpeg when I stumbled on this bug > in the latest master commit (9450f759748d02d1d284d2e4afd741cb0fe0c04a). Its > in libavfilter/vf_libvmaf.c::109. The function copy_picture_data does only > work corre

[FFmpeg-devel] Bug in VMAF calculation for 10 bit comparison

2022-09-14 Thread christian.feldmann
Hi, I was debugging some VMAF calculation in ffmpeg when I stumbled on this bug in the latest master commit (9450f759748d02d1d284d2e4afd741cb0fe0c04a). Its in libavfilter/vf_libvmaf.c::109. The function copy_picture_data does only work correctly for 8 bit input. For 10 bit input, only half of t

[FFmpeg-devel] [PATCH] float in tiff

2022-09-14 Thread Paul B Mahol
Patches attached. From 624514b681886ac340b76202b857a0870b7bc65d Mon Sep 17 00:00:00 2001 From: Paul B Mahol Date: Wed, 14 Sep 2022 14:09:02 +0200 Subject: [PATCH 1/4] avutil: add RGB single-precision float formats Signed-off-by: Paul B Mahol --- libavutil/pixdesc.c | 25

Re: [FFmpeg-devel] [PATCH v4 1/2] libavcodec/flacdec: Implement decoding of 32 bit-per-sample PCM

2022-09-14 Thread Paul B Mahol
On 9/14/22, Martijn van Beurden wrote: > Op wo 14 sep. 2022 om 15:03 schreef Andreas Rheinhardt < > andreas.rheinha...@outlook.com>: > >> > --- a/libavcodec/flacdec.c >> > +++ b/libavcodec/flacdec.c >> > @@ -64,6 +64,9 @@ typedef struct FLACContext { >> > int32_t *decoded[FLAC_MAX_CHANNELS];

Re: [FFmpeg-devel] [PATCH v4 1/2] libavcodec/flacdec: Implement decoding of 32 bit-per-sample PCM

2022-09-14 Thread Martijn van Beurden
Op wo 14 sep. 2022 om 15:03 schreef Andreas Rheinhardt < andreas.rheinha...@outlook.com>: > > --- a/libavcodec/flacdec.c > > +++ b/libavcodec/flacdec.c > > @@ -64,6 +64,9 @@ typedef struct FLACContext { > > int32_t *decoded[FLAC_MAX_CHANNELS];///< decoded samples > > uint8_t *decoded

Re: [FFmpeg-devel] [PATCH] libavfilter/f_select: switch to activate and properly handle EOF pts

2022-09-14 Thread Nicolas George
Li-Heng Chen (12022-09-13): > This patch solves a potential EOF pts bug that can be triggered with other > filters: when placing select filter before fps filter, the EOF pts in > `f_select` always indicate the last input frame regardless of the frame > selected. This may cause unwanted duplicati

Re: [FFmpeg-devel] [PATCH v4 1/2] libavcodec/flacdec: Implement decoding of 32 bit-per-sample PCM

2022-09-14 Thread Andreas Rheinhardt
Martijn van Beurden: > Add decoding of FLAC files coding for 32 bit-per-sample PCM to libavcodec. > --- > libavcodec/flac.c | 4 +- > libavcodec/flacdec.c | 248 ++ > libavcodec/get_bits.h | 12 ++ > libavcodec/mathops.h | 9 ++ > 4 files changed,

Re: [FFmpeg-devel] [PATCH] fftools/opt_common: check the return value of av_hwdevice_get_type_name before printing it

2022-09-14 Thread James Almer
On 9/12/2022 10:02 AM, James Almer wrote: It may be NULL, as is the case for D3D11VA_VLD. Running "ffmpeg -h decoder=h264" on a Windows build Before: Decoder h264 [H.264 / AVC / MPEG-4 AVC / MPEG-4 part 10]: Supported hardware devices: dxva2 (null) d3d11va cuda After: Decoder h264 [H.264

Re: [FFmpeg-devel] [PATCH] Bonk, Bonk

2022-09-14 Thread Paul B Mahol
On 9/12/22, Martijn van Beurden wrote: > Op wo 7 sep. 2022 om 19:59 schreef Paul B Mahol : > >> Patches attached. >> >> Could decoder be made faster? >> >> > Haven't reviewed, but great to have another codec added. Concerning the > speed, as far as I know Bonk is slow to decode. Its website states

Re: [FFmpeg-devel] [PATCH v2 1/3] avfilter/avfilter: Don't use AVFrame.channel_layout

2022-09-14 Thread Andreas Rheinhardt
Nicolas George: > Andreas Rheinhardt (12022-09-12): >> Signed-off-by: Andreas Rheinhardt >> --- >> libavfilter/avfilter.c | 12 ++-- >> 1 file changed, 10 insertions(+), 2 deletions(-) > > Series should be ok. > > Regards, > Thanks for the review. Will apply this tonight unless there

Re: [FFmpeg-devel] [PATCH 2/3] avutil/dict: Improve appending values

2022-09-14 Thread Paul B Mahol
On 9/13/22, Andreas Rheinhardt wrote: > When appending two values (due to AV_DICT_APPEND), the earlier code > would first zero-allocate a buffer of the required size and then > copy both parts into it via av_strlcat(). This is problematic, > as it leads to quadratic performance in case of frequent

Re: [FFmpeg-devel] [PATCH 1/3] avutil/dict: Fix memleak when using AV_DICT_APPEND

2022-09-14 Thread Paul B Mahol
On 9/13/22, Andreas Rheinhardt wrote: > If a key already exists in an AVDictionary and the AV_DICT_APPEND flag > is set, the old entry is at first discarded from the dictionary, but > a pointer to the value is kept. Lateron enough memory to store the > appended string is allocated; should this all

Re: [FFmpeg-devel] [PATCH] avformat/dump: Avoid unnecessary implicit calculation of strlen

2022-09-14 Thread Paul B Mahol
On 9/14/22, Andreas Rheinhardt wrote: > av_strlcpy() returns the length of the src string to enable > the caller to check for truncation. It is currently used in > the following way in dump_metadata(): Every metadata value > is searched for \b, \n, \v, \f, \r and then the data up to > the first of

Re: [FFmpeg-devel] [PATCH v4] libavfilter/x86/vf_convolution: add sobel filter optimization and unit test with intel AVX512 VNNI

2022-09-14 Thread Wang, Bin
-Original Message- From: Wang, Bin Sent: Wednesday, September 7, 2022 2:27 PM To: ffmpeg-devel@ffmpeg.org Cc: Wang, Bin Subject: [FFmpeg-devel] [PATCH v4] libavfilter/x86/vf_convolution: add sobel filter optimization and unit test with intel AVX512 VNNI From: bwang30 This commit enab

Re: [FFmpeg-devel] [PATCH 05/18] lavu/riscv: add optimisations

2022-09-14 Thread Rémi Denis-Courmont
Hmm. It looks like I accidentally dropped a fix-up while rebasing/squashing and bow there's 8-bit instead of 16-bit clipping :-( Will send the trivial fix in a few hours. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/l