Re: [FFmpeg-devel] [PATCH v7 1/2] avformat: refactor ff_stream_encode_params_copy() to stream_params_copy()

2022-08-09 Thread Pierre-Anthony Lemieux
On Mon, Aug 8, 2022 at 7:50 AM Pierre-Anthony Lemieux wrote: > > On Mon, Aug 8, 2022 at 7:48 AM Andreas Rheinhardt > wrote: > > > > p...@sandflow.com: > > > From: Pierre-Anthony Lemieux > > > > > > Addresses http://ffmpeg.org/pipermail/ffmpeg-devel/2022-August/299726.html > > > > > > --- > > >

Re: [FFmpeg-devel] [PATCH v2] doc/git-howto.texi: Document commit signing

2022-08-09 Thread Michael Niedermayer
On Tue, Aug 09, 2022 at 04:38:56PM -0300, James Almer wrote: > On 8/9/2022 4:34 PM, Michael Niedermayer wrote: > > From: Michael Niedermayer > > > > Signed-off-by: Michael Niedermayer > > --- > > doc/git-howto.texi | 22 +- > > 1 file changed, 21 insertions(+), 1 deletion(

Re: [FFmpeg-devel] [PATCH 1/2] avformat/mov: Rework the AVIF parser to handle multiple items

2022-08-09 Thread James Zern
On Tue, Aug 2, 2022 at 9:54 AM James Zern wrote: > > Andreas, > > On Thu, Jul 28, 2022 at 11:25 AM Vignesh Venkatasubramanian > wrote: > > > > Stores the item ids of all the items found in the file and > > processes the primary item at the end of the meta box. This patch > > does not change any b

[FFmpeg-devel] [PATCH 11/11] avcodec/mpegpicture: Always reset motion val buffer

2022-08-09 Thread Andreas Rheinhardt
Codecs call ff_find_unused_picture() to get the index of an unused picture; said picture may have buffers left from using it previously (these buffers are intentionally not unreferenced so that it might be possible to reuse them; this is mpegvideo's version of a bufferpool). They should not make an

[FFmpeg-devel] [PATCH 10/11] avcodec/mpegvideo: Move setting mb_height to ff_mpv_init_context_frame

2022-08-09 Thread Andreas Rheinhardt
It is the proper place to set it, directly besides mb_width and mb_stride. The reason for doing it the way it is done now seems to be that the code does not create more slice contexts than necessary (i.e. not more than one per row), so that this number needs to be known before setting the number of

Re: [FFmpeg-devel] [PATCH v2] doc/git-howto.texi: Document commit signing

2022-08-09 Thread James Almer
On 8/9/2022 4:34 PM, Michael Niedermayer wrote: From: Michael Niedermayer Signed-off-by: Michael Niedermayer --- doc/git-howto.texi | 22 +- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/doc/git-howto.texi b/doc/git-howto.texi index 874afabbbc..48389751a4

[FFmpeg-devel] [PATCH v2] doc/git-howto.texi: Document commit signing

2022-08-09 Thread Michael Niedermayer
From: Michael Niedermayer Signed-off-by: Michael Niedermayer --- doc/git-howto.texi | 22 +- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/doc/git-howto.texi b/doc/git-howto.texi index 874afabbbc..48389751a4 100644 --- a/doc/git-howto.texi +++ b/doc/git-howto

Re: [FFmpeg-devel] [PATCH 1/2] MAINTAINERS: Add ED25519 key for tag/commit signing experiment

2022-08-09 Thread Michael Niedermayer
On Mon, Aug 08, 2022 at 04:50:07PM +0200, Michael Niedermayer wrote: > From: Michael Niedermayer > > Signed-off-by: Michael Niedermayer > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 7ed15f96f6..ed2ec0b90c 100644 > --- a/MAINTAINE

Re: [FFmpeg-devel] [RFC] git and signing commits and tags

2022-08-09 Thread Michael Niedermayer
On Tue, Aug 09, 2022 at 07:50:13PM +0200, Lynne wrote: > Aug 9, 2022, 13:02 by mich...@niedermayer.cc: > > > On Tue, Aug 09, 2022 at 12:59:52PM +0200, Michael Niedermayer wrote: > > > >> On Tue, Aug 09, 2022 at 12:36:53AM +0200, Michael Niedermayer wrote: > >> > On Mon, Aug 08, 2022 at 09:26:52PM

[FFmpeg-devel] [PATCH 9/9] avcodec/mpegvideo_enc: Remove redundant cast

2022-08-09 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/mpegvideo_enc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/mpegvideo_enc.c b/libavcodec/mpegvideo_enc.c index 4840d80fe8..63fa0663d3 100644 --- a/libavcodec/mpegvideo_enc.c +++ b/libavcodec/mpegvideo_enc.c @@ -11

[FFmpeg-devel] [PATCH 8/9] avcodec/mpegvideo_enc: Remove redundant check

2022-08-09 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/mpegvideo_enc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/mpegvideo_enc.c b/libavcodec/mpegvideo_enc.c index 2cd4db27bc..4840d80fe8 100644 --- a/libavcodec/mpegvideo_enc.c +++ b/libavcodec/mpegvideo_enc.c @@ -12

[FFmpeg-devel] [PATCH 7/9] avcodec/mpegvideo_enc: Don't copy Picture unnecessarily

2022-08-09 Thread Andreas Rheinhardt
Also add const where possible. Signed-off-by: Andreas Rheinhardt --- libavcodec/mpegvideo_enc.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/libavcodec/mpegvideo_enc.c b/libavcodec/mpegvideo_enc.c index d45e15a039..2cd4db27bc 100644 --- a/libavcodec/mpegvid

[FFmpeg-devel] [PATCH 6/9] avcodec/mpegpicture: Move encoding_error and mb_var_sum to MpegEncCtx

2022-08-09 Thread Andreas Rheinhardt
These fields are only ever set by the encoder for the current picture and for no other picture. So only one set of these values needs to exist, so move them to MpegEncContext. Signed-off-by: Andreas Rheinhardt --- libavcodec/mpegpicture.c | 5 - libavcodec/mpegpicture.h | 5 - liba

[FFmpeg-devel] [PATCH 5/9] avutil/buffer: Never poison returned buffers

2022-08-09 Thread Andreas Rheinhardt
Poisoning returned buffers is based around the implicit assumption that the contents of said buffers are transient. Yet this is not true for the buffer pools used by the various hardware contexts which store important state in there that needs to be preserved. Furthermore, the current code is also

[FFmpeg-devel] [PATCH 4/9] avcodec/mpegpicture: Remove always-true checks

2022-08-09 Thread Andreas Rheinhardt
Of all the buffers that are made writable, three are always allocated and the other four are allocated iff any one of them is allocated; so one can replace the seven checks for existence with one. Signed-off-by: Andreas Rheinhardt --- libavcodec/mpegpicture.c | 15 --- 1 file changed

[FFmpeg-devel] [PATCH 3/9] avcodec/mpegutils: Constify ff_print_debug_info2, ff_draw_horiz_band

2022-08-09 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/mpegutils.c | 11 ++- libavcodec/mpegutils.h | 9 + 2 files changed, 11 insertions(+), 9 deletions(-) diff --git a/libavcodec/mpegutils.c b/libavcodec/mpegutils.c index 395bd38ff5..ff9418232b 100644 --- a/libavcodec/mpegutils.c ++

[FFmpeg-devel] [PATCH 2/9] avcodec/mpegutils: Combine multiple av_log statements

2022-08-09 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/mpegutils.c | 101 +++-- 1 file changed, 57 insertions(+), 44 deletions(-) diff --git a/libavcodec/mpegutils.c b/libavcodec/mpegutils.c index 4cbc474543..395bd38ff5 100644 --- a/libavcodec/mpegutils.c +++ b/liba

[FFmpeg-devel] [PATCH 1/9] avcodec/wmv2dec: Zero mb_type array for I pictures

2022-08-09 Thread Andreas Rheinhardt
Up until now, ff_wmv2_decode_secondary_picture_header() only set the mb_type array for non I-pictures, so that the decoding process uses the earlier values of this array; this affects the output of the wmv8-x8intra FATE-test (which this patch therefore updates). These earlier values were set when d

Re: [FFmpeg-devel] [RFC] git and signing commits and tags

2022-08-09 Thread Lynne
Aug 9, 2022, 13:02 by mich...@niedermayer.cc: > On Tue, Aug 09, 2022 at 12:59:52PM +0200, Michael Niedermayer wrote: > >> On Tue, Aug 09, 2022 at 12:36:53AM +0200, Michael Niedermayer wrote: >> > On Mon, Aug 08, 2022 at 09:26:52PM +0200, Lynne wrote: >> > > Aug 8, 2022, 16:50 by mich...@niedermaye

[FFmpeg-devel] [PATCH 1/2] arm: vc1sdp: Change stride parameters to ptrdiff_t

2022-08-09 Thread Martin Storsjö
This was missed in db54426975e124e98e5130ad01316cb7afd60630. Signed-off-by: Martin Storsjö --- In practice, ptrdiff_t and int are the same type on arm, so these didn't cause any warnings and haven't been caught due to that. --- libavcodec/arm/vc1dsp_init_neon.c | 12 ++-- 1 file changed,

[FFmpeg-devel] [PATCH 2/2] arm: rv40dsp: Change stride parameters to ptrdiff_t

2022-08-09 Thread Martin Storsjö
These were missed when h264_chroma_mc_func was changed in e4a94d8b36c48d95a7d412c40d7b558422ff659c. Signed-off-by: Martin Storsjö --- libavcodec/arm/rv40dsp_init_arm.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavcodec/arm/rv40dsp_init_arm.c b/libavcodec/arm/

Re: [FFmpeg-devel] [PATCH 1/2] lavc/aarch64: new 8-bit hevc 16x16 idct

2022-08-09 Thread Martin Storsjö
On Thu, 23 Jun 2022, J. Dekker wrote: old: hevc_idct_16x16_8_c: 5366.2 hevc_idct_16x16_8_neon: 1493.2 new: hevc_idct_16x16_8_c: 5363.2 hevc_idct_16x16_8_neon: 943.5 Co-developed-by: Rafal Dabrowa Signed-off-by: J. Dekker --- libavcodec/aarch64/hevcdsp_idct_neon.S| 666 +++

Re: [FFmpeg-devel] [FFmpeg-cvslog] doc/filters: clarify behaviour of weights in amix

2022-08-09 Thread Gyan Doshi
On 2022-08-09 04:55 pm, Hendrik Leppkes wrote: On Tue, Aug 9, 2022 at 12:46 PM Gyan Doshi wrote: On 2022-08-09 04:00 pm, Ronald S. Bultje wrote: On Tue, Aug 9, 2022 at 5:36 PM Gyan Doshi wrote: On 2022-08-09 02:57 pm, Anton Khirnov wrote: Quoting Gyan Doshi (2022-08-09 11:22:39) I am

Re: [FFmpeg-devel] [PATCH] lavc/aarch64: add hevc chroma loop filter 8-12bit

2022-08-09 Thread Martin Storsjö
On Thu, 23 Jun 2022, J. Dekker wrote: Signed-off-by: J. Dekker --- libavcodec/aarch64/Makefile | 3 +- libavcodec/aarch64/hevcdsp_deblock_neon.S | 168 ++ libavcodec/aarch64/hevcdsp_init_aarch64.c | 14 ++ 3 files changed, 184 insertions(+), 1 deletion(-) creat

Re: [FFmpeg-devel] [FFmpeg-cvslog] doc/filters: clarify behaviour of weights in amix

2022-08-09 Thread Hendrik Leppkes
On Tue, Aug 9, 2022 at 12:46 PM Gyan Doshi wrote: > > > > On 2022-08-09 04:00 pm, Ronald S. Bultje wrote: > > On Tue, Aug 9, 2022 at 5:36 PM Gyan Doshi wrote: > > > >> > >> On 2022-08-09 02:57 pm, Anton Khirnov wrote: > >>> Quoting Gyan Doshi (2022-08-09 11:22:39) > I am a docs maintainer so

Re: [FFmpeg-devel] [RFC] git and signing commits and tags

2022-08-09 Thread Gerion Entrup
Hi, Am Montag, 8. August 2022, 21:26:52 CEST schrieb Lynne: > Aug 8, 2022, 16:50 by mich...@niedermayer.cc: > > > Given the recent server issues, i wonder if we should suggest/recommand > > and document signing commits and tags > > > > i tried to push such commit to github and it nicely says "ver

Re: [FFmpeg-devel] [PATCH 3/3] lavc/aarch64: hevc_add_res add 12bit variants

2022-08-09 Thread Martin Storsjö
On Tue, 9 Aug 2022, Martin Storsjö wrote: On Thu, 23 Jun 2022, J. Dekker wrote: hevc_add_res_4x4_12_c: 46.0 hevc_add_res_4x4_12_neon: 18.7 hevc_add_res_8x8_12_c: 194.7 hevc_add_res_8x8_12_neon: 25.2 hevc_add_res_16x16_12_c: 716.0 hevc_add_res_16x16_12_neon: 69.7 hevc_add_res_32x32_12_c: 3820.7

Re: [FFmpeg-devel] [PATCH 3/3] lavc/aarch64: hevc_add_res add 12bit variants

2022-08-09 Thread Martin Storsjö
On Thu, 23 Jun 2022, J. Dekker wrote: hevc_add_res_4x4_12_c: 46.0 hevc_add_res_4x4_12_neon: 18.7 hevc_add_res_8x8_12_c: 194.7 hevc_add_res_8x8_12_neon: 25.2 hevc_add_res_16x16_12_c: 716.0 hevc_add_res_16x16_12_neon: 69.7 hevc_add_res_32x32_12_c: 3820.7 hevc_add_res_32x32_12_neon: 261.0 Signed-o

Re: [FFmpeg-devel] [PATCH 2/3] lavc/aarch64: reformat add_res funcs

2022-08-09 Thread Martin Storsjö
On Thu, 23 Jun 2022, J. Dekker wrote: Signed-off-by: J. Dekker --- libavcodec/aarch64/hevcdsp_idct_neon.S | 216 - 1 file changed, 108 insertions(+), 108 deletions(-) LGTM, thanks! // Martin ___ ffmpeg-devel mailing list ffm

Re: [FFmpeg-devel] [RFC] git and signing commits and tags

2022-08-09 Thread Michael Niedermayer
On Tue, Aug 09, 2022 at 12:59:52PM +0200, Michael Niedermayer wrote: > On Tue, Aug 09, 2022 at 12:36:53AM +0200, Michael Niedermayer wrote: > > On Mon, Aug 08, 2022 at 09:26:52PM +0200, Lynne wrote: > > > Aug 8, 2022, 16:50 by mich...@niedermayer.cc: > > > > > > > Given the recent server issues, i

Re: [FFmpeg-devel] [PATCH 1/3] checkasm/hevc_add_res: add 12bit test

2022-08-09 Thread Martin Storsjö
On Thu, 23 Jun 2022, J. Dekker wrote: Signed-off-by: J. Dekker --- tests/checkasm/hevc_add_res.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/tests/checkasm/hevc_add_res.c b/tests/checkasm/hevc_add_res.c index 0c896adaca..f17d121939 100644 --- a/tests/check

Re: [FFmpeg-devel] [RFC] git and signing commits and tags

2022-08-09 Thread Michael Niedermayer
On Tue, Aug 09, 2022 at 12:36:53AM +0200, Michael Niedermayer wrote: > On Mon, Aug 08, 2022 at 09:26:52PM +0200, Lynne wrote: > > Aug 8, 2022, 16:50 by mich...@niedermayer.cc: > > > > > Given the recent server issues, i wonder if we should suggest/recommand > > > and document signing commits and t

Re: [FFmpeg-devel] [PATCH] avcodec/mpegpicture: Move mb_var, mc_mb_var and mb_mean to MpegEncCtx

2022-08-09 Thread Andreas Rheinhardt
Andreas Rheinhardt: > These tables are only used by encoders and only for the current picture; > ergo they need not be put into the picture at all, but rather into > the encoder's context. They also don't need to be refcounted, > because there is only one owner. > > In contrast to this, the earlie

Re: [FFmpeg-devel] [FFmpeg-cvslog] doc/filters: clarify behaviour of weights in amix

2022-08-09 Thread Gyan Doshi
On 2022-08-09 04:00 pm, Ronald S. Bultje wrote: On Tue, Aug 9, 2022 at 5:36 PM Gyan Doshi wrote: On 2022-08-09 02:57 pm, Anton Khirnov wrote: Quoting Gyan Doshi (2022-08-09 11:22:39) I am a docs maintainer so I push these directly. All patches should go through the mailing list, so othe

Re: [FFmpeg-devel] [FFmpeg-cvslog] doc/filters: clarify behaviour of weights in amix

2022-08-09 Thread Ronald S. Bultje
On Tue, Aug 9, 2022 at 5:36 PM Gyan Doshi wrote: > > > On 2022-08-09 02:57 pm, Anton Khirnov wrote: > > Quoting Gyan Doshi (2022-08-09 11:22:39) > >> I am a docs maintainer so I push these directly. > > All patches should go through the mailing list, so other people get the > > opportunity to com

Re: [FFmpeg-devel] [FFmpeg-cvslog] doc/filters: clarify behaviour of weights in amix

2022-08-09 Thread Gyan Doshi
On 2022-08-09 03:15 pm, Anton Khirnov wrote: Quoting Gyan Doshi (2022-08-09 11:36:22) On 2022-08-09 02:57 pm, Anton Khirnov wrote: Quoting Gyan Doshi (2022-08-09 11:22:39) I am a docs maintainer so I push these directly. All patches should go through the mailing list, so other people get

Re: [FFmpeg-devel] [FFmpeg-cvslog] doc/filters: clarify behaviour of weights in amix

2022-08-09 Thread Anton Khirnov
Quoting Gyan Doshi (2022-08-09 11:36:22) > > > On 2022-08-09 02:57 pm, Anton Khirnov wrote: > > Quoting Gyan Doshi (2022-08-09 11:22:39) > >> I am a docs maintainer so I push these directly. > > All patches should go through the mailing list, so other people get the > > opportunity to comment on

Re: [FFmpeg-devel] [PATCH v2] mov: Compare frag times in correct time base when seeking a stream without a corresponding sidx

2022-08-09 Thread zhilizhao(赵志立)
> On Aug 3, 2022, at 9:18 PM, Derek Buitenhuis > wrote: > > Some muxers, such as GPAC, create files with only one sidx, but two streams > muxed into the same fragments pointed to by this sidx. > > Prevously, in such a case, when we seeked in such files, we fell back > to, for example, using t

Re: [FFmpeg-devel] [FFmpeg-cvslog] doc/filters: clarify behaviour of weights in amix

2022-08-09 Thread Gyan Doshi
On 2022-08-09 02:57 pm, Anton Khirnov wrote: Quoting Gyan Doshi (2022-08-09 11:22:39) I am a docs maintainer so I push these directly. All patches should go through the mailing list, so other people get the opportunity to comment on them. I do that for more extensive changes. As the guide

Re: [FFmpeg-devel] [FFmpeg-cvslog] doc/filters: clarify behaviour of weights in amix

2022-08-09 Thread Anton Khirnov
Quoting Gyan Doshi (2022-08-09 11:22:39) > I am a docs maintainer so I push these directly. All patches should go through the mailing list, so other people get the opportunity to comment on them. -- Anton Khirnov ___ ffmpeg-devel mailing list ffmpeg-de

Re: [FFmpeg-devel] [FFmpeg-cvslog] doc/filters: clarify behaviour of weights in amix

2022-08-09 Thread Anton Khirnov
I do not see this patch on the mailing list. -- Anton Khirnov ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject