[FFmpeg-devel] [PATCH] avcodec/acelp_*: Remove unnecessary headers

2022-08-01 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/acelp_filters.c | 2 +- libavcodec/acelp_pitch_delay.c | 2 -- libavcodec/acelp_vectors.c | 4 ++-- 3 files changed, 3 insertions(+), 5 deletions(-) diff --git a/libavcodec/acelp_filters.c b/libavcodec/acelp_filters.c index 9182579330..db4

[FFmpeg-devel] [PATCH v5 4/4] avcodec/h264chroma: Constify src in h264_chroma_mc_func

2022-08-01 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/aarch64/h264chroma_init_aarch64.c | 12 +- libavcodec/aarch64/h264cmc_neon.S| 4 +- libavcodec/aarch64/rv40dsp_init_aarch64.c| 8 +- libavcodec/aarch64/vc1dsp_init_aarch64.c | 8 +- libavcodec/arm/h264chroma_init_arm.c

[FFmpeg-devel] [PATCH v5 3/4] avcodec/loongarch/h264chroma, vc1dsp_lasx: Add wrapper for __lasx_xvldx

2022-08-01 Thread Andreas Rheinhardt
__lasx_xvldx does not accept a pointer to const (in fact, no function in lasxintrin.h does so), although it is not allowed to modify the pointed-to buffer. Therefore this commit adds a wrapper for it in order to constify the H264Chroma API in a later commit. Signed-off-by: Andreas Rheinhardt ---

[FFmpeg-devel] [PATCH v5 1/4] avcodec/loongarch: Add wrapper for __lsx_vldx

2022-08-01 Thread Andreas Rheinhardt
__lsx_vldx does not accept a pointer to const (in fact, no function in lsxintrin.h does so), although it is not allowed to modify the pointed-to buffer. Therefore this commit adds a wrapper for it in order to constify the HEVC DSP functions in a later commit. Signed-off-by: Andreas Rheinhardt ---

Re: [FFmpeg-devel] [PATCH 2/2] fate/lavf-image: Disable file checksums for exr tests

2022-08-01 Thread Andreas Rheinhardt
Andreas Rheinhardt: > The generated files are endian-dependent, so no checksums > may be part of the ref files. > > Fixes ticket #9854. > > Signed-off-by: Andreas Rheinhardt > --- > It is actually untested whether this fixes ticket #9854 > as the commit message claims. I will ask the author of #

Re: [FFmpeg-devel] [PATCH 2/2] Provided support for MPEG-5 EVC (Essential Video Coding) codec

2022-08-01 Thread Michael Niedermayer
On Mon, Aug 01, 2022 at 11:29:01AM +0200, Dawid Kozinski wrote: [...] > +static int get_nalu_type(const uint8_t *bits, int bits_size) > +{ > +int unit_type_plus1 = 0; > + > +if(bits_size >= EVC_NAL_HEADER_SIZE) { > +unsigned char *p = (unsigned char *)bits; > +// forbidden_

Re: [FFmpeg-devel] [PATCH 1/2] Provided support for MPEG-5 EVC (Essential Video Coding) codec

2022-08-01 Thread James Almer
On 8/1/2022 6:28 AM, Dawid Kozinski wrote: diff --git a/libavcodec/libxevd.c b/libavcodec/libxevd.c new file mode 100644 index 00..8ba2d89cbd --- /dev/null +++ b/libavcodec/libxevd.c @@ -0,0 +1,436 @@ +/* + * libxevd decoder + * EVC (MPEG-5 Essential Video Coding) decoding using XEVD MPEG

Re: [FFmpeg-devel] Enhancement layers in FFmpeg

2022-08-01 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Niklas Haas > Sent: Monday, August 1, 2022 3:59 PM > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] Enhancement layers in FFmpeg > > On Mon, 01 Aug 2022 13:17:12 + Soft Works >

Re: [FFmpeg-devel] [PATCH 2/2] Provided support for MPEG-5 EVC (Essential Video Coding) codec

2022-08-01 Thread James Almer
On 8/1/2022 6:29 AM, Dawid Kozinski wrote: diff --git a/libavformat/movenc.c b/libavformat/movenc.c index 5608afde42..d0b094c30d 100644 --- a/libavformat/movenc.c +++ b/libavformat/movenc.c @@ -1392,6 +1392,16 @@ static int mov_write_hvcc_tag(AVIOContext *pb, MOVTrack *track) return update

Re: [FFmpeg-devel] Enhancement layers in FFmpeg

2022-08-01 Thread Niklas Haas
On Mon, 01 Aug 2022 13:17:12 + Soft Works wrote: > From my (rather limited) angle of view, my thoughts are these: > > When decoding these kinds of sources, a user would typically not only > want to do the processing in hardware but the decoding as well. > > I think we cannot realistically ex

Re: [FFmpeg-devel] [PATCH] configure: Check for DXGI_OUTDUPL_FRAME_INFO for the ddagrab filter

2022-08-01 Thread Timo Rothenpieler
Yeah, doesn't really matter what of the two we check for. Type and DDA API should always exist in tandem. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email f

Re: [FFmpeg-devel] [PATCH] configure: Check for DXGI_OUTDUPL_FRAME_INFO for the ddagrab filter

2022-08-01 Thread Hendrik Leppkes
On Mon, Aug 1, 2022 at 2:56 PM Martin Storsjö wrote: > > On Mon, 1 Aug 2022, Hendrik Leppkes wrote: > > > On Mon, Aug 1, 2022 at 2:36 PM Martin Storsjö wrote: > >> > >> The DXGI_OUTDUPL_FRAME_INFO type isn't available in Windows API > >> subsets other than "desktop", while the IDXGIOutput1 interf

Re: [FFmpeg-devel] Enhancement layers in FFmpeg

2022-08-01 Thread Hendrik Leppkes
On Mon, Aug 1, 2022 at 1:25 PM Niklas Haas wrote: > > Hey, > > We need to think about possible ways to implement reasonably-transparent > support for enhancement layers in FFmpeg. (SVC, Dolby Vision, ...). > There are more open questions than answers here. > > From what I can tell, these are basic

Re: [FFmpeg-devel] [PATCH v12 11/13] lavc/qsv: create mfx session using oneVPL for decoding/encoding

2022-08-01 Thread Anton Khirnov
Quoting Xiang, Haihao (2022-07-25 06:11:49) > From: Haihao Xiang > > If qsv hwdevice is available, use the mfxLoader handle in qsv hwdevice > to create mfx session. Otherwise create mfx session with a new mfxLoader > handle. > > This is in preparation for oneVPL support > --- > libavcodec/qsv.c

Re: [FFmpeg-devel] [PATCH v12 13/13] configure: add --enable-libvpl option

2022-08-01 Thread Anton Khirnov
Quoting Xiang, Haihao (2022-07-25 06:11:51) > +elif enabled libvpl; then > +# Consider pkg-config only. The name of libmfx is still passed to > check_pkg_config function for --enable-libvpl option > +# because QSV has dependency on libmfx, we can use the same dependency if > using libmfx in this

Re: [FFmpeg-devel] Enhancement layers in FFmpeg

2022-08-01 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Niklas Haas > Sent: Monday, August 1, 2022 1:25 PM > To: ffmpeg-devel@ffmpeg.org > Subject: [FFmpeg-devel] Enhancement layers in FFmpeg > > Hey, > > We need to think about possible ways to implement reasonably- > transparent > su

[FFmpeg-devel] [PATCH 3/3] avcodec/h264chroma: Constify src in h264_chroma_mc_func

2022-08-01 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/aarch64/h264chroma_init_aarch64.c | 12 +- libavcodec/aarch64/h264cmc_neon.S| 4 +- libavcodec/aarch64/rv40dsp_init_aarch64.c| 8 +- libavcodec/aarch64/vc1dsp_init_aarch64.c | 8 +- libavcodec/arm/h264chroma_init_arm.c

[FFmpeg-devel] [PATCH 2/3] avcodec/hevcdec: Constify src pointers of HEVC DSP functions

2022-08-01 Thread Andreas Rheinhardt
This is possible now that the HEVC DSP API treats them as const. Also constify the AVFrames whose data is used as source in such cases. Signed-off-by: Andreas Rheinhardt --- libavcodec/hevcdec.c | 26 ++ 1 file changed, 14 insertions(+), 12 deletions(-) diff --git a/liba

Re: [FFmpeg-devel] [PATCH] configure: Check for DXGI_OUTDUPL_FRAME_INFO for the ddagrab filter

2022-08-01 Thread Martin Storsjö
On Mon, 1 Aug 2022, Hendrik Leppkes wrote: On Mon, Aug 1, 2022 at 2:36 PM Martin Storsjö wrote: The DXGI_OUTDUPL_FRAME_INFO type isn't available in Windows API subsets other than "desktop", while the IDXGIOutput1 interface is available for all API subsets. This fixes compilation for UWP/"Win

Re: [FFmpeg-devel] [PATCH] configure: Check for DXGI_OUTDUPL_FRAME_INFO for the ddagrab filter

2022-08-01 Thread Hendrik Leppkes
On Mon, Aug 1, 2022 at 2:36 PM Martin Storsjö wrote: > > The DXGI_OUTDUPL_FRAME_INFO type isn't available in Windows API > subsets other than "desktop", while the IDXGIOutput1 interface is > available for all API subsets. > > This fixes compilation for UWP/"Windows Store" configurations (and > old

[FFmpeg-devel] [PATCH 2/2] fate/lavf-image: Disable file checksums for exr tests

2022-08-01 Thread Andreas Rheinhardt
The generated files are endian-dependent, so no checksums may be part of the ref files. Fixes ticket #9854. Signed-off-by: Andreas Rheinhardt --- It is actually untested whether this fixes ticket #9854 as the commit message claims. I will ask the author of #9854 to test it. tests/fate/lavf-ima

[FFmpeg-devel] [PATCH 1/2] tests/fate-run: Allow to skip file checksums for lavf_image

2022-08-01 Thread Andreas Rheinhardt
The output file (even the filesize) of the recently added EXR tests depends on the endianness; therefore checksums of these files must not be part of the ref file. Therefore this commit adds an option (unused for now) to disable these checksums on a per-test basis. In order to avoid having to chec

Re: [FFmpeg-devel] [PATCH] configure: Check for DXGI_OUTDUPL_FRAME_INFO for the ddagrab filter

2022-08-01 Thread Timo Rothenpieler
Very weird decision by Microsoft there for sure. Patch LGTM ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "u

[FFmpeg-devel] [PATCH] configure: Check for DXGI_OUTDUPL_FRAME_INFO for the ddagrab filter

2022-08-01 Thread Martin Storsjö
The DXGI_OUTDUPL_FRAME_INFO type isn't available in Windows API subsets other than "desktop", while the IDXGIOutput1 interface is available for all API subsets. This fixes compilation for UWP/"Windows Store" configurations (and older API subsets like Windows Phone). Signed-off-by: Martin Storsjö

Re: [FFmpeg-devel] [PATCH 1/2] Provided support for MPEG-5 EVC (Essential Video Coding) codec

2022-08-01 Thread James Almer
On 8/1/2022 6:28 AM, Dawid Kozinski wrote: diff --git a/libavcodec/evc_parser.c b/libavcodec/evc_parser.c new file mode 100644 index 00..b2136a6b45 --- /dev/null +++ b/libavcodec/evc_parser.c @@ -0,0 +1,526 @@ +/* + * EVC format parser + * + * Copyright (C) 2021 Dawid Kozinski + * + * Thi

[FFmpeg-devel] [PATCH 11/11] avcodec/avcodec: Remove AV_CODEC_FLAG2_DROP_FRAME_TIMECODE

2022-08-01 Thread Andreas Rheinhardt
It has been deprecated in 94d68a41fabb55dd8c7e59b88fe4a28a637d1e5f and can't be set via AVOptions. The only codecs that use it (the MPEG-1/2 encoders) have private options for this. So remove it. Signed-off-by: Andreas Rheinhardt --- libavcodec/avcodec.h | 5 - libavcodec/mpeg12enc.c | 1 -

[FFmpeg-devel] [PATCH 10/11] avcodec/avcodec: Remove legacy cruft

2022-08-01 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/avcodec.h | 7 --- 1 file changed, 7 deletions(-) diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h index 60b215d2e9..abd6272f63 100644 --- a/libavcodec/avcodec.h +++ b/libavcodec/avcodec.h @@ -338,13 +338,6 @@ typedef struct RcOverride

[FFmpeg-devel] [PATCH 09/11] avcodec/aacenc_quantization: Deduplicate quantization functions

2022-08-01 Thread Andreas Rheinhardt
Up until now, there were four copies of quantize_and_encode_band_cost_(ZERO|[SU]QUAD|[SU]PAIR|ESC|NONE|NOISE|STEREO) (namely in aaccoder.o, aacenc_is.o, aacenc_ltp.o, aacenc_pred.o). As 43b378a0d321e3d01f196cec95e13acfac80d464 says, this is meant to enable more optimizations. Yet neither GCC nor C

[FFmpeg-devel] [PATCH 08/11] avcodec/aacenc_tns: Remove unused header

2022-08-01 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/aacenc_tns.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavcodec/aacenc_tns.c b/libavcodec/aacenc_tns.c index 2ffe1f8de8..195ff5e2b7 100644 --- a/libavcodec/aacenc_tns.c +++ b/libavcodec/aacenc_tns.c @@ -30,7 +30,6 @@ #include "aacenc_tn

[FFmpeg-devel] [PATCH 07/11] avcodec/aacenc_quantization: Remove always-zero function parameter

2022-08-01 Thread Andreas Rheinhardt
rtz is only ever nonzero for quantize_and_encode_band(). Signed-off-by: Andreas Rheinhardt --- This commit touches aaccoder_mips.c, but honestly I was not able to compile it at all (neither before nor after this change), because all I got were errors like: "{standard input}:1114: Error: float reg

[FFmpeg-devel] [PATCH 06/11] avcodec/sbrdsp: Remove unnecessary headers

2022-08-01 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/sbrdsp.c | 1 - libavcodec/sbrdsp.h | 1 - libavcodec/sbrdsp_fixed.c | 1 - 3 files changed, 3 deletions(-) diff --git a/libavcodec/sbrdsp.c b/libavcodec/sbrdsp.c index a93b5f9c13..8d6ffdfe7e 100644 --- a/libavcodec/sbrdsp.c +++ b/liba

[FFmpeg-devel] [PATCH 05/11] avcodec/aacenc: Move aac_pce_configs to its only user

2022-08-01 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/aacenc.c | 273 libavcodec/aacenc.h | 273 2 files changed, 273 insertions(+), 273 deletions(-) diff --git a/libavcodec/aacenc.c b/libavcodec/aacenc.c index

[FFmpeg-devel] [PATCH 04/11] fftools/ffmpeg_opt: Fix copyinkf

2022-08-01 Thread Andreas Rheinhardt
Broken in 9c2b800203a5a8f3d83f3b8f28e8c50d28186b39. Signed-off-by: Andreas Rheinhardt --- fftools/ffmpeg_opt.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/fftools/ffmpeg_opt.c b/fftools/ffmpeg_opt.c index d7049069f4..a96bcf9b8a 100644 --- a/fftools/ffmpeg_opt.c +++ b/fftools/ffmpeg_op

[FFmpeg-devel] [PATCH 02/11] avcodec/flacdsp: Split encoder-only parts into a ctx of its own

2022-08-01 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- configure | 4 +--- libavcodec/Makefile | 5 ++-- libavcodec/arm/Makefile | 4 ++-- libavcodec/arm/flacdsp_init_arm.c | 5 +--- libavcodec/flacdsp.c | 4 libavcodec/flacenc.c

[FFmpeg-devel] [PATCH 03/11] avcodec/internal: Move ff_thread_can_start_frame() to threadframe.h

2022-08-01 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/internal.h| 2 -- libavcodec/threadframe.h | 2 ++ 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/internal.h b/libavcodec/internal.h index 8809a7079a..b1a49579d8 100644 --- a/libavcodec/internal.h +++ b/libavcodec/int

[FFmpeg-devel] [PATCH 01/11] avcodec/flacdsp: Remove unused function parameter

2022-08-01 Thread Andreas Rheinhardt
Forgotten in e609cfd697f8eed7325591f767585041719807d1. Signed-off-by: Andreas Rheinhardt --- libavcodec/arm/flacdsp_init_arm.c | 3 +-- libavcodec/flacdec.c | 6 +++--- libavcodec/flacdsp.c | 7 +++ libavcodec/flacdsp.h | 6 +++--- libavcodec/flacenc.c

[FFmpeg-devel] [PATCH v2 2/2] libavcodec/flacenc: Implement encoding of 32 bit-per-sample PCM

2022-08-01 Thread Martijn van Beurden
Add encoding of 32 bit-per-sample PCM to FLAC files to libavcodec. Coding to this format is at this point considered experimental and -strict -2 is needed to get ffmpeg to encode such files. --- libavcodec/flacenc.c| 499 libavcodec/put_bits.h | 7 +

[FFmpeg-devel] [PATCH v2 1/2] libavcodec/flacdec: Implement decoding of 32 bit-per-sample PCM

2022-08-01 Thread Martijn van Beurden
Add decoding of FLAC files coding for 32 bit-per-sample PCM to libavcodec. --- libavcodec/flac.c | 4 +- libavcodec/flacdec.c | 248 ++ libavcodec/get_bits.h | 12 ++ libavcodec/mathops.h | 9 ++ 4 files changed, 250 insertions(+), 23 deletions(-)

[FFmpeg-devel] [PATCH v2 0/2] 32bps FLAC patches

2022-08-01 Thread Martijn van Beurden
Recently libFLAC gained the ability (not in any released version yet though) to create FLAC files containing 32-bit int PCM samples. To keep complexity reasonable, the choice was made to limit residuals to 32-bit integers, which the encoder must make sure of. In case the encoder cannot find any pre

[FFmpeg-devel] Enhancement layers in FFmpeg

2022-08-01 Thread Niklas Haas
Hey, We need to think about possible ways to implement reasonably-transparent support for enhancement layers in FFmpeg. (SVC, Dolby Vision, ...). There are more open questions than answers here. >From what I can tell, these are basically separate bitstreams that carry some amount of auxiliary inf

Re: [FFmpeg-devel] [PATCH 1/3] Provided support for MPEG-5 EVC (Essential Video Coding) codec

2022-08-01 Thread PLT
I've just created two new patches and sent them to the mailing list. All your comments and hints have been taken into account. -Original Message- From: ffmpeg-devel On Behalf Of Anton Khirnov Sent: Friday, July 1, 2022 10:57 AM To: FFmpeg development discussions and patches Subject: Re:

[FFmpeg-devel] [PATCH 2/2] Provided support for MPEG-5 EVC (Essential Video Coding) codec

2022-08-01 Thread Dawid Kozinski
- Added muxer for EVC format (MP4, raw) - Added demuxer for EVC format (MP4) - Added evc extension to the list of extensions for ff_mov_demuxer Signed-off-by: Dawid Kozinski --- doc/muxers.texi | 6 ++ libavformat/Makefile | 2 + libavformat/allformats.c | 2 + libavformat/evc

[FFmpeg-devel] [PATCH 1/2] Provided support for MPEG-5 EVC (Essential Video Coding) codec

2022-08-01 Thread Dawid Kozinski
- Added new entry to codec IDs list - Added new entry to the codec descriptor list - Bumped libavcodec minor version - Changes in Changelog and MAINTAINERS files - Added xeve encoder wrapper - Added xevd dencoder wrapper - Added documentation for xeve and xevd wrappers - Added parser for EVC format

Re: [FFmpeg-devel] [PATCH v3 2/2] ffmpeg_opt: consider HW acceleration method when selecting decoder

2022-08-01 Thread Anton Khirnov
Hi, the concept is generally ok, but I have a few comments on the implementation. Quoting Xiang, Haihao (2022-07-25 06:30:51) > +static const AVCodec *choose_decoder2(InputStream *ist, OptionsContext *o, > AVFormatContext *s, AVStream *st) > +{ > +char *codec_name = NULL; > + > +MATCH_PER