Re: [FFmpeg-devel] [PATCH 14/18] avcodec/hevcdec: Don't allocate redundant HEVCContexts

Michael Niedermayer: > On Sat, Jul 23, 2022 at 07:44:40AM +0200, Andreas Rheinhardt wrote: >> Andreas Rheinhardt: >>> Michael Niedermayer: On Sat, Jul 02, 2022 at 08:32:06AM +0200, Andreas Rheinhardt wrote: > Michael Niedermayer: >> On Fri, Jul 01, 2022 at 12:29:45AM +0200, Andreas Rhe

Re: [FFmpeg-devel] [PATCH] avcodec/hevcdec: Output MD5-message in one piece

Andreas Rheinhardt: > Otherwise, there is no guarantee that the various av_log-messages > are not interrupted by another log statement. The latter may originate > from anywhere else, even the HEVC decoder itself, as happens when > one uses frame-threading to decode the BUMPING_A_ericsson_1.bit > sa

Re: [FFmpeg-devel] ABI break in 5.1

On Sat, 23 Jul 2022, at 16:03, Jan Engelhardt wrote: > (Or, in today's terms, a program built with 5.1 but which is > combined with 5.0 at runtime, then this can happen: FFmpeg 5.1 and 5.0 are two major versions and never ever are guaranteed to be compatible backwardly. Your tools show that we o

Re: [FFmpeg-devel] ABI break in 5.1

Jan Engelhardt (12022-07-23): > The information in ELF helps package managers prevent such > replacement. Key word: help. > Seriously, why do I have to explain this all the time. Maybe because you are never convincing. Regards, -- Nicolas George signature.asc Description: PGP signature __

Re: [FFmpeg-devel] ABI break in 5.1

On Saturday 2022-07-23 16:32, Nicolas George wrote: > >No, the ELF symbol version system cannot prevent you from replacing a >file with an older version. The information in ELF helps package managers prevent such replacement. If I even try as much as propose a glibc downgrade to rpm, this will h

[FFmpeg-devel] [PATCH v2] fftools/objpool: Don't use return with expression when returning void

Using tail calls with functions returning void is forbidden (C99/C11 6.8.6.4: "A return statement with an expression shall not appear in a function whose return type is void.") GCC emits a warning because of this when using -pedantic: "ISO C forbids ‘return’ with expression, in function returning v

[FFmpeg-devel] [PATCH] avformat/lrcenc: Avoid reading packet padding

(Everything would be fine if the packet was properly padded.) Signed-off-by: Andreas Rheinhardt --- libavformat/lrcenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/lrcenc.c b/libavformat/lrcenc.c index cdf94e6cd2..f7a5a6982d 100644 --- a/libavformat/lrcenc.c

Re: [FFmpeg-devel] [PATCH] fftools/objpool: Don't use return with expression when returning void

Hendrik Leppkes: > On Sat, Jul 23, 2022 at 6:24 PM Andreas Rheinhardt > wrote: >> >> Using tail calls with functions returning void is forbidden >> (C99/C11 6.8.6.4: "A return statement with an expression shall not appear >> in a function whose return type is void.") GCC emits a warning >> because

Re: [FFmpeg-devel] [PATCH] fftools/objpool: Don't use return with expression when returning void

On Sat, Jul 23, 2022 at 6:24 PM Andreas Rheinhardt wrote: > > Using tail calls with functions returning void is forbidden > (C99/C11 6.8.6.4: "A return statement with an expression shall not appear > in a function whose return type is void.") GCC emits a warning > because of this when using -pedan

[FFmpeg-devel] [PATCH] fftools/ffmpeg: Zero subtitle packet padding

Fixes uninitialized reads in the sub-lrc-remux test. Signed-off-by: Andreas Rheinhardt --- fftools/ffmpeg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c index 632ac25cb2..1089cc48c4 100644 --- a/fftools/ffmpeg.c +++ b/fftools/ffmpeg.c @@

[FFmpeg-devel] [PATCH] fftools/objpool: Don't use return with expression when returning void

Using tail calls with functions returning void is forbidden (C99/C11 6.8.6.4: "A return statement with an expression shall not appear in a function whose return type is void.") GCC emits a warning because of this when using -pedantic: "ISO C forbids ‘return’ with expression, in function returning v

[FFmpeg-devel] [PATCH v2 5/5] avcodec/vp8, vp9: Avoid using VP56mv and VP56Frame in VP8/9

Instead replace VP56mv by new and identical structures VP8mv and VP9mv. Also replace VP56Frame by VP8FrameType in vp8.h and use that in VP8 code. Also remove VP56_FRAME_GOLDEN2, as this has only been used by VP8, and use VP8_FRAME_ALTREF as replacement for its usage in VP8 as this is more in line w

Re: [FFmpeg-devel] [PATCH 01/27] fftools/ffmpeg: replace AVFrame.pkt_duration with duration

Anton Khirnov: > Mistakenly reintroduced in 4740fea7ddf. > --- > fftools/ffmpeg.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c > index 632ac25cb2..841dd6f08a 100644 > --- a/fftools/ffmpeg.c > +++ b/fftools/ffmpeg.c > @@ -1216,1

Re: [FFmpeg-devel] [PATCH 5/5] avcodec/vp8, vp9: Avoid using VP56mv and VP56Frame in VP8/9

Ronald S. Bultje: > Hi, > > On Sat, Jul 23, 2022 at 1:16 PM Andreas Rheinhardt < > andreas.rheinha...@outlook.com> wrote: > >> Instead replace VP56mv by new and identical structures VP8mv and VP9mv. >> Also replace VP56Frame by VP8FrameType in vp8.h and use that >> in VP8 code. Also remove VP56_F

Re: [FFmpeg-devel] [FFmpeg-cvslog] [ffmpeg-web] branch master updated. 42a0288 web/download: Add FFmpeg 5.1

On 7/23/2022 11:53 AM, Michael Niedermayer wrote: On Sat, Jul 23, 2022 at 09:55:15AM +0530, Gyan Doshi wrote: On 2022-07-23 02:16 am, Michael Niedermayer wrote: On Sat, Jul 23, 2022 at 12:06:29AM +0530, Gyan Doshi wrote: Is the News entry forthcoming? sounds like you want to write the news

Re: [FFmpeg-devel] [FFmpeg-cvslog] [ffmpeg-web] branch master updated. 42a0288 web/download: Add FFmpeg 5.1

On Sat, Jul 23, 2022 at 09:55:15AM +0530, Gyan Doshi wrote: > > > On 2022-07-23 02:16 am, Michael Niedermayer wrote: > > On Sat, Jul 23, 2022 at 12:06:29AM +0530, Gyan Doshi wrote: > > > Is the News entry forthcoming? > > sounds like you want to write the news entry? > > Not exactly. For 4.3, it

Re: [FFmpeg-devel] [PATCH V2] lavf/dnn: dump OpenVINO model input/output names to OVMdel struct.

-Original Message- From: ffmpeg-devel On Behalf Of Ting Fu Sent: 2022年7月21日 17:41 To: ffmpeg-devel@ffmpeg.org Subject: [FFmpeg-devel] [PATCH V2] lavf/dnn: dump OpenVINO model input/output names to OVMdel struct. Dump all input/output names to OVModel struct. In case other funcs use the

Re: [FFmpeg-devel] [PATCH 14/18] avcodec/hevcdec: Don't allocate redundant HEVCContexts

On Sat, Jul 23, 2022 at 07:44:40AM +0200, Andreas Rheinhardt wrote: > Andreas Rheinhardt: > > Michael Niedermayer: > >> On Sat, Jul 02, 2022 at 08:32:06AM +0200, Andreas Rheinhardt wrote: > >>> Michael Niedermayer: > On Fri, Jul 01, 2022 at 12:29:45AM +0200, Andreas Rheinhardt wrote: > > T

Re: [FFmpeg-devel] ABI break in 5.1

Jan Engelhardt (12022-07-23): > As I have previously explained, > [ http://ffmpeg.org/pipermail/ffmpeg-devel/2020-July/265705.html ] Read the replies that have been made to you at the time. > (Or, in today's terms, a program built with 5.1 but which is > combined with 5.0 at runtime, then this ca

[FFmpeg-devel] [PATCH 19/27] fftools/ffmpeg_opt: reduce indentation in map_auto_video()

Fix indentation after the previous commit. Also use an early return to save one extra indentation level. --- fftools/ffmpeg_opt.c | 72 +++- 1 file changed, 37 insertions(+), 35 deletions(-) diff --git a/fftools/ffmpeg_opt.c b/fftools/ffmpeg_opt.c index 4d2

[FFmpeg-devel] [PATCH 07/27] fftools/ffmpeg: drop OutputStream.ref_par

It serves no purpose, codec parameters can be written directly to AVStream.codecpar with the same effect. --- fftools/ffmpeg.c | 37 - fftools/ffmpeg.h | 1 - fftools/ffmpeg_opt.c | 6 -- 3 files changed, 16 insertions(+), 28 deletions(-) diff --g

[FFmpeg-devel] [PATCH 14/27] fftools/ffmpeg: deprecate the -map_channel option

It is now entirely redundant with audio filters, and is in fact implemented by setting up a 'pan' filter instance. --- doc/ffmpeg.texi | 4 fftools/ffmpeg.c| 2 ++ fftools/ffmpeg.h| 7 +++ fftools/ffmpeg_filter.c | 2 ++ fftools/ffmpeg_opt.c| 19 +++

[FFmpeg-devel] [PATCH 16/27] fftools/ffmpeg_mux: move some functions closer to their only callers

--- fftools/ffmpeg_mux.c | 196 +-- 1 file changed, 98 insertions(+), 98 deletions(-) diff --git a/fftools/ffmpeg_mux.c b/fftools/ffmpeg_mux.c index 7f6da997a4..08a76f0066 100644 --- a/fftools/ffmpeg_mux.c +++ b/fftools/ffmpeg_mux.c @@ -74,48 +74,6 @@ struc

[FFmpeg-devel] [PATCH 10/27] fftools/ffmpeg: stop allocating an encoder context when not encoding

--- fftools/ffmpeg.c | 12 +--- fftools/ffmpeg_opt.c | 36 2 files changed, 25 insertions(+), 23 deletions(-) diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c index 0e30f8ce01..30618c6a6a 100644 --- a/fftools/ffmpeg.c +++ b/fftools/ffmpeg.c @@ -146

[FFmpeg-devel] [PATCH 06/27] fftools/ffmpeg: drop the -vol option

It has been deprecated in favor of the volume filter since 2012. --- fftools/ffmpeg.c| 4 fftools/ffmpeg_filter.c | 10 -- fftools/ffmpeg_opt.c| 3 --- 3 files changed, 17 deletions(-) diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c index 1cf704ab82..1780e535ae 100644

[FFmpeg-devel] [PATCH 11/27] fftools/ffmpeg_opt: drop a redundant assignment

The codec type will be set by avcodec_alloc_context3(), there is no reason to set it manually. --- fftools/ffmpeg_opt.c | 1 - 1 file changed, 1 deletion(-) diff --git a/fftools/ffmpeg_opt.c b/fftools/ffmpeg_opt.c index f6e354355b..29bc4fd97f 100644 --- a/fftools/ffmpeg_opt.c +++ b/fftools/ffmpeg

[FFmpeg-devel] [PATCH 08/27] fftools/ffmpeg: do not use the encoder context for streamcopy

The streamcopy initialization code briefly needs an AVCodecContext to apply AVOptions to. Allocate a temporary codec context, do not use the encoding one. --- fftools/ffmpeg.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c ind

[FFmpeg-devel] [PATCH 26/27] fftools/ffmpeg_opt: factor manually mapping streams out of open_output_file()

--- fftools/ffmpeg_opt.c | 157 ++- 1 file changed, 81 insertions(+), 76 deletions(-) diff --git a/fftools/ffmpeg_opt.c b/fftools/ffmpeg_opt.c index a472b254cb..672ac87b3e 100644 --- a/fftools/ffmpeg_opt.c +++ b/fftools/ffmpeg_opt.c @@ -2632,13 +2632,91 @@

[FFmpeg-devel] [PATCH 21/27] fftools/ffmpeg_opt: reduce indentation in map_auto_audio()

Fix indentation after the previous commit. Also use an early return to save one extra indentation level. --- fftools/ffmpeg_opt.c | 57 ++-- 1 file changed, 29 insertions(+), 28 deletions(-) diff --git a/fftools/ffmpeg_opt.c b/fftools/ffmpeg_opt.c index e42

[FFmpeg-devel] [PATCH 23/27] fftools/ffmpeg_opt: reduce indentation in map_auto_subtitle()

Fix indentation after the previous commit. Also use an early return to save one extra indentation level. --- fftools/ffmpeg_opt.c | 60 +++- 1 file changed, 31 insertions(+), 29 deletions(-) diff --git a/fftools/ffmpeg_opt.c b/fftools/ffmpeg_opt.c index da7

[FFmpeg-devel] [PATCH 09/27] fftools/ffmpeg: deprecate -psnr

It is entirely redundant with -flags +psnr. --- doc/ffmpeg.texi | 3 ++- fftools/ffmpeg.h | 3 +++ fftools/ffmpeg_opt.c | 12 ++-- 3 files changed, 15 insertions(+), 3 deletions(-) diff --git a/doc/ffmpeg.texi b/doc/ffmpeg.texi index 0e657b0138..974d1c108f 100644 --- a/doc/ffmp

[FFmpeg-devel] [PATCH 25/27] fftools/ffmpeg_opt: reindent

--- fftools/ffmpeg_opt.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/fftools/ffmpeg_opt.c b/fftools/ffmpeg_opt.c index 287527f478..a472b254cb 100644 --- a/fftools/ffmpeg_opt.c +++ b/fftools/ffmpeg_opt.c @@ -2621,15 +2621,15 @@ static void map_auto_subtitl

[FFmpeg-devel] [PATCH 17/27] fftools/ffmpeg: do not log to the decoder context

That should only be done from inside the decoder. Log to NULL instead, as is the current convention in ffmpeg. --- fftools/ffmpeg.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c index 19173c75e1..cc0ede8a54 100644 --- a/fftools/ffmpeg.c

[FFmpeg-devel] [PATCH 18/27] fftools/ffmpeg_opt: factor auto-mapping video out of open_output_file()

--- fftools/ffmpeg_opt.c | 84 1 file changed, 46 insertions(+), 38 deletions(-) diff --git a/fftools/ffmpeg_opt.c b/fftools/ffmpeg_opt.c index e6f2fb597a..4d2cd13107 100644 --- a/fftools/ffmpeg_opt.c +++ b/fftools/ffmpeg_opt.c @@ -2495,6 +2495,50 @@ s

[FFmpeg-devel] [PATCH 15/27] fftools/ffmpeg_filter: drop a block commented out since 2012

Since the option it relates to is deprecated, it is highly unlikely to become useful. --- fftools/ffmpeg_filter.c | 13 - 1 file changed, 13 deletions(-) diff --git a/fftools/ffmpeg_filter.c b/fftools/ffmpeg_filter.c index 5d00bfe056..f9ae76f76d 100644 --- a/fftools/ffmpeg_filter.c ++

[FFmpeg-devel] [PATCH 27/27] fftools/ffmpeg_opt: reindent

--- fftools/ffmpeg_opt.c | 140 +-- 1 file changed, 70 insertions(+), 70 deletions(-) diff --git a/fftools/ffmpeg_opt.c b/fftools/ffmpeg_opt.c index 672ac87b3e..d7049069f4 100644 --- a/fftools/ffmpeg_opt.c +++ b/fftools/ffmpeg_opt.c @@ -2635,80 +2635,80 @@

[FFmpeg-devel] [PATCH 13/27] fftools/ffmpeg: move guess_input_channel_layout() to ffmpeg_opt.c

That is the only place where it is used. Also make it static. --- fftools/ffmpeg.c | 19 --- fftools/ffmpeg.h | 2 -- fftools/ffmpeg_opt.c | 19 +++ 3 files changed, 19 insertions(+), 21 deletions(-) diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c index f

[FFmpeg-devel] [PATCH 12/27] fftools/ffmpeg: drop unused hwaccel variables

--- fftools/ffmpeg.c | 3 --- fftools/ffmpeg.h | 6 -- 2 files changed, 9 deletions(-) diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c index 30618c6a6a..f39966f096 100644 --- a/fftools/ffmpeg.c +++ b/fftools/ffmpeg.c @@ -2275,7 +2275,6 @@ static int decode_video(InputStream *ist, AVPacket *p

[FFmpeg-devel] [PATCH 24/27] fftools/ffmpeg_opt: factor auto-mapping data streams out of open_output_file()

--- fftools/ffmpeg_opt.c | 28 1 file changed, 16 insertions(+), 12 deletions(-) diff --git a/fftools/ffmpeg_opt.c b/fftools/ffmpeg_opt.c index 04f4abb88a..287527f478 100644 --- a/fftools/ffmpeg_opt.c +++ b/fftools/ffmpeg_opt.c @@ -2618,6 +2618,20 @@ static void map_a

[FFmpeg-devel] [PATCH 22/27] fftools/ffmpeg_opt: factor auto-mapping subtitles out of open_output_file()

--- fftools/ffmpeg_opt.c | 70 1 file changed, 38 insertions(+), 32 deletions(-) diff --git a/fftools/ffmpeg_opt.c b/fftools/ffmpeg_opt.c index 174b1dd0eb..da74b0265a 100644 --- a/fftools/ffmpeg_opt.c +++ b/fftools/ffmpeg_opt.c @@ -2580,6 +2580,42 @@ s

[FFmpeg-devel] [PATCH 20/27] fftools/ffmpeg_opt: factor auto-mapping audio out of open_output_file()

--- fftools/ffmpeg_opt.c | 71 +--- 1 file changed, 40 insertions(+), 31 deletions(-) diff --git a/fftools/ffmpeg_opt.c b/fftools/ffmpeg_opt.c index 9b08c68ec5..e426768f7c 100644 --- a/fftools/ffmpeg_opt.c +++ b/fftools/ffmpeg_opt.c @@ -2541,6 +2541,44 @@ s

[FFmpeg-devel] [PATCH 03/27] fftools/ffmpeg: remove an unnecessary avcodec_close() call

No encoders can possibly be opened at this point. And even if some were, they would be closed in ffmpeg_cleanup(). --- fftools/ffmpeg.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c index 7c340f4570..1cf704ab82 100644 --- a/fftools/ff

[FFmpeg-devel] [PATCH 04/27] fftools/ffmpeg_filter: remove unused function argument

--- fftools/ffmpeg_filter.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fftools/ffmpeg_filter.c b/fftools/ffmpeg_filter.c index 122b17686a..f16f4b13b1 100644 --- a/fftools/ffmpeg_filter.c +++ b/fftools/ffmpeg_filter.c @@ -52,7 +52,7 @@ static const enum AVPixelFormat *

[FFmpeg-devel] [PATCH 05/27] fftools/ffmpeg_filter: do not pass the entire AVCodecContext to choose_pixel_fmt()

It only uses strict_std_compliance, so pass just that value. Makes it more clear what fields are accessed. --- fftools/ffmpeg_filter.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/fftools/ffmpeg_filter.c b/fftools/ffmpeg_filter.c index f16f4b13b1..f715ecb6b6 10064

[FFmpeg-devel] [PATCH 02/27] fftools/ffmpeg: stop accessing the encoder context unnecessarily

The same information is available from AVStream.codecpar. This will allow to stop allocating an encoder unless encoding is actually performed. --- fftools/ffmpeg.c | 15 --- fftools/ffmpeg_mux.c | 2 +- 2 files changed, 9 insertions(+), 8 deletions(-) diff --git a/fftools/ffmpeg.

[FFmpeg-devel] [PATCH 01/27] fftools/ffmpeg: replace AVFrame.pkt_duration with duration

Mistakenly reintroduced in 4740fea7ddf. --- fftools/ffmpeg.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c index 632ac25cb2..841dd6f08a 100644 --- a/fftools/ffmpeg.c +++ b/fftools/ffmpeg.c @@ -1216,18 +1216,18 @@ static void do_video_

Re: [FFmpeg-devel] ABI break in 5.1

On Saturday 2022-07-23 15:28, Nicolas George wrote: >Jan Engelhardt (12022-07-23): >> >> This is a follow-up to a topic that was already raised earlier, >> http://ffmpeg.org/pipermail/ffmpeg-devel/2020-July/265694.html >> >> The same has now happened to 5.0->5.1. > >I do not see an issue. What

Re: [FFmpeg-devel] [PATCH 5/5] avcodec/vp8, vp9: Avoid using VP56mv and VP56Frame in VP8/9

Hi, On Sat, Jul 23, 2022 at 1:16 PM Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: > Instead replace VP56mv by new and identical structures VP8mv and VP9mv. > Also replace VP56Frame by VP8FrameType in vp8.h and use that > in VP8 code. Also remove VP56_FRAME_GOLDEN2, as this has only

Re: [FFmpeg-devel] ABI break in 5.1

Jan Engelhardt (12022-07-23): > > This is a follow-up to a topic that was already raised earlier, > http://ffmpeg.org/pipermail/ffmpeg-devel/2020-July/265694.html > > The same has now happened to 5.0->5.1. I do not see an issue. What issue do you see? Regards, -- Nicolas George signature

[FFmpeg-devel] ABI break in 5.1

This is a follow-up to a topic that was already raised earlier, http://ffmpeg.org/pipermail/ffmpeg-devel/2020-July/265694.html The same has now happened to 5.0->5.1. == abidiff /usr/lib64/libavcodec.so.59.18.100 b/usr/lib64/libavcodec.so.59.37.100 Functi

Re: [FFmpeg-devel] [PATCH v3 0/6] ICC profile support in avcodec

On Tue, 19 Jul 2022 14:26:02 +0200 Niklas Haas wrote: > Changes in v3: > - switch from `int icc_profiles` to a new AV_CODEC_FLAG2 to avoid ABI > break > - rebased onto master and fixed merge conflicts > > Changes in v2: > - remove unnecessary import > - fixed assignment-instead-of-equality > -