Re: [FFmpeg-devel] [PATCH v5 0/6] Implement SEI parsing for QSV decoders

2022-07-18 Thread Xiang, Haihao
On Fri, 2022-07-01 at 20:48 +, ffmpegagent wrote: > Missing SEI information has always been a major drawback when using the QSV > decoders. I used to think that there's no chance to get at the data without > explicit implementation from the MSDK side (or doing something weird like > parsing in

Re: [FFmpeg-devel] [PATCH v2] libavcodec/qsvenc: Use parameter from AVCodecContext to reset qsv codec

2022-07-18 Thread Xiang, Haihao
On Thu, 2022-07-14 at 16:43 +0800, Wenbin Chen wrote: > Using parameter from AVCodecContext to reset qsv codec is more suitable > for MFXVideoENCODE_Reset()'s usage. Per-frame metadata is more suitable > for the usage of mfxEncodeCtrl being passed to > MFXVideoENCODE_EncodeFrameAsync(). Now change

Re: [FFmpeg-devel] [PATCH] libavcodec/qsvenc: Change the parameter log to be thread safe

2022-07-18 Thread Xiang, Haihao
On Fri, 2022-07-08 at 15:14 +0800, Wenbin Chen wrote: > Dividing one line log into several av_log() call is not thread safe. Now > merge these strings into one av_log() call. > > Signed-off-by: Wenbin Chen > --- > libavcodec/qsvenc.c | 87 ++--- > 1 file c

Re: [FFmpeg-devel] [PATCH v2] libavfilter/vf_overlay_qsv: Use format of first input to set output format for overlay_qsv

2022-07-18 Thread Xiang, Haihao
On Thu, 2022-07-07 at 11:12 +0800, Wenbin Chen wrote: > overlay_qsv hard coded to use nv12 as output format. Now use the format > of the first input to set output format. > > For detailed information of supported format on different platform, > please see the "composition" rows in "Video Processin

Re: [FFmpeg-devel] [PATCH] lavc: add API for exporting reconstructed frames from encoders

2022-07-18 Thread James Almer
On 7/18/2022 3:05 PM, Anton Khirnov wrote: --- doc/APIchanges | 5 + libavcodec/avcodec.c | 12 libavcodec/avcodec.h | 20 libavcodec/codec.h | 8 libavcodec/decode.c| 4 +--- libavcodec/decode.h

[FFmpeg-devel] Patch: fftools/ffprobe.c: avoid overriding error code.

2022-07-18 Thread Yubo Xie
fftools/ffprobe.c: avoid overriding error code. 0001-fftools-ffprobe.c-avoid-overriding-error-code.patch Description: 0001-fftools-ffprobe.c-avoid-overriding-error-code.patch ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailma

Re: [FFmpeg-devel] Make disposition forced work with mov_text subtitles.

2022-07-18 Thread facefunk
I see what I did wrong. -v or --reroll-count are arguments to git format-patch so obviously aren't applied by git send-email when providing a preformatted patch, which I did. My mistake. On Mon, 18 Jul 2022 at 18:48, Leo Izen wrote: > On 7/18/22 12:08, facefunk wrote: > > We are not currently ab

[FFmpeg-devel] [PATCH v3] libavcodec: Make disposition forced work with mov_text subtitles.

2022-07-18 Thread facefunk
We are not currently able to force mov_text subtitles by setting -disposition:s:0 +forced or equivalent. By setting the forced flags in movtextenc as specifid in https://developer.apple.com/library/archive/documentation/QuickTime/QTFF/QTFFChap3/qtff3.html subtitles can be forced as expected in

[FFmpeg-devel] Make disposition forced work with mov_text subtitles.

2022-07-18 Thread facefunk
Okay, great! Thanks for reviewing. I've addressed your points as well as a few tweaks in the spirit of preserving the abstraction boundary. Would the attached patch revision be acceptable? ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://

Re: [FFmpeg-devel] [PATCH] avcodec/pthread_frame: update the main avctx from the current, ThreadContext

2022-07-18 Thread Michael Niedermayer
On Sat, Jul 09, 2022 at 08:45:31AM +0200, Steve Lhomme wrote: > Patch attached in the email. > > In some cases, the submit packet can result in configurations changes of the > hardware decoders. The previous HW context is then freed and a new one > created. That context is supposed to move up to t

Re: [FFmpeg-devel] [PATCH 1/3] avformat/mxfdec: SMPTE RDD 48:2018 support

2022-07-18 Thread Tomas Härdin
mån 2022-07-11 klockan 23:44 +0200 skrev Michael Niedermayer: > Signed-off-by: Michael Niedermayer > --- >  libavformat/mxf.c    |  3 +++ >  libavformat/mxf.h    |  1 + >  libavformat/mxfdec.c | 48 > >  3 files changed, 52 insertions(+) > > diff --git

Re: [FFmpeg-devel] [PATCH] lavc/libx264: support AV_CODEC_CAP_ENCODER_RECON_FRAME

2022-07-18 Thread Anton Khirnov
Quoting James Almer (2022-07-18 20:18:16) > > > On 7/18/2022 3:15 PM, Anton Khirnov wrote: > > Quoting James Almer (2022-07-18 14:23:58) > >> On 7/18/2022 4:12 AM, Anton Khirnov wrote: > >>> --- > >>>libavcodec/libx264.c | 52 +++- > >>>1 file change

Re: [FFmpeg-devel] [PATCH] lavc/libx264: support AV_CODEC_CAP_ENCODER_RECON_FRAME

2022-07-18 Thread James Almer
On 7/18/2022 3:15 PM, Anton Khirnov wrote: Quoting James Almer (2022-07-18 14:23:58) On 7/18/2022 4:12 AM, Anton Khirnov wrote: --- libavcodec/libx264.c | 52 +++- 1 file changed, 51 insertions(+), 1 deletion(-) diff --git a/libavcodec/libx264.c

Re: [FFmpeg-devel] [PATCH] lavc/libx264: support AV_CODEC_CAP_ENCODER_RECON_FRAME

2022-07-18 Thread Anton Khirnov
Quoting James Almer (2022-07-18 14:23:58) > On 7/18/2022 4:12 AM, Anton Khirnov wrote: > > --- > > libavcodec/libx264.c | 52 +++- > > 1 file changed, 51 insertions(+), 1 deletion(-) > > > > diff --git a/libavcodec/libx264.c b/libavcodec/libx264.c > > ind

Re: [FFmpeg-devel] [PATCH] lavc/libx264: support AV_CODEC_CAP_ENCODER_RECON_FRAME

2022-07-18 Thread Anton Khirnov
Quoting James Almer (2022-07-18 19:41:27) > Why not ff_encode_alloc_frame() for this? Can > csp_to_pixfmt(pic_out.img.i_csp) be different than ctx->pix_fmt? Yes, the reconstructed frame is in x264's internal format, which will typically be some flavor of nv12, even if the input format is fully pl

[FFmpeg-devel] [PATCH] lavc: add API for exporting reconstructed frames from encoders

2022-07-18 Thread Anton Khirnov
--- doc/APIchanges | 5 + libavcodec/avcodec.c | 12 libavcodec/avcodec.h | 20 libavcodec/codec.h | 8 libavcodec/decode.c| 4 +--- libavcodec/decode.h| 5 + libavcodec/encode.c| 25

Re: [FFmpeg-devel] Make disposition forced work with mov_text subtitles.

2022-07-18 Thread facefunk
Thanks for the advice. I did --reroll-count=2 but it doesn't seem to have worked. On Mon, 18 Jul 2022 at 18:48, Leo Izen wrote: > On 7/18/22 12:08, facefunk wrote: > > We are not currently able to force mov_text subtitles by setting > -disposition:s:0 +forced or equivalent. By setting the forced

Re: [FFmpeg-devel] Make disposition forced work with mov_text subtitles.

2022-07-18 Thread Leo Izen
On 7/18/22 12:08, facefunk wrote: We are not currently able to force mov_text subtitles by setting -disposition:s:0 +forced or equivalent. By setting the forced flags in movtextenc as specifid in https://developer.apple.com/library/archive/documentation/QuickTime/QTFF/QTFFChap3/qtff3.html sub

Re: [FFmpeg-devel] [PATCH] lavc/libx264: support AV_CODEC_CAP_ENCODER_RECON_FRAME

2022-07-18 Thread James Almer
On 7/18/2022 4:12 AM, Anton Khirnov wrote: --- libavcodec/libx264.c | 52 +++- 1 file changed, 51 insertions(+), 1 deletion(-) diff --git a/libavcodec/libx264.c b/libavcodec/libx264.c index 98ec030865..5e360682e6 100644 --- a/libavcodec/libx264.c +++ b/

[FFmpeg-devel] [PATCH 2/2] avcodec/wrapped_avframe: Don't presume AVPacket to be writable

2022-07-18 Thread Andreas Rheinhardt
It need not be writable; in fact, it is often not writable even if the packet sent to the decoder was writable, because the generic code calls av_packet_ref() on it. It is never writable if a user drains the decoder after every packet, because in this case the decode callback is called from avcodec

Re: [FFmpeg-devel] Development opportunity: LTC noise on files created from videotape source: filter idea

2022-07-18 Thread Paul B Mahol
On Mon, Jul 18, 2022 at 7:14 PM Michael Niedermayer wrote: > On Mon, Jul 18, 2022 at 09:53:14AM +, Stephen McConnachie wrote: > > Hi FFMPEG developers, > > > > I have a proposal for a paid development opportunity to add a filter to > FFMPEG. > > > > I followed the advice on the FFMPEG Consult

[FFmpeg-devel] [PATCH 1/2] avcodec/wrapped_avframe: Don't leak frame metadata, side-data

2022-07-18 Thread Andreas Rheinhardt
wrapped_avframe_decode() uses an AVFrame as dst in av_frame_move_ref() after having called ff_decode_frame_props() to attach side-date to this very frame. This leaks all the side-data and metadata that ff_decode_frame_props() has attached. This happens in various fate-filter-metadata tests since 6

Re: [FFmpeg-devel] Development opportunity: LTC noise on files created from videotape source: filter idea

2022-07-18 Thread Michael Niedermayer
On Mon, Jul 18, 2022 at 09:53:14AM +, Stephen McConnachie wrote: > Hi FFMPEG developers, > > I have a proposal for a paid development opportunity to add a filter to > FFMPEG. > > I followed the advice on the FFMPEG Consulting page at > https://ffmpeg.org/consulting.html and am emailing this

Re: [FFmpeg-devel] [PATCH 1/3] libavcodec: Make disposition forced work with mov_text subtitles.

2022-07-18 Thread Michael Niedermayer
On Mon, Jul 18, 2022 at 05:08:31PM +0100, facefunk wrote: > We are not currently able to force mov_text subtitles by setting > -disposition:s:0 +forced or equivalent. By setting the forced flags in > movtextenc as specifid in > https://developer.apple.com/library/archive/documentation/QuickTime/

Re: [FFmpeg-devel] [PATCH v2 4/5] libswscale: Enable hscale_avx2 for all input sizes.

2022-07-18 Thread Michael Niedermayer
On Mon, Jul 18, 2022 at 09:54:39AM +0200, Alan Kelly wrote: > Hi Michael, > > I have tried to recreate this locally in a clean client applying the > patches as sent in the email thread. I have tried gcc and mingw and this > passes for me. Are you sure you applied both patches 3 & 4? If only patch

Re: [FFmpeg-devel] [PATCH] RELEASE_NOTES: Based on the version from 5.0

2022-07-18 Thread Michael Niedermayer
On Mon, Jul 18, 2022 at 01:39:47PM +0200, Anton Khirnov wrote: > Quoting Michael Niedermayer (2022-07-17 16:23:40) > > On Sun, Jul 17, 2022 at 10:43:02AM +0200, Jean-Baptiste Kempf wrote: > > > Maybe some highlights of this release? Like the biggest changes and > > > improvements? > > > > Isnt th

[FFmpeg-devel] [PATCH 3/3] libavutil: Correct number of parameters in flag type options documentation.

2022-07-18 Thread facefunk
Signed-off-by: facefunk --- libavutil/opt.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavutil/opt.h b/libavutil/opt.h index 461b5d3b6b..f250579b29 100644 --- a/libavutil/opt.h +++ b/libavutil/opt.h @@ -175,8 +175,8 @@ * above, put the following into the chil

[FFmpeg-devel] [PATCH 2/3] libavcodec: Correct typo in mov_text encoder class name.

2022-07-18 Thread facefunk
Signed-off-by: facefunk --- libavcodec/movtextenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/movtextenc.c b/libavcodec/movtextenc.c index d2550585e8..6f54e2a64c 100644 --- a/libavcodec/movtextenc.c +++ b/libavcodec/movtextenc.c @@ -732,7 +732,7 @@ static cons

[FFmpeg-devel] [PATCH 1/3] libavcodec: Make disposition forced work with mov_text subtitles.

2022-07-18 Thread facefunk
We are not currently able to force mov_text subtitles by setting -disposition:s:0 +forced or equivalent. By setting the forced flags in movtextenc as specifid in https://developer.apple.com/library/archive/documentation/QuickTime/QTFF/QTFFChap3/qtff3.html subtitles can be forced as expected in

[FFmpeg-devel] Make disposition forced work with mov_text subtitles.

2022-07-18 Thread facefunk
We are not currently able to force mov_text subtitles by setting -disposition:s:0 +forced or equivalent. By setting the forced flags in movtextenc as specifid in https://developer.apple.com/library/archive/documentation/QuickTime/QTFF/QTFFChap3/qtff3.html subtitles can be forced as expected in

Re: [FFmpeg-devel] [PATCH] avcodec/pnmdec: Mark PHM decoder as init-threadsafe

2022-07-18 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/pnmdec.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavcodec/pnmdec.c b/libavcodec/pnmdec.c > index bb2ce53496..f012ed288b 100644 > --- a/libavcodec/pnmdec.c > +++ b/libavcodec/pnmdec.c > @@ -513,5 +513,6

Re: [FFmpeg-devel] [PATCH v2 2/2] lavfi/cropdetect: Add new mode to detect crop-area based on motion vectors and edges

2022-07-18 Thread Thilo Borgmann
Am 17.07.22 um 09:54 schrieb Thilo Borgmann: Am 16.07.22 um 23:09 schrieb Thilo Borgmann: Am 11.07.22 um 10:54 schrieb Thilo Borgmann: $subject v3. v4. v5 now with fixed docs. -ThiloFrom c5962d580dd103d0b9cc08724a6863e62383da7b Mon Sep 17 00:00:00 2001 From: Thilo Borgmann Date: Mon, 18

Re: [FFmpeg-devel] [PATCH v2 1/2] lavfi/edge_common: Add 16bit versions of gaussian_blur and sobel

2022-07-18 Thread Thilo Borgmann
Am 17.07.22 um 09:54 schrieb Thilo Borgmann: Am 16.07.22 um 23:07 schrieb Thilo Borgmann: Hi, 1/2 adds 16 bit versions of ff_gaussian_blur and ff_sobel. 2/2 adds new mode to cropdetect. v3 does it the template way for 1/2 as requested on IRC. v4 fixed bug in gaussian_blur. Otherwise identi

Re: [FFmpeg-devel] [PATCH] avcodec/aacdec: don't force HE-AACv2 profile if no PS info is present

2022-07-18 Thread Andreas Rheinhardt
James Almer: > On 7/14/2022 9:10 AM, Andreas Rheinhardt wrote: >> James Almer: >>> Should fix ticket #3361 >>> >>> Signed-off-by: James Almer >>> --- >>> This also needs an update to some fate ref samples i'll upload before >>> pushing >>> (fate-aac-al_sbr_ps_04_ur and fate-aac-al_sbr_ps_06_ur whi

Re: [FFmpeg-devel] [PATCH 1/2] avformat/argo_cvg: name unk{1, 2} fields correctly

2022-07-18 Thread Andreas Rheinhardt
Zane van Iperen: > Signed-off-by: Zane van Iperen > --- > libavformat/argo_cvg.c | 33 + > 1 file changed, 17 insertions(+), 16 deletions(-) > > diff --git a/libavformat/argo_cvg.c b/libavformat/argo_cvg.c > index f32487023a..2ee4a64449 100644 > --- a/libavformat/

Re: [FFmpeg-devel] [PATCH v10 10/13] lavu/hwcontext_qsv: make qsv hwdevice works with oneVPL

2022-07-18 Thread Anton Khirnov
Quoting Xiang, Haihao (2022-07-12 08:27:32) > +static int qsv_va_update_config(void *ctx, mfxHDL handle, mfxConfig cfg) > +{ > +#if CONFIG_VAAPI > +#if VA_CHECK_VERSION(1, 5, 0) > +#define LOCAL_VADISPLAYPCIID VADisplayPCIID > +#else > +#define LOCAL_VADISPLAYPCIID 21 > +#endif > +mfxStatus sts

Re: [FFmpeg-devel] [PATCH 2/4] lavc: add API for exporting reconstructed frames from encoders

2022-07-18 Thread James Almer
On 7/17/2022 4:26 PM, Anton Khirnov wrote: diff --git a/libavcodec/encode.c b/libavcodec/encode.c index 1f39ab1a2f..f15309ce09 100644 --- a/libavcodec/encode.c +++ b/libavcodec/encode.c @@ -594,6 +594,18 @@ int ff_encode_preinit(AVCodecContext *avctx) return AVERROR(ENOMEM); }

Re: [FFmpeg-devel] [PATCH 1/4] lavu/frame: allow calling av_frame_make_writable() on non-refcounted frames

2022-07-18 Thread James Almer
On 7/17/2022 4:26 PM, Anton Khirnov wrote: This is an easy way to make a refcounted frame from a non-refcounted one. --- doc/APIchanges | 5 + libavutil/frame.c | 3 --- libavutil/frame.h | 3 ++- libavutil/version.h | 2 +- 4 files changed, 8 insertions(+), 5 deletions(-) dif

Re: [FFmpeg-devel] [PATCH] lavc/libx264: support AV_CODEC_CAP_ENCODER_RECON_FRAME

2022-07-18 Thread James Almer
On 7/18/2022 4:12 AM, Anton Khirnov wrote: --- libavcodec/libx264.c | 52 +++- 1 file changed, 51 insertions(+), 1 deletion(-) diff --git a/libavcodec/libx264.c b/libavcodec/libx264.c index 98ec030865..5e360682e6 100644 --- a/libavcodec/libx264.c +++ b/

Re: [FFmpeg-devel] [PATCH] ffprobe: use AVFrame.duration instead of AVFrame.pkt_duration

2022-07-18 Thread Anton Khirnov
Quoting James Almer (2022-07-18 13:49:18) > On 7/18/2022 4:34 AM, Anton Khirnov wrote: > > diff --git a/tests/ref/fate/exif-image-jpg b/tests/ref/fate/exif-image-jpg > > index b942fc5a7b..2d5fe18d61 100644 > > --- a/tests/ref/fate/exif-image-jpg > > +++ b/tests/ref/fate/exif-image-jpg > > @@ -10,6

Re: [FFmpeg-devel] [PATCH] ffprobe: use AVFrame.duration instead of AVFrame.pkt_duration

2022-07-18 Thread James Almer
On 7/18/2022 4:34 AM, Anton Khirnov wrote: diff --git a/tests/ref/fate/exif-image-jpg b/tests/ref/fate/exif-image-jpg index b942fc5a7b..2d5fe18d61 100644 --- a/tests/ref/fate/exif-image-jpg +++ b/tests/ref/fate/exif-image-jpg @@ -10,6 +10,8 @@ best_effort_timestamp=0 best_effort_timestamp_time=

Re: [FFmpeg-devel] [PATCH] add HDR image format test coverage

2022-07-18 Thread Paul B Mahol
On Mon, Jul 18, 2022 at 1:16 PM Anton Khirnov wrote: > Quoting Paul B Mahol (2022-07-17 16:51:20) > > Patch attached. > > > > From 7080795a572f8f741d4a00b2db02c8e00ce6aaf2 Mon Sep 17 00:00:00 2001 > > From: Paul B Mahol > > Date: Sun, 17 Jul 2022 15:12:12 +0200 > > Subject: [PATCH] fate: add Rad

Re: [FFmpeg-devel] [PATCH] RELEASE_NOTES: Based on the version from 5.0

2022-07-18 Thread Anton Khirnov
Quoting Michael Niedermayer (2022-07-17 16:23:40) > On Sun, Jul 17, 2022 at 10:43:02AM +0200, Jean-Baptiste Kempf wrote: > > Maybe some highlights of this release? Like the biggest changes and > > improvements? > > Isnt that what Changelog is already doing ? By tradition, only certain things get

Re: [FFmpeg-devel] [PATCH] swscale: add NV16 input/output

2022-07-18 Thread Anton Khirnov
Quoting Michael Niedermayer (2022-07-14 20:09:54) > On Fri, Jul 01, 2022 at 10:08:14AM +0200, Matthieu Bouron wrote: > > On Sat, Jun 11, 2022 at 5:35 PM Michael Niedermayer > > wrote: > > > > > On Fri, Jun 10, 2022 at 04:11:10PM +0200, Matthieu Bouron wrote: > > > > On Thu, Jun 2, 2022 at 9:13 PM

Re: [FFmpeg-devel] [PATCH] add HDR image format test coverage

2022-07-18 Thread Anton Khirnov
Quoting Paul B Mahol (2022-07-17 16:51:20) > Patch attached. > > From 7080795a572f8f741d4a00b2db02c8e00ce6aaf2 Mon Sep 17 00:00:00 2001 > From: Paul B Mahol > Date: Sun, 17 Jul 2022 15:12:12 +0200 > Subject: [PATCH] fate: add Radiance HDR image test > > Signed-off-by: Paul B Mahol > --- > test

Re: [FFmpeg-devel] [PATCH v2 1/2] avformat: refactor ff_stream_encode_params_copy() to ff_stream_params_copy()

2022-07-18 Thread Anton Khirnov
Quoting p...@sandflow.com (2022-07-13 00:34:12) > +dst->index = src->index; This should probably not be copied. -- Anton Khirnov ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel T

[FFmpeg-devel] Development opportunity: LTC noise on files created from videotape source: filter idea

2022-07-18 Thread Stephen McConnachie
Hi FFMPEG developers, I have a proposal for a paid development opportunity to add a filter to FFMPEG. I followed the advice on the FFMPEG Consulting page at https://ffmpeg.org/consulting.html and am emailing this list to try to identify if any of the FFMPEG developers may be able to take on a d

Re: [FFmpeg-devel] [PATCH v3 1/4] lavc/hevc_refs: fix dpb logical for IRAP

2022-07-18 Thread Xiang, Haihao
On Fri, 2022-07-15 at 13:06 +0800, Fei Wang wrote: > From: Xu Guangxin > > According to C.5.2.2, item 2. When we got an IRAP, and the > NoOutputOfPriorPicsFlag = 0, we need bump all outputable frames. > > Tested-by: Fei Wang > Signed-off-by: Xu Guangxin > --- > update: > 1. clean and replace 0

Re: [FFmpeg-devel] [PATCH] ffprobe: use AVFrame.duration instead of AVFrame.pkt_duration

2022-07-18 Thread Anton Khirnov
Quoting Nicolas George (2022-07-18 10:23:40) > Anton Khirnov (12022-07-18): > > Subject: Re: [FFmpeg-devel] [PATCH] ffprobe: use AVFrame.duration instead of > > AVFrame.pkt_duration > > You may want to update this: it is no longer "instead". Right, changed locally. -- Anton Khirnov ___

Re: [FFmpeg-devel] [PATCH] ffprobe: use AVFrame.duration instead of AVFrame.pkt_duration

2022-07-18 Thread Nicolas George
Anton Khirnov (12022-07-18): > Subject: Re: [FFmpeg-devel] [PATCH] ffprobe: use AVFrame.duration instead of > AVFrame.pkt_duration You may want to update this: it is no longer "instead". Regards, -- Nicolas George signature.asc Description: PGP signature ___

Re: [FFmpeg-devel] [PATCH v2 4/5] libswscale: Enable hscale_avx2 for all input sizes.

2022-07-18 Thread Alan Kelly
Hi Michael, I have tried to recreate this locally in a clean client applying the patches as sent in the email thread. I have tried gcc and mingw and this passes for me. Are you sure you applied both patches 3 & 4? If only patch 4 is applied, then I get the error you have. Thanks, Alan On Sat,

[FFmpeg-devel] [PATCH] lavc/libx264: support AV_CODEC_CAP_ENCODER_RECON_FRAME

2022-07-18 Thread Anton Khirnov
--- libavcodec/libx264.c | 52 +++- 1 file changed, 51 insertions(+), 1 deletion(-) diff --git a/libavcodec/libx264.c b/libavcodec/libx264.c index 98ec030865..5e360682e6 100644 --- a/libavcodec/libx264.c +++ b/libavcodec/libx264.c @@ -311,6 +311,25 @@ stati