Re: [FFmpeg-devel] [PATCH 2/2] avformat/movenc: enable btrt for mov mode

2022-06-12 Thread zhilizhao(赵志立)
Please ignore patch 2/2. Too much false positive fate failure. Ping for v2 1/2 'avformat/movenc: enable compressorname for mp4 mode' https://patchwork.ffmpeg.org/project/ffmpeg/patch/tencent_c970c82d419aac406b9a419f4dab094ef...@qq.com/ > On May 30, 2022, at 3:49 PM, Zhao Zhili wrote: > > Signe

Re: [FFmpeg-devel] [PATCH v2 3/3] avcodec/avs2_parser: parse more info

2022-06-12 Thread zhilizhao(赵志立)
> On Jun 13, 2022, at 1:07 AM, Andreas Rheinhardt > wrote: > > Zhao Zhili: >> Including video resolution, framerate and picture type, etc. >> >> Signed-off-by: Zhao Zhili >> --- >> v2: fix unused variable warning >> >> libavcodec/avs2.h| 27 ++ >> libavcodec/avs2_parser.c |

[FFmpeg-devel] [PATCH v3 0/5] Refactor avs2_parser

2022-06-12 Thread Zhao Zhili
v3: 1. Move ff_avs2_frame_rate_tab from avs2.h to avs2.c 2. Consitify `precision` in patch 3/5 3. init_get_bits8() with size limites to buf_size_min 4. Select avs2_parser for libdavs2 5. Use ff_avs2_frame_rate_tab in libdavs2 v2: Fix warning of unused variable. Zhao Zhili (5): avcodec/avs2: add

[FFmpeg-devel] [PATCH v3 5/5] avcodec/libdavs2: use frame rate code table

2022-06-12 Thread Zhao Zhili
It's more natural than the floating to fraction conversion. Signed-off-by: Zhao Zhili --- libavcodec/libdavs2.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavcodec/libdavs2.c b/libavcodec/libdavs2.c index bc31745a4f..d7625718a2 100644 --- a/libavcodec/libdavs2.c +++

[FFmpeg-devel] [PATCH v3 3/5] avcodec/avs2_parser: parse more info

2022-06-12 Thread Zhao Zhili
Including video resolution, framerate and picture type, etc. Signed-off-by: Zhao Zhili --- libavcodec/Makefile | 2 +- libavcodec/avs2.c| 42 libavcodec/avs2.h| 10 libavcodec/avs2_parser.c | 105 +++ 4 files chan

[FFmpeg-devel] [PATCH v3 4/5] configure: select avs2 parser for libdavs2 decoder

2022-06-12 Thread Zhao Zhili
Signed-off-by: Zhao Zhili --- configure | 1 + 1 file changed, 1 insertion(+) diff --git a/configure b/configure index 3dca1c4bd3..3b60fde733 100755 --- a/configure +++ b/configure @@ -3324,6 +3324,7 @@ libcodec2_encoder_deps="libcodec2" libdav1d_decoder_deps="libdav1d" libdav1d_decoder_select

[FFmpeg-devel] [PATCH v3 2/5] avcodec/avs2_parser: split data into frames

2022-06-12 Thread Zhao Zhili
Before the patch, the parser split data into units, not frames. Signed-off-by: Zhao Zhili --- libavcodec/avs2.h| 2 +- libavcodec/avs2_parser.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/libavcodec/avs2.h b/libavcodec/avs2.h index 7b66f51998..f342ba52a0 1006

[FFmpeg-devel] [PATCH v3 1/5] avcodec/avs2: add AVS2 related definitions

2022-06-12 Thread Zhao Zhili
Replace magic numbers by enum values. Signed-off-by: Zhao Zhili --- libavcodec/avs2.h| 41 libavcodec/avs2_parser.c | 6 +- 2 files changed, 42 insertions(+), 5 deletions(-) create mode 100644 libavcodec/avs2.h diff --git a/libavcodec/avs2.

[FFmpeg-devel] [PATCH 2/3] avformat/mov: Check the item count in iloc better

2022-06-12 Thread Michael Niedermayer
Fixes: out of array access Fixes: 47899/clusterfuzz-testcase-minimized-ffmpeg_IO_DEMUXER_fuzzer-5706852010164224 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavformat/mov.c | 6 +++--- 1 file chang

[FFmpeg-devel] [PATCH 3/3] avcodec/bink: disallow odd positioned scaled blocks

2022-06-12 Thread Michael Niedermayer
Fixes: out of array access Fixes: 47911/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_BINK_fuzzer-6194020855971840 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/bink.c | 2 +- 1 file cha

[FFmpeg-devel] [PATCH 1/3] tools/target_dec_fuzzer: Adjust threshold for SIMBIOSIS_IMX

2022-06-12 Thread Michael Niedermayer
Fixes: Timeout Fixes: 47892/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_SIMBIOSIS_IMX_fuzzer-5160609278197760 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- tools/target_dec_fuzzer.c | 1 + 1 file

[FFmpeg-devel] [PATCH 1/2] avformat/img2enc: fix first image check

2022-06-12 Thread Marton Balint
Start image number was hardcoded to 1 for the first image check. Signed-off-by: Marton Balint --- libavformat/img2enc.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/libavformat/img2enc.c b/libavformat/img2enc.c index b3a0801ec9..82a04e639b 100644 --- a/libavformat/im

[FFmpeg-devel] [PATCH 2/2] avformat/img2enc: use unmatched filename for an invalid or missing sequence pattern

2022-06-12 Thread Marton Balint
Also warn the user that for single images -update should be used, for sequences a proper pattern should be specified. Fixes ticket #9748. Signed-off-by: Marton Balint --- libavformat/img2enc.c | 18 +++--- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/libavformat/im

Re: [FFmpeg-devel] [PATCH] swresample/resample: Properly empty MMX state

2022-06-12 Thread Andreas Rheinhardt
Andreas Rheinhardt: > There is a x86-32 MMXEXT implementation for resampling > planar 16bit data. multiple_resample() therefore calls > emms_c() if it thinks that this needed. And this is bad: > > 1. It is a maintenance nightmare because changes to the > x86 resample DSP code would necessitate cha

Re: [FFmpeg-devel] [PATCH] avcodec/get_bits: declare VLC table args as const

2022-06-12 Thread Andreas Rheinhardt
Leo Izen: > Declaring the VLC table as const allows a caller to call get_vlc2() > with a pre-generated static const table without generating warnings > for -Wdiscarded-qualifiers. > --- > libavcodec/get_bits.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavcodec

[FFmpeg-devel] [PATCH] avformat/concat: fix missing metadata

2022-06-12 Thread Steven Hartland
Remove return after copying extradata as this prevents metadata being duplicated correctly. Signed-off-by: Steven Hartland --- libavformat/concatdec.c | 1 - tests/ref/fate/concat-demuxer-simple2-lavf-ts | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/

[FFmpeg-devel] [PATCH] avcodec/exif: Move tag_list out of header

2022-06-12 Thread Andreas Rheinhardt
It is only used by exif.c (and e.g. EXIF_TAG_NAME_LENGTH is an implementation detail anyway). Also remove the sentinel, as it is used in conjunction with FF_ARRAY_ELEMS. Signed-off-by: Andreas Rheinhardt --- libavcodec/exif.c | 127 libavcodec/exif.h

[FFmpeg-devel] [PATCH] swresample/noise_shaping_data: Remove unused tables

2022-06-12 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libswresample/noise_shaping_data.c | 4 1 file changed, 4 deletions(-) diff --git a/libswresample/noise_shaping_data.c b/libswresample/noise_shaping_data.c index 77e0f2eafc..5fd2136986 100644 --- a/libswresample/noise_shaping_data.c +++ b/libswresample

[FFmpeg-devel] [PATCH 6/7] avcodec/v210dec: add support for strideless v210 as in BOXX files

2022-06-12 Thread Marton Balint
Fixes ticket #1838. Signed-off-by: Marton Balint --- libavcodec/v210dec.c | 34 +++--- 1 file changed, 27 insertions(+), 7 deletions(-) diff --git a/libavcodec/v210dec.c b/libavcodec/v210dec.c index ba48bb6fe4..bf84cd4428 100644 --- a/libavcodec/v210dec.c +++ b/libav

[FFmpeg-devel] [PATCH 7/7] doc/decoders: add docs for v210 decoder

2022-06-12 Thread Marton Balint
Signed-off-by: Marton Balint --- doc/decoders.texi | 15 +++ 1 file changed, 15 insertions(+) diff --git a/doc/decoders.texi b/doc/decoders.texi index de2429abba..e2fcbf5dc9 100644 --- a/doc/decoders.texi +++ b/doc/decoders.texi @@ -168,6 +168,21 @@ A :-separate list of hexadecimal p

[FFmpeg-devel] [PATCH 5/7] avcodec/v210dec: add support for invalid paddings up to 16 bytes

2022-06-12 Thread Marton Balint
Fixes ticket #1528. Signed-off-by: Marton Balint --- libavcodec/v210dec.c | 32 +--- 1 file changed, 21 insertions(+), 11 deletions(-) diff --git a/libavcodec/v210dec.c b/libavcodec/v210dec.c index 4268b5b748..ba48bb6fe4 100644 --- a/libavcodec/v210dec.c +++ b/libavc

[FFmpeg-devel] [PATCH 4/7] avcodec/v210dec: do not use accelerated code for the last pixels of a row

2022-06-12 Thread Marton Balint
ASM code tends to overwrite the buffers by 2-4 bytes and it can cause issues with slice threads. Signed-off-by: Marton Balint --- libavcodec/v210dec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/v210dec.c b/libavcodec/v210dec.c index e97f43a8e6..4268b5b748

[FFmpeg-devel] [PATCH 2/7] avcodec/v210dec: factorize row decoding

2022-06-12 Thread Marton Balint
Signed-off-by: Marton Balint --- libavcodec/v210dec.c | 108 +-- 1 file changed, 54 insertions(+), 54 deletions(-) diff --git a/libavcodec/v210dec.c b/libavcodec/v210dec.c index 48ebe57100..c89440658f 100644 --- a/libavcodec/v210dec.c +++ b/libavcodec/v210

[FFmpeg-devel] [PATCH 3/7] avcodec/v210dec: disallow negative custom stride

2022-06-12 Thread Marton Balint
Also make sure a big custom stride does not overflow size check. Avoids segfaults. Signed-off-by: Marton Balint --- libavcodec/v210dec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/v210dec.c b/libavcodec/v210dec.c index c89440658f..e97f43a8e6 100644 --- a/

[FFmpeg-devel] [PATCH 1/7] avcodec/v210dec: properly support odd widths

2022-06-12 Thread Marton Balint
Fixes ticket #5195. Signed-off-by: Marton Balint --- libavcodec/v210dec.c | 49 +--- 1 file changed, 33 insertions(+), 16 deletions(-) diff --git a/libavcodec/v210dec.c b/libavcodec/v210dec.c index 6c10ef6a7c..48ebe57100 100644 --- a/libavcodec/v210dec.c

Re: [FFmpeg-devel] [PATCH v2 3/3] avcodec/avs2_parser: parse more info

2022-06-12 Thread Andreas Rheinhardt
Zhao Zhili: > Including video resolution, framerate and picture type, etc. > > Signed-off-by: Zhao Zhili > --- > v2: fix unused variable warning > > libavcodec/avs2.h| 27 ++ > libavcodec/avs2_parser.c | 103 +++ > 2 files changed, 130 insert

Re: [FFmpeg-devel] [PATCH 1/2] lavf/avio: add avio_vprintf()

2022-06-12 Thread Nicolas George
Stefano Sabatini (12022-06-12): > Updated. Hi. Since it is somewhat related, I would appreciate if you gave your opinion on the option of having a good string API in FFmpeg: https://ffmpeg.org/pipermail/ffmpeg-devel/2021-December/290226.html Eventually, I would like to have the more generic writ

[FFmpeg-devel] [PATCH v2 3/3] avcodec/avs2_parser: parse more info

2022-06-12 Thread Zhao Zhili
Including video resolution, framerate and picture type, etc. Signed-off-by: Zhao Zhili --- v2: fix unused variable warning libavcodec/avs2.h| 27 ++ libavcodec/avs2_parser.c | 103 +++ 2 files changed, 130 insertions(+) diff --git a/libavcod

[FFmpeg-devel] [PATCH] lavf/avformat.h: document av_guess_codec() parameters

2022-06-12 Thread Stefano Sabatini
Also annotate that some of the parameters were never used. Fix trac issue: http://trac.ffmpeg.org/ticket/4706 --- libavformat/avformat.h | 9 + 1 file changed, 9 insertions(+) diff --git a/libavformat/avformat.h b/libavformat/avformat.h index f12fa7d904..58030f1814 100644 --- a/libavform

[FFmpeg-devel] [PATCH v2] avformat/movenc: enable compressorname for mp4 mode

2022-06-12 Thread Zhao Zhili
Signed-off-by: Zhao Zhili --- v2: update fate test libavformat/movenc.c | 5 +++-- tests/ref/lavf/mp4 | 6 +++--- tests/ref/vsynth/vsynth1-mpeg4 | 2 +- tests/ref/vsynth/vsynth2-mpeg4 | 2 +- tests/ref/vsynth/vsynth3-mpeg4 | 2 +- tests/ref/vsynth/vsynth

Re: [FFmpeg-devel] [PATCH 2/2] ffprobe: add -o option

2022-06-12 Thread Stefano Sabatini
On date Thursday 2022-06-09 21:09:02 +0200, Marton Balint wrote: > On Sun, 3 Apr 2022, Stefano Sabatini wrote: [...] > > Updated again, now it's locally passing fate with FATE samples (don't > > remember if other issues were spotted the past time). > > This looks good to me in general, so I intend

Re: [FFmpeg-devel] [PATCH 1/2] lavf/avio: add avio_vprintf()

2022-06-12 Thread Stefano Sabatini
On date Thursday 2022-06-09 21:03:02 +0200, Marton Balint wrote: > > > On Sun, 3 Apr 2022, Stefano Sabatini wrote: > > > On date Wednesday 2021-04-21 23:53:35 +0200, Stefano Sabatini wrote: > > > On date Sunday 2021-04-18 23:30:57 +0200, Stefano Sabatini wrote: > > > > This new function makes it

Re: [FFmpeg-devel] [PATCH 2/2] doc/ffprobe: clarify that the input file is not optional

2022-06-12 Thread Stefano Sabatini
On date Thursday 2022-04-21 12:36:15 +0530, Gyan Doshi wrote: > Pushed as 83e1a1de8833845224948e5d002355c03dd117d5 Thanks. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link

Re: [FFmpeg-devel] [PATCH] all: Replace if (ARCH_FOO) checks by #if ARCH_FOO

2022-06-12 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Martin Storsjö > Sent: Sunday, June 12, 2022 10:58 AM > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Cc: Andreas Rheinhardt > Subject: Re: [FFmpeg-devel] [PATCH] all: Replace if (ARCH_FOO) checks > by #if AR

Re: [FFmpeg-devel] [PATCH] all: Replace if (ARCH_FOO) checks by #if ARCH_FOO

2022-06-12 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Hendrik Leppkes > Sent: Sunday, June 12, 2022 11:09 AM > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH] all: Replace if (ARCH_FOO) checks > by #if ARCH_FOO > > On Sun, Jun

Re: [FFmpeg-devel] [PATCH] all: Replace if (ARCH_FOO) checks by #if ARCH_FOO

2022-06-12 Thread Hendrik Leppkes
On Sun, Jun 12, 2022 at 10:17 AM Soft Works wrote: > > > > > -Original Message- > > From: ffmpeg-devel On Behalf Of > > Andreas Rheinhardt > > Sent: Sunday, June 12, 2022 7:28 AM > > To: ffmpeg-devel@ffmpeg.org > > Cc: Andreas Rheinhardt > > Subject: [FFmpeg-devel] [PATCH] all: Replace i

Re: [FFmpeg-devel] [PATCH] all: Replace if (ARCH_FOO) checks by #if ARCH_FOO

2022-06-12 Thread Martin Storsjö
On Sun, 12 Jun 2022, Martin Storsjö wrote: On Sun, 12 Jun 2022, Soft Works wrote: -Original Message- From: ffmpeg-devel On Behalf Of Andreas Rheinhardt Sent: Sunday, June 12, 2022 7:28 AM To: ffmpeg-devel@ffmpeg.org Cc: Andreas Rheinhardt Subject: [FFmpeg-devel] [PATCH] all: Repla

Re: [FFmpeg-devel] [PATCH] all: Replace if (ARCH_FOO) checks by #if ARCH_FOO

2022-06-12 Thread Martin Storsjö
On Sun, 12 Jun 2022, Soft Works wrote: -Original Message- From: ffmpeg-devel On Behalf Of Andreas Rheinhardt Sent: Sunday, June 12, 2022 7:28 AM To: ffmpeg-devel@ffmpeg.org Cc: Andreas Rheinhardt Subject: [FFmpeg-devel] [PATCH] all: Replace if (ARCH_FOO) checks by #if ARCH_FOO This

Re: [FFmpeg-devel] [PATCH] all: Replace if (ARCH_FOO) checks by #if ARCH_FOO

2022-06-12 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Andreas Rheinhardt > Sent: Sunday, June 12, 2022 7:28 AM > To: ffmpeg-devel@ffmpeg.org > Cc: Andreas Rheinhardt > Subject: [FFmpeg-devel] [PATCH] all: Replace if (ARCH_FOO) checks by > #if ARCH_FOO > > This is more spec-complian