On 5/15/2022 10:16 PM, Michael Niedermayer wrote:
Maybe helps coverity
Helps: CID1433771
Signed-off-by: Michael Niedermayer
---
libavcodec/mpeg4videodec.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/libavcodec/mpeg4videodec.c b/libavcodec/mpeg4videodec.c
index e2
Fixes: missing error check
Fixes: CID717495
Signed-off-by: Michael Niedermayer
---
libavformat/act.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/libavformat/act.c b/libavformat/act.c
index 6dd9f62a87..da73fcceca 100644
--- a/libavformat/act.c
+++ b/libavformat/act.c
@
Maybe helps coverity
Helps: CID1433771
Signed-off-by: Michael Niedermayer
---
libavcodec/mpeg4videodec.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/libavcodec/mpeg4videodec.c b/libavcodec/mpeg4videodec.c
index e2bde73639..715cb606c9 100644
--- a/libavcodec/mpeg4videode
Fixes: missing error check
Fixes: CID1504270
Signed-off-by: Michael Niedermayer
---
libavformat/jpegxl_probe.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/libavformat/jpegxl_probe.c b/libavformat/jpegxl_probe.c
index 9cd00da194..3de002f004 100644
--- a/libavformat/jpe
> -Original Message-
> From: ffmpeg-devel On Behalf Of
> Andreas Rheinhardt
> Sent: Sunday, May 15, 2022 8:12 PM
> To: ffmpeg-devel@ffmpeg.org
> Subject: Re: [FFmpeg-devel] [PATCH v4 06/10] libavformat/asfdec: fix
> macro definition and use
>
> softworkz:
> > From: softworkz
> >
> > S
From: softworkz
Signed-off-by: softworkz
---
libavformat/os_support.h | 26 +-
1 file changed, 21 insertions(+), 5 deletions(-)
diff --git a/libavformat/os_support.h b/libavformat/os_support.h
index 5e6b32d2dc..bd8c89568f 100644
--- a/libavformat/os_support.h
+++ b/liba
From: softworkz
Signed-off-by: softworkz
---
libavutil/file_open.c | 2 +-
libavutil/wchar_filename.h | 156 +
2 files changed, 157 insertions(+), 1 deletion(-)
diff --git a/libavutil/file_open.c b/libavutil/file_open.c
index cc302f2f76..57c5e78d51 10
This patchset adds support for long file and directory paths on Windows. The
implementation follows the same logic that .NET is using internally, with
the only exception that it doesn't expand short path components in 8.3
format. .NET does this as the same function is also used for other purposes,
> -Original Message-
> From: ffmpeg-devel On Behalf Of nil-
> admir...@mailo.com
> Sent: Sunday, May 15, 2022 9:13 PM
> To: ffmpeg-devel@ffmpeg.org
> Subject: Re: [FFmpeg-devel] [PATCH 2/2] avformat/os_support: Support
> long file names on Windows
>
> > diff --git a/libavformat/os_supp
> -Original Message-
> From: ffmpeg-devel On Behalf Of nil-
> admir...@mailo.com
> Sent: Sunday, May 15, 2022 9:54 PM
> To: ffmpeg-devel@ffmpeg.org
> Subject: Re: [FFmpeg-devel] [PATCH v11 1/6]
> libavutil/wchar_filename.h: Add whcartoutf8, wchartoansi and
> utf8toansi
>
> > All these
> -Original Message-
> From: ffmpeg-devel On Behalf Of nil-
> admir...@mailo.com
> Sent: Sunday, May 15, 2022 9:36 PM
> To: ffmpeg-devel@ffmpeg.org
> Subject: Re: [FFmpeg-devel] [PATCH 0/2] Support long file names on
> Windows
>
> > I have kept the individual functions separate on purp
> -Original Message-
> From: ffmpeg-devel On Behalf Of nil-
> admir...@mailo.com
> Sent: Sunday, May 15, 2022 9:03 PM
> To: ffmpeg-devel@ffmpeg.org
> Subject: Re: [FFmpeg-devel] [PATCH 1/2] avutil/wchar_filename,
> file_open: Support long file names on Windows
>
> > diff --git a/libavu
switch-case over es_type and then perform a linear search over
startcode.
---
This version doesn't use stdbool.h but is otherwise identical.
libavformat/mpeg.c | 213 +++--
1 file changed, 130 insertions(+), 83 deletions(-)
diff --git a/libavformat/mpeg.c
printf %s with a null pointer is undefined behavior.
---
doc/examples/demuxing_decoding.c | 10 +-
doc/examples/extract_mvs.c | 4 ++--
fftools/ffmpeg.c | 12 ++--
fftools/ffmpeg_mux.c | 2 +-
fftools/ffmpeg_opt.c | 2 +-
fftools/ffp
This deprecates av_get_media_type_string() which does return NULL.
printf %s with a null pointer is undefined behavior
This also matches behavior with avcodec_get_name() which never returns NULL,
instead it returns "unknown_codec".
---
doc/APIchanges | 3 +++
libavutil/avutil.h | 10 +++
printf %s with NULL is undefined behavior.
This version adds #include "attributes.h" for -Wdeprecated-declarations.
-Scott Theisen
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe,
> All these paths end up either in win32_open (in file_open.c) or in
> one of the functions mapped inside os_support.h where they are now
> (with my submitted patchset) handled by the get_extended_win32_path()
> function, which handles all cases (e.g. forward slashes, relative paths,
> prefixed, n
> I have kept the individual functions separate on purpose, to make it easy to
> compare with the .NET impl. (compilers should inlinie those anyway)
Calling add_extended_prefix without pre-validation results in error,
since it does check for \\?\, \\.\, or \??\; only it's wrapper
get_extended_win
From: softworkz
Signed-off-by: softworkz
---
fftools/opt_common: add missing include of avf/version.h
MSVC compiler complains without this include
v2: also include avfilter.h as suggested
v3: adjust commit message as suggested by Andreas
Published-As:
https://github.c
On Sun, May 15, 2022 at 9:51 PM Andreas Rheinhardt
wrote:
>
> Jan Ekström:
> > On Sun, May 15, 2022 at 8:57 PM Andreas Rheinhardt
> > wrote:
> >>
> >> av_dict_set() expects a different set of flags, namely the AV_DICT_*
> >> flags. Using AV_OPT_FLAG_DECODING_PARAM (or any AV_OPT_FLAG_*) ic
> >> a
On Sun, May 15, 2022 at 08:55:49PM +0200, Michael Niedermayer wrote:
> On Sun, May 15, 2022 at 12:49:51PM -0400, Ronald S. Bultje wrote:
> > Hi,
> >
> > On Fri, May 13, 2022 at 5:22 PM Michael Niedermayer
> > wrote:
> >
> > > On Fri, May 13, 2022 at 11:42:08AM -0400, Leo Izen wrote:
> > > > This
> diff --git a/libavformat/os_support.h b/libavformat/os_support.h
In addition to what you've already added, this file defines stat as:
#ifdef _WIN32
...
# ifdef stat
# undef stat
# endif
# define stat _stati64
...
which is
1. not wide-char aware (_wstati64 does exist)
2. not long path awar
> diff --git a/libavutil/wchar_filename.h b/libavutil/wchar_filename.h
> ...
> +static inline int path_is_extended(const wchar_t *path)
> ...
Why path handling functions ended up in wchar_filename.h?
Isn't it better to move them to file_open or os_support?
> +num_chars = GetFullPathNameW(*ppa
On Sun, May 15, 2022 at 12:49:51PM -0400, Ronald S. Bultje wrote:
> Hi,
>
> On Fri, May 13, 2022 at 5:22 PM Michael Niedermayer
> wrote:
>
> > On Fri, May 13, 2022 at 11:42:08AM -0400, Leo Izen wrote:
> > > This commit moves some of the functionality from avfilter/colorspace
> > > into avutil/cs
Jan Ekström:
> On Sun, May 15, 2022 at 8:57 PM Andreas Rheinhardt
> wrote:
>>
>> av_dict_set() expects a different set of flags, namely the AV_DICT_*
>> flags. Using AV_OPT_FLAG_DECODING_PARAM (or any AV_OPT_FLAG_*) ic
>> av_dict_set() is therefore completely wrong and given that av_dict_set()
>>
Ping; it still applies cleanly.
-Scott Theisen
On 2/8/22 15:32, Scott Theisen wrote:
Also add a few clarifying comments.
---
libavcodec/cbs_mpeg2.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/libavcodec/cbs_mpeg2.c b/libavcodec/cbs_mpeg2.c
index 33bd3
On Sun, May 15, 2022 at 8:57 PM Andreas Rheinhardt
wrote:
>
> av_dict_set() expects a different set of flags, namely the AV_DICT_*
> flags. Using AV_OPT_FLAG_DECODING_PARAM (or any AV_OPT_FLAG_*) ic
> av_dict_set() is therefore completely wrong and given that av_dict_set()
> just doesn't care abou
softworkz:
> From: softworkz
>
> Signed-off-by: softworkz
> ---
> libavformat/asfdec_f.c | 24
> 1 file changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/libavformat/asfdec_f.c b/libavformat/asfdec_f.c
> index 81a29f99d5..91c3874ac7 100644
> --- a/libavformat
On Sun, 15 May 2022 12:49:51 -0400 "Ronald S. Bultje"
wrote:
> To explain: when I designed this stuff, I chose to keep them in float so
> that we can use the literal values from the specs, which are themselves in
> floating point. That would not be possible anymore, and would therefore
> make it
av_dict_set() expects a different set of flags, namely the AV_DICT_*
flags. Using AV_OPT_FLAG_DECODING_PARAM (or any AV_OPT_FLAG_*) ic
av_dict_set() is therefore completely wrong and given that av_dict_set()
just doesn't care about whether the string it receives has anything
to do with a decoding p
Hi,
On Fri, May 13, 2022 at 5:22 PM Michael Niedermayer
wrote:
> On Fri, May 13, 2022 at 11:42:08AM -0400, Leo Izen wrote:
> > This commit moves some of the functionality from avfilter/colorspace
> > into avutil/csp and exposes it as a public API so it can be used by
> > libavcodec and/or libavf
softworkz:
> From: softworkz
>
> required for PRINT_LIB_INFO(avfilter...
>
> Signed-off-by: softworkz
> ---
> fftools/opt_common: add missing include of avf/version.h
>
> MSVC compiler complains without this include
>
> v2: also include avfilter.h as suggested
>
> Publish
Leo Izen:
> This commit moves some of the functionality from avfilter/colorspace
> into avutil/csp and exposes it as a public API so it can be used by
> libavcodec and/or libavformat.
> ---
> libavfilter/colorspace.c| 88
> libavfilter/colorspace.h| 25 +-
Alex Agranovsky:
> Hello,
>
>
> I've been chasing the problem with VideoToolbox failures to decode on
> iOS and Apple Silicone described in https://trac.ffmpeg.org/ticket/9713
>
> As I've mentioned in the ticket, the problem seems to boil down to the
> last byte of PPS "disappearing" by the time
On Sun, May 15, 2022 at 2:58 PM Gyan Doshi wrote:
>
>
>
> On 2022-05-15 04:29 pm, Jan Ekström wrote:
> > On Thu, May 12, 2022 at 11:19 AM Anton Khirnov wrote:
> >> Quoting Gyan Doshi (2022-05-12 09:01:31)
> >>> A substitute option for metadata rotate would accept a single rotation
> >>> value.
>
On 2022-05-15 04:29 pm, Jan Ekström wrote:
On Thu, May 12, 2022 at 11:19 AM Anton Khirnov wrote:
Quoting Gyan Doshi (2022-05-12 09:01:31)
A substitute option for metadata rotate would accept a single rotation
value.
If adding an option for matrix, we should allow flips too.
I see no reason
On Thu, May 12, 2022 at 11:19 AM Anton Khirnov wrote:
>
> Quoting Gyan Doshi (2022-05-12 09:01:31)
> > A substitute option for metadata rotate would accept a single rotation
> > value.
> > If adding an option for matrix, we should allow flips too.
>
> I see no reason not to have both. You can have
Hello Mates,
It has emerged from various discussions that some points of the General
Assembly and community regarding to voting wasn't 100% precise and clear for
everyone.
Some points were opened to interpretations and what was written down did not
match completely what was said.
And I would pr
38 matches
Mail list logo
