Re: [FFmpeg-devel] [PATCH v4 2/2] doc/examples/transcode_aac: Set decoder packet timebase

2022-04-27 Thread Andreas Rheinhardt
Andreas Unterweger: > Previously, the default timebase caused two warnings during decoding > about not being able to update timestamps for skipped and discarded > samples, respectively. > > Signed-off-by: Andreas Unterweger > --- > doc/examples/transcode_aac.c | 6 +- > 1 file changed, 5 ins

[FFmpeg-devel] [PATCH] avformat/jpegxl_probe: Fix potential incorrect and UB shift

2022-04-27 Thread Andreas Rheinhardt
Fixes Coverity issue #1504273. Signed-off-by: Andreas Rheinhardt --- libavformat/jpegxl_probe.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/jpegxl_probe.c b/libavformat/jpegxl_probe.c index 924b529ad5..9cd00da194 100644 --- a/libavformat/jpegxl_probe.c +++

Re: [FFmpeg-devel] [PATCH] libavcodec/qsvdec.c: extract frame packing arrangement data

2022-04-27 Thread Chen, Wenbin
> On Tue, 2022-04-26 at 18:00 +0800, Wenbin Chen wrote: > > Use h264_sei to parse SEI data got from MediaSDK. Extract frame > > packing arrangement information from SEI data and config AVStereo3D > > side data for decoded frame. > > > > Signed-off-by: Wenbin Chen > > Signed-off-by: Tong Wu > > --

Re: [FFmpeg-devel] [PATCH] libavcodec/qsvdec.c: extract frame packing arrangement data

2022-04-27 Thread Andreas Rheinhardt
Wenbin Chen: > Use h264_sei to parse SEI data got from MediaSDK. Extract frame > packing arrangement information from SEI data and config AVStereo3D > side data for decoded frame. > > Signed-off-by: Wenbin Chen > Signed-off-by: Tong Wu > --- > libavcodec/qsv_internal.h | 2 + > libavcodec/qsv

[FFmpeg-devel] [PATCH 2/2] avfilter/Makefile: Add fflcms2.h to SKIPHEADERS- if necessary

2022-04-27 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavfilter/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/libavfilter/Makefile b/libavfilter/Makefile index 1db097b464..e06acdf881 100644 --- a/libavfilter/Makefile +++ b/libavfilter/Makefile @@ -596,6 +596,7 @@ SHLIBOBJS

[FFmpeg-devel] [PATCH 1/2] avcodec/Makefile: Add libjxl.h to SKIPHEADERS if necessary

2022-04-27 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/Makefile b/libavcodec/Makefile index d6ad23474d..cfaa6f196a 100644 --- a/libavcodec/Makefile +++ b/libavcodec/Makefile @@ -1229,6 +1229,7 @@ SKIPHEADERS-$(CONFIG_AMF)

Re: [FFmpeg-devel] Guidance needed for a semi-breaking change

2022-04-27 Thread MCC CS
Would you then approve changing current 0 from HIGH to MAX? Alternatively -1 can be added until a major bump, while keeping 0 as default. Either would be nondestructive. And do you have an example/doc text about adding version guards to an arg? I hope there's a general preprocessor variable for FF

Re: [FFmpeg-devel] Guidance needed for a semi-breaking change

2022-04-27 Thread Timo Rothenpieler
On 27.04.2022 16:07, MCC CS wrote: The default for AAC_AT is to produce highest quality audio, which I'll keep undoubtedly in the same direction. However, the question is this: Should the one who explicitly set `-aac_at_quality 0` (highest quality available) be moved from HIGH to MAX, HOWEVER

[FFmpeg-devel] [PATCH v2] doc/encoders: document libjxl encoder options

2022-04-27 Thread Leo Izen
Add more detailed documenation for the libjxl encoder wrapper than is present currently inside libavcodec. --- doc/encoders.texi | 35 +++ 1 file changed, 35 insertions(+) diff --git a/doc/encoders.texi b/doc/encoders.texi index aac9f25e55..51f0dc3fcb 100644 --- a/

Re: [FFmpeg-devel] [PATCH v4 2/2] doc/examples/transcode_aac: Set decoder packet timebase

2022-04-27 Thread Andreas Unterweger
On Wed, 27 Apr 2022 at 16:07, Andreas Unterweger wrote: > > Previously, the default timebase caused two warnings during decoding > about not being able to update timestamps for skipped and discarded > samples, respectively. > > Signed-off-by: Andreas Unterweger > --- > doc/examples/transcode_aac

[FFmpeg-devel] [PATCH v4 2/2] doc/examples/transcode_aac: Set decoder packet timebase

2022-04-27 Thread Andreas Unterweger
Previously, the default timebase caused two warnings during decoding about not being able to update timestamps for skipped and discarded samples, respectively. Signed-off-by: Andreas Unterweger --- doc/examples/transcode_aac.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --gi

Re: [FFmpeg-devel] Guidance needed for a semi-breaking change

2022-04-27 Thread MCC CS
The default for AAC_AT is to produce highest quality audio, which I'll keep undoubtedly in the same direction. However, the question is this: Should the one who explicitly set `-aac_at_quality 0` (highest quality available) be moved from HIGH to MAX, HOWEVER causing the side effect of moving eve

[FFmpeg-devel] [PATCH v4 1/2] doc/examples/transcode_aac: Don't ignore last encoded

2022-04-27 Thread Andreas Unterweger
The last encoded frame is now fetched on EOF. It was previously left in the encoder and caused a "1 frame left in queue" warning. Signed-off-by: Andreas Unterweger --- doc/examples/transcode_aac.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/doc/ex

Re: [FFmpeg-devel] [PATCH v3 2/2] doc/examples/transcode_aac: Set decoder packet timebase

2022-04-27 Thread Andreas Unterweger
Am 27.04.2022 um 15:35 schrieb Andreas Unterweger: Previously, the default timebase caused two warnings during decoding about not being able to update timestamps for skipped and discarded samples, respectively. Signed-off-by: Andreas Unterweger ---  doc/examples/transcode_aac.c | 6 +-  

[FFmpeg-devel] [PATCH v3 2/2] doc/examples/transcode_aac: Set decoder packet timebase

2022-04-27 Thread Andreas Unterweger
Previously, the default timebase caused two warnings during decoding about not being able to update timestamps for skipped and discarded samples, respectively. Signed-off-by: Andreas Unterweger --- doc/examples/transcode_aac.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff -

[FFmpeg-devel] [PATCH v3 1/2] doc/examples/transcode_aac: Don't ignore last encoded frame

2022-04-27 Thread Andreas Unterweger
The last encoded frame is now fetched on EOF. It was previously left in the encoder and caused a "1 frame left in queue" warning. Signed-off-by: Andreas Unterweger --- doc/examples/transcode_aac.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/doc/

Re: [FFmpeg-devel] [PATCH] doc/encoders: document libjxl encoder options

2022-04-27 Thread Gyan Doshi
On 2022-04-27 05:58 pm, Leo Izen wrote: On 4/27/22 04:39, Gyan Doshi wrote: On 2022-04-27 02:38 am, Leo Izen wrote: + +@item modular +Force the encoder to use Modular mode. The default is to let the encoder pick +between VarDCT and Modular encoding modes based on encoding settings and t

Re: [FFmpeg-devel] Guidance needed for a semi-breaking change

2022-04-27 Thread Nicolas George
Timo Rothenpieler (12022-04-27): > Any existing commandline should produce the exact same output after the > change. I do not agree. Small changes in default behavior are acceptable, since the user did not specify what they want. (I would argue that changes that fix a bug and changes that are un

Re: [FFmpeg-devel] Guidance needed for a semi-breaking change

2022-04-27 Thread Timo Rothenpieler
Any existing commandline should produce the exact same output after the change. Not sure if the encoder is bitexact, but if it is, the output should match. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-

Re: [FFmpeg-devel] Guidance needed for a semi-breaking change

2022-04-27 Thread MCC CS
I wasn't considering a breaking change, those using -aac_at_quality 0 or -aac_at_quality 2 would continue to use those. However, would moving -aac_at_quality 0 from HIGH (currently highest used by FFMPEG) to MAX be welcome? I'd assume that those using -aac_at_quality 0 do so to use the highest qual

Re: [FFmpeg-devel] [PATCH] libavformat/rtsp: pkt_size option is not honored in rtsp

2022-04-27 Thread zhilizhao(赵志立)
> On Apr 6, 2022, at 8:52 PM, Yubo Xie wrote: > > Signed-off-by: xyb > --- > libavformat/rtsp.c| 4 ++-- > libavformat/rtsp.h| 1 - > libavformat/rtspenc.c | 2 +- > 3 files changed, 3 insertions(+), 4 deletions(-) > Applied, thanks! ___ ffmp

Re: [FFmpeg-devel] Guidance needed for a semi-breaking change

2022-04-27 Thread Timo Rothenpieler
You need to keep API and ABI compatibility, cause otherwise it's a breaking change which can only happen at a major bump. Any and all existing applications and commandline need to keep working as they do right now. What you could do is convert the option into a OPT_TYPE_CONST one, and offer th

[FFmpeg-devel] Guidance needed for a semi-breaking change

2022-04-27 Thread MCC CS
Hi, It's my first time writing an (original) patch for ffmpeg, so I would like your help. I’m planning to propose a diff to an encoder param for aac_at, which is, as currently listed by "ffmpeg -h encoder=aac_at”: -aac_at_qualityE...A.. quality vs speed control (from 0 to 2)

Re: [FFmpeg-devel] [PATCH] doc/encoders: document libjxl encoder options

2022-04-27 Thread Leo Izen
On 4/27/22 04:39, Gyan Doshi wrote: On 2022-04-27 02:38 am, Leo Izen wrote: + +@item modular +Force the encoder to use Modular mode. The default is to let the encoder pick +between VarDCT and Modular encoding modes based on encoding settings and the +type of input content. What happens i

[FFmpeg-devel] [PATCH] libavformat/isom: Add more language mappings

2022-04-27 Thread Ivan Baykalov
mov_mdhd_language_map table doesn't contain ISO 639 codes for some of the languages. I added a few which have no contradictory mappings Fixes ticket #9743 --- libavformat/isom.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/libavformat/isom.c b/libavformat/isom.c

Re: [FFmpeg-devel] [PATCH] libavcodec/qsvdec.c: extract frame packing arrangement data

2022-04-27 Thread Xiang, Haihao
On Tue, 2022-04-26 at 18:00 +0800, Wenbin Chen wrote: > Use h264_sei to parse SEI data got from MediaSDK. Extract frame > packing arrangement information from SEI data and config AVStereo3D > side data for decoded frame. > > Signed-off-by: Wenbin Chen > Signed-off-by: Tong Wu > --- > libavcodec

Re: [FFmpeg-devel] [PATCH] avcodec/openh264: return (DE|EN)CODER_NOT_FOUND if version check fails

2022-04-27 Thread Martin Storsjö
On Wed, 20 Apr 2022, Martin Storsjö wrote: On Fri, 18 Feb 2022, Andreas Schneider wrote: Signed-off-by: Andreas Schneider --- libavcodec/libopenh264dec.c | 2 +- libavcodec/libopenh264enc.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/libopenh264dec.c b/liba

[FFmpeg-devel] [PATCH] libavcodec/mpeg12dec: extract embedded CC of particular type only

2022-04-27 Thread Ivan Baykalov
Some streams contain closed caption data embedded using several wrapping types. For example stream can contain CC wrapped as ATSC A53 packets + the same data wrapped as SCTE-20 packets. Prior to the patch CC data was extracted from both types of packets, so it gave duplicated character pairs on the

Re: [FFmpeg-devel] [PATCH] doc/encoders: document libjxl encoder options

2022-04-27 Thread Gyan Doshi
On 2022-04-27 02:38 am, Leo Izen wrote: Add more detailed documenation for the libjxl encoder wrapper than is present currently inside libavcodec. --- doc/encoders.texi | 34 ++ 1 file changed, 34 insertions(+) diff --git a/doc/encoders.texi b/doc/encoders.t