[FFmpeg-devel] [PATCH 7/7] avcodec/xfacedec: Add AV_CODEC_CAP_DR1

2022-04-23 Thread Andreas Rheinhardt
This decoder uses ff_get_buffer() and does nothing weird (it does not even rely on any alignment of the frame's data/linesize). Signed-off-by: Andreas Rheinhardt --- libavcodec/xfacedec.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/xfacedec.c b/libavcodec/xfacedec.c index b103

[FFmpeg-devel] [PATCH 6/7] avcodec/pgxdec: Use unsigned types for unsigned values

2022-04-23 Thread Andreas Rheinhardt
Both AV_PIX_FMT_GRAY8 and AV_PIX_FMT_GRAY16 use unsigned values, not signed ones. The fact that the input might be signed in some cases in the original format doesn't change this. Signed-off-by: Andreas Rheinhardt --- libavcodec/pgxdec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

[FFmpeg-devel] [PATCH 5/7] avcodec/pgxdec: Hoist branch out of loop

2022-04-23 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/pgxdec.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/libavcodec/pgxdec.c b/libavcodec/pgxdec.c index 30895b51ee..29de103167 100644 --- a/libavcodec/pgxdec.c +++ b/libavcodec/pgxdec.c @@ -95,16 +95,13 @@ error:

[FFmpeg-devel] [PATCH 4/7] avcodec/pgxdec: Fix issue with negative linesizes

2022-04-23 Thread Andreas Rheinhardt
The PGX decoder accesses the lines via code like (PIXEL*)frame->data[0] + i*frame->linesize[0]/sizeof(PIXEL) where PIXEL is a macro parameter. This code has issues with negative linesizes, because the type of sizeof(PIXEL) is size_t, so that on common systems i*linesize/sizeof(PIXEL) will always be

[FFmpeg-devel] [PATCH 3/7] avcodec/pgxdec: Remove pointless checks

2022-04-23 Thread Andreas Rheinhardt
These checks were (most likely) added to check for overreads as the bytestream2_get_* functions return 0 in this case. Yet this is not necessary anymore as we now have an explicit check for the size. Should the input contain a real \0, pgx_get_number() will error out lateron. Signed-off-by: Andrea

[FFmpeg-devel] [PATCH 2/7] avcodec/pgxdec: Avoid always-false checks

2022-04-23 Thread Andreas Rheinhardt
We have already checked that there is data to be read. Signed-off-by: Andreas Rheinhardt --- libavcodec/pgxdec.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/libavcodec/pgxdec.c b/libavcodec/pgxdec.c index 154a683b4f..9c474036da 100644 --- a/libavcod

[FFmpeg-devel] [PATCH 1/7] avcodec/pgxdec: Make better use of size check

2022-04-23 Thread Andreas Rheinhardt
Each of the three calls to pgx_get_number() consumes at least two bytes. Signed-off-by: Andreas Rheinhardt --- libavcodec/pgxdec.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libavcodec/pgxdec.c b/libavcodec/pgxdec.c index 899e7a9994..154a683b4f 100644 --- a/libavcodec/

Re: [FFmpeg-devel] [PATCH v11 1/6] libavutil/wchar_filename.h: Add whcartoutf8, wchartoansi and utf8toansi

2022-04-23 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of Nil > Admirari > Sent: Saturday, April 23, 2022 10:56 PM > To: ffmpeg-devel@ffmpeg.org > Subject: [FFmpeg-devel] [PATCH v11 1/6] libavutil/wchar_filename.h: > Add whcartoutf8, wchartoansi and utf8toansi > > These functions are going

[FFmpeg-devel] [PATCH 32/32] fate/concatdec: Don't duplicate test requirements

2022-04-23 Thread Andreas Rheinhardt
The tests in concatdec.mak reuse files created by tests from lavf-container. Therefore these tests have the other tests as prerequisite and mostly duplicate their CONFIG-requirements. (The mxf_d10 tests did it incorrect as they only required the MXF muxer.) This duplication is of course bad as usua

[FFmpeg-devel] [PATCH 31/32] fate/lavf-container: Fix test requirements

2022-04-23 Thread Andreas Rheinhardt
Automatically inherited by the fate-seek-lavf tests based upon these tests. Signed-off-by: Andreas Rheinhardt --- tests/fate/lavf-container.mak | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/tests/fate/lavf-container.mak b/tests/fate/lavf-container.mak index 9e0

[FFmpeg-devel] [PATCH 30/32] fate/lavf-audio: Fix requirements of tests

2022-04-23 Thread Andreas Rheinhardt
These changes are automatically inherited by the fate-seek-tests based upon lavf-audio. Signed-off-by: Andreas Rheinhardt --- tests/fate/lavf-audio.mak | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/tests/fate/lavf-audio.mak b/tests/fate/lavf-audio.mak index a06

[FFmpeg-devel] [PATCH 29/32] fate/lavf-video: Fix test requirements

2022-04-23 Thread Andreas Rheinhardt
The new requirements are also automatically inherited by the FATE_SEEK_LAVF_VIDEO seek-tests. Signed-off-by: Andreas Rheinhardt --- tests/fate/lavf-video.mak | 24 ++-- 1 file changed, 14 insertions(+), 10 deletions(-) diff --git a/tests/fate/lavf-video.mak b/tests/fate/lavf

[FFmpeg-devel] [PATCH 28/32] fate/lavf-image2pipe: Fix test requirements

2022-04-23 Thread Andreas Rheinhardt
The fix is automatically inherited by the corresponding fate-seek-lavf-*pipe tests. Signed-off-by: Andreas Rheinhardt --- tests/fate/lavf-image2pipe.mak | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/tests/fate/lavf-image2pipe.mak b/tests/fate/lavf-image2pipe.mak

[FFmpeg-devel] [PATCH 27/32] avformat/format: Also search for image2-codecs for image2pipe

2022-04-23 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavformat/format.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/format.c b/libavformat/format.c index 5f8155be59..4b1f3c2986 100644 --- a/libavformat/format.c +++ b/libavformat/format.c @@ -99,7 +99,7 @@ enum AVCodecID av_

[FFmpeg-devel] [PATCH 26/32] fate/acodec: Remove acodec-adpcm-adx-trellis test

2022-04-23 Thread Andreas Rheinhardt
adx ignores the trellis option, making this test identical to acodec-adpcm-adx. Signed-off-by: Andreas Rheinhardt --- tests/fate/acodec.mak | 3 +-- tests/ref/acodec/adpcm-adx-trellis | 4 2 files changed, 1 insertion(+), 6 deletions(-) delete mode 100644 tests/ref/acodec/adpc

[FFmpeg-devel] [PATCH 25/32] fate/acodec: Fix test requirements

2022-04-23 Thread Andreas Rheinhardt
This automatically fixes the requirements of the fate-seek-acodec* tests (e.g. 16 of the 27 such tests are now automatically disabled if the aresample filter is disabled). Signed-off-by: Andreas Rheinhardt --- tests/fate/acodec.mak | 85 ++- 1 file changed

[FFmpeg-devel] [PATCH 24/32] fate/vcodec: Fix test requirements

2022-04-23 Thread Andreas Rheinhardt
This automatically fixes the requirements of the fate-seek-vsynth* tests (e.g. 16 of the 49 such tests are now automatically disabled if the scale filter is disabled). Signed-off-by: Andreas Rheinhardt --- tests/fate/vcodec.mak | 82 +++ 1 file changed, 44

[FFmpeg-devel] [PATCH 23/32] fate/vcodec: Don't add scale filter unnecessarily

2022-04-23 Thread Andreas Rheinhardt
If one uses a -s command, a scale filter is inserted even when doing so is redundant. This patch stops doing so. This makes the tests that don't need libswscale actually succeed in case it is disabled (only 315 of 470 tests need it). Signed-off-by: Andreas Rheinhardt --- tests/fate/vcodec.mak |

[FFmpeg-devel] [PATCH 22/32] fate/seek: Don't duplicate test requirements

2022-04-23 Thread Andreas Rheinhardt
Most of the tests in seek.mak use files created by other tests as input. Therefore these tests have the other tests as prerequisite and duplicate their CONFIG-requirements. This duplication is of course bad as usual, so stop it by using the corresponding variable that contains the non-seek-tests th

[FFmpeg-devel] [PATCH 21/32] fate/seek: Avoid list of source files

2022-04-23 Thread Andreas Rheinhardt
The output files of the lavf tests are highly regular, allowing to use rules for the src files instead of a list. Signed-off-by: Andreas Rheinhardt --- The list of vsynth and acodec src file names could be removed if the tests were to be renamed/modified to allow to infer said filename from the n

[FFmpeg-devel] [PATCH 20/32] tests/fate-run: Remove intermediate lavf_container_fate files

2022-04-23 Thread Andreas Rheinhardt
They are not used lateron. Signed-off-by: Andreas Rheinhardt --- tests/fate-run.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/fate-run.sh b/tests/fate-run.sh index 8c27210ac0..a96ff049b0 100755 --- a/tests/fate-run.sh +++ b/tests/fate-run.sh @@ -340,6 +340,7 @@ lavf_container_fate

[FFmpeg-devel] [PATCH 19/32] fate/speedhq: Fix test requirements

2022-04-23 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- tests/fate/speedhq.mak | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/fate/speedhq.mak b/tests/fate/speedhq.mak index 32405b710f..199ee160ea 100644 --- a/tests/fate/speedhq.mak +++ b/tests/fate/speedhq.mak @@ -4,5 +4,5 @@ FATE_SPEED

[FFmpeg-devel] [PATCH 18/32] avformat/fitsenc: Simplify writing header padding

2022-04-23 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavformat/fitsenc.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/libavformat/fitsenc.c b/libavformat/fitsenc.c index 5cf34ef067..37ee10bb13 100644 --- a/libavformat/fitsenc.c +++ b/libavformat/fitsenc.c @@ -24,6 +24,7 @@ * FI

[FFmpeg-devel] [PATCH 17/32] fate/fits: Use transcode for transcode-like test

2022-04-23 Thread Andreas Rheinhardt
Each of the intermediately generated lena-*.fits files is only used for exactly one test; so it could be deleted right after the test. Switching to a transcode test (which is also more natural) achieves this. It also adds checksums of the intermediate files to the ref-file. Signed-off-by: Andreas

[FFmpeg-devel] [PATCH 07/32] tests/Makefile: Make DEMDEC etc. auxiliary functions more flexible

2022-04-23 Thread Andreas Rheinhardt
Add a parameter that allows to add additional requirements. Also add FILE_PROTOCOL to all the auxiliary functions that use a demuxer. Also fix the requirements for the fate-mpegts-probe-(latm|program) tests. They have misused DEMDEC. Signed-off-by: Andreas Rheinhardt --- tests/Makefile|

[FFmpeg-devel] [PATCH 15/32] fate/utvideo: Fix test requirements

2022-04-23 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- tests/fate/utvideo.mak | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/tests/fate/utvideo.mak b/tests/fate/utvideo.mak index 9329df5386..bf8401c370 100644 --- a/tests/fate/utvideo.mak +++ b/tests/fate/utvideo.mak @@ -64,8 +64,9

[FFmpeg-devel] [PATCH 14/32] fate/bmp: Fix test requirements

2022-04-23 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- tests/fate/bmp.mak | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/fate/bmp.mak b/tests/fate/bmp.mak index de27f19b15..050d3d1357 100644 --- a/tests/fate/bmp.mak +++ b/tests/fate/bmp.mak @@ -22,7 +22,7 @@ fate-bmp-15bit-mask: CMD

[FFmpeg-devel] [PATCH 16/32] fate/fits: Fix test requirements

2022-04-23 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- tests/fate/fits.mak | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/tests/fate/fits.mak b/tests/fate/fits.mak index f16fc83266..ea471d6654 100644 --- a/tests/fate/fits.mak +++ b/tests/fate/fits.mak @@ -18,19 +18,19 @@ tests/

[FFmpeg-devel] [PATCH 13/32] fate/cdxl: Fix test requirements

2022-04-23 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- tests/fate/cdxl.mak | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/fate/cdxl.mak b/tests/fate/cdxl.mak index 2a4e2dd510..db3045c27c 100644 --- a/tests/fate/cdxl.mak +++ b/tests/fate/cdxl.mak @@ -7,13 +7,13 @@ fate-cdxl-ham6: C

[FFmpeg-devel] [PATCH 11/32] fate/video: Fix test requirements

2022-04-23 Thread Andreas Rheinhardt
In particular, add the missing dependency on the scale and aresample filters (and therefore on libswscale resp. libswresample). Signed-off-by: Andreas Rheinhardt --- tests/fate/video.mak | 216 ++- 1 file changed, 110 insertions(+), 106 deletions(-) diff

[FFmpeg-devel] [PATCH 12/32] fate/dfa: Fix test requirements

2022-04-23 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- tests/fate/dfa.mak | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/fate/dfa.mak b/tests/fate/dfa.mak index 5b725e3a99..682a9d10b2 100644 --- a/tests/fate/dfa.mak +++ b/tests/fate/dfa.mak @@ -31,7 +31,7 @@ fate-dfa10: CMD = framecrc -

[FFmpeg-devel] [PATCH 10/32] fate/screen: Fix test requirements

2022-04-23 Thread Andreas Rheinhardt
In particular, add the missing dependency on the scale filter (and therefore on libswscale). Signed-off-by: Andreas Rheinhardt --- tests/fate/screen.mak | 55 --- 1 file changed, 31 insertions(+), 24 deletions(-) diff --git a/tests/fate/screen.mak b/tests

[FFmpeg-devel] [PATCH 09/32] tests/Makefile: Add FRAMECRC function

2022-04-23 Thread Andreas Rheinhardt
Intended for scenarios that currently use DEMDEC, but are missing the requirements that are implicitly needed by framecrc. Signed-off-by: Andreas Rheinhardt --- tests/Makefile | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/Makefile b/tests/Makefile index e175631258..1c9e3594c0 1006

[FFmpeg-devel] [PATCH 08/32] fate/image: Fix requirements of tests

2022-04-23 Thread Andreas Rheinhardt
Also reduce the amount of repetitions a bit. Signed-off-by: Andreas Rheinhardt --- tests/fate/image.mak | 129 +++ 1 file changed, 57 insertions(+), 72 deletions(-) diff --git a/tests/fate/image.mak b/tests/fate/image.mak index 63076f8ded..c8e0d321ef 1006

[FFmpeg-devel] [PATCH 06/32] fate/lavf-image: Fix requirements of tests

2022-04-23 Thread Andreas Rheinhardt
In particular, add the missing dependency on the scale filter (and therefore on libswscale). Signed-off-by: Andreas Rheinhardt --- tests/fate/lavf-image.mak | 70 +-- 1 file changed, 37 insertions(+), 33 deletions(-) diff --git a/tests/fate/lavf-image.mak b/t

[FFmpeg-devel] [PATCH 05/32] fate/mov: Use REMUX and TRANSCODE where appropriate

2022-04-23 Thread Andreas Rheinhardt
Also fix the requirements of fate-mov-channel-description: It needs the pcm_s16le decoder and the mov demuxer. Signed-off-by: Andreas Rheinhardt --- tests/fate/mov.mak | 18 +- 1 file changed, 5 insertions(+), 13 deletions(-) diff --git a/tests/fate/mov.mak b/tests/fate/mov.mak

[FFmpeg-devel] [PATCH 04/32] fate/caf: Use REMUX where appropriate

2022-04-23 Thread Andreas Rheinhardt
And drop the FATE_CAF_REMUX variables which only existed to avoid having to repeat the common FILE_PROTOCOL PIPE_PROTOCOL FRAMECRC_MUXER stuff. Signed-off-by: Andreas Rheinhardt --- tests/fate/caf.mak | 21 +++-- 1 file changed, 7 insertions(+), 14 deletions(-) diff --git a/test

[FFmpeg-devel] [PATCH 03/32] fate/amr[nw]b: Use REMUX where appropriate

2022-04-23 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- tests/fate/amrnb.mak | 4 +--- tests/fate/amrwb.mak | 4 +--- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/tests/fate/amrnb.mak b/tests/fate/amrnb.mak index f4f74f14d9..6f5ed413e3 100644 --- a/tests/fate/amrnb.mak +++ b/tests/fate/amrnb.mak

[FFmpeg-devel] [PATCH 02/32] fate/id3v2: Use REMUX where appropriate

2022-04-23 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- tests/fate/id3v2.mak | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/tests/fate/id3v2.mak b/tests/fate/id3v2.mak index fea7545270..fc574e4487 100644 --- a/tests/fate/id3v2.mak +++ b/tests/fate/id3v2.mak @@ -1,14 +1,10 @@ FATE_ID3V

[FFmpeg-devel] [PATCH 01/32] fate/matroska: Use REMUX and TRANSCODE where appropriate

2022-04-23 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- tests/fate/matroska.mak | 70 ++--- 1 file changed, 23 insertions(+), 47 deletions(-) diff --git a/tests/fate/matroska.mak b/tests/fate/matroska.mak index 3073b0a061..c9d88975ca 100644 --- a/tests/fate/matroska.mak +++ b/t

[FFmpeg-devel] [PATCH] lavf/tls_mbedtls: add support for mbedtls version 3

2022-04-23 Thread Timo Rothenpieler
- certs.h is gone. Only contains test data, and was not used at all. - config.h is renamed. Was seemingly not used, so can be removed. - MBEDTLS_ERR_SSL_NO_USABLE_CIPHERSUITE is gone, instead MBEDTLS_ERR_SSL_HANDSHAKE_FAILURE will be thrown. - mbedtls_pk_parse_keyfile now needs to be passed a pro

Re: [FFmpeg-devel] [PATCH v9 6/6] fftools: Use UTF-8 on Windows

2022-04-23 Thread nil-admirari
> This needs a similar commit message as what I suggested for the previous > commit, explaining what it does, when, why, and clarifying that this is a > noop for older versions. Done: https://ffmpeg.org/pipermail/ffmpeg-devel/2022-April/295572.html. > In particular, it'd be interesting to know

Re: [FFmpeg-devel] [PATCH v9 5/6] fftools: Enable long path support on Windows (fixes #8885)

2022-04-23 Thread nil-admirari
> Does that sound like the correct explanation of the situation? Yes, thanks. I altered the suggested message a bit. New version of the patch: https://ffmpeg.org/pipermail/ffmpeg-devel/2022-April/295571.html. ___ ffmpeg-devel mailing list ffmpeg-dev

Re: [FFmpeg-devel] [PATCH v9 4/6] fftools/cmdutils.c: Remove MAX_PATH limit and replace fopen with av_fopen_utf8

2022-04-23 Thread nil-admirari
> > +#include "compat/w32dlfcn.h" > This adds a dependency on nonpublic headers - which I think can be > tolerated as it's only a build-time issue, and fftools are currently built > as part of the rest of the ffmpeg build anyway. Currently the header consist entirely of static inline functions

Re: [FFmpeg-devel] [PATCH v9 2/6] libavformat/avisynth.c: Remove MAX_PATH limit

2022-04-23 Thread nil-admirari
> This looks ok to me, but as mentioned in the other patch, I think CP_ACP > actually would be more correct than the current CP_THREAD_ACP utf8toansi was changed to use CP_ACP in https://ffmpeg.org/pipermail/ffmpeg-devel/2022-April/295569.html, so avisynth.c now uses CP_ACP as well. ___

Re: [FFmpeg-devel] [PATCH v9 1/6] libavutil/wchar_filename.h: Add whcartoutf8, wchartoansi and utf8toansi

2022-04-23 Thread nil-admirari
> However while reviewing this, I noticed a preexisting issue regarding the > av_fopen_utf8 function. This patchset extends the use of that function > into fftools, which isn't great given the issue... Reverted back to fopen(). > The other question is whether it's tolerable to use more non-inst

[FFmpeg-devel] [PATCH v11 6/6] fftools: Set active code page to UTF-8 on Windows

2022-04-23 Thread Nil Admirari
Starting with Windows 1903, applications can set active code page to UTF-8 in the application manifest. It improves path name compatibility with dependencies that use char* pathnames internally, but whose code page has already been changed to UTF-8 with a manifest (e.g. AviSynth). On older version

[FFmpeg-devel] [PATCH v11 5/6] fftools: Enable long path support on Windows (fixes #8885)

2022-04-23 Thread Nil Admirari
Newer versions of Windows (Windows 10 1607 and newer) can support path names longer than MAX_PATH (260 characters). To take advantage of that, an application needs to opt in, by including a small manifest as a resource. Application must be prepared to handle filenames greater than MAX_PATH. Additi

[FFmpeg-devel] [PATCH v11 3/6] compat/w32dlfcn.h: Remove MAX_PATH limit and replace LoadLibraryExA with LoadLibraryExW

2022-04-23 Thread Nil Admirari
--- compat/w32dlfcn.h | 78 ++- 1 file changed, 64 insertions(+), 14 deletions(-) diff --git a/compat/w32dlfcn.h b/compat/w32dlfcn.h index 52a94efa..2284ac7a 100644 --- a/compat/w32dlfcn.h +++ b/compat/w32dlfcn.h @@ -25,6 +25,30 @@ #if (_WIN32_WINNT <

[FFmpeg-devel] [PATCH v11 1/6] libavutil/wchar_filename.h: Add whcartoutf8, wchartoansi and utf8toansi

2022-04-23 Thread Nil Admirari
These functions are going to be used in libavformat/avisynth.c and fftools/cmdutils.c to remove MAX_PATH limit. --- libavutil/wchar_filename.h | 51 ++ 1 file changed, 51 insertions(+) diff --git a/libavutil/wchar_filename.h b/libavutil/wchar_filename.h index 9

[FFmpeg-devel] [PATCH v11 4/6] fftools/cmdutils.c: Remove MAX_PATH limit

2022-04-23 Thread Nil Admirari
--- fftools/cmdutils.c | 31 +-- 1 file changed, 25 insertions(+), 6 deletions(-) diff --git a/fftools/cmdutils.c b/fftools/cmdutils.c index 5d7cdc3e..d42bb04e 100644 --- a/fftools/cmdutils.c +++ b/fftools/cmdutils.c @@ -50,6 +50,7 @@ #include "opt_common.h" #ifdef _

[FFmpeg-devel] [PATCH v11 2/6] libavformat/avisynth.c: Remove MAX_PATH limit

2022-04-23 Thread Nil Admirari
--- libavformat/avisynth.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/libavformat/avisynth.c b/libavformat/avisynth.c index 8ba2bdea..f7bea8c3 100644 --- a/libavformat/avisynth.c +++ b/libavformat/avisynth.c @@ -34,6 +34,7 @@ /* Platform-specific directives.

Re: [FFmpeg-devel] [PATCH] libavcodec/videotoolboxenc.c: add option to hevc encoder to prioritize speed.

2022-04-23 Thread Simone Karin Lehmann
> Am 23.04.2022 um 21:56 schrieb Thilo Borgmann : > > Am 23.04.22 um 17:42 schrieb Simone Karin Lehmann: >>> Am 23.04.2022 um 17:07 schrieb Thilo Borgmann : >>> >>> >>> If that works I'd be happy. Does not apply for me anymore (on HEAD), though? >>> >>> >> hhmm, the patch applies for me on c

Re: [FFmpeg-devel] [PATCH] libavfilter/version: bump minor version for icc{gen, detect}

2022-04-23 Thread Niklas Haas
LGTM On Sat, 23 Apr 2022 23:10:51 +0300 Jan Ekström wrote: > Missed during that patch set's life time. > --- > libavfilter/version.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavfilter/version.h b/libavfilter/version.h > index 547b3b4e7d..9add1658e5 100644 > ---

[FFmpeg-devel] [PATCH] libavfilter/version: bump minor version for icc{gen, detect}

2022-04-23 Thread Jan Ekström
Missed during that patch set's life time. --- libavfilter/version.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/version.h b/libavfilter/version.h index 547b3b4e7d..9add1658e5 100644 --- a/libavfilter/version.h +++ b/libavfilter/version.h @@ -31,7 +31,7 @@ #in

[FFmpeg-devel] [PATCH v10 4/6] fftools/cmdutils.c: Remove MAX_PATH limit

2022-04-23 Thread Nil Admirari
--- fftools/cmdutils.c | 32 ++-- 1 file changed, 26 insertions(+), 6 deletions(-) diff --git a/fftools/cmdutils.c b/fftools/cmdutils.c index 5d7cdc3e..af070c19 100644 --- a/fftools/cmdutils.c +++ b/fftools/cmdutils.c @@ -37,6 +37,7 @@ #include "libswresample/swresamp

[FFmpeg-devel] [PATCH v10 6/6] fftools: Set active code page to UTF-8 on Windows

2022-04-23 Thread Nil Admirari
Starting with Windows 1903 applications can set active code page to UTF-8 with the application manifest. It improves path name compatibility with dependencies that use char* pathnames internally, but whose code page has already been changed to UTF-8 via a manifest (e.g. AviSynth). On older version

[FFmpeg-devel] [PATCH v10 3/6] compat/w32dlfcn.h: Remove MAX_PATH limit and replace LoadLibraryExA with LoadLibraryExW

2022-04-23 Thread Nil Admirari
--- compat/w32dlfcn.h | 78 ++- 1 file changed, 64 insertions(+), 14 deletions(-) diff --git a/compat/w32dlfcn.h b/compat/w32dlfcn.h index 52a94efa..2284ac7a 100644 --- a/compat/w32dlfcn.h +++ b/compat/w32dlfcn.h @@ -25,6 +25,30 @@ #if (_WIN32_WINNT <

[FFmpeg-devel] [PATCH v10 2/6] libavformat/avisynth.c: Remove MAX_PATH limit

2022-04-23 Thread Nil Admirari
--- libavformat/avisynth.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/libavformat/avisynth.c b/libavformat/avisynth.c index 8ba2bdea..f7bea8c3 100644 --- a/libavformat/avisynth.c +++ b/libavformat/avisynth.c @@ -34,6 +34,7 @@ /* Platform-specific directives.

[FFmpeg-devel] [PATCH v10 5/6] fftools: Enable long path support on Windows (fixes #8885)

2022-04-23 Thread Nil Admirari
Newer versions of Windows (Windows 10 1607 and newer) can support path names longer than MAX_PATH (260 characters). To take advantage of that, an application needs to opt in, by including a small manifest as a resource. Application must be prepared to handle filenames greater than MAX_PATH. Additi

[FFmpeg-devel] [PATCH v10 1/6] libavutil/wchar_filename.h: Add whcartoutf8, wchartoansi and utf8toansi

2022-04-23 Thread Nil Admirari
These functions are going to be used in libavformat/avisynth.c and fftools/cmdutils.c remove MAX_PATH limit. --- libavutil/wchar_filename.h | 52 ++ 1 file changed, 52 insertions(+) diff --git a/libavutil/wchar_filename.h b/libavutil/wchar_filename.h index 90f0

Re: [FFmpeg-devel] [PATCH] libavcodec/videotoolboxenc.c: add option to hevc encoder to prioritize speed.

2022-04-23 Thread Thilo Borgmann
Am 23.04.22 um 17:42 schrieb Simone Karin Lehmann: Am 23.04.2022 um 17:07 schrieb Thilo Borgmann : If that works I'd be happy. Does not apply for me anymore (on HEAD), though? hhmm, the patch applies for me on current HEAD. I’ve tested it a few moments ago on a fresh downloaded git snap

Re: [FFmpeg-devel] [PATCH v2 1/5] lavfi: generalize colorspace coefficent helpers

2022-04-23 Thread Niklas Haas
Merged in 2cb0cebd11eb90dfcccac5c258af1003bd4f17d2 On Tue, 19 Apr 2022 14:48:06 +0200 Niklas Haas wrote: > Merging this series at the end of the week if I don't get any additional > feedback. > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org >

Re: [FFmpeg-devel] [PATCH 0/2] Jpeg XL version.h bump

2022-04-23 Thread Jan Ekström
On Sat, Apr 23, 2022 at 10:39 PM Leo Izen wrote: > > I missed the version.h bump when rebasing the Jpeg XL > patchset onto master. This should properly bump the minor > library versions. > > Leo Izen (2): > avcodec/version.h: bump version for Jpeg XL > avformat/version.h: bump version for Jpeg

[FFmpeg-devel] [PATCH 2/2] avformat/version.h: bump version for Jpeg XL

2022-04-23 Thread Leo Izen
The version.h bump got missed with the Jpeg XL patchset. This should bump the minor version in accordance with the contributing guidelines. --- libavformat/version.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/version.h b/libavformat/version.h index d8fc959f19..

[FFmpeg-devel] [PATCH 1/2] avcodec/version.h: bump version for Jpeg XL

2022-04-23 Thread Leo Izen
The version.h bump got missed with the Jpeg XL patchset. This should bump the minor version in accordance with the contributing guidelines. --- libavcodec/version.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/version.h b/libavcodec/version.h index 26ee41eb1f..735

[FFmpeg-devel] [PATCH 0/2] Jpeg XL version.h bump

2022-04-23 Thread Leo Izen
I missed the version.h bump when rebasing the Jpeg XL patchset onto master. This should properly bump the minor library versions. Leo Izen (2): avcodec/version.h: bump version for Jpeg XL avformat/version.h: bump version for Jpeg XL libavcodec/version.h | 2 +- libavformat/version.h | 2 +-

Re: [FFmpeg-devel] FFmpeg 5.0 LTS vs 5.1 LTS

2022-04-23 Thread Neal Gompa
On Sat, Apr 23, 2022 at 2:15 PM James Almer wrote: > > > > On 4/23/2022 3:08 PM, Neal Gompa wrote: > > On Sat, Apr 23, 2022 at 12:40 PM James Almer wrote: > >> > >> On 4/23/2022 1:36 PM, Michael Niedermayer wrote: > >>> Hi all > >>> > >>> Do people prefer that 5.0 becomes LTS or the next (5.1) ?

Re: [FFmpeg-devel] FFmpeg 5.0 LTS vs 5.1 LTS

2022-04-23 Thread James Almer
On 4/23/2022 3:08 PM, Neal Gompa wrote: On Sat, Apr 23, 2022 at 12:40 PM James Almer wrote: On 4/23/2022 1:36 PM, Michael Niedermayer wrote: Hi all Do people prefer that 5.0 becomes LTS or the next (5.1) ? Or something else ? Thanks 5.0 lacks the new channel layout API, and making that

Re: [FFmpeg-devel] FFmpeg 5.0 LTS vs 5.1 LTS

2022-04-23 Thread Neal Gompa
On Sat, Apr 23, 2022 at 12:40 PM James Almer wrote: > > On 4/23/2022 1:36 PM, Michael Niedermayer wrote: > > Hi all > > > > Do people prefer that 5.0 becomes LTS or the next (5.1) ? > > Or something else ? > > > > Thanks > > 5.0 lacks the new channel layout API, and making that an LTS will give >

Re: [FFmpeg-devel] [PATCH v15 4/4] avformat/image2: add Jpeg XL as image2 format

2022-04-23 Thread Lynne
17 Apr 2022, 15:22 by leo.i...@gmail.com: > This commit adds support to libavformat for muxing > and demuxing Jpeg XL images as image2 streams. > --- > MAINTAINERS| 1 + > libavformat/Makefile | 1 + > libavformat/allformats.c | 1 + > libavformat/img2.c |

Re: [FFmpeg-devel] FFmpeg 5.0 LTS vs 5.1 LTS

2022-04-23 Thread James Almer
On 4/23/2022 1:36 PM, Michael Niedermayer wrote: Hi all Do people prefer that 5.0 becomes LTS or the next (5.1) ? Or something else ? Thanks 5.0 lacks the new channel layout API, and making that an LTS will give projects less incentive to migrate, so IMO, 5.1 (or a newer one) should be the

[FFmpeg-devel] FFmpeg 5.0 LTS vs 5.1 LTS

2022-04-23 Thread Michael Niedermayer
Hi all Do people prefer that 5.0 becomes LTS or the next (5.1) ? Or something else ? Thanks -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Nations do behave wisely once they have exhausted all other alternatives. -- Abba Eban signature.asc Description: PGP signat

Re: [FFmpeg-devel] [PATCH] libavcodec/videotoolboxenc.c: add option to hevc encoder to prioritize speed.

2022-04-23 Thread Simone Karin Lehmann
> Am 23.04.2022 um 17:07 schrieb Thilo Borgmann : > > > If that works I'd be happy. Does not apply for me anymore (on HEAD), though? > > hhmm, the patch applies for me on current HEAD. I’ve tested it a few moments ago on a fresh downloaded git snapshot. Maybe a former patch from me still t

Re: [FFmpeg-devel] [PATCH] libavcodec/videotoolboxenc.c: add option to hevc encoder to prioritize speed.

2022-04-23 Thread Thilo Borgmann
Am 23.04.22 um 14:31 schrieb Simone Karin Lehmann: Am 22.04.2022 um 18:52 schrieb Thilo Borgmann : For that version I get: libavcodec/videotoolboxenc.c:1153:39: error: use of undeclared identifier 'kVTCompressionPropertyKey_PrioritizeEncodingSpeedOverQuality'

Re: [FFmpeg-devel] [PATCH 2/2] lavfi: Add blurriness filter

2022-04-23 Thread Thilo Borgmann
Hi, v3 updated to current HEAD. Named blurdetect filter now. Minor fixes on allocation and removed -f option. Please make this per plane filtering, with default to measure only first plane. done in v4. (Will add Changelog, version.h and fate test once the filter itself looks ok) Ping.

Re: [FFmpeg-devel] [PATCH] libavcodec/videotoolboxenc.c: add option to hevc encoder to prioritize speed.

2022-04-23 Thread Simone Karin Lehmann
> Am 22.04.2022 um 18:52 schrieb Thilo Borgmann : > > > For that version I get: > > libavcodec/videotoolboxenc.c:1153:39: error: use of undeclared identifier > 'kVTCompressionPropertyKey_PrioritizeEncodingSpeedOverQuality' > > kVTCompressionPropertyKey_P

Re: [FFmpeg-devel] [PATCH] libavformat/mov.c: Added configuration flag to skip cover art atom while opening mov parser

2022-04-23 Thread Hendrik Leppkes
On Fri, Apr 22, 2022 at 4:30 PM Malviya, Janpriya wrote: > > Hi Derek, > > We require to add this configuration for the following reasons : > - We have our own pipeline mechanism to download & fetch audio data from > source. > - We are using ffmpeg with custom IO callbacks for parsing & decoding

Re: [FFmpeg-devel] [PATCH] avformat/mov: Add support for still image AVIF parsing

2022-04-23 Thread Gyan Doshi
Removed some trailing whitespace, edited commit msg and pushed as 499e245b856733c3bbcd3ba23b406729343ed5fe Consider adding avif to extensions in the AVInputFormat Regards, Gyan On 2022-04-23 12:29 am, Vignesh Venkatasubramanian wrote: Add support for parsing AVIF still images. This patches su