[FFmpeg-devel] [PATCH] avformat/mov: Add support for still image AVIF parsing

2022-04-22 Thread Vignesh Venkatasubramanian
Add support for parsing AVIF still images. This patches supports AVIF still images that have exactly 1 item (i.e.) no alpha channel. Essentially, we will have to parse the "iloc" box and populate the mov index. With this patch, we can decode still AVIF images like so: ffmpeg -i image.avif image.pn

Re: [FFmpeg-devel] [PATCH] avformat/mov: Add support for still image AVIF parsing

2022-04-22 Thread Vignesh Venkatasubramanian
On Thu, Apr 21, 2022 at 9:18 PM Gyan Doshi wrote: > > > > On 2022-04-21 09:46 pm, Vignesh Venkatasubramanian wrote: > > On Thu, Apr 21, 2022 at 2:08 AM Gyan Doshi wrote: > >> > >> > >> On 2022-04-20 09:54 am, Gyan Doshi wrote: > >>> > >>> On 2022-04-20 02:49 am, Paul B Mahol wrote: > On Tue,

Re: [FFmpeg-devel] [PATCH] avfilter/vsrc_mandelbrot: Check for malloc failure

2022-04-22 Thread Michael Niedermayer
On Fri, Apr 22, 2022 at 11:52:36AM +0200, Paul B Mahol wrote: > LGTM will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Opposition brings concord. Out of discord comes the fairest harmony. -- Heraclitus signature.asc Description: PGP signature ___

Re: [FFmpeg-devel] [PATCH v2 3/5] libswscale: Avx2 hscale can process inputs of any size.

2022-04-22 Thread Michael Niedermayer
On Thu, Feb 17, 2022 at 11:04:04AM +0100, Alan Kelly wrote: > The main loop processes blocks of 16 pixels. The tail processes blocks > of size 4. > --- > libswscale/x86/scale_avx2.asm | 48 +-- > 1 file changed, 46 insertions(+), 2 deletions(-) > > diff --git a/lib

Re: [FFmpeg-devel] [PATCH] libavcodec/videotoolboxenc.c: add option to hevc encoder to prioritize speed.

2022-04-22 Thread Thilo Borgmann
Am 22.04.22 um 18:24 schrieb Andreas Rheinhardt: Simone Karin Lehmann: Am 14.04.2022 um 10:13 schrieb Thilo Borgmann : Hi, diff --git a/libavcodec/videotoolboxenc.c b/libavcodec/videotoolboxenc.c index 418ff00b8d..ab0dad6cbc 100644 --- a/libavcodec/videotoolboxenc.c +++ b/libavcodec/videot

Re: [FFmpeg-devel] [PATCH] libavcodec/videotoolboxenc.c: add option to hevc encoder to prioritize speed.

2022-04-22 Thread Andreas Rheinhardt
Simone Karin Lehmann: > > >> Am 14.04.2022 um 10:13 schrieb Thilo Borgmann : >> >> Hi, >> diff --git a/libavcodec/videotoolboxenc.c b/libavcodec/videotoolboxenc.c index 418ff00b8d..ab0dad6cbc 100644 --- a/libavcodec/videotoolboxenc.c +++ b/libavcodec/videotoolboxenc.c @@

Re: [FFmpeg-devel] proposal for a minor change in the behavior of the drawtext filter

2022-04-22 Thread Michael Koch
Hi Francesco, I think the y position of the baseline should be independent of the content of the textfile. For example, you might want to change the color in the middle of a text. That can only be done by invoking drawtext two times. To make sure that both texts share the same baseline, the wo

Re: [FFmpeg-devel] proposal for a minor change in the behavior of the drawtext filter

2022-04-22 Thread Francesco Carusi
Hi Michael, you're right, the default y position is not referred to the baseline but to the upper left corner of the text. I initially referred it to the baseline but that is not the default used by the current drawtext filter, so I thought it would be better to keep compatibility with the cu

Re: [FFmpeg-devel] [PATCH v2 3/5] libswscale: Avx2 hscale can process inputs of any size.

2022-04-22 Thread Paul B Mahol
On Fri, Apr 22, 2022 at 10:03 AM Alan Kelly < alankelly-at-google@ffmpeg.org> wrote: > Hi, > > Is anyone interested in this patch? This makes AVX2 hscale work on all > input sizes. > > I can apply this if you confirm it works with any image size and on unaligned data. > Thanks, > > Alan > >

[FFmpeg-devel] [PATCH] Fix wrong BTI landing pad

2022-04-22 Thread Andre Kempe
This patch fixes a wrong type of BTI landing pad when branching to functions instantiated via the fft*_neon macro. Although the previously employed paciasp instruction serves as a landing pad, for the ways that this function is invoked it is the wrong type. Signed-off-by: André Kempe --- libavc

Re: [FFmpeg-devel] proposal for a minor change in the behavior of the drawtext filter

2022-04-22 Thread Michael Koch
Hi Francesco, in my opinion the line spacing looks good. But there is still the problem that the y position of the baseline depends on the height of the characters in the first line. You see that when you switch between your pictures line_height_net_arial.png  and line_height_new_arial2.png. I

Re: [FFmpeg-devel] proposal for a minor change in the behavior of the drawtext filter

2022-04-22 Thread Francesco Carusi
On 22/04/2022 12:30, Michael Niedermayer wrote: On Fri, Apr 22, 2022 at 12:01:31PM +0200, Francesco Carusi wrote: Hello ffmpeg team, I'm working on an enhanced version of the drawtext filter and would like to discuss with you about a minor change in its behavior related to line spacing managem

Re: [FFmpeg-devel] proposal for a minor change in the behavior of the drawtext filter

2022-04-22 Thread Michael Niedermayer
On Fri, Apr 22, 2022 at 12:01:31PM +0200, Francesco Carusi wrote: > Hello ffmpeg team, > > I'm working on an enhanced version of the drawtext filter and would like to > discuss with you about a minor change in its behavior related to line > spacing management. > In the current implementation the s

[FFmpeg-devel] proposal for a minor change in the behavior of the drawtext filter

2022-04-22 Thread Francesco Carusi
Hello ffmpeg team, I'm working on an enhanced version of the drawtext filter and would like to discuss with you about a minor change in its behavior related to line spacing management. In the current implementation the space between two lines of text is set equal to the height of the highest g

Re: [FFmpeg-devel] [PATCH] avfilter/vsrc_mandelbrot: Check for malloc failure

2022-04-22 Thread Paul B Mahol
LGTM ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH v2 4/5] libswscale: Enable hscale_avx2 for all input sizes.

2022-04-22 Thread Alan Kelly
Ping! On Thu, Feb 17, 2022 at 11:04 AM Alan Kelly wrote: > ff_shuffle_filter_coefficients shuffles the tail as required. > --- > libswscale/utils.c | 19 --- > libswscale/x86/swscale.c | 6 ++ > 2 files changed, 18 insertions(+), 7 deletions(-) > > diff --git a/libsws

Re: [FFmpeg-devel] [PATCH v2 3/5] libswscale: Avx2 hscale can process inputs of any size.

2022-04-22 Thread Alan Kelly
Hi, Is anyone interested in this patch? This makes AVX2 hscale work on all input sizes. Thanks, Alan On Mon, Mar 7, 2022 at 4:27 PM Alan Kelly wrote: > Hi Michael, > > Thanks for reviewing the first two parts of this patchset. > > Is there anybody interested in reviewing this part? > > Thanks

Re: [FFmpeg-devel] [PATCH] swscale: aarch64: Optimize the final summation in the hscale routine

2022-04-22 Thread Martin Storsjö
On Thu, 21 Apr 2022, Swinney, Jonathan wrote: Thanks for making this improvement. I will rebase my patches on your change. I also measured the performance on AWS Graviton 2 and 3. I added the numbers to your table. Before: Cortex A53 A72 A73 Graviton 2 Graviton