[FFmpeg-devel] [PATCH v2 3/3] libavcodec/qsvdec: using suggested num to set init_pool_size

2022-03-17 Thread Wenbin Chen
The init_pool_size is set to be 64 and it is too many. Use IOSurfQuery to get NumFrameSuggest which is the suggested number of frame that needed to be allocated when initializing the decoder. Considering that the hevc_qsv encoder uses the most frame buffer, async is 4 (default) and max_b_frames is

[FFmpeg-devel] [PATCH v2 2/3] libavcodec/qsvdec: remove redundant decodeHeader()

2022-03-17 Thread Wenbin Chen
Since ffmpeg-qsv uses return value to reinit decoder, it doesn't need to decode header each time. Move qsv_decode_header's position so that it will be called only if codec needed to be reinitialized. Rearrange the code of flushing decoder and re-init decoder operation. Remove the buffer_count and u

[FFmpeg-devel] [PATCH v2 1/3] libavcodec/qsvdec: reinit decoder according to decode() return value

2022-03-17 Thread Wenbin Chen
FFmpeg-qsv decoder reinit codec when width and height change, but there are not only resolution change need to reinit codec. I change it to use return value from DecodeFrameAsync() to decide whether decoder need to be reinitialized. Signed-off-by: Wenbin Chen Signed-off-by: Guangxin Xu --- liba

Re: [FFmpeg-devel] [PATCH v2 2/2] avformat/movenc: sidx earliest_presentation_time is applied after editlist

2022-03-17 Thread zhilizhao(赵志立)
Ping for review. The following is copied from ISO-14496-12 as reference: > earliest_presentation_time is the earliest presentation time of any content > in the reference > stream in the first subsegment, in the timescale indicated in the timescale > field; the earliest > presentation time is der

[FFmpeg-devel] [PATCH] avcodec/setts_bsf: fix memleak

2022-03-17 Thread Zhao Zhili
--- libavcodec/setts_bsf.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavcodec/setts_bsf.c b/libavcodec/setts_bsf.c index 3c666b5061..fadf63bc54 100644 --- a/libavcodec/setts_bsf.c +++ b/libavcodec/setts_bsf.c @@ -244,6 +244,8 @@ static void setts_close(AVBSFContext *bsf) s->pts_

[FFmpeg-devel] [PATCH] avcodec/dfa: don't check for the bitstream version on every copied line

2022-03-17 Thread James Almer
And use av_image_copy_plane() while at it to simplify things for version != 0x100. Signed-off-by: James Almer --- libavcodec/dfa.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/libavcodec/dfa.c b/libavcodec/dfa.c index ab78d66763..c29eb76de5 100644 --- a/liba

[FFmpeg-devel] [PATCH] avcodec/opus: always use ambisonic layout for mapping family 2

2022-03-17 Thread James Almer
No need to use a Custom layout when the non diegetic channels can be described as a standard mask. Signed-off-by: James Almer --- libavcodec/opus.c | 17 +++-- 1 file changed, 3 insertions(+), 14 deletions(-) diff --git a/libavcodec/opus.c b/libavcodec/opus.c index 7eccc17e80..35402

[FFmpeg-devel] [PATCH] avcodec/wmaprodec: ensure channel count in the private context and decoder context are consistent

2022-03-17 Thread James Almer
avctx->ch_layout will be reinitialized using channel_mask later in the function. Signed-off-by: James Almer --- libavcodec/wmaprodec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/wmaprodec.c b/libavcodec/wmaprodec.c index 5c1d38eca5..6a8b895c1b 100644 --- a/lib

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/wmalosslessdec: Check channel mask against num channels

2022-03-17 Thread James Almer
On 3/17/2022 9:07 PM, James Almer wrote: On 3/17/2022 8:52 PM, James Almer wrote: On 3/17/2022 8:30 PM, Michael Niedermayer wrote: Fixes: Out of array write Fixes: 45613/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WMALOSSLESS_fuzzer-4539073606320128 Found-by: continuous fuzzing p

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/wmalosslessdec: Check channel mask against num channels

2022-03-17 Thread James Almer
On 3/17/2022 8:52 PM, James Almer wrote: On 3/17/2022 8:30 PM, Michael Niedermayer wrote: Fixes: Out of array write Fixes: 45613/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WMALOSSLESS_fuzzer-4539073606320128 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/t

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/wmalosslessdec: Check channel mask against num channels

2022-03-17 Thread James Almer
On 3/17/2022 8:30 PM, Michael Niedermayer wrote: Fixes: Out of array write Fixes: 45613/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WMALOSSLESS_fuzzer-4539073606320128 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Micha

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/alsdec: Set channels from data after data is set

2022-03-17 Thread James Almer
On 3/17/2022 8:30 PM, Michael Niedermayer wrote: Fixes: out of array write Fixes: 45624/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ALS_fuzzer-6473487382872064 Fixes: 45626/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ALS_fuzzer-4874997192065024 Found-by: continuous fuzzing process

[FFmpeg-devel] [PATCH 1/3] avcodec/dfpwmdec: Check packet size more completely

2022-03-17 Thread Michael Niedermayer
Fixes: out of array access Fixes: 45497/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_DFPWM_fuzzer-5239786212818944.fuzz Fixes: 45510/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_DFPWM_fuzzer-4947856883056640 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/

[FFmpeg-devel] [PATCH 3/3] avcodec/alsdec: Set channels from data after data is set

2022-03-17 Thread Michael Niedermayer
Fixes: out of array write Fixes: 45624/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ALS_fuzzer-6473487382872064 Fixes: 45626/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ALS_fuzzer-4874997192065024 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/pro

[FFmpeg-devel] [PATCH 2/3] avcodec/wmalosslessdec: Check channel mask against num channels

2022-03-17 Thread Michael Niedermayer
Fixes: Out of array write Fixes: 45613/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WMALOSSLESS_fuzzer-4539073606320128 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/wmalosslessdec.c |

Re: [FFmpeg-devel] [PATCH 3/3] gitignore: add config_components.h

2022-03-17 Thread James Almer
On 3/17/2022 6:33 PM, Martin Storsjö wrote: On Thu, 17 Mar 2022, James Almer wrote: Signed-off-by: James Almer --- .gitignore | 1 + 1 file changed, 1 insertion(+) All three LGTM - thanks, and sorry for missing these! // Martin Applied. ___ ffm

Re: [FFmpeg-devel] [PATCH 3/3] gitignore: add config_components.h

2022-03-17 Thread Martin Storsjö
On Thu, 17 Mar 2022, James Almer wrote: Signed-off-by: James Almer --- .gitignore | 1 + 1 file changed, 1 insertion(+) All three LGTM - thanks, and sorry for missing these! // Martin ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ff

[FFmpeg-devel] [PATCH 3/3] gitignore: add config_components.h

2022-03-17 Thread James Almer
Signed-off-by: James Almer --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index f06d853edf..e810d11107 100644 --- a/.gitignore +++ b/.gitignore @@ -35,6 +35,7 @@ /ffprobe /config.asm /config.h +/config_components.h /coverage.info /lcov/ /src -- 2

[FFmpeg-devel] [PATCH 2/3] Makefile: check config_components.h when comparing timestamps in component list files

2022-03-17 Thread James Almer
Signed-off-by: James Almer --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 13fa7a409c..f6eb4f591d 100644 --- a/Makefile +++ b/Makefile @@ -79,7 +79,7 @@ CONFIGURABLE_COMPONENTS = \ $(SRC_PAT

[FFmpeg-devel] [PATCH 1/3] Makefile: delete config_components.h on distclean

2022-03-17 Thread James Almer
Signed-off-by: James Almer --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 1c38c522fb..13fa7a409c 100644 --- a/Makefile +++ b/Makefile @@ -159,7 +159,7 @@ clean:: $(RM) -rf coverage.info coverage.info.in lcov distclean:: clean

Re: [FFmpeg-devel] [PATCH 001/293 v8] avutil/channel_layout: Add a new channel layout API

2022-03-17 Thread James Almer
On 3/17/2022 4:46 PM, James Almer wrote: On 3/17/2022 4:39 PM, Michael Niedermayer wrote: On Tue, Mar 15, 2022 at 11:00:02PM -0300, James Almer wrote: On 3/15/2022 9:41 PM, Michael Niedermayer wrote: On Mon, Jan 24, 2022 at 05:46:56PM -0300, James Almer wrote: From: Anton Khirnov The ne

Re: [FFmpeg-devel] [PATCH 001/293 v8] avutil/channel_layout: Add a new channel layout API

2022-03-17 Thread James Almer
On 3/17/2022 4:39 PM, Michael Niedermayer wrote: On Tue, Mar 15, 2022 at 11:00:02PM -0300, James Almer wrote: On 3/15/2022 9:41 PM, Michael Niedermayer wrote: On Mon, Jan 24, 2022 at 05:46:56PM -0300, James Almer wrote: From: Anton Khirnov The new API is more extensible and allows for cus

Re: [FFmpeg-devel] [PATCH 001/293 v8] avutil/channel_layout: Add a new channel layout API

2022-03-17 Thread Michael Niedermayer
On Tue, Mar 15, 2022 at 11:00:02PM -0300, James Almer wrote: > On 3/15/2022 9:41 PM, Michael Niedermayer wrote: > > On Mon, Jan 24, 2022 at 05:46:56PM -0300, James Almer wrote: > > > From: Anton Khirnov > > > > > > The new API is more extensible and allows for custom layouts. > > > More accurate

Re: [FFmpeg-devel] [PATCH 1/2] tools/target_dec_fuzzer: Adjust threshold for TQI

2022-03-17 Thread Michael Niedermayer
On Sat, Feb 12, 2022 at 10:13:49PM +0100, Michael Niedermayer wrote: > Fixes: Timeout > Fixes: > 44455/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_EATQI_fuzzer-6069950551293952 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signe

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/speexdec: Align some comments

2022-03-17 Thread Michael Niedermayer
On Tue, Feb 15, 2022 at 10:52:28PM +0100, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavcodec/speexdec.c | 40 > 1 file changed, 20 insertions(+), 20 deletions(-) will apply [...] -- Michael GnuPG fingerprint: 9FF2128B

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/speexdec: Use correct doxygen comments

2022-03-17 Thread Michael Niedermayer
On Tue, Feb 15, 2022 at 10:52:27PM +0100, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavcodec/speexdec.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) will apply [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Re: [FFmpeg-devel] [PATCH] tools/target_dec_fuzzer: Adjust threshold for DSICINVIDEO

2022-03-17 Thread Michael Niedermayer
On Wed, Feb 23, 2022 at 01:40:39AM +0100, Michael Niedermayer wrote: > Fixes: Timeout > Fixes: > 44829/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_DSICINVIDEO_fuzzer-6190334340628480 > > Signed-off-by: Michael Niedermayer > --- > tools/target_dec_fuzzer.c | 1 + > 1 file changed, 1 insert

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/dfa: Optimize output reshuffle loop

2022-03-17 Thread Michael Niedermayer
On Fri, Mar 11, 2022 at 09:20:25PM +0100, Michael Niedermayer wrote: > 18035 -> 4018 dezicycles (Tested with LOGOS.DFA, gcc 7, 3950X) > > Signed-off-by: Michael Niedermayer > --- > libavcodec/dfa.c | 14 +++--- > 1 file changed, 11 insertions(+), 3 deletions(-) will apply [...] -- Mic

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/mjpegbdec: Set buf_size

2022-03-17 Thread Michael Niedermayer
On Fri, Mar 11, 2022 at 09:20:23PM +0100, Michael Niedermayer wrote: > Fixes: Timeout > Fixes: > 45170/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MJPEGB_fuzzer-5874820431085568 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Sign

Re: [FFmpeg-devel] [PATCH] avformat/matroskadec: Use rounded down duration in get_cue_desc() check

2022-03-17 Thread Michael Niedermayer
On Fri, Mar 11, 2022 at 12:47:47AM +0100, Michael Niedermayer wrote: > Floating point is evil, it would be better if duration was not a double > > Fixes: Infinite loop > Fixes: > 45123/clusterfuzz-testcase-minimized-ffmpeg_dem_WEBM_DASH_MANIFEST_fuzzer-6725052291219456 > > Found-by: continuous f

[FFmpeg-devel] [PATCH] avcodec/libvpxenc: enable dynamic max quantizer parameter reconfiguration

2022-03-17 Thread Danil Chapovalov
--- libavcodec/libvpxenc.c | 9 + 1 file changed, 9 insertions(+) diff --git a/libavcodec/libvpxenc.c b/libavcodec/libvpxenc.c index 8f94ba15dc..4735e57620 100644 --- a/libavcodec/libvpxenc.c +++ b/libavcodec/libvpxenc.c @@ -44,6 +44,7 @@ #include "libavutil/mathematics.h" #include "lib

[FFmpeg-devel] [PATCH 5/6] avcodec/blockdsp: Arm 64-bit NEON block clear fast paths

2022-03-17 Thread Ben Avison
Signed-off-by: Ben Avison --- libavcodec/aarch64/Makefile| 2 + libavcodec/aarch64/blockdsp_init_aarch64.c | 42 + libavcodec/aarch64/blockdsp_neon.S | 43 ++ libavcodec/blockdsp.c | 2 + libavcodec/blockdsp.h

[FFmpeg-devel] [PATCH 6/6] avcodec/vc1: Introduce fast path for unescaping bitstream buffer

2022-03-17 Thread Ben Avison
Populate with implementations suitable for 32-bit and 64-bit Arm. Signed-off-by: Ben Avison --- libavcodec/aarch64/vc1dsp_init_aarch64.c | 60 libavcodec/aarch64/vc1dsp_neon.S | 176 +++ libavcodec/arm/vc1dsp_init_neon.c| 60 libavcodec/arm

[FFmpeg-devel] [PATCH 4/6] avcodec/idctdsp: Arm 64-bit NEON block add and clamp fast paths

2022-03-17 Thread Ben Avison
Signed-off-by: Ben Avison --- libavcodec/aarch64/Makefile | 3 +- libavcodec/aarch64/idctdsp_init_aarch64.c | 26 +++-- libavcodec/aarch64/idctdsp_neon.S | 130 ++ 3 files changed, 150 insertions(+), 9 deletions(-) create mode 100644 libavcodec/aarch6

[FFmpeg-devel] [PATCH 3/6] avcodec/vc1: Arm 64-bit NEON inverse transform fast paths

2022-03-17 Thread Ben Avison
Signed-off-by: Ben Avison --- libavcodec/aarch64/vc1dsp_init_aarch64.c | 19 + libavcodec/aarch64/vc1dsp_neon.S | 678 +++ 2 files changed, 697 insertions(+) diff --git a/libavcodec/aarch64/vc1dsp_init_aarch64.c b/libavcodec/aarch64/vc1dsp_init_aarch64.c index edfb2

[FFmpeg-devel] [PATCH 2/6] avcodec/vc1: Arm 32-bit NEON deblocking filter fast paths

2022-03-17 Thread Ben Avison
Signed-off-by: Ben Avison --- libavcodec/arm/vc1dsp_init_neon.c | 14 + libavcodec/arm/vc1dsp_neon.S | 643 ++ 2 files changed, 657 insertions(+) diff --git a/libavcodec/arm/vc1dsp_init_neon.c b/libavcodec/arm/vc1dsp_init_neon.c index 2cca784f5a..f5f5c702d7 100

[FFmpeg-devel] [PATCH 1/6] avcodec/vc1: Arm 64-bit NEON deblocking filter fast paths

2022-03-17 Thread Ben Avison
Signed-off-by: Ben Avison --- libavcodec/aarch64/Makefile | 1 + libavcodec/aarch64/vc1dsp_init_aarch64.c | 14 + libavcodec/aarch64/vc1dsp_neon.S | 698 +++ 3 files changed, 713 insertions(+) create mode 100644 libavcodec/aarch64/vc1dsp_neon.S diff -

[FFmpeg-devel] [PATCH 0/6] avcodec/vc1: Arm optimisations

2022-03-17 Thread Ben Avison
The VC1 decoder was missing lots of important fast paths for Arm, especially for 64-bit Arm. This submission fills in implementations for all functions where a fast path already existed and the fallback C implementation was taking 1% or more of the runtime, and adds a new fast path to permit vc1_un

Re: [FFmpeg-devel] [PATCH] avcodec/libvpxenc: enable dynamic max quantizer parameter reconfiguration

2022-03-17 Thread Jan Ekström
On Thu, Mar 17, 2022 at 1:53 AM James Zern wrote: > > Lynne, > > > On Wed, Mar 16, 2022 at 5:39 AM Lynne wrote: > > > > 16 Mar 2022, 13:07 by danilchap-at-google@ffmpeg.org: > > > > > --- > > > libavcodec/libvpxenc.c | 7 +++ > > > 1 file changed, 7 insertions(+) > > > > > > diff --git a

[FFmpeg-devel] ffprobe closed_captions json output not set while text output is set

2022-03-17 Thread Pieter Viljoen
Please reconsider an abandoned patch to allow consistent behavior in closed caption detection between ffprobe with and without "-print_format json". https://patchwork.ffmpeg.org/project/ffmpeg/patch/mn2pr04mb59815313285aa685e37d09aeba...@mn2pr04mb5981.namprd04.prod.outlook.com/ I also asked for so

Re: [FFmpeg-devel] [PATCH] fate: add a setts bsf test

2022-03-17 Thread Paul B Mahol
probably fine ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avcodec/setts_bsf: don't repeatedly set start pts and dts

2022-03-17 Thread Paul B Mahol
lgtm ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH v3 9/9] configure: Use a separate config_components.h header for $ALL_COMPONENTS

2022-03-17 Thread Michael Niedermayer
On Fri, Mar 11, 2022 at 03:53:24PM +0200, Martin Storsjö wrote: > This avoids unnecessary rebuilds of most source files if only the > list of enabled components has changed, but not the other properties > of the build, set in config.h. > --- > Patchwork notified me that the previous round failed bu

Re: [FFmpeg-devel] [PATCH 06/10] fftools/ffmpeg: drop mistakenly added empty line

2022-03-17 Thread Andreas Rheinhardt
Anton Khirnov: > --- > fftools/ffmpeg_opt.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/fftools/ffmpeg_opt.c b/fftools/ffmpeg_opt.c > index 778e02c39e..5f08cab908 100644 > --- a/fftools/ffmpeg_opt.c > +++ b/fftools/ffmpeg_opt.c > @@ -1,4 +1,3 @@ > - > /* > * ffmpeg option parsing >

Re: [FFmpeg-devel] [PATCH 05/10] fftools: move opt_timelimit from cmdutils to ffmpeg

2022-03-17 Thread Andreas Rheinhardt
Anton Khirnov: > This option is only supported by ffmpeg. > --- > fftools/cmdutils.c | 17 - > fftools/ffmpeg_opt.c | 20 > 2 files changed, 20 insertions(+), 17 deletions(-) > > diff --git a/fftools/cmdutils.c b/fftools/cmdutils.c > index 12ef07b62f..e5684f

Re: [FFmpeg-devel] [PATCH 04/10] fftools/cmdutils: split common option handlers into their own file

2022-03-17 Thread Andreas Rheinhardt
Anton Khirnov: > --- > fftools/Makefile |2 +- > fftools/cmdutils.c | 1399 +-- > fftools/cmdutils.h | 202 --- > fftools/ffmpeg_opt.c |1 + > fftools/ffplay.c |1 + > fftools/ffpro

Re: [FFmpeg-devel] [PATCH 03/10] fftools: drop useless indirection

2022-03-17 Thread Andreas Rheinhardt
Anton Khirnov: > --- > fftools/cmdutils.c | 4 ++-- > fftools/cmdutils.h | 2 -- > fftools/ffmpeg.c | 4 ++-- > 3 files changed, 4 insertions(+), 6 deletions(-) > > diff --git a/fftools/cmdutils.c b/fftools/cmdutils.c > index 4b50e15eef..0ac98852fe 100644 > --- a/fftools/cmdutils.c > +++ b/ffto

Re: [FFmpeg-devel] [PATCH 02/10] fftools/cmdutils: drop extern declarations for nonexistent variables

2022-03-17 Thread Andreas Rheinhardt
Anton Khirnov: > --- > fftools/cmdutils.h | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/fftools/cmdutils.h b/fftools/cmdutils.h > index d8e5aa342b..f460cb028e 100644 > --- a/fftools/cmdutils.h > +++ b/fftools/cmdutils.h > @@ -44,8 +44,6 @@ extern const char program_name[]; > */ > e

Re: [FFmpeg-devel] [PATCH 01/10] fftools/cmdutils: drop prototypes for nonexistent functions

2022-03-17 Thread Andreas Rheinhardt
Anton Khirnov: > --- > fftools/cmdutils.h | 7 --- > 1 file changed, 7 deletions(-) > > diff --git a/fftools/cmdutils.h b/fftools/cmdutils.h > index 50eed9b13a..d8e5aa342b 100644 > --- a/fftools/cmdutils.h > +++ b/fftools/cmdutils.h > @@ -66,11 +66,6 @@ void exit_program(int ret) av_noreturn;

Re: [FFmpeg-devel] [PATCH] avformat/imfdec: Convert to the new channel layout API

2022-03-17 Thread Andreas Rheinhardt
James Almer: > > > On 3/17/2022 10:09 AM, Andreas Rheinhardt wrote: >> Signed-off-by: Andreas Rheinhardt >> --- >>   libavformat/imfdec.c | 2 +- >>   1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/libavformat/imfdec.c b/libavformat/imfdec.c >> index 3ce850b75a..9ec52efbc8 10064

Re: [FFmpeg-devel] [PATCH] avformat/imfdec: Convert to the new channel layout API

2022-03-17 Thread James Almer
On 3/17/2022 10:09 AM, Andreas Rheinhardt wrote: Signed-off-by: Andreas Rheinhardt --- libavformat/imfdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/imfdec.c b/libavformat/imfdec.c index 3ce850b75a..9ec52efbc8 100644 --- a/libavformat/imfdec.c +++ b/l

[FFmpeg-devel] [PATCH] avformat/imfdec: Convert to the new channel layout API

2022-03-17 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavformat/imfdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/imfdec.c b/libavformat/imfdec.c index 3ce850b75a..9ec52efbc8 100644 --- a/libavformat/imfdec.c +++ b/libavformat/imfdec.c @@ -874,7 +874,7 @@ static int imf_r

[FFmpeg-devel] [PATCH 7/7] avcodec/internal: Move FF_DEFAULT_QUANT_BIAS to mpegvideoenc.h

2022-03-17 Thread Andreas Rheinhardt
Only used there. Signed-off-by: Andreas Rheinhardt --- libavcodec/internal.h | 2 -- libavcodec/mpegvideoenc.h | 3 ++- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/libavcodec/internal.h b/libavcodec/internal.h index 351c057d01..badca4c9dd 100644 --- a/libavcodec/internal.h

[FFmpeg-devel] [PATCH 6/7] avcodec/internal: Move FF_SIGNBIT and ff_log2_run to mathops.h

2022-03-17 Thread Andreas Rheinhardt
It is a more fitting place for them. Also move the definition of ff_log2_run to mathtables.c. Signed-off-by: Andreas Rheinhardt --- libavcodec/aptx.c | 2 +- libavcodec/bitstream.c | 9 - libavcodec/cavs.c | 4 libavcodec/cavsdec.c| 1 + libavcodec/dnxhdenc.c | 2

[FFmpeg-devel] [PATCH 5/7] avcodec/bitstream: Move code for initializing VLCs to file of its own

2022-03-17 Thread Andreas Rheinhardt
bitstream.c is currently the disjoint union of three parts: The first part is ff_log2_run, the second part are some auxiliary functions for the PutBits-API; and the third part is the code for creating VLCs. This commit moves the latter into a file of its own. This has the advantage of making one of

[FFmpeg-devel] [PATCH 4/7] avcodec/mathops: Move bitswap_32() to its only user

2022-03-17 Thread Andreas Rheinhardt
Effectively reverts eaff1aa09e90e2711207c9463db8bf8e8dec8178 given that bitswap_32 is no longer used outside of bitstream.c since 03008c2811ec26cf338780a89b6b2b849b399e3c. Signed-off-by: Andreas Rheinhardt --- libavcodec/bitstream.c | 11 +-- libavcodec/dstdec.c| 1 + libavcodec/mat

[FFmpeg-devel] [PATCH] fate: add crystalizer test

2022-03-17 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- tests/fate/filter-audio.mak | 5 + tests/ref/fate/filter-crystalizer | 264 ++ 2 files changed, 269 insertions(+) create mode 100644 tests/ref/fate/filter-crystalizer diff --git a/tests/fate/filter-audio.mak b/tests/fate/filter

[FFmpeg-devel] [PATCH] avfilter: add tpad filter tests

2022-03-17 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- tests/fate/filter-video.mak | 4 tests/ref/fate/filter-tpad-add | 11 +++ tests/ref/fate/filter-tpad-clone | 10 ++ 3 files changed, 25 insertions(+) create mode 100644 tests/ref/fate/filter-tpad-add create mode 100644 tests/ref/fate/

Re: [FFmpeg-devel] [PATCH] Fix libversion.sh for split headers

2022-03-17 Thread Martin Storsjö
On Wed, 16 Mar 2022, Martin Storsjö wrote: --- The extra dummy version_major.h isn't pretty though, but needed (I think?) to fulfill the make dependency. --- ffbuild/library.mak | 4 ++-- ffbuild/libversion.sh | 4 libavutil/version_major.h | 25 + 3 files c

Re: [FFmpeg-devel] [PATCH v2 5/5] avcodec/x86/hevc_mc: add qpel_h64_8_avx512icl

2022-03-17 Thread Wu, Jianhua
Henrik Gramner: > Sent: Friday, March 11, 2022 10:51 PM > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH v2 5/5] avcodec/x86/hevc_mc: add > qpel_h64_8_avx512icl > > All 5/5 LGTM. > Hi there, Are there any more comments or objections here?

Re: [FFmpeg-devel] [PATCH 02/21] avcodec/zlib_wrapper: Add wrappers for zlib inflateInit, inflateEnd

2022-03-17 Thread Andreas Rheinhardt
Tomas Härdin: > ons 2022-03-16 klockan 20:32 +0100 skrev Andreas Rheinhardt: >> Tomas Härdin: +int ff_inflate_init(FFZStream *z, void *logctx) +{ +    z_stream *const zstream = &z->zstream; +    int zret; + +    z->inited = 0; +    zstream->next_in  = Z_NULL;