Re: [FFmpeg-devel] [PATCH 2/2] lavu/tests/opts: add tests for filepath options

2022-03-07 Thread J. Dekker
On 5 Mar 2022, at 20:16, Michael Niedermayer wrote: > On Fri, Mar 04, 2022 at 04:03:07PM +0100, Niklas Haas wrote: >> From: Niklas Haas >> >> Using the venerable HEADER.txt as a small file to load. >> --- >> libavutil/tests/opt.c| 38 +- >> tests/fate/l

[FFmpeg-devel] [PATCH v7 3/3] libavformat: Added DFPWM WAV container support

2022-03-07 Thread Jack Bruienne
This commit adds support for storing DFPWM audio in a WAV container. It uses the WAVEFORMATEXTENSIBLE structure, following these conventions: https://gist.github.com/MCJack123/90c24b64c8e626c7f130b57e9800962c The implementation is very simple: it just adds the GUID to the list of WAV GUIDs, and m

[FFmpeg-devel] [PATCH v7 2/3] libavformat: Add DFPWM raw format

2022-03-07 Thread Jack Bruienne
This patch builds on my previous DFPWM codec patch, adding a raw audio format to be able to read/write the raw files that are most commonly used (as no other container format supports it yet). The muxers are mostly copied from the PCM demuxer and the raw muxers, as DFPWM is typically stored as r

[FFmpeg-devel] [PATCH v7 1/3] libavcodec: Added DFPWM1a codec

2022-03-07 Thread Jack Bruienne
From the wiki page (https://wiki.vexatos.com/dfpwm): DFPWM (Dynamic Filter Pulse Width Modulation) is an audio codec created by Ben “GreaseMonkey” Russell in 2012, originally to be used as a voice codec for asiekierka's pixmess, a C remake of 64pixels. It is a 1-bit-per-sample codec which uses a

Re: [FFmpeg-devel] [PATCH v6 1/2] libavcodec: Added DFPWM1a codec

2022-03-07 Thread Jack Bruienne
On 3/7/22 06:03, Tomas Härdin wrote: tor 2022-03-03 klockan 10:44 -0500 skrev Jack Bruienne:  From the wiki page (https://wiki.vexatos.com/dfpwm): DFPWM (Dynamic Filter Pulse Width Modulation) is an audio codec created by Ben “GreaseMonkey” Russell in 2012, originally to be used as a voice co

Re: [FFmpeg-devel] [PATCH] avcodec/argo: Check packet size

2022-03-07 Thread Michael Niedermayer
On Sun, Feb 27, 2022 at 11:26:06AM +0100, Michael Niedermayer wrote: > Fixes: Timeout > Fixes: > 45052/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ARGO_fuzzer-6033489206575104 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed

Re: [FFmpeg-devel] [PATCH] avcodec/g729_parser: Check channels

2022-03-07 Thread Michael Niedermayer
On Sun, Feb 27, 2022 at 03:02:46PM +0100, Paul B Mahol wrote: > On Sun, Feb 27, 2022 at 2:51 PM Michael Niedermayer > wrote: > > > Fixes: signed integer overflow: 10 * 808464428 cannot be represented in > > type 'int' > > Fixes: assertion failure > > Fixes: ticket9651 > > > > > LGTM will apply

Re: [FFmpeg-devel] [PATCH] avformat/avidec: Check height

2022-03-07 Thread Michael Niedermayer
On Mon, Feb 28, 2022 at 01:00:52AM +0100, Michael Niedermayer wrote: > Fixes: negation of -2147483648 cannot be represented in type 'int'; cast to > an unsigned type to negate this value to itself > Fixes: Ticket8486 > > Signed-off-by: Michael Niedermayer > --- > libavformat/avidec.c | 2 ++ >

Re: [FFmpeg-devel] [PATCH 3/3] avformat/rmdec: Better duplicate tags check

2022-03-07 Thread Michael Niedermayer
On Thu, Feb 24, 2022 at 12:50:57AM +0100, Michael Niedermayer wrote: > Fixes: memleaks > Fixes: > 44810/clusterfuzz-testcase-minimized-ffmpeg_dem_IVR_fuzzer-5619494647627776 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by:

Re: [FFmpeg-devel] [PATCH 2/3] tools/target_dec_fuzzer: Adjust threshold for targa

2022-03-07 Thread Michael Niedermayer
On Thu, Feb 24, 2022 at 12:50:56AM +0100, Michael Niedermayer wrote: > Fixes: Timeout > Fixes: > 44877/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_TARGA_fuzzer-4870505251864576 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signe

[FFmpeg-devel] [PATCH] avcodec: Add dv marker bsf

2022-03-07 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- doc/bitstream_filters.texi | 15 libavcodec/Makefile | 1 + libavcodec/bitstream_filters.c | 1 + libavcodec/dv_error_marker_bsf.c | 117 +++ 4 files changed, 134 insertions(+) create mode 100644 li

Re: [FFmpeg-devel] [PATCH v2 4/7] avutil/mathematics: add av_rescale_interval() function

2022-03-07 Thread Pierre-Anthony Lemieux
On Fri, Mar 4, 2022 at 12:40 PM Pierre-Anthony Lemieux wrote: > > On Fri, Mar 4, 2022 at 12:13 PM Andreas Rheinhardt > wrote: > > > > p...@sandflow.com: > > > From: Pierre-Anthony Lemieux > > > > > > Refactors a function used by avformat/concat and avformat/imf. > > > > > > --- > > > libavutil

[FFmpeg-devel] [PATCH v3 7/7] avformat/concat: refactor to use ff_rescale_interval()

2022-03-07 Thread pal
From: Pierre-Anthony Lemieux --- libavformat/concatdec.c | 18 -- 1 file changed, 4 insertions(+), 14 deletions(-) diff --git a/libavformat/concatdec.c b/libavformat/concatdec.c index 0603c6e254..cfe1329105 100644 --- a/libavformat/concatdec.c +++ b/libavformat/concatdec.c @@ -8

[FFmpeg-devel] [PATCH v3 6/7] avformat/imf: refactor to use ff_rescale_interval()

2022-03-07 Thread pal
From: Pierre-Anthony Lemieux --- libavformat/imfdec.c | 20 ++-- 1 file changed, 6 insertions(+), 14 deletions(-) diff --git a/libavformat/imfdec.c b/libavformat/imfdec.c index ac212b05e1..a19e431df3 100644 --- a/libavformat/imfdec.c +++ b/libavformat/imfdec.c @@ -904,14 +904,6

[FFmpeg-devel] [PATCH v3 5/7] avformat/tests: add test for ff_rescale_interval()

2022-03-07 Thread pal
From: Pierre-Anthony Lemieux --- libavformat/Makefile | 1 + libavformat/tests/.gitignore | 1 + libavformat/tests/seek_utils.c | 57 ++ tests/fate/libavformat.mak | 5 +++ 4 files changed, 64 insertions(+) create mode 100644 libavformat/tests/

[FFmpeg-devel] [PATCH v3 4/7] avformat/seek: add ff_rescale_interval() function

2022-03-07 Thread pal
From: Pierre-Anthony Lemieux Refactors a function used by avformat/concat and avformat/imf. --- libavformat/avio_internal.h | 21 + libavformat/seek.c | 10 ++ 2 files changed, 31 insertions(+) diff --git a/libavformat/avio_internal.h b/libavformat/avio_int

[FFmpeg-devel] [PATCH v3 3/7] avformat/imf: clean-up and reduce logging

2022-03-07 Thread pal
From: Pierre-Anthony Lemieux --- libavformat/imfdec.c | 93 ++-- 1 file changed, 29 insertions(+), 64 deletions(-) diff --git a/libavformat/imfdec.c b/libavformat/imfdec.c index f208b262c3..ac212b05e1 100644 --- a/libavformat/imfdec.c +++ b/libavformat/im

[FFmpeg-devel] [PATCH v3 2/7] avformat/imf: add support for input seeking

2022-03-07 Thread pal
From: Pierre-Anthony Lemieux The IMF demuxer did not implement AVInputFormat::read_seek2(), resulting in inefficient input seeking. Addresses https://trac.ffmpeg.org/ticket/9648 Byte- and frame-seeking are not supported. --- libavformat/imfdec.c | 129 ++---

[FFmpeg-devel] [PATCH v3 1/7] avformat/imf: relocate static function imf_time_to_ts()

2022-03-07 Thread pal
From: Pierre-Anthony Lemieux --- libavformat/imfdec.c | 38 +++--- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/libavformat/imfdec.c b/libavformat/imfdec.c index 3ce850b75a..b98af020d2 100644 --- a/libavformat/imfdec.c +++ b/libavformat/imfdec.c

Re: [FFmpeg-devel] [PATCH] mlp_parser: fetch a new timestamp when major sync is found

2022-03-07 Thread Jan Ekström
On Mon, Mar 7, 2022 at 7:10 PM Michael Niedermayer wrote: > > On Mon, Mar 07, 2022 at 12:32:59AM +0200, Jan Ekström wrote: > > From: Hendrik Leppkes > > > > Decoding can only start on a major sync > > > and the parser discards > > any data received until that point. > > Thats a bug and its incons

Re: [FFmpeg-devel] [PATCH] mlp_parser: fetch a new timestamp when major sync is found

2022-03-07 Thread Hendrik Leppkes
On Mon, Mar 7, 2022 at 6:10 PM Michael Niedermayer wrote: > So why is this considered to be "ok" in audio codecs? > Because we dont visually see that data is lost ? This patch is not trying to argue that its "ok" to drop data, nor does it introduce this behavior. Someone else did that years ago.

Re: [FFmpeg-devel] GSoC 2022

2022-03-07 Thread Michael Niedermayer
Hi all FFmpeg has been accepted for GSoC this year again! Thanks to everyone who wants to mentor and proposed a project! https://summerofcode.withgoogle.com/programs/2022/organizations/ffmpeg https://trac.ffmpeg.org/wiki/SponsoringPrograms/GSoC/2022 thx -- Michael GnuPG fingerprint: 9FF2

Re: [FFmpeg-devel] [PATCH] avcodec/pngdec: support alpha blending for palette apng

2022-03-07 Thread Paul B Mahol
will apply soon! ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avfilter: Added siti filter

2022-03-07 Thread Paul B Mahol
On 3/7/22, Thilo Borgmann wrote: > Am 06.03.22 um 22:25 schrieb Paul B Mahol: >> On 3/6/22, Thilo Borgmann wrote: >>> Am 22.02.22 um 12:30 schrieb Thilo Borgmann: Am 18.02.22 um 17:08 schrieb Paul B Mahol: > On Sat, Feb 12, 2022 at 11:55 AM Thilo Borgmann > > wrote: > >>

Re: [FFmpeg-devel] [PATCH v3 0/8] rewrite avpriv_find_start_code() for clarity

2022-03-07 Thread Scott Theisen
On 2/8/22 22:28, Scott Theisen wrote: I have removed most of my added comments. Rebased to account for Andreas Rheinhardt moving the prototype to startcode.h. Per his suggestion, the function signature is now unmodified. (ff_)mpeg1_find_frame_end() now has a wrapper function preserving the orig

Re: [FFmpeg-devel] [PATCH] mlp_parser: fetch a new timestamp when major sync is found

2022-03-07 Thread Michael Niedermayer
On Mon, Mar 07, 2022 at 12:32:59AM +0200, Jan Ekström wrote: > From: Hendrik Leppkes > > Decoding can only start on a major sync > and the parser discards > any data received until that point. Thats a bug and its inconsistant For example video codec parsers do not drop frames until a keyframe A

Re: [FFmpeg-devel] [PATCH] avfilter: Added siti filter

2022-03-07 Thread Thilo Borgmann
Am 06.03.22 um 22:25 schrieb Paul B Mahol: On 3/6/22, Thilo Borgmann wrote: Am 22.02.22 um 12:30 schrieb Thilo Borgmann: Am 18.02.22 um 17:08 schrieb Paul B Mahol: On Sat, Feb 12, 2022 at 11:55 AM Thilo Borgmann wrote: Am 31.01.22 um 12:55 schrieb James Almer: On 1/31/2022 8:53 AM, Anto

Re: [FFmpeg-devel] [PATCH v2 3/5] libswscale: Avx2 hscale can process inputs of any size.

2022-03-07 Thread Alan Kelly
Hi Michael, Thanks for reviewing the first two parts of this patchset. Is there anybody interested in reviewing this part? Thanks, Alan On Thu, Feb 17, 2022 at 5:21 PM Michael Niedermayer wrote: > On Thu, Feb 17, 2022 at 11:04:04AM +0100, Alan Kelly wrote: > > The main loop processes blocks

[FFmpeg-devel] [PATCH RESEND] configure: move ranlib -D test after setting defaults

2022-03-07 Thread Adrian Ratiu
In Gentoo and ChromeOS we want to allow pure LLVM builds without using GNU tools, so we block any unwanted mixed GNU/LLVM usages (GNU tools are still kept around in our chroots for projects like glibc which cannot yet be built otherwise). The default ${cross_prefix}${ranlib_default} points to GNU

Re: [FFmpeg-devel] [PATCH v6 1/2] libavcodec: Added DFPWM1a codec

2022-03-07 Thread Tomas Härdin
tor 2022-03-03 klockan 10:44 -0500 skrev Jack Bruienne: > >  From the wiki page (https://wiki.vexatos.com/dfpwm): > > DFPWM (Dynamic Filter Pulse Width Modulation) is an audio codec > > created by Ben “GreaseMonkey” Russell in 2012, originally to be > > used > > as a voice codec for asiekierka's p

Re: [FFmpeg-devel] [PATCH 269/281] wavpack: convert to new channel layout API

2022-03-07 Thread Anton Khirnov
Quoting James Almer (2022-01-13 03:07:13) > From: Anton Khirnov > > Signed-off-by: Vittorio Giovara > Signed-off-by: James Almer > --- > libavcodec/wavpack.c| 51 ++--- > libavcodec/wavpackenc.c | 29 --- > 2 files changed, 37 inserti

Re: [FFmpeg-devel] [PATCH 270/281] wma: convert to new channel layout API

2022-03-07 Thread Anton Khirnov
Quoting James Almer (2022-01-13 03:09:02) > From: Anton Khirnov > > Signed-off-by: James Almer > --- > libavcodec/wma.c| 11 ++- > libavcodec/wmadec.c | 29 +++-- > libavcodec/wmaenc.c | 27 ++- > libavcodec/wma