[FFmpeg-devel] [PATCH] avformat/avisynth: remove framedata variable

2022-02-19 Thread Stephen Hutchinson
It's just a simple index. Addresses Coverity issue 1500290 Signed-off-by: Stephen Hutchinson --- libavformat/avisynth.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/avisynth.c b/libavformat/avisynth.c index 03489f180f..318588ff52 100644 --- a/libavformat/a

Re: [FFmpeg-devel] [PATCH 2/2] avformat/avisynth: make sure framedata variable is initialized

2022-02-19 Thread Stephen Hutchinson
On 2/19/22 5:45 PM, Andreas Rheinhardt wrote: Stephen Hutchinson: Addresses Coverity issue 1500290 Signed-off-by: Stephen Hutchinson --- libavformat/avisynth.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavformat/avisynth.c b/libavformat/avisynth.c index 03489f1

Re: [FFmpeg-devel] [PATCH 2/2] avformat/avisynth: make sure framedata variable is initialized

2022-02-19 Thread Andreas Rheinhardt
Stephen Hutchinson: > Addresses Coverity issue 1500290 > > Signed-off-by: Stephen Hutchinson > --- > libavformat/avisynth.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/libavformat/avisynth.c b/libavformat/avisynth.c > index 03489f180f..cfb7b2a783 100644 > --- a/li

Re: [FFmpeg-devel] [PATCH 2/3] avisynth: use AviSynth+'s frame properties to set various fields

2022-02-19 Thread Stephen Hutchinson
On 2/19/22 3:39 PM, Andreas Rheinhardt wrote: +if (frameprop = true) { + +frame = avs_library.avs_get_frame(avs->clip, framedata); framedata is completely uninitialized here. I presume it should be zero (for the first frame)? (This is Coverity issue 1500290.) I don't remember wh

Re: [FFmpeg-devel] [PATCH] swscale: Take the destination range into account for yuv->rgb->yuv conversions

2022-02-19 Thread Martin Storsjö
On Sat, 19 Feb 2022, Michael Niedermayer wrote: On Fri, Feb 18, 2022 at 04:45:46PM +0200, Martin Storsjö wrote: The range parameters need to be set up before calling sws_init_context (which selects which fastpaths can be used; this gets called by sws_getContext); solely passing them via sws_set

[FFmpeg-devel] [PATCH 2/2] avformat/avisynth: make sure framedata variable is initialized

2022-02-19 Thread Stephen Hutchinson
Addresses Coverity issue 1500290 Signed-off-by: Stephen Hutchinson --- libavformat/avisynth.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavformat/avisynth.c b/libavformat/avisynth.c index 03489f180f..cfb7b2a783 100644 --- a/libavformat/avisynth.c +++ b/libavformat/a

[FFmpeg-devel] [PATCH 1/2] avformat/avisynth: remove unused variable 'frameprop'

2022-02-19 Thread Stephen Hutchinson
Since the check got simplified and stdbool was no longer necessary to include, neither is that variable. Silences a warning. Signed-off-by: Stephen Hutchinson --- libavformat/avisynth.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavformat/avisynth.c b/libavformat/avisynth.c index 2bd0

Re: [FFmpeg-devel] [PATCH 1/2] lavfi: add ff_inoutlink_check_flow()

2022-02-19 Thread Paul B Mahol
OK for the set. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 2/3] avisynth: use AviSynth+'s frame properties to set various fields

2022-02-19 Thread Andreas Rheinhardt
Stephen Hutchinson: > * Field Order > * Chroma Location > * Color Transfer Characteristics > * Color Range > * Color Primaries > * Matrix Coefficients > > The existing TFF/BFF detection is retained as a fallback for > older versions of AviSynth that can't access frame properties. > The other prope

Re: [FFmpeg-devel] [PATCH] avfilter/vf_fps: only give frame as soon as possible if really requested by output

2022-02-19 Thread Nicolas George
Nicolas George (12022-02-19): > This would break input-driven filtering I think. I am looking into it. See: https://ffmpeg.org/pipermail/ffmpeg-devel/2022-February/293240.html https://ffmpeg.org/pipermail/ffmpeg-devel/2022-February/293241.html Regards, -- Nicolas George signature.asc Descr

[FFmpeg-devel] [PATCH 2/2] lavfi/vf_fps: check flow before sending more frames

2022-02-19 Thread Nicolas George
Analyzed by Paul B Mahol . Fixes OOM in #9081. Signed-off-by: Nicolas George --- libavfilter/vf_fps.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/vf_fps.c b/libavfilter/vf_fps.c index 99e679441e..0e5a1fec35 100644 --- a/libavfilter/vf_fps.c +++ b/libavfilter/

[FFmpeg-devel] [PATCH 1/2] lavfi: add ff_inoutlink_check_flow()

2022-02-19 Thread Nicolas George
Signed-off-by: Nicolas George --- libavfilter/avfilter.c | 8 libavfilter/filters.h | 8 2 files changed, 16 insertions(+) diff --git a/libavfilter/avfilter.c b/libavfilter/avfilter.c index 7362bcdab5..1f37a70179 100644 --- a/libavfilter/avfilter.c +++ b/libavfilter/avfilter.c

Re: [FFmpeg-devel] [PATCH] swscale: Take the destination range into account for yuv->rgb->yuv conversions

2022-02-19 Thread Michael Niedermayer
On Fri, Feb 18, 2022 at 04:45:46PM +0200, Martin Storsjö wrote: > The range parameters need to be set up before calling > sws_init_context (which selects which fastpaths can be used; > this gets called by sws_getContext); solely passing them via > sws_setColorspaceDetails isn't enough. > > This fi

[FFmpeg-devel] [PATCH 2/2] fftools/ffprobe: Remove redundant checks

2022-02-19 Thread Andreas Rheinhardt
A decoder is only opened if there is a decoder for the codec, so every AVCodecContext here has AVCodecContext.codec set. Signed-off-by: Andreas Rheinhardt --- fftools/ffprobe.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c index 420

[FFmpeg-devel] [PATCH 1/2] fftools/ffprobe: Flush decoder after draining

2022-02-19 Thread Andreas Rheinhardt
This is a prerequisite to continue using the decoder at all to decode the next interval (if any). This fixes a regression introduced in commit 2a88ebd096f3c748a2d99ed1b60b22879b3c567c and reported in ticket #8657. Signed-off-by: Andreas Rheinhardt --- I wonder whether it would not be simpler to l

[FFmpeg-devel] [PATCH] libavfilter: zscale performance optimization >4x

2022-02-19 Thread Victoria Zhislina
By ffmpeg threading support implementation via frame slicing and doing zimg_filter_graph_build that used to take 30-60% of each frame processig only if necessary (some parameters changed) the performance increase vs original version in video downscale and color conversion >4x is seen on 64 cores I

Re: [FFmpeg-devel] [PATCH] avfilter/vf_fps: only give frame as soon as possible if really requested by output

2022-02-19 Thread Nicolas George
Paul B Mahol (12022-02-19): > Fixes OOM in #9081. > > Signed-off-by: Paul B Mahol > --- > libavfilter/vf_fps.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) This would break input-driven filtering I think. I am looking into it. Regards, -- Nicolas George signature.asc Descripti

Re: [FFmpeg-devel] [PATCH 3/7] tools/target_dem_fuzzer: Force interrupt for HLS

2022-02-19 Thread Michael Niedermayer
On Sun, Dec 05, 2021 at 10:19:03PM +0100, Michael Niedermayer wrote: > Fixes: Timeout > Fixes: > 41580/clusterfuzz-testcase-minimized-ffmpeg_dem_HLS_fuzzer-5059099224571904 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by:

Re: [FFmpeg-devel] [PATCH 2/7] tools/target_dem_fuzzer: Test interrupt callback

2022-02-19 Thread Michael Niedermayer
On Sun, Dec 05, 2021 at 10:19:02PM +0100, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > tools/target_dem_fuzzer.c | 10 ++ > 1 file changed, 10 insertions(+) will apply [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB No human

Re: [FFmpeg-devel] [PATCH v3 4/5] fftools/cmdutils.c: Replace MAX_PATH-sized buffers with dynamically sized ones

2022-02-19 Thread nil-admirari
> Ok, well maybe we should change that too, to use wchar paths (or utf8->whcar > routines?). Changed to wchartoutf8, and replaced fopen with av_fopen_utf8 throughout the file. See https://ffmpeg.org/pipermail/ffmpeg-devel/2022-February/293229.html. > doesn't use UTF-8 like everything else. Th

[FFmpeg-devel] [PATCH v7 6/6] fftools: Use UTF-8 on Windows

2022-02-19 Thread Nil Admirari
--- fftools/fftools.manifest | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/fftools/fftools.manifest b/fftools/fftools.manifest index 30b7d8f..d1ac1e4 100644 --- a/fftools/fftools.manifest +++ b/fftools/fftools.manifest @@ -3,8 +3,10 @@ -http://schemas.microso

[FFmpeg-devel] [PATCH v7 2/6] libavformat/avisynth.c: Replace MAX_PATH-sized buffers with dynamically sized ones

2022-02-19 Thread Nil Admirari
--- libavformat/avisynth.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/libavformat/avisynth.c b/libavformat/avisynth.c index 2bd0c69..e28d832 100644 --- a/libavformat/avisynth.c +++ b/libavformat/avisynth.c @@ -34,6 +34,7 @@ /* Platform-specific directives. */

[FFmpeg-devel] [PATCH v7 4/6] fftools/cmdutils.c: Replace MAX_PATH-sized buffers with dynamically sized ones, and fopen with av_fopen_utf8

2022-02-19 Thread Nil Admirari
--- fftools/cmdutils.c | 40 ++-- 1 file changed, 30 insertions(+), 10 deletions(-) diff --git a/fftools/cmdutils.c b/fftools/cmdutils.c index 4b50e15..e87601e 100644 --- a/fftools/cmdutils.c +++ b/fftools/cmdutils.c @@ -40,6 +40,7 @@ #include "libavutil/attri

[FFmpeg-devel] [PATCH v7 5/6] fftools: Enable long path support on Windows (fixes #8885)

2022-02-19 Thread Nil Admirari
--- fftools/Makefile | 5 + fftools/fftools.manifest | 10 ++ fftools/manifest.rc | 3 +++ 3 files changed, 18 insertions(+) create mode 100644 fftools/fftools.manifest create mode 100644 fftools/manifest.rc diff --git a/fftools/Makefile b/fftools/Makefile index da420

[FFmpeg-devel] [PATCH v7 3/6] compat/w32dlfcn.h: Replace MAX_PATH-sized buffers with dynamically sized ones

2022-02-19 Thread Nil Admirari
Also replaces a call to LoadLibraryExA with LoadLibraryExW since ANSI functions do not support long paths. --- compat/w32dlfcn.h | 74 ++- 1 file changed, 61 insertions(+), 13 deletions(-) diff --git a/compat/w32dlfcn.h b/compat/w32dlfcn.h index 52a94ef

[FFmpeg-devel] [PATCH v7 1/6] libavutil/wchar_filename.h: Add whcartoutf8, wchartoansi and utf8toansi

2022-02-19 Thread Nil Admirari
These functions are going to be used in libavformat/avisynth.c and fftools/cmdutils.c when replacing MAX_PATH-sized buffers with dynamically sized ones. --- libavutil/wchar_filename.h | 51 ++ 1 file changed, 51 insertions(+) diff --git a/libavutil/wchar_filena

Re: [FFmpeg-devel] [PATCH 1/2] avdevice/avfoundation: fix memleak

2022-02-19 Thread zhilizhao(赵志立)
> On Feb 8, 2022, at 9:05 PM, Andreas Rheinhardt > wrote: > > Thilo Borgmann: >> Am 08.02.22 um 13:50 schrieb Andreas Rheinhardt: >>> Thilo Borgmann: Am 04.02.22 um 17:19 schrieb Zhao Zhili: > --- >libavdevice/avfoundation.m | 10 ++ >1 file changed, 6 insertio