Re: [FFmpeg-devel] [PATCH] configure: link to libatomic when it's present

2022-01-28 Thread Brad Smith
On 1/26/2022 6:49 AM, Anton Khirnov wrote: Quoting Brad Smith (2022-01-23 20:40:30) Testing this commit out it does as I had suspected and even with --as-needed causes a false positive on OpenBSD / FreeBSD. Why? Looking at this again and thinking about what it does, the test as is is flawed

[FFmpeg-devel] [PATCH 3/3] avfilter/af_apsyclip: increase protection for high frequencies

2022-01-28 Thread Jason Jang
This reduces sibilance distortion when sibilance and bass are present at the same time. Bringing the protection of high frequencies up to about the same level as for low frequencies should also make the quality less dependent on the frequency balance of the playback system. Signed-off-by: Jason Ja

[FFmpeg-devel] [PATCH 2/3] avfilter/af_apsyclip: fix peak overestimation

2022-01-28 Thread Jason Jang
Ignore more samples that are near the edge of the block. The reason is that the filtering tends to cause these samples to go above the window more than the samples near the middle. If these samples are included in the unwindowed peak estimation, the peak can be overestimated. Because the block is w

[FFmpeg-devel] [PATCH 1/3] avfilter/af_apsyclip: fix FFT bin indexing

2022-01-28 Thread Jason Jang
With a complex FFT instead of real FFT, the negative frequencies are not dropped from the spectrum output, so they need to be scaled when the positive frequencies are scaled. The location of the top bin is also different. Signed-off-by: Jason Jang --- libavfilter/af_apsyclip.c | 19 +

[FFmpeg-devel] [PATCH v4] avformat/hls: Implement support for using AVSEEK_FLAG_BACKWARD when seeking

2022-01-28 Thread Gustav Grusell
Before, seeking in hls streams would always seek to the next keyframe after the given timestamp. With this fix, if seeking in videostream and AVSEEK_FLAG_BACKWARD is set, seeking will be to the first keyframe of the segment containing the given timestamp. This fixes #7485. Signed-off-by: Gustav Gr

[FFmpeg-devel] [PATCH v3] avformat/hls Implement support for using AVSEEK_FLAG_BACKWARD when seeking

2022-01-28 Thread Gustav Grusell
Before, seeking in hls streams would always seek to the next keyframe after the given timestamp. With this fix, if seeking in videostream and AVSEEK_FLAG_BACKWARD is set, seeking will be to the first keyframe of the segment containing the given timestamp. This fixes #7485. Signed-off-by: Gustav Gr

Re: [FFmpeg-devel] [PATCH 135/281] rtp: convert to new channel layout API

2022-01-28 Thread Anton Khirnov
Quoting James Almer (2022-01-13 02:57:52) > diff --git a/libavformat/rtpdec_amr.c b/libavformat/rtpdec_amr.c > index 988b7bddfd..20b435039c 100644 > --- a/libavformat/rtpdec_amr.c > +++ b/libavformat/rtpdec_amr.c > @@ -64,11 +64,10 @@ static int amr_handle_packet(AVFormatContext *ctx, > PayloadCon

Re: [FFmpeg-devel] [PATCH] avcodec/jpeg2000dec: Move preparations to main thread, fix race

2022-01-28 Thread Andreas Rheinhardt
Andreas Rheinhardt: > jpeg2000_decode_tile() (which is run concurrently by several threads > when using slice threading) currently modifies some joint values > before doing its actual work. This is a data race that happens to work > because all threads set the same values; but it is nevertheless >

Re: [FFmpeg-devel] [PATCH] avcodec/mips: Support old style mmi instruction mnemonics

2022-01-28 Thread Jiaxun Yang
在2021年8月2日八月 上午9:33,yinshiyou...@loongson.cn写道: >> -原始邮件- >> 发件人: "Jiaxun Yang" >> 发送时间: 2021-08-02 13:40:54 (星期一) >> 收件人: "FFmpeg development discussions and patches" , >> yinshiyou...@loongson.cn >> 抄送: >> 主题: Re: [FFmpeg-devel] [PATCH] avcodec/mips: Support old style mmi >> instruc

Re: [FFmpeg-devel] [PATCH] avformat/mp3dec: Parse iTunes gapless info

2022-01-28 Thread Anton Khirnov
Quoting Christopher Snowhill (2022-01-28 06:21:07) > Parse the ID3v2 iTunSMPB comment tag containing gapless decoding info, > and also add the expected test results for the implementation. > > Signed-off-by: Christopher Snowhill > --- > Curses, Apple Mail is broken, too. Using git imap-send inste

Re: [FFmpeg-devel] [PATCH 1/2] avutil/random_seed: Speed up fate test

2022-01-28 Thread Anton Khirnov
Quoting Michael Niedermayer (2022-01-25 11:21:08) > This decreases the quality of the seeds during the test, it does not affect > the seeds outside the test. > There is a small chance that this causes test failures, if that happens > the threshold needs adjusting > > Testing on an idle x86_64 syst

Re: [FFmpeg-devel] [PATCH 01/21] avcodec/h263: Remove declaration for inexistent function

2022-01-28 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/h263.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/libavcodec/h263.h b/libavcodec/h263.h > index 982e545491..31836ebb95 100644 > --- a/libavcodec/h263.h > +++ b/libavcodec/h263.h > @@ -68,7 +68,6 @@ void ff_h2

Re: [FFmpeg-devel] [PATCH 096/281] mov: convert to new channel layout API

2022-01-28 Thread Anton Khirnov
Quoting James Almer (2022-01-13 02:55:49) > diff --git a/libavformat/mov_chan.c b/libavformat/mov_chan.c > index 349634094c..5894bb8ce2 100644 > --- a/libavformat/mov_chan.c > +++ b/libavformat/mov_chan.c > @@ -499,7 +499,7 @@ static uint32_t mov_get_channel_label(uint32_t label) > } > > uint32