Re: [FFmpeg-devel] GitHub Integration

2021-12-25 Thread Steven Liu
> 在 2021年12月26日,上午8:55,lance.lmw...@gmail.com 写道: > > On Sat, Dec 25, 2021 at 05:15:19PM +, Soft Works wrote: >> >> >>> -Original Message- >>> From: ffmpeg-devel On Behalf Of Lynne >>> Sent: Saturday, December 25, 2021 5:50 PM >>> To: FFmpeg development discussions and patches >

Re: [FFmpeg-devel] GitHub Integration

2021-12-25 Thread lance . lmwang
On Sat, Dec 25, 2021 at 05:15:19PM +, Soft Works wrote: > > > > -Original Message- > > From: ffmpeg-devel On Behalf Of Lynne > > Sent: Saturday, December 25, 2021 5:50 PM > > To: FFmpeg development discussions and patches > > Subject: Re: [FFmpeg-devel] GitHub Integration > > > > 2

[FFmpeg-devel] [PATCH] avcodec/tiff: Remove messing with jpeg context

2021-12-25 Thread Michael Niedermayer
The whole concept is just not correct, also as it seems not to be needed at all, all dng files i have decode without this. Fixes: various crashes Fixes: 42937/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_TIFF_fuzzer-4625073334517760 Fixes: 42938/clusterfuzz-testcase-minimized-ffmpeg_AV_CODE

Re: [FFmpeg-devel] GitHub Integration

2021-12-25 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of Lynne > Sent: Saturday, December 25, 2021 5:50 PM > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] GitHub Integration > > 23 Dec 2021, 00:24 by softwo...@hotmail.com: > > > Hi, > > > > holidays are ap

Re: [FFmpeg-devel] GitHub Integration

2021-12-25 Thread Lynne
23 Dec 2021, 00:24 by softwo...@hotmail.com: > Hi, > > holidays are approaching and I got a little present for all of you > even though it won’t be something for everybody. > > A while ago I had committed to prepare a test setup for integrating > GitHub in a similar way as the Git developers are

Re: [FFmpeg-devel] GitHub Integration

2021-12-25 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of Michael > Niedermayer > Sent: Saturday, December 25, 2021 12:12 PM > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] GitHub Integration > > On Sat, Dec 25, 2021 at 12:31:56PM +0300, Vasily wrote: > > Hi

Re: [FFmpeg-devel] GitHub Integration

2021-12-25 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of Vasily > Sent: Saturday, December 25, 2021 10:32 AM > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] GitHub Integration > > Hi, > > First off, a great idea bridging that gap! But I agree that the top

[FFmpeg-devel] [PATCH v2 2/2] avcodec/libx26[45]: reindent after last commit

2021-12-25 Thread lance . lmwang
From: Limin Wang --- libavcodec/libx264.c | 44 ++-- libavcodec/libx265.c | 48 2 files changed, 46 insertions(+), 46 deletions(-) diff --git a/libavcodec/libx264.c b/libavcodec/libx264.c index 9836818..c5e

[FFmpeg-devel] [PATCH v2 1/2] avcodec/libx26[45]: add udu_sei option to import user data unregistered SEIs

2021-12-25 Thread lance . lmwang
From: Limin Wang Most of user data unregistered SEIs are privated data which defined by user/ encoder. currently, the user data unregistered SEIs found in input are forwarded as side-data to encoders directly, it'll cause the reencoded output including some useless UDU SEIs. I prefer to add one

Re: [FFmpeg-devel] [PATCH] avcodec/nvenc: add udu_sei option to import user data unregistered SEIs

2021-12-25 Thread lance . lmwang
On Sat, Dec 25, 2021 at 02:15:36PM +0100, Timo Rothenpieler wrote: > Applied a slightly modified version. > Just so it avoids cycling through the side data loop entirely when it's > never going to be needed. Thanks, it's better, I'll move the check out of loop for libx264 and libx265 to avoid the

[FFmpeg-devel] [PATCH] avformat/fitsdec: remove always true condition

2021-12-25 Thread Steven Liu
From: Steven Liu Because the AVBPrint->len is unsigned, so it should alway true, the AVBPrint->len < INT64_MAX is unneccessary condition. Signed-off-by: Steven Liu --- libavformat/fitsdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/fitsdec.c b/libavformat/

Re: [FFmpeg-devel] [PATCH] avcodec/nvenc: add udu_sei option to import user data unregistered SEIs

2021-12-25 Thread Timo Rothenpieler
Applied a slightly modified version. Just so it avoids cycling through the side data loop entirely when it's never going to be needed. smime.p7s Description: S/MIME Cryptographic Signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://

Re: [FFmpeg-devel] [PATCH v3 2/2] avformat/mov: add use_hoov option

2021-12-25 Thread Steven Liu
> 在 2021年12月25日,19:42,zhilizhao(赵志立) 写道: > > > >> On Dec 25, 2021, at 6:36 PM, Marton Balint wrote: >> >> On Sat, 25 Dec 2021, Zhao Zhili wrote: >> >>> Fix #8883. >>> --- >>> doc/demuxers.texi | 6 ++ >>> libavformat/isom.h | 1 + >>> libavformat/mov.c | 9 +++-- >>> 3 files changed

Re: [FFmpeg-devel] [PATCH v3 2/2] avformat/mov: add use_hoov option

2021-12-25 Thread zhilizhao(赵志立)
> On Dec 25, 2021, at 6:36 PM, Marton Balint wrote: > > On Sat, 25 Dec 2021, Zhao Zhili wrote: > >> Fix #8883. >> --- >> doc/demuxers.texi | 6 ++ >> libavformat/isom.h | 1 + >> libavformat/mov.c | 9 +++-- >> 3 files changed, 14 insertions(+), 2 deletions(-) >> >> diff --git a/doc/de

Re: [FFmpeg-devel] GitHub Integration

2021-12-25 Thread Michael Niedermayer
On Sat, Dec 25, 2021 at 12:31:56PM +0300, Vasily wrote: > Hi, > > First off, a great idea bridging that gap! But I agree that the topic is > misleading, maybe rename to smth like "github bridge for PR creation" to be > really explicit? > > Second one, why first-comers aren't allowed to submit wi

Re: [FFmpeg-devel] [PATCH v3 2/2] avformat/mov: add use_hoov option

2021-12-25 Thread Steven Liu
> 在 2021年12月25日,18:36,Marton Balint 写道: > > > > On Sat, 25 Dec 2021, Zhao Zhili wrote: > >> Fix #8883. >> --- >> doc/demuxers.texi | 6 ++ >> libavformat/isom.h | 1 + >> libavformat/mov.c | 9 +++-- >> 3 files changed, 14 insertions(+), 2 deletions(-) >> >> diff --git a/doc/demuxers

Re: [FFmpeg-devel] [PATCH 5/5] avformat/mvdec: Check bytes_per_sample

2021-12-25 Thread Michael Niedermayer
On Fri, Dec 24, 2021 at 03:29:50PM -0500, John-Paul Stewart wrote: > On 2021-12-24 11:58, Michael Niedermayer wrote: > > On Thu, Dec 23, 2021 at 10:32:12PM -0500, John-Paul Stewart wrote: > >> On 2021-12-23 16:15, Michael Niedermayer wrote: > >>> Fixes: division by zero > >>> Fixes: > >>> 42814/cl

Re: [FFmpeg-devel] [PATCH 2/5] avcodec/cdgraphics: avoid signed overflow in alpha

2021-12-25 Thread Michael Niedermayer
On Thu, Dec 23, 2021 at 10:45:47PM +0100, Andreas Rheinhardt wrote: > Michael Niedermayer: > > Fixes: left shift of 255 by 24 places cannot be represented in type 'int' > > Fixes: > > 42766/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_CDGRAPHICS_fuzzer-5142826105569280 > > > > Found-by: cont

Re: [FFmpeg-devel] [PATCH v3 2/2] avformat/mov: add use_hoov option

2021-12-25 Thread Marton Balint
On Sat, 25 Dec 2021, Zhao Zhili wrote: Fix #8883. --- doc/demuxers.texi | 6 ++ libavformat/isom.h | 1 + libavformat/mov.c | 9 +++-- 3 files changed, 14 insertions(+), 2 deletions(-) diff --git a/doc/demuxers.texi b/doc/demuxers.texi index cab8a7072c..276b536ac5 100644 --- a/doc/dem

[FFmpeg-devel] [PATCH v3 2/2] avformat/mov: add use_hoov option

2021-12-25 Thread Zhao Zhili
Fix #8883. --- doc/demuxers.texi | 6 ++ libavformat/isom.h | 1 + libavformat/mov.c | 9 +++-- 3 files changed, 14 insertions(+), 2 deletions(-) diff --git a/doc/demuxers.texi b/doc/demuxers.texi index cab8a7072c..276b536ac5 100644 --- a/doc/demuxers.texi +++ b/doc/demuxers.texi @@ -71

Re: [FFmpeg-devel] GitHub Integration

2021-12-25 Thread Vasily
Typo correction: "the bot should remove", not "the boy" (oh my mobile tapping...) сб, 25 дек. 2021 г., 12:31 Vasily : > Hi, > > First off, a great idea bridging that gap! But I agree that the topic is > misleading, maybe rename to smth like "github bridge for PR creation" to be > really explicit?

Re: [FFmpeg-devel] GitHub Integration

2021-12-25 Thread Vasily
Hi, First off, a great idea bridging that gap! But I agree that the topic is misleading, maybe rename to smth like "github bridge for PR creation" to be really explicit? Second one, why first-comers aren't allowed to submit without pre-approval? (context: I haven't made my contributions to ffmpeg

Re: [FFmpeg-devel] [PATCH] avfilter/vf_libvmaf: update filter for libvmaf v2.0.0

2021-12-25 Thread Paul B Mahol
On Fri, Dec 24, 2021 at 9:52 PM Kyle Swanson wrote: > Hi, > > Never followed through on this vf_libvmaf patch from last June, and > I've had several people asking about its status lately. Rebased patch > attached. It's been a while, so I guess let's start the review again. > Would be nice if we c

Re: [FFmpeg-devel] [PATCH 2/3] avformat/mov: skip hoov box if strict >= normal

2021-12-25 Thread zhilizhao(赵志立)
> On Dec 25, 2021, at 3:08 AM, Derek Buitenhuis > wrote: > > On 12/24/2021 10:46 AM, Steven Liu wrote: >> I think about ignore hoov should not default, because it use hoov >> default before. > > I agree - we (Vimeo) get a ton of hoov files with no moov or broken moov - > much more than files

[FFmpeg-devel] [PATCH v2 2/2] avformat/mov: take hoov as moov only in the second pass

2021-12-25 Thread Zhao Zhili
Fix #8883. --- libavformat/mov.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index ea2f010aa0..5787a20124 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -7324,8 +7324,9 @@ static int mov_read_default(MOVContext *c, AVIOC

[FFmpeg-devel] [PATCH v2 1/2] avformat/mov: skip moof and sidx before found moov

2021-12-25 Thread Zhao Zhili
It's required for #8883. VLC and quicktime player can handle the sample file. --- libavformat/mov.c | 16 1 file changed, 16 insertions(+) diff --git a/libavformat/mov.c b/libavformat/mov.c index 2aed6e80ef..ea2f010aa0 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -73