[FFmpeg-devel] [PATCH] avfilter/vf_fftfilt: Use av_clip_uintp2

2021-10-13 Thread Martin Storsjö
The refactoring in 844890b1bc86316a38bc9e1dbf8ba0dd254307e3 caused fate-source to point out that this could be av_clip_uintp2. Signed-off-by: Martin Storsjö --- libavfilter/vf_fftfilt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/vf_fftfilt.c b/libavfilter/vf_

[FFmpeg-devel] [PATCH v2 3/3] avformat/avio{, buf}: deprecate AVIOContext::written

2021-10-13 Thread Jan Ekström
Originally added as a private entry in commit 3f75e5116b900f1428aa13041fc7d6301bf1988a, but its grouping with the comment noting its private state was missed during merging of the field from Libav (most likely due to an already existing field in between). Users should migrate to the public field A

[FFmpeg-devel] [PATCH v2 2/3] avformat/avio{, buf}: introduce public AVIOContext::bytes_{read, written}

2021-10-13 Thread Jan Ekström
Such fields can be seen as generally useful in cases where the API user is not implementing custom AVIO callbacks, but still would like to know if data is being read or written out, such as in case data is being read from input but no AVPacket has been received yet. --- doc/APIchanges| 3

[FFmpeg-devel] [PATCH v2 1/3] avformat/avio: privatize point of truth for AVIOContext::written

2021-10-13 Thread Jan Ekström
Looking at 3f75e5116b900f1428aa13041fc7d6301bf1988a, the field was supposed to be private, but during merging the field and the group that had the comment about it got separated. Thus, move the actual privately utilized state of this variable into the private FFIOContext. --- libavformat/avio_int

[FFmpeg-devel] [PATCH v2 0/3] introduce public AVIOContext::bytes_{read, written}

2021-10-13 Thread Jan Ekström
After a brief discussion with Michael on IRC, this seems to be the idea of a path forward that was agreed upon. 1. AVIOContext::written was supposed to be a private field [1], so move the value utilized internally to FFIOContext, and set the AVIOContext value from there. 2. Introduce public

Re: [FFmpeg-devel] [PATCH 01/10] avcodec/binkaudio: Remove AV_CODEC_CAP_DELAY

2021-10-13 Thread Paul B Mahol
LGTM ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/speexdec: Seed should be unsigned otherwise the operations done on it are undefined

2021-10-13 Thread Michael Niedermayer
On Tue, Oct 12, 2021 at 06:31:14PM +0200, Paul B Mahol wrote: > ok will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The greatest way to live with honor in this world is to be what we pretend to be. -- Socrates signature.asc Description: PGP sign

Re: [FFmpeg-devel] Commit Message Line Wrapping

2021-10-13 Thread Michael Niedermayer
On Wed, Oct 13, 2021 at 11:46:30AM +, Soft Works wrote: > Hi everybody, > > I have submitted a patch with the following commit message: > (with the patch being about text column alignment) > > - > > Before: > > overlay AVOptions: > x ..FV..

[FFmpeg-devel] [PATCH v1] libavcodec/flac_parser: Validate subframe zero bit and type

2021-10-13 Thread Mattias Wadman
Reduces the risk of finding false frames that happens to have valid values and CRC. Fixes ticket #9185 ffmpeg flac decoder incorrectly finds junk frame https://trac.ffmpeg.org/ticket/9185 --- libavcodec/flac_parser.c | 30 -- 1 file changed, 28 insertions(+), 2 deleti

Re: [FFmpeg-devel] [PATCH] avfilter/vf_lut3d: fix building with --disable-optimizations

2021-10-13 Thread Paul B Mahol
applied ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avformat/westwood_vqa: Store VQFL codebook chunks

2021-10-13 Thread Paul B Mahol
will apply soon ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 2/2] avfilter: add xcorrelate video filter

2021-10-13 Thread Paul B Mahol
will apply soon ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 1/2] avfilter: add limitdiff video filter

2021-10-13 Thread Paul B Mahol
will apply soon ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avfilter/vf_guided: support enhanced guided filter

2021-10-13 Thread Paul B Mahol
Why this filter is being applied at first place at all? It is extraordinary slow and used very slow algorithm and reallocates memory all the time. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To

[FFmpeg-devel] [PATCH v2 1/1] avformat/dump: Print codec level and stream start offsets for input streams

2021-10-13 Thread Soft Works
Signed-off-by: softworkz --- v2: rearrange code to fix warning libavformat/dump.c | 8 1 file changed, 8 insertions(+) diff --git a/libavformat/dump.c b/libavformat/dump.c index 4824965ee9..58bb28d06e 100644 --- a/libavformat/dump.c +++ b/libavformat/dump.c @@ -566,6 +566,9 @@ static v

[FFmpeg-devel] [PATCH v3 1/1] fftools/cmdutils: Print bit depths when executing 'ffmpeg -pix_fmts'

2021-10-13 Thread Soft Works
New output looks like this: Pixel formats: I = Supported Input format for conversion .O... = Supported Output format for conversion ..H.. = Hardware accelerated format ...P. = Paletted format B = Bitstream format FLAGS NAMENB_COMPONENTS BITS_PER_PIXEL BIT_DEPTHS - IO... yu

[FFmpeg-devel] Commit Message Line Wrapping

2021-10-13 Thread Soft Works
Hi everybody, I have submitted a patch with the following commit message: (with the patch being about text column alignment) - Before: overlay AVOptions: x ..FV... set the x expression (default "0") y ..FV... set the

Re: [FFmpeg-devel] [PATCH 1/1] fftools/ffmpeg: Output log message when interactive q command is received

2021-10-13 Thread Gyan Doshi
On 2021-10-13 02:30 pm, Michael Koch wrote: Are those keys listed somewhere in the documentation? Not yet. Press ? to get a list at runtime. Regards, Gyan ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ff

Re: [FFmpeg-devel] [PATCH 1/1] fftools/ffmpeg: Output log message when interactive q command is received

2021-10-13 Thread Michael Koch
Are those keys listed somewhere in the documentation? ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubs

Re: [FFmpeg-devel] [PATCH 2/5] fftools/cmdutils: Print filter input/output formats in help output

2021-10-13 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Paul B Mahol > Sent: Wednesday, October 13, 2021 10:42 AM > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH 2/5] fftools/cmdutils: Print > filter input/output formats in help

Re: [FFmpeg-devel] [PATCH 2/5] fftools/cmdutils: Print filter input/output formats in help output

2021-10-13 Thread Paul B Mahol
On Wed, Oct 13, 2021 at 10:24 AM Soft Works wrote: > > > > -Original Message- > > From: ffmpeg-devel On Behalf Of > > Paul B Mahol > > Sent: Wednesday, October 13, 2021 10:16 AM > > To: FFmpeg development discussions and patches > de...@ffmpeg.org> > > Subject: Re: [FFmpeg-devel] [PATCH

[FFmpeg-devel] [PATCH 1/1] avformat/dump: Print codec level and stream start offsets for input streams

2021-10-13 Thread Soft Works
Signed-off-by: softworkz --- libavformat/dump.c | 9 + 1 file changed, 9 insertions(+) diff --git a/libavformat/dump.c b/libavformat/dump.c index 4824965ee9..17e216bf0f 100644 --- a/libavformat/dump.c +++ b/libavformat/dump.c @@ -562,6 +562,10 @@ static void dump_stream_format(const AVFo

[FFmpeg-devel] [PATCH 1/1] fftools/ffmpeg: Output log message when interactive q command is received

2021-10-13 Thread Soft Works
When viewing logs, it's sometimes useful to be able to see whether execution was ended via q command. Signed-off-by: softworkz --- fftools/ffmpeg.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c index 7545b7c68e..d141f34df9 100644 --- a

[FFmpeg-devel] [PATCH v2 1/1] Print bit depths when executing 'ffmpeg -pix_fmts'

2021-10-13 Thread Soft Works
New output looks like this: Pixel formats: I = Supported Input format for conversion .O... = Supported Output format for conversion ..H.. = Hardware accelerated format ...P. = Paletted format B = Bitstream format FLAGS NAMENB_COMPONENTS BITS_PER_PIXEL BIT_DEPTHS - IO... yu

Re: [FFmpeg-devel] [PATCH 2/5] fftools/cmdutils: Print filter input/output formats in help output

2021-10-13 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Paul B Mahol > Sent: Wednesday, October 13, 2021 10:16 AM > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH 2/5] fftools/cmdutils: Print > filter input/output formats in help

Re: [FFmpeg-devel] [PATCH 2/5] fftools/cmdutils: Print filter input/output formats in help output

2021-10-13 Thread Paul B Mahol
On Wed, Oct 13, 2021 at 9:58 AM Soft Works wrote: > > > > -Original Message- > > From: ffmpeg-devel On Behalf Of > > Soft Works > > Sent: Wednesday, October 13, 2021 9:36 AM > > To: FFmpeg development discussions and patches > de...@ffmpeg.org> > > Subject: Re: [FFmpeg-devel] [PATCH 2/5

Re: [FFmpeg-devel] [PATCH 2/5] fftools/cmdutils: Print filter input/output formats in help output

2021-10-13 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Soft Works > Sent: Wednesday, October 13, 2021 9:36 AM > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH 2/5] fftools/cmdutils: Print > filter input/output formats in help out

Re: [FFmpeg-devel] [PATCH 2/5] fftools/cmdutils: Print filter input/output formats in help output

2021-10-13 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Paul B Mahol > Sent: Wednesday, October 13, 2021 9:27 AM > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH 2/5] fftools/cmdutils: Print > filter input/output formats in help o

Re: [FFmpeg-devel] [PATCH 1/1] Print bit depth when executing 'ffmpeg -pix_fmts'

2021-10-13 Thread Paul B Mahol
On Wed, Oct 13, 2021 at 9:20 AM Soft Works wrote: > > > > -Original Message- > > From: ffmpeg-devel On Behalf Of > > Tobias Rapp > > Sent: Wednesday, October 13, 2021 8:56 AM > > To: ffmpeg-devel@ffmpeg.org > > Subject: Re: [FFmpeg-devel] [PATCH 1/1] Print bit depth when > > executing 'f

Re: [FFmpeg-devel] [PATCH 2/5] fftools/cmdutils: Print filter input/output formats in help output

2021-10-13 Thread Paul B Mahol
scale, extractplanes, alphaextract, waveform, vectorscope. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "uns

Re: [FFmpeg-devel] [PATCH 1/5] avfilter/avfilter: Add avfilter_alloc() and avfilter_query_formats() for initializing filters without a graph

2021-10-13 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Paul B Mahol > Sent: Wednesday, October 13, 2021 9:16 AM > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH 1/5] avfilter/avfilter: Add > avfilter_alloc() and avfilter_query_fo

Re: [FFmpeg-devel] [PATCH 2/5] fftools/cmdutils: Print filter input/output formats in help output

2021-10-13 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Paul B Mahol > Sent: Wednesday, October 13, 2021 9:18 AM > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH 2/5] fftools/cmdutils: Print > filter input/output formats in help o

Re: [FFmpeg-devel] [PATCH 1/1] Print bit depth when executing 'ffmpeg -pix_fmts'

2021-10-13 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Tobias Rapp > Sent: Wednesday, October 13, 2021 8:56 AM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH 1/1] Print bit depth when > executing 'ffmpeg -pix_fmts' > > On 13/10/2021 06:58, Soft Works wrote: > > Ne

Re: [FFmpeg-devel] [PATCH 2/5] fftools/cmdutils: Print filter input/output formats in help output

2021-10-13 Thread Paul B Mahol
what about more complicated filters? ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 1/5] avfilter/avfilter: Add avfilter_alloc() and avfilter_query_formats() for initializing filters without a graph

2021-10-13 Thread Paul B Mahol
On Wed, Oct 13, 2021 at 6:50 AM Soft Works wrote: > The purpose of these additions is for being able to programatically > retrieve > the supported formats of a filter for each input and output without adding > the filter to a graph and creating connections. > That is flawed by definition. > >

Re: [FFmpeg-devel] [PATCH 3/5] avfilter/aphasemeter: add null check

2021-10-13 Thread Paul B Mahol
why is this needed? ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".