Re: [FFmpeg-devel] [PATCH] configure: export pkg-config includedir variable

2021-10-08 Thread Xiang, Haihao
On Fri, 2021-10-08 at 10:32 -0300, James Almer wrote: > Some packages may not define custom cflags, in which case a simple > "pkg-config --cflags" call will return an empty string. > This change will be useful to get a valid include path that can be > used in library checks. > > Signed-off-by: Jam

[FFmpeg-devel] [PATCH] qsvenc_hevc: Enable look ahead with ExtBRC

2021-10-08 Thread Haihao Xiang
From: Daniel Socek Signed-off-by: Daniel Socek Signed-off-by: Haihao Xiang --- libavcodec/qsvenc.c | 3 +++ libavcodec/qsvenc_hevc.c | 1 + 2 files changed, 4 insertions(+) diff --git a/libavcodec/qsvenc.c b/libavcodec/qsvenc.c index 06f55604b5..e21a9b1207 100644 --- a/libavcodec/qsvenc.

Re: [FFmpeg-devel] Revert a patch for v360 filter

2021-10-08 Thread Paul B Mahol
On Fri, Oct 8, 2021 at 5:49 PM Michael Koch wrote: > > Invalid reasoning. Absolute rotations give those issues. > > These issues can easily be avoided by keeping the pitch angle in the -89 > to +89 range, for example. > > Please don't misunderstand me, I'm not against relative rotations. If > you

Re: [FFmpeg-devel] [PATCH 3/4] avcodec/mpeg12dec: Fix usage of init_get_bits() and use init_get_bits8()

2021-10-08 Thread Michael Niedermayer
On Fri, Oct 08, 2021 at 10:33:52PM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavcodec/mpeg12dec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) LGTM thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC78704

Re: [FFmpeg-devel] ARM Hardware Request

2021-10-08 Thread J. Dekker
On 8 Oct 2021, at 10:25, Thilo Borgmann wrote: >> Hi, >> >> I'm writing ARM64 ASM and testing on Apple M1 and Graviton2 N1 devices. >> This, however, is not a good spread of micro-architectures among commonly >> used ARM64 devices. Additional micro-architectures which I would like to >> test a

[FFmpeg-devel] ?????? [PATCH 02/02] libavcodec/: Add the parsing procedure of SVC decoding function based on Temporal scalability for H.264/AVC

2021-10-08 Thread ??????
Dear,   I'm really sorry to disturb you. I sent you two emails on September 23rd, but I haven't received any reply yet. May I ask if you have received my patch --  -- ??:

Re: [FFmpeg-devel] Revert a patch for v360 filter

2021-10-08 Thread Michael Koch
Invalid reasoning. Absolute rotations give those issues. These issues can easily be avoided by keeping the pitch angle in the -89 to +89 range, for example. Please don't misunderstand me, I'm not against relative rotations. If you need relative rotations for your application, feel free to us

Re: [FFmpeg-devel] [PATCH] configure: export pkg-config includedir variable

2021-10-08 Thread James Almer
On 10/8/2021 11:57 AM, Timo Rothenpieler wrote: On 08.10.2021 15:32, James Almer wrote: Some packages may not define custom cflags, in which case a simple "pkg-config --cflags" call will return an empty string. This change will be useful to get a valid include path that can be used in library ch

Re: [FFmpeg-devel] [PATCH] configure: export pkg-config includedir variable

2021-10-08 Thread Timo Rothenpieler
On 08.10.2021 15:32, James Almer wrote: Some packages may not define custom cflags, in which case a simple "pkg-config --cflags" call will return an empty string. This change will be useful to get a valid include path that can be used in library checks. Is that at all a standard thing with pkgc

Re: [FFmpeg-devel] [PATCH 2/5] avformat/imf: CPL processor

2021-10-08 Thread Pierre-Anthony Lemieux
On Thu, Oct 7, 2021 at 1:24 PM Pierre-Anthony Lemieux wrote: > > On Thu, Oct 7, 2021 at 1:03 PM Lynne wrote: > > > > 6 Oct 2021, 02:45 by p...@sandflow.com: > > > > > On Tue, Oct 5, 2021 at 5:03 PM Lynne wrote: > > > > > >> > > >> 5 Oct 2021, 17:22 by p...@sandflow.com: > > >> > > >> > Hi Lynne,

[FFmpeg-devel] [PATCH 4/4] avcodec/videotoolboxenc: use goto end for memory cleanup

2021-10-08 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/videotoolboxenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/videotoolboxenc.c b/libavcodec/videotoolboxenc.c index 93c3898..bac36fd 100644 --- a/libavcodec/videotoolboxenc.c +++ b/libavcodec/videotool

[FFmpeg-devel] [PATCH 3/4] avcodec/mpeg12dec: Fix usage of init_get_bits() and use init_get_bits8()

2021-10-08 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/mpeg12dec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/mpeg12dec.c b/libavcodec/mpeg12dec.c index e6ada1c..09b2902 100644 --- a/libavcodec/mpeg12dec.c +++ b/libavcodec/mpeg12dec.c @@ -2265,7 +2265,7 @@

[FFmpeg-devel] [PATCH 2/4] avcodec/avs3_parser: Fix usage of init_get_bits() and use init_get_bits8()

2021-10-08 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/avs3_parser.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/avs3_parser.c b/libavcodec/avs3_parser.c index 1a05ea0..d04d96a 100644 --- a/libavcodec/avs3_parser.c +++ b/libavcodec/avs3_parser.c @@ -73,7 +7

[FFmpeg-devel] [PATCH 1/4] avcodec/audiotoolboxdec: Fix usage of init_get_bits() and use init_get_bits8()

2021-10-08 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/audiotoolboxdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/audiotoolboxdec.c b/libavcodec/audiotoolboxdec.c index a222cde..9939fef 100644 --- a/libavcodec/audiotoolboxdec.c +++ b/libavcodec/audiotool

[FFmpeg-devel] [PATCH] configure: export pkg-config includedir variable

2021-10-08 Thread James Almer
Some packages may not define custom cflags, in which case a simple "pkg-config --cflags" call will return an empty string. This change will be useful to get a valid include path that can be used in library checks. Signed-off-by: James Almer --- configure | 5 - 1 file changed, 4 insertions(+

Re: [FFmpeg-devel] Revert a patch for v360 filter

2021-10-08 Thread Paul B Mahol
On Fri, Oct 8, 2021 at 2:11 PM Michael Koch wrote: > I'd like to suggest to revert this patch for the v360 filter: > http://ffmpeg.org/pipermail/ffmpeg-cvslog/2020-October/124887.html > > Why should it be reverted? > -- Because after this patch, the yaw, pitch and roll angles have a > different m

Re: [FFmpeg-devel] [PATCH 4/4] fftools/ffmpeg: Remove unnecessary av_packet_unref()

2021-10-08 Thread James Almer
On 10/8/2021 5:14 AM, Andreas Rheinhardt wrote: avcodec_receive_packet() already unreferences the packet on its own. Signed-off-by: Andreas Rheinhardt --- fftools/ffmpeg.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c index 0e38d6d185..14611480f1 1

Re: [FFmpeg-devel] [PATCH 14/20] tests/fate-run: Set bitexact flag for output, too

2021-10-08 Thread James Almer
On 10/7/2021 12:47 PM, Andreas Rheinhardt wrote: Andreas Rheinhardt: James Almer: On 10/1/2021 6:08 PM, Andreas Rheinhardt wrote: Signed-off-by: Andreas Rheinhardt --- One could also do this more generically in the ffmpeg function.   tests/fate-run.sh | 2 +-   1 file changed, 1 insertion(+

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg, ffmpeg_opt: Allocate (In|Out)putStream.pkt early

2021-10-08 Thread James Almer
On 10/8/2021 8:49 AM, Andreas Rheinhardt wrote: Avoids checks lateron in the hot path. Signed-off-by: Andreas Rheinhardt --- fftools/ffmpeg.c | 16 +--- fftools/ffmpeg_opt.c | 4 ++-- 2 files changed, 3 insertions(+), 17 deletions(-) diff --git a/fftools/ffmpeg.c b/fftools

Re: [FFmpeg-devel] Revert a patch for v360 filter

2021-10-08 Thread Paul B Mahol
NAK ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] Revert a patch for v360 filter

2021-10-08 Thread Michael Koch
I'd like to suggest to revert this patch for the v360 filter: http://ffmpeg.org/pipermail/ffmpeg-cvslog/2020-October/124887.html Why should it be reverted? -- Because after this patch, the yaw, pitch and roll angles have a different meaning. If they are set in the command line, they are interpr

Re: [FFmpeg-devel] ARM Hardware Request

2021-10-08 Thread Ming Shun Ho
On Fri, Oct 8, 2021 at 4:25 PM Thilo Borgmann wrote: > > Hi, > > On 8 Oct 2021, at 1:21, J. Dekker wrote: > > > Hi, > > > > I'm writing ARM64 ASM and testing on Apple M1 and Graviton2 N1 > > devices. This, however, is not a good spread of micro-architectures > > among commonly used ARM64 devices.

[FFmpeg-devel] [PATCH] fftools/ffmpeg, ffmpeg_opt: Allocate (In|Out)putStream.pkt early

2021-10-08 Thread Andreas Rheinhardt
Avoids checks lateron in the hot path. Signed-off-by: Andreas Rheinhardt --- fftools/ffmpeg.c | 16 +--- fftools/ffmpeg_opt.c | 4 ++-- 2 files changed, 3 insertions(+), 17 deletions(-) diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c index 14611480f1..9d4f9d7a2b 100644 --- a/f

[FFmpeg-devel] [PATCH 2/2] avfilter: add xcorrelate video filter

2021-10-08 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- doc/filters.texi | 18 ++ libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/vf_convolve.c | 370 +- 4 files changed, 346 insertions(+), 44 deletions(-) diff --git a/doc/filters.texi b/do

[FFmpeg-devel] [PATCH 1/2] avfilter: add limitdiff video filter

2021-10-08 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- doc/filters.texi | 31 libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/vf_limitdiff.c | 370 + 4 files changed, 403 insertions(+) create mode 100644 libavfilter/vf_limitdiff.c

Re: [FFmpeg-devel] [PATCH 3/4] fftools/ffmpeg: Fix crash when flushing non-fully setup output stream

2021-10-08 Thread Paul B Mahol
lgtm ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH v2 3/3] libavfilter/vf_avgblur_vulkan: fix incorrect conditional judgement

2021-10-08 Thread Paul B Mahol
applied ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 1/4] avfilter/avfiltergraph: Fix use-after-free when inserting auto-converter

2021-10-08 Thread Paul B Mahol
LGTM ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] ARM Hardware Request

2021-10-08 Thread Thilo Borgmann
Hi, On 8 Oct 2021, at 1:21, J. Dekker wrote: Hi, I'm writing ARM64 ASM and testing on Apple M1 and Graviton2 N1 devices. This, however, is not a good spread of micro-architectures among commonly used ARM64 devices. Additional micro-architectures which I would like to test are 'High Efficien

[FFmpeg-devel] [PATCH 4/4] fftools/ffmpeg: Remove unnecessary av_packet_unref()

2021-10-08 Thread Andreas Rheinhardt
avcodec_receive_packet() already unreferences the packet on its own. Signed-off-by: Andreas Rheinhardt --- fftools/ffmpeg.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c index 0e38d6d185..14611480f1 100644 --- a/fftools/ffmpeg.c +++ b/fftools/ffmpeg.c

[FFmpeg-devel] [PATCH 3/4] fftools/ffmpeg: Fix crash when flushing non-fully setup output stream

2021-10-08 Thread Andreas Rheinhardt
The output stream's packet may not have been allocated at that point. This happens when quitting in the following command line: $ ./ffmpeg -lavfi abuffer=sample_fmt=u8:sample_rate=48000:channel_layout=stereo -f null - Signed-off-by: Andreas Rheinhardt --- Is there actually a reason that this pac

[FFmpeg-devel] [PATCH 2/4] tests/fate-run: Use DEC_OPTS for additional input, too

2021-10-08 Thread Andreas Rheinhardt
Should fix failures in the cover-art-flac-remux test. Signed-off-by: Andreas Rheinhardt --- Sorry for this; will apply this soon. tests/fate-run.sh | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tests/fate-run.sh b/tests/fate-run.sh index 87b5539296..fbfc0a925d 100755

[FFmpeg-devel] [PATCH 1/4] avfilter/avfiltergraph: Fix use-after-free when inserting auto-converter

2021-10-08 Thread Andreas Rheinhardt
When inserting an auto-resampler, it may be that the configuration of the filters that the auto-resampler is supposed to connect is already partially merged, i.e. converter->inputs[0].incfg.foo and converter->outputs[0].outcfg.foo (where foo is one of formats, samplerates, channel_layouts) can coin

[FFmpeg-devel] [PATCH v5 07/10] qsvenc: support MFX_RATECONTROL_LA_EXT when MFX_VERSION < 2.0

2021-10-08 Thread Haihao Xiang
MFX_RATECONTROL_LA_EXT isn't supported for MFX_VERSION >= 2.0[1][2]. This is in preparation for oneVPL support [1]: https://spec.oneapi.io/versions/latest/elements/oneVPL/source/appendix/VPL_intel_media_sdk.html#msdk-full-name-feature-removals [2]: https://github.com/oneapi-src/oneVPL --- libavc

[FFmpeg-devel] [PATCH v5 10/10] configure: add --enable-libvpl option

2021-10-08 Thread Haihao Xiang
This allows user to build FFmpeg against Intel oneVPL. oneVPL 2.2 is the required minimum version when building Intel oneVPL code. It will fail to run configure script if both libmfx and libvpl are enabled. It is recommended to use oneVPL for new work, even for currently available hardwares [1]

[FFmpeg-devel] [PATCH v5 09/10] qsv: use a new method to create mfx session when using oneVPL

2021-10-08 Thread Haihao Xiang
In oneVPL, MFXLoad() and MFXCreateSession() are required to create a workable mfx session[1] Add AccelerationMode config filter for D3D9/D3D11 session (galinart) The default device is changed to d3d11va for oneVPL when both d3d11va and dxva2 are enabled on Microsoft Windows This is in preparatio

[FFmpeg-devel] [PATCH v5 06/10] qsvenc: support multi-frame encode when MFX_VERSION < 2.0

2021-10-08 Thread Haihao Xiang
Multi-frame encode isn't supported for MFX_VERSION >= 2.0[1][2]. This is in preparation for oneVPL support [1]: https://spec.oneapi.io/versions/latest/elements/oneVPL/source/appendix/VPL_intel_media_sdk.html#msdk-full-name-feature-removals [2]: https://github.com/oneapi-src/oneVPL --- libavcodec

[FFmpeg-devel] [PATCH v5 02/10] configure: fix the check for MFX_CODEC_VP9

2021-10-08 Thread Haihao Xiang
The data structures for VP9 in mfxvp9.h is wrapped by MFX_VERSION_NEXT, which means those data structures have never been used in a public release. Actually MFX_CODEC_VP9 and other VP9 stuffs is added in mfxstructures.h. In addition, mfxdefs.h is included in mfxvp9.h, so we may use the check in thi

[FFmpeg-devel] [PATCH v5 08/10] qsv: support OPAQUE memory when MFX_VERSION < 2.0

2021-10-08 Thread Haihao Xiang
OPAQUE memory isn't supported for MFX_VERSION >= 2.0[1][2]. This is in preparation for oneVPL support [1]: https://spec.oneapi.io/versions/latest/elements/oneVPL/source/appendix/VPL_intel_media_sdk.html#msdk-full-name-feature-removals [2]: https://github.com/oneapi-src/oneVPL --- libavcodec/qsv.

[FFmpeg-devel] [PATCH v5 05/10] qsv: build audio related code when MFX_VERSION < 2.0

2021-10-08 Thread Haihao Xiang
Audio isn't supported for MFX_VERSION >= 2.0[1][2]. This is in preparation for oneVPL support [1]: https://spec.oneapi.io/versions/latest/elements/oneVPL/source/appendix/VPL_intel_media_sdk.html#msdk-full-name-feature-removals [2]: https://github.com/oneapi-src/oneVPL --- libavcodec/qsv.c |

[FFmpeg-devel] [PATCH v5 01/10] configure: ensure --enable-libmfx uses libmfx 1.x

2021-10-08 Thread Haihao Xiang
Intel's oneVPL is a successor to MediaSDK, but removed some obsolete features of MediaSDK[1]. Some early versions of oneVPL still uses libmfx as library name[2], however some of obsolete features, including OPAQUE memory, multi-frame encode, user plugins and LA_EXT rate control mode etc, have been

[FFmpeg-devel] [PATCH v5 04/10] qsv: load user plugin for MFX_VERSION < 2.0

2021-10-08 Thread Haihao Xiang
User plugin isn't supported for MFX_VERSION >= 2.0[1][2]. This is in preparation for oneVPL Support [1]: https://spec.oneapi.io/versions/latest/elements/oneVPL/source/appendix/VPL_intel_media_sdk.html#msdk-full-name-feature-removals [2]: https://github.com/oneapi-src/oneVPL --- libavcodec/qsv.c

[FFmpeg-devel] [PATCH v5 03/10] qsv: remove mfx/ prefix from mfx headers

2021-10-08 Thread Haihao Xiang
The following Cflags has been added to libmfx.pc, so mfx/ prefix is no longer needed when including mfx headers in FFmpeg. Cflags: -I${includedir} -I${includedir}/mfx Some old versions of libmfx have the following Cflags in libmfx.pc Cflags: -I${includedir} We may add -I${includedir}/mfx to

[FFmpeg-devel] [PATCH v5 00/10] make QSV works with the Intel's oneVPL

2021-10-08 Thread Haihao Xiang
The oneAPI Video Processing Library (oneVPL) is a single interface for encode, decode and video processing[1]. oneVPL is a successor to Intel(R) Media SDK, but removed obsolete features. Intel(R) Media SDK lifetime comes to an end now, new features for new Intel Gen platforms will be supported in o