Re: [FFmpeg-devel] [PATCH v3 1/2] avcodec/codec_par: Add codec properties field to AVCodecParameters

On Wed, Oct 6, 2021 at 8:45 AM Soft Works wrote: > diff --git a/libavcodec/codec_par.h b/libavcodec/codec_par.h > index 10cf79dff1..42ed8deb13 100644 > --- a/libavcodec/codec_par.h > +++ b/libavcodec/codec_par.h > @@ -198,6 +198,10 @@ typedef struct AVCodecParameters { > * Audio only. Number

[FFmpeg-devel] [PATCH v3 2/2] ffprobe: Use codec properties value from AvCodecParameters

Signed-off-by: softworkz --- fftools/ffprobe.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c index 90e895bbf9..f5c6335a13 100644 --- a/fftools/ffprobe.c +++ b/fftools/ffprobe.c @@ -2655,9 +2655,9 @@ static int show_stream(WriterConte

[FFmpeg-devel] [PATCH v3 1/2] avcodec/codec_par: Add codec properties field to AVCodecParameters

This fixes incorrect display of closed_captions property in ffprobe. Repro Example: ffprobe -show_entries stream=closed_captions:disposition=:side_data= "http://streams.videolan.org/streams/ts/CC/NewsStream-608-ac3.ts"; While the codec string included "Closed Captions", the stream data is showe

Re: [FFmpeg-devel] [PATCH] avcodec/amr_parser: passthrough if channels is unknown

James Almer: > On 10/5/2021 5:51 PM, Michael Niedermayer wrote: >> Fixes: division by 0 >> Fixes: >> 39562/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_AMRWB_fuzzer-5448834960982016 >> >> Fixes: >> 39589/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_AMRWB_fuzzer-6119205334810624 >> >> >> F

[FFmpeg-devel] [PATCH v6 11/11] libavformat/asfdec: Fix variable types and add checks for unsupported values

Signed-off-by: softworkz --- libavformat/asfdec_f.c | 168 ++--- 1 file changed, 108 insertions(+), 60 deletions(-) diff --git a/libavformat/asfdec_f.c b/libavformat/asfdec_f.c index b8140a6d57..c7141f6da1 100644 --- a/libavformat/asfdec_f.c +++ b/libavformat/

[FFmpeg-devel] [PATCH v6 10/11] libavformat/asfdec: Fix parameter type in asf_read_stream_propertie()

Signed-off-by: softworkz --- libavformat/asfdec_f.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/asfdec_f.c b/libavformat/asfdec_f.c index 024d77903b..b8140a6d57 100644 --- a/libavformat/asfdec_f.c +++ b/libavformat/asfdec_f.c @@ -323,7 +323,7 @@ static int asf_

[FFmpeg-devel] [PATCH v6 09/11] libavformat/asfdec: Ensure variables are initialized

Signed-off-by: softworkz --- libavformat/asfdec_f.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/asfdec_f.c b/libavformat/asfdec_f.c index 8283f245ab..024d77903b 100644 --- a/libavformat/asfdec_f.c +++ b/libavformat/asfdec_f.c @@ -968,6 +968,7 @@ static int asf_get_packet(AVFor

[FFmpeg-devel] [PATCH v6 08/11] libavformat/asfdec: Remove variable redefinition in inner scope

Signed-off-by: softworkz --- libavformat/asfdec_f.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libavformat/asfdec_f.c b/libavformat/asfdec_f.c index a7b5ffe465..8283f245ab 100644 --- a/libavformat/asfdec_f.c +++ b/libavformat/asfdec_f.c @@ -1181,7 +1181,7 @@ static int

[FFmpeg-devel] [PATCH v6 07/11] libavformat/asfdec: Fix macro definition and use

Signed-off-by: softworkz --- libavformat/asfdec_f.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/libavformat/asfdec_f.c b/libavformat/asfdec_f.c index e87c78cd6c..a7b5ffe465 100644 --- a/libavformat/asfdec_f.c +++ b/libavformat/asfdec_f.c @@ -896,

[FFmpeg-devel] [PATCH v6 06/11] libavformat/asfdec: Remove unused parameters

Signed-off-by: softworkz --- libavformat/asfdec_f.c | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/libavformat/asfdec_f.c b/libavformat/asfdec_f.c index 4c898ab3f2..e87c78cd6c 100644 --- a/libavformat/asfdec_f.c +++ b/libavformat/asfdec_f.c @@

[FFmpeg-devel] [PATCH v6 05/11] libavformat/asfdec: Implement parsing of GUID values

Signed-off-by: softworkz --- libavformat/asfdec_f.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/libavformat/asfdec_f.c b/libavformat/asfdec_f.c index 58c424b565..4c898ab3f2 100644 --- a/libavformat/asfdec_f.c +++ b/libavformat/asfdec_f.c @@ -280,9 +280,12 @@ stati

[FFmpeg-devel] [PATCH v6 04/11] libavformat/asfdec: Fixing get_tag

These three are closely related and can't be separated easily: In get_tag, the code was adding 22 bytes (in order to allow it to hold 64bit numbers as string) to the value len for creating creating a buffer. This was unnecessarily imposing a size-constraint on the value_len parameter. The code in

[FFmpeg-devel] [PATCH v6 03/11] libavformat/asfdec: Fix type of value_len

The value_len is an uint32 not an int32 per spec. That value must not be truncated, neither by casting to int, nor by any conditional checks, because at the end of get_tag, this value is needed to move forward in parsing. When the len value gets modified, the parsing may break. Signed-off-by: soft

[FFmpeg-devel] [PATCH v6 02/11] libavformat/asfdec: Fix get_value return type and add checks for unsupported values

get_value had a return type of int, which means that reading QWORDS (case 4) was broken due to truncation of the result from avio_rl64(). Signed-off-by: softworkz --- libavformat/asfdec_f.c | 38 +- 1 file changed, 29 insertions(+), 9 deletions(-) diff --git

[FFmpeg-devel] [PATCH v6 01/11] libavformat/asf: Fix handling of byte array length values

The spec allows attachment sizes of up to UINT32_MAX while we can handle only sizes up to INT32_MAX (in downstream code). The debug.assert in get_tag didn't really address this, and truncating the value_len in calling methods cannot be used because the length value is required in order to continue

[FFmpeg-devel] [PATCH v2] avfilter/vf_lut3d: add x86-optimized tetrahedral interpolation

From: Mark Reid I spotted an interesting pattern that I didn't see before that leads to the implementation being faster. The bit shifting table I was using before is no longer needed, and was able to remove quite a few lines.  I also add use of FMA on the AVX2 version. f32 1920x1080 1 thread w

[FFmpeg-devel] [PATCH v2 2/2] ffprobe: Fix incorrect display of closed_captions property

Repro Example: ffprobe -show_entries stream=closed_captions:disposition=:side_data= "http://streams.videolan.org/streams/ts/CC/NewsStream-608-ac3.ts"; While the codec string includes "Closed Captions", the stream data is showing: closed_captions=0 The test ref was incorrect as the test media fi

[FFmpeg-devel] [PATCH v2 1/2] avcodec/codec_par: Add codec properties field to AVCodecParameters

Signed-off-by: softworkz --- v2: include codec properties in AVCodecParameters instead of adding an API to retrieve it doc/APIchanges | 3 +++ libavcodec/codec_par.c | 2 ++ libavcodec/codec_par.h | 4 libavcodec/version.h | 2 +- 4 files changed, 10 insertions(+), 1 deletion(-)

Re: [FFmpeg-devel] [PATCH 2/5] avformat/imf: CPL processor

On Tue, Oct 5, 2021 at 5:03 PM Lynne wrote: > > 5 Oct 2021, 17:22 by p...@sandflow.com: > > > Hi Lynne, > > > > Can you be more specific? > > > > The file header we used look consistent with the header of other > > BSD-licensed files, like aacdec.c. > > > > Thanks, > > > > -- Pierre > > > > On Thu

Re: [FFmpeg-devel] [PATCH 2/5] avformat/imf: CPL processor

5 Oct 2021, 17:22 by p...@sandflow.com: > Hi Lynne, > > Can you be more specific? > > The file header we used look consistent with the header of other > BSD-licensed files, like aacdec.c. > > Thanks, > > -- Pierre > > On Thu, Sep 30, 2021 at 6:40 AM Lynne wrote: > >> >> 29 Sept 2021, 22:47 by p..

[FFmpeg-devel] [PATCH] avformat/http: parse Content-Range responses with unknown document size

From: Aman Karmani The HTTP spec allows '*' for document size in Content-Range response headers, to specify that the file size is unknown: Content-Range: -/ Content-Range: -/* Content-Range: */ In the case where the filesize is unknown, this patch keeps track of a new fileend va

[FFmpeg-devel] [PATCH v2 1/1] avformat: Add probe_streams option

Allow user to disable codec probing: - spdif (and s337m incl. s-adm in the future) is not sub-demuxed and may pass-through to a muxer - disable any stream probing in wav files (dts detection). - mpeg-ts files missing PAT/PMT are considered invalid. Signed-off-by: Nicolas Gaullier --- doc/forma

[FFmpeg-devel] [PATCH v2 0/1] Add-probe_streams-option

This V2 is just a rebase. See my post yesterday for details. Nicolas Gaullier (1): avformat: Add probe_streams option doc/formats.texi| 3 +++ libavformat/avformat.h | 9 + libavformat/mpeg.c | 5 +++-- libavformat/mpegts.c| 10 ++ libavform

Re: [FFmpeg-devel] [PATCH] avcodec/amr_parser: passthrough if channels is unknown

On Tue, Oct 5, 2021 at 11:03 PM James Almer wrote: > On 10/5/2021 5:51 PM, Michael Niedermayer wrote: > > Fixes: division by 0 > > Fixes: > 39562/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_AMRWB_fuzzer-5448834960982016 > > Fixes: > 39589/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_AM

Re: [FFmpeg-devel] [PATCH] avcodec/amr_parser: passthrough if channels is unknown

On 10/5/2021 5:51 PM, Michael Niedermayer wrote: Fixes: division by 0 Fixes: 39562/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_AMRWB_fuzzer-5448834960982016 Fixes: 39589/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_AMRWB_fuzzer-6119205334810624 Found-by: continuous fuzzing process

Re: [FFmpeg-devel] [PATCH] avcodec/amr_parser: passthrough if channels is unknown

lgtm ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH 8/8] avfilter/vf_thumbnail_cuda: Reindent after the previous commit

Signed-off-by: Andreas Rheinhardt --- libavfilter/vf_thumbnail_cuda.c | 25 - 1 file changed, 12 insertions(+), 13 deletions(-) diff --git a/libavfilter/vf_thumbnail_cuda.c b/libavfilter/vf_thumbnail_cuda.c index 7c86203227..c8dd905123 100644 --- a/libavfilter/vf_thumbnai

[FFmpeg-devel] [PATCH 7/8] avfilter/vf_thumbnail_cuda: Fix segfaults on uninit

Uninit crashed if an array containing frames could not be allocated or config_props() has never been called. Signed-off-by: Andreas Rheinhardt --- libavfilter/vf_thumbnail_cuda.c | 5 + 1 file changed, 5 insertions(+) diff --git a/libavfilter/vf_thumbnail_cuda.c b/libavfilter/vf_thumbnail_c

[FFmpeg-devel] [PATCH 6/8] avfilter/tests/filtfmts: Check for existence of formats/channel layouts

Fixes segfaults with filters that either return AVERROR(EAGAIN) (or another error) or that do not set everything and rely on filter_query_formats() to set the rest. Signed-off-by: Andreas Rheinhardt --- libavfilter/tests/filtfmts.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) dif

[FFmpeg-devel] [PATCH 5/8] avfilter/vf_scale: Reindentation

Signed-off-by: Andreas Rheinhardt --- libavfilter/vf_scale.c | 45 +- 1 file changed, 23 insertions(+), 22 deletions(-) diff --git a/libavfilter/vf_scale.c b/libavfilter/vf_scale.c index 993fd18620..44f85cb019 100644 --- a/libavfilter/vf_scale.c +++ b/liba

[FFmpeg-devel] [PATCH 4/8] avfilter/vf_scale: Remove always-true checks

Signed-off-by: Andreas Rheinhardt --- libavfilter/vf_scale.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/libavfilter/vf_scale.c b/libavfilter/vf_scale.c index 5411289894..993fd18620 100644 --- a/libavfilter/vf_scale.c +++ b/libavfilter/vf_scale.c @@ -344,7 +344,6 @@

[FFmpeg-devel] [PATCH 3/8] avfilter/vf_transpose: Don't call av_pix_fmt_desc_get() twice

Signed-off-by: Andreas Rheinhardt --- libavfilter/vf_transpose.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavfilter/vf_transpose.c b/libavfilter/vf_transpose.c index b0354b938f..f9f0d70cd5 100644 --- a/libavfilter/vf_transpose.c +++ b/libavfilter/vf_transpose.c @@

[FFmpeg-devel] [PATCH 2/8] examples/remuxing: Fix use of uninitialized value

Fixes Coverity ticket 1492326. Regression since 53f374c08d5cc97158c17ea34b1c8ee0116c0578. Signed-off-by: Andreas Rheinhardt --- Sorry for this. doc/examples/remuxing.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/examples/remuxing.c b/doc/examples/remuxing.c index 9ff

[FFmpeg-devel] [PATCH] avcodec/amr_parser: passthrough if channels is unknown

Fixes: division by 0 Fixes: 39562/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_AMRWB_fuzzer-5448834960982016 Fixes: 39589/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_AMRWB_fuzzer-6119205334810624 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/proj

[FFmpeg-devel] [PATCH 1/8] avfilter/tests/filtfmts: Replace macro by ordinary function

This is possible now that AVFilterFormatsConfig exists. Signed-off-by: Andreas Rheinhardt --- libavfilter/tests/filtfmts.c | 77 1 file changed, 42 insertions(+), 35 deletions(-) diff --git a/libavfilter/tests/filtfmts.c b/libavfilter/tests/filtfmts.c index

Re: [FFmpeg-devel] [PATCH] avcodec/rasc: Fix potential use of uninitialized value

Andreas Rheinhardt: > Fixes Coverity issue #1439566. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/rasc.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavcodec/rasc.c b/libavcodec/rasc.c > index 7fedf73878..b328e219bb 100644 > --- a/libavcodec/rasc.c > +++ b/libavcodec/

Re: [FFmpeg-devel] [PATCH 4/4] libavfilter/vf_avgblur_vulkan: fix incorrect conditional judgement

Jianhua wrote: > Signed-off-by: Wu Jianhua intel.com> > --- > libavfilter/vf_avgblur_vulkan.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavfilter/vf_avgblur_vulkan.c b/libavfilter/vf_avgblur_vulkan.c > index

Re: [FFmpeg-devel] [PATCH 2/5] avformat/imf: CPL processor

Hi Lynne, Can you be more specific? The file header we used look consistent with the header of other BSD-licensed files, like aacdec.c. Thanks, -- Pierre On Thu, Sep 30, 2021 at 6:40 AM Lynne wrote: > > 29 Sept 2021, 22:47 by p...@sandflow.com: > > > From: Pierre-Anthony Lemieux > > > > Sign

Re: [FFmpeg-devel] [PATCH 004/218] avfilter: Replace query_formats callback with union of list and callback

Andreas Rheinhardt (12021-09-30): > If one looks at the many query_formats callbacks in existence, > one will immediately recognize that there is one type of default > callback for video and a slightly different default callback for > audio: It is "return ff_set_common_formats_from_list(ctx, pix_fm

Re: [FFmpeg-devel] [PATCH 003/218] avfilter/formats: Add function to create AVFilterFormats with one entry

Andreas Rheinhardt (12021-09-30): > Most instances ff_add_formats() actually only ever add one format; > this function can be used to simplify those callers. > > Signed-off-by: Andreas Rheinhardt > --- > libavfilter/formats.c | 6 ++ > libavfilter/formats.h | 6 ++ > 2 files changed, 12

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/wmaprodec: Do not initialize unused variable to out of array value

LGTM ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".