It has already been checked immediately before that said
AVDictionaryEntry exists; checking again is redundant.
Furthermore, av_hwdevice_find_type_by_name() requires its argument
to be non-NULL, so adding a codepath that automatically calls it
with that parameter is nonsense. The same goes for the
This av_buffer_create() does nothing but leak an AVBuffer and an
AVBufferRef (except on allocation error).
Fixes Coverity issue 1491393.
Signed-off-by: Andreas Rheinhardt
---
libavutil/hwcontext_qsv.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/libavutil/hwcontext_qsv.c b/libavutil/hwc
It makes the cleanup code smaller (and reduces the amount of
allocations).
Signed-off-by: Andreas Rheinhardt
---
Better naming suggestions for the structures welcome.
One could also stop using an av_fifo altogether and use an ordinary
array (that is only allocated once) with FIFO semantics.
Or o
Freeing the new H.264 specific fields has been forgotten.
(This leak only appears in case the encoder has not been completely
drained.)
Signed-off-by: Andreas Rheinhardt
---
libavcodec/qsvenc.c | 8
1 file changed, 8 insertions(+)
diff --git a/libavcodec/qsvenc.c b/libavcodec/qsvenc.c
Up until now, it has only been freed when the QSVFrame is reused,
so that the last one contained in it leaked at the end.
Signed-off-by: Andreas Rheinhardt
---
libavcodec/qsvenc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/libavcodec/qsvenc.c b/libavcodec/qsvenc.c
index 66f79bb021..e5d0
Since commit 3bbe0c210b05fc6fbd7b1d4bbd8479db7f2cf957, the Payloads
array of every QSVFrame leaks as soon as the frame is reused;
the leak is small and not very noticeable, but if there is an attempt
to use said array the ensuing crash is much more noticeable.
This happens when encoding H.264 with
On 26/9/21 1:09 pm, Andreas Rheinhardt wrote:
This avoids a -Wstringop-truncation warning from GCC which takes
issue with the fact that the destination might not be NUL terminated.
Signed-off-by: Andreas Rheinhardt
---
libavformat/argo_asf.c | 20 +++-
1 file changed, 7 in
> -Original Message-
> From: ffmpeg-devel On Behalf Of
> Soft Works
> Sent: Sunday, 26 September 2021 01:00
> To: FFmpeg development discussions and patches de...@ffmpeg.org>
> Subject: Re: [FFmpeg-devel] Scaling PAL8 images with alpha
>
>
>
> > -Original Message-
> > From: f
Usage example:
ffmpeg -y -loglevel verbose -i "..\fate-suite\apng\o_sample.png"
-filter_complex "elbg=pal8=1:use_alpha=1" -frames:v 1 out.png
Signed-off-by: softworkz
---
doc/filters.texi | 4
libavfilter/vf_elbg.c | 25 -
2 files changed, 20 insertions(+), 9
This avoids a -Wstringop-truncation warning from GCC which takes
issue with the fact that the destination might not be NUL terminated.
Signed-off-by: Andreas Rheinhardt
---
libavformat/argo_asf.c | 20 +++-
1 file changed, 7 insertions(+), 13 deletions(-)
diff --git a/libavforma
Usage example:
ffmpeg -y -loglevel verbose -i "..\fate-suite\apng\o_sample.png"
-filter_complex
"split[split1][split2];[split1]palettegen=max_colors=254:use_alpha=1[pal1];[split2][pal1]paletteuse=use_alpha=1"
-frames:v 1 out.png
Signed-off-by: softworkz
---
doc/filters.texi| 8
> -Original Message-
> From: ffmpeg-devel On Behalf Of
> Michael Niedermayer
> Sent: Saturday, 25 September 2021 22:47
> To: FFmpeg development discussions and patches de...@ffmpeg.org>
> Subject: Re: [FFmpeg-devel] Scaling PAL8 images with alpha
>
> On Sat, Sep 25, 2021 at 10:34:32PM
Up until now, the list of pixfmts is reallocated every time an entry
is added to it; there are currently 196 pixel formats, so this matters:
It causes 5541704 calls to av_realloc_array() in a typical FATE run,
which is the majority for said function (8095768 calls) and even
a large chunk of the cal
Up until now, it has returned the AVFilterFormats list via
an AVFilterFormats** parameter; the actual return value was an int
that was always AVERROR(ENOMEM) on error. The AVFilterFormats**
argument was a pure output parameter which was only documented
by naming the parameter rfmts. Yet nevertheles
Signed-off-by: Andreas Rheinhardt
---
libavfilter/vf_swaprect.c | 18 +++---
1 file changed, 7 insertions(+), 11 deletions(-)
diff --git a/libavfilter/vf_swaprect.c b/libavfilter/vf_swaprect.c
index 4a5f4a12a6..fff9b53dc4 100644
--- a/libavfilter/vf_swaprect.c
+++ b/libavfilter/vf_sw
On Mon, Sep 20, 2021 at 5:44 PM James Zern wrote:
>
> On Wed, Sep 8, 2021 at 6:46 PM James Zern wrote:
> >
> > On Mon, Aug 30, 2021 at 5:11 AM Maryla
> > wrote:
> > >
> > > When a color indexing transform with 16 or fewer colors is used,
> > > WebP uses "pixel packing", i.e. storing several pix
Michael Niedermayer:
> On Fri, Sep 24, 2021 at 06:37:11PM +0200, Andreas Rheinhardt wrote:
>> Signed-off-by: Andreas Rheinhardt
>> ---
>> libavcodec/tests/avcodec.c | 11 ++-
>> 1 file changed, 10 insertions(+), 1 deletion(-)
>
> This and also the other patches adding checks LGTM
>
The
Andreas Rheinhardt:
> Fixes memleaks in case the trailer is never written.
>
> Signed-off-by: Andreas Rheinhardt
> ---
> libavformat/chromaprint.c | 7 ---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/libavformat/chromaprint.c b/libavformat/chromaprint.c
> index 399de7
On Sat, Sep 18, 2021 at 08:01:38PM +1000, Peter Ross wrote:
> ---
> libavcodec/siren.c | 6 +-
> 1 file changed, 5 insertions(+), 1 deletion(-)
probably ok
thx
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
The misfortune of the wise is better than the
On Sat, Sep 25, 2021 at 10:34:32PM +0200, Michael Niedermayer wrote:
> On Sat, Sep 25, 2021 at 03:46:25PM +, Soft Works wrote:
> >
> >
> > > -Original Message-
> > > From: ffmpeg-devel On Behalf Of
> > > Michael Niedermayer
> > > Sent: Saturday, 25 September 2021 16:30
> > > To: FFmp
On Sat, Sep 25, 2021 at 03:46:25PM +, Soft Works wrote:
>
>
> > -Original Message-
> > From: ffmpeg-devel On Behalf Of
> > Michael Niedermayer
> > Sent: Saturday, 25 September 2021 16:30
> > To: FFmpeg development discussions and patches > de...@ffmpeg.org>
> > Subject: Re: [FFmpeg-
Signed-off-by: Paul B Mahol
---
libavfilter/vf_selectivecolor.c | 41 +++--
1 file changed, 29 insertions(+), 12 deletions(-)
diff --git a/libavfilter/vf_selectivecolor.c b/libavfilter/vf_selectivecolor.c
index 9d789a6d8b..398d4bec0d 100644
--- a/libavfilter/vf_select
Signed-off-by: Paul B Mahol
---
libavfilter/vf_selectivecolor.c | 15 +--
1 file changed, 9 insertions(+), 6 deletions(-)
diff --git a/libavfilter/vf_selectivecolor.c b/libavfilter/vf_selectivecolor.c
index ebbba9157f..9d789a6d8b 100644
--- a/libavfilter/vf_selectivecolor.c
+++ b/lib
> -Original Message-
> From: ffmpeg-devel On Behalf Of
> Paul B Mahol
> Sent: Saturday, 25 September 2021 17:51
> To: FFmpeg development discussions and patches de...@ffmpeg.org>
> Subject: Re: [FFmpeg-devel] Scaling PAL8 images with alpha
>
> On Sat, Sep 25, 2021 at 5:46 PM Soft Works
Also fixes incorrect parsing of dv_bl_signal_compatibility_id,
which was often set to zero instead of the actual value, for mpegts only.
Signed-off-by: quietvoid
---
libavformat/mpegts.c | 44
1 file changed, 4 insertions(+), 40 deletions(-)
diff --g
Read at most 24 bytes, but in reality only 5 bytes are used for parsing.
The rest of the bytes are reserved in the specification.
Signed-off-by: quietvoid
---
libavformat/mov.c | 51 ++-
1 file changed, 10 insertions(+), 41 deletions(-)
diff --git a/l
When muxing to Matroska, write the Block Additional Mapping
if there is AV_PKT_DATA_DOVI_CONF side data present.
Most of the code was implemented by Plex developers.
Since the type (dvcC/dvvC) can change depending on the caller,
the logic was separated from ff_isom_put_dvcc_dvvc.
In this case, mov
The parsing was implemented in a new dovi_isom file for the
unification of the mov/mpegts DOVI parsing into one function, in a following
patch.
Most of the Matroska elements implementation was done by Plex developers.
Signed-off-by: quietvoid
---
libavformat/Makefile | 2 +-
libavformat/
Most of the implementation was done by the Plex developers.
Signed-off-by: quietvoid
---
libavformat/matroska.h| 7 +++
libavformat/matroskadec.c | 44 +--
2 files changed, 49 insertions(+), 2 deletions(-)
diff --git a/libavformat/matroska.h b/libavf
On Sat, Sep 25, 2021 at 5:46 PM Soft Works wrote:
>
>
> > -Original Message-
> > From: ffmpeg-devel On Behalf Of
> > Michael Niedermayer
> > Sent: Saturday, 25 September 2021 16:30
> > To: FFmpeg development discussions and patches > de...@ffmpeg.org>
> > Subject: Re: [FFmpeg-devel] Sca
> -Original Message-
> From: ffmpeg-devel On Behalf Of
> Michael Niedermayer
> Sent: Saturday, 25 September 2021 16:30
> To: FFmpeg development discussions and patches de...@ffmpeg.org>
> Subject: Re: [FFmpeg-devel] Scaling PAL8 images with alpha
>
> On Sat, Sep 25, 2021 at 10:23:56AM
On Sat, Sep 25, 2021 at 10:23:56AM +0200, Hendrik Leppkes wrote:
> On Sat, Sep 25, 2021 at 5:00 AM Soft Works wrote:
> >
> >
> >
> > > -Original Message-
> > > From: ffmpeg-devel On Behalf Of
> > > Soft Works
> > > Sent: Friday, 24 September 2021 19:03
> > > To: FFmpeg development discuss
On Sat, Sep 25, 2021 at 04:51:58PM +0300, Jan Ekström wrote:
> On Sat, Sep 25, 2021 at 4:35 PM wrote:
> >
> > On Sat, Sep 25, 2021 at 03:35:53PM +0300, Jan Ekström wrote:
> > > On Thu, Sep 23, 2021 at 6:08 PM wrote:
> > > >
> > > > On Thu, Sep 23, 2021 at 05:11:49PM +0300, Jan Ekström wrote:
> >
From: Limin Wang
SVT-AV1 seems to have switched their default from CQP to CRF in February,
so enforce the controlling option accordingly.
Signed-off-by: Limin Wang
---
libavcodec/libsvtav1.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/libavcodec/libsvtav1.c b/libavcodec/libsvtav1.c
ind
From: Limin Wang
Signed-off-by: Limin Wang
---
doc/encoders.texi | 20 +++-
1 file changed, 19 insertions(+), 1 deletion(-)
diff --git a/doc/encoders.texi b/doc/encoders.texi
index 8fccd73..8a7589c 100644
--- a/doc/encoders.texi
+++ b/doc/encoders.texi
@@ -1750,12 +1750,30 @@ Y
On Sat, Sep 25, 2021 at 4:35 PM wrote:
>
> On Sat, Sep 25, 2021 at 03:35:53PM +0300, Jan Ekström wrote:
> > On Thu, Sep 23, 2021 at 6:08 PM wrote:
> > >
> > > On Thu, Sep 23, 2021 at 05:11:49PM +0300, Jan Ekström wrote:
> > > > On Thu, Sep 23, 2021 at 4:46 PM Christopher Degawa
> > > > wrote:
>
On Sat, Sep 25, 2021 at 03:35:53PM +0300, Jan Ekström wrote:
> On Thu, Sep 23, 2021 at 6:08 PM wrote:
> >
> > On Thu, Sep 23, 2021 at 05:11:49PM +0300, Jan Ekström wrote:
> > > On Thu, Sep 23, 2021 at 4:46 PM Christopher Degawa
> > > wrote:
> > > >
> > > > On Sun, Sep 19, 2021 at 2:02 PM Christo
On Sat, Sep 25, 2021 at 03:59:20PM +0300, Jan Ekström wrote:
> On Sat, Sep 25, 2021 at 3:49 PM wrote:
> >
> > On Sat, Sep 25, 2021 at 01:00:20PM +0300, Jan Ekström wrote:
> > > On Sat, Sep 18, 2021 at 4:27 AM wrote:
> > > >
> > > > From: Limin Wang
> > > >
> > > > Signed-off-by: Limin Wang
> >
On Sat, Sep 25, 2021 at 03:14:34PM +0300, Jan Ekström wrote:
> On Sat, Sep 18, 2021 at 4:27 AM wrote:
> >
> > From: Limin Wang
> >
> > Signed-off-by: Limin Wang
> > ---
>
> Probably something like "avcodec/libsvtav1: fix value range for
> rc_mode" is a bit better as a commit message?
OK, will
On Sat, Sep 25, 2021 at 03:06:23PM +0300, Jan Ekström wrote:
> On Sat, Sep 18, 2021 at 4:27 AM wrote:
> >
> > From: Limin Wang
> >
> > Signed-off-by: Limin Wang
> > ---
>
> Commit message should probably be something along the lines of
>
> """
> avcodec/libsvtav1: properly enforce CQP mode whe
On Sat, Sep 25, 2021 at 02:32:43PM +0300, Jan Ekström wrote:
> On Sat, Sep 18, 2021 at 4:27 AM wrote:
> >
> > From: Limin Wang
> >
> > Signed-off-by: Limin Wang
> > ---
>
> Hi,
>
> "doc/encoders: add available values for libsvtav1 options"
>
> would possibly be better as a commit message?
Su
On Sat, Sep 25, 2021 at 3:49 PM wrote:
>
> On Sat, Sep 25, 2021 at 01:00:20PM +0300, Jan Ekström wrote:
> > On Sat, Sep 18, 2021 at 4:27 AM wrote:
> > >
> > > From: Limin Wang
> > >
> > > Signed-off-by: Limin Wang
> >
> > I'd prefer the wording "fix duplicate definition of caps_internal",
> > b
On Sat, Sep 25, 2021 at 01:00:20PM +0300, Jan Ekström wrote:
> On Sat, Sep 18, 2021 at 4:27 AM wrote:
> >
> > From: Limin Wang
> >
> > Signed-off-by: Limin Wang
>
> I'd prefer the wording "fix duplicate definition of caps_internal",
> but otherwise this patch is LGTM.
No problem, will update w
On Thu, Sep 23, 2021 at 6:08 PM wrote:
>
> On Thu, Sep 23, 2021 at 05:11:49PM +0300, Jan Ekström wrote:
> > On Thu, Sep 23, 2021 at 4:46 PM Christopher Degawa
> > wrote:
> > >
> > > On Sun, Sep 19, 2021 at 2:02 PM Christopher Degawa
> > > wrote:
> > >
> > > >
> > > >
> > > > On Fri, Sep 17, 202
On Sat, Sep 18, 2021 at 4:27 AM wrote:
>
> From: Limin Wang
>
> Signed-off-by: Limin Wang
> ---
Probably something like "avcodec/libsvtav1: fix value range for
rc_mode" is a bit better as a commit message?
> libavcodec/libsvtav1.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> di
On Sat, Sep 18, 2021 at 4:27 AM wrote:
>
> From: Limin Wang
>
> Signed-off-by: Limin Wang
> ---
Commit message should probably be something along the lines of
"""
avcodec/libsvtav1: properly enforce CQP mode when set in wrapper
SVT-AV1 seems to have switched their default from CQP to CRF in F
On Sat, Sep 18, 2021 at 4:27 AM wrote:
>
> From: Limin Wang
>
> Signed-off-by: Limin Wang
> ---
Hi,
"doc/encoders: add available values for libsvtav1 options"
would possibly be better as a commit message?
> doc/encoders.texi | 44
> 1 file change
On Sat, Sep 18, 2021 at 4:27 AM wrote:
>
> From: Limin Wang
>
> Reviewed-by: Jan Ekström
> Signed-off-by: Limin Wang
I still hate how SVT-AV1 has no enum/defines for these, but so be it :)
LGTM.
Jan
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg
On Sat, Sep 18, 2021 at 4:27 AM wrote:
>
> From: Limin Wang
>
> Signed-off-by: Limin Wang
I'd prefer the wording "fix duplicate definition of caps_internal",
but otherwise this patch is LGTM.
Good catch.
Jan
___
ffmpeg-devel mailing list
ffmpeg-deve
On Sat, Sep 25, 2021 at 4:06 AM wrote:
>
> On Thu, Sep 23, 2021 at 09:45:48AM -0400, Christopher Degawa wrote:
> > On Sun, Sep 19, 2021 at 2:02 PM Christopher Degawa
> > wrote:
> >
> > >
> > >
> > > On Fri, Sep 17, 2021 at 9:28 PM wrote:
> > >
> > >> From: Limin Wang
> > >>
> > >> Signed-off-by
Signed-off-by: Paul B Mahol
---
libavfilter/vf_avgblur.c | 311 +--
1 file changed, 171 insertions(+), 140 deletions(-)
diff --git a/libavfilter/vf_avgblur.c b/libavfilter/vf_avgblur.c
index 3e222a43fa..a838285bb4 100644
--- a/libavfilter/vf_avgblur.c
+++ b/li
On Sat, Sep 18, 2021 at 08:01:38PM +1000, Peter Ross wrote:
> ---
> libavcodec/siren.c | 6 +-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/libavcodec/siren.c b/libavcodec/siren.c
> index 2161b29a2c..3b0ad7b642 100644
> --- a/libavcodec/siren.c
> +++ b/libavcodec/siren.c
On Sat, Sep 25, 2021 at 5:00 AM Soft Works wrote:
>
>
>
> > -Original Message-
> > From: ffmpeg-devel On Behalf Of
> > Soft Works
> > Sent: Friday, 24 September 2021 19:03
> > To: FFmpeg development discussions and patches > de...@ffmpeg.org>
> > Subject: Re: [FFmpeg-devel] Scaling PAL8
On Sat, Sep 25, 2021 at 5:00 AM Soft Works wrote:
>
>
> > -Original Message-
> > From: ffmpeg-devel On Behalf Of
> > Soft Works
> > Sent: Friday, 24 September 2021 19:03
> > To: FFmpeg development discussions and patches > de...@ffmpeg.org>
> > Subject: Re: [FFmpeg-devel] Scaling PAL8 i
54 matches
Mail list logo
