[FFmpeg-devel] [PATCH 4/4] avcodec/mmaldec: fix pointer type warning

2021-09-23 Thread Ho Ming Shun
Signed-off-by: Ho Ming Shun --- libavcodec/mmaldec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/mmaldec.c b/libavcodec/mmaldec.c index 0aad7d0bb1..8ec0fe 100644 --- a/libavcodec/mmaldec.c +++ b/libavcodec/mmaldec.c @@ -660,7 +660,7 @@ static int ffmal_copy_

[FFmpeg-devel] [PATCH 3/4] avcodec/mmaldec: re-use AVPacket for extra_data

2021-09-23 Thread Ho Ming Shun
extra_data and normal packets (from ff_decode_get_packet) processing do not overlap, thus we can re-use the spare AVPacket to send to ffmmal_add_packet. Furthermore, this removes allocation of AVPacket on the stack and stops using deprecated av_init_packet. --- libavcodec/mmaldec.c | 8 +++-

[FFmpeg-devel] [PATCH 2/4] avcodec/mmaldec: use avpkt from DecodeSimpleContext

2021-09-23 Thread Ho Ming Shun
Use spare packet allocated in DecodeSimpleContext to handle packet submission into ffmmal_add_packet. --- libavcodec/mmaldec.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/libavcodec/mmaldec.c b/libavcodec/mmaldec.c index b97cc6ff5e..aab107d325 100644 --- a/libavcode

[FFmpeg-devel] [PATCH 1/4] avcodec/mmaldec: use decoupled dataflow

2021-09-23 Thread Ho Ming Shun
MMAL is an fundamentally an asynchronous decoder, which was a bad fit for the legacy dataflow API. Often multiple packets are enqueued before a flood of frames are returned from MMAL. The previous lockstep dataflow meant that any delay in returning packets from the VPU would cause ctx->queue_decod

[FFmpeg-devel] [PATCH 0/4] Switch mmaldec to decoupled dataflow

2021-09-23 Thread Ho Ming Shun
This series switches mmaldec to use the decoupled dataflow API to reduce excessive buffering in the driver. At the same time, remove dependency on sizeof(AVPacket) which is deprecated. Also fix all compile warnings. Ho Ming Shun (4): avcodec/mmaldec: use decoupled dataflow avcodec/mmaldec: u

Re: [FFmpeg-devel] [PATCH] avcodec/mmaldec: use decoupled dataflow

2021-09-23 Thread Ming Shun Ho
On Fri, Sep 24, 2021 at 3:40 AM Andreas Rheinhardt wrote: > > Ho Ming Shun: > > MMAL is an fundamentally an asynchronous decoder, which was a bad fit > > for the legacy dataflow API. Often multiple packets are enqueued before > > a flood of frames are returned from MMAL. > > > > The previous locks

Re: [FFmpeg-devel] [PATCH] swscale/yuv2rgb: fix shift values for conversion to X2RGB10

2021-09-23 Thread Manuel Stoeckl
> On Mon, Sep 20, 2021 at 10:21:23PM -0400, Manuel Stoeckl wrote: > > This resolves a problem where conversions from YUV to X2RGB10LE > > would produce color values a factor 4 too small. > > > > The variable 'yval' used later in the switch case 30 has range > > [0,255], but the color channel value

[FFmpeg-devel] [PATCH v3 3/3] swscale: add input/output support for X2BGR10LE

2021-09-23 Thread Manuel Stoeckl
Signed-off-by: Manuel Stoeckl --- libswscale/input.c | 15 +-- libswscale/output.c | 9 - libswscale/utils.c | 1 + libswscale/yuv2rgb.c | 9 ++--- tests/ref/fate/filter-pixdesc-x2bgr10

[FFmpeg-devel] [PATCH v3 2/3] lavu/pix_fmt: add pixel format for x2bgr10

2021-09-23 Thread Manuel Stoeckl
The new format (given in big/little endian forms) matches the existing X2RGB10 format, except with B and R channels switched. AV_PIX_FMT_X2BGR10 data often is created by OpenGL programs whose buffers use the GL_RGB10 internal format. Signed-off-by: Manuel Stoeckl --- doc/APIchanges

[FFmpeg-devel] [PATCH v3 1/3] swscale/yuv2rgb: fix conversion to X2RGB10

2021-09-23 Thread Manuel Stoeckl
This resolves a problem where conversions from YUV to X2RGB10LE would produce color values a factor 4 too small, because an 8-bit value was placed in a 10-bit channel. Signed-off-by: Manuel Stoeckl --- libswscale/yuv2rgb.c | 2 +- tests/ref/fate/filter-pixdesc-x2rgb10le | 2

Re: [FFmpeg-devel] [PATCH V2] libavutil/hwcontext_qsv: fix a bug for mapping qsv frame to vaapi

2021-09-23 Thread James Almer
On 9/13/2021 3:22 AM, Wenbin Chen wrote: Command below failed. ffmpeg -v verbose -init_hw_device vaapi=va:/dev/dri/renderD128 -init_hw_device qsv=qs@va -hwaccel qsv -hwaccel_device qs -filter_hw_device va -c:v h264_qsv -i 1080P.264 -vf "hwmap,format=vaapi" -c:v h264_vaapi output.264 Cause: Assig

Re: [FFmpeg-devel] [PATCH V2] libavutil/hwcontext_qsv: fix a bug for mapping qsv frame to vaapi

2021-09-23 Thread Chen, Wenbin
> Command below failed. > ffmpeg -v verbose -init_hw_device vaapi=va:/dev/dri/renderD128 > -init_hw_device qsv=qs@va -hwaccel qsv -hwaccel_device qs > -filter_hw_device va -c:v h264_qsv > -i 1080P.264 -vf "hwmap,format=vaapi" -c:v h264_vaapi output.264 > > Cause: Assign pair->first directly to dat

Re: [FFmpeg-devel] [PATCH v8 06/13] avfilter/overlay_graphicsubs: Add overlay_graphicsubs and graphicsub2video filters

2021-09-23 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of Andreas > Rheinhardt > Sent: Wednesday, 22 September 2021 06:24 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH v8 06/13] avfilter/overlay_graphicsubs: > Add overlay_graphicsubs and graphicsub2video filters > > So

[FFmpeg-devel] [PATCH v9 13/13] avfilter/graphicsub2text: Add new graphicsub2text filter (OCR)

2021-09-23 Thread Soft Works
Signed-off-by: softworkz --- configure| 1 + doc/filters.texi | 55 ++ libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/sf_graphicsub2text.c | 322 +++ 5 files changed, 380 in

[FFmpeg-devel] [PATCH v9 12/13] avfilter/split_cc: Add split_cc filter for closed caption handling

2021-09-23 Thread Soft Works
- split_cc {V -> VS) Extract closed-caption (A53) data from video frames as subtitle Frames ffmpeg -y -loglevel verbose -i "https://streams.videolan.org/streams/ts/CC/NewsStream-608-ac3.ts"; -filter_complex "[0:v]split_cc[vid1],textmod=mode=remove_chars:find='@',[vid1]overlay_textsubs" out

[FFmpeg-devel] [PATCH v9 11/13] avfilter/stripstyles: Add stripstyles filter

2021-09-23 Thread Soft Works
- stripstyles {S -> S) Remove all inline styles from subtitle events Signed-off-by: softworkz --- libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/sf_stripstyles.c | 211 +++ 3 files changed, 213 insertions(+) create mode

[FFmpeg-devel] [PATCH v9 10/13] avfilter/textmod: Add textmod, censor and show_speaker filters

2021-09-23 Thread Soft Works
- textmod {S -> S) Modify subtitle text in a number of ways - censor {S -> S) Censor subtitles using a word list - show_speaker {S -> S) Prepend speaker names from ASS subtitles to the visible text lines Signed-off-by: softworkz --- doc/filters.texi | 229 + libavfilt

[FFmpeg-devel] [PATCH v9 09/13] avfilter/overlay_textsubs: Add overlay_textsubs and textsubs2video filters

2021-09-23 Thread Soft Works
- overlay_textsubs {VS -> V) Overlay text subtitles onto a video stream. - textsubs2video {S -> V) Converts text subtitles to video frames Signed-off-by: softworkz --- configure | 2 + doc/filters.texi | 69 libavfilter/Makefile

[FFmpeg-devel] [PATCH v9 08/13] fftools/ffmpeg: Replace sub2video with subtitle frame filtering

2021-09-23 Thread Soft Works
This commit actually enables subtitle filtering in ffmpeg by sending and receiving subtitle frames to and from a filtergraph. The heartbeat functionality from the previous sub2video implementation is retained and applied to all subtitle frames (bitmap, text, ..). The other part of sub2video funct

[FFmpeg-devel] [PATCH v9 07/13] avfilter/overlay_graphicsubs: Add overlay_graphicsubs and graphicsub2video filters

2021-09-23 Thread Soft Works
- overlay_graphicsubs (VS -> V) Overlay graphic subtitles onto a video stream - graphicsub2video {S -> V) Converts graphic subtitles to video frames (with alpha) Gets auto-inserted for retaining compatibility with sub2video command lines Signed-off-by: softworkz --- doc/filters.texi

[FFmpeg-devel] [PATCH v9 06/13] avfilter/sbuffer: Add sbuffersrc and sbuffersink filters

2021-09-23 Thread Soft Works
Signed-off-by: softworkz --- configure| 2 +- libavfilter/allfilters.c | 2 ++ libavfilter/buffersink.c | 63 +++ libavfilter/buffersink.h | 15 + libavfilter/buffersrc.c | 72 libavfilter/buffersr

[FFmpeg-devel] [PATCH v9 05/13] avfilter/avfilter: Handle subtitle frames

2021-09-23 Thread Soft Works
Signed-off-by: softworkz --- libavfilter/avfilter.c | 8 +--- libavfilter/avfiltergraph.c | 5 + libavfilter/formats.c | 14 ++ libavfilter/formats.h | 3 +++ 4 files changed, 27 insertions(+), 3 deletions(-) diff --git a/libavfilter/avfilter.c b/libavfilt

[FFmpeg-devel] [PATCH v9 04/13] avfilter/subtitles: Add subtitles.c for subtitle frame allocation

2021-09-23 Thread Soft Works
Analog to avfilter/video.c and avfilter/audio.c Signed-off-by: softworkz --- libavfilter/Makefile| 1 + libavfilter/avfilter.c | 4 +++ libavfilter/internal.h | 1 + libavfilter/subtitles.c | 63 + libavfilter/subtitles.h | 44

[FFmpeg-devel] [PATCH v9 03/13] fftools/play, probe: Adjust for subtitle changes

2021-09-23 Thread Soft Works
Signed-off-by: softworkz --- fftools/ffplay.c | 102 +- fftools/ffprobe.c | 48 ++ 2 files changed, 79 insertions(+), 71 deletions(-) diff --git a/fftools/ffplay.c b/fftools/ffplay.c index ccea0e4578..9237752cab 100644 --- a/fftoo

[FFmpeg-devel] [PATCH v9 02/13] global: Move ass helper functions to avutil and extend ass dialog parsing

2021-09-23 Thread Soft Works
Signed-off-by: softworkz --- libavcodec/Makefile | 56 +++--- libavcodec/ass_internal.h | 68 +++ libavcodec/assdec.c | 2 +- libavcodec/assenc.c | 2 +- libavcodec/ccaption_dec.c

[FFmpeg-devel] [PATCH v9 01/13] global: Prepare AVFrame for subtitle handling

2021-09-23 Thread Soft Works
Root commit for adding subtitle filtering capabilities. In detail: - Add type (AVMediaType) field to AVFrame Replaces previous way of distinction which was based on checking width and height to determine whether a frame is audio or video - Add subtitle fields to AVFrame - Add new struct AVSubt

[FFmpeg-devel] [PATCH v9 00/13] Subtitle Filtering

2021-09-23 Thread Soft Works
v9 Update: - Addressed all review comments (thanks Andreas!) - Move ass utility functions to avutil as public API - Handle subtitle decoding via new decode API (removed av_decode_subtitle3) - Change 'subtitle_header' to use refcounted buffers - Allow mapping subtitle streams to filter graph an

Re: [FFmpeg-devel] [PATCH] avformat/jvdec: Make sizeof(JVFrame) smaller to save memory

2021-09-23 Thread Peter Ross
On Thu, Sep 23, 2021 at 06:29:35PM +0200, Andreas Rheinhardt wrote: > Signed-off-by: Andreas Rheinhardt > --- > libavformat/jvdec.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavformat/jvdec.c b/libavformat/jvdec.c > index 8f21ea1893..93569c87df 100644 > --- a

[FFmpeg-devel] [PATCH 2/2] fate/subtitles: Add JACOsub remuxing test

2021-09-23 Thread Andreas Rheinhardt
This muxer was untested up until now; had it been tested, it would have been obvious that it has been broken for years. Signed-off-by: Andreas Rheinhardt --- tests/fate/subtitles.mak | 4 tests/ref/fate/sub-jacosub-remux | 17 + 2 files changed, 21 insertions(+) cr

[FFmpeg-devel] [PATCH 1/2] avformat/jacosubenc: Fix writing extradata

2021-09-23 Thread Andreas Rheinhardt
The terminating '\0' is no longer included in the size of the extradata output by the demuxer since commit 36e61e24e7ac737b38c4382d439329352d9e0c29. E.g. if one remuxes the JACOsub sample JACOsub_capability_tester.jss from the FATE suite, one receives a file not recognized as JACOsub before this pa

[FFmpeg-devel] [PATCH 01/02] configure: Add macro defination for SVC decoding function based on Temporal scalability for H.264/AVC

2021-09-23 Thread ??????
Dear,   According to Mr. Zhao's advice last time, I made some modifications to my patch.   This patch just adds a macro defination named "TMP_SVC_DEC_H264" to the configure file that controls switching on and off SVC decoding capabilities based on temporal scalability.   Thank you for you review

[FFmpeg-devel] [PATCH 02/02] libavcodec/: Add the parsing procedure of SVC decoding function based on Temporal scalability for H.264/AVC

2021-09-23 Thread ??????
Dear,   According to Mr. Zhao's advice last time, I made some modifications to my patch.   According to the official document of H.264, this patch adds the code to parse the temporal scalable information in the parsing process.   Thank you for you review! h264_parsing_procedure_of_SVC.patch Desc

Re: [FFmpeg-devel] [PATCH] avcodec/mmaldec: use decoupled dataflow

2021-09-23 Thread Andreas Rheinhardt
Ho Ming Shun: > MMAL is an fundamentally an asynchronous decoder, which was a bad fit > for the legacy dataflow API. Often multiple packets are enqueued before > a flood of frames are returned from MMAL. > > The previous lockstep dataflow meant that any delay in returning packets > from the VPU wo

Re: [FFmpeg-devel] [PATCH 14/14] avcodec/elbg: Mark ELBGContext as being unaliased by using av_restrict

2021-09-23 Thread Tomas Härdin
mån 2021-09-20 klockan 23:18 +0200 skrev Andreas Rheinhardt: > This improves performance: For msvideo1, the performance improved by > 4.8% when encoding the sample from the fate-vsynth1-msvideo1 test; > when encoding the sample from fate-vsynth1-cinepak, performance > improved by 2%. The compiler u

Re: [FFmpeg-devel] [PATCH 1/5] [IMF demuxer] build system

2021-09-23 Thread Pierre-Anthony Lemieux
I have reordered the patches so that each patch individually compiles, when applied in order. Let me know if this does not work. Best, -- Pierre On Thu, Sep 23, 2021 at 11:13 AM Pierre-Anthony Lemieux wrote: > > Hi Timo, > > > Every commit individually has to compile and pass fate. > > Ok. Thi

[FFmpeg-devel] [PATCH 5/5] [IMF demuxer] build system

2021-09-23 Thread pal
From: Pierre-Anthony Lemieux Signed-off-by: Pierre-Anthony Lemieux --- Notes: Modify the FFMPEG build system to add support for an IMF demuxer. MAINTAINERS | 1 + configure| 3 ++- doc/demuxers.texi| 6 ++ libavformat/Makefile | 2 ++ libavform

[FFmpeg-devel] [PATCH 4/5] [IMF demuxer] Tests

2021-09-23 Thread pal
From: Pierre-Anthony Lemieux Signed-off-by: Pierre-Anthony Lemieux --- Notes: Tests for the public API of the IMF demuxer. libavformat/tests/imf.c | 476 1 file changed, 476 insertions(+) create mode 100644 libavformat/tests/imf.c diff --git a/li

[FFmpeg-devel] [PATCH 3/5] [IMF demuxer] Demuxer implementation

2021-09-23 Thread pal
From: Pierre-Anthony Lemieux Signed-off-by: Pierre-Anthony Lemieux --- Notes: Implements the IMF demuxer, which accepts as input an IMF CPL. The assets referenced by the CPL can be contained in multiple deliveries, each defined by an ASSETMAP file:./ffmpeg -assetmaps \,\,... -i \ If -asse

[FFmpeg-devel] [PATCH 2/5] [IMF demuxer] CPL processor

2021-09-23 Thread pal
From: Pierre-Anthony Lemieux Signed-off-by: Pierre-Anthony Lemieux --- Notes: Implements IMF Composition Playlist (CPL) parsing. The IMF CPL is specified in SMTPE ST 2067-3 and defines a timeline onto which MXF files are placed. libavformat/imf_cpl.c | 652 +++

[FFmpeg-devel] [PATCH 1/5] [IMF demuxer] Headers

2021-09-23 Thread pal
From: Pierre-Anthony Lemieux Signed-off-by: Pierre-Anthony Lemieux --- Notes: Public and private header files for the IMF demuxer. The functions and constants defines in the public header file imf.h can be used by other modules. The Interoperable Master Format (IMF) is a file-based media

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mxf: support MCA audio information

2021-09-23 Thread Tomas Härdin
tor 2021-09-23 klockan 00:02 +0200 skrev Marton Balint: On Fri, 17 Sep 2021, Marc-Antoine Arnaud wrote: > --- > libavformat/mxf.h    |   1 + > libavformat/mxfdec.c | 277 > ++- > 2 files changed, 272 insertions(+), 6 deletions(-) I guess the questionable p

Re: [FFmpeg-devel] [PATCH 17/27] avformat/movenchint: Simplify writing padding

2021-09-23 Thread Andreas Rheinhardt
Paul B Mahol: > lgtm if ffio_fill does not turn negative argument into very positive one. > ffio_fill does not do that; and the argument here is always nonnegative. Here is the loop: while (size > 0) { int len = size; // size is an int and > 0 and so is len is now if (len > 1

Re: [FFmpeg-devel] [PATCH 17/27] avformat/movenchint: Simplify writing padding

2021-09-23 Thread Paul B Mahol
lgtm if ffio_fill does not turn negative argument into very positive one. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org wi

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/mmaldec: fix deprecation warning

2021-09-23 Thread Ming Shun Ho
On Fri, Sep 24, 2021 at 2:09 AM Andreas Rheinhardt wrote: > > Ming Shun Ho: > > On Fri, Sep 24, 2021 at 12:52 AM Andreas Rheinhardt > > wrote: > >> > >> Ho Ming Shun: > >>> Signed-off-by: Ho Ming Shun > >>> --- > >>> libavcodec/mmaldec.c | 2 ++ > >>> 1 file changed, 2 insertions(+) > >>> > >>>

Re: [FFmpeg-devel] [PATCH 21/27] avformat/omadec: Don't output uninitialized values

2021-09-23 Thread Paul B Mahol
lgtm ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 19/27] avformat/riffenc: Fix indentation

2021-09-23 Thread Paul B Mahol
lgtm ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 24/27] avformat/aviobuf: Extend ffio_fill to 64bits

2021-09-23 Thread Paul B Mahol
lgtm ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH] avcodec/mmaldec: use decoupled dataflow

2021-09-23 Thread Ho Ming Shun
MMAL is an fundamentally an asynchronous decoder, which was a bad fit for the legacy dataflow API. Often multiple packets are enqueued before a flood of frames are returned from MMAL. The previous lockstep dataflow meant that any delay in returning packets from the VPU would cause ctx->queue_decod

Re: [FFmpeg-devel] [PATCH 1/5] [IMF demuxer] build system

2021-09-23 Thread Pierre-Anthony Lemieux
Hi Timo, > Every commit individually has to compile and pass fate. Ok. This will reduce the number of patches. Best, -- Pierre On Thu, Sep 23, 2021 at 11:07 AM Timo Rothenpieler wrote: > > On 23/09/2021 19:00, p...@sandflow.com wrote: > > From: Pierre-Anthony Lemieux > > > > Signed-off-by: P

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/mmaldec: fix deprecation warning

2021-09-23 Thread Andreas Rheinhardt
Ming Shun Ho: > On Fri, Sep 24, 2021 at 12:52 AM Andreas Rheinhardt > wrote: >> >> Ho Ming Shun: >>> Signed-off-by: Ho Ming Shun >>> --- >>> libavcodec/mmaldec.c | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >>> diff --git a/libavcodec/mmaldec.c b/libavcodec/mmaldec.c >>> index 5b75a1e74d..961

Re: [FFmpeg-devel] [PATCH 1/5] [IMF demuxer] build system

2021-09-23 Thread Timo Rothenpieler
On 23/09/2021 19:00, p...@sandflow.com wrote: From: Pierre-Anthony Lemieux Signed-off-by: Pierre-Anthony Lemieux --- Notes: Modify the FFMPEG build system to add support for an IMF demuxer. The Interoperable Master Format (IMF) is a file-based media format for the delivery and storage

[FFmpeg-devel] [PATCH] avformat/jvdec: Make sizeof(JVFrame) smaller to save memory

2021-09-23 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavformat/jvdec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/jvdec.c b/libavformat/jvdec.c index 8f21ea1893..93569c87df 100644 --- a/libavformat/jvdec.c +++ b/libavformat/jvdec.c @@ -36,8 +36,8 @@ typedef struct JVF

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/mmaldec: fix deprecation warning

2021-09-23 Thread Ming Shun Ho
On Fri, Sep 24, 2021 at 12:52 AM Andreas Rheinhardt wrote: > > Ho Ming Shun: > > Signed-off-by: Ho Ming Shun > > --- > > libavcodec/mmaldec.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/libavcodec/mmaldec.c b/libavcodec/mmaldec.c > > index 5b75a1e74d..96140bf53d 100644 > > -

Re: [FFmpeg-devel] [PATCH 1/5] [IMF demuxer] build system

2021-09-23 Thread Pierre-Anthony Lemieux
Hi all, Sample content is available at: http://ffmpeg-imf-samples-public.s3-website-us-west-1.amazonaws.com/countdown/CPL_f5095caa-f204-4e1c-8a84-7af48c7ae16b.xml Looking forward to the feedback. Best, -- Pierre On Thu, Sep 23, 2021 at 10:01 AM wrote: > > From: Pierre-Anthony Lemieux > > Si

[FFmpeg-devel] [PATCH 5/5] [IMF demuxer] Tests

2021-09-23 Thread pal
From: Pierre-Anthony Lemieux Signed-off-by: Pierre-Anthony Lemieux --- Notes: Tests for the public API of the IMF demuxer. libavformat/tests/imf.c | 476 1 file changed, 476 insertions(+) create mode 100644 libavformat/tests/imf.c diff --git a/li

[FFmpeg-devel] [PATCH 4/5] [IMF demuxer] Demuxer implementation

2021-09-23 Thread pal
From: Pierre-Anthony Lemieux Signed-off-by: Pierre-Anthony Lemieux --- Notes: Implements the IMF demuxer, which accepts as input an IMF CPL. The assets referenced by the CPL can be contained in multiple deliveries, each defined by an ASSETMAP file:./ffmpeg -assetmaps \,\,... -i \ If -asse

[FFmpeg-devel] [PATCH 3/5] [IMF demuxer] CPL processor

2021-09-23 Thread pal
From: Pierre-Anthony Lemieux Signed-off-by: Pierre-Anthony Lemieux --- Notes: Implements IMF Composition Playlist (CPL) parsing. The IMF CPL is specified in SMTPE ST 2067-3 and defines a timeline onto which MXF files are placed. libavformat/imf_cpl.c | 652 +++

[FFmpeg-devel] [PATCH 2/5] [IMF demuxer] Headers

2021-09-23 Thread pal
From: Pierre-Anthony Lemieux Signed-off-by: Pierre-Anthony Lemieux --- Notes: Public and private header files for the IMF demuxer. The functions and constants defines in the public header file imf.h can be used by other modules. libavformat/imf.h | 156 ++

[FFmpeg-devel] [PATCH 1/5] [IMF demuxer] build system

2021-09-23 Thread pal
From: Pierre-Anthony Lemieux Signed-off-by: Pierre-Anthony Lemieux --- Notes: Modify the FFMPEG build system to add support for an IMF demuxer. The Interoperable Master Format (IMF) is a file-based media format for the delivery and storage of professional audio-visual masters. An IMF Comp

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/mmaldec: fix deprecation warning

2021-09-23 Thread Andreas Rheinhardt
Ho Ming Shun: > Signed-off-by: Ho Ming Shun > --- > libavcodec/mmaldec.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/libavcodec/mmaldec.c b/libavcodec/mmaldec.c > index 5b75a1e74d..96140bf53d 100644 > --- a/libavcodec/mmaldec.c > +++ b/libavcodec/mmaldec.c > @@ -772,7 +772,9 @@ st

[FFmpeg-devel] [PATCH 2/2] avcodec/mmaldec: fix deprecation warning

2021-09-23 Thread Ho Ming Shun
Signed-off-by: Ho Ming Shun --- libavcodec/mmaldec.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavcodec/mmaldec.c b/libavcodec/mmaldec.c index 5b75a1e74d..96140bf53d 100644 --- a/libavcodec/mmaldec.c +++ b/libavcodec/mmaldec.c @@ -772,7 +772,9 @@ static int ffmmal_decode(AVCodecCont

[FFmpeg-devel] [PATCH 1/2] avcodec/mmaldec: fix pointer type warning

2021-09-23 Thread Ho Ming Shun
Signed-off-by: Ho Ming Shun --- libavcodec/mmaldec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/mmaldec.c b/libavcodec/mmaldec.c index 8c7d749742..5b75a1e74d 100644 --- a/libavcodec/mmaldec.c +++ b/libavcodec/mmaldec.c @@ -651,7 +651,7 @@ static int ffmal_copy_

[FFmpeg-devel] [PATCH 18/27] avformat/asfenc: Simplify writing error correction data

2021-09-23 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- Equivalent to avio_w16(pb, 0x0). libavformat/asfenc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libavformat/asfenc.c b/libavformat/asfenc.c index 07588772c6..a0510df7dc 100644 --- a/libavformat/asfenc.c +++ b/libavformat/asfenc.c

[FFmpeg-devel] [PATCH 17/27] avformat/movenchint: Simplify writing padding

2021-09-23 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavformat/movenchint.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libavformat/movenchint.c b/libavformat/movenchint.c index 47276091f3..35212f2c5d 100644 --- a/libavformat/movenchint.c +++ b/libavformat/movenchint.c @@ -260,8 +260

Re: [FFmpeg-devel] [PATCH 09/27] avformat/cafenc: Don't segfault upon allocation error

2021-09-23 Thread Paul B Mahol
lgtm ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH 27/27] avformat/mxfenc: Simplfy writing padding

2021-09-23 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavformat/mxfenc.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/libavformat/mxfenc.c b/libavformat/mxfenc.c index f37606ed89..56facbe4b7 100644 --- a/libavformat/mxfenc.c +++ b/libavformat/mxfenc.c @@ -965,7 +965,6 @@ static void m

[FFmpeg-devel] [PATCH 26/27] avformat/gxfenc: Simplify writing padding/reserved elements

2021-09-23 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavformat/gxfenc.c | 30 +++--- 1 file changed, 7 insertions(+), 23 deletions(-) diff --git a/libavformat/gxfenc.c b/libavformat/gxfenc.c index 1a80ecb603..8cc3bd456e 100644 --- a/libavformat/gxfenc.c +++ b/libavformat/gxfenc.c @@ -

[FFmpeg-devel] [PATCH 25/27] avformat/avienc: Simplify writing padding

2021-09-23 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- write_odml_master() was responsible for 134406 of the 135347 calls to avio_wl64() during a fate-run. libavformat/avienc.c | 18 +- 1 file changed, 5 insertions(+), 13 deletions(-) diff --git a/libavformat/avienc.c b/libavformat/avienc.c inde

[FFmpeg-devel] [PATCH 24/27] avformat/aviobuf: Extend ffio_fill to 64bits

2021-09-23 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavformat/avio_internal.h | 2 +- libavformat/aviobuf.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/avio_internal.h b/libavformat/avio_internal.h index 8b9e048f73..11060e9ff9 100644 --- a/libavformat/avio_interna

[FFmpeg-devel] [PATCH 23/27] avformat/omaenc: Simplify writing padding

2021-09-23 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavformat/omaenc.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/libavformat/omaenc.c b/libavformat/omaenc.c index ec71956fbd..1c4edcac5c 100644 --- a/libavformat/omaenc.c +++ b/libavformat/omaenc.c @@ -29,7 +29,6 @@ static a

[FFmpeg-devel] [PATCH 22/27] fate/oma: Add remux tests for ATRAC3 and ATRAC3P

2021-09-23 Thread Andreas Rheinhardt
They already uncovered an uninitialized-value bug in the ATRAC3 code in the demuxer; and provide coverage for ID3v2.3. Signed-off-by: Andreas Rheinhardt --- tests/fate/oma.mak | 18 +- tests/ref/fate/oma-atrac3-remux | 14 ++ tests/ref/fate/oma-atrac3p-

[FFmpeg-devel] [PATCH 21/27] avformat/omadec: Don't output uninitialized values

2021-09-23 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavformat/omadec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/omadec.c b/libavformat/omadec.c index f6b7697a43..a727cc4d66 100644 --- a/libavformat/omadec.c +++ b/libavformat/omadec.c @@ -491,7 +491,7 @@ static int oma_r

[FFmpeg-devel] [PATCH 20/27] fate/demux: Move Sony OpenMG audio (oma) test into a new file

2021-09-23 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- tests/Makefile | 1 + tests/fate/demux.mak | 3 --- tests/fate/oma.mak | 5 + 3 files changed, 6 insertions(+), 3 deletions(-) create mode 100644 tests/fate/oma.mak diff --git a/tests/Makefile b/tests/Makefile index d5595908b8..1e0345b163 100644

[FFmpeg-devel] [PATCH 19/27] avformat/riffenc: Fix indentation

2021-09-23 Thread Andreas Rheinhardt
Forgotten after bf9a8d183ddcc65b5ae473bb048a3d38bd6df9f3. Signed-off-by: Andreas Rheinhardt --- libavformat/riffenc.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavformat/riffenc.c b/libavformat/riffenc.c index 43c8bf957a..ffccfa3d48 100644 --- a/libavformat/ri

[FFmpeg-devel] [PATCH 16/27] avformat/mpegenc: Simplify writing padding/stuffing

2021-09-23 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavformat/mpegenc.c | 26 +- 1 file changed, 9 insertions(+), 17 deletions(-) diff --git a/libavformat/mpegenc.c b/libavformat/mpegenc.c index 6aed527d50..b1d8bf9c38 100644 --- a/libavformat/mpegenc.c +++ b/libavformat/mpegenc.c @@

[FFmpeg-devel] [PATCH 15/27] avformat/matroskaenc: Simplify writing qt-compatibility header

2021-09-23 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavformat/matroskaenc.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/libavformat/matroskaenc.c b/libavformat/matroskaenc.c index 039f20988a..f17665b0c1 100644 --- a/libavformat/matroskaenc.c +++ b/libavformat/matroskaenc.c @@ -785,

[FFmpeg-devel] [PATCH 14/27] avformat/movenc: Simplify reserving space for tfrf tags

2021-09-23 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavformat/movenc.c | 22 ++ 1 file changed, 6 insertions(+), 16 deletions(-) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index 53c8ffadd5..7650ac5ed3 100644 --- a/libavformat/movenc.c +++ b/libavformat/movenc.c @@ -1344,7 +

[FFmpeg-devel] [PATCH 13/27] avformat/movenc: Limit ism_lookahead to a sane value

2021-09-23 Thread Andreas Rheinhardt
There can only be a maximum of 255 entries in a tfrf tag, so using more makes no sense; moreover, several size computations can overflow in this case. Fix this by limiting it to 255. Signed-off-by: Andreas Rheinhardt --- libavformat/movenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[FFmpeg-devel] [PATCH 12/27] avformat/icoenc: Use avcodec_get_name() instead of codec descriptor

2021-09-23 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavformat/icoenc.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/libavformat/icoenc.c b/libavformat/icoenc.c index 21966f3921..d684f67707 100644 --- a/libavformat/icoenc.c +++ b/libavformat/icoenc.c @@ -27,7 +27,6 @@ #include "liba

[FFmpeg-devel] [PATCH 11/27] avformat/icoenc: Simplify writing bitmask

2021-09-23 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- I am pretty certain that the size of said bitmask should be (par->height * par->width + 7) / 8 (or maybe par->height * ((par->width + 7) / 8)), but not what it is now. libavformat/icoenc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --g

[FFmpeg-devel] [PATCH 10/27] avformat/cafenc: Fix memleak when trailer is never written

2021-09-23 Thread Andreas Rheinhardt
Do this by using the AVStream's priv_data for the buffer holding the packet size data. Signed-off-by: Andreas Rheinhardt --- libavformat/cafenc.c | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/libavformat/cafenc.c b/libavformat/cafenc.c index b17d2397e9..41

[FFmpeg-devel] [PATCH 09/27] avformat/cafenc: Don't segfault upon allocation error

2021-09-23 Thread Andreas Rheinhardt
If an array for the packet sizes could not be successfully reallocated when writing a packet, the CAF muxer frees said array, but does not reset the number of valid bytes. As a result, when the trailer is written later, avio_write tries to read that many bytes from NULL, which segfaults. Fix this

[FFmpeg-devel] [PATCH 08/27] avformat/cafenc: Fix potential integer overflow

2021-09-23 Thread Andreas Rheinhardt
(As long as avio_write() only accepts an int, it makes no sense to try to support sizes that don't fit into an int.) Signed-off-by: Andreas Rheinhardt --- libavformat/cafenc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/cafenc.c b/libavformat/cafenc.c inde

[FFmpeg-devel] [PATCH 07/27] fate/caf: Add remux tests

2021-09-23 Thread Andreas Rheinhardt
These test both the muxer as well as the demuxer. Signed-off-by: Andreas Rheinhardt --- tests/fate/caf.mak | 30 +- tests/ref/fate/caf-alac-remux | 28 tests/ref/fate/caf-amr_nb-remux| 19 +++ tests

[FFmpeg-devel] [PATCH 06/27] fate/demux: Move caf test to its own file

2021-09-23 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- tests/Makefile| 1 + tests/fate/caf.mak| 5 + tests/fate/demux.mak | 3 --- tests/ref/fate/{caf => caf-demux} | 0 4 files changed, 6 insertions(+), 3 deletions(-) create mode 100644 tests/fate/caf.mak re

[FFmpeg-devel] [PATCH 05/27] avfilter/audio, video: Remove references to avfilter_unref_buffer()

2021-09-23 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavfilter/audio.h | 3 +-- libavfilter/video.h | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/libavfilter/audio.h b/libavfilter/audio.h index 6bbe6ee9ef..90709a0ad0 100644 --- a/libavfilter/audio.h +++ b/libavfilter/audio.h @@ -37,8

[FFmpeg-devel] [PATCH 04/27] avformat/filmstripenc: Simplify writing reserved elements

2021-09-23 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavformat/filmstripenc.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/libavformat/filmstripenc.c b/libavformat/filmstripenc.c index 48f483bc90..ebb7294175 100644 --- a/libavformat/filmstripenc.c +++ b/libavformat/filmstripenc.c @

[FFmpeg-devel] [PATCH 03/27] avformat/chromaprint: Improve returned error codes

2021-09-23 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavformat/chromaprint.c | 18 -- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/libavformat/chromaprint.c b/libavformat/chromaprint.c index b7a943e126..e4882c8e61 100644 --- a/libavformat/chromaprint.c +++ b/libavformat/chrom

[FFmpeg-devel] [PATCH 02/27] avformat/chromaprint: Add deinit function

2021-09-23 Thread Andreas Rheinhardt
Fixes memleaks in case the trailer is never written. Signed-off-by: Andreas Rheinhardt --- libavformat/chromaprint.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/libavformat/chromaprint.c b/libavformat/chromaprint.c index 399de725d3..b7a943e126 100644 --- a/libavfor

Re: [FFmpeg-devel] [PATCH 01/27] avformat/astenc: Simplify writing padding

2021-09-23 Thread James Almer
On 9/23/2021 12:06 PM, Andreas Rheinhardt wrote: Signed-off-by: Andreas Rheinhardt --- libavformat/astenc.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/libavformat/astenc.c b/libavformat/astenc.c index cf75b48b21..a5792e0b07 100644 --- a/libavformat/astenc.c +++ b/l

Re: [FFmpeg-devel] [PATCH v2 6/6] avcodec/libsvtav1: support constant quality mode

2021-09-23 Thread lance . lmwang
On Thu, Sep 23, 2021 at 05:11:49PM +0300, Jan Ekström wrote: > On Thu, Sep 23, 2021 at 4:46 PM Christopher Degawa > wrote: > > > > On Sun, Sep 19, 2021 at 2:02 PM Christopher Degawa > > wrote: > > > > > > > > > > > On Fri, Sep 17, 2021 at 9:28 PM wrote: > > > > > >> From: Limin Wang > > >> > >

[FFmpeg-devel] [PATCH 01/27] avformat/astenc: Simplify writing padding

2021-09-23 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavformat/astenc.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/libavformat/astenc.c b/libavformat/astenc.c index cf75b48b21..a5792e0b07 100644 --- a/libavformat/astenc.c +++ b/libavformat/astenc.c @@ -118,9 +118,7 @@ static int as

Re: [FFmpeg-devel] [PATCH v2 6/6] avcodec/libsvtav1: support constant quality mode

2021-09-23 Thread Jan Ekström
On Thu, Sep 23, 2021 at 4:46 PM Christopher Degawa wrote: > > On Sun, Sep 19, 2021 at 2:02 PM Christopher Degawa > wrote: > > > > > > > On Fri, Sep 17, 2021 at 9:28 PM wrote: > > > >> From: Limin Wang > >> > >> Signed-off-by: Limin Wang > >> > > As a note, I personally favor this patch over mi

Re: [FFmpeg-devel] [PATCH v2 6/6] avcodec/libsvtav1: support constant quality mode

2021-09-23 Thread Christopher Degawa
On Sun, Sep 19, 2021 at 2:02 PM Christopher Degawa wrote: > > > On Fri, Sep 17, 2021 at 9:28 PM wrote: > >> From: Limin Wang >> >> Signed-off-by: Limin Wang >> > As a note, I personally favor this patch over mine since I don't think > `enable_tpl_la` is worth exposing to the user if its main r

Re: [FFmpeg-devel] [PATCH 0/3] Detect field_order when probing MP4/H264

2021-09-23 Thread James Almer
On 9/23/2021 7:54 AM, Nicolas Gaullier wrote: Envoyé : jeudi 16 septembre 2021 09:40 Nicolas Gaullier (3): avcodec/h264_parser: Set AVCodecContext.framerate avformat/utils: Use r_frame_rate in compute_frame_duration if codec_framerate is unknown avformat/mov: Set AVSTREAM_PARSE_HEADERS f

Re: [FFmpeg-devel] [PATCH v2 3/5] avformat/matroskaenc: Write dvcC/dvvC block additional mapping

2021-09-23 Thread quietvoid
On 23/09/2021 01.33, Andreas Rheinhardt wrote: diff --git a/libavformat/dovi_isom.h b/libavformat/dovi_isom.h index 9d9a05bdb0..b58ab1bea0 100644 --- a/libavformat/dovi_isom.h +++ b/libavformat/dovi_isom.h @@ -23,7 +23,12 @@ #define AVFORMAT_DOVI_ISOM_H #include "avformat.h" +#include "l

Re: [FFmpeg-devel] [PATCH 0/3] Detect field_order when probing MP4/H264

2021-09-23 Thread Nicolas Gaullier
>Envoyé : jeudi 16 septembre 2021 09:40 > >>Nicolas Gaullier (3): >> avcodec/h264_parser: Set AVCodecContext.framerate >> avformat/utils: Use r_frame_rate in compute_frame_duration if >> codec_framerate is unknown >> avformat/mov: Set AVSTREAM_PARSE_HEADERS flag for H264 > >Hello, I have receiv

Re: [FFmpeg-devel] [PATCH v8 07/13] fftools/ffmpeg: Replace sub2video with subtitle frame filtering

2021-09-23 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of Nicolas > George > Sent: Thursday, 23 September 2021 10:18 > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH v8 07/13] fftools/ffmpeg: Replace > sub2video with subtitle frame filtering > > But a

Re: [FFmpeg-devel] [PATCH 4/4] avfiler/framesync: Remove redundant setting of AVClass

2021-09-23 Thread Nicolas George
Andreas Rheinhardt (12021-09-19): > Every filter exposing the framesync options via its child_next > callback already calls framesync_preinit() in its preinit callback. > So the filter is already preinited whenever its child_next is called. > > Signed-off-by: Andreas Rheinhardt > --- > libavfilt

Re: [FFmpeg-devel] [PATCH v8 07/13] fftools/ffmpeg: Replace sub2video with subtitle frame filtering

2021-09-23 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of Nicolas > George > Sent: Thursday, 23 September 2021 10:18 > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH v8 07/13] fftools/ffmpeg: Replace > sub2video with subtitle frame filtering > > Soft

  1   2   >