Re: [FFmpeg-devel] [PATCH v5 00/12] Subtitle Filtering

On Wed, Sep 15, 2021 at 1:21 AM Soft Works wrote: > > Hendrik, > > I can't avoid to note that your reply pattern is a bit similar to > what I've seen before here: long texts trying to point out one's > authority, naming rejection conditions, trying to discourage instead > of encourage and finally

Re: [FFmpeg-devel] [PATCH] libavfilter/vf_vpp_qsv: fix uninitialized variable problem

> -Original Message- > From: ffmpeg-devel On Behalf Of > Wenbin Chen > Sent: Wednesday, 15 September 2021 07:15 > To: ffmpeg-devel@ffmpeg.org > Cc: Wenbin Chen > Subject: [FFmpeg-devel] [PATCH] libavfilter/vf_vpp_qsv: fix > uninitialized variable problem > > This two variables may be

Re: [FFmpeg-devel] [PATCH] libavfilter/vf_vpp_qsv: fix uninitialized variable problem

On Wed, 2021-09-15 at 13:15 +0800, Wenbin Chen wrote: > This two variables may be used below with uninitialized value. > Now fix them. > > Signed-off-by: Wenbin Chen > --- > libavfilter/vf_vpp_qsv.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavfilter/vf_vpp_

[FFmpeg-devel] [PATCH] libavfilter/vf_vpp_qsv: fix uninitialized variable problem

This two variables may be used below with uninitialized value. Now fix them. Signed-off-by: Wenbin Chen --- libavfilter/vf_vpp_qsv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavfilter/vf_vpp_qsv.c b/libavfilter/vf_vpp_qsv.c index c268b5dba8..22ffe0d7f3 100644 ---

Re: [FFmpeg-devel] [PATCH v5 10/12] avfilter/textmod: Add textmod filter

> -Original Message- > From: ffmpeg-devel On Behalf Of > Andreas Rheinhardt > Sent: Sunday, 12 September 2021 23:56 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH v5 10/12] avfilter/textmod: Add > textmod filter > > Soft Works: > > Signed-off-by: softworkz > > ---

Re: [FFmpeg-devel] [PATCH V2] libavutil/hwcontext_qsv: fix a bug for mapping qsv frame to vaapi

> Command below failed. > ffmpeg -v verbose -init_hw_device vaapi=va:/dev/dri/renderD128 > -init_hw_device qsv=qs@va -hwaccel qsv -hwaccel_device qs > -filter_hw_device va -c:v h264_qsv > -i 1080P.264 -vf "hwmap,format=vaapi" -c:v h264_vaapi output.264 > > Cause: Assign pair->first directly to dat

[FFmpeg-devel] [PATCH 12/12] avutil/mem: Deprecate av_mallocz_array()

It does the same as av_calloc(), so one of them should be removed. Given that av_calloc() has the shorter name, it is retained. Signed-off-by: Andreas Rheinhardt --- libavutil/mem.c | 2 ++ libavutil/mem.h | 11 ++- libavutil/version.h | 3 +++ 3 files changed, 11 insertions(+)

[FFmpeg-devel] [PATCH 11/12] Replace all occurences of av_mallocz_array() by av_calloc()

They do the same. Signed-off-by: Andreas Rheinhardt --- compat/w32dlfcn.h | 2 +- doc/examples/remuxing.c| 2 +- doc/examples/transcoding.c | 2 +- fftools/cmdutils.c | 4 +-- fftools/ffmpeg_opt.c | 8 +++--- fftools/ffprobe

Re: [FFmpeg-devel] [PATCH v5 00/12] Subtitle Filtering

> -Original Message- > From: ffmpeg-devel On Behalf Of > Soft Works > Sent: Sunday, 12 September 2021 22:33 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH v5 00/12] Subtitle Filtering > > > > > -Original Message- > > F

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/hevc_sei: check size before using it

On Tue, Sep 14, 2021 at 07:27:04PM +0800, myp...@gmail.com wrote: > On Tue, Sep 14, 2021 at 6:50 PM wrote: > > > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > libavcodec/hevc_sei.c | 31 +-- > > 1 file changed, 25 insertions(+), 6 deletions(-) > >

Re: [FFmpeg-devel] [PATCH 3/4] avformat/rmdec: Use 64bit for intermediate for DEINT_ID_INT4

James Almer: > On 9/14/2021 6:09 PM, Michael Niedermayer wrote: >> On Sat, Jul 10, 2021 at 03:31:14PM +0200, Michael Niedermayer wrote: >>> On Sat, Apr 17, 2021 at 03:12:29AM +0200, Andreas Rheinhardt wrote: James Almer: > On 4/16/2021 9:13 PM, Andreas Rheinhardt wrote: >> James Almer:

Re: [FFmpeg-devel] [PATCH 3/4] avformat/rmdec: Use 64bit for intermediate for DEINT_ID_INT4

On 9/14/2021 6:09 PM, Michael Niedermayer wrote: On Sat, Jul 10, 2021 at 03:31:14PM +0200, Michael Niedermayer wrote: On Sat, Apr 17, 2021 at 03:12:29AM +0200, Andreas Rheinhardt wrote: James Almer: On 4/16/2021 9:13 PM, Andreas Rheinhardt wrote: James Almer: On 4/16/2021 8:45 PM, Andreas Rh

Re: [FFmpeg-devel] [PATCH 3/4] avformat/rmdec: Use 64bit for intermediate for DEINT_ID_INT4

On Sat, Jul 10, 2021 at 03:31:14PM +0200, Michael Niedermayer wrote: > On Sat, Apr 17, 2021 at 03:12:29AM +0200, Andreas Rheinhardt wrote: > > James Almer: > > > On 4/16/2021 9:13 PM, Andreas Rheinhardt wrote: > > >> James Almer: > > >>> On 4/16/2021 8:45 PM, Andreas Rheinhardt wrote: > > Jame

Re: [FFmpeg-devel] [PATCH 2/3] avformat/sbgdec: Check opt_duration and start for overflow

On Fri, Jun 25, 2021 at 09:22:03AM -0300, James Almer wrote: > On 6/24/2021 5:57 PM, Michael Niedermayer wrote: > > Fixes: signed integer overflow: 27886261755 + 71189412840 > > cannot be represented in type 'long' > > Fixes: > > 35215/clusterfuzz-testcase-minimized-ffmpeg_dem_SBG

Re: [FFmpeg-devel] [PATCH] avformat/aaxdec: Ask for a sample and disable COLUMN_FLAG_DEFAULT

On Sat, Jul 10, 2021 at 11:26:17PM +0200, Michael Niedermayer wrote: > The codepath repeatly seeks back to the same byte and fills the table with > this > Fixes: Timeout (reading billions of times the same byte) > Fixes: > 35510/clusterfuzz-testcase-minimized-ffmpeg_dem_AAX_fuzzer-574228904450457

[FFmpeg-devel] [PATCH 3/3] avcodec/flicvideo: Check remaining bytes in FLI*COPY

Fixes: Timeout Fixes: 37795/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_FLIC_fuzzer-4846536543043584 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/flicvideo.c | 2 ++ 1 file changed, 2

[FFmpeg-devel] [PATCH 1/3] avcodec/mxpegdec: Check for AVDISCARD_ALL

Fixes: Fixes NULL pointer dereference Fixes: 36610/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MXPEG_fuzzer-6052641783283712 Fixes: 37907/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MXPEG_fuzzer-4725170850365440 Fixes: 37904/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MXPEG_fuz

[FFmpeg-devel] [PATCH 2/3] avcodec/h274: fix bad left shifts

Fixes: left shift of negative value -3 Fixes: 37788/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_H264_fuzzer-6024714540154880 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/h274.c | 4 ++

Re: [FFmpeg-devel] [PATCH] avutil/imgutils: use INT64_MAX for alloc buffer check and image size check

On 9/14/2021 8:19 AM, Steven Liu wrote: check alloc buffer size limit from INT_MAX to INT64_MAX check stride and stride*(uint64_t)(h+128) look into the Picture size condition using INT_MAX is smaller, so make it to INT64_MAX maybe large enough for Picture. Signed-off-by: Steven Liu --- libavu

[FFmpeg-devel] [PATCH v2] avformat/mpegts: fixes overflow handlign when parsing the PMT

When an possible overflow was detected, there was a break to exit the while loop. However, it should have already substracted 2 bytes from program_info_length (descriptor ID + length). Ticket #9422 --- libavformat/mpegts.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/

[FFmpeg-devel] [PATCH] Fixes overflow in libavformat/mpegts.c when parsing the PMT, ticket #9422.

When an possible overflow was detected, there was a break to exit the while loop. However, it should have already substracted 2 bytes from program_info_length (descri^Cor ID + length). --- libavformat/mpegts.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libavformat/m

Re: [FFmpeg-devel] [PATCH v2 07/14] avfilter/vf_spp: Add dummy element to array to avoid shift

On Tue, Sep 14, 2021 at 01:23:32AM +0200, Andreas Rheinhardt wrote: > Signed-off-by: Andreas Rheinhardt > --- > libavfilter/vf_spp.c | 7 --- > 1 file changed, 4 insertions(+), 3 deletions(-) ok thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB During t

Re: [FFmpeg-devel] [PATCH] avcodec/h264_picture: wait for the second slice to apply film grain on interlaced content

On Tue, Sep 14, 2021 at 09:59:02AM -0300, James Almer wrote: > Fixes: Assertion failure > Fixes: > clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_H264_fuzzer-6581961297100800 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off

Re: [FFmpeg-devel] [PATCH 1/3] avformat/matroskadec: Reset state also on failure in matroska_reset_status()

On Mon, Sep 13, 2021 at 10:57:41PM +0200, Andreas Rheinhardt wrote: > Michael Niedermayer: > > On Mon, Jul 19, 2021 at 11:12:11PM +0200, Andreas Rheinhardt wrote: > >> Michael Niedermayer: > >>> On Fri, Jul 02, 2021 at 06:17:58PM +0200, Andreas Rheinhardt wrote: > Michael Niedermayer: > >

Re: [FFmpeg-devel] [PATCH 3/3] tools/target_dec_fuzzer: Adjust threshold for WMV3

On Tue, Sep 14, 2021 at 12:48:48AM +0200, Michael Niedermayer wrote: > Fixes: Timeout clearing images > Fixes: > 37726/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WMV3_fuzzer-4604669570187264 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects

Re: [FFmpeg-devel] [PATCH] avformat/utils: Ignore negative duration in codec_info_duration computation

On Sat, Jul 03, 2021 at 11:02:16PM +0200, Michael Niedermayer wrote: > Fixes: signed integer overflow: -5994697211974418462 + -325530713450286 > cannot be represented in type 'long' > Fixes: > 35332/clusterfuzz-testcase-minimized-ffmpeg_dem_MATROSKA_fuzzer-5868035117285376 > > Found-by: cont

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/exr: Fix undefined integer multiplication

On Mon, Sep 13, 2021 at 11:30:31PM -0300, James Almer wrote: > On 9/13/2021 7:48 PM, Michael Niedermayer wrote: > > Fixes: signed integer overflow: 7020950083487072256 * 2 cannot be > > represented in type 'long long' > > Fixes: > > 37523/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_EXR_fuzz

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/jpeg2000_parser: Check state!=0

On Tue, Sep 14, 2021 at 07:35:50AM +0200, Paul B Mahol wrote: > lgtm will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB I am the wisest man alive, for I know one thing, and that is that I know nothing. -- Socrates signature.asc Description: PGP si

Re: [FFmpeg-devel] [PATCH] avformat/mov: Check for duplicate clli

On Mon, Sep 13, 2021 at 06:07:17PM -0300, James Almer wrote: > On 9/13/2021 6:04 PM, Michael Niedermayer wrote: > > Fixes: memleak > > Fixes: > > 35261/clusterfuzz-testcase-minimized-ffmpeg_dem_MOV_fuzzer-4869656287510528 > > > > Found-by: continuous fuzzing process > > https://github.com/google

Re: [FFmpeg-devel] [PATCH v2] fftools/ffprobe: Don't access AVProgram.(start|end)_time

On 14.09.2021 15:05, Andreas Rheinhardt wrote: These are internal fields. Signed-off-by: Andreas Rheinhardt --- Thanks, Tobias. I guess this version is fine, isn't it? doc/ffprobe.xsd | 4 fftools/ffprobe.c | 4 2 files changed, 8 deletions(-) Changes in ffprobe.c and ffprob

Re: [FFmpeg-devel] [PATCH 02/14] avformat/mp3dec: Avoid calling avio_tell() multiple times

Andreas Rheinhardt: > Signed-off-by: Andreas Rheinhardt > --- > libavformat/mp3dec.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/libavformat/mp3dec.c b/libavformat/mp3dec.c > index 195d89814e..9205abebc4 100644 > --- a/libavformat/mp3dec.c > +++ b/libavformat/m

[FFmpeg-devel] [PATCH v2] fftools/ffprobe: Don't access AVProgram.(start|end)_time

These are internal fields. Signed-off-by: Andreas Rheinhardt --- Thanks, Tobias. I guess this version is fine, isn't it? doc/ffprobe.xsd | 4 fftools/ffprobe.c | 4 2 files changed, 8 deletions(-) diff --git a/doc/ffprobe.xsd b/doc/ffprobe.xsd index 79784b5146..b65e54dbef 100644 --

[FFmpeg-devel] [PATCH] avcodec/h264_picture: wait for the second slice to apply film grain on interlaced content

Fixes: Assertion failure Fixes: clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_H264_fuzzer-6581961297100800 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: James Almer --- libavcodec/h264_picture.c | 2 +- 1 file changed, 1

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/hevc_sei: check size before using it

On Tue, Sep 14, 2021 at 6:50 PM wrote: > > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavcodec/hevc_sei.c | 31 +-- > 1 file changed, 25 insertions(+), 6 deletions(-) > > diff --git a/libavcodec/hevc_sei.c b/libavcodec/hevc_sei.c > index 2c326bf..29d034

[FFmpeg-devel] [PATCH] avutil/imgutils: use INT64_MAX for alloc buffer check and image size check

check alloc buffer size limit from INT_MAX to INT64_MAX check stride and stride*(uint64_t)(h+128) look into the Picture size condition using INT_MAX is smaller, so make it to INT64_MAX maybe large enough for Picture. Signed-off-by: Steven Liu --- libavutil/imgutils.c | 2 +- libavutil/imgutils.h

[FFmpeg-devel] [PATCH 3/3] avcodec/dynamic_hdr10_plus: check size before using it

From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/dynamic_hdr10_plus.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavcodec/dynamic_hdr10_plus.c b/libavcodec/dynamic_hdr10_plus.c index 854e70d..34a44aa 100644 --- a/libavcodec/dynamic_hdr10_plus.c +++ b/li

[FFmpeg-devel] [PATCH 2/3] avcodec/dynamic_hdr10_plus: use AVERROR_INVALIDDATA instead of AVERROR(EINVAL)

From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/dynamic_hdr10_plus.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/libavcodec/dynamic_hdr10_plus.c b/libavcodec/dynamic_hdr10_plus.c index a602e60..854e70d 100644 --- a/libavcodec/dyna

[FFmpeg-devel] [PATCH 1/3] avcodec/hevc_sei: check size before using it

From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/hevc_sei.c | 31 +-- 1 file changed, 25 insertions(+), 6 deletions(-) diff --git a/libavcodec/hevc_sei.c b/libavcodec/hevc_sei.c index 2c326bf..29d0346 100644 --- a/libavcodec/hevc_sei.c +++ b/libavcodec/hevc

[FFmpeg-devel] [PATCH] avutil/buffer: Avoid allocation of AVBuffer when using buffer pool

Do this by putting an AVBuffer structure into BufferPoolEntry and reuse it for all subsequent uses of said BufferPoolEntry. Signed-off-by: Andreas Rheinhardt --- libavutil/buffer.c | 44 + libavutil/buffer_internal.h | 11 ++ 2 files changed,

Re: [FFmpeg-devel] [PATCH] avutil/imgutils: use INT64_MAX for check stride and stride*(uint64_t)(h+128)

Steven Liu: > look into the Picture size condition using INT_MAX is smaller, > so make it to INT64_MAX maybe large enough for Picture. > before patch: > [mjpeg @ 0x61904b80] [IMGUTILS @ 0x7ffee7e71210] Picture size 15748x23622 > is invalid > [image2 @ 0x61600680] decoding for stream 0 fail

[FFmpeg-devel] [PATCH] avutil/imgutils: use INT64_MAX for check stride and stride*(uint64_t)(h+128)

look into the Picture size condition using INT_MAX is smaller, so make it to INT64_MAX maybe large enough for Picture. before patch: [mjpeg @ 0x61904b80] [IMGUTILS @ 0x7ffee7e71210] Picture size 15748x23622 is invalid [image2 @ 0x61600680] decoding for stream 0 failed [image2 @ 0x61600