Re: [FFmpeg-devel] [PATCH v2 10/14] avfilter/avfilter: Remove redundant parsing code

2021-09-13 Thread Paul B Mahol
lgtm ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/jpeg2000_parser: Check state!=0

2021-09-13 Thread Paul B Mahol
lgtm ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH v2 03/14] avfilter/vf_readeia608: Use av_dict_set_int()

2021-09-13 Thread Paul B Mahol
lgtm ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 1/4] libavfilter/x86/vf_hflip: add ff_flip_byte/short_avx512()

2021-09-13 Thread Wu, Jianhua
Paul B Mahol wrote: > > will apply soon if nobody objects > Hi Paul, It seemed that there is no one with objection over the past two weeks. Are the patches able to be applied? Best regards, Jianhua ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/exr: Fix undefined integer multiplication

2021-09-13 Thread James Almer
On 9/13/2021 7:48 PM, Michael Niedermayer wrote: Fixes: signed integer overflow: 7020950083487072256 * 2 cannot be represented in type 'long long' Fixes: 37523/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_EXR_fuzzer-5133634955771904 Found-by: continuous fuzzing process https://github.com

Re: [FFmpeg-devel] [PATCH v1 1/1] libavformat/amr.c: remove mode range check

2021-09-13 Thread Sun Zhenliang
在 2021年9月8日 +0800 21:48,Sun Zhenliang ,写道: > 在 2021年9月8日 +0800 17:55,Hendrik Leppkes ,写道: > > On Sat, Sep 4, 2021 at 1:52 PM Sun Zhenliang > > wrote: > > > > > > Thanks for reviewing. > > > > > > Probing is expecting to find “correct” frames, which includes those kinds > > > of comfort noise and

Re: [FFmpeg-devel] [PATCH v1 1/1] libavformat/amr.c: remove mode range check

2021-09-13 Thread Sun Zhenliang
在 2021年9月8日 +0800 22:12,Sun Zhenliang ,写道: > 在 2021年9月8日 +0800 17:10,Paul B Mahol ,写道: > > On Wed, Sep 8, 2021 at 10:56 AM Sun Zhenliang > > wrote: > > > > > 在 2021年9月8日 +0800 16:37,Paul B Mahol ,写道: > > > > On Wed, Sep 8, 2021 at 4:23 AM Sun Zhenliang > > > > > > > wrote: > > > > > > > > > 在 202

[FFmpeg-devel] [PATCH v2 14/14] avfilter/avfilter: Report all unrecognized options in avfilter_init_str

2021-09-13 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavfilter/avfilter.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/libavfilter/avfilter.c b/libavfilter/avfilter.c index 4971ad9d9f..998db32d56 100644 --- a/libavfilter/avfilter.c +++ b/libavfilter/avfilter.c @@ -921,7 +921,7 @@ i

[FFmpeg-devel] [PATCH v2 13/14] avfilter/avfilter: Don't fail upon options for filter without AVClass

2021-09-13 Thread Andreas Rheinhardt
Commit 62549f9655c48f0ec061087fa33a96040ce01145 added a check to (the predecessor of) avfilter_init_str() to error out if options were provided to a filter without options (or rather, without private class). This was fine at the time, yet soon afterwards commit fdd93eabfb2644f541f7aac9943abce26776e

[FFmpeg-devel] [PATCH v2 12/14] avfilter/avfilter: Honour the short options documentation

2021-09-13 Thread Andreas Rheinhardt
The documentation for filter arguments states that short options must precede long options (i.e. those of the form key=value). Yet if process_options() encounters arguments not abiding by this, it simply treats short options after a long option as if it were parsing short options for the first time

[FFmpeg-devel] [PATCH v2 11/14] avfilter/avfilter: Use AV_DICT_DONT_STRDUP_(KEY|VAL) when possible

2021-09-13 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavfilter/avfilter.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/libavfilter/avfilter.c b/libavfilter/avfilter.c index 11d4e01807..cc499fd5ed 100644 --- a/libavfilter/avfilter.c +++ b/libavfilter/avfilter.c @@ -822,6 +822,7 @@

[FFmpeg-devel] [PATCH v2 10/14] avfilter/avfilter: Remove redundant parsing code

2021-09-13 Thread Andreas Rheinhardt
avfilter_init_str() (via process_options()) both applies options extracted from the given string directly to the relevant (private) context as well as to an AVDictionary that is later given to avfilter_init_dict() which applies these options again. This is unnecessary, so leave applying the options

[FFmpeg-devel] [PATCH v2 09/14] avfilter/vf_scale: Honour the AVFilter.init_dict documentation

2021-09-13 Thread Andreas Rheinhardt
The documentation states that unrecognized options need to be returned (just as av_opt_set_dict() would do). Yet the scale and scale2ref filters didn't abide by this: They simply copied all options and in case it contained an unrecognized option was among them, they would error out later in config_

[FFmpeg-devel] [PATCH v2 08/14] avfilter/vf_zscale: Use init instead of init_dict

2021-09-13 Thread Andreas Rheinhardt
The AVDictionary was unused. Signed-off-by: Andreas Rheinhardt --- libavfilter/vf_zscale.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavfilter/vf_zscale.c b/libavfilter/vf_zscale.c index dfea00f9eb..e2715eb8dc 100644 --- a/libavfilter/vf_zscale.c +++ b/libavfilter

[FFmpeg-devel] [PATCH v2 07/14] avfilter/vf_spp: Add dummy element to array to avoid shift

2021-09-13 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavfilter/vf_spp.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/libavfilter/vf_spp.c b/libavfilter/vf_spp.c index 6c15dbaf66..b9b5f7bc78 100644 --- a/libavfilter/vf_spp.c +++ b/libavfilter/vf_spp.c @@ -93,7 +93,8 @@ DECLARE_ALI

[FFmpeg-devel] [PATCH v2 06/14] avfilter/vf_spp: Use preinit instead of init_dict

2021-09-13 Thread Andreas Rheinhardt
By using preinit, the AVDCT already exists directly after allocating the filter, so that the filter's AVClass's child_next becomes usable for setting options with the AV_OPT_SEARCH_CHILDREN search flag. This means that it is no longer necessary to use the init_dict callback for this filter. Furthe

[FFmpeg-devel] [PATCH v2 05/14] avfilter/af_aresample: Use preinit instead of init_dict

2021-09-13 Thread Andreas Rheinhardt
By using preinit, the SwrContext already exists directly after allocating the filter, so that the filter's AVClass's child_next becomes usable for setting options with the AV_OPT_SEARCH_CHILDREN search flag. This means that it is no longer necessary to use the init_dict callback for this filter. F

[FFmpeg-devel] [PATCH v2 04/14] avformat/rtsp: Use av_dict_set_int()

2021-09-13 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavformat/rtsp.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c index 3772a7f2a9..a3e9b9a1a2 100644 --- a/libavformat/rtsp.c +++ b/libavformat/rtsp.c @@ -122,12 +122,9 @@ static const AVOpt

[FFmpeg-devel] [PATCH v2 03/14] avfilter/vf_readeia608: Use av_dict_set_int()

2021-09-13 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavfilter/vf_readeia608.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libavfilter/vf_readeia608.c b/libavfilter/vf_readeia608.c index 2d6d0653a1..5ce2e75213 100644 --- a/libavfilter/vf_readeia608.c +++ b/libavfilter/vf_readeia608.c

[FFmpeg-devel] [PATCH v2 02/14] avfilter/vf_scale: Deduplicate AVClasses

2021-09-13 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- This one is new. libavfilter/vf_scale.c | 13 ++--- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/libavfilter/vf_scale.c b/libavfilter/vf_scale.c index 6c7f4dc9ab..a1902a13cf 100644 --- a/libavfilter/vf_scale.c +++ b/libavfilter/vf_s

[FFmpeg-devel] [PATCH 3/3] tools/target_dec_fuzzer: Adjust threshold for WMV3

2021-09-13 Thread Michael Niedermayer
Fixes: Timeout clearing images Fixes: 37726/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WMV3_fuzzer-4604669570187264 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- tools/target_dec_fuzzer.c | 1 +

[FFmpeg-devel] [PATCH 1/3] avcodec/jpeg2000_parser: Check state!=0

2021-09-13 Thread Michael Niedermayer
Fixes: out of array read Fixes: 37664/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_JPEG2000_fuzzer-5893420460146688 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/jpeg2000_parser.c | 2 +

[FFmpeg-devel] [PATCH 2/3] avcodec/exr: Fix undefined integer multiplication

2021-09-13 Thread Michael Niedermayer
Fixes: signed integer overflow: 7020950083487072256 * 2 cannot be represented in type 'long long' Fixes: 37523/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_EXR_fuzzer-5133634955771904 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed

[FFmpeg-devel] [PATCH v2 01/14] avfilter/vsrc_testsrc: Deduplicate AVClasses

2021-09-13 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- I am not resending all the deduplication patches; they can be e.g. found here: https://github.com/mkver/FFmpeg/commits/avfilter_deduplication libavfilter/vsrc_testsrc.c | 47 +- 1 file changed, 16 insertions(+), 31 deletio

Re: [FFmpeg-devel] [PATCH 3/4] avcodec/mpegutils: consolidate single byte av_log()

2021-09-13 Thread Michael Niedermayer
On Sat, Sep 04, 2021 at 01:37:26PM -0300, James Almer wrote: > On 9/4/2021 12:28 PM, Michael Niedermayer wrote: > > On Fri, Sep 03, 2021 at 03:45:55PM -0300, James Almer wrote: > > > On 9/3/2021 3:39 PM, Michael Niedermayer wrote: > > > > Fixes: Timeout (56sec -> 15sec) > > > > Fixes: > > > > 3714

Re: [FFmpeg-devel] [PATCH v3] avcodec/h264dec: apply H.274 film grain

2021-09-13 Thread Michael Niedermayer
On Tue, Aug 17, 2021 at 09:54:56PM +0200, Niklas Haas wrote: > From: Niklas Haas > > Because we need access to ref frames without film grain applied, we have > to add an extra AVFrame to H264Picture to avoid messing with the > original. This requires some amount of overhead to make the reference

Re: [FFmpeg-devel] [PATCH] avformat/mov: Check for duplicate clli

2021-09-13 Thread James Almer
On 9/13/2021 6:04 PM, Michael Niedermayer wrote: Fixes: memleak Fixes: 35261/clusterfuzz-testcase-minimized-ffmpeg_dem_MOV_fuzzer-4869656287510528 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libav

[FFmpeg-devel] [PATCH] avformat/mov: Check for duplicate clli

2021-09-13 Thread Michael Niedermayer
Fixes: memleak Fixes: 35261/clusterfuzz-testcase-minimized-ffmpeg_dem_MOV_fuzzer-4869656287510528 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavformat/mov.c | 3 +++ 1 file changed, 3 insertions(+

Re: [FFmpeg-devel] [PATCH 1/3] avformat/matroskadec: Reset state also on failure in matroska_reset_status()

2021-09-13 Thread Andreas Rheinhardt
Michael Niedermayer: > On Mon, Jul 19, 2021 at 11:12:11PM +0200, Andreas Rheinhardt wrote: >> Michael Niedermayer: >>> On Fri, Jul 02, 2021 at 06:17:58PM +0200, Andreas Rheinhardt wrote: Michael Niedermayer: > The calling code does not handle failures and will fail with assertion > fa

Re: [FFmpeg-devel] [PATCH 1/3] avformat/matroskadec: Reset state also on failure in matroska_reset_status()

2021-09-13 Thread Michael Niedermayer
On Mon, Jul 19, 2021 at 11:12:11PM +0200, Andreas Rheinhardt wrote: > Michael Niedermayer: > > On Fri, Jul 02, 2021 at 06:17:58PM +0200, Andreas Rheinhardt wrote: > >> Michael Niedermayer: > >>> The calling code does not handle failures and will fail with assertion > >>> failures later. > >>> Seek

Re: [FFmpeg-devel] [PATCH] avformat/jacosubdec: Check for min in t overflow in get_shift()

2021-09-13 Thread Michael Niedermayer
On Sat, Jun 05, 2021 at 04:30:14PM +0200, Michael Niedermayer wrote: > Fixes: negation of -2147483648 cannot be represented in type 'int'; cast to > an unsigned type to negate this value to itself > Fixes: > 34651/clusterfuzz-testcase-minimized-ffmpeg_dem_JACOSUB_fuzzer-5157941012463616 > > Foun

Re: [FFmpeg-devel] [PATCH v2 2/2] swresample/aarch64: fix relocation out of range error

2021-09-13 Thread Michael Niedermayer
On Mon, Sep 13, 2021 at 03:14:54PM +0300, Martin Storsjö wrote: > On Mon, 13 Sep 2021, Zhao Zhili wrote: > > > From: Zhao Zhili > > > > --- > > v2: add local labels instead of changing the code > > > > libswresample/aarch64/audio_convert_neon.S | 6 -- > > 1 file changed, 4 insertions(+), 2

Re: [FFmpeg-devel] [PATCH 1/4] avformat/mxfdec: check channel number in mxf_get_d10_aes3_packet()

2021-09-13 Thread Michael Niedermayer
On Sun, Sep 12, 2021 at 02:58:52PM +0200, Tomas Härdin wrote: > sön 2021-09-05 klockan 21:24 +0200 skrev Michael Niedermayer: > > Fixes: Out of array access > > Fixes: 37030/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer- > > 5387719147651072 > > > > Found-by: continuous fuzzing process > >

Re: [FFmpeg-devel] [PATCH] configure: account for openssl3 license change

2021-09-13 Thread Timo Rothenpieler
will push this soon smime.p7s Description: S/MIME Cryptographic Signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org

Re: [FFmpeg-devel] [PATCH 09/10] avcodec/avcodec, options_table: Deprecate sub_text_format

2021-09-13 Thread Soft Works
> -Original Message- > From: Andreas Rheinhardt > Sent: Monday, 13 September 2021 15:54 > To: ffmpeg-devel@ffmpeg.org > Cc: Andreas Rheinhardt ; Soft Works > > Subject: [PATCH 09/10] avcodec/avcodec, options_table: Deprecate > sub_text_format > > Unused since 1f63665ca567fbc49fa80166d

Re: [FFmpeg-devel] [PATCH 08/10] avfilter/vf_subtitles, fftools/ffmpeg: Don't set sub_text_format

2021-09-13 Thread Soft Works
> -Original Message- > From: Andreas Rheinhardt > Sent: Monday, 13 September 2021 15:54 > To: ffmpeg-devel@ffmpeg.org > Cc: Andreas Rheinhardt ; Soft Works > > Subject: [PATCH 08/10] avfilter/vf_subtitles, fftools/ffmpeg: Don't > set sub_text_format > > Unnecessary since 1f63665ca567f

Re: [FFmpeg-devel] [PATCH 04/10] fftools/cmdutils: Don't report AV_CODEC_CAP_TRUNCATED after next bump

2021-09-13 Thread James Almer
On 9/13/2021 10:53 AM, Andreas Rheinhardt wrote: Signed-off-by: Andreas Rheinhardt --- Could also be removed now. fftools/cmdutils.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fftools/cmdutils.c b/fftools/cmdutils.c index ac172dbd65..6a61f7a5e4 100644 --- a/fftools/cmdutils.c +++

[FFmpeg-devel] [PATCH 10/10] avcodec/opus_silk: Remove wrong size information in function declaration

2021-09-13 Thread Andreas Rheinhardt
silk_lsp2poly()'s declaration contained arrays with array sizes; yet these array sizes exceeded the number of actually accessed array elements (which is related to another parameter) and this leads to -Wstringop-overflow= warnings from GCC 11, because the arrays provided by callers are only large e

[FFmpeg-devel] [PATCH 09/10] avcodec/avcodec, options_table: Deprecate sub_text_format

2021-09-13 Thread Andreas Rheinhardt
Unused since 1f63665ca567fbc49fa80166d468a822c2999efa. Found-by: Soft Works Signed-off-by: Andreas Rheinhardt --- doc/APIchanges | 4 libavcodec/avcodec.h | 7 --- libavcodec/options_table.h | 4 +++- libavcodec/version.h | 3 +++ 4 files changed, 14 insertions(

[FFmpeg-devel] [PATCH 08/10] avfilter/vf_subtitles, fftools/ffmpeg: Don't set sub_text_format

2021-09-13 Thread Andreas Rheinhardt
Unnecessary since 1f63665ca567fbc49fa80166d468a822c2999efa, because the value the option is set to coincides with the default value. Found-by: Soft Works Signed-off-by: Andreas Rheinhardt --- fftools/ffmpeg.c | 2 -- libavfilter/vf_subtitles.c | 1 - 2 files changed, 3 deletions(-) d

[FFmpeg-devel] [PATCH 07/10] avutil/opt: Simplify av_opt_set_dict2()

2021-09-13 Thread Andreas Rheinhardt
Make it clearer that the ordinary exit always returns 0. Signed-off-by: Andreas Rheinhardt --- libavutil/opt.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/libavutil/opt.c b/libavutil/opt.c index 24b8899ca0..f05283d610 100644 --- a/libavutil/opt.c +++ b/libavutil/opt.

[FFmpeg-devel] [PATCH 06/10] avutil/opt: Also warn for deprecated named constants

2021-09-13 Thread Andreas Rheinhardt
Intended for the "truncated" AVCodecContext flag. Signed-off-by: Andreas Rheinhardt --- libavutil/opt.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/libavutil/opt.c b/libavutil/opt.c index 41284d4ecd..24b8899ca0 100644 --- a/libavutil/opt.c +++ b/libavutil/opt.c @@

[FFmpeg-devel] [PATCH 05/10] Revert "fate: Add test for ticket 6024, truncated decoding mode"

2021-09-13 Thread Andreas Rheinhardt
From: Anton Khirnov This reverts commit 47cd8effea343e71c4010929ed3fb10dd3dca4b1. AV_CODEC_FLAG_TRUNCATED is now deprecated. --- tests/fate/video.mak| 3 --- tests/ref/fate/mpeg2-ticket6024 | 27 --- 2 files changed, 30 deletions(-) delete mode 100644 tests/

[FFmpeg-devel] [PATCH 04/10] fftools/cmdutils: Don't report AV_CODEC_CAP_TRUNCATED after next bump

2021-09-13 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- Could also be removed now. fftools/cmdutils.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fftools/cmdutils.c b/fftools/cmdutils.c index ac172dbd65..6a61f7a5e4 100644 --- a/fftools/cmdutils.c +++ b/fftools/cmdutils.c @@ -1399,8 +1399,10 @@ static vo

[FFmpeg-devel] [PATCH 03/10] avcodec/(h263|mpeg4?video)_parser: Make *_find_frame_end() static

2021-09-13 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- Could be merged into the preceding commit. libavcodec/h263_parser.c | 11 ++ libavcodec/mpeg12.c| 2 + libavcodec/mpeg12.h| 2 + libavcodec/mpeg4video_parser.c | 15 libavcodec/mpegvideo.h | 2 + libavcod

[FFmpeg-devel] [PATCH 02/10] lavc: deprecate AV_CODEC_(FLAG|CAP)_TRUNCATED

2021-09-13 Thread Andreas Rheinhardt
From: Anton Khirnov It is supported only by a few decoders (h263, h263p, mpeg(1|2|)video and mpeg4) and is entirely redundant with parsers. Furthermore, using it leads to missing frames, as flushing the decoder at the end does not work properly. Co-authored-by: Andreas Rheinhardt Signed-off-by:

[FFmpeg-devel] [PATCH 01/10] avcodec/mpegvideo: Move startcodes to mpeg12.h

2021-09-13 Thread Andreas Rheinhardt
And remove the MPEG-4-specific SLICE_START_CODE, which duplicates SLICE_STARTCODE. Signed-off-by: Andreas Rheinhardt --- I can add a commit giving these startcodes a proper MPEG12_ prefix later if desired. (Some of these startcodes are btw duplicated in lavf/mpegvideodec.c.) libavcodec/ituh263d

Re: [FFmpeg-devel] [PATCH v2 2/2] swresample/aarch64: fix relocation out of range error

2021-09-13 Thread zhilizhao(赵志立)
> On Sep 13, 2021, at 8:14 PM, Martin Storsjö wrote: > > On Mon, 13 Sep 2021, Zhao Zhili wrote: > >> From: Zhao Zhili >> >> --- >> v2: add local labels instead of changing the code >> >> libswresample/aarch64/audio_convert_neon.S | 6 -- >> 1 file changed, 4 insertions(+), 2 deletions(-)

[FFmpeg-devel] [PATCH] avfilter: add scale2ref_npp video filter

2021-09-13 Thread Roman Arzumanyan
This patch adds scale2ref_npp video filter which is similar to scale2ref, but accelerated by NPP. CLI sample: ./ffmpeg \ -hwaccel cuda -hwaccel_output_format cuda \ -i ./bbb_sunflower_1080p_30fps_normal.mp4 \ -i ./920px-Wilber-huge-alpha.png \ -filter_complex "[0:v]scale_npp=format=

[FFmpeg-devel] [PATCH] avfilter: add sharpen_npp video filter

2021-09-13 Thread Roman Arzumanyan
This patch adds simple sharpening filter which is accelerated by NPP. CLI sample: ./ffmpeg \ -hwaccel cuda -hwaccel_output_format cuda \ -i ./input.mp4 \ -vf sharpen_npp \ -c:v hevc_nvenc \ -y ./output_sharp.mp4 From 0df6297bd3664beb05c813c5fc62852e61616fa9 Mon Sep 17 00:00:00 20

Re: [FFmpeg-devel] [PATCH 25/38] avfilter/avfilter: Honour the short options documentation

2021-09-13 Thread Andreas Rheinhardt
Nicolas George: > Andreas Rheinhardt (12021-09-12): >> The documentation for filter arguments states that short options must >> precede long options (i.e. those of the form key=value). Yet if >> process_options() encounters arguments not abiding by this, it simply >> treats short options after a lo

Re: [FFmpeg-devel] [PATCH] libavcodec/hevc_mp4toannexb_bsf: ignore extra data if possible

2021-09-13 Thread Artem Galin
LGTM. On Fri, 10 Sept 2021 at 05:10, Haihao Xiang wrote: > > It is possible that an IRAP frame in input AVPacket has SPS and PPS, and > these headers should take effect. Hence we should not prepend extra data > to IRAP frame in this case, otherwise an IRAP frame in output AVPacket > will have 2 S

Re: [FFmpeg-devel] [PATCH v2 2/2] swresample/aarch64: fix relocation out of range error

2021-09-13 Thread Martin Storsjö
On Mon, 13 Sep 2021, Zhao Zhili wrote: From: Zhao Zhili --- v2: add local labels instead of changing the code libswresample/aarch64/audio_convert_neon.S | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/libswresample/aarch64/audio_convert_neon.S b/libswresample/aarch64

Re: [FFmpeg-devel] [PATCH 25/38] avfilter/avfilter: Honour the short options documentation

2021-09-13 Thread Nicolas George
Andreas Rheinhardt (12021-09-12): > The documentation for filter arguments states that short options must > precede long options (i.e. those of the form key=value). Yet if > process_options() encounters arguments not abiding by this, it simply > treats short options after a long option as if it wer

Re: [FFmpeg-devel] [PATCH 25/38] avfilter/avfilter: Honour the short options documentation

2021-09-13 Thread Andreas Rheinhardt
Paul B Mahol: > lgtm > maybe add log messages about ignored stuff > avfilter_init_str() already contains a log message about ignored stuff; but it is currently dead code, because process_options() errors out if it encounters an unknown option. That way only the first unrecognized option will be p

Re: [FFmpeg-devel] [PATCH 29/38] avfilter/vf_vflip: Remove empty options and AVClass

2021-09-13 Thread Paul B Mahol
lgtm ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 30/38] avfilter/vf_hflip: Remove empty options and AVClass

2021-09-13 Thread Paul B Mahol
lgtm ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 25/38] avfilter/avfilter: Honour the short options documentation

2021-09-13 Thread Paul B Mahol
lgtm maybe add log messages about ignored stuff ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 26/38] avfilter/avfilter: Don't fail upon options for filter without AVClass

2021-09-13 Thread Paul B Mahol
lgtm ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 22/38] avfilter/avfilter: Remove unused count

2021-09-13 Thread Paul B Mahol
lgtm ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 02/39] avfilter/internal: Add AVFILTER_DEFINE_CLASS_EXT

2021-09-13 Thread Paul B Mahol
lgtm ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 32/38] avfilter/vf_grayworld: Remove empty options and AVClass

2021-09-13 Thread Paul B Mahol
lgtm ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 01/39] avfilter/vf_maskedminmax: Simplify init

2021-09-13 Thread Paul B Mahol
lgtm ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 31/38] avfilter/vf_hflip: Don't call av_pix_fmt_desc_get() twice

2021-09-13 Thread Paul B Mahol
lgtm ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH v2 2/2] swresample/aarch64: fix relocation out of range error

2021-09-13 Thread Zhao Zhili
From: Zhao Zhili --- v2: add local labels instead of changing the code libswresample/aarch64/audio_convert_neon.S | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/libswresample/aarch64/audio_convert_neon.S b/libswresample/aarch64/audio_convert_neon.S index 74feff448a..

Re: [FFmpeg-devel] [PATCH 23/38] avfilter/avfilter: Remove redundant parsing code

2021-09-13 Thread Paul B Mahol
lgtm ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 2/2] swresample/aarch64: fix relocation out of range error

2021-09-13 Thread Martin Storsjö
On Mon, 13 Sep 2021, Zhao Zhili wrote: From: Zhao Zhili --- libswresample/aarch64/audio_convert_neon.S | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libswresample/aarch64/audio_convert_neon.S b/libswresample/aarch64/audio_convert_neon.S index 74feff448a..9505b6 100

Re: [FFmpeg-devel] [PATCH 1/2] lavc/aarch64: fix relocation out of range error

2021-09-13 Thread Martin Storsjö
On Mon, 13 Sep 2021, Zhao Zhili wrote: From: Zhao Zhili Use a temporary label instead of global function symbol for b.gt. --- libavcodec/aarch64/videodsp.S | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/aarch64/videodsp.S b/libavcodec/aarch64/videodsp.S index 2

Re: [FFmpeg-devel] [PATCH v3 07/18] fftools/play, probe: Adjust for subtitle format type change

2021-09-13 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Tobias Rapp > Sent: Monday, 13 September 2021 09:41 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH v3 07/18] fftools/play, probe: > Adjust for subtitle format type change > > On 11.09.2021 08:02, Soft Works wr

Re: [FFmpeg-devel] [PATCH v3 07/18] fftools/play, probe: Adjust for subtitle format type change

2021-09-13 Thread Tobias Rapp
On 11.09.2021 08:02, Soft Works wrote: Signed-off-by: softworkz --- fftools/ffplay.c | 2 +- fftools/ffprobe.c | 23 ++- 2 files changed, 23 insertions(+), 2 deletions(-) diff --git a/fftools/ffplay.c b/fftools/ffplay.c index 46758b9f55..f6a4d242c3 100644 --- a/fftools

[FFmpeg-devel] [PATCH 2/2] swresample/aarch64: fix relocation out of range error

2021-09-13 Thread Zhao Zhili
From: Zhao Zhili --- libswresample/aarch64/audio_convert_neon.S | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libswresample/aarch64/audio_convert_neon.S b/libswresample/aarch64/audio_convert_neon.S index 74feff448a..9505b6 100644 --- a/libswresample/aarch64/audio_co

[FFmpeg-devel] [PATCH 1/2] lavc/aarch64: fix relocation out of range error

2021-09-13 Thread Zhao Zhili
From: Zhao Zhili Use a temporary label instead of global function symbol for b.gt. --- libavcodec/aarch64/videodsp.S | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/aarch64/videodsp.S b/libavcodec/aarch64/videodsp.S index 24067cc2af..fe2da0658e 100644 --- a/libav