[FFmpeg-devel] [PATCH v3 7/7] libavfilter: Send only input frame for DNN Detect and Classify

2021-08-23 Thread Shubhanshu Saxena
This commit updates the following two filters to send only the input frame and send NULL as output frame instead of input frame to the DNN backends. 1. vf_dnn_detect 2. vf_dnn_classify Signed-off-by: Shubhanshu Saxena --- libavfilter/dnn/dnn_backend_common.c | 2 +- libavfilter/dnn/dnn_backe

[FFmpeg-devel] [PATCH v3 6/7] doc/filters.texi: Include dnn_processing in docs of sr and derain filter

2021-08-23 Thread Shubhanshu Saxena
Signed-off-by: Shubhanshu Saxena --- doc/filters.texi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/filters.texi b/doc/filters.texi index d99368e64b..112adc5d94 100644 --- a/doc/filters.texi +++ b/doc/filters.texi @@ -9982,7 +9982,7 @@ Note that different backends us

[FFmpeg-devel] [PATCH v3 5/7] lavfi/dnn: Rename InferenceItem to LastLevelTaskItem

2021-08-23 Thread Shubhanshu Saxena
This patch renames the InferenceItem to LastLevelTaskItem in the three backends to avoid confusion among the meanings of these structs. The following are the renames done in this patch: 1. extract_inference_from_task -> extract_lltask_from_task 2. InferenceItem -> LastLevelTaskItem 3. inference_q

[FFmpeg-devel] [PATCH v3 4/7] libavfilter: Remove Async Flag from DNN Filter Side

2021-08-23 Thread Shubhanshu Saxena
Remove async flag from filter's perspective after the unification of async and sync modes in the DNN backend. Signed-off-by: Shubhanshu Saxena --- doc/filters.texi | 14 -- libavfilter/dnn/dnn_backend_tf.c | 7 +++ libavfilter/dnn_filter_common.c | 7 --- l

[FFmpeg-devel] [PATCH v3 3/7] libavfilter: Remove synchronous functions from DNN filters

2021-08-23 Thread Shubhanshu Saxena
This commit removes the unused sync mode specific code from the DNN filters since the sync and async mode are now unified from the filters' perspective. Signed-off-by: Shubhanshu Saxena --- libavfilter/vf_dnn_detect.c | 71 +--- libavfilter/vf_dnn_processing.c | 84 +-

[FFmpeg-devel] [PATCH v3 2/7] libavfilter: Unify Execution Modes in DNN Filters

2021-08-23 Thread Shubhanshu Saxena
This commit unifies the async and sync mode from the DNN filters' perspective. As of this commit, the Native backend only supports synchronous execution mode. Now the user can switch between async and sync mode by using the 'async' option in the backend_configs. The values can be 1 for async and 0

[FFmpeg-devel] [PATCH v3 1/7] lavfi/dnn: Task-based Inference in Native Backend

2021-08-23 Thread Shubhanshu Saxena
This commit rearranges the code in Native Backend to use the TaskItem for inference. Signed-off-by: Shubhanshu Saxena --- libavfilter/dnn/dnn_backend_native.c | 176 ++- libavfilter/dnn/dnn_backend_native.h | 2 + 2 files changed, 121 insertions(+), 57 deletions(-) dif

Re: [FFmpeg-devel] [PATCH] avcodec/av1dec: Adjust incorrect error output

2021-08-23 Thread Wang, Fei W
On Tue, 2021-08-24 at 02:45 +, Soft Works wrote: > > -Original Message- > > From: ffmpeg-devel On Behalf Of > > Ronald S. Bultje > > Sent: Tuesday, 24 August 2021 04:34 > > To: FFmpeg development discussions and patches > de...@ffmpeg.org> > > Subject: Re: [FFmpeg-devel] [PATCH] avcod

Re: [FFmpeg-devel] [PATCH] avcodec/av1dec: Adjust incorrect error output

2021-08-23 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Ronald S. Bultje > Sent: Tuesday, 24 August 2021 04:34 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH] avcodec/av1dec: Adjust incorrect > error output > > Hi, > > On Mon,

Re: [FFmpeg-devel] [PATCH v2] avfilter: add libdewobble_opencl filter

2021-08-23 Thread Daniel Playfair Cal
On Tue, Aug 24, 2021 at 3:09 AM Paul B Mahol wrote: > library is named dewobble, thus filter should be libdewobble. Lynne suggested "libdewobble_opencl". I can rename it to "libdewobble" if you prefer, but will everyone be happy with that? Perhaps it will be easier if you explain the convention

Re: [FFmpeg-devel] [PATCH] avcodec/av1dec: Adjust incorrect error output

2021-08-23 Thread Ronald S. Bultje
Hi, On Mon, Aug 23, 2021 at 9:39 PM Soft Works wrote: > The current message "Your platform doesn't suppport > hardware accelerated AV1 decoding." is inaccurate and > misleading. When a user doesn't specify a hwcaccel, > this doesn't tell anything about what is actually > supported on that platfo

[FFmpeg-devel] [PATCH] avcodec/av1dec: Adjust incorrect error output

2021-08-23 Thread Soft Works
The current message "Your platform doesn't suppport hardware accelerated AV1 decoding." is inaccurate and misleading. When a user doesn't specify a hwcaccel, this doesn't tell anything about what is actually supported on that platform. Signed-off-by: softworkz --- libavcodec/av1dec.c | 4 ++-- 1

[FFmpeg-devel] [PATCH] libavformat/rtpdec_jpeg.c: quantization table headers not sent in every frame packet

2021-08-23 Thread Hayden Myers
MJPEG streams coming from Genetec VMS provide a quantization table for each frame, but only in the first packet. Before the packet data is copied to the frame buffer, a check is done to compare the fragment offset against the frame - header. The header is computed at the beginning of each frame. T

[FFmpeg-devel] [PATCH 2/2] avcodec/libx265: add support for setting chroma sample location

2021-08-23 Thread Jan Ekström
--- libavcodec/libx265.c | 8 1 file changed, 8 insertions(+) diff --git a/libavcodec/libx265.c b/libavcodec/libx265.c index b5c94b64a3..c58882170b 100644 --- a/libavcodec/libx265.c +++ b/libavcodec/libx265.c @@ -210,6 +210,14 @@ static av_cold int libx265_encode_init(AVCodecContext *av

[FFmpeg-devel] [PATCH 1/2] avcodec/libx264: add support for setting chroma sample location

2021-08-23 Thread Jan Ekström
--- libavcodec/libx264.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavcodec/libx264.c b/libavcodec/libx264.c index d48e142e41..379c167e6f 100644 --- a/libavcodec/libx264.c +++ b/libavcodec/libx264.c @@ -870,6 +870,8 @@ static av_cold int X264_init(AVCodecContext *avctx) x4->

Re: [FFmpeg-devel] [PATCH 2/2] fftools: add -lavfi_dump option

2021-08-23 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of Nicolas > George > Sent: Monday, 23 August 2021 11:45 > To: ffmpeg-devel@ffmpeg.org > Subject: [FFmpeg-devel] [PATCH 2/2] fftools: add -lavfi_dump option > > Signed-off-by: Nicolas George > --- > doc/ffmpeg.texi | 4

[FFmpeg-devel] [PATCH v3 1/1] avcodec/vp6: return value check for init_get_bits

2021-08-23 Thread maryam ebrahimzadeh
avcodec/vp6: Return value check for init_get_bits As the second argument for init_get_bits(buf) can be crafted, a return value check for this function call is necessary. Also replace init_get_bits with init_get_bits8. --- libavcodec/vp6.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)

[FFmpeg-devel] [PATCH v5 1/1] avcodec/vc1dec: Return value check for init_get_bits

2021-08-23 Thread maryam ebrahimzadeh
avcodec/vc1dec: Return value check for init_get_bits As the second argument for init_get_bits(avctx and buf) can be crafted, a return value check for this function call is necessary so replace init_get_bits with init_get_bits8 and add return value check. --- libavcodec/vc1dec.c | 11 ---

Re: [FFmpeg-devel] [PATCH v2] avfilter: add libdewobble_opencl filter

2021-08-23 Thread Paul B Mahol
On Mon, Aug 23, 2021 at 4:18 PM Daniel Playfair Cal < daniel.playfair@gmail.com> wrote: > All of the existing filters for video stabilization use an affine model > (or a limited version of it) to represent the movement of the camera. When > used with cameras with a very wide field of view and/

Re: [FFmpeg-devel] [PATCH 3/8] avformat/crcenc: Simplify writing trailer

2021-08-23 Thread Paul B Mahol
lgtm ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] [fateserver] Cleanup and security strengthening

2021-08-23 Thread Nicolas George
Michael Niedermayer (12021-08-23): > Please make sure you use g...@git.ffmpeg.org:fateserver not > g...@source.ffmpeg.org:fateserver My bad. I fixed it and it worked. Thanks. Regards, -- Nicolas George signature.asc Description: PGP signature ___

Re: [FFmpeg-devel] [PATCH] [fateserver] Cleanup and security strengthening

2021-08-23 Thread Michael Niedermayer
On Mon, Aug 23, 2021 at 04:32:02PM +0200, Nicolas George wrote: > Michael Niedermayer (12021-08-23): > > you should have write access to g...@git.ffmpeg.org:fateserver > > i see this key there: > > 4096 SHA256:JMjmh7/1eynBVRAprwk96+NfcFjmla4v/G/IlwVuuxQ cigaes@ssecem (RSA) > > ~/prog/fateserver $

Re: [FFmpeg-devel] [PATCH 1/9] avformat/aviobuf: Avoid calling function twice due to FFMAX()

2021-08-23 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Signed-off-by: Andreas Rheinhardt > --- > libavformat/aviobuf.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/libavformat/aviobuf.c b/libavformat/aviobuf.c > index 66fddf1433..164b07ae6a 100644 > --- a/libavformat/aviobuf.c > +++ b/libavform

Re: [FFmpeg-devel] [PATCH] [fateserver] Cleanup and security strengthening

2021-08-23 Thread Nicolas George
Michael Niedermayer (12021-08-23): > you should have write access to g...@git.ffmpeg.org:fateserver > i see this key there: > 4096 SHA256:JMjmh7/1eynBVRAprwk96+NfcFjmla4v/G/IlwVuuxQ cigaes@ssecem (RSA) ~/prog/fateserver $ git fetch origin-ssh ERROR:gitosis.serve.main:Repository read access denied

[FFmpeg-devel] [PATCH] avformat/{isom, mov, movenc}: add support for CMAF DASH roles

2021-08-23 Thread Jan Ekström
From: Jan Ekström This information is coded in a standard MP4 KindBox and utilizes the scheme and values as per the DASH role scheme defined in MPEG-DASH. Other schemes are technically allowed, but where multiple schemes define the same concepts, the DASH scheme should be utilized. Such flagging

Re: [FFmpeg-devel] [PATCH] [fateserver] Cleanup and security strengthening

2021-08-23 Thread Michael Niedermayer
On Mon, Aug 23, 2021 at 02:18:03PM +0200, Nicolas George wrote: > Nicolas George (12021-08-23): > > I will try to deploy the changes this shortly. > > To deploy the changes cleanly, I would need write access to the > fateserver Git repository. I already have access to the FATE server > itself, but

[FFmpeg-devel] [PATCH v2] avfilter: add libdewobble_opencl filter

2021-08-23 Thread Daniel Playfair Cal
All of the existing filters for video stabilization use an affine model (or a limited version of it) to represent the movement of the camera. When used with cameras with a very wide field of view and/or where the camera shaking is severe, the corrections result in significant geometric distortion (

Re: [FFmpeg-devel] [PATCH 2/8] avformat/movenc: Avoid calling strlen multiple times

2021-08-23 Thread Andreas Rheinhardt
James Almer: > On 8/23/2021 10:16 AM, Andreas Rheinhardt wrote: >> Signed-off-by: Andreas Rheinhardt >> --- >>   libavformat/movenc.c | 22 +- >>   1 file changed, 13 insertions(+), 9 deletions(-) >> >> diff --git a/libavformat/movenc.c b/libavformat/movenc.c >> index 18410c70fa

Re: [FFmpeg-devel] [PATCH 2/8] avformat/movenc: Avoid calling strlen multiple times

2021-08-23 Thread James Almer
On 8/23/2021 10:16 AM, Andreas Rheinhardt wrote: Signed-off-by: Andreas Rheinhardt --- libavformat/movenc.c | 22 +- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index 18410c70fa..acf9d63c52 100644 --- a/libavfo

[FFmpeg-devel] [PATCH 1/8] avformat/vorbiscomment: Don't compute strlen twice

2021-08-23 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavformat/vorbiscomment.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libavformat/vorbiscomment.c b/libavformat/vorbiscomment.c index a929634cc0..13ee065a44 100644 --- a/libavformat/vorbiscomment.c +++ b/libavformat/vorbiscommen

[FFmpeg-devel] [PATCH 7/8] avformat/flac_picture: Simplify parsing title

2021-08-23 Thread Andreas Rheinhardt
Don't allocate the buffer for the title ourselves, leave it to av_dict_set(). This simplifies freeing. Signed-off-by: Andreas Rheinhardt --- libavformat/flac_picture.c | 27 --- 1 file changed, 12 insertions(+), 15 deletions(-) diff --git a/libavformat/flac_picture.c b/l

[FFmpeg-devel] [PATCH 8/8] avformat/flac_picture: Reindentation

2021-08-23 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavformat/flac_picture.c | 23 +++ 1 file changed, 11 insertions(+), 12 deletions(-) diff --git a/libavformat/flac_picture.c b/libavformat/flac_picture.c index 3b69654ff6..0effbf04f6 100644 --- a/libavformat/flac_picture.c +++ b/libavfo

[FFmpeg-devel] [PATCH 6/8] avformat/flac_picture: Try to reuse buffer for attached picture

2021-08-23 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavformat/flac_picture.c | 15 +-- libavformat/flac_picture.h | 14 +- libavformat/flacdec.c| 2 +- libavformat/oggparsevorbis.c | 4 ++-- 4 files changed, 29 insertions(+), 6 deletions(-) diff --git a/libavformat/flac

[FFmpeg-devel] [PATCH 5/8] avformat/oggparsevorbis: Avoid tmp bufs when parsing VorbisComment

2021-08-23 Thread Andreas Rheinhardt
A single VorbisComment consists of a length field and a non-NUL-terminated string of the form "key=value". Up until now, when parsing such a VorbisComment, zero-terminated duplicates of key and value would be created. This is wasteful if these duplicates are freed shortly afterwards, as happens in

[FFmpeg-devel] [PATCH 4/8] avformat/oggparsevorbis: Factor parsing a single VorbisComment out

2021-08-23 Thread Andreas Rheinhardt
This is in preparation for further commits. Signed-off-by: Andreas Rheinhardt --- libavformat/oggparsevorbis.c | 142 ++- 1 file changed, 75 insertions(+), 67 deletions(-) diff --git a/libavformat/oggparsevorbis.c b/libavformat/oggparsevorbis.c index c48658ceda..

[FFmpeg-devel] [PATCH 3/8] avformat/crcenc: Simplify writing trailer

2021-08-23 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavformat/crcenc.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/libavformat/crcenc.c b/libavformat/crcenc.c index 4fdc448141..c58fbd6c88 100644 --- a/libavformat/crcenc.c +++ b/libavformat/crcenc.c @@ -48,10 +48,8 @@ static int crc

[FFmpeg-devel] [PATCH 2/8] avformat/movenc: Avoid calling strlen multiple times

2021-08-23 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavformat/movenc.c | 22 +- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index 18410c70fa..acf9d63c52 100644 --- a/libavformat/movenc.c +++ b/libavformat/movenc.c @@ -2766,6 +

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/pthread_frame: also keep AVCodecContext.properties in sync between threads

2021-08-23 Thread James Almer
On 8/16/2021 12:50 PM, James Almer wrote: Some frame threaded decoders set it, but this information never reached the caller in frame threading scenarios. Signed-off-by: James Almer --- libavcodec/pthread_frame.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/pthread_frame.c

Re: [FFmpeg-devel] [PATCH] [fateserver] Cleanup and security strengthening

2021-08-23 Thread James Almer
On 8/23/2021 9:51 AM, Nicolas George wrote: James Almer (12021-08-23): Assuming it's from 20.04.x to 20.04.2, it should be fine. But shouldn't this It is a bit older than that: Welcome to Ubuntu 18.04.5 LTS (GNU/Linux 4.15.0-151-generic x86_64) That makes it all the more necessary but also a

Re: [FFmpeg-devel] [PATCH] [fateserver] Cleanup and security strengthening

2021-08-23 Thread Nicolas George
James Almer (12021-08-23): > Assuming it's from 20.04.x to 20.04.2, it should be fine. But shouldn't this It is a bit older than that: Welcome to Ubuntu 18.04.5 LTS (GNU/Linux 4.15.0-151-generic x86_64) That makes it all the more necessary but also all the more risky. > kind of thing be done by

Re: [FFmpeg-devel] [PATCH] [fateserver] Cleanup and security strengthening

2021-08-23 Thread James Almer
On 8/23/2021 9:20 AM, Nicolas George wrote: Nicolas George (12021-08-23): To deploy the changes cleanly, I would need write access to the fateserver Git repository. I already have access to the FATE server itself, but not the public repository. Any objection to me doing: New release '20.04.2

Re: [FFmpeg-devel] [PATCH] [fateserver] Cleanup and security strengthening

2021-08-23 Thread Nicolas George
Nicolas George (12021-08-23): > To deploy the changes cleanly, I would need write access to the > fateserver Git repository. I already have access to the FATE server > itself, but not the public repository. Any objection to me doing: New release '20.04.2 LTS' available. Run 'do-release-upgrade' t

Re: [FFmpeg-devel] [PATCH] [fateserver] Cleanup and security strengthening

2021-08-23 Thread Nicolas George
Nicolas George (12021-08-23): > I will try to deploy the changes this shortly. To deploy the changes cleanly, I would need write access to the fateserver Git repository. I already have access to the FATE server itself, but not the public repository. Thanks in advance. -- Nicolas George sign

Re: [FFmpeg-devel] [PATCH v2 6/6] doc/filters.texi: Include dnn_processing in docs of sr and derain filter

2021-08-23 Thread Shubhanshu Saxena
On Mon, Aug 23, 2021 at 3:57 PM Fu, Ting wrote: > > > > -Original Message- > > From: ffmpeg-devel On Behalf Of > > Shubhanshu Saxena > > Sent: Saturday, August 21, 2021 03:59 PM > > To: ffmpeg-devel@ffmpeg.org > > Cc: Shubhanshu Saxena > > Subject: [FFmpeg-devel] [PATCH v2 6/6] doc/filt

Re: [FFmpeg-devel] [PATCH] [fateserver] Cleanup and security strengthening

2021-08-23 Thread Nicolas George
Chad Fraleigh (12021-08-22): > It mostly looks good (from a perl perspective). Thanks for the comments. > > Just 3 questionable items.. > > -<>-<>- > > -if ($ENV{HTTP_ACCEPT_ENCODING} =~ /gzip/) { > -print "Content-Encoding: gzip\r\n"; > +if (ready_for_gzip) { > $cat = 'cat'; > } >

Re: [FFmpeg-devel] [PATCH v2 6/6] doc/filters.texi: Include dnn_processing in docs of sr and derain filter

2021-08-23 Thread Fu, Ting
> -Original Message- > From: ffmpeg-devel On Behalf Of > Shubhanshu Saxena > Sent: Saturday, August 21, 2021 03:59 PM > To: ffmpeg-devel@ffmpeg.org > Cc: Shubhanshu Saxena > Subject: [FFmpeg-devel] [PATCH v2 6/6] doc/filters.texi: Include > dnn_processing > in docs of sr and derain fi

[FFmpeg-devel] [PATCH 2/2] fftools: add -lavfi_dump option

2021-08-23 Thread Nicolas George
Signed-off-by: Nicolas George --- doc/ffmpeg.texi | 4 fftools/ffmpeg.h| 1 + fftools/ffmpeg_filter.c | 14 ++ fftools/ffmpeg_opt.c| 3 +++ 4 files changed, 22 insertions(+) This will be useful for tests covering suble cases of the format negotiation. I d

[FFmpeg-devel] [PATCH 1/2] lavfi/graphdump: add plain listing output

2021-08-23 Thread Nicolas George
Signed-off-by: Nicolas George --- libavfilter/avfilter.h | 5 ++- libavfilter/graphdump.c | 79 +++-- 2 files changed, 80 insertions(+), 4 deletions(-) diff --git a/libavfilter/avfilter.h b/libavfilter/avfilter.h index 69ecb0186d..2a3c1e79a8 100644 --- a/lib

Re: [FFmpeg-devel] [PATCH v4 0/2] TTML in MP4, part 1

2021-08-23 Thread Jan Ekström
On Mon, Aug 16, 2021 at 3:26 PM Jan Ekström wrote: > > To keep it simpler this first part includes only non-fragmented use > cases if the built-in sample squashing is utilized. Contains the basic > mapping code as well as the function that writes out the squashed documents. > > Works with both sub

Re: [FFmpeg-devel] [PATCH v2 2/2] libavutil/x86/cpu.c: add IceLake-AVX512 runtime check

2021-08-23 Thread Wu, Jianhua
Ping. > -Original Message- > From: Wu, Jianhua > Sent: Wednesday, August 18, 2021 2:42 PM > To: ffmpeg-devel@ffmpeg.org > Cc: Wu, Jianhua > Subject: [PATCH v2 2/2] libavutil/x86/cpu.c: add IceLake-AVX512 runtime > check > > Signed-off-by: Wu Jianhua > --- > libavutil/x86/cpu.c | 5 ++-