Re: [FFmpeg-devel] [RFC] Suggestion for a Nicer Integration with GitHub

From the point of view of someone who is currently developing a filter for ffmpeg and will be submitting a patch to the list for the first time, I think this is a great idea.Whilst following simple instructions to prepare and submit a patch should't be outside the ability of anyone who is capable o

Re: [FFmpeg-devel] [PATCH v1 01/10] return value check for init_get_bits in wmv2dec.c

On Thu, Aug 12, 2021 at 8:01 AM Maryam Ebrahimzadeh wrote: > > Init_get_bits8 checks for overflow and some other conditions (in > init_get_bits_xe ) too. > What overflow? I'm not sure you understand the concept here. 32 can't overflow, neither can 8*4. Please also make sure to quote and respond

Re: [FFmpeg-devel] [PATCH v1 04/10] return value check for init_get_bits in wmadec.c

On Thu, Aug 12, 2021 at 6:52 AM maryam ebrahimzadeh wrote: > > --- > libavcodec/wmadec.c | 15 +++ > 1 file changed, 11 insertions(+), 4 deletions(-) > > diff --git a/libavcodec/wmadec.c b/libavcodec/wmadec.c > index d627bbe50e..6ac6221d11 100644 > --- a/libavcodec/wmadec.c > +++ b/li

Re: [FFmpeg-devel] [PATCH v1 07/10] return value check for init_get_bits in vc1dec.c

I choose them because their second argument can be crafted. On Aug 12, 2021, at 10:29 AM, Hendrik Leppkes mailto:h.lepp...@gmail.com>> wrote: On Thu, Aug 12, 2021 at 6:53 AM maryam ebrahimzadeh mailto:me22...@outlook.com>> wrote: --- libavcodec/vc1dec.c | 8 ++-- 1 file changed, 6 insertion

Re: [FFmpeg-devel] [PATCH v1 01/10] return value check for init_get_bits in wmv2dec.c

On Aug 12, 2021, at 10:23 AM, Hendrik Leppkes mailto:h.lepp...@gmail.com>> wrote: On Thu, Aug 12, 2021 at 6:48 AM maryam ebrahimzadeh mailto:me22...@outlook.com>> wrote: As the second argument for init_get_bits can be crafted, a return value check for this function call is necessary so rep

Re: [FFmpeg-devel] [PATCH v1 07/10] return value check for init_get_bits in vc1dec.c

On Thu, Aug 12, 2021 at 6:53 AM maryam ebrahimzadeh wrote: > > --- > libavcodec/vc1dec.c | 8 ++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/vc1dec.c b/libavcodec/vc1dec.c > index 1fb1950ade..07d60294f2 100644 > --- a/libavcodec/vc1dec.c > +++ b/libavcodec/

Re: [FFmpeg-devel] [PATCH v1 06/10] return value check for init_get_bits in vp6.c

On Thu, Aug 12, 2021 at 6:53 AM maryam ebrahimzadeh wrote: > > --- > libavcodec/vp6.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/libavcodec/vp6.c b/libavcodec/vp6.c > index 73822a00f9..149daa59f3 100644 > --- a/libavcodec/vp6.c > +++ b/libavcodec/vp6.c > @@ -167,7

Re: [FFmpeg-devel] [PATCH v1 01/10] return value check for init_get_bits in wmv2dec.c

On Thu, Aug 12, 2021 at 6:48 AM maryam ebrahimzadeh wrote: > > As the second argument for init_get_bits can be crafted, a return value check > for this function call is necessary so replace init_get_bits with > init_get_bits8. > > --- > libavcodec/wmv2dec.c | 6 -- > 1 file changed, 4 inse

[FFmpeg-devel] [PATCH v2 1/1] return value check for init_get_bits in wmadec.c

sorry for my mistake. previous version faild to make. --- libavcodec/sipr.c| 5 +++-- libavcodec/truemotion2.c | 12 +--- libavcodec/utvideodec.c | 8 ++-- libavcodec/vaapi_mpeg2.c | 5 - libavcodec/vble.c| 5 +++-- libavcodec/vc1dec.c | 8 ++-- libav

[FFmpeg-devel] [PATCH v1 10/10] return value check for init_get_bits in utvideodec.c

--- libavcodec/utvideodec.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/libavcodec/utvideodec.c b/libavcodec/utvideodec.c index b39d8a7948..144992ff0d 100644 --- a/libavcodec/utvideodec.c +++ b/libavcodec/utvideodec.c @@ -153,7 +153,9 @@ static int decode_plane10(Ut

[FFmpeg-devel] [PATCH v1 09/10] return value check for init_get_bits in vaapi_mpeg2.c

--- libavcodec/vaapi_mpeg2.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavcodec/vaapi_mpeg2.c b/libavcodec/vaapi_mpeg2.c index 26e0cd827c..8e3903212a 100644 --- a/libavcodec/vaapi_mpeg2.c +++ b/libavcodec/vaapi_mpeg2.c @@ -136,9 +136,12 @@ static int vaapi_mpeg2_dec

[FFmpeg-devel] [PATCH v1 08/10] return value check for init_get_bits in vble.c

--- libavcodec/vble.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libavcodec/vble.c b/libavcodec/vble.c index f1400959e0..d3e1804c7b 100644 --- a/libavcodec/vble.c +++ b/libavcodec/vble.c @@ -146,8 +146,9 @@ static int vble_decode_frame(AVCodecContext *avctx, void *da

[FFmpeg-devel] [PATCH v1 07/10] return value check for init_get_bits in vc1dec.c

--- libavcodec/vc1dec.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/libavcodec/vc1dec.c b/libavcodec/vc1dec.c index 1fb1950ade..07d60294f2 100644 --- a/libavcodec/vc1dec.c +++ b/libavcodec/vc1dec.c @@ -444,7 +444,9 @@ static av_cold int vc1_decode_init(AVCodecContex

[FFmpeg-devel] [PATCH v1 06/10] return value check for init_get_bits in vp6.c

--- libavcodec/vp6.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavcodec/vp6.c b/libavcodec/vp6.c index 73822a00f9..149daa59f3 100644 --- a/libavcodec/vp6.c +++ b/libavcodec/vp6.c @@ -167,7 +167,9 @@ static int vp6_parse_header(VP56Context *s, const uint8_t *buf, int

[FFmpeg-devel] [PATCH v1 05/10] return value check for init_get_bits in vorbisdec.c

--- libavcodec/vorbisdec.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/libavcodec/vorbisdec.c b/libavcodec/vorbisdec.c index dac2b6841c..80358f6359 100644 --- a/libavcodec/vorbisdec.c +++ b/libavcodec/vorbisdec.c @@ -1052,7 +1052,9 @@ static av_cold int vorbis_decod

[FFmpeg-devel] [PATCH v1 04/10] return value check for init_get_bits in wmadec.c

--- libavcodec/wmadec.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/libavcodec/wmadec.c b/libavcodec/wmadec.c index d627bbe50e..6ac6221d11 100644 --- a/libavcodec/wmadec.c +++ b/libavcodec/wmadec.c @@ -822,6 +822,7 @@ static int wma_decode_superframe(AVCode

[FFmpeg-devel] [PATCH v1 03/10] return value check for init_get_bits in wmalosslessdec.c

--- libavcodec/wmalosslessdec.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/libavcodec/wmalosslessdec.c b/libavcodec/wmalosslessdec.c index 74c91f4f7e..a2e83ca99c 100644 --- a/libavcodec/wmalosslessdec.c +++ b/libavcodec/wmalosslessdec.c @@ -1187,6 +1187,7 @@ stati

[FFmpeg-devel] [PATCH v1 02/10] return value check for init_get_bits in wmaprodec.c

--- libavcodec/wmaprodec.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/libavcodec/wmaprodec.c b/libavcodec/wmaprodec.c index e0d00d2d37..23df0be6ab 100644 --- a/libavcodec/wmaprodec.c +++ b/libavcodec/wmaprodec.c @@ -1615,6 +1615,7 @@ static int decode_packet(AVCod

[FFmpeg-devel] [PATCH v1 01/10] return value check for init_get_bits in wmv2dec.c

As the second argument for init_get_bits can be crafted, a return value check for this function call is necessary so replace init_get_bits with init_get_bits8. --- libavcodec/wmv2dec.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/libavcodec/wmv2dec.c b/libavcodec/w

[FFmpeg-devel] [PATCH] movenc: Ensure no separate moof written for empty track

track->mdat_buf can be not NULL while the track is still empty if the last packet write failed. Signed-off-by: Hu Weiwen --- libavformat/movenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index bcc202300bb..a460cd9adae 100644

[FFmpeg-devel] [PATCH] movenc: Get rid of frag_start

"frag_start" is redundant, and every occurance can be replaced with cluster[0].dts - start_dts The proof of no behaviour changes: (All line number below is based on commit bff7d662d728) "frag_start" is read at 4 place (with all possible call stacks): mov_write_packet ... mov_flush_fragment

Re: [FFmpeg-devel] [PATCH v2] lavc/qsvenc: allows the SDK runtime to choose LowPower/non-LowPower modes

> -Original Message- > From: ffmpeg-devel On Behalf Of > Haihao Xiang > Sent: Thursday, 12 August 2021 04:34 > To: ffmpeg-devel@ffmpeg.org > Cc: Haihao Xiang > Subject: [FFmpeg-devel] [PATCH v2] lavc/qsvenc: allows the SDK > runtime to choose LowPower/non-LowPower modes > > The SDK su

Re: [FFmpeg-devel] [PATCH] libavformat/file.c: 'file_delete()' and 'file_move()' require 'CONFIG_FILE_PROTOCOL'

Michael Witten: > This quashes 2 warnings when the 'file' protocol is not enabled. > --- > libavformat/file.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavformat/file.c b/libavformat/file.c > index 8303436be0..9c23f680cd 100644 > --- a/libavformat/file.c > +++

Re: [FFmpeg-devel] [PATCH 1/2] avformat/oggdec: Use av_realloc_array()

Andreas Rheinhardt: > Signed-off-by: Andreas Rheinhardt > --- > This also removes the last user of av_size_mult from libavformat > (indeed, from anything outside of mem.c), so this removes one entry > from the list of dynamic symbols (if using a shared build). > > libavformat/oggdec.c | 5 ++---

Re: [FFmpeg-devel] [PATCH] avcodec/h264_parse: add some missing checks to ff_h264_init_poc()

On 8/11/2021 11:33 PM, Andreas Rheinhardt wrote: James Almer: On 8/11/2021 11:26 PM, Andreas Rheinhardt wrote: James Almer: poc.delta_poc_bottom and poc.delta_poc[1] are only coded in the bitstream if pps->pic_order_present is true, so ensure they are not used otherwise, to prevent the potenti

Re: [FFmpeg-devel] [PATCH] avfilter/vf_scale: Avoid unnecessary indirection

Andreas Rheinhardt: > Signed-off-by: Andreas Rheinhardt > --- > libavfilter/vf_scale.c | 42 +- > 1 file changed, 21 insertions(+), 21 deletions(-) > > diff --git a/libavfilter/vf_scale.c b/libavfilter/vf_scale.c > index aa855b894a..160ad8b584 100644 > ---

Re: [FFmpeg-devel] [PATCH] avutil/mem: Correct av_calloc() documentation

Andreas Rheinhardt: > Incorrect since 4959f18a8e11ad7d3529b1c4fc429f1b6b76ad7c. > > Signed-off-by: Andreas Rheinhardt > --- > Do we even need both av_mallocz_array and av_calloc given that > they do exactly the same? I'd like to deprecate one, namely > av_mallocz_array() (it has the longer name).

[FFmpeg-devel] [PATCH v2] lavc/qsvenc: allows the SDK runtime to choose LowPower/non-LowPower modes

The SDK supports LowPower and non-LowPower modes, but some features are available only under one of the two modes. Currently non-LowPower mode is always chosen in FFmpeg if the mode is not set to LowPower explicitly. User will experience some SDK errors if a LowPower related feature is specified bu

Re: [FFmpeg-devel] [PATCH] avcodec/h264_parse: add some missing checks to ff_h264_init_poc()

James Almer: > On 8/11/2021 11:26 PM, Andreas Rheinhardt wrote: >> James Almer: >>> poc.delta_poc_bottom and poc.delta_poc[1] are only coded in the >>> bitstream if >>> pps->pic_order_present is true, so ensure they are not used >>> otherwise, to >>> prevent the potential use of stale values. >>> >

Re: [FFmpeg-devel] [PATCH] avcodec/h264_parse: add some missing checks to ff_h264_init_poc()

On 8/11/2021 11:26 PM, Andreas Rheinhardt wrote: James Almer: poc.delta_poc_bottom and poc.delta_poc[1] are only coded in the bitstream if pps->pic_order_present is true, so ensure they are not used otherwise, to prevent the potential use of stale values. Signed-off-by: James Almer --- This co

Re: [FFmpeg-devel] [PATCH] avcodec/h264_parse: add some missing checks to ff_h264_init_poc()

James Almer: > poc.delta_poc_bottom and poc.delta_poc[1] are only coded in the bitstream if > pps->pic_order_present is true, so ensure they are not used otherwise, to > prevent the potential use of stale values. > > Signed-off-by: James Almer > --- > This complements ce4a31cd1ff0348d279af74d4955

[FFmpeg-devel] [PATCH 23/23] avfilter: Remove init_opaque callback

The last init_opaque callback has been removed in commit 07ffdedf784e86b88074d8d3e08e55752869562a; the opaque argument has been always NULL since 0acf7e268b2f873379cd854b4d5aaba6f9c1f0b5. Signed-off-by: Andreas Rheinhardt --- libavfilter/avfilter.c | 4 +--- libavfilter/avfilter.h | 7 --- 2

[FFmpeg-devel] [PATCH 22/23] avfilter/vf_xmedian: Free inpads' names generically

This affects only the xmedian filter, not tmedian. Signed-off-by: Andreas Rheinhardt --- libavfilter/vf_xmedian.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/libavfilter/vf_xmedian.c b/libavfilter/vf_xmedian.c index 168a5944db..c01f9ff202 100644 --- a/libavfilter/v

[FFmpeg-devel] [PATCH 21/23] avfilter/vf_stack: Free inpads' names generically

Signed-off-by: Andreas Rheinhardt --- libavfilter/vf_stack.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/libavfilter/vf_stack.c b/libavfilter/vf_stack.c index 3368e25c9c..33cef09a91 100644 --- a/libavfilter/vf_stack.c +++ b/libavfilter/vf_stack.c @@ -123,10 +12

[FFmpeg-devel] [PATCH 20/23] avfilter/vf_signature: Free inpads' names generically

Signed-off-by: Andreas Rheinhardt --- libavfilter/vf_signature.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/libavfilter/vf_signature.c b/libavfilter/vf_signature.c index a345ad6ebd..3f4b17b555 100644 --- a/libavfilter/vf_signature.c +++ b/libavfilter/vf_signature.c

[FFmpeg-devel] [PATCH 19/23] avfilter/vf_program_opencl: Free inpads' names generically

Only ff_vf_program_opencl is affected by this: ff_vsrc_openclsrc as a source filter doesn't have any inputs and the code where inpads are inserted is unreachable for it. Signed-off-by: Andreas Rheinhardt --- libavfilter/vf_program_opencl.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deleti

[FFmpeg-devel] [PATCH 18/23] avfilter/vf_mix: Free inpads' names generically

Signed-off-by: Andreas Rheinhardt --- libavfilter/vf_mix.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/libavfilter/vf_mix.c b/libavfilter/vf_mix.c index 0ca60d5522..9f1400e729 100644 --- a/libavfilter/vf_mix.c +++ b/libavfilter/vf_mix.c @@ -125,10 +125,8 @@ stat

[FFmpeg-devel] [PATCH 17/23] avfilter/vf_mergeplanes: Free inpads' names generically

Signed-off-by: Andreas Rheinhardt --- libavfilter/vf_mergeplanes.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/libavfilter/vf_mergeplanes.c b/libavfilter/vf_mergeplanes.c index 30888f62af..633421e37d 100644 --- a/libavfilter/vf_mergeplanes.c +++ b/libavfilter/vf_m

[FFmpeg-devel] [PATCH 16/23] avfilter/vf_extractplanes: Free outpads' names generically

Signed-off-by: Andreas Rheinhardt --- libavfilter/vf_extractplanes.c | 16 +++- 1 file changed, 3 insertions(+), 13 deletions(-) diff --git a/libavfilter/vf_extractplanes.c b/libavfilter/vf_extractplanes.c index cede3d669e..52602965ac 100644 --- a/libavfilter/vf_extractplanes.c +++ b

[FFmpeg-devel] [PATCH 15/23] avfilter/src_movie: Free outpads' names generically

Signed-off-by: Andreas Rheinhardt --- libavfilter/src_movie.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/libavfilter/src_movie.c b/libavfilter/src_movie.c index 7d97295dd0..947aa8c90f 100644 --- a/libavfilter/src_movie.c +++ b/libavfilter/src_movie.c @@ -306,10 +30

[FFmpeg-devel] [PATCH 14/23] avfilter/split: Free outpads' names generically

Signed-off-by: Andreas Rheinhardt --- libavfilter/split.c | 16 +++- 1 file changed, 3 insertions(+), 13 deletions(-) diff --git a/libavfilter/split.c b/libavfilter/split.c index da5f681af8..b14f6798e9 100644 --- a/libavfilter/split.c +++ b/libavfilter/split.c @@ -56,23 +56,13 @@ sta

[FFmpeg-devel] [PATCH 13/23] avfilter/f_streamselect: Free pads' names generically

Signed-off-by: Andreas Rheinhardt --- libavfilter/f_streamselect.c | 13 +++-- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/libavfilter/f_streamselect.c b/libavfilter/f_streamselect.c index 22eb76d4d7..7762cdb3d1 100644 --- a/libavfilter/f_streamselect.c +++ b/libavfilte

[FFmpeg-devel] [PATCH 12/23] avfilter/f_select: Free outpads' names generically

Signed-off-by: Andreas Rheinhardt --- libavfilter/f_select.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/libavfilter/f_select.c b/libavfilter/f_select.c index f0468078e8..0538ee347d 100644 --- a/libavfilter/f_select.c +++ b/libavfilter/f_select.c @@ -192,10 +192

[FFmpeg-devel] [PATCH 04/23] avfilter/af_acrossover: Free outpads' names generically

Signed-off-by: Andreas Rheinhardt --- libavfilter/af_acrossover.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/libavfilter/af_acrossover.c b/libavfilter/af_acrossover.c index 3ba67b30e1..c99c7de1f7 100644 --- a/libavfilter/af_acrossover.c +++ b/libavfilter/af_acros

[FFmpeg-devel] [PATCH 11/23] avfilter/f_interleave: Free inpads' names generically

Signed-off-by: Andreas Rheinhardt --- libavfilter/f_interleave.c | 14 +++--- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/libavfilter/f_interleave.c b/libavfilter/f_interleave.c index 259952b591..b2c0305797 100644 --- a/libavfilter/f_interleave.c +++ b/libavfilter/f_int

[FFmpeg-devel] [PATCH 10/23] avfilter/avf_concat: Free pads' names generically

Signed-off-by: Andreas Rheinhardt --- libavfilter/avf_concat.c | 14 +++--- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/libavfilter/avf_concat.c b/libavfilter/avf_concat.c index 333a0b090c..0ff7cb20b0 100644 --- a/libavfilter/avf_concat.c +++ b/libavfilter/avf_concat.c

[FFmpeg-devel] [PATCH 09/23] avfilter/af_lv2: Free inpads' names generically

Signed-off-by: Andreas Rheinhardt --- libavfilter/af_lv2.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/libavfilter/af_lv2.c b/libavfilter/af_lv2.c index 28b729691d..d97367ca99 100644 --- a/libavfilter/af_lv2.c +++ b/libavfilter/af_lv2.c @@ -393,7 +393,7 @@ sta

[FFmpeg-devel] [PATCH 08/23] avfilter/af_ladspa: Free inpads' names generically

Signed-off-by: Andreas Rheinhardt --- libavfilter/af_ladspa.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/libavfilter/af_ladspa.c b/libavfilter/af_ladspa.c index 4060251670..cbb8282988 100644 --- a/libavfilter/af_ladspa.c +++ b/libavfilter/af_ladspa.c @@ -456,

[FFmpeg-devel] [PATCH 07/23] avfilter/af_join: Free inpads' names generically

Signed-off-by: Andreas Rheinhardt --- libavfilter/af_join.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/libavfilter/af_join.c b/libavfilter/af_join.c index 6a4b449021..1fb216f622 100644 --- a/libavfilter/af_join.c +++ b/libavfilter/af_join.c @@ -194,10 +194,8 @@ s

[FFmpeg-devel] [PATCH 06/23] avfilter/af_amix: Free inpads' names generically

Signed-off-by: Andreas Rheinhardt --- libavfilter/af_amix.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/libavfilter/af_amix.c b/libavfilter/af_amix.c index 2296b49243..d5af72bafe 100644 --- a/libavfilter/af_amix.c +++ b/libavfilter/af_amix.c @@ -553,10 +553,8 @@ st

[FFmpeg-devel] [PATCH 05/23] avfilter/af_amerge: Free inpads' names generically

Signed-off-by: Andreas Rheinhardt --- libavfilter/af_amerge.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/libavfilter/af_amerge.c b/libavfilter/af_amerge.c index 2e45b7c277..1b7c6dd2f4 100644 --- a/libavfilter/af_amerge.c +++ b/libavfilter/af_amerge.c @@ -60,8 +60,6

[FFmpeg-devel] [PATCH 03/23] avfilter/avfilter: Allow to free pads generically

This can be enabled/disabled on a per-filter basis by setting the new internal flags FF_FILTER_FLAG_FREE_(IN|OUT)PADS. Signed-off-by: Andreas Rheinhardt --- It would be possible to only free the names of non-static pads; it could then be used with the headphone and afir filters. But I don't think

[FFmpeg-devel] [PATCH 02/23] avfilter/internal: Uninline ff_insert_(in|out)pad()

These functions are not hot at all and future commits will make them bigger. Signed-off-by: Andreas Rheinhardt --- I haven't found a caller that adds a pad somewhere else than the end of the list, so the index parameter could be removed. Shall I do so or is there a compelling reason to retain thi

[FFmpeg-devel] [PATCH] avcodec/h264_parse: add some missing checks to ff_h264_init_poc()

poc.delta_poc_bottom and poc.delta_poc[1] are only coded in the bitstream if pps->pic_order_present is true, so ensure they are not used otherwise, to prevent the potential use of stale values. Signed-off-by: James Almer --- This complements ce4a31cd1ff0348d279af74d49556d0315171e94, and is a more

[FFmpeg-devel] [PATCH 01/23] avfilter/vf_(guided|program_opencl): Add missing dynamic inputs flag

The code for inserting inpads can't be reached by ff_vsrc_openclsrc (unsurprising given that it is a source filter), so it didn't get the flag. Signed-off-by: Andreas Rheinhardt --- libavfilter/vf_guided.c | 3 ++- libavfilter/vf_program_opencl.c | 1 + 2 files changed, 3 insertions(+),

Re: [FFmpeg-devel] [PATCH 3/3] libavformat/protocols.c: avio_enum_protocols_{input, output}(): Add functions to the API

| Michael Witten: | | > In the repo, there is only one function that enumerates protocols: | > | > fftools/cmdutils.c: show_protocols() | > | > This commit simply has that function make calls directly to the | > desired functions, namely: | > | > * avio_enum_protocols_for_input(

Re: [FFmpeg-devel] [PATCH 3/3] avfilter/vf_(guided|program_opencl): Add missing dynamic inputs flag

Andreas Rheinhardt: > Signed-off-by: Andreas Rheinhardt > --- > libavfilter/vf_guided.c | 3 ++- > libavfilter/vf_program_opencl.c | 2 ++ > 2 files changed, 4 insertions(+), 1 deletion(-) > > diff --git a/libavfilter/vf_guided.c b/libavfilter/vf_guided.c > index 202a6a0586..e2bf08f5c3 1

Re: [FFmpeg-devel] [PATCH 2.0/3] libavformat/protocols.c: avio_enum_protocols(): Add more const-correctness

| Michael Witten: | | > -const char *avio_enum_protocols(void **opaque, int output) | > +const char *avio_enum_protocols(void **const opaque, const int output) | | Andreas Rheinhardt: | | > This thing makes nothing more const-correct at all; C uses call be | > value, so we only deal with ou

Re: [FFmpeg-devel] [PATCH 3/3] libavformat/protocols.c: avio_enum_protocols_{input, output}(): Add functions to the API

Michael Witten: > In the repo, there is only one function that enumerates protocols: > > fftools/cmdutils.c: show_protocols() > > This commit simply has that function make calls directly to the > desired functions, namely: > > * avio_enum_protocols_for_input() > * avio_enum_protocols_for_o

Re: [FFmpeg-devel] [PATCH 0/3] libavformat/protocols.c: avio_enum_protocols(): Cleanup

| Michael Witten: | | > However, {2} is presented as a bunch of tiny little transformations | > that are intended to aid comprehension; they can be squashed into | > one commit as the maintainer sees fit (indeed, as shown below, the | > squashed diff is already quite comprehensible): | |

Re: [FFmpeg-devel] [PATCH 2.0/3] libavformat/protocols.c: avio_enum_protocols(): Add more const-correctness

Michael Witten: > This commit adds 'const' qualifiers to the parameters. > > --- > libavformat/avio.h | 2 +- > libavformat/protocols.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavformat/avio.h b/libavformat/avio.h > index 0b35409787..3b92cf742a 100644 >

Re: [FFmpeg-devel] [PATCH 2.b/3] libavformat/protocols.c: avio_enum_protocols(): Convert the 'goto' loop to a 'for(; ; )' block

| Michael Witten: | | > -iterate: | > +for(;;) { | > if (*p) { | > if ((output && (*p)->url_write) || (!output && (*p)->url_read)) { | > *opaque = (void *)p; | > @@ -105,7 +105,7 @@ iterate: | > goto done; | > } | > ++p; | > -

Re: [FFmpeg-devel] [PATCH] ffmpeg_hw: Don't ignore key parameters when initializing a hw device

> -Original Message- > From: ffmpeg-devel On Behalf Of > Haihao Xiang > Sent: Wednesday, 11 August 2021 08:44 > To: ffmpeg-devel@ffmpeg.org > Cc: Haihao Xiang > Subject: [FFmpeg-devel] [PATCH] ffmpeg_hw: Don't ignore key > parameters when initializing a hw device > > Currently user ma

[FFmpeg-devel] [PATCH] avformat/mxfdec: store parition score instead of partition pointer in metadata

Partition struct may be reallocated, so let's store the score directly in order to avoid use-after-free. Also mxf->current_partition might be null when reading some local tags. Signed-off-by: Marton Balint --- libavformat/mxfdec.c | 31 +-- 1 file changed, 17 inserti

Re: [FFmpeg-devel] [PATCH 2.b/3] libavformat/protocols.c: avio_enum_protocols(): Convert the 'goto' loop to a 'for(; ; )' block

11 Aug 2021, 21:00 by mfwit...@gmail.com: > The indentation will be cleaned up in the next commit. > > --- > libavformat/protocols.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavformat/protocols.c b/libavformat/protocols.c > index 032f07bf72..2aa302d08f 100644

Re: [FFmpeg-devel] [PATCH 1/3] avfilter/avfilter: Fix leaks upon filter creation error

Nicolas George: > Andreas Rheinhardt (12021-08-11): >> Both the name as well as the options need to be freed. >> (Right now there is no option for the AVFilterContext itself that could >> leak, but some filters have options (e.g. of type AV_OPT_TYPE_STRING) >> that can leak.) >> >> Signed-off-by: A

Re: [FFmpeg-devel] [PATCH 0/3] libavformat/protocols.c: avio_enum_protocols(): Cleanup

Michael Witten (12021-08-11): > However, {2} is presented as a bunch of tiny little transformations > that are intended to aid comprehension; they can be squashed into > one commit as the maintainer sees fit (indeed, as shown below, the > squashed diff is already quite comprehensible): This is my

[FFmpeg-devel] [PATCH 2.e/3] libavformat/protocols.c: avio_enum_protocols(): Create a macro for generating different loops

The function 'avio_enum_protocols()' iterates through the list of protocols, looking for a protocol that has a certain non-zero pointer-to-function; the exact pointer-to-function to use depends on the the argument passed through the parameter 'output'. * Before this commit, the parameter 'output'

[FFmpeg-devel] [PATCH 3/3] libavformat/protocols.c: avio_enum_protocols_{input, output}(): Add functions to the API

In the repo, there is only one function that enumerates protocols: fftools/cmdutils.c: show_protocols() This commit simply has that function make calls directly to the desired functions, namely: * avio_enum_protocols_for_input() * avio_enum_protocols_for_output() --- fftools/cmdutils.c

[FFmpeg-devel] [PATCH 2.d/3] libavformat/protocols.c: avio_enum_protocols(): Move loop initialization

For the sake of completeness and scope correctness, the declaration and initialization of 'p' has been moved into the 'for(;;)' statement. --- libavformat/protocols.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libavformat/protocols.c b/libavformat/protocols.c index e3cd

[FFmpeg-devel] [PATCH 2.c/3] libavformat/protocols.c: avio_enum_protocols(): Move the loop variables

The loop variables can now be moved into their respective slots of the 'for(;;)' statement; this removes the need for the 'done' label. --- libavformat/protocols.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/libavformat/protocols.c b/libavformat/protocols.c index 2a

[FFmpeg-devel] [PATCH 2.b/3] libavformat/protocols.c: avio_enum_protocols(): Convert the 'goto' loop to a 'for(; ; )' block

The indentation will be cleaned up in the next commit. --- libavformat/protocols.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/protocols.c b/libavformat/protocols.c index 032f07bf72..2aa302d08f 100644 --- a/libavformat/protocols.c +++ b/libavformat/protocol

[FFmpeg-devel] [PATCH 2.a/3] libavformat/protocols.c: avio_enum_protocols(): Move branch to bottom of function

A 'goto done;' statement is used to jump to the desired code. --- libavformat/protocols.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/libavformat/protocols.c b/libavformat/protocols.c index 0deadbfbe7..032f07bf72 100644 --- a/libavformat/protocols.c +++ b/libavformat

[FFmpeg-devel] [PATCH 2.9/3] libavformat/protocols.c: avio_enum_protocols(): Reverse the conditional

The 'if(!*p)' has been turned into 'if (*p)'; of course, this has necessitated the swapping of the branches. --- libavformat/protocols.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavformat/protocols.c b/libavformat/protocols.c index 5828113428..0deadbfbe7 10064

[FFmpeg-devel] [PATCH 2.8/3] libavformat/3otocols.c: avio_enum_protocols(): Make the 'else' logic explicit

--- libavformat/protocols.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavformat/protocols.c b/libavformat/protocols.c index 3f8433e317..5828113428 100644 --- a/libavformat/protocols.c +++ b/libavformat/protocols.c @@ -99,11 +99,12 @@ iterate: if (!*p) {

[FFmpeg-devel] [PATCH 2.7/3] libavformat/protocols.c: avio_enum_protocols(): Indent code

Nothing but white space changed: $ git diff --ignore-all-space "$THIS"^ "$THIS" && echo NOTHING NOTHING This is just setting up for the next commit. --- libavformat/protocols.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavformat/protocols.c b/libavformat/p

[FFmpeg-devel] [PATCH 2.6/3] libavformat/protocols.c: avio_enum_protocols(): Move assignment to '*opaque'

The assignment is not necessary until returning. --- libavformat/protocols.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/protocols.c b/libavformat/protocols.c index bedaa9ef77..ec7c72b14f 100644 --- a/libavformat/protocols.c +++ b/libavformat/protocols.c @@ -96,

[FFmpeg-devel] [PATCH 2.5/3] libavformat/protocols.c: avio_enum_protocols(): Add block curly braces to 'if' statement

This is preparation for the next commit. --- libavformat/protocols.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavformat/protocols.c b/libavformat/protocols.c index 5e4bf5cbae..bedaa9ef77 100644 --- a/libavformat/protocols.c +++ b/libavformat/protocols.c @@ -101,8 +10

[FFmpeg-devel] [PATCH 2.4/3] libavformat/protocols.c: avio_enum_protocols(): Consolidate initialization of 'p'

Now that the label has been moved past the initial assignment of 'p', it is possible to consolidate both the declaration and initialization. A typedef is used to simplify the declaration of 'p', and to help the reader understand what the purpose of 'p' is. --- libavformat/protocols.c | 6 ++

[FFmpeg-devel] [PATCH 2.3/3] libavformat/protocols.c: avio_enum_protocols(): Move 'iterate' label

Upon iteration ('goto iterate;'), it is known that 'p' is non-zero, so there is no point in doing the check; it is known that 'p' must be incremented. Therefore, the 'iterate' label may be moved past the ternary operator, provided that '++p;' is added just before the 'goto', so as to perform the re

[FFmpeg-devel] [PATCH 2.2/3] libavformat/protocols.c: avio_enum_protocols(): Convert recursion to iteration

In C, it's generally not good to write a recursive algorithm, because it is not possible to rely on the compiler to elide a tail call; therefore, this commit converts a tail call into an iterative loop by means of an explicit 'goto' statement. --- libavformat/protocols.c | 3 ++- 1 file changed, 2

[FFmpeg-devel] [PATCH 2.1/3] libavformat/protocols.c: avio_enum_protocols(): Split declaration and initialization

The main purpose of doing this is to allow for inserting a a statement label; as I recall, a label cannot be placed just before a declaration, even when that declaration has an initializer (then again, I never tried, so maybe this is not true...) --- libavformat/protocols.c | 3 ++- 1 file change

[FFmpeg-devel] [PATCH 2.0/3] libavformat/protocols.c: avio_enum_protocols(): Add more const-correctness

This commit adds 'const' qualifiers to the parameters. --- libavformat/avio.h | 2 +- libavformat/protocols.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/avio.h b/libavformat/avio.h index 0b35409787..3b92cf742a 100644 --- a/libavformat/avio.h +++ b/liba

[FFmpeg-devel] [PATCH 1/3] libavformat/protocols.c: avio_enum_protocols(): Add const-correctness

This quashes a compile-time warning. * 'url_protocols' is an array of const pointers. * The explicit conversion to '(void *)' is okay, because the destination is an "opaque" blob of private data. --- libavformat/protocols.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) d

[FFmpeg-devel] [PATCH 0/3] libavformat/protocols.c: avio_enum_protocols(): Cleanup

This series improves the following function: libavformat/protocols.c: avio_enum_protocols() There are really only 3 logical commits: [1] Add const-correctness (fixes a compile-time warning) {2} Refactoring (cleanup) [3] Add functions to the API (use them too) However,

Re: [FFmpeg-devel] [RFC] Suggestion for a Nicer Integration with GitHub

August 11, 2021 9:44 AM, "Soft Works" wrote: >> -Original Message- >> From: ffmpeg-devel On Behalf Of >> ffmpegandmahanstreamer@e.email >> Sent: Wednesday, 11 August 2021 15:01 >> To: FFmpeg development discussions and patches > de...@ffmpeg.org> >> Subject: Re: [FFmpeg-devel] [RFC] Sugg

Re: [FFmpeg-devel] [PATCH v2] avutils/hwcontext: When deriving a hwdevice, search for existing device in both directions

> -Original Message- > From: ffmpeg-devel On Behalf Of > Soft Works > Sent: Tuesday, 10 August 2021 11:53 > To: ffmpeg-devel@ffmpeg.org > Subject: [FFmpeg-devel] [PATCH v2] avutils/hwcontext: When deriving a > hwdevice, search for existing device in both directions > [..] > Signed-of

Re: [FFmpeg-devel] Mail quoting (was: 1/2] libavutil/log: Add capability to prefix loglines with current time or current date+time)

E.email comes with this capability built in. August 10, 2021 10:02 AM, "Michael Niedermayer" wrote: > On Tue, Aug 10, 2021 at 09:47:31AM +, Soft Works wrote: > >> -Original Message- >> From: ffmpeg-devel On Behalf Of >> Nicolas George >> Sent: Tuesday, 10 August 2021 11:16 >> To: F

Re: [FFmpeg-devel] [RFC] Suggestion for a Nicer Integration with GitHub

August 10, 2021 10:37 AM, "Soft Works" wrote: > Hi, > > A while ago there was a discussion about moving forward and > migrating the ffmpeg development process from the mailing list to > another platform (like GitLab). > That discussion had died without further results and an important > takea

Re: [FFmpeg-devel] [PATCH v3 1/2] qsvdec: add support for HW_DEVICE_CTX method

On 8/11/2021 1:29 PM, Soft Works wrote: -Original Message- From: ffmpeg-devel On Behalf Of Haihao Xiang Sent: Wednesday, 11 August 2021 08:02 To: ffmpeg-devel@ffmpeg.org Cc: Haihao Xiang Subject: [FFmpeg-devel] [PATCH v3 1/2] qsvdec: add support for HW_DEVICE_CTX method This allows

Re: [FFmpeg-devel] [PATCH v3 1/2] qsvdec: add support for HW_DEVICE_CTX method

> -Original Message- > From: ffmpeg-devel On Behalf Of > Haihao Xiang > Sent: Wednesday, 11 August 2021 08:02 > To: ffmpeg-devel@ffmpeg.org > Cc: Haihao Xiang > Subject: [FFmpeg-devel] [PATCH v3 1/2] qsvdec: add support for > HW_DEVICE_CTX method > > This allows user set hw_device_ctx

Re: [FFmpeg-devel] [PATCH] lavc/qsvenc: allows the SDK runtime to choose LowPower/non-LowPower modes

On 8/11/2021 12:12 PM, Xiang, Haihao wrote: On Sat, 2020-10-10 at 14:22 +0800, Haihao Xiang wrote: The SDK supports LowPower and non-LowPower modes, but some features are available only under one of the two modes. Currently non-LowPower mode is always chosen in FFmpeg if the mode is not set expl

Re: [FFmpeg-devel] [PATCH] lavc/qsvenc: allows the SDK runtime to choose LowPower/non-LowPower modes

On Sat, 2020-10-10 at 14:22 +0800, Haihao Xiang wrote: > The SDK supports LowPower and non-LowPower modes, but some features are > available only under one of the two modes. Currently non-LowPower mode > is always chosen in FFmpeg if the mode is not set explicitly, which will > result in some SDK e

Re: [FFmpeg-devel] [PATCH] avcodec/wma: handle run_level_decode error

Stéphane Cerveau: > Consider data as invalid if ff_wma_run_level_decode > gets out with an error. > > It avoids an unpleasant sound distorsion. > > See http://trac.ffmpeg.org/ticket/9358 > --- > libavcodec/wmadec.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/li

[FFmpeg-devel] [PATCH] avcodec/wma: handle run_level_decode error

Consider data as invalid if ff_wma_run_level_decode gets out with an error. It avoids an unpleasant sound distorsion. See http://trac.ffmpeg.org/ticket/9358 --- libavcodec/wmadec.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libavcodec/wmadec.c b/libavcodec/wmadec.c

Re: [FFmpeg-devel] [RFC PATCH] avformat/mov: add AVFMT_SHOW_IDS flag

On 8/11/2021 11:04 AM, Gyan Doshi wrote: On 2021-08-11 07:29 pm, Andreas Rheinhardt wrote: Gyan Doshi: The MOV muxer can store streamids as track ids but they aren't visible when probing the result via lavf/dump or ffprobe due to lack of this flag in the demuxer. This current submission is j

Re: [FFmpeg-devel] [RFC PATCH] avformat/mov: add AVFMT_SHOW_IDS flag

On 2021-08-11 07:29 pm, Andreas Rheinhardt wrote: Gyan Doshi: The MOV muxer can store streamids as track ids but they aren't visible when probing the result via lavf/dump or ffprobe due to lack of this flag in the demuxer. This current submission is just to get Patchwork FATE results. Will b

[FFmpeg-devel] [PATCH] avcodec/cbs_h264: infer all pic_order_cnt slice fields when not coded

Also change the syntax for some checks, to more closely follow the spec. Signed-off-by: James Almer --- libavcodec/cbs_h264_syntax_template.c | 24 +--- 1 file changed, 13 insertions(+), 11 deletions(-) diff --git a/libavcodec/cbs_h264_syntax_template.c b/libavcodec/cbs_h26

Re: [FFmpeg-devel] [RFC PATCH] avformat/mov: add AVFMT_SHOW_IDS flag

Gyan Doshi: > The MOV muxer can store streamids as track ids but they aren't > visible when probing the result via lavf/dump or ffprobe due to > lack of this flag in the demuxer. > > This current submission is just to get Patchwork FATE results. > Will be updated with changed refs, if any. You ar

Re: [FFmpeg-devel] [RFC] Suggestion for a Nicer Integration with GitHub

> -Original Message- > From: ffmpeg-devel On Behalf Of > ffmpegandmahanstreamer@e.email > Sent: Wednesday, 11 August 2021 15:01 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [RFC] Suggestion for a Nicer Integration > with GitHub > > Augu

  1   2   >