Re: [FFmpeg-devel] [PATCH] lavfi/qsvvpp: do not mix up FFmpeg and SDK error code

> -Original Message- > From: ffmpeg-devel On Behalf Of > Haihao Xiang > Sent: Friday, 30 July 2021 04:39 > To: ffmpeg-devel@ffmpeg.org > Cc: Haihao Xiang > Subject: [FFmpeg-devel] [PATCH] lavfi/qsvvpp: do not mix up FFmpeg and > SDK error code > > The function ff_qsvvpp_filter_frame s

Re: [FFmpeg-devel] [PATCH] avformat/hls: return ret when read_packet get exceptions

> 2021年8月4日 下午2:30，Nicolas George 写道： > > Steven Liu (12021-08-04): >> Ok, "avformat/hls: return ret when read_packet return error codes." > > "forward error code" is the idiomatic wording, according to git log. What about “Return sensible error values and forward error codes.” ? > > Regards,

Re: [FFmpeg-devel] [PATCH] avformat/hls: return ret when read_packet get exceptions

Steven Liu (12021-08-04): > Ok, "avformat/hls: return ret when read_packet return error codes." "forward error code" is the idiomatic wording, according to git log. Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-dev

Re: [FFmpeg-devel] [PATCH] avformat/hls: return ret when read_packet get exceptions

> 2021年8月4日 下午2:18，Nicolas George 写道： > > Steven Liu (12021-08-04): >> Subject: Re: [FFmpeg-devel] [PATCH] avformat/hls: return ret when read_packet >> get exceptions > > Nit: FFmpeg does not have exceptions, it has error codes. Ok, "avformat/hls: return ret when read_packet return error codes

Re: [FFmpeg-devel] [PATCH] avformat/hls: return ret when read_packet get exceptions

Steven Liu (12021-08-04): > Subject: Re: [FFmpeg-devel] [PATCH] avformat/hls: return ret when read_packet > get exceptions Nit: FFmpeg does not have exceptions, it has error codes. Regards, -- Nicolas George signature.asc Description: PGP signature _

Re: [FFmpeg-devel] [PATCH v2 1/2] qsvdec: add support for HW_DEVICE_CTX method

> -Original Message- > From: ffmpeg-devel On Behalf Of > Xiang, Haihao > Sent: Tuesday, 3 August 2021 07:22 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH v2 1/2] qsvdec: add support for > HW_DEVICE_CTX method > > On Mon, 2021-08-02 at 10:27 +, Soft Works wrote:

Re: [FFmpeg-devel] [PATCH] ffmpeg_hw: make hardware selection for filters more user friendly

> -Original Message- > From: ffmpeg-devel On Behalf Of > Haihao Xiang > Sent: Tuesday, 29 June 2021 03:46 > To: ffmpeg-devel@ffmpeg.org > Cc: Haihao Xiang > Subject: [FFmpeg-devel] [PATCH] ffmpeg_hw: make hardware selection for > filters more user friendly > > When a device is derived

Re: [FFmpeg-devel] [PATCH v1] avfilter/vf_vpp_qsv: add scale mode option

On Wed, 2021-08-04 at 09:47 +0800, Linjie Fu wrote: > Hi Andreas,On Wed, Aug 4, 2021 at 8:30 AM Andreas Rheinhardt < > andreas.rheinha...@outlook.com> wrote: > > > Linjie Fu: > > > On Wed, Mar 24, 2021 at 2:15 PM Wang, Fei W > > > > wrote: > > > > > > > On Mon, 2021-03-22 at 20:12 +0800, Linjie

[FFmpeg-devel] [PATCH] avformat/hls: return ret when read_packet get exceptions

From: Steven Liu Should not modify to AVERROR_EOF value when get error number. for example: return HTTP ERROR return value when cannot get fragments from http protocol, for user get the point of problem. Reported-by: bevis Signed-off-by: Steven Liu --- libavformat/hls.c | 4 ++-- 1 file chang

[FFmpeg-devel] [PATCH v2 5/5] tests/checkasm/vf_gblur.c: update check_horiz_slice for the new ff_horiz_slice_avx2/512

Co-authored-by: Cheng Yanfei Co-authored-by: Jin Jun Signed-off-by: Wu Jianhua --- tests/checkasm/vf_gblur.c | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/tests/checkasm/vf_gblur.c b/tests/checkasm/vf_gblur.c index 0fac37b6be..a7a1c1a24e 100644 --- a/tes

[FFmpeg-devel] [PATCH v2 4/5] libavfilter/x86/vf_gblur: add localbuf and ff_horiz_slice_avx2/512()

We introduced a ff_horiz_slice_avx2/512() implemented on a new algorithm. In a nutshell, the new algorithm does three things, gathering data from 8/16 rows, blurring data, and scattering data back to the image buffer. Here we used a customized transpose 8x8/16x16 to avoid the huge overhead brought

[FFmpeg-devel] [PATCH v2 3/5] tests/checkasm/vf_gblur.c: add check_verti_slice() for unit test

Co-authored-by: Cheng Yanfei Co-authored-by: Jin Jun Signed-off-by: Wu Jianhua --- tests/checkasm/vf_gblur.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/tests/checkasm/vf_gblur.c b/tests/checkasm/vf_gblur.c index b9fe2f9a36..0fac37b6be 100644 --- a/tests/checkas

[FFmpeg-devel] [PATCH v2 2/5] libavfilter/x86/vf_gblur: add ff_verti_slice_avx2/512()

The new vertical slice with AVX2/512 acceleration can significantly improve the performance of Gaussian Filter 2D. Performance data: ff_verti_slice_c: 32.57 ff_verti_slice_avx2: 476.19 ff_verti_slice_avx512: 833.33 Co-authored-by: Cheng Yanfei Co-authored-by: Jin Jun Signed-off-by: Wu Jianhua

[FFmpeg-devel] [PATCH v2 1/5] libavfilter/x86/vf_gblur: add ff_postscale_slice_avx512()

Co-authored-by: Cheng Yanfei Co-authored-by: Jin Jun Signed-off-by: Wu Jianhua --- libavfilter/x86/vf_gblur.asm| 21 - libavfilter/x86/vf_gblur_init.c | 4 2 files changed, 16 insertions(+), 9 deletions(-) diff --git a/libavfilter/x86/vf_gblur.asm b/libavfilter/x8

Re: [FFmpeg-devel] [PATCH v1] avfilter/vf_vpp_qsv: add scale mode option

Hi Andreas,On Wed, Aug 4, 2021 at 8:30 AM Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: > Linjie Fu: > > On Wed, Mar 24, 2021 at 2:15 PM Wang, Fei W > wrote: > > > >> On Mon, 2021-03-22 at 20:12 +0800, Linjie Fu wrote: > >>> On Wed, Feb 24, 2021 at 9:44 AM Fei Wang > >>> wrote: > >

Re: [FFmpeg-devel] [PATCH] avutil/Makefile: Apply CFLAGS for compilation

On 8/3/2021 10:30 PM, Andreas Rheinhardt wrote: Fixes "make tools/crypto_bench.o". Can confirm it does fix it, so should be ok. Signed-off-by: Andreas Rheinhardt --- libavutil/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavutil/Makefile b/libavutil/Make

Re: [FFmpeg-devel] [PATCH] avfilter/vf_vpp_qsv: Don't overrun stack array

On Wed, 2021-08-04 at 02:27 +0200, Andreas Rheinhardt wrote: > 8b83dad82512a6948b63408f964463b063ad24c9 added another potentially > used > video enhancement filter without increasing a define for the number > of > such options which is used as the size of stack array. This can lead > to > a buffer

[FFmpeg-devel] [PATCH 3/4] avdevice/decklink: add levelA configure

From: Limin Wang Signed-off-by: Limin Wang --- doc/outdevs.texi| 4 libavdevice/decklink_common.cpp | 17 + libavdevice/decklink_common_c.h | 1 + libavdevice/decklink_enc_c.c| 1 + 4 files changed, 23 insertions(+) diff --git a/doc/outdevs.texi b/do

[FFmpeg-devel] [PATCH] avutil/Makefile: Apply CFLAGS for compilation

Fixes "make tools/crypto_bench.o". Signed-off-by: Andreas Rheinhardt --- libavutil/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavutil/Makefile b/libavutil/Makefile index 18dc5f22d9..410ac636f7 100644 --- a/libavutil/Makefile +++ b/libavutil/Makefile @@ -262,6

[FFmpeg-devel] [PATCH 2/4] avdevice/decklink: add sqd configure

From: Limin Wang Signed-off-by: Limin Wang --- doc/outdevs.texi| 4 libavdevice/decklink_common.cpp | 11 +++ libavdevice/decklink_common_c.h | 1 + libavdevice/decklink_enc_c.c| 1 + 4 files changed, 17 insertions(+) diff --git a/doc/outdevs.texi b/doc/outd

[FFmpeg-devel] [PATCH 1/4] avdevice/decklink: add link configuration

From: Limin Wang Signed-off-by: Limin Wang --- doc/outdevs.texi| 5 + libavdevice/decklink_common.cpp | 9 + libavdevice/decklink_common.h | 8 libavdevice/decklink_common_c.h | 1 + libavdevice/decklink_enc.cpp| 2 ++ libavdevice/decklink_enc_c.c|

[FFmpeg-devel] [PATCH 4/4] avdevice/decklink: support for more duplex mode for Decklink 8K Pro

From: Limin Wang Signed-off-by: Limin Wang --- doc/indevs.texi | 16 +++- doc/outdevs.texi| 16 +++- libavdevice/decklink_common.cpp | 8 libavdevice/decklink_common.h | 11 +++ libavdevice/decklink_dec_c.c| 10

Re: [FFmpeg-devel] [PATCH v1] avfilter/vf_vpp_qsv: add scale mode option

Linjie Fu: > On Wed, Mar 24, 2021 at 2:15 PM Wang, Fei W wrote: > >> On Mon, 2021-03-22 at 20:12 +0800, Linjie Fu wrote: >>> On Wed, Feb 24, 2021 at 9:44 AM Fei Wang >>> wrote: The option allow user to set diffenent scaling mode from auto/low-power/high-quality. More det

[FFmpeg-devel] [PATCH] avfilter/vf_vpp_qsv: Don't overrun stack array

8b83dad82512a6948b63408f964463b063ad24c9 added another potentially used video enhancement filter without increasing a define for the number of such options which is used as the size of stack array. This can lead to a buffer overrun if all filters are used simultaneously. So increase said number. F

Re: [FFmpeg-devel] Mailing List Delay

On Mon, Aug 02, 2021 at 09:59:47PM +0100, Derek Buitenhuis wrote: > On 7/14/2021 8:05 PM, Nicolas George wrote: > > Therefore, the information we need now to debug is what the logs of > > ffbox0-bg.mplayerhq.hu contains immediately after 20 Feb 2021 11:47:04 > > -0800. > > > > If it happens to you

[FFmpeg-devel] [PATCH] configure: Add dash before arflags

From: averne This allows specifying additional flags with `./configure --ar='ar -<...>`. Previously this resulted in commands such as `ar rcD -T`, which give an error ("no operation specified"), on certain versions of ar (eg 2.30-ubuntu). Signed-off-by: avener --- configure | 4 ++-- 1 file c

Re: [FFmpeg-devel] [PATCH 06/10] avfilter/internal: Move ff_norm_qscale() to qp_table.h

On Mon, Aug 02, 2021 at 05:39:11PM +0200, Andreas Rheinhardt wrote: > It is the natural header for it. > > Signed-off-by: Andreas Rheinhardt > --- > libavfilter/internal.h | 16 > libavfilter/qp_table.h | 17 + > 2 files changed, 17 insertions(+), 16 deletions(-)

Re: [FFmpeg-devel] Fix for PES packets with too much padding

August 3, 2021 10:07 AM, "Sergio M. Ammirata, Ph.D." wrote: > PES packet with too much padding trigger unlimited error > messages "PES packet size mismatch" because the code that > corrects the length is wrong. > Here is a sample file: http://99.93.62.129/smpte2038.ts > PID 300 is the one trigge

Re: [FFmpeg-devel] [PATCH v2 4/4] fftools/cmdutils: pass sws_flags to scale filter in simple filter graph

On Tue, Aug 3, 2021 at 1:07 AM Nicolas George wrote: > Linjie Fu (12021-08-03): > > From: Linjie Fu > > > > Pass sws_flags to scale filter through scale_sws_opts and correct the > > dumped flags information. > > > > CMD: > > $ffmpeg -v verbose -i input.mp4 -sws_flags lanczos+bitexact+accurate_rn

Re: [FFmpeg-devel] [PATCH v2 3/4] libswscale/utils: simplify the default scaler logic

On Tue, Aug 3, 2021 at 1:02 AM Nicolas George wrote: > Linjie Fu (12021-08-03): > > From: Linjie Fu > > > > Signed-off-by: Linjie Fu > > --- > > libswscale/utils.c | 7 +-- > > 1 file changed, 1 insertion(+), 6 deletions(-) > > Nack. The original logic needs to be evaluated to see if the o

[FFmpeg-devel] [PATCH v3 2/2] fftools/ffmpeg_filter: fix the flags parsing for scaler

From: Linjie Fu Scaler relys on "-sws_flags" option to pass the flags to swscale and scale filter. Currently passing "sws_flags=xxx" as a filter option to scaler leads to an incorrect option parsing. Check and change the string to "flags=xxx" and dumped flags information. (Refer to parse_sws_fla

[FFmpeg-devel] [PATCH v3 1/2] lavfi/vf_scale: use default swscale flags for simple and complex filter graph

From: Linjie Fu Currently the default swscale flags for simple filter graph is bicubic, however for complex filter graph it uses bilinear as decleared in scale filter. $ffmpeg -v verbose -i input.mp4 -vf format=yuv420p,scale=800x600 -an -f null - [Parsed_scale_1 @ 0x7f86d2c160c0] w:1920 h:1080 f

Re: [FFmpeg-devel] AAC - Fetching data out of data stream elements/DSE?

Carsten Gross: > Hello, > > AAC audio streams offer the possibility of transmitting additional binary > data with the audio data. The corresponding element is called a "data > stream element" (DSE). On the new ARD satellite audio transponder on > Astra 19.2E, this is used by NDR, for example, to t

[FFmpeg-devel] AAC - Fetching data out of data stream elements/DSE?

Hello, AAC audio streams offer the possibility of transmitting additional binary data with the audio data. The corresponding element is called a "data stream element" (DSE). On the new ARD satellite audio transponder on Astra 19.2E, this is used by NDR, for example, to transmit RDS (Radio Data Sys

Re: [FFmpeg-devel] [PATCH v1] avfilter/vf_vpp_qsv: add scale mode option

On 2021-08-03 20:13, Linjie Fu wrote: On Wed, Mar 24, 2021 at 2:15 PM Wang, Fei W wrote: On Mon, 2021-03-22 at 20:12 +0800, Linjie Fu wrote: On Wed, Feb 24, 2021 at 9:44 AM Fei Wang wrote: The option allow user to set diffenent scaling mode from auto/low-power/high-quality. More details

Re: [FFmpeg-devel] [PATCH v1] avfilter/vf_vpp_qsv: add scale mode option

On Wed, Mar 24, 2021 at 2:15 PM Wang, Fei W wrote: > On Mon, 2021-03-22 at 20:12 +0800, Linjie Fu wrote: > > On Wed, Feb 24, 2021 at 9:44 AM Fei Wang > > wrote: > > > > > > The option allow user to set diffenent scaling mode from > > > auto/low-power/high-quality. > > > > > > More details: > > >

Re: [FFmpeg-devel] [PATCH v3 33/34] avdevice/dshow: prevent NULL access

Diederick Niehorster: > list_options true would crash when both a video and an audio device were > specified as input. Crash would occur on line 1588 (in this new rev) > because ctx->device_unique_name[otherDevType] would be NULL > > Signed-off-by: Diederick Niehorster > --- > libavdevice/dshow.

Re: [FFmpeg-devel] [PATCH v3 00/34] avdevice (mostly dshow) enhancements

ping for the series On Sat, Jul 17, 2021 at 4:27 PM Diederick C. Niehorster wrote: > > On Wed, Jul 7, 2021 at 8:46 AM Diederick C. Niehorster > wrote: > > > > On Tue, Jul 6, 2021 at 11:20 AM Diederick Niehorster > > wrote: > > > > > > This patch series implements a series of features, mostly e

[FFmpeg-devel] Fix for PES packets with too much padding

PES packet with too much padding trigger unlimited error messages "PES packet size mismatch" because the code that corrects the length is wrong. Here is a sample file: http://99.93.62.129/smpte2038.ts PID 300 is the one triggering the errors. I am attaching a patch that fixes the problem. From 3a2

Re: [FFmpeg-devel] [PATCH v1 1/1] check and propagate function return value

On 8/3/2021 9:00 AM, Maryam Ebrahimzadeh wrote: On Aug 3, 2021, at 11:07 AM, Paul B Mahol mailto:one...@gmail.com>> wrote: lgtm Thanks for reviewing. If it is my duty, how can I push it to the master? Pushed it, thanks. ___ ffmpeg-devel mailing l

Re: [FFmpeg-devel] [PATCH] Nvenc: Adding support for chroma qp offset for h264_nvenc and hevc_nvenc

On 03.08.2021 12:46, Ricardo Monteiro wrote: Hello, With the release of the Video Coding SDK 11.1 support for specifying chroma QP offsets for Cb and Cr components was added. To reproduce this the newest nv-codec-headers are necessary. The new parameters are qp_cb_offset and qp_cr_offset for

Re: [FFmpeg-devel] [PATCH v1 1/1] check and propagate function return value

On Aug 3, 2021, at 11:07 AM, Paul B Mahol mailto:one...@gmail.com>> wrote: lgtm Thanks for reviewing. If it is my duty, how can I push it to the master? ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://f

[FFmpeg-devel] [PATCH] Adds base-uri parameter to librsvg, allowing e.g. embedded images in SVGs to be loaded

Usage of the data URI scheme is currently needed to load external references in SVGs. This patch adds a base_uri parameter so linked images can be rendered without encoding them in Base64. http://www.w3.org/2000/svg"; xmlns:xlink="http://www.w3.org/1999/xlink";> Signed-off-by: Daniel Pe

Re: [FFmpeg-devel] [PATCH 08/10] avfilter/internal: Don't include libavcodec/(avcodec|internal).h

Andreas Rheinhardt (12021-08-03): > Does this LGTM also pertain to the preceding two patches (which remove > the reasons for including these headers)? No. Patch #7 looks ok, but I do not maintain that file. I do not have expertise to judge #6. Regards, -- Nicolas George signature.asc Descri

Re: [FFmpeg-devel] [PATCH 08/10] avfilter/internal: Don't include libavcodec/(avcodec|internal).h

Nicolas George: > Andreas Rheinhardt (12021-08-02): >> The reasons for including them don't exist any longer: ff_tlog() has >> been moved to libavutil/internal.h and FF_QSCALE_TYPE_* has been moved >> to qp_table.h. >> >> Signed-off-by: Andreas Rheinhardt >> --- >> The following headers are now no

Re: [FFmpeg-devel] [PATCH 09/10] avfilter/internal: Don't include framepool.h, thread.h

Andreas Rheinhardt (12021-08-02): > They are not used by the header at all and only used by very few files; > so include the headers in their users instead of in internal.h. > > Signed-off-by: Andreas Rheinhardt > --- > libavfilter/audio.c| 1 + > libavfilter/avfilter.c | 1 + > libavfilter/

Re: [FFmpeg-devel] [PATCH 08/10] avfilter/internal: Don't include libavcodec/(avcodec|internal).h

Andreas Rheinhardt (12021-08-02): > The reasons for including them don't exist any longer: ff_tlog() has > been moved to libavutil/internal.h and FF_QSCALE_TYPE_* has been moved > to qp_table.h. > > Signed-off-by: Andreas Rheinhardt > --- > The following headers are now no longer provided by > li

Re: [FFmpeg-devel] [PATCH] avfilter/avfilter: use av_frame_copy() to copy frame data

James Almer (12021-08-02): > Signed-off-by: James Almer > --- > libavfilter/avfilter.c | 17 - > 1 file changed, 4 insertions(+), 13 deletions(-) imgutils.h is probably now unneeded. LGTM otherwise. Regards, -- Nicolas George signature.asc Description: PGP signature __

[FFmpeg-devel] [PATCH v1 1/1] return value check for init_get_bits in adts_decode_extradata

As second argument for init_get_bits (buf) can be crafted, return value check for this function call is necessary. 'buf' is part of 'AVPacket pkt'. --- libavformat/adtsenc.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/libavformat/adtsenc.c b/libavformat/adtsenc.c

Re: [FFmpeg-devel] [PATCH 2/5] libavfilter/x86/vf_gblur: add ff_verti_slice_avx2/512()

> From: ffmpeg-devel On Behalf Of > Michael Niedermayer > Sent: Tuesday, August 3, 2021 2:16 AM > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH 2/5] libavfilter/x86/vf_gblur: add > ff_verti_slice_avx2/512() > > On Mon, Aug 02, 2021 at 01:34

Re: [FFmpeg-devel] Mailing List Delay

August 2, 2021 5:57 PM, "Derek Buitenhuis" wrote: > On 8/2/2021 10:48 PM, ffmpegandmahanstreamer@e.email wrote: > >> Have you checked the mailing list archives? Maybe its slow to get to others >> but fast to get on the >> ML. > > No, it is not. It's the same issue as we looked at above. I susp