Re: [FFmpeg-devel] [PATCH] avcodec/h264_parser: remove key frame tagging heuristics

2021-07-12 Thread Kieran Kunhya
On Tue, 13 Jul 2021, 02:45 James Almer, wrote: > On 7/12/2021 10:01 PM, Kieran Kunhya wrote: > >> > >> Because it isn't something that should be marked as a keyframe as coded > >> bitstream in any kind of container, like it's the case of mp4 sync > samples. > >> > > > > MPEG-TS Random Access Indi

Re: [FFmpeg-devel] [PATCH] avcodec/h264_parser: remove key frame tagging heuristics

2021-07-12 Thread James Almer
On 7/12/2021 10:01 PM, Kieran Kunhya wrote: Because it isn't something that should be marked as a keyframe as coded bitstream in any kind of container, like it's the case of mp4 sync samples. MPEG-TS Random Access Indicator expects keyframes to be signalled like this. With intra-refresh and t

Re: [FFmpeg-devel] [PATCH] avcodec/h264_parser: remove key frame tagging heuristics

2021-07-12 Thread Kieran Kunhya
> > Because it isn't something that should be marked as a keyframe as coded > bitstream in any kind of container, like it's the case of mp4 sync samples. > MPEG-TS Random Access Indicator expects keyframes to be signalled like this. With intra-refresh and this code removed, there will be no random

Re: [FFmpeg-devel] [PATCH] avcodec/h264_parser: remove key frame tagging heuristics

2021-07-12 Thread James Almer
On 7/12/2021 8:53 PM, Kieran Kunhya wrote: On Mon, 12 Jul 2021 at 20:33, James Almer wrote: None of these packets contain keyframes, and tagging them as such can result in non spec compliant output when remuxing into containers like mp4 and Matroska, where bogus samples would be marked as Sync

Re: [FFmpeg-devel] [PATCH] avcodec/h264_parser: remove key frame tagging heuristics

2021-07-12 Thread Kieran Kunhya
On Mon, 12 Jul 2021 at 20:33, James Almer wrote: > None of these packets contain keyframes, and tagging them as such can > result in > non spec compliant output when remuxing into containers like mp4 and > Matroska, > where bogus samples would be marked as Sync Samples. > > Some tests are updated

[FFmpeg-devel] [PATCH] web/security: Add CVE-2021-30123 (never affected a release)

2021-07-12 Thread Michael Niedermayer
Thanks to Jan Ekström for details --- src/security | 1 + 1 file changed, 1 insertion(+) diff --git a/src/security b/src/security index 935823b..1248018 100644 --- a/src/security +++ b/src/security @@ -15,6 +15,7 @@ CVE-2020-21041, 5d9f44da460f781a1604d537d0555b78e29438ba, ticket/7989 CVE-2020-

Re: [FFmpeg-devel] [PATCH 6/8] lavfi/vf_scale: convert to the frame-based sws API

2021-07-12 Thread James Almer
On 7/12/2021 4:39 PM, Michael Niedermayer wrote: On Mon, Jul 12, 2021 at 01:07:07PM +0200, Anton Khirnov wrote: --- libavfilter/vf_scale.c | 73 -- 1 file changed, 49 insertions(+), 24 deletions(-) crashes: ./ffmpeg -i ~/tickets/5264/gbrap16.tif -

Re: [FFmpeg-devel] [PATCH 6/8] lavfi/vf_scale: convert to the frame-based sws API

2021-07-12 Thread Michael Niedermayer
On Mon, Jul 12, 2021 at 01:07:07PM +0200, Anton Khirnov wrote: > --- > libavfilter/vf_scale.c | 73 -- > 1 file changed, 49 insertions(+), 24 deletions(-) crashes: ./ffmpeg -i ~/tickets/5264/gbrap16.tif -vf format=yuva444p,scale=alphablend=checkerboard,

[FFmpeg-devel] [PATCH] avcodec/h264_parser: remove key frame tagging heuristics

2021-07-12 Thread James Almer
None of these packets contain keyframes, and tagging them as such can result in non spec compliant output when remuxing into containers like mp4 and Matroska, where bogus samples would be marked as Sync Samples. Some tests are updated to reflect this. Suggested-by: ffm...@fb.com Signed-off-by: Ja

Re: [FFmpeg-devel] [PATCH 8/8] lavfi/vf_scale: pass the thread count to the scaler

2021-07-12 Thread Michael Niedermayer
On Mon, Jul 12, 2021 at 01:07:09PM +0200, Anton Khirnov wrote: > --- > libavfilter/vf_scale.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavfilter/vf_scale.c b/libavfilter/vf_scale.c > index cdff3ab7ed..f676f5d82e 100644 > --- a/libavfilter/vf_scale.c > +++ b/libavfilter/vf_scale.

Re: [FFmpeg-devel] [PATCH 5/8] sws: add a new scaling API

2021-07-12 Thread Michael Niedermayer
On Mon, Jul 12, 2021 at 01:07:06PM +0200, Anton Khirnov wrote: [...] > diff --git a/libswscale/swscale.h b/libswscale/swscale.h > index 50d6d46553..41eacd2dea 100644 > --- a/libswscale/swscale.h > +++ b/libswscale/swscale.h > @@ -30,6 +30,7 @@ > #include > > #include "libavutil/avutil.h" > +#i

Re: [FFmpeg-devel] FFMPEG for V4L2 M2M devices ?

2021-07-12 Thread Andriy Gelman
On Mon, 12. Jul 11:02, Dave Stevenson wrote: > On Sat, 10 Jul 2021 at 00:56, Brad Hards wrote: > > > > On Saturday, 10 July 2021 8:53:27 AM AEST Andrii wrote: > > > I am working on porting a Kodi player to an NVidia Jetson Nano device. > > > I've > > > been developing a decoder for quite some tim

Re: [FFmpeg-devel] FFMPEG for V4L2 M2M devices ?

2021-07-12 Thread Dave Stevenson
On Mon, 12 Jul 2021 at 14:51, Andrii wrote: >> >> A quick Google implies that NVidia already has a stateful V4L2 M2M >> driver in their vendor kernel. Other than the strange choice of device >> node name (/dev/nvhost-nvdec), the details at [3] make it look like a >> normal V4L2 M2M decoder that ha

Re: [FFmpeg-devel] FFMPEG for V4L2 M2M devices ?

2021-07-12 Thread Andrii
> > A quick Google implies that NVidia already has a stateful V4L2 M2M > driver in their vendor kernel. Other than the strange choice of device > node name (/dev/nvhost-nvdec), the details at [3] make it look like a > normal V4L2 M2M decoder that has a good chance of working against > h264_v4l2m2m.

Re: [FFmpeg-devel] [PATCH 1/2] libavutil/cpu: Adds fast gather detection.

2021-07-12 Thread Lynne
12 Jul 2021, 13:53 by jamr...@gmail.com: > On 7/12/2021 7:46 AM, Lynne wrote: > >> 12 Jul 2021, 11:29 by alankelly-at-google@ffmpeg.org: >> >>> On Fri, Jun 25, 2021 at 1:24 PM Alan Kelly wrote: >>> On Fri, Jun 25, 2021 at 10:40 AM Lynne wrote: > Jun 25, 2021, 09:54 by alankelly

Re: [FFmpeg-devel] [PATCH 1/1] libavformat/rtsp.c: Reply to GET_PARAMETER requests

2021-07-12 Thread Martin Storsjö
On Sat, 26 Jun 2021, Martin Storsjö wrote: On Fri, 25 Jun 2021, Hayden Myers wrote: Some encoders send GET_PARAMETER requests as a keep-alive mechanism. If the client doesn't reply with an OK message, the encoder will close the session.  This was encountered with the impath i5110 encoder, when

Re: [FFmpeg-devel] [PATCH 2/2] avformat/movenc: add support for TTML muxing

2021-07-12 Thread Martin Storsjö
On Tue, 22 Jun 2021, Jan Ekström wrote: From: Jan Ekström Includes basic support for both the ISMV ('dfxp') and MP4 ('stpp') methods. This initial version also foregoes fragmentation support as this eases the initial review. Hmm, I'm not sure I understand here, this seems to add at least som

Re: [FFmpeg-devel] [PATCH 1/2] libavutil/cpu: Adds fast gather detection.

2021-07-12 Thread James Almer
On 7/12/2021 7:46 AM, Lynne wrote: 12 Jul 2021, 11:29 by alankelly-at-google@ffmpeg.org: On Fri, Jun 25, 2021 at 1:24 PM Alan Kelly wrote: On Fri, Jun 25, 2021 at 10:40 AM Lynne wrote: Jun 25, 2021, 09:54 by alankelly-at-google@ffmpeg.org: Broadwell and later and Zen3 and later

Re: [FFmpeg-devel] [PATCH 24/24] lavfi/vf_scale: implement slice threading

2021-07-12 Thread Michael Niedermayer
On Mon, Jul 12, 2021 at 12:34:55PM +0200, Anton Khirnov wrote: > Quoting Michael Niedermayer (2021-07-03 18:27:36) > > On Sat, Jul 03, 2021 at 03:27:36PM +0200, Anton Khirnov wrote: > > > Quoting Michael Niedermayer (2021-06-01 11:35:13) > > > > On Mon, May 31, 2021 at 09:55:15AM +0200, Anton Khirn

Re: [FFmpeg-devel] [PATCH 24/24] lavfi/vf_scale: implement slice threading

2021-07-12 Thread Hendrik Leppkes
On Mon, Jul 12, 2021 at 12:35 PM Anton Khirnov wrote: > > Quoting Michael Niedermayer (2021-07-03 18:27:36) > > On Sat, Jul 03, 2021 at 03:27:36PM +0200, Anton Khirnov wrote: > > > Quoting Michael Niedermayer (2021-06-01 11:35:13) > > > > On Mon, May 31, 2021 at 09:55:15AM +0200, Anton Khirnov wro

[FFmpeg-devel] [PATCH 5/8] sws: add a new scaling API

2021-07-12 Thread Anton Khirnov
--- libswscale/swscale.c | 263 ++ libswscale/swscale.h | 80 +++ libswscale/swscale_internal.h | 19 +++ libswscale/utils.c| 70 + 4 files changed, 374 insertions(+), 58 deletions(-) diff --git a/libswscale/swscale.

[FFmpeg-devel] [PATCH 8/8] lavfi/vf_scale: pass the thread count to the scaler

2021-07-12 Thread Anton Khirnov
--- libavfilter/vf_scale.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavfilter/vf_scale.c b/libavfilter/vf_scale.c index cdff3ab7ed..f676f5d82e 100644 --- a/libavfilter/vf_scale.c +++ b/libavfilter/vf_scale.c @@ -543,6 +543,7 @@ static int config_props(AVFilterLink *outlink)

[FFmpeg-devel] [PATCH 6/8] lavfi/vf_scale: convert to the frame-based sws API

2021-07-12 Thread Anton Khirnov
--- libavfilter/vf_scale.c | 73 -- 1 file changed, 49 insertions(+), 24 deletions(-) diff --git a/libavfilter/vf_scale.c b/libavfilter/vf_scale.c index 39ab3a4b28..cdff3ab7ed 100644 --- a/libavfilter/vf_scale.c +++ b/libavfilter/vf_scale.c @@ -620,29 +620,

[FFmpeg-devel] [PATCH 7/8] sws: implement slice threading

2021-07-12 Thread Anton Khirnov
--- libswscale/options.c | 3 ++ libswscale/swscale.c | 56 libswscale/swscale_internal.h | 14 ++ libswscale/utils.c| 82 +++ 4 files changed, 155 insertions(+) diff --git a/libswscale/options.c b/libswsc

[FFmpeg-devel] [PATCH 1/8] tools/venc_data_dump: factor out demux/decode code

2021-07-12 Thread Anton Khirnov
It can be shared with other simple demux/decode tools. --- tests/ref/fate/source | 1 + tools/Makefile | 2 + tools/decode_simple.c | 157 + tools/decode_simple.h | 53 ++ tools/venc_data_dump.c | 156 +

[FFmpeg-devel] [PATCH 4/8] lavu/slicethread: return ENOSYS rather than EINVAL in the dummy func

2021-07-12 Thread Anton Khirnov
EINVAL is the wrong error code here, since the arguments passed to the function are valid. The error is that the function is not implemented in the build, which corresponds to ENOSYS. --- libavutil/slicethread.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavutil/slicethr

[FFmpeg-devel] [PATCH 3/8] lavfi/vf_scale: remove the nb_slices option

2021-07-12 Thread Anton Khirnov
It was intended for debugging only and has been superseded by the standalone tool for testing sliced scaling. --- libavfilter/vf_scale.c | 14 -- 1 file changed, 14 deletions(-) diff --git a/libavfilter/vf_scale.c b/libavfilter/vf_scale.c index 71d7fa2890..39ab3a4b28 100644 --- a/liba

[FFmpeg-devel] [PATCH 2/8] FATE: add a test for sliced scaling

2021-07-12 Thread Anton Khirnov
--- Makefile | 2 + tests/Makefile| 1 + tests/fate/libswscale.mak | 11 +++ tools/Makefile| 3 +- tools/scale_slice_test.c | 190 ++ 5 files changed, 206 insertions(+), 1 deletion(-) create mode 100644 tools/sca

[FFmpeg-devel] [RFC/PATCH v2] swscale slice threading

2021-07-12 Thread Anton Khirnov
Hi, here is a new iteration of $subj. Compared to the first version, threading has been moved into sws using lavu slicethread. There is also a new AVFrame-based API that allows submitting and receiving partial slices (at least API-wise, the implementation will still wait for complete input). There

Re: [FFmpeg-devel] [PATCH] mxfdec.c: fixed frame wrapping detection for MXFGCP1FrameWrappedPicture essence container

2021-07-12 Thread Tomas Härdin
sön 2021-07-11 klockan 09:47 -0700 skrev p...@sandflow.com: > From: Pierre-Anthony Lemieux > > Signed-off-by: Pierre-Anthony Lemieux > --- > > Notes: > For JPEG 2000 essence, the MXF input format module currently uses the > value of byte 14 of the essence container UL to determines whether

Re: [FFmpeg-devel] [PATCH 1/2] libavutil/cpu: Adds fast gather detection.

2021-07-12 Thread Lynne
12 Jul 2021, 11:29 by alankelly-at-google@ffmpeg.org: > On Fri, Jun 25, 2021 at 1:24 PM Alan Kelly wrote: > >> On Fri, Jun 25, 2021 at 10:40 AM Lynne wrote: >> >>> Jun 25, 2021, 09:54 by alankelly-at-google@ffmpeg.org: >>> >>> > Broadwell and later and Zen3 and later have fast gather ins

Re: [FFmpeg-devel] [PATCH 24/24] lavfi/vf_scale: implement slice threading

2021-07-12 Thread Anton Khirnov
Quoting Michael Niedermayer (2021-07-03 18:27:36) > On Sat, Jul 03, 2021 at 03:27:36PM +0200, Anton Khirnov wrote: > > Quoting Michael Niedermayer (2021-06-01 11:35:13) > > > On Mon, May 31, 2021 at 09:55:15AM +0200, Anton Khirnov wrote: > > > > --- > > > > libavfilter/vf_scale.c | 182 +++

Re: [FFmpeg-devel] [PATCH 1/2] libavutil/cpu: Adds fast gather detection.

2021-07-12 Thread Alan Kelly
On Fri, Jun 25, 2021 at 1:24 PM Alan Kelly wrote: > On Fri, Jun 25, 2021 at 10:40 AM Lynne wrote: > >> Jun 25, 2021, 09:54 by alankelly-at-google@ffmpeg.org: >> >> > Broadwell and later and Zen3 and later have fast gather instructions. >> > --- >> > Gather requires between 9 and 12 cycles o

[FFmpeg-devel] [PATCH] cafenc: fill in avg. packet size later if unknown

2021-07-12 Thread Roman Beranek
> This doesn't move the pointer back to the file end if par->block_align is set. > I think that's fine though, since the function writes the trailer, which > should > mean that nothing more needs to be written. Is it a convention to leave the pointer positioned at the end of the file? ___

Re: [FFmpeg-devel] FFMPEG for V4L2 M2M devices ?

2021-07-12 Thread Dave Stevenson
On Sat, 10 Jul 2021 at 00:56, Brad Hards wrote: > > On Saturday, 10 July 2021 8:53:27 AM AEST Andrii wrote: > > I am working on porting a Kodi player to an NVidia Jetson Nano device. I've > > been developing a decoder for quite some time now, and realized that the > > best approach would be to hav

[FFmpeg-devel] [PATCH] cafenc: fill in avg. packet size later if unknown

2021-07-12 Thread Roman Beranek
In-Reply-To: References: <20210710011006.3383868-1-roman.bera...@prusa3d.cz> Reply-To: FFmpeg development discussions and patches > This doesn't move the pointer back to the file end if par->block_align is set. > I think that's fine though, since the function writes the trailer, which > shoul

Re: [FFmpeg-devel] [PATCH v3 0/2] libx264 configure check clean-up

2021-07-12 Thread Jan Ekström
On Sat, Jul 10, 2021 at 8:55 PM James Almer wrote: > > On 7/10/2021 1:26 PM, Jan Ekström wrote: > > On Wed, Jul 7, 2021, 22:01 Jan Ekström wrote: > > > >> Changes compared to v2: > >> - Kept the CONFIG_LIBX264RGB_ENCODER define check for ff_libx264rgb_encoder > >>and the AVClass for libx264rg

Re: [FFmpeg-devel] Request for review - x265 User Data Unregistered SEI patch

2021-07-12 Thread Brad Hards
On Sunday, 11 July 2021 10:01:47 PM AEST Derek Buitenhuis wrote: > Can you amend the commit message to contain the reasoning from [1]? Amended. > A quick review: > > +void *sei_data; > > +int sei_data_size; > > I don't see sei_data freed anywhere at the end of decoding? Fixed in v2. Inclu

[FFmpeg-devel] [PATCH v2] libavcodec/libx265: add user data unregistered SEI encoding

2021-07-12 Thread Brad Hards
MISB ST 0604 and ST 2101 require user data unregistered SEI messages (precision timestamps and sensor identifiers) to be included. That currently isn't supported for libx265. This patch adds support for user data unregistered SEI messages in accordance with ISO/IEC 23008-2:2020 Section D.2.7 The d

Re: [FFmpeg-devel] [PATCH] cafenc: fill in avg. packet size later if unknown

2021-07-12 Thread Lynne
10 Jul 2021, 09:42 by d...@lynne.ee: > 10 Jul 2021, 03:10 by roman.bera...@prusa3d.cz: > >> Frame size of Opus stream was previously presumed here to be 960 samples >> (20ms), however sizes of 120, 240, 480, 1920, and 2880 are also allowed. >> It can also alter on a per-packet basis and even multi

Re: [FFmpeg-devel] [PATCH] fate/oggvorbis: Fix tests after fixing AV_PKT_DATA_SKIP_SAMPLES

2021-07-12 Thread Lynne
10 Jul 2021, 02:12 by sunguangy...@gmail.com: > After fixing AV_PKT_DATA_SKIP_SAMPLES for reading vorbis packets from ogg, > the actual decoded samples become fewer. Three fate tests are failing: > > fate-vorbis-20: > The samples in 6.ogg are not frame aligned. 6.pcm file was generated by > ffmpeg