[FFmpeg-devel] [PATCH] avfilter/dnn_filter_common: Use const where appropriate

2021-06-24 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavfilter/dnn_filter_common.c | 2 +- libavfilter/dnn_filter_common.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/libavfilter/dnn_filter_common.c b/libavfilter/dnn_filter_common.c index 0ed0ac2..fcee748 100644 --- a/lib

Re: [FFmpeg-devel] [PATCH] avformat: add a concat protocol that takes a line break delimited list of resources

2021-06-24 Thread Nicolas George
James Almer (12021-06-24): > Can you tell me how to create a file with a \n in its name? I can test on > Archlinux. touch 'foo bar' With some shells, you can write: touch $'foo\nbar' Regards, -- Nicolas George signature.asc Description: PGP signature __

Re: [FFmpeg-devel] [PATCH 2/3] avformat/sbgdec: Check opt_duration and start for overflow

2021-06-24 Thread Nicolas George
Michael Niedermayer (12021-06-24): > Fixes: signed integer overflow: 27886261755 + 71189412840 > cannot be represented in type 'long' > Fixes: > 35215/clusterfuzz-testcase-minimized-ffmpeg_dem_SBG_fuzzer-6123272247836672 > > Found-by: continuous fuzzing process > https://github.

Re: [FFmpeg-devel] [PATCH] avformat: add a concat protocol that takes a line break delimited list of resources

2021-06-24 Thread James Almer
On 6/24/2021 1:38 PM, Nicolas George wrote: James Almer (12021-06-24): Can the \n in filenames be escaped, either with backslash or quotes, like with other special characters? If so, then they should be supported that way already. Please test. Reading your code tells me it does not work as is,

Re: [FFmpeg-devel] Hardware purchase request

2021-06-24 Thread Stefano Sabatini
On Thu, Jun 24, 2021 at 2:04 PM Michael Niedermayer wrote: [...] > > iam also adding stefano to the CC as there was some communication between > > a few developers and SPI about this expense and iam not sure stefano is > > following > > the ML > > to re-animate this thread > cryptos seem down and

[FFmpeg-devel] [PATCH 2/3] avformat/sbgdec: Check opt_duration and start for overflow

2021-06-24 Thread Michael Niedermayer
Fixes: signed integer overflow: 27886261755 + 71189412840 cannot be represented in type 'long' Fixes: 35215/clusterfuzz-testcase-minimized-ffmpeg_dem_SBG_fuzzer-6123272247836672 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg S

[FFmpeg-devel] [PATCH 1/3] avformat/matroskadec: Reset state also on failure in matroska_reset_status()

2021-06-24 Thread Michael Niedermayer
The calling code does not handle failures and will fail with assertion failures later. Seeking can always fail even when the position was previously read. Fixes: Assertion failure Fixes: 35253/clusterfuzz-testcase-minimized-ffmpeg_dem_MATROSKA_fuzzer-4693059982983168 Found-by: continuous fuzzin

[FFmpeg-devel] [PATCH 3/3] avcodec/utils: Use 64bit for intermediate in AV_CODEC_ID_ADPCM_THP* duration calculation

2021-06-24 Thread Michael Niedermayer
Fixes: signed integer overflow: 486539264 * 14 cannot be represented in type 'int' Fixes: 35281/clusterfuzz-testcase-minimized-ffmpeg_dem_RSD_fuzzer-6068262742917120 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Nieder

Re: [FFmpeg-devel] [PATCH] avcodec: Pass the HDR10+ metadata to the packet side data in VP9 encoder

2021-06-24 Thread James Zern
On Tue, Jun 22, 2021 at 1:46 PM James Zern wrote: > > On Thu, Jun 17, 2021 at 10:21 PM Mohammad Izadi > wrote: > > > > HDR10+ metadata is stored in the bit stream for HEVC. The story is > > different for VP9 and cannot store the metadata in the bit stream. HDR10+ > > should be passed to packet

Re: [FFmpeg-devel] [PATCH] avformat: add a concat protocol that takes a line break delimited list of resources

2021-06-24 Thread Nicolas George
James Almer (12021-06-24): > Can the \n in filenames be escaped, either with backslash or quotes, like > with other special characters? If so, then they should be supported that way > already. Please test. Reading your code tells me it does not work as is, but it could. You are making a common mis

Re: [FFmpeg-devel] [PATCH] avformat: add a concat protocol that takes a line break delimited list of resources

2021-06-24 Thread James Almer
On 6/24/2021 12:44 PM, Nicolas George wrote: James Almer (12021-06-24): Are we ok that file with a \n in their name will not be supported? Yes, since it's used to delimit files in the list. I know, it is the reason I asked. So, I say it negatively: I am not ok that this prevents valid filena

Re: [FFmpeg-devel] [PATCH] avformat: add a concat protocol that takes a line break delimited list of resources

2021-06-24 Thread Nicolas George
James Almer (12021-06-24): > > Are we ok that file with a \n in their name will not be supported? > Yes, since it's used to delimit files in the list. I know, it is the reason I asked. So, I say it negatively: I am not ok that this prevents valid filenames from being used, even if they are very e

Re: [FFmpeg-devel] [PATCH] avformat: add a concat protocol that takes a line break delimited list of resources

2021-06-24 Thread James Almer
On 6/24/2021 11:59 AM, Nicolas George wrote: James Almer (12021-06-23): Suggested-by: ffm...@fb.com Signed-off-by: James Almer --- doc/protocols.texi | 30 +++ libavformat/Makefile| 1 + libavformat/concat.c| 111 libavformat

Re: [FFmpeg-devel] [PATCH] avformat: add a concat protocol that takes a line break delimited list of resources

2021-06-24 Thread Nicolas George
James Almer (12021-06-23): > Suggested-by: ffm...@fb.com > Signed-off-by: James Almer > --- > doc/protocols.texi | 30 +++ > libavformat/Makefile| 1 + > libavformat/concat.c| 111 > libavformat/protocols.c | 1 + > 4 files change

Re: [FFmpeg-devel] [PATCH 1/2] libavutil/cpu: Adds av_cpu_has_fast_gather to detect cpus with avx fast gather instruction

2021-06-24 Thread James Almer
On 6/24/2021 10:30 AM, Alan Kelly wrote: Hi, Sorry for the late reply, busy oncall week. Thanks for your responses. I have looked at the code for cpuflags and what you suggested makes sense. I just have a question about naming. EXTERNAL_AVX2_FAST is already used in many places - it checks whethe

Re: [FFmpeg-devel] [PATCH 1/2] libavutil/cpu: Adds av_cpu_has_fast_gather to detect cpus with avx fast gather instruction

2021-06-24 Thread Alan Kelly
Hi, Sorry for the late reply, busy oncall week. Thanks for your responses. I have looked at the code for cpuflags and what you suggested makes sense. I just have a question about naming. EXTERNAL_AVX2_FAST is already used in many places - it checks whether the flag AV_CPU_FLAG_AVXSLOW is set so I

Re: [FFmpeg-devel] [PATCH] avcodec/h264_metadata_bsf: Allow zeroing constraint_set4_flag and constraint_set5_flag

2021-06-24 Thread Derek Buitenhuis
On 24/06/2021 02:23, James Almer wrote: >> +@item zero_new_constraint_set_flags >> +Zero constraint_set4_flag and constraint_set5_flag in the SPS. These >> +bits were reserved in a previous version of the H.264 spec, and thus >> +some hardware encoders require these to be zero. The result of zeroin

[FFmpeg-devel] [PATCH 2/2] Advertise current segment in streaming mode

2021-06-24 Thread Kevin LaFlamme
In streaming mode when using a segment list, the current segment should be listed so that clients can immediately request it even before complete. Without this, even though the segment is being written in a way that it can be requested while still writing, clients won't know it's available. --- li

[FFmpeg-devel] [PATCH 1/2] Fix double write of DASH manifest in streaming mode

2021-06-24 Thread Kevin LaFlamme
When streaming mode is enabled, the DASH manifest is written on the first packet for the segment so that the segment can be advertised immediately to clients. It was also still writing the manifest at the end of the segment leading to two duplicate writes. --- libavformat/dashenc.c | 7 +-- 1

Re: [FFmpeg-devel] Hardware purchase request

2021-06-24 Thread Michael Niedermayer
On Tue, Apr 27, 2021 at 03:56:40PM +0200, Michael Niedermayer wrote: > On Mon, Apr 26, 2021 at 04:00:43PM +0200, Lynne wrote: > > Apr 8, 2021, 00:24 by mich...@niedermayer.cc: > > > > > On Sat, Apr 03, 2021 at 10:32:13PM +0200, Lynne wrote: > > > > > >> Apr 3, 2021, 20:12 by mich...@niedermayer.cc