[FFmpeg-devel] [PATCH v3 22/22] lavfi/vpp_qsv: allow user to set scaling mode for vpp_qsv filter

2021-06-14 Thread Haihao Xiang
option 'scaling' accepts one of low_power and hq $ ffmpeg -init_hw_device qsv -hwaccel qsv -c:v h264_qsv -i input.h264 -vf "vpp_qsv=scaling=hq" -f null - --- libavfilter/vf_vpp_qsv.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/libavfilter/vf_vpp_qsv.c b/libavfilter/vf_vpp_qsv.

[FFmpeg-devel] [PATCH v3 21/22] lavfi/deinterlace_qsv: add more input / output pixel formats

2021-06-14 Thread Haihao Xiang
NV12 is added in system memory and the command below may work now. $ ffmpeg -init_hw_device qsv -c:v h264_qsv -i input.h264 -vf deinterlace_qsv -f null - --- libavfilter/vf_vpp_qsv.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavfilter/vf_vpp_qsv.c b/libavfilter/vf_v

[FFmpeg-devel] [PATCH v3 20/22] lavfi/deinterlace_qsv: add async_depth option

2021-06-14 Thread Haihao Xiang
Allow user to set async depth for deinterlace_qsv --- libavfilter/vf_vpp_qsv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavfilter/vf_vpp_qsv.c b/libavfilter/vf_vpp_qsv.c index ba7d3488f1..99659a5523 100644 --- a/libavfilter/vf_vpp_qsv.c +++ b/libavfilter/vf_vpp_qsv.c @@ -713,6 +713,7

[FFmpeg-devel] [PATCH v3 19/22] lavfi/deinterlace_qsv: re-use VPPContext for deinterlace_qsv filter

2021-06-14 Thread Haihao Xiang
All features are implemented in vpp_qsv filter now, so deinterlace_qsv can be taken as a specical case of vpp_qsv filter, we re-use VPPContext with a different option array and pix formats for deinterlace_qsv filter --- libavfilter/Makefile | 2 +- libavfilter/vf_deinterlace_qsv.c |

[FFmpeg-devel] [PATCH v3 14/22] lavfi/vpp_qsv: double the framerate for deinterlacing

2021-06-14 Thread Haihao Xiang
--- libavfilter/vf_vpp_qsv.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/libavfilter/vf_vpp_qsv.c b/libavfilter/vf_vpp_qsv.c index 29ba220665..cde1acdbb0 100644 --- a/libavfilter/vf_vpp_qsv.c +++ b/libavfilter/vf_vpp_qsv.c @@ -255,10 +255,16 @@ static int config_

[FFmpeg-devel] [PATCH v3 13/22] lavfi/scale_qsv: add more input / output pixel formats

2021-06-14 Thread Haihao Xiang
NV12 and P010 are added $ ffmpeg -init_hw_device qsv -c:v h264_qsv -i input.h264 -vf "scale_qsv=format=p010" -f null - --- libavfilter/vf_vpp_qsv.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavfilter/vf_vpp_qsv.c b/libavfilter/vf_vpp_qsv.c index bceee8c4df..29ba220

[FFmpeg-devel] [PATCH v3 12/22] lavfi/scale_qsv: add new options for scale_qsv filter

2021-06-14 Thread Haihao Xiang
Allow user to set crop area and async depth --- libavfilter/vf_vpp_qsv.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/libavfilter/vf_vpp_qsv.c b/libavfilter/vf_vpp_qsv.c index 03785e9398..bceee8c4df 100644 --- a/libavfilter/vf_vpp_qsv.c +++ b/libavfilter/vf_vpp_qsv.c @@ -675,6 +675,10

[FFmpeg-devel] [PATCH v3 18/22] lavfi/deinterlace_qsv: simplify deinterlace_qsv filter

2021-06-14 Thread Haihao Xiang
Like what we did for scale_qsv filter, we use QSVVPPContext as a base context to manage MFX session for deinterlace_qsv filter --- libavfilter/vf_deinterlace_qsv.c | 492 ++- 1 file changed, 30 insertions(+), 462 deletions(-) diff --git a/libavfilter/vf_deinterlace_qsv

[FFmpeg-devel] [PATCH v3 17/22] lavfi/vpp_qsv: check output format string against NULL pointer

2021-06-14 Thread Haihao Xiang
This is in preparation for re-using VPPContext but with a different option array for deinterlacing_qsv filter --- libavfilter/vf_vpp_qsv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/vf_vpp_qsv.c b/libavfilter/vf_vpp_qsv.c index cdf1f61b0f..45ac761d06 100644 ---

[FFmpeg-devel] [PATCH v3 11/22] lavfi/vpp_qsv: factor common QSV filter definition

2021-06-14 Thread Haihao Xiang
--- libavfilter/vf_vpp_qsv.c | 195 +-- 1 file changed, 86 insertions(+), 109 deletions(-) diff --git a/libavfilter/vf_vpp_qsv.c b/libavfilter/vf_vpp_qsv.c index dd3afb5e10..03785e9398 100644 --- a/libavfilter/vf_vpp_qsv.c +++ b/libavfilter/vf_vpp_qsv.c @@ -105

[FFmpeg-devel] [PATCH v3 09/22] lavfi/vpp_qsv: add vpp_preinit callback

2021-06-14 Thread Haihao Xiang
Set the expected default value for options in this callback, hence we have the right values even if these options are not included in the option arrray. This is in preparation for re-using VPPContext but with a different option array for other QSV filters --- libavfilter/vf_vpp_qsv.c | 14

[FFmpeg-devel] [PATCH v3 10/22] lavfi/scale_qsv: re-use VPPContext for scale_qsv filter

2021-06-14 Thread Haihao Xiang
All features are implemented in vpp_qsv filter, scale_qsv can be taken as a special case of vpp_qsv filter now, we re-use VPPContext with a different option arrary and pixel formats --- libavfilter/Makefile | 2 +- libavfilter/vf_scale_qsv.c | 334 - lib

[FFmpeg-devel] [PATCH v3 16/22] lavfi/qsvvpp: set PTS for output frame

2021-06-14 Thread Haihao Xiang
When the SDK returns MFX_ERR_MORE_SURFACE, the PTS is not set for the output frame. We assign a PTS calculated from the input frame to the output frame. After applying this patch, we may avoid the error below: [null @ 0x56395cab4ae0] Application provided invalid, non monotonically increasing dts t

[FFmpeg-devel] [PATCH v3 15/22] lavfi/qsvvpp: avoid overriding the returned value

2021-06-14 Thread Haihao Xiang
Currently the returned value from MFXVideoVPP_RunFrameVPPAsync() is overridden, so the check of 'ret == MFX_ERR_MORE_SURFACE' is always false when MFX_ERR_MORE_SURFACE is returned from MFXVideoVPP_RunFrameVPPAsync() --- libavfilter/qsvvpp.c | 11 --- 1 file changed, 8 insertions(+), 3 dele

[FFmpeg-devel] [PATCH v3 08/22] lavfi/vpp_qsv: pass scaling mode to the SDK

2021-06-14 Thread Haihao Xiang
After this patch, the scaling mode will be passed to the SDK when the scaling mode is not equal to the default mode. This is in preparation for re-using VPPContext for scale_qsv filter --- libavfilter/vf_vpp_qsv.c | 19 ++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --gi

[FFmpeg-devel] [PATCH v3 04/22] lavfi/vpp_qsv: add "a", "dar" and "sar" variables

2021-06-14 Thread Haihao Xiang
Also fix the coding style for VAR index. This is in preparation for re-using VPPContext for scale_qsv filter --- libavfilter/vf_vpp_qsv.c | 29 +++-- 1 file changed, 19 insertions(+), 10 deletions(-) diff --git a/libavfilter/vf_vpp_qsv.c b/libavfilter/vf_vpp_qsv.c index 72

[FFmpeg-devel] [PATCH v3 07/22] lavfi/vpp_qsv: factorize extra MFX configuration

2021-06-14 Thread Haihao Xiang
This is in preparation for re-using VPPContext for scale_qsv filter --- libavfilter/vf_vpp_qsv.c | 78 +--- 1 file changed, 32 insertions(+), 46 deletions(-) diff --git a/libavfilter/vf_vpp_qsv.c b/libavfilter/vf_vpp_qsv.c index 7afbb3c983..c9a7b0ceb9 100644 --

[FFmpeg-devel] [PATCH v3 06/22] lavfi/vpp_qsv: allow special values for the output dimensions

2021-06-14 Thread Haihao Xiang
Special values are: 0 = original width/height -1 = keep original aspect This is in preparation for re-using VPPContext for scale_qsv filter --- libavfilter/vf_vpp_qsv.c | 47 ++-- 1 file changed, 40 insertions(+), 7 deletions(-) diff --git a/libavfilter/vf_vpp

[FFmpeg-devel] [PATCH v3 05/22] lavfi/vpp_qsv: handle NULL pointer when evaluating an expression

2021-06-14 Thread Haihao Xiang
This is in preparation for re-using VPPContext but with a different option array for scale_qsv filter --- libavfilter/vf_vpp_qsv.c | 36 1 file changed, 20 insertions(+), 16 deletions(-) diff --git a/libavfilter/vf_vpp_qsv.c b/libavfilter/vf_vpp_qsv.c index e7

[FFmpeg-devel] [PATCH v3 03/22] lavfi/scale_qsv: don't need variables for constants in FFmpeg

2021-06-14 Thread Haihao Xiang
PI, PHI and E are defined in FFmpeg --- libavfilter/vf_scale_qsv.c | 9 - 1 file changed, 9 deletions(-) diff --git a/libavfilter/vf_scale_qsv.c b/libavfilter/vf_scale_qsv.c index 77a782aa58..f8e937e40e 100644 --- a/libavfilter/vf_scale_qsv.c +++ b/libavfilter/vf_scale_qsv.c @@ -44,9 +44,

[FFmpeg-devel] [PATCH v3 02/22] lavfi/scale_qsv: simplify scale_qsv filter

2021-06-14 Thread Haihao Xiang
Use QSVVPPContext as a base context of QSVScaleContext, hence we may re-use functions defined for QSVVPPContext to manage MFX session for scale_qsv filter too. Because system memory is taken into account in QSVVVPPContext, we may add support for non-QSV pixel formats in the future --- libavfilter/

[FFmpeg-devel] [PATCH v3 01/22] lavfi/qsv: use QSVVPPContext as base context in vf_vpp_qsv/vf_overlay_qsv

2021-06-14 Thread Haihao Xiang
The same members between QSVVPPContext and VPPContext are removed from VPPContext, and async_depth is moved from QSVVPPParam to QSVVPPContext so that all QSV filters using QSVVPPContext may support async depth. In addition we may use QSVVPPContext as base context in other QSV filters in the future.

[FFmpeg-devel] [PATCH v3 00/22] clean-up QSV filters

2021-06-14 Thread Haihao Xiang
Haihao Xiang (22): lavfi/qsv: use QSVVPPContext as base context in vf_vpp_qsv/vf_overlay_qsv lavfi/scale_qsv: simplify scale_qsv filter lavfi/scale_qsv: don't need variables for constants in FFmpeg lavfi/vpp_qsv: add "a", "dar" and "sar" variables lavfi/vpp_qsv: handle NULL pointer wh

Re: [FFmpeg-devel] [PATCH] lavfi/drawtext: Add localtime_ms for millisecond precision

2021-06-14 Thread Steven Liu
Thilo Borgmann 于2021年6月15日周二 上午3:14写道: > > Am 08.06.21 um 18:42 schrieb Thilo Borgmann: > > Hi, > > > > add %{localtime_ms} function to the drawtext filter. Same as %{localtime} > > but with additional millisecond part. > > Ping for a volunteer to actually have a look at the patch for review. lgt

Re: [FFmpeg-devel] [PATCH] avcodec: Pass the HDR10+ metadata to the packet side data in VP9 encoder

2021-06-14 Thread Andreas Rheinhardt
Mohammad Izadi: > On Thu, Jun 10, 2021 at 4:05 PM Andreas Rheinhardt < > andreas.rheinha...@outlook.com> wrote: > >> Mohammad Izadi: >>> HDR10+ metadata is stored in the bit stream for HEVC. The story is >> different for VP9 and cannot store the metadata in the bit stream. HDR10+ >> should be pass

Re: [FFmpeg-devel] [PATCH] avcodec: Pass the HDR10+ metadata to the packet side data in VP9 encoder

2021-06-14 Thread Mohammad Izadi
On Thu, Jun 10, 2021 at 4:05 PM Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: > Mohammad Izadi: > > HDR10+ metadata is stored in the bit stream for HEVC. The story is > different for VP9 and cannot store the metadata in the bit stream. HDR10+ > should be passed to packet side data an

Re: [FFmpeg-devel] [PATCH] avcodec: Pass the HDR10+ metadata to the packet side data in VP9 encoder

2021-06-14 Thread Andreas Rheinhardt
Mohammad Izadi: > HDR10+ metadata is stored in the bit stream for HEVC. The story is different > for VP9 and cannot store the metadata in the bit stream. HDR10+ should be > passed to packet side data an stored in the container (mkv) for VP9. > > This CL is taking HDR10+ from AVFrame side data in

Re: [FFmpeg-devel] [PATCH] avformat/matroskaenc: Allow changing the time stamp precision via option

2021-06-14 Thread Andreas Rheinhardt
Thierry Foucu: > On Mon, Jun 14, 2021 at 12:09 PM Andreas Rheinhardt < > andreas.rheinha...@outlook.com> wrote: > >> Thierry Foucu: >>> On Fri, Jun 4, 2021 at 10:18 PM Andreas Rheinhardt < >>> andreas.rheinha...@outlook.com> wrote: >>> Michael Fabian 'Xaymar' Dirks: > On 2021-05-24 22:15,

Re: [FFmpeg-devel] [PATCH] avformat/matroskaenc: Allow changing the time stamp precision via option

2021-06-14 Thread Thierry Foucu
On Mon, Jun 14, 2021 at 12:09 PM Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: > Thierry Foucu: > > On Fri, Jun 4, 2021 at 10:18 PM Andreas Rheinhardt < > > andreas.rheinha...@outlook.com> wrote: > > > >> Michael Fabian 'Xaymar' Dirks: > >>> On 2021-05-24 22:15, Andreas Rheinhardt wr

[FFmpeg-devel] [PATCH] avcodec: Pass the HDR10+ metadata to the packet side data in VP9 encoder

2021-06-14 Thread Mohammad Izadi
HDR10+ metadata is stored in the bit stream for HEVC. The story is different for VP9 and cannot store the metadata in the bit stream. HDR10+ should be passed to packet side data an stored in the container (mkv) for VP9. This CL is taking HDR10+ from AVFrame side data in libvpxenc and is passing

[FFmpeg-devel] [PATCH 17/17] avcodec/libavcodec.v: Tighten export whitelist

2021-06-14 Thread Andreas Rheinhardt
Currently every symbol (with external linkage) that starts with "av" is exported. Yet libaom-av1 has lots of functions that are not meant to be exported and start with "av1_" (I counted 1236); and libvpx has average_split_mvs. These functions are exported if one links these libraries statically int

[FFmpeg-devel] [PATCH 16/17] Remove/replace some unnecessary avcodec.h inclusions

2021-06-14 Thread Andreas Rheinhardt
Also remove other unnecessary headers and include headers directly while at it. Signed-off-by: Andreas Rheinhardt --- libavcodec/ac3.c | 1 - libavcodec/ac3.h | 5 +++-- libavcodec/ac3dsp.c | 9 - libavcodec/ac3enc.h

[FFmpeg-devel] [PATCH 15/17] avcodec/g729postfilter.h: Include acelp_pitch_delay.h

2021-06-14 Thread Andreas Rheinhardt
Needed for PITCH_DELAY_MAX. Signed-off-by: Andreas Rheinhardt --- fate-checkheaders doesn't catch this, because it doesn't use the RES_PREV_DATA_SIZE macro at all. libavcodec/g729postfilter.c | 1 - libavcodec/g729postfilter.h | 1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/

[FFmpeg-devel] [PATCH 14/17] avcodec/dsd_tablegen: Merge header into dsd.c

2021-06-14 Thread Andreas Rheinhardt
Since b492fbcc6e87094804fdf71308dc500976c6b165, the DSD tables are always initialized at runtime, so merge the dsd_tablegen.h header into dsd.c. Signed-off-by: Andreas Rheinhardt --- libavcodec/dsd.c | 44 ++- libavcodec/dsd_tablegen.h | 75 --

[FFmpeg-devel] [PATCH 11/17] avcodec: Remove some unnecessary mpegvideo.h inclusions

2021-06-14 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/h263data.c | 2 +- libavcodec/h264_slice.c | 2 +- libavcodec/snowdec.c| 1 - 3 files changed, 2 insertions(+), 3 deletions(-) diff --git a/libavcodec/h263data.c b/libavcodec/h263data.c index 20d0436fda..c520df3574 100644 --- a/libavcodec/h2

[FFmpeg-devel] [PATCH 13/17] avfilter/internal: Mark ff_filter_get_nb_threads() as av_pure

2021-06-14 Thread Andreas Rheinhardt
It does not modify anything; it only returns a value, so it fulfills the requirements for av_pure. The deeper rationale behind this change is that this function is called quite often inside arguments to FFMIN which may lead to two calls to it; declaring this function as av_pure allows the compiler

[FFmpeg-devel] [PATCH 10/17] Remove unnecessary avassert.h inclusions

2021-06-14 Thread Andreas Rheinhardt
From: Andreas Rheinhardt Signed-off-by: Andreas Rheinhardt --- fftools/ffplay.c | 3 --- libavcodec/ass.c | 1 - libavcodec/cfhd.h | 2 -- libavcodec/cfhddsp.c

[FFmpeg-devel] [PATCH 12/17] Avoid calling functions repeatedly via FFMIN

2021-06-14 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/pngdec.c | 4 +++- libavformat/afc.c| 4 ++-- libavformat/avidec.c | 3 ++- 3 files changed, 7 insertions(+), 4 deletions(-) diff --git a/libavcodec/pngdec.c b/libavcodec/pngdec.c index 16c4c3a283..3c7907 100644 --- a/libavcodec/pngdec.c

[FFmpeg-devel] [PATCH 09/17] Remove unnecessary mem.h inclusions

2021-06-14 Thread Andreas Rheinhardt
From: Andreas Rheinhardt Signed-off-by: Andreas Rheinhardt --- fftools/ffmpeg_qsv.c| 1 - libavcodec/aactab.c | 1 - libavcodec/arbc.c | 1 - libavcodec/argo.c | 1 - libavcodec/dcadsp.c

[FFmpeg-devel] [PATCH 08/17] Remove obsolete version.h inclusions

2021-06-14 Thread Andreas Rheinhardt
These have mostly been added because of FF_API_*; yet when these were removed, removing the header has been forgotten. Signed-off-by: Andreas Rheinhardt --- Some of these leftovers are from the last bump. Sorry. libavcodec/blockdsp.c | 1 - libavcodec/blockdsp.h | 1 - libavcode

[FFmpeg-devel] [PATCH 07/17] avutil/internal, swresample/audioconvert: Remove cpu.h inclusions

2021-06-14 Thread Andreas Rheinhardt
These inclusions are not necessary, as cpu.h is already included wherever it is needed (via direct inclusion or via the arch-specific headers). Signed-off-by: Andreas Rheinhardt --- I did my best to make sure this is correct on all arches; but testing is always welcome. libavutil/internal.h

[FFmpeg-devel] [PATCH 06/17] avcodec/lossless_videodsp: Improve included headers

2021-06-14 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/lossless_videodsp.c | 3 ++- libavcodec/lossless_videodsp.h | 3 --- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/libavcodec/lossless_videodsp.c b/libavcodec/lossless_videodsp.c index cff94c234d..fa0869eef9 100644 --- a/libavcodec

[FFmpeg-devel] [PATCH 05/17] avcodec/avcodec: Don't include cpu.h

2021-06-14 Thread Andreas Rheinhardt
It is not used here at all; instead, add it where it is used without including it or any of the arch-specific CPU headers. Signed-off-by: Andreas Rheinhardt --- libavcodec/avcodec.h | 1 - libavcodec/frame_thread_encoder.c | 1 + libavcodec/libaomdec.c | 1

[FFmpeg-devel] [PATCH 04/17] avcodec/avcodec: Don't include hwcontext.h

2021-06-14 Thread Andreas Rheinhardt
It is no longer used directly; but it is still indirectly included via codec.h. Signed-off-by: Andreas Rheinhardt --- libavcodec/avcodec.h | 1 - 1 file changed, 1 deletion(-) diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h index 6873e12279..5457f47bd0 100644 --- a/libavcodec/avcodec.h

[FFmpeg-devel] [PATCH 03/17] avcodec/avcodec: Don't include errno.h

2021-06-14 Thread Andreas Rheinhardt
This inclusion has been added before libavutil/error.h was split off from avcodec.h (in 60c144f700e2e362047b00704abcb694d49e549c). Signed-off-by: Andreas Rheinhardt --- Still included implicitly (even via multiple paths). libavcodec/avcodec.h | 1 - 1 file changed, 1 deletion(-) diff --git a/l

[FFmpeg-devel] [PATCH 02/17] avcodec/avcodec: Stop including channel_layout.h in avcodec.h

2021-06-14 Thread Andreas Rheinhardt
Also include channel_layout.h directly wherever used. Signed-off-by: Andreas Rheinhardt --- doc/examples/filtering_audio.c | 1 + doc/examples/transcode_aac.c | 1 + doc/examples/transcoding.c | 1 + fftools/cmdutils.c | 1 + fftools/ffplay.c | 1 + ffto

[FFmpeg-devel] [PATCH 01/17] avcodec/avcodec: Stop including bsf.h in avcodec.h

2021-06-14 Thread Andreas Rheinhardt
Also include bsf.h directly wherever it is used. Signed-off-by: Andreas Rheinhardt --- Following the example of e67e02d15672a87da1b0566e197a1e19dc7e1e33 I have neither added an APIchanges entry nor a version bump for anything in this set. fftools/cmdutils.c | 1 + fftools/ffmpeg.h

Re: [FFmpeg-devel] [PATCH] lavfi/drawtext: Add localtime_ms for millisecond precision

2021-06-14 Thread Thilo Borgmann
Am 08.06.21 um 18:42 schrieb Thilo Borgmann: > Hi, > > add %{localtime_ms} function to the drawtext filter. Same as %{localtime} but > with additional millisecond part. Ping for a volunteer to actually have a look at the patch for review. Thanks, Thilo _

Re: [FFmpeg-devel] [PATCH] avformat/matroskaenc: Allow changing the time stamp precision via option

2021-06-14 Thread Andreas Rheinhardt
Thierry Foucu: > On Fri, Jun 4, 2021 at 10:18 PM Andreas Rheinhardt < > andreas.rheinha...@outlook.com> wrote: > >> Michael Fabian 'Xaymar' Dirks: >>> On 2021-05-24 22:15, Andreas Rheinhardt wrote: michael.di...@xaymar.com: > From: Michael Fabian 'Xaymar' Dirks > > Adds "timestam

Re: [FFmpeg-devel] [PATCH] avformat/matroskaenc: Allow changing the time stamp precision via option

2021-06-14 Thread Thierry Foucu
On Fri, Jun 4, 2021 at 10:18 PM Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: > Michael Fabian 'Xaymar' Dirks: > > On 2021-05-24 22:15, Andreas Rheinhardt wrote: > >> michael.di...@xaymar.com: > >>> From: Michael Fabian 'Xaymar' Dirks > >>> > >>> Adds "timestamp_precision" to the av

Re: [FFmpeg-devel] [PATCH v2] avcodec/ccaption_dec: Make real-time latency configurable

2021-06-14 Thread Pavel Koshevoy
On Mon, Jun 14, 2021 at 10:04 AM Paul B Mahol wrote: > On Sun, Jun 13, 2021 at 11:50 PM Pavel Koshevoy > wrote: > > > On Sat, Jun 5, 2021 at 11:40 AM Pavel Koshevoy > > wrote: > > > > > Un-hardcode the 200ms minimum latency between emitting subtitle events > > > so that those that wish to recei

[FFmpeg-devel] [PATCH] lavfi/dnn_backend_openvino.c: Fix Memory Leak for RequestItem

2021-06-14 Thread Shubhanshu Saxena
Fix memory leak for RequestItem upon error while pushing to the request_queue in the completion callback. Signed-off-by: Shubhanshu Saxena --- libavfilter/dnn/dnn_backend_openvino.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavfilter/dnn/dnn_backend_openvino.c b/libavfilter/dnn/dn

Re: [FFmpeg-devel] [PATCH 1/2] lavc/libaomenc: Show encoder config as a warning in case of failed initialization

2021-06-14 Thread Thilo Borgmann
Am 14.06.21 um 20:10 schrieb Thilo Borgmann: > Am 14.06.21 um 19:39 schrieb James Zern: >> On Sat, Jun 12, 2021 at 12:10 PM Thilo Borgmann >> wrote: >>> >>> Hi, >>> >>> if init fails, it's likely originating from the library's config. This and >>> 2/2 are for easier debugging in that case instea

Re: [FFmpeg-devel] [PATCH 1/2] lavc/libaomenc: Show encoder config as a warning in case of failed initialization

2021-06-14 Thread Thilo Borgmann
Am 14.06.21 um 19:39 schrieb James Zern: > On Sat, Jun 12, 2021 at 12:10 PM Thilo Borgmann > wrote: >> >> Hi, >> >> if init fails, it's likely originating from the library's config. This and >> 2/2 are for easier debugging in that case instead of having to run again >> with loglevel DEBUG. >> >

Re: [FFmpeg-devel] [PATCH v2 17/33] avdevice/dshow: discover source color range/space/etc

2021-06-14 Thread James Almer
On 6/14/2021 1:56 PM, Michael Niedermayer wrote: On Fri, Jun 11, 2021 at 10:30:48PM +0200, Diederick Niehorster wrote: Enabled discovering a DirectShow device's color range, space, primaries, transfer characteristics and chroma location, if the device exposes that information. Sets them in the s

Re: [FFmpeg-devel] [PATCH 2/2] lavc/libvpxenc: Show encoder config as a warning in case

2021-06-14 Thread James Zern
On Sat, Jun 12, 2021 at 12:12 PM Thilo Borgmann wrote: > > $subject > > --- > libavcodec/libvpxenc.c | 10 ++ > 1 file changed, 6 insertions(+), 4 deletions(-) lgtm. Same comment for the else as for libaomenc.c ___ ffmpeg-devel mailing list ff

Re: [FFmpeg-devel] [PATCH 1/2] lavc/libaomenc: Show encoder config as a warning in case of failed initialization

2021-06-14 Thread James Zern
On Sat, Jun 12, 2021 at 12:10 PM Thilo Borgmann wrote: > > Hi, > > if init fails, it's likely originating from the library's config. This and > 2/2 are for easier debugging in that case instead of having to run again with > loglevel DEBUG. > > --- > libavcodec/libaomenc.c | 10 ++ > 1

Re: [FFmpeg-devel] [PATCH v2 17/33] avdevice/dshow: discover source color range/space/etc

2021-06-14 Thread Michael Niedermayer
On Fri, Jun 11, 2021 at 10:30:48PM +0200, Diederick Niehorster wrote: > Enabled discovering a DirectShow device's color range, space, primaries, > transfer characteristics and chroma location, if the device exposes that > information. Sets them in the stream's codecpars. > > Signed-off-by: Diederi

Re: [FFmpeg-devel] [PATCH] dashenc: Write out DASH manifest immediately in streaming mode

2021-06-14 Thread Jeyapal, Karthick
On 6/11/21, 9:31 PM, "Kevin LaFlamme" wrote: >Does my last explanation make sense or if not could you point me to >where this reasoning is incorrect? Your reasoning is perfectly fine. Since I haven't heard any objections to your reply, I have pushed this patch. Thanks. > >Kevin LaFlamme >Dire

Re: [FFmpeg-devel] [PATCH v2] avcodec/ccaption_dec: Make real-time latency configurable

2021-06-14 Thread Paul B Mahol
On Sun, Jun 13, 2021 at 11:50 PM Pavel Koshevoy wrote: > On Sat, Jun 5, 2021 at 11:40 AM Pavel Koshevoy > wrote: > > > Un-hardcode the 200ms minimum latency between emitting subtitle events > > so that those that wish to receive a subtitle event for every screen > > change could do so. > > > > T

Re: [FFmpeg-devel] [PATCH] avformat/dashenc: use av_match_ext()

2021-06-14 Thread Jeyapal, Karthick
From: Limin Wang > >Signed-off-by: Limin Wang >--- >libavformat/dashenc.c | 16 +++- >1 file changed, 3 insertions(+), 13 deletions(-) Pushed. Thanks, Karthick > >diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c >index 8a626c1..b7622bc 100644 >--- a/libavformat/dashenc.c >++

Re: [FFmpeg-devel] [PATCH] lavc/videotoolboxenc.c: Fix preprocessor macro for OSX, 10.10.5 and probably older versions

2021-06-14 Thread Thilo Borgmann
Am 14.06.21 um 15:14 schrieb Marvin Scholz (ePirat): Am 14.06.2021 um 15:03 schrieb Thilo Borgmann : Hi, TARGET_OS_OSX exists since OSX 10.10.6. TARGET_OS_MAC is there on both sides of 10.10.6. Fixes compilation on Yosemite. Hi Thilo, TARGET_OS_MAC is 1 when building for iOS as well, you

Re: [FFmpeg-devel] [PATCH] lavc/videotoolboxenc.c: Fix preprocessor macro for OSX, 10.10.5 and probably older versions

2021-06-14 Thread Marvin Scholz (ePirat)
> Am 14.06.2021 um 15:03 schrieb Thilo Borgmann : > > Hi, > > TARGET_OS_OSX exists since OSX 10.10.6. TARGET_OS_MAC is there on both sides > of 10.10.6. Fixes compilation on Yosemite. > Hi Thilo, TARGET_OS_MAC is 1 when building for iOS as well, you need !TARGET_OS_IPHONE instead. > -Thil

[FFmpeg-devel] [PATCH] lavc/videotoolboxenc.c: Fix preprocessor macro for OSX, 10.10.5 and probably older versions

2021-06-14 Thread Thilo Borgmann
Hi, TARGET_OS_OSX exists since OSX 10.10.6. TARGET_OS_MAC is there on both sides of 10.10.6. Fixes compilation on Yosemite. -Thilo From a6c690c8f1d311995c6511fcd22982ff1f4c5949 Mon Sep 17 00:00:00 2001 From: Thilo Borgmann Date: Mon, 14 Jun 2021 14:51:13 +0200 Subject: [PATCH] lavc/videotoolb

[FFmpeg-devel] [PATCH] Avoid using the --preprocessor argument to windres

2021-06-14 Thread Martin Storsjö
Instead use --preprocessor-arg; in binutils 2.36, the --preprocessor flag was changed so that it no longer accepts a string containing multiple arguments, but the whole --preprocessor argument is treated as the path to the preprocessor executable (where the path can contain spaces). It's currently

Re: [FFmpeg-devel] [PATCH 1/2] libavutil/cpu: Adds av_cpu_has_fast_gather to detect cpus with avx fast gather instruction

2021-06-14 Thread James Almer
On 6/14/2021 8:53 AM, Ronald S. Bultje wrote: Hi Alan, On Mon, Jun 14, 2021 at 7:20 AM Alan Kelly < alankelly-at-google@ffmpeg.org> wrote: Broadwell and later have fast gather instructions. --- This is so that the avx2 version of ff_hscale8to15X which uses gather instructions is only s

Re: [FFmpeg-devel] [PATCH] ffbuild/common.mak: explicitly pass windres preprocessor args

2021-06-14 Thread Martin Storsjö
On Tue, 8 Jun 2021, Kyle Schwarz wrote: Binutils 2.36 no longer supports bundling args with the preprocessor option. --- ffbuild/common.mak | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ffbuild/common.mak b/ffbuild/common.mak index 32f5b997b5..9fbbf89130 100644 --- a/ffbuild

Re: [FFmpeg-devel] [PATCH 1/2] libavutil/cpu: Adds av_cpu_has_fast_gather to detect cpus with avx fast gather instruction

2021-06-14 Thread Ronald S. Bultje
Hi Alan, On Mon, Jun 14, 2021 at 7:20 AM Alan Kelly < alankelly-at-google@ffmpeg.org> wrote: > Broadwell and later have fast gather instructions. > --- > This is so that the avx2 version of ff_hscale8to15X which uses gather > instructions is only selected on machines where it will actually

Re: [FFmpeg-devel] [PATCH 1/2] libavutil/cpu: Adds av_cpu_has_fast_gather to detect cpus with avx fast gather instruction

2021-06-14 Thread Andreas Rheinhardt
Alan Kelly: > Broadwell and later have fast gather instructions. > --- > This is so that the avx2 version of ff_hscale8to15X which uses gather > instructions is only selected on machines where it will actually be > faster. > libavutil/cpu.c | 6 ++ > libavutil/cpu.h | 6

Re: [FFmpeg-devel] [PATCH] ffmpeg: add -fpsmin to clamp output framerate

2021-06-14 Thread Matthias Neugebauer
Anything I can do to not land in spam? On another Google groups mailing list I (and many others including the admin accounts) had the same issue a couple of times. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/

[FFmpeg-devel] [PATCH 2/2] libswscale: Adds ff_hscale8to15_4_avx2 and ff_hscale8to15_X4_avx2 for all filter sizes.

2021-06-14 Thread Alan Kelly
These functions replace all ff_hscale8to15_*_ssse3 when avx2 is available. --- libswscale/swscale_internal.h | 2 + libswscale/utils.c| 37 +++ libswscale/x86/Makefile | 1 + libswscale/x86/scale_avx2.asm | 112 ++ libswscale/x86/swsca

[FFmpeg-devel] [PATCH 1/2] libavutil/cpu: Adds av_cpu_has_fast_gather to detect cpus with avx fast gather instruction

2021-06-14 Thread Alan Kelly
Broadwell and later have fast gather instructions. --- This is so that the avx2 version of ff_hscale8to15X which uses gather instructions is only selected on machines where it will actually be faster. libavutil/cpu.c | 6 ++ libavutil/cpu.h | 6 ++ libavutil/cpu_inte

Re: [FFmpeg-devel] [PATCH] ffmpeg: add -fpsmin to clamp output framerate

2021-06-14 Thread Henrik Gramner
On Mon, Jun 14, 2021 at 9:22 AM Matthias Neugebauer wrote: > Anything I can do to not land in spam? On another Google groups > mailing list I (and many others including the admin accounts) had > the same issue a couple of times. This is caused by sending emails from a domain with a DMARC reject o

Re: [FFmpeg-devel] [PATCH] avfilter/vf_guided: support single input

2021-06-14 Thread Steven Liu
> 在 2021年6月14日,10:08,Xuewei Meng <928826...@qq.com> 写道: > > From: Xuewei Meng > > Support single input for guided filter by adding guidance mode. > If the guidance mode is off, single input is required. And > edge-preserving smoothing is conducted. If the mode is on, two > inputs are needed. T

Re: [FFmpeg-devel] [PATCH] ffmpeg: add -fpsmin to clamp output framerate

2021-06-14 Thread Gyan Doshi
On 2021-06-14 12:52, Matthias Neugebauer wrote: Anything I can do to not land in spam? On another Google groups mailing list I (and many others including the admin accounts) had the same issue a couple of times. Quickest workaround: send from a non-Gmail account. Regards, Gyan P.S. Is Goog