Re: [FFmpeg-devel] [PATCH] Pass the HDR10+ metadata to the packet side data in VP9 encoder

2021-05-25 Thread Moritz Barsnick
On Tue, May 25, 2021 at 18:53:11 -0700, Mohammad Izadi wrote: > Subject: Pass the HDR10+ metadata to the packet side data in VP9 encoder You should prefix this with "avcodec: ". > API changes, most recent first: > +2021-05-25 - xx - lavc 58.137.101 - packet.h > + Add AV_PKT_DATA_DYNAMI

Re: [FFmpeg-devel] [PATCH] avcodec/ccaption_dec: Make real-time latency configurable

2021-05-25 Thread Moritz Barsnick
On Tue, May 25, 2021 at 20:16:29 -0600, Pavel Koshevoy wrote: > -sub->pts > ctx->last_real_time + av_rescale_q(200, ms_tb, > AV_TIME_BASE_Q)) { > +sub->pts >= ctx->last_real_time + > av_rescale_q(ctx->real_time_latency_msec, ms_tb, AV_TIME_BASE_Q)) { [...] > +{ "real_time_late

Re: [FFmpeg-devel] [PATCH]avfilter: add Intel IPP library based x86 optimized video scaling filter

2021-05-25 Thread Gyan Doshi
On 2021-05-25 20:17, Hendrik Leppkes wrote: On Tue, May 25, 2021 at 4:27 PM Gyan Doshi wrote: On 2021-05-25 18:40, Nicolas George wrote: Zhislina, Victoria (12021-05-25): While you are right that IPP is not GPL based and is closed source currently (but free for any commercial usage) and t

[FFmpeg-devel] [PATCH] avcodec/ccaption_dec: Make real-time latency configurable

2021-05-25 Thread Pavel Koshevoy
Un-hardcode the 200ms minimum latency between emitting subtitle events so that those that wish to receive a subtitle event for every screen change could do so. --- libavcodec/ccaption_dec.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavcodec/ccaption_dec.c b/libavcode

Re: [FFmpeg-devel] [PATCH] Pass the HDR10+ metadata to the packet side data in VP9 encoder

2021-05-25 Thread Mohammad Izadi
Answered inline: On Tue, May 25, 2021 at 8:15 AM James Almer wrote: > On 4/26/2021 10:54 PM, Mohammad Izadi wrote: > > HDR10+ metadata is stored in the bit stream for HEVC. The story is > different for VP9 and cannot store the metadata in the bit stream. HDR10+ > should be passed to packet side

[FFmpeg-devel] [PATCH] Pass the HDR10+ metadata to the packet side data in VP9 encoder

2021-05-25 Thread Mohammad Izadi
HDR10+ metadata is stored in the bit stream for HEVC. The story is different for VP9 and cannot store the metadata in the bit stream. HDR10+ should be passed to packet side data an stored in the container (mkv) for VP9. This CL is taking HDR10+ from AVFrame side data in libvpxenc and is passing

[FFmpeg-devel] [PATCH 2/2] fftools/ffprobe: 240M matrix is not the same as BT.601

2021-05-25 Thread Valerii Zapodovnikov
--- fftools/ffplay.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/fftools/ffplay.c b/fftools/ffplay.c index 0be1d90bf9..53bd9362fa 100644 --- a/fftools/ffplay.c +++ b/fftools/ffplay.c @@ -963,12 +963,12 @@ static void set_sdl_yuv_conversion_mode(AVFrame *frame) if

[FFmpeg-devel] [PATCH 1/2] pixfmt: fixed wrong fix of comment

2021-05-25 Thread Valerii Zapodovnikov
This mostly reverts 785bfb1d7bb8de567c3aac1d9cc369b55ac9fb7b. But I also added some clarifications so that nobody mixes primaries with matrix again. SMPTE 240 and 170 primaires are the same, while matrix coeff. are different, because 240 is derived from 170's new primaries and white point while 170

Re: [FFmpeg-devel] [PATCH 3/3] libavfilter: vf_drawtext filter support draw text with detection bounding boxes in side_data

2021-05-25 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel On Behalf Of Guo, > Yejun > Sent: 2021年5月25日 9:08 > To: FFmpeg development discussions and patches > > Subject: Re: [FFmpeg-devel] [PATCH 3/3] libavfilter: vf_drawtext filter > support draw text with detection bounding boxes in side_data > > >

[FFmpeg-devel] [PATCH] avfilter/yadif: Fix time base for large denominators

2021-05-25 Thread Tom Boshoven
This fixes an issue where the yadif filter could cause the timebase denominator to overflow. Signed-off-by: Tom Boshoven --- libavfilter/vf_yadif.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libavfilter/vf_yadif.c b/libavfilter/vf_yadif.c index a6942a2aa2..91cc79ecc3

[FFmpeg-devel] [PATCH] avcodec/exr: More strictly check dc_count

2021-05-25 Thread Michael Niedermayer
Fixes: out of array access Fixes: exr/deneme Found-by: Burak Çarıkçı Signed-off-by: Michael Niedermayer --- libavcodec/exr.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/exr.c b/libavcodec/exr.c index 9377a89169..4648ed7d62 100644 --- a/libavcodec/exr.c +++

Re: [FFmpeg-devel] [PATCH] avfilter/yadif: Fix time base for large denominators

2021-05-25 Thread Tom Boshoven
On Mon, May 24, 2021 at 10:39 PM Andriy Gelman wrote: > > Some fate tests fail on patchwork: > https://patchwork.ffmpeg.org/project/ffmpeg/patch/20210524155206.47644-1-...@jwplayer.com/ Thanks! I did not realize one could make this many mistakes in a simple one-line patch. Apologies for the impr

Re: [FFmpeg-devel] [PATCH 2/2] libavcodec/dpxenc: change transfer/primaries to BT.709

2021-05-25 Thread Валерий Заподовников
So, apparently two such patches were done before but not pushed (even written by Paul, see patch 22747, it will supersede mine). I think at the very least you must rename "linear colorimetric" BS, because there is no such thing in the standard and it is not even defined for 2. Also one little fact:

Re: [FFmpeg-devel] [PATCH]avfilter: add Intel IPP library based x86 optimized video scaling filter

2021-05-25 Thread Hendrik Leppkes
On Tue, May 25, 2021 at 4:27 PM Gyan Doshi wrote: > > > > On 2021-05-25 18:40, Nicolas George wrote: > > Zhislina, Victoria (12021-05-25): > >> While you are right that IPP is not GPL based and is closed source > >> currently (but free for any commercial usage) and therefore does > >> require --en

Re: [FFmpeg-devel] [PATCH] Pass the HDR10+ metadata to the packet side data in VP9 encoder

2021-05-25 Thread James Almer
On 4/26/2021 10:54 PM, Mohammad Izadi wrote: HDR10+ metadata is stored in the bit stream for HEVC. The story is different for VP9 and cannot store the metadata in the bit stream. HDR10+ should be passed to packet side data an stored in the container (mkv) for VP9. This CL is taking HDR10+ from

Re: [FFmpeg-devel] [PATCH]avfilter: add Intel IPP library based x86 optimized video scaling filter

2021-05-25 Thread Gyan Doshi
On 2021-05-25 18:40, Nicolas George wrote: Zhislina, Victoria (12021-05-25): While you are right that IPP is not GPL based and is closed source currently (but free for any commercial usage) and therefore does require --enable-nonfree, I'm sorry to mention that you are not right about "doing t

[FFmpeg-devel] [PATCH] avformat/hls Implement support for using AVSEEK_FLAG_BACKWARD when seeking

2021-05-25 Thread Gustav Grusell
Before, seeking in hls streams would always seek to the next keyframe after the given timestamp. With this fix, if AVSEEK_FLAG_BACKWARD is set, seeking will be to the first keyframe of the segment containing the given timestamp. This fixes #7485. Signed-off-by: Gustav Grusell --- libavformat/h

Re: [FFmpeg-devel] [PATCH]avfilter: add Intel IPP library based x86 optimized video scaling filter

2021-05-25 Thread Nicolas George
Zhislina, Victoria (12021-05-25): > While you are right that IPP is not GPL based and is closed source > currently (but free for any commercial usage) and therefore does > require --enable-nonfree, > I'm sorry to mention that you are not right about "doing the same but > faster". If you read my co

Re: [FFmpeg-devel] [PATCH]avfilter: add Intel IPP library based x86 optimized video scaling filter

2021-05-25 Thread Zhislina, Victoria
While you are right that IPP is not GPL based and is closed source currently (but free for any commercial usage) and therefore does require --enable-nonfree, I'm sorry to mention that you are not right about "doing the same but faster". If you read my commit message you could see that it: Introdu

Re: [FFmpeg-devel] [PATCH] avformat/hls Implement support for using AVSEEK_FLAG_BACKWARD when seeking

2021-05-25 Thread Gustav Grusell
On Tue, May 25, 2021 at 4:24 AM Lingjiang Fang wrote: > > only format change, maybe better to revert if you don't mean to do so > :) > > Thanks, will fix. On Tue, May 25, 2021 at 10:30 AM 徐慧书 wrote: > On Sat, May 15, 2021 at 4:11 AM Gustav Grusell > wrote: > > > > > tb =

Re: [FFmpeg-devel] [PATCH v6] avcodec/nvenc: write out user data unregistered SEI

2021-05-25 Thread Brad Hards
On Tuesday, 25 May 2021 9:03:51 PM AEST Timo Rothenpieler wrote: > On 25/05/2021 12:11, Brad Hards wrote: > > Signed-off-by: Brad Hards > > --- > > > > libavcodec/nvenc.c | 73 +- > > libavcodec/nvenc.h | 2 ++ > > 2 files changed, 62 insertions(+)

[FFmpeg-devel] avcodec/nvenc: write out user data unregistered SEI

2021-05-25 Thread Brad Hards
MISB ST 0604 and ST 2101 require user data unregistered SEI messages (precision timestamps and sensor identifiers) to be included. That currently isn't supported. This series adds encoding for hevc_nvenc and h264_nvenc in accordance with ISO/IEC 14496-10:2020 Section D.1.7 and ISO/IEC 23008-2:2020

[FFmpeg-devel] [PATCH v7] avcodec/nvenc: write out user data unregistered SEI

2021-05-25 Thread Brad Hards
Signed-off-by: Brad Hards --- libavcodec/nvenc.c | 71 +- libavcodec/nvenc.h | 2 ++ 2 files changed, 60 insertions(+), 13 deletions(-) diff --git a/libavcodec/nvenc.c b/libavcodec/nvenc.c index 0dcd93a99c..8ca5cab4c8 100644 --- a/libavcodec/nvenc.c +

Re: [FFmpeg-devel] [PATCH] web/contact: Add libera.chat

2021-05-25 Thread Timo Rothenpieler
I'm in favour of switching over to Libera.chat. Freenodes business model is more than questionable, and some recent actions of the new staff are questionable at best. The old Freenode staff have switched to Libera in their entirety, so it seems only natural to follow along than to stay on a ne

Re: [FFmpeg-devel] [PATCH v6] avcodec/nvenc: write out user data unregistered SEI

2021-05-25 Thread Timo Rothenpieler
On 25/05/2021 12:11, Brad Hards wrote: Signed-off-by: Brad Hards --- libavcodec/nvenc.c | 73 +- libavcodec/nvenc.h | 2 ++ 2 files changed, 62 insertions(+), 13 deletions(-) diff --git a/libavcodec/nvenc.c b/libavcodec/nvenc.c index 0dcd93a99

Re: [FFmpeg-devel] [PATCH] Pass the HDR10+ metadata to the packet side data in VP9 encoder

2021-05-25 Thread Nicolas George
Валерий Заподовников (12021-05-25): > You know that on Android gmail viewer you can delete the citation of > previsous email by long pressing on 3 dots after email like I just did? > Please do it next time. Also is Youtube going to permit HDR10+ globally? Please keep a little context, though. Reg

Re: [FFmpeg-devel] [PATCH] Pass the HDR10+ metadata to the packet side data in VP9 encoder

2021-05-25 Thread Валерий Заподовников
You know that on Android gmail viewer you can delete the citation of previsous email by long pressing on 3 dots after email like I just did? Please do it next time. Also is Youtube going to permit HDR10+ globally? ___ ffmpeg-devel mailing list ffmpeg-deve

[FFmpeg-devel] [PATCH v6] avcodec/nvenc: write out user data unregistered SEI

2021-05-25 Thread Brad Hards
Signed-off-by: Brad Hards --- libavcodec/nvenc.c | 73 +- libavcodec/nvenc.h | 2 ++ 2 files changed, 62 insertions(+), 13 deletions(-) diff --git a/libavcodec/nvenc.c b/libavcodec/nvenc.c index 0dcd93a99c..9c2664a99e 100644 --- a/libavcodec/nvenc.c +

[FFmpeg-devel] Encode user data unregistered SEI (H.264/H.265)

2021-05-25 Thread Brad Hards
MISB ST 0604 and ST 2101 require user data unregistered SEI messages (precision timestamps and sensor identifiers) to be included. That currently isn't supported. This series adds encoding for libx264, libx265, hevc_nvenc and h264_nvenc in accordance with ISO/IEC 14496-10:2020 Section D.1.7 and IS

Re: [FFmpeg-devel] [PATCH 1/1] avformat/hlsenc: Fix bug on start_pts

2021-05-25 Thread Lingjiang Fang
On Sun, 16 May 2021 16:59:39 +0800 Hongcheng Zhong wrote: > From: spartazhc > > This patch fixes Bug #9237 > In some bitstream, pts of some video packet can be N/A, which will set > start_pts to AV_NOPTS_VALUE. Adding an if condition can fix it. > > Signed-off-by: spartazhc > --- > libavform

Re: [FFmpeg-devel] [PATCH] avformat/hls Implement support for using AVSEEK_FLAG_BACKWARD when seeking

2021-05-25 Thread 徐慧书
On Sat, May 15, 2021 at 4:11 AM Gustav Grusell wrote: > > Before, seeking in hls streams would always seek to the next keyframe after > the given timestamp. > With this fix, if AVSEEK_FLAG_BACKWARD is set, seeking will be to the first > keyframe of the > segment containing the given timestamp. T

[FFmpeg-devel] [PATCH] avformat/librist: fix logging setting

2021-05-25 Thread Zhao Zhili
The librist logging API is confusing. It looks like a per instance setting but saves a copy to global static variable quietly. So there is a potential use-after-free issue with log_cb_arg. librist took zero as invalid file descriptor at first. After the problem was fixed, now it will close the zer