Re: [FFmpeg-devel] [PATCH v3 1/2] avfilter/dnn/dnn_backend_tf: fix cross library usage

2021-05-07 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel On Behalf Of > lance.lmw...@gmail.com > Sent: 2021年5月8日 9:18 > To: ffmpeg-devel@ffmpeg.org > Cc: Limin Wang > Subject: [FFmpeg-devel] [PATCH v3 1/2] avfilter/dnn/dnn_backend_tf: fix > cross library usage > > From: Limin Wang > > duplicate ff_

[FFmpeg-devel] [PATCH v1] Add ignore_rtcp option in rtsp

2021-05-07 Thread sunml
From: Minlei Sun Regarding ignore_rtcp flag, it is turned off by default. When some devices (such as hikvision iSecure Center Platform v1.3.xxx) rtsp stream contains rtcp data packets (may be non-standard), there will be a freeze when the output is rtmp stream. So when igore_rtcp is enabled, t

[FFmpeg-devel] [PATCH 4/4] avcodec/vp3: Mark decoders as init-threadsafe

2021-05-07 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/vp3.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/libavcodec/vp3.c b/libavcodec/vp3.c index 6d44b9345c..166c1bf60d 100644 --- a/libavcodec/vp3.c +++ b/libavcodec/vp3.c @@ -3166,8 +3166,8 @@ const AVCodec ff_theora

[FFmpeg-devel] [PATCH 3/4] avcodec/vp3: Reindentation

2021-05-07 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/vp3.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/libavcodec/vp3.c b/libavcodec/vp3.c index ef443dbf22..6d44b9345c 100644 --- a/libavcodec/vp3.c +++ b/libavcodec/vp3.c @@ -2431,14 +2431,14 @@ static av_cold

[FFmpeg-devel] [PATCH 2/4] avcodec/vp3: Avoid code duplication when initializing coeff_vlcs

2021-05-07 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/vp3.c | 20 +--- 1 file changed, 5 insertions(+), 15 deletions(-) diff --git a/libavcodec/vp3.c b/libavcodec/vp3.c index 9aa84e83b7..ef443dbf22 100644 --- a/libavcodec/vp3.c +++ b/libavcodec/vp3.c @@ -2408,6 +2408,8 @@ static av_co

[FFmpeg-devel] [PATCH 1/4] avcodec/vp3: Don't try to decode VP4 when VP4 decoder is disabled

2021-05-07 Thread Andreas Rheinhardt
Otherwise decoding will crash lateron; e.g. because dct_tokens is never set or because a VLC that has not been allocated is used. Signed-off-by: Andreas Rheinhardt --- libavcodec/vp3.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/libavcodec/vp3.c b/libavcodec/vp3.c

[FFmpeg-devel] [PATCH v3 2/2] avformat: add data_size for ff_hex_to_data()

2021-05-07 Thread lance . lmwang
From: Limin Wang This prevents OOM in case of data buffer size is insufficient. Signed-off-by: Limin Wang --- libavformat/hls.c | 4 +++- libavformat/internal.h | 6 -- libavformat/rtpdec_latm.c | 6 -- libavformat/rtpdec_mpeg4.c | 6 -- libavformat/utils.c| 7

[FFmpeg-devel] [PATCH v3 1/2] avfilter/dnn/dnn_backend_tf: fix cross library usage

2021-05-07 Thread lance . lmwang
From: Limin Wang duplicate ff_hex_to_data() function from avformat and rename it to hex_to_data() as static function. Signed-off-by: Limin Wang --- libavfilter/dnn/dnn_backend_tf.c | 41 +--- 1 file changed, 38 insertions(+), 3 deletions(-) diff --git a/lib

Re: [FFmpeg-devel] [PATCH] avfilter/af_afade: remove fade duration limit

2021-05-07 Thread realies
Can you please review this? Patchwork has failed to apply it as the attachment has a mime type of application/octet-stream. On Fri, Apr 30, 2021 at 4:36 AM realies wrote: > > On Thu, Apr 29, 2021 at 2:49 AM realies wrote: > > > > From 8a4fe250e508932d8018adbb1af95d7c4a599a58 Mon Sep 17 00:00:00

[FFmpeg-devel] [PATCH] avcodec/avpacket: always initialize the new packet in avpriv_packet_list_put()

2021-05-07 Thread James Almer
If a copy callback is provided by the caller, the packet passed to it was zeroed instead of initialized with default values. Signed-off-by: James Almer --- libavcodec/avpacket.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavcodec/avpacket.c b/libavcodec/avpacket.c

[FFmpeg-devel] [PATCH 1/2] avcodec: Implement Acorn Replay IMA ADPCM decoder

2021-05-07 Thread Cameron Cawley
--- Changelog | 1 + doc/general_contents.texi | 1 + libavcodec/Makefile | 1 + libavcodec/adpcm.c| 19 +++ libavcodec/allcodecs.c| 1 + libavcodec/codec_desc.c | 7 +++ libavcodec/codec_id.h | 1 + libavcodec/utils.c| 1 +

[FFmpeg-devel] PATCH: examples/transcode_aac.c drain/flush to output

2021-05-07 Thread Ray
Example transocde_aac.c does not drain queue and write to output when requested, resulting in "frames left in queue on closing" warning messages and samples/frames lost. $ ./transcode_aac foo.wav foo.aac [aac @ 0x1e299c0] Qavg: 55159.750 [aac @ 0x1e299c0] 1 frames left in the queue on closing A

[FFmpeg-devel] [PATCH 2/2] avformat/rpl: Support files containing Replay IMA ADPCM audio

2021-05-07 Thread Cameron Cawley
--- libavformat/rpl.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/libavformat/rpl.c b/libavformat/rpl.c index 367e80b2c4..d495734e8e 100644 --- a/libavformat/rpl.c +++ b/libavformat/rpl.c @@ -121,6 +121,7 @@ static int rpl_read_header(AVFormatContext *s)

Re: [FFmpeg-devel] [PATCH] avcodec: be more explicit about the buffer size in get_encode_buffer documentation

2021-05-07 Thread James Almer
On 5/4/2021 11:12 PM, James Almer wrote: Signed-off-by: James Almer --- libavcodec/avcodec.h | 4 1 file changed, 4 insertions(+) diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h index 0ef1676daf..3cf131d0a5 100644 --- a/libavcodec/avcodec.h +++ b/libavcodec/avcodec.h @@ -2097,6

[FFmpeg-devel] [PATCH v2] avcodec/h263, h263data: Move ff_h263_init_rl_inter to h263.c

2021-05-07 Thread Andreas Rheinhardt
The SVQ1 decoder does not need mpegvideo or rl.c, but it uses stuff from h263data.c. But since 61fe481586425a41d45e371de1e875b49882477d h263data.c called ff_rl_init() and this of course led to build errors when the SVQ1 decoder is enabled and mpegvideo disabled. Fix this by moving ff_h263_init_rl_

[FFmpeg-devel] [PATCH 2/2] avcodec/h263, h263data: Move ff_h263_init_rl_inter to h263.c

2021-05-07 Thread Andreas Rheinhardt
The SVQ1 decoder does not need mpegvideo or rl.c, but it uses stuff from h263data.c. But since 61fe481586425a41d45e371de1e875b49882477d h263data.c called ff_rl_init() and this of course led to build errors when the SVQ1 decoder is enabled and mpegvideo disabled. Fix this by moving ff_h263_init_rl_

[FFmpeg-devel] [PATCH 1/2] configure: Add missing mpegvideo dependency for IPU decoder

2021-05-07 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- Will apply this patchset later tonight if no one objects. configure | 1 + 1 file changed, 1 insertion(+) diff --git a/configure b/configure index 9ece040c7b..ebc9588b0d 100755 --- a/configure +++ b/configure @@ -2789,6 +2789,7 @@ indeo3_decoder_select="hpe

Re: [FFmpeg-devel] [PATCH] avformat/movenc: correct range for movie_timescale

2021-05-07 Thread Gyan Doshi
On 2021-05-07 19:00, James Almer wrote: On 5/7/2021 10:22 AM, Gyan Doshi wrote: ISO 14496-12 declares it as a 32-bit unsigned integer ---   libavformat/movenc.c | 2 +-   1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index 2ab507df15..9f

[FFmpeg-devel] [PATCHv3] fate/integer.c: Connect test to fuzzer

2021-05-07 Thread Vedaa
Hi, I have added the inclusion guards and changed the author. --- Makefile | 2 ++ libavutil/tests/integer.c | 21 ++ libavutil/tests/integer.h | 45 +++ tools/Makefile| 3 +++ tools/target_int_fuzzer.c | 35

Re: [FFmpeg-devel] [PATCH V4] [mips] Optimize H264 decoding for MIPS platform.

2021-05-07 Thread Michael Niedermayer
On Thu, May 06, 2021 at 09:16:12PM +0800, 殷时友 wrote: > > > 2021年4月12日 下午11:37,Shiyou Yin 写道: > > > > v2: Fixed a build error in [PATCH 2/5]. > > v3: add patch 4/5. > > v4: Fix bug in 2/5 caused by instruction 'lhu' on BIGENDIAN environment. > > > > [PATCH v4 1/5] avcodec/mips: Restore the initi

Re: [FFmpeg-devel] [PATCHv2] fate/integer.c: Connect test to fuzzer

2021-05-07 Thread Michael Niedermayer
On Thu, May 06, 2021 at 10:34:50PM +0530, Vedaa wrote: > Hi, > > I have made the requisite changes. [...] > +++ b/libavutil/tests/integer.h > @@ -0,0 +1,43 @@ > +/* > + * Copyright (c) 2004 Michael Niedermayer > + * > + * This file is part of FFmpeg. > + * > + * FFmpeg is free software; you ca

Re: [FFmpeg-devel] [PATCH v2 2/2] avformat: add data_size for ff_hex_to_data()

2021-05-07 Thread lance . lmwang
On Fri, May 07, 2021 at 09:40:16AM -0300, James Almer wrote: > On 5/7/2021 8:00 AM, lance.lmw...@gmail.com wrote: > > From: Limin Wang > > > > This prevents OOM in case of data buffer size is insufficient. > > > > Signed-off-by: Limin Wang > > --- > > libavformat/hls.c | 2 +- > > l

Re: [FFmpeg-devel] [PATCH] avcodec/alsdec: Fixed decoding error for mono audio files

2021-05-07 Thread Thilo Borgmann
Am 07.05.21 um 13:07 schrieb Michael Niedermayer: > From: noboru2000 > > A highest_decoded_channel flag is modified to serve as meant. > > Signed-off-by: noboru2000 > > Regression since: a11aa5f3ed7ee4d2385a7b725d43f6070d790b4c > Fixes: Sin48k16bit1ch.mp4 > > Signed-off-by: Michael Niedermaye

[FFmpeg-devel] [PATCH 2/2] lavf/mpegts: fix av_log use the uninitialized stream id

2021-05-07 Thread Jun Zhao
From: Jun Zhao fix av_log use the uninitialized stream id Signed-off-by: Jun Zhao --- libavformat/mpegts.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavformat/mpegts.c b/libavformat/mpegts.c index 9092dbce72..722dae8e36 100644 --- a/libavformat/mpegts.c +++ b/liba

[FFmpeg-devel] [PATCH 1/2] doc/filters: Update commands doc for amix

2021-05-07 Thread Jun Zhao
From: Jun Zhao commit 95b854dd06 "rename sum option to normalize" missed command part docs Signed-off-by: Jun Zhao --- doc/filters.texi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/filters.texi b/doc/filters.texi index b405cc5dfb..3d5aa8e8ef 100644 --- a/doc/filters.

Re: [FFmpeg-devel] [PATCH] avformat/movenc: correct range for movie_timescale

2021-05-07 Thread James Almer
On 5/7/2021 10:22 AM, Gyan Doshi wrote: ISO 14496-12 declares it as a 32-bit unsigned integer --- libavformat/movenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index 2ab507df15..9fe58b312e 100644 --- a/libavformat/movenc.c

[FFmpeg-devel] [PATCH] avformat/movenc: correct range for movie_timescale

2021-05-07 Thread Gyan Doshi
ISO 14496-12 declares it as a 32-bit unsigned integer --- libavformat/movenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index 2ab507df15..9fe58b312e 100644 --- a/libavformat/movenc.c +++ b/libavformat/movenc.c @@ -107,7 +107,7

Re: [FFmpeg-devel] [PATCH v2 2/2] avformat: add data_size for ff_hex_to_data()

2021-05-07 Thread James Almer
On 5/7/2021 8:00 AM, lance.lmw...@gmail.com wrote: From: Limin Wang This prevents OOM in case of data buffer size is insufficient. Signed-off-by: Limin Wang --- libavformat/hls.c | 2 +- libavformat/internal.h | 6 -- libavformat/rtpdec_latm.c | 4 ++-- libavformat/rtpd

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/adpcm_psx: always fetch next byte irregardless of flag

2021-05-07 Thread Zane van Iperen
On 3/5/21 9:31 pm, Zane van Iperen wrote: Even though all samples are meant to be zero (if flag == 0x07), doesn't mean that they aren't there. See No$PSX docs [1]. [1]: https://problemkaputt.de/psx-spx.htm#spuadpcmsamples Ping on this patchset. _

[FFmpeg-devel] [PATCH] avcodec/alsdec: Fixed decoding error for mono audio files

2021-05-07 Thread Michael Niedermayer
From: noboru2000 A highest_decoded_channel flag is modified to serve as meant. Signed-off-by: noboru2000 Regression since: a11aa5f3ed7ee4d2385a7b725d43f6070d790b4c Fixes: Sin48k16bit1ch.mp4 Signed-off-by: Michael Niedermayer --- libavcodec/alsdec.c | 9 ++--- 1 file changed, 6 insertion

[FFmpeg-devel] [PATCH v2 2/2] avformat: add data_size for ff_hex_to_data()

2021-05-07 Thread lance . lmwang
From: Limin Wang This prevents OOM in case of data buffer size is insufficient. Signed-off-by: Limin Wang --- libavformat/hls.c | 2 +- libavformat/internal.h | 6 -- libavformat/rtpdec_latm.c | 4 ++-- libavformat/rtpdec_mpeg4.c | 4 ++-- libavformat/utils.c| 7 +

[FFmpeg-devel] [PATCH v2 1/2] avfilter/dnn/dnn_backend_tf: fix cross library usage

2021-05-07 Thread lance . lmwang
From: Limin Wang duplicate ff_hex_to_data() function from avformat and rename it to hex_to_data() as static function. Signed-off-by: Limin Wang --- libavfilter/dnn/dnn_backend_tf.c | 38 +++--- 1 file changed, 35 insertions(+), 3 deletions(-) diff --git a/libav

Re: [FFmpeg-devel] [PATCH] [GSOC] avfilter: added guided filter

2021-05-07 Thread Steven Liu
Andrey Moskalenko 于2021年5月3日周一 上午3:47写道: > > Added guided filter with subsampling and multithreading for speedup. Maybe not only use multithreading for speedup, also need some algorithms to improve it. What about the speedup compare data? > --- > doc/filters.texi | 25 +++ > libavfilter/

Re: [FFmpeg-devel] [PATCH] avfilter/vf_dnn_classify: add result check for av_frame_get_side_data

2021-05-07 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel On Behalf Of > Steven Liu > Sent: 2021年5月7日 16:30 > To: FFmpeg development discussions and patches > > Subject: Re: [FFmpeg-devel] [PATCH] avfilter/vf_dnn_classify: add result > check for av_frame_get_side_data > > Guo, Yejun 于2021年5月7日周五 下午4:

Re: [FFmpeg-devel] [PATCH] avfilter/vf_dnn_classify: add result check for av_frame_get_side_data

2021-05-07 Thread Steven Liu
Guo, Yejun 于2021年5月7日周五 下午4:11写道: > > > > > -Original Message- > > From: ffmpeg-devel On Behalf Of > > Steven Liu > > Sent: 2021年5月7日 14:43 > > To: ffmpeg-devel@ffmpeg.org > > Cc: Steven Liu > > Subject: [FFmpeg-devel] [PATCH] avfilter/vf_dnn_classify: add result check > > for > > av_fr

Re: [FFmpeg-devel] [PATCH] avfilter/vf_dnn_classify: add result check for av_frame_get_side_data

2021-05-07 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel On Behalf Of > Steven Liu > Sent: 2021年5月7日 14:43 > To: ffmpeg-devel@ffmpeg.org > Cc: Steven Liu > Subject: [FFmpeg-devel] [PATCH] avfilter/vf_dnn_classify: add result check for > av_frame_get_side_data > > CID: 1482090 thanks for the patch, w

Re: [FFmpeg-devel] [PATCH 2/2] GSoC: Add guided filter

2021-05-07 Thread Steven Liu
Xuewei Meng <928826...@qq.com> 于2021年5月6日周四 下午10:59写道: > > This version can be executed by thread in slice level. > > To-Do-List: > > 1. Fast guided filter > > 2. Improve the derain/dehaze/denoise performance of guided filter > > Signed-off-by: Xuewei Meng <928826...@qq.com> > --- > doc/filters.te

Re: [FFmpeg-devel] [PATCH 04/23] avcodec/zmbv: Mark decoder as init-threadsafe

2021-05-07 Thread Tomas Härdin
tor 2021-05-06 klockan 07:11 +0200 skrev Andreas Rheinhardt: > Initializing zlib in the way we do here is threadsafe, see > https://www.zlib.net/zlib_faq.html#faq21 > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/zmbv.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff -

Re: [FFmpeg-devel] [PATCH 03/23] avcodec/zmbv: Don't free uninitialized z_stream

2021-05-07 Thread Tomas Härdin
tor 2021-05-06 klockan 07:11 +0200 skrev Andreas Rheinhardt: > It is not documented to be safe to call inflateEnd() on a z_stream > that has not been successfully initialized via inflateInit(); so > record whether it has been successfully initialized. > > Signed-off-by: Andreas Rheinhardt Seems