[FFmpeg-devel] [PATCH] avcodec: be more explicit about the buffer size in get_encode_buffer documentation

Signed-off-by: James Almer --- libavcodec/avcodec.h | 4 1 file changed, 4 insertions(+) diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h index 0ef1676daf..3cf131d0a5 100644 --- a/libavcodec/avcodec.h +++ b/libavcodec/avcodec.h @@ -2097,6 +2097,10 @@ typedef struct AVCodecContext {

Re: [FFmpeg-devel] [PATCH V2 6/6] lavfi/dnn_classify: add filter dnn_classify for classification based on detection bounding boxes

> -Original Message- > From: Guo, Yejun > Sent: 2021年4月29日 21:37 > To: ffmpeg-devel@ffmpeg.org > Cc: Guo, Yejun > Subject: [PATCH V2 6/6] lavfi/dnn_classify: add filter dnn_classify for > classification based on detection bounding boxes > > classification is done on every detection bou

Re: [FFmpeg-devel] [PATCH] avformat/rpl: cosmetics

On 4/5/21 10:05 pm, Zane van Iperen wrote: Signed-off-by: Zane van Iperen --- libavformat/rpl.c | 26 ++ 1 file changed, 10 insertions(+), 16 deletions(-) I will apply this trivial change tomorrow, if no objections. ___

[FFmpeg-devel] [PATCH 3/3] avcodec/iff: Only write palette to plane 1 if its PAL8

Fixes: null pointer passed as argument 1, which is declared to never be null Fixes: 33791/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_IFF_ILBM_fuzzer-5107575256383488.fuzz Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Mic

[FFmpeg-devel] [PATCH 2/3] avformat/tta: Check for EOF in index reading loop

Fixes: OOM Fixes: 33585/clusterfuzz-testcase-minimized-ffmpeg_dem_TTA_fuzzer-4564665830080512 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavformat/tta.c | 2 ++ 1 file changed, 2 insertions(+) di

[FFmpeg-devel] [PATCH 1/3] avutil/tx: avoid negative left shifts

Fixes: left shift of negative value -1 Fixes: 33736/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_SIREN_fuzzer-6657785795313664 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavutil/tx.c | 4 ++--

Re: [FFmpeg-devel] [PATCH] avutil/imgutils: don't add offsets to NULL pointers

On 5/4/2021 5:13 PM, Andreas Rheinhardt wrote: James Almer: Signed-off-by: James Almer --- libavutil/imgutils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavutil/imgutils.c b/libavutil/imgutils.c index 53faad889a..aaee0dfb7a 100644 --- a/libavutil/imgutils.c +++ b

Re: [FFmpeg-devel] [PATCH] avutil/imgutils: don't add offsets to NULL pointers

James Almer: > Signed-off-by: James Almer > --- > libavutil/imgutils.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavutil/imgutils.c b/libavutil/imgutils.c > index 53faad889a..aaee0dfb7a 100644 > --- a/libavutil/imgutils.c > +++ b/libavutil/imgutils.c > @@ -166,7

Re: [FFmpeg-devel] [PATCH 24/46] avcodec/jpeglsenc: Avoid intermediate buffer, allow user-supplied buffers

On 5/4/2021 4:20 PM, Andreas Rheinhardt wrote: James Almer: On 4/29/2021 8:56 PM, Andreas Rheinhardt wrote: Up until now, the JPEG-LS encoder allocated a worst-case-sized packet at the beginning of each encode2 call; then it wrote the packet header into its destination buffer and encoded the ac

[FFmpeg-devel] [PATCH] avfilter/[vf_nnedi, vf_estdif]: Check interlaced flag on correct frame

Fixes regression in vf_nnedi after 24dc6d386c6f7edb8f6945319f53a7f0b1642bb8 and vf_estdif while at it. Signed-off-by: Kacper Michajłow --- libavfilter/vf_estdif.c | 2 +- libavfilter/vf_nnedi.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/libavfilter/vf_estdif.c b/liba

Re: [FFmpeg-devel] [PATCH 1/5] libavutil: add convenience accessors for frame side data

May 4, 2021, 19:00 by jamr...@gmail.com: > On 5/4/2021 12:44 PM, Lynne wrote: > >> Apr 30, 2021, 22:29 by c...@passwd.hu: >> >>> >>> >>> On Fri, 30 Apr 2021, Lynne wrote: >>> Apr 30, 2021, 13:34 by br...@frogmouth.net: > Signed-off-by: Brad Hards > --- > libavutil/frame.c |

Re: [FFmpeg-devel] [PATCH 24/46] avcodec/jpeglsenc: Avoid intermediate buffer, allow user-supplied buffers

James Almer: > On 4/29/2021 8:56 PM, Andreas Rheinhardt wrote: >> Up until now, the JPEG-LS encoder allocated a worst-case-sized packet >> at the beginning of each encode2 call; then it wrote the packet header >> into its destination buffer and encoded the actual packet data; >> said data is writte

Re: [FFmpeg-devel] [PATCH] avfilter/[vf_nnedi, vf_estdif]: Check interlaced flag on correct frame

On Tue, 4 May 2021 at 21:05, Kacper Michajłow wrote: > Fixes regression in vf_nnedi after > 24dc6d386c6f7edb8f6945319f53a7f0b1642bb8 and vf_estdif while at it. > > Signed-off-by: Kacper Michajłow > --- > libavfilter/vf_estdif.c | 2 +- > libavfilter/vf_nnedi.c | 2 +- > 2 files changed, 2 inse

Re: [FFmpeg-devel] [PATCH 24/46] avcodec/jpeglsenc: Avoid intermediate buffer, allow user-supplied buffers

On 4/29/2021 8:56 PM, Andreas Rheinhardt wrote: Up until now, the JPEG-LS encoder allocated a worst-case-sized packet at the beginning of each encode2 call; then it wrote the packet header into its destination buffer and encoded the actual packet data; said data is written into another worst-case

Re: [FFmpeg-devel] [PATCH] avformat/avio: Add Metacube support

On Tue, 4 May 2021, Steinar H. Gunderson wrote: On Tue, May 04, 2021 at 04:46:29PM +0100, Derek Buitenhuis wrote: Can this not be accomplished outside of FFmpeg, by registering your own I/O callbacks? That would seem to me to be the 'proper' way to do this. More work? Yes. But less hacky. For

Re: [FFmpeg-devel] [PATCH 5/5] avformat: move AVStream.stream_identifier to AVStreamInternal

On 5/4/2021 3:35 PM, Andreas Rheinhardt wrote: James Almer: It's a private field, no reason to have it exposed in a public header. Signed-off-by: James Almer --- libavformat/avformat.h | 7 --- libavformat/internal.h | 7 +++ libavformat/mpegts.c | 4 ++-- 3 files changed, 9 ins

Re: [FFmpeg-devel] [PATCH 5/5] avformat: move AVStream.stream_identifier to AVStreamInternal

James Almer: > It's a private field, no reason to have it exposed in a public header. > > Signed-off-by: James Almer > --- > libavformat/avformat.h | 7 --- > libavformat/internal.h | 7 +++ > libavformat/mpegts.c | 4 ++-- > 3 files changed, 9 insertions(+), 9 deletions(-) > > diff -

Re: [FFmpeg-devel] [PATCH] avformat/avio: Add Metacube support

On Tue, May 04, 2021 at 06:38:41PM +0100, Derek Buitenhuis wrote: > I will say that it is unclear enough to me what the goals and uses are of > the patch that it came off a bit like upstreaming something purely for > personal > use, even if that wasn't intended. Apologies. No offense taken. The b

Re: [FFmpeg-devel] [PATCH] avformat/avio: Add Metacube support

On 04/05/2021 18:22, Steinar H. Gunderson wrote: > For a libavformat-using program that does its own transports? Sure, I'm > already doing that in other projects. For anything that wants to use the > ffurl transports -- and in particular, stream from the ffmpeg(1) client? > I don't see how that wou

Re: [FFmpeg-devel] [PATCH] avformat/avio: Add Metacube support

On Tue, May 04, 2021 at 04:46:29PM +0100, Derek Buitenhuis wrote: > Can this not be accomplished outside of FFmpeg, by registering your own I/O > callbacks? That would seem to me to be the 'proper' way to do this. More > work? Yes. But less hacky. For a libavformat-using program that does its own

Re: [FFmpeg-devel] [PATCH] avcodec/codec_id: remove unnecessary offsets from AVCodecID

lgtm On Mon, May 3, 2021 at 3:21 PM James Almer wrote: > They are no longer required. > > Signed-off-by: James Almer > --- > libavcodec/codec_id.h | 20 +++- > 1 file changed, 7 insertions(+), 13 deletions(-) > > diff --git a/libavcodec/codec_id.h b/libavcodec/codec_id.h > inde

Re: [FFmpeg-devel] [PATCH] ffprobe: add option to control optional fields display

On 04/05/2021 17:51, Nicolas George wrote: > This part of XML is hugely complicated. Many people prefer to pretend it > does not exist, and I think we should avoid forcing them to use it if > there is a simpler solution. Yes, presumably this is why nobody uses the XSD :) - Derek _

Re: [FFmpeg-devel] [PATCH 1/5] libavutil: add convenience accessors for frame side data

On 5/4/2021 12:44 PM, Lynne wrote: Apr 30, 2021, 22:29 by c...@passwd.hu: On Fri, 30 Apr 2021, Lynne wrote: Apr 30, 2021, 13:34 by br...@frogmouth.net: Signed-off-by: Brad Hards --- libavutil/frame.c | 31 +++ libavutil/frame.h | 23 +++

[FFmpeg-devel] [PATCH] Intel IPP library based x86 optimized video scaling.

Victoria Zhislina Cloud Software Engineering, Senior Application Engineer, Intel Corp. Nizhny Novgorod, Russia; Office: (831)-2969-444 ext.2231; INET: 312-2231 Joint Stock Company Intel A/O Registered legal address: Krylatsky Hi

Re: [FFmpeg-devel] [PATCH] ffprobe: add option to control optional fields display

Derek Buitenhuis (12021-05-04): > For XML, the correct way to do that is to use the XSD in the doc/ directory. > That's how XML is supposed to work. This part of XML is hugely complicated. Many people prefer to pretend it does not exist, and I think we should avoid forcing them to use it if there

Re: [FFmpeg-devel] [PATCH] ffprobe: add option to control optional fields display

On 04/05/2021 17:32, Gyan Doshi wrote: > No. It's to allow consumers of these writers to discover and access all > fields if they choose to. > > It's an obstacle I faced in a recent project. For XML, the correct way to do that is to use the XSD in the doc/ directory. That's how XML is supposed t

Re: [FFmpeg-devel] [PATCH] ffprobe: add option to control optional fields display

On 2021-05-04 21:12, Derek Buitenhuis wrote: On 01/05/2021 14:07, Gyan Doshi wrote: +@item -show_optional_fields @var{value} +Some writers viz. JSON and XML, omit the printing of fields with invalid or non-applicable values, +while other writers always print them. This option enables one

Re: [FFmpeg-devel] [PATCH] avformat/avio: Add Metacube support

On Tue, May 4, 2021 at 5:52 PM Derek Buitenhuis wrote: > > On 03/05/2021 22:05, Steinar H. Gunderson wrote: > > Two reasons: > > > > - As the commit message says, it is desirable to have this on pipe output > > as > >well (Cubemap would like to fork out to FFmpeg to do remuxing etc. for > >

Re: [FFmpeg-devel] [PATCH] avformat/avio: Add Metacube support

On 03/05/2021 22:05, Steinar H. Gunderson wrote: > Two reasons: > > - As the commit message says, it is desirable to have this on pipe output as >well (Cubemap would like to fork out to FFmpeg to do remuxing etc. for >it, without having to speak HTTP over the pipe). > - The HTTP layer do

Re: [FFmpeg-devel] [PATCH] ffprobe: add option to control optional fields display

On 01/05/2021 14:07, Gyan Doshi wrote: > > +@item -show_optional_fields @var{value} > +Some writers viz. JSON and XML, omit the printing of fields with invalid or > non-applicable values, > +while other writers always print them. This option enables one to control > this behaviour. > +Valid val

Re: [FFmpeg-devel] [PATCH 1/5] libavutil: add convenience accessors for frame side data

Apr 30, 2021, 22:29 by c...@passwd.hu: > > > On Fri, 30 Apr 2021, Lynne wrote: > >> Apr 30, 2021, 13:34 by br...@frogmouth.net: >> >>> Signed-off-by: Brad Hards >>> --- >>> libavutil/frame.c | 31 +++ >>> libavutil/frame.h | 23 +++ >>> 2 files cha

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg: fix -t inaccurate recording time

Hi, any updates for this patch? 获取 Outlook for iOS 发件人: Shiwang.Xie 发送时间: Friday, April 30, 2021 12:26:46 AM 收件人: ffmpeg-devel@ffmpeg.org 抄送: Shiwang.Xie 主题: [PATCH] fftools/ffmpeg: fix -t inaccurate recording time if input start time is

Re: [FFmpeg-devel] [PATCH 1/2] configure: fix some filter dependencies

On Tue, May 4, 2021 at 1:27 PM Matthias C. M. Troffaes wrote: > Fixes builds with > > --disable-avcodec --disable-avformat --enable-avfilter > > which currently results in a broken avfilter library due to a few > filters that require avcodec or avformat getting mistakenly > compiled. Note that th

[FFmpeg-devel] [PATCH] Enhancement for defect #6827

Adding error logs to identify special failure, when Directd3d 9 is not supported. see defect #6827 --- libavutil/hwcontext_dxva2.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavutil/hwcontext_dxva2.c b/libavutil/hwcontext_dxva2.c

[FFmpeg-devel] [PATCH 1/2] configure: fix some filter dependencies

Fixes builds with --disable-avcodec --disable-avformat --enable-avfilter which currently results in a broken avfilter library due to a few filters that require avcodec or avformat getting mistakenly compiled. --- configure | 7 +++ 1 file changed, 7 insertions(+) diff --git a/configure b/co

[FFmpeg-devel] [PATCH 2/2] configure: dnn needs avformat

The source file "libavfilter/dnn/dnn_backend_native.h" includes "libavformat/avio.h", so avformat needs to be declared as a dependency. --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 9e45c0822c..8725a94f8a 100755 --- a/configure +++ b/

Re: [FFmpeg-devel] [PATCH 1/4] avformat/mvdec: Check sample rate in parse_audio_var()

On Thu, Apr 29, 2021 at 08:50:35AM +1000, Peter Ross wrote: > On Wed, Apr 28, 2021 at 05:06:33PM +0200, Michael Niedermayer wrote: > > Fixes: signed integer overflow: -63542400238284 * 16 cannot be > > represented in type 'long' > > Fixes: > > 33612/clusterfuzz-testcase-minimized-ffmpeg_dem_M

Re: [FFmpeg-devel] [PATCH] avcodec/faxcompr: Check for end of bitstream in decode_group3_1d_line() and decode_group3_2d_line()

On Thu, Apr 29, 2021 at 05:25:40PM +0200, Andreas Rheinhardt wrote: > Michael Niedermayer: > > Fixes: infinite loop > > Fixes: > > 33674/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_TIFF_fuzzer-4816457818046464 > > > > Found-by: continuous fuzzing process > > https://github.com/google/oss-f

Re: [FFmpeg-devel] [PATCH] avcodec/utils: treat PAL8 for jpegs similar to other colorspaces

On Thu, Apr 29, 2021 at 10:09:37PM +0200, Michael Niedermayer wrote: > Fixes: out of array access > Fixes: > 33713/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MJPEG_fuzzer-5778775641030656 > > Related to: c8197f73e684b0edc450f3dc2b2b4b3fb9dedd0d > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH] GSoC: Add guided filter To-Do-List: 1. Fast guided filter 2. Improve the derain/dehaze/denoise performance of guided filter

XueweiMeng <928826...@qq.com> 于2021年5月3日周一 下午10:59写道： > > From: Xuewei Meng Todo comments should be mail context, not subject. > > Signed-off-by: Xuewei Meng > --- > doc/filters.texi | 21 +++ > libavfilter/Makefile | 1 + > libavfilter/allfilters.c | 1 + > libavfilter/vf_guid

[FFmpeg-devel] [PATCH] avformat/rpl: cosmetics

Signed-off-by: Zane van Iperen --- libavformat/rpl.c | 26 ++ 1 file changed, 10 insertions(+), 16 deletions(-) diff --git a/libavformat/rpl.c b/libavformat/rpl.c index f5d2b8fe59..367e80b2c4 100644 --- a/libavformat/rpl.c +++ b/libavformat/rpl.c @@ -216,18 +216,13 @@ sta

Re: [FFmpeg-devel] [PATCH 2/2] avformat/rpl: Support files containing Replay IMA ADPCM audio

On 4/5/21 6:10 am, Cameron Cawley wrote: +case 2: + if(av_stristr(audio_codec, "adpcm") != NULL) { Nit: use spaces here. Also "if (" +ast->codecpar->codec_id = AV_CODEC_ID_ADPCM_IMA_ACORN; +break; +} +

Re: [FFmpeg-devel] [PATCH] ffprobe: add option to control optional fields display

Ping; plan to push tomorrow. On 2021-05-01 18:37, Gyan Doshi wrote: --- doc/ffprobe.texi | 6 ++ fftools/ffprobe.c | 23 +-- 2 files changed, 27 insertions(+), 2 deletions(-) diff --git a/doc/ffprobe.texi b/doc/ffprobe.texi index d7fab4ff40..59a397a225 100644 --- a