Re: [FFmpeg-devel] [PATCH v2 1/2] avcodec/adpcmenc: Adds encoder for Westwood ADPCM.

2021-04-23 Thread Zane van Iperen
On 24/4/21 8:35 am, Aidan Richmond wrote: +case AV_CODEC_ID_ADPCM_IMA_WS: +{ +PutBitContext pb; +init_put_bits(&pb, dst, pkt_size); + +av_assert0(avctx->trellis == 0); +for (n = frame->nb_samples / 2; n > 0; n--) { +/* stereo: 1 byte (2 samp

[FFmpeg-devel] [PATCH v2 2/2] avformat/westwoodaudenc: Adds muxer for Westwood AUD format.

2021-04-23 Thread Aidan Richmond
Format is still used by modders of these old games. --- libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/westwood_audenc.c | 129 ++ 3 files changed, 131 insertions(+) create mode 100644 libavformat/westwood_audenc.c

[FFmpeg-devel] [PATCH v2 1/2] avcodec/adpcmenc: Adds encoder for Westwood ADPCM.

2021-04-23 Thread Aidan Richmond
--- libavcodec/Makefile| 1 + libavcodec/adpcmenc.c | 32 ++-- libavcodec/allcodecs.c | 1 + 3 files changed, 32 insertions(+), 2 deletions(-) diff --git a/libavcodec/Makefile b/libavcodec/Makefile index 4a597f727a..fcddde459d 100644 --- a/libavcodec/Makefile ++

Re: [FFmpeg-devel] [PATCH] avcodec/av1_metadata: don't store the inserted TD OBU in stack

2021-04-23 Thread James Almer
On 4/23/2021 5:00 PM, Andreas Rheinhardt wrote: James Almer: Fixes: stack-use-after-return Fixes: clusterfuzz-testcase-minimized-ffmpeg_BSF_AV1_METADATA_fuzzer-5931515701755904 Fixes: clusterfuzz-testcase-minimized-ffmpeg_BSF_AV1_METADATA_fuzzer-6105676541722624 Signed-off-by: James Almer --

Re: [FFmpeg-devel] [PATCH] avcodec/av1_metadata: don't store the inserted TD OBU in stack

2021-04-23 Thread Andreas Rheinhardt
James Almer: > Fixes: stack-use-after-return > Fixes: > clusterfuzz-testcase-minimized-ffmpeg_BSF_AV1_METADATA_fuzzer-5931515701755904 > Fixes: > clusterfuzz-testcase-minimized-ffmpeg_BSF_AV1_METADATA_fuzzer-6105676541722624 > > Signed-off-by: James Almer > --- > libavcodec/av1_metadata_bsf.c

Re: [FFmpeg-devel] [PATCH] Pass the HDR10+ metadata to the packet side data in VP9 encoder

2021-04-23 Thread James Zern
Hi, On Fri, Apr 23, 2021 at 8:58 AM Mohammad Izadi wrote: > > HDR10+ metadata is stored in the bit stream for HEVC. The story is different > for VP9 and cannot store the metadata in the bit stream. HDR10+ should be > passed to packet side data an stored in the container (mkv) for VP9. > > This

Re: [FFmpeg-devel] [PATCH 1/7] avformat/asfdec_o: shrink extradata to the initialized size

2021-04-23 Thread James Almer
On 4/23/2021 2:50 PM, Michael Niedermayer wrote: Fixes: OOM Fixes: 27240/clusterfuzz-testcase-minimized-ffmpeg_dem_ASF_O_fuzzer-5937469859823616 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavfo

Re: [FFmpeg-devel] [PATCH 1/7] avformat/asfdec_o: shrink extradata to the initialized size

2021-04-23 Thread Andreas Rheinhardt
Michael Niedermayer: > Fixes: OOM > Fixes: > 27240/clusterfuzz-testcase-minimized-ffmpeg_dem_ASF_O_fuzzer-5937469859823616 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael Niedermayer > --- > libavformat/asfdec_o

[FFmpeg-devel] [PATCH 5/7] avformat/bfi: check nframes

2021-04-23 Thread Michael Niedermayer
Fixes: signed integer overflow: -2147483648 - 1 cannot be represented in type 'int' Fixes: 29102/clusterfuzz-testcase-minimized-ffmpeg_dem_BFI_fuzzer-6737028768202752 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niede

[FFmpeg-devel] [PATCH 6/7] avformat/dsfdec: Change order of operations in bitrate computation

2021-04-23 Thread Michael Niedermayer
Fixes: signed integer overflow: 538976288 * 67372036 cannot be represented in type 'int' Fixes: 29102/clusterfuzz-testcase-minimized-ffmpeg_dem_DSF_fuzzer-6751696819716096 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael

[FFmpeg-devel] [PATCH 4/7] avformat/avidec: fix position overflow in avi_load_index()

2021-04-23 Thread Michael Niedermayer
Fixes: signed integer overflow: 9223372033098784808 + 4294967072 cannot be represented in type 'long' Fixes: 29102/clusterfuzz-testcase-minimized-ffmpeg_dem_AVI_fuzzer-6732488912273408 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off

[FFmpeg-devel] [PATCH 7/7] avformat/dsicin: Check packet size for overflow

2021-04-23 Thread Michael Niedermayer
Fixes: signed integer overflow: 24672 + 2147483424 cannot be represented in type 'int' Fixes: 29102/clusterfuzz-testcase-minimized-ffmpeg_dem_DSICIN_fuzzer-6731325979623424 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael

[FFmpeg-devel] [PATCH 2/7] avformat/aiffdec: Check for size overflow in header parsing

2021-04-23 Thread Michael Niedermayer
Fixes: signed integer overflow: 2147483647 + 1 cannot be represented in type 'int' Fixes: 29102/clusterfuzz-testcase-minimized-ffmpeg_dem_AIFF_fuzzer-6723467048255488 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niede

[FFmpeg-devel] [PATCH 3/7] avformat/asfdec_f: Check sizeX against padding

2021-04-23 Thread Michael Niedermayer
Fixes: signed integer overflow: 2147483607 + 64 cannot be represented in type 'int' Fixes: 29102/clusterfuzz-testcase-minimized-ffmpeg_dem_ASF_fuzzer-6753897878257664 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niede

[FFmpeg-devel] [PATCH 1/7] avformat/asfdec_o: shrink extradata to the initialized size

2021-04-23 Thread Michael Niedermayer
Fixes: OOM Fixes: 27240/clusterfuzz-testcase-minimized-ffmpeg_dem_ASF_O_fuzzer-5937469859823616 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavformat/asfdec_o.c | 6 +- 1 file changed, 5 insert

[FFmpeg-devel] [PATCH] Pass the HDR10+ metadata to the packet side data in VP9 encoder

2021-04-23 Thread Mohammad Izadi
HDR10+ metadata is stored in the bit stream for HEVC. The story is different for VP9 and cannot store the metadata in the bit stream. HDR10+ should be passed to packet side data an stored in the container (mkv) for VP9. This CL is taking HDR10+ from AVFrame side data in libvpxenc and is passing

Re: [FFmpeg-devel] [PATCH] avfilter/af_adelay: make per channel delay argument an int64_t

2021-04-23 Thread Andreas Rheinhardt
James Almer: > On 4/23/2021 11:18 AM, Andreas Rheinhardt wrote: >> James Almer: >>> Should fix ticket #9196 >>> >>> Signed-off-by: James Almer >>> --- >>>   libavfilter/af_adelay.c | 13 + >>>   1 file changed, 9 insertions(+), 4 deletions(-) >>> >>> diff --git a/libavfilter/af_adelay.c

Re: [FFmpeg-devel] [PATCH] avfilter/af_adelay: make per channel delay argument an int64_t

2021-04-23 Thread James Almer
On 4/23/2021 11:18 AM, Andreas Rheinhardt wrote: James Almer: Should fix ticket #9196 Signed-off-by: James Almer --- libavfilter/af_adelay.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/libavfilter/af_adelay.c b/libavfilter/af_adelay.c index 6ac81c2a3e..

Re: [FFmpeg-devel] [PATCH] avfilter/af_adelay: make per channel delay argument an int64_t

2021-04-23 Thread Andreas Rheinhardt
James Almer: > Should fix ticket #9196 > > Signed-off-by: James Almer > --- > libavfilter/af_adelay.c | 13 + > 1 file changed, 9 insertions(+), 4 deletions(-) > > diff --git a/libavfilter/af_adelay.c b/libavfilter/af_adelay.c > index 6ac81c2a3e..81ff7947f5 100644 > --- a/libavfilte

Re: [FFmpeg-devel] [PATCH 2/2] avformat/westwoodaudenc Adds muxer for Westwood AUD format.

2021-04-23 Thread Andreas Rheinhardt
Aidan Richmond: > Format is still used by modders of these old games. > --- > libavformat/Makefile | 1 + > libavformat/allformats.c | 1 + > libavformat/westwood_audenc.c | 120 > ++ > 3 files changed, 122 insertions(+) > create mode 100

Re: [FFmpeg-devel] [PATCH 2/2] avformat/westwoodaudenc Adds muxer for Westwood AUD format.

2021-04-23 Thread Zane van Iperen
On 23/4/21 6:51 pm, Aidan Richmond wrote: +/* This flags that the file contains 16 bit samples rather than 8 bit + since the encoder only encodes 16 bit samples this should be set. */ +flags |= 2; + +avio_wl16(pb, s->codecpar->sample_rate); +/* We don't know the file siz

[FFmpeg-devel] [PATCH] avfilter/af_adelay: make per channel delay argument an int64_t

2021-04-23 Thread James Almer
Should fix ticket #9196 Signed-off-by: James Almer --- libavfilter/af_adelay.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/libavfilter/af_adelay.c b/libavfilter/af_adelay.c index 6ac81c2a3e..81ff7947f5 100644 --- a/libavfilter/af_adelay.c +++ b/libavfilter/a

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/adpcmenc Adds encoder for Westwood ADPCM.

2021-04-23 Thread Zane van Iperen
On 23/4/21 6:51 pm, Aidan Richmond wrote: --- libavcodec/Makefile| 1 + libavcodec/adpcmenc.c | 32 ++-- libavcodec/allcodecs.c | 1 + 3 files changed, 32 insertions(+), 2 deletions(-) All looks mostly fine. Just a minor nit: Could you add a ":" to t

Re: [FFmpeg-devel] [PATCH] avfilter/af_adelay: make per channel delay argument an int64_t

2021-04-23 Thread Gyan Doshi
On 2021-04-23 19:05, James Almer wrote: On 4/23/2021 10:09 AM, Gyan Doshi wrote: On 2021-04-23 18:22, James Almer wrote: Should fix ticket #9196 Signed-off-by: James Almer ---   libavfilter/af_adelay.c | 11 +++   1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/libavf

Re: [FFmpeg-devel] [PATCH] avfilter/af_adelay: make per channel delay argument an int64_t

2021-04-23 Thread James Almer
On 4/23/2021 10:09 AM, Gyan Doshi wrote: On 2021-04-23 18:22, James Almer wrote: Should fix ticket #9196 Signed-off-by: James Almer ---   libavfilter/af_adelay.c | 11 +++   1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/libavfilter/af_adelay.c b/libavfilter/af_adelay.c

Re: [FFmpeg-devel] [PATCH] avfilter/af_adelay: make per channel delay argument an int64_t

2021-04-23 Thread Gyan Doshi
On 2021-04-23 18:22, James Almer wrote: Should fix ticket #9196 Signed-off-by: James Almer --- libavfilter/af_adelay.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/libavfilter/af_adelay.c b/libavfilter/af_adelay.c index 6ac81c2a3e..1229bf5bc7 100644 ---

[FFmpeg-devel] [PATCH] avfilter/af_adelay: make per channel delay argument an int64_t

2021-04-23 Thread James Almer
Should fix ticket #9196 Signed-off-by: James Almer --- libavfilter/af_adelay.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/libavfilter/af_adelay.c b/libavfilter/af_adelay.c index 6ac81c2a3e..1229bf5bc7 100644 --- a/libavfilter/af_adelay.c +++ b/libavfilter/af_

[FFmpeg-devel] [PATCH] libavfilter: Spelling Correction in OpenVino Backend

2021-04-23 Thread shubhanshu02
Correct Spelling of the word `descibe` to `describe` in init_model_ov Signed-off-by: shubhanshu02 --- libavfilter/dnn/dnn_backend_openvino.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/dnn/dnn_backend_openvino.c b/libavfilter/dnn/dnn_backend_openvino.c index

Re: [FFmpeg-devel] [PATCH 7/9] avformat/id3v2: Check end for overflow in id3v2_parse()

2021-04-23 Thread Michael Niedermayer
On Thu, Apr 22, 2021 at 07:51:53PM -0300, James Almer wrote: > On 4/19/2021 3:23 PM, Michael Niedermayer wrote: > > Fixes: signed integer overflow: 9223372036840103978 + 67637280 cannot be > > represented in type 'long' > > Fixes: > > 33341/clusterfuzz-testcase-minimized-ffmpeg_dem_DSF_fuzzer-640

[FFmpeg-devel] [PATCH] tools/target_dec_fuzzer: Adjust threshold for libvorbis

2021-04-23 Thread Michael Niedermayer
Fixes: Timeout Fixes: 33513/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_LIBVORBIS_fuzzer-6481006635909120 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- tools/target_dec_fuzzer.c | 1 + 1 file cha

[FFmpeg-devel] [PATCH 2/2] avformat/westwoodaudenc Adds muxer for Westwood AUD format.

2021-04-23 Thread Aidan Richmond
Format is still used by modders of these old games. --- libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/westwood_audenc.c | 120 ++ 3 files changed, 122 insertions(+) create mode 100644 libavformat/westwood_audenc.c

[FFmpeg-devel] [PATCH 1/2] avcodec/adpcmenc Adds encoder for Westwood ADPCM.

2021-04-23 Thread Aidan Richmond
--- libavcodec/Makefile| 1 + libavcodec/adpcmenc.c | 32 ++-- libavcodec/allcodecs.c | 1 + 3 files changed, 32 insertions(+), 2 deletions(-) diff --git a/libavcodec/Makefile b/libavcodec/Makefile index 4a597f727a..fcddde459d 100644 --- a/libavcodec/Makefile ++