Re: [FFmpeg-devel] [PATCH] avformat/rawenc: remove singlejpeg muxer

2021-04-15 Thread Gyan Doshi
On 2021-04-15 09:51, Gyan Doshi wrote: On 2021-04-12 21:27, Gyan Doshi wrote: Ping. Plan to push in 24h. Pushed as 240aa70b798e99c15191d986261966bdbce59dba Regards, Gyan On 2021-04-10 20:00, Gyan Doshi wrote: It was added in 51ac1f616f due to ticket #4218, in order to show a singl

Re: [FFmpeg-devel] [PATCH V8 3/3] lavfi: add filter dnn_detect for object detection

2021-04-15 Thread Guo, Yejun
> -Original Message- > From: Guo, Yejun > Sent: 2021年4月13日 13:14 > To: ffmpeg-devel@ffmpeg.org > Cc: Guo, Yejun > Subject: [PATCH V8 3/3] lavfi: add filter dnn_detect for object detection > > Below are the example steps to do object detection: > > 1. download and install l_openvino_to

Re: [FFmpeg-devel] [PATCH 3/4] avformat/rmdec: Use 64bit for intermediate for DEINT_ID_INT4

2021-04-15 Thread Andreas Rheinhardt
Michael Niedermayer: > Fixes: runtime error: signed integer overflow: 65312 * 65535 cannot be > represented in type 'int' > Fixes: > 32832/clusterfuzz-testcase-minimized-ffmpeg_dem_RM_fuzzer-4817710040088576 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/mast

Re: [FFmpeg-devel] [PATCH 3/4] avformat/rmdec: Use 64bit for intermediate for DEINT_ID_INT4

2021-04-15 Thread James Almer
On 4/15/2021 5:44 PM, Michael Niedermayer wrote: Fixes: runtime error: signed integer overflow: 65312 * 65535 cannot be represented in type 'int' Fixes: 32832/clusterfuzz-testcase-minimized-ffmpeg_dem_RM_fuzzer-4817710040088576 Found-by: continuous fuzzing process https://github.com/google/os

[FFmpeg-devel] [PATCH 1/4] avformat/mov: check for pts overflow in mov_read_sidx()

2021-04-15 Thread Michael Niedermayer
Fixes: signed integer overflow: 9223372036846336888 + 4278255871 cannot be represented in type 'long' Fixes: 32782/clusterfuzz-testcase-minimized-ffmpeg_dem_MOV_fuzzer-6059216516284416 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off

[FFmpeg-devel] [PATCH 2/4] tools/target_dec_fuzzer: Adjust threshold for paf video

2021-04-15 Thread Michael Niedermayer
Fixes: Timeout (long -> 2sec) Fixes: 32790/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_PAF_VIDEO_fuzzer-5497584169910272 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- tools/target_dec_fuzzer.c |

[FFmpeg-devel] [PATCH 4/4] avcodec/faxcompr: Check remaining bits on error in decode_group3_1d_line()

2021-04-15 Thread Michael Niedermayer
Fixes: Timeout Fixes: 32886/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_TIFF_fuzzer-4779761466474496 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/faxcompr.c | 2 +- 1 file changed, 1

[FFmpeg-devel] [PATCH 3/4] avformat/rmdec: Use 64bit for intermediate for DEINT_ID_INT4

2021-04-15 Thread Michael Niedermayer
Fixes: runtime error: signed integer overflow: 65312 * 65535 cannot be represented in type 'int' Fixes: 32832/clusterfuzz-testcase-minimized-ffmpeg_dem_RM_fuzzer-4817710040088576 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: M

[FFmpeg-devel] [PATCH 08/10] avformat/id3v2: Don't reverse the order of id3v2 APICs

2021-04-15 Thread Andreas Rheinhardt
When parsing ID3v2 tags, special (non-text) metadata is not applied directly and unconditionally; instead it is stored in a linked list in which elements are prepended. When traversing the list to add APICs (or private tags) at the end, the order is reversed. The same also happens for chapters and

[FFmpeg-devel] [PATCH 09/10] avformat/webm_chunk: Use ff_stream_encode_params_copy()

2021-04-15 Thread Andreas Rheinhardt
It is simpler and more complete (e.g. it copies the framerate information which allows to write the default duration element). Signed-off-by: Andreas Rheinhardt --- libavformat/webm_chunk.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/libavformat/webm_chunk.c b/liba

[FFmpeg-devel] [PATCH 10/10] avformat/segment: Use ff_stream_encode_params_copy()

2021-04-15 Thread Andreas Rheinhardt
It is simpler and more complete (e.g. it copies the id). Signed-off-by: Andreas Rheinhardt --- I wonder whether we should use ff_stream_encode_params_copy() in the other muxers with submuxers, too. libavformat/segment.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git

[FFmpeg-devel] [PATCH 07/10] avformat/aiffenc: Avoid seek when writing id3v2 tags at the end

2021-04-15 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavformat/aiffenc.c | 27 +++ 1 file changed, 11 insertions(+), 16 deletions(-) diff --git a/libavformat/aiffenc.c b/libavformat/aiffenc.c index 1ecdb52ee7..725e06b3bd 100644 --- a/libavformat/aiffenc.c +++ b/libavformat/aiffenc.c @

[FFmpeg-devel] [PATCH 06/10] avformat/aiffenc: Remove always-false check

2021-04-15 Thread Andreas Rheinhardt
write_header() already checks that there are only video tracks besides the one audio track. Signed-off-by: Andreas Rheinhardt --- libavformat/aiffenc.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/libavformat/aiffenc.c b/libavformat/aiffenc.c index 06e475cddb..1ecdb52ee7 100644 --- a/li

[FFmpeg-devel] [PATCH 05/10] fate/id3v2: Add test for id3v2 chapters

2021-04-15 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- tests/fate/id3v2.mak | 5 +++ tests/ref/fate/id3v2-chapters | 66 +++ 2 files changed, 71 insertions(+) create mode 100644 tests/ref/fate/id3v2-chapters diff --git a/tests/fate/id3v2.mak b/tests/fate/id3v2.mak index

[FFmpeg-devel] [PATCH 04/10] fate/id3v2: Add a test for remuxing id3v2 private tags

2021-04-15 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- tests/fate/id3v2.mak| 12 +--- tests/ref/fate/id3v2-priv-remux | 18 ++ 2 files changed, 27 insertions(+), 3 deletions(-) create mode 100644 tests/ref/fate/id3v2-priv-remux diff --git a/tests/fate/id3v2.mak b/tests/fate/i

[FFmpeg-devel] [PATCH 03/10] fate/cover-art: Add test for writing id3v2 tags and apic with AIFF/MP3

2021-04-15 Thread Andreas Rheinhardt
Notice that the order of the APIC tracks is currently wrong. This is a superposition of two bugs: (i) Both muxers write the attached pictures in the order they arrive in the muxer and not in the stream_index order, leading to attached pictures that are copied being written earlier because their tim

[FFmpeg-devel] [PATCH 02/10] fate/mov: Add test for muxing cover images

2021-04-15 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- tests/fate/mov.mak | 12 -- tests/ref/fate/mov-cover-image | 43 ++ 2 files changed, 53 insertions(+), 2 deletions(-) create mode 100644 tests/ref/fate/mov-cover-image diff --git a/tests/fate/mov.mak b/tes

[FFmpeg-devel] [PATCH 01/10] fate/filter-video: Remove SAMPLES depedency from refcmp tests

2021-04-15 Thread Andreas Rheinhardt
They don't need it as they use the lavfi device to create their samples. Signed-off-by: Andreas Rheinhardt --- tests/fate/filter-video.mak | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/fate/filter-video.mak b/tests/fate/filter-video.mak index a0d645cc4a..75ca7

[FFmpeg-devel] [PATCH 1/2] avcodec/svq3: Remove unused function parameter

2021-04-15 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/svq3.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/libavcodec/svq3.c b/libavcodec/svq3.c index edc8aeacc6..0d108da06f 100644 --- a/libavcodec/svq3.c +++ b/libavcodec/svq3.c @@ -1319,7 +1319,7 @@ static av_cold int

[FFmpeg-devel] [PATCH 2/2] avcodec/svq3: Free array of frames in a loop

2021-04-15 Thread Andreas Rheinhardt
Avoids code duplication Signed-off-by: Andreas Rheinhardt --- libavcodec/svq3.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/libavcodec/svq3.c b/libavcodec/svq3.c index 0d108da06f..396555b337 100644 --- a/libavcodec/svq3.c +++ b/libavcodec/svq3.c @@ -1587,12 +15

[FFmpeg-devel] [PATCH] avcodec/ivi: Fix indentation

2021-04-15 Thread Andreas Rheinhardt
Also improve readability by keeping a pointer to the IVIBandDesc that is currently freed. Signed-off-by: Andreas Rheinhardt --- libavcodec/ivi.c | 26 ++ 1 file changed, 14 insertions(+), 12 deletions(-) diff --git a/libavcodec/ivi.c b/libavcodec/ivi.c index a5074e9980..

Re: [FFmpeg-devel] [PATCH 2/5] avcodec/flacenc: Remove always-true check

2021-04-15 Thread Michael Niedermayer
On Thu, Apr 15, 2021 at 04:03:38AM +0200, Andreas Rheinhardt wrote: > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/flacenc.c | 11 +-- > 1 file changed, 5 insertions(+), 6 deletions(-) LGTM thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB G

Re: [FFmpeg-devel] [PATCH v3 1/1] avformat/mpegtsenc: Write necessary descriptors into PMT for arib_caption muxing

2021-04-15 Thread zheng qian
On Fri, Apr 16, 2021 at 12:22 AM zheng qian wrote: > + > +// data_component_descriptor, defined in ARIB STD-B10, part > 2, 6.2.20 > +*q++ = 0xFD; // descriptor_tag: ARIB data coding type > descriptor > +*q++ = 3; // descriptor_length > +

Re: [FFmpeg-devel] [PATCH] avcodec/nellymoserenc: Fix segfault when using unsupported channels/rate

2021-04-15 Thread Michael Niedermayer
On Thu, Apr 15, 2021 at 03:52:31PM +0200, Andreas Rheinhardt wrote: > NellyMoserEncodeContext.avctx is only set in init after these checks, > yet it is used by encode_end(). > This is a regression since 0a56bfa71f751a2b25da8d060a019c1c75ca9d7b. > > Signed-off-by: Andreas Rheinhardt > --- > Sorry

[FFmpeg-devel] [PATCH v3 1/1] avformat/mpegtsenc: Write necessary descriptors into PMT for arib_caption muxing

2021-04-15 Thread zheng qian
Changes since v2: Generate stream_identifier and data_component_id from profile The recognization of ARIB STD-B24 caption has been introduced in commit a03885b, which is used as closed caption in Japanese / Brazilian Digital Television. But arib_caption stream copy is not working correctly caus

[FFmpeg-devel] [PATCH] JPEG-LS Decoder: Update

2021-04-15 Thread Spyros Theoharis
> - 8 up to 16 bits > - 444/422/420/411 > - fixed restart mechanism support > - RGB/YUV 444 images (via -rgb444 input option) This typically indicates that you should send four patches instead of one. [A] Is this necessary? It is difficult to split the patch to four individual patches si

[FFmpeg-devel] [PATCH] avcodec/nellymoserenc: Fix segfault when using unsupported channels/rate

2021-04-15 Thread Andreas Rheinhardt
NellyMoserEncodeContext.avctx is only set in init after these checks, yet it is used by encode_end(). This is a regression since 0a56bfa71f751a2b25da8d060a019c1c75ca9d7b. Signed-off-by: Andreas Rheinhardt --- Sorry for this. Will apply soon and backport. libavcodec/nellymoserenc.c | 6 ++ 1

[FFmpeg-devel] [PATCH 2/2] avformat/mpegts: add missing sample_rate value to Opus extradata

2021-04-15 Thread James Almer
Signed-off-by: James Almer --- libavformat/mpegts.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/mpegts.c b/libavformat/mpegts.c index 5343a14e38..1a2a9f8cd0 100644 --- a/libavformat/mpegts.c +++ b/libavformat/mpegts.c @@ -2026,6 +2026,7 @@ int ff_parse_mpeg2_descriptor(AVForma

Re: [FFmpeg-devel] [PATCH v4 1/2] lavc/aarch64: change h264pred_init structure

2021-04-15 Thread Martin Storsjö
On Thu, 15 Apr 2021, Mikhail Nitenko wrote: Change structure to allow the addition of other bit depths. --- libavcodec/aarch64/h264pred_init.c | 57 ++ 1 file changed, 27 insertions(+), 30 deletions(-) OK I guess. // Martin _

Re: [FFmpeg-devel] [PATCH v4 2/2] lavc/aarch64: add pred16x16 10-bit functions

2021-04-15 Thread Martin Storsjö
On Thu, 15 Apr 2021, Mikhail Nitenko wrote: Benchmarks: A53 A72 pred16x16_dc_10_c: 136.0 124.0 pred16x16_dc_10_neon: 121.2 106.0 pred16x16_horizontal_10_c: 155.073.2 pred16x16_horizontal_10_neon:82.267.7 pred16x16_top_dc_10_c:

[FFmpeg-devel] [PATCH v4 2/2] lavc/aarch64: add pred16x16 10-bit functions

2021-04-15 Thread Mikhail Nitenko
Benchmarks: A53 A72 pred16x16_dc_10_c: 136.0 124.0 pred16x16_dc_10_neon: 121.2 106.0 pred16x16_horizontal_10_c: 155.073.2 pred16x16_horizontal_10_neon:82.267.7 pred16x16_top_dc_10_c: 106.093.7 pred16x16_top_dc_10_neon

[FFmpeg-devel] [PATCH v4 1/2] lavc/aarch64: change h264pred_init structure

2021-04-15 Thread Mikhail Nitenko
Change structure to allow the addition of other bit depths. --- libavcodec/aarch64/h264pred_init.c | 57 ++ 1 file changed, 27 insertions(+), 30 deletions(-) diff --git a/libavcodec/aarch64/h264pred_init.c b/libavcodec/aarch64/h264pred_init.c index b144376f90..fc8989a

Re: [FFmpeg-devel] [PATCH 2/2] mov: Don't export unknown/unhandled metadata types as if they were UTF8

2021-04-15 Thread Martin Storsjö
On Thu, 1 Apr 2021, Martin Storsjö wrote: They can be other incompatible text encodings (such as UTF-16), or even binary data. --- libavformat/mov.c | 8 1 file changed, 8 insertions(+) Ping // Martin ___ ffmpeg-devel mailing list ffmpeg-dev

Re: [FFmpeg-devel] [PATCH 1/2] mov: Pick up "com.apple.quicktime.artwork" as cover art

2021-04-15 Thread Martin Storsjö
On Thu, 1 Apr 2021, Martin Storsjö wrote: --- libavformat/mov.c | 22 -- 1 file changed, 12 insertions(+), 10 deletions(-) Ping // Martin ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ff