Re: [FFmpeg-devel] [PATCH] avformat/mpegtsenc: Preserve disposition in the absence of language

2021-04-02 Thread stephen douglas
ISO 639 language descriptors used by DVB are the 3 charecter variants hence const char *language = lang && strlen(lang->value) >= 3 ? lang->value : default_language;should beconst char *language = lang && strlen(lang->value) > 3 ? lang->value : default_language; On Saturday, 3 April 2021, 06

Re: [FFmpeg-devel] 4.4 Release Name

2021-04-02 Thread Linjie Fu
On Sat, Apr 3, 2021 at 09:10 Zane van Iperen wrote: > > > On 2/4/21 8:34 pm, RADSL wrote: > > > > On 4/2/2021 2:59 AM, Michael Niedermayer wrote: > >> Hi all > >> > >> We still need to choose the name for 4.4 > >> previous unused suggestions where: > >> Von Neumann, Lorentz, Poincaré, Desitter, D

[FFmpeg-devel] [PATCH] avformat/mpegtsenc: Preserve disposition in the absence of language

2021-04-02 Thread Andreas Rheinhardt
Implements ticket #9113. Signed-off-by: Andreas Rheinhardt --- libavformat/mpegtsenc.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/libavformat/mpegtsenc.c b/libavformat/mpegtsenc.c index 35c835c484..dbd3bb148a 100644 --- a/libavformat/mpegtsenc.c +++ b/

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/adpcm_swf: remove memory allocation during trellis encoding

2021-04-02 Thread Zane van Iperen
On 1/4/21 9:34 pm, Zane van Iperen wrote: The block size is hardcoded, so the buffer size is always known. Statically allocate the buffer on the stack. Signed-off-by: Zane van Iperen --- libavcodec/adpcmenc.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) Ping on parts 2 a

Re: [FFmpeg-devel] 4.4 Release Name

2021-04-02 Thread Zane van Iperen
On 2/4/21 8:34 pm, RADSL wrote: On 4/2/2021 2:59 AM, Michael Niedermayer wrote: Hi all We still need to choose the name for 4.4 previous unused suggestions where: Von Neumann, Lorentz, Poincaré, Desitter, De Broglie, Gauss, Galois, Viterbi, Darwin Feel free to reply with name suggestions I

Re: [FFmpeg-devel] Hardware purchase request

2021-04-02 Thread Michael Niedermayer
On Mon, Mar 29, 2021 at 11:03:16PM +0300, Jan Ekström wrote: > On Tue, Mar 23, 2021 at 12:47 AM Lynne wrote: > > > > As discussed during the last developer meeting, I am in need of new > > hardware to > > work on Vulkan filtering, hwcontext, AV1 VAAPI decoding, new assembly and > > general develo

Re: [FFmpeg-devel] [RFC] CFHD

2021-04-02 Thread Michael Niedermayer
On Fri, Apr 02, 2021 at 10:22:27PM +0200, Paul B Mahol wrote: > On Fri, Apr 2, 2021 at 10:14 PM Paul B Mahol wrote: > > > > > > > On Fri, Apr 2, 2021 at 8:28 PM Michael Niedermayer > > wrote: > > > >> Hi all > >> > >> CFHD currently has even with all fixes (ignoring ones with objections) > >> ap

Re: [FFmpeg-devel] [RFC] CFHD

2021-04-02 Thread Paul B Mahol
On Fri, Apr 2, 2021 at 10:14 PM Paul B Mahol wrote: > > > On Fri, Apr 2, 2021 at 8:28 PM Michael Niedermayer > wrote: > >> Hi all >> >> CFHD currently has even with all fixes (ignoring ones with objections) >> applied a null pointer >> read and out of array write issue remaining. >> >> My patch

Re: [FFmpeg-devel] [RFC] CFHD

2021-04-02 Thread Paul B Mahol
On Fri, Apr 2, 2021 at 8:28 PM Michael Niedermayer wrote: > Hi all > > CFHD currently has even with all fixes (ignoring ones with objections) > applied a null pointer > read and out of array write issue remaining. > > My patch which makes the header parsing more restrictive has an objection > aga

[FFmpeg-devel] [PATCH] avformat/vividas: Fix crash when seeking without audio stream

2021-04-02 Thread Andreas Rheinhardt
The current code tries the access the codecpar of a nonexistent audio stream when seeking. Stop that. Fixes ticket #9121. Signed-off-by: Andreas Rheinhardt --- Will apply this soon. libavformat/vividas.c | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/li

[FFmpeg-devel] [PATCH] avformat/url: fix ff_make_absolute_url with Windows file paths

2021-04-02 Thread Marton Balint
Ugly, but a lot less broken than it was. Fixes ticket #9166. Signed-off-by: Marton Balint --- libavformat/url.c | 25 - 1 file changed, 24 insertions(+), 1 deletion(-) diff --git a/libavformat/url.c b/libavformat/url.c index 77d610d95f..90fd41e810 100644 --- a/libavform

[FFmpeg-devel] [RFC] CFHD

2021-04-02 Thread Michael Niedermayer
Hi all CFHD currently has even with all fixes (ignoring ones with objections) applied a null pointer read and out of array write issue remaining. My patch which makes the header parsing more restrictive has an objection against it. and the only other developer who recently worked on it stated th

Re: [FFmpeg-devel] [PATCH 221/223] avutil/cpu: Fix race condition in av_cpu_count()

2021-04-02 Thread Andreas Rheinhardt
On Thu, Dec 3, 2020 at 1:36 AM Andreas Rheinhardt < andreas.rheinha...@gmail.com> wrote: > av_cpu_count() intends to emit a debug message containing the number of > logical cores when called the first time. The check currently works with > a static volatile int; yet this does not help at all in ca

Re: [FFmpeg-devel] [PATCH 204/217] avcodec/ass_split: Don't presume strlen to be >= 2

2021-04-02 Thread Andreas Rheinhardt
On Wed, Dec 2, 2020 at 5:24 AM Andreas Rheinhardt < andreas.rheinha...@gmail.com> wrote: > Fixes potential heap-buffer-overflow. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/ass_split.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/ass_split.c b/

Re: [FFmpeg-devel] [PATCH 112/134] avcodec/flacenc: Fix memleak upon init error

2021-04-02 Thread Andreas Rheinhardt
On Mon, Nov 30, 2020 at 1:56 AM Andreas Rheinhardt < andreas.rheinha...@gmail.com> wrote: > An AVMD5 struct would leak if an error happened after its allocation. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/flacenc.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavcodec

Re: [FFmpeg-devel] [PATCH 68/72] avcodec/proresenc_anatoliy: Fix memleak upon init error

2021-04-02 Thread Andreas Rheinhardt
On Fri, Nov 27, 2020 at 6:47 PM Andreas Rheinhardt < andreas.rheinha...@gmail.com> wrote: > A buffer may leak in case of YUVA444P10 with dimensions that are not > both divisible by 16. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/proresenc_anatoliy.c | 2 ++ > 1 file changed, 2 inser

Re: [FFmpeg-devel] [PATCH 191/217] avcodec/binkaudio: Check return value of functions that can fail

2021-04-02 Thread Andreas Rheinhardt
On Wed, Dec 2, 2020 at 5:24 AM Andreas Rheinhardt < andreas.rheinha...@gmail.com> wrote: > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/binkaudio.c | 8 +--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/libavcodec/binkaudio.c b/libavcodec/binkaudio.c > index f25

Re: [FFmpeg-devel] [PATCH 190/217] avcodec/binkaudio: Fix memleak upon init failure

2021-04-02 Thread Andreas Rheinhardt
On Wed, Dec 2, 2020 at 5:24 AM Andreas Rheinhardt < andreas.rheinha...@gmail.com> wrote: > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/binkaudio.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/libavcodec/binkaudio.c b/libavcodec/binkaudio.c > index 7b5965ede1..f25aea0d64 10

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/av1_metadata_bsf: Check for the existence of units

2021-04-02 Thread James Almer
On 4/2/2021 12:39 PM, Andreas Rheinhardt wrote: Fixes a crash with ISOBMFF extradata containing no OBUs. Signed-off-by: Andreas Rheinhardt --- libavcodec/av1_metadata_bsf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/av1_metadata_bsf.c b/libavcodec/av1_meta

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/h264_metadata_bsf: Don't add AUD to extradata

2021-04-02 Thread James Almer
On 4/2/2021 12:38 PM, Andreas Rheinhardt wrote: This is a regression since switching to the generic CBS BSF code. Signed-off-by: Andreas Rheinhardt --- Will apply this patchset soon. libavcodec/h264_metadata_bsf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcode

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/cfhd: More strictly check tag order and multiplicity

2021-04-02 Thread Paul B Mahol
I do not have time or motivation to deal with this and similar issues. But applying band-aid solutions are not step forward. On Fri, Apr 2, 2021 at 12:53 AM Michael Niedermayer wrote: > On Fri, Apr 02, 2021 at 12:49:26AM +0200, Michael Niedermayer wrote: > > On Fri, Apr 02, 2021 at 12:25:53AM +

[FFmpeg-devel] [PATCH 2/2] avcodec/av1_metadata_bsf: Check for the existence of units

2021-04-02 Thread Andreas Rheinhardt
Fixes a crash with ISOBMFF extradata containing no OBUs. Signed-off-by: Andreas Rheinhardt --- libavcodec/av1_metadata_bsf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/av1_metadata_bsf.c b/libavcodec/av1_metadata_bsf.c index 8cafe461d1..328db5c0da 100644 --- a

[FFmpeg-devel] [PATCH 1/2] avcodec/h264_metadata_bsf: Don't add AUD to extradata

2021-04-02 Thread Andreas Rheinhardt
This is a regression since switching to the generic CBS BSF code. Signed-off-by: Andreas Rheinhardt --- Will apply this patchset soon. libavcodec/h264_metadata_bsf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/h264_metadata_bsf.c b/libavcodec/h264_metadata_bsf

Re: [FFmpeg-devel] 4.4 Release Name

2021-04-02 Thread Paul B Mahol
Name for new version should be: Mr. Miser. On Fri, Apr 2, 2021 at 3:49 PM Lynne wrote: > Apr 2, 2021, 12:34 by ad...@radsl.net: > > > > > On 4/2/2021 2:59 AM, Michael Niedermayer wrote: > > > >> Hi all > >> > >> We still need to choose the name for 4.4 > >> previous unused suggestions where: >

Re: [FFmpeg-devel] [PATCH 2/7] lavc/pngdec: perform APNG blending in-place

2021-04-02 Thread James Almer
On 4/2/2021 11:40 AM, Anton Khirnov wrote: Saves an allocation+free and two frame copies per each frame. --- libavcodec/pngdec.c | 51 + 1 file changed, 28 insertions(+), 23 deletions(-) diff --git a/libavcodec/pngdec.c b/libavcodec/pngdec.c index 6

[FFmpeg-devel] [PATCH 6/7] lavc/pngdec: improve chunk length check

2021-04-02 Thread Anton Khirnov
The length does not cover the chunk type or CRC. --- libavcodec/pngdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/pngdec.c b/libavcodec/pngdec.c index f3295688c6..0ff81d740c 100644 --- a/libavcodec/pngdec.c +++ b/libavcodec/pngdec.c @@ -1217,7 +1217,7 @@ stati

[FFmpeg-devel] [PATCH 7/7] lavc/pngdec: use a separate bytestream reader for each chunk

2021-04-02 Thread Anton Khirnov
This makes sure that reading a truncated chunk will never overflow into the following chunk. It also allows to remove many repeated lines skipping over the trailing crc checksum. --- libavcodec/pngdec.c | 166 +++- 1 file changed, 72 insertions(+), 94 deleti

[FFmpeg-devel] [PATCH 5/7] tests/fate: add tests for PNG side/meta data

2021-04-02 Thread Anton Khirnov
--- tests/fate/image.mak | 8 ++ tests/ref/fate/png-frame-metadata | 4 +++ tests/ref/fate/png-side-data | 46 +++ 3 files changed, 58 insertions(+) create mode 100644 tests/ref/fate/png-frame-metadata create mode 100644 tests/ref/fate/png-side

[FFmpeg-devel] [PATCH 4/7] lavc/pngdec: restructure exporting frame meta/side data

2021-04-02 Thread Anton Khirnov
This data cannot be stored in PNGDecContext.picture, because the corresponding chunks may be read after the call to ff_thread_finish_setup(), at which point modifying shared context data is a race. Store intermediate state in the context and then write it directly to the output frame. Fixes expor

[FFmpeg-devel] [PATCH 2/7] lavc/pngdec: perform APNG blending in-place

2021-04-02 Thread Anton Khirnov
Saves an allocation+free and two frame copies per each frame. --- libavcodec/pngdec.c | 51 + 1 file changed, 28 insertions(+), 23 deletions(-) diff --git a/libavcodec/pngdec.c b/libavcodec/pngdec.c index 63c22063d9..095e4e86c2 100644 --- a/libavcodec/p

[FFmpeg-devel] [PATCH 1/7] tests/fate: add a test for APNG_DISPOSE_OP_BACKGROUND

2021-04-02 Thread Anton Khirnov
--- tests/fate/apng.mak| 3 +++ tests/ref/fate/apng-dispose-background | 8 2 files changed, 11 insertions(+) create mode 100644 tests/ref/fate/apng-dispose-background diff --git a/tests/fate/apng.mak b/tests/fate/apng.mak index 0a5f542f19..901fc0a10e 100644 --- a/te

[FFmpeg-devel] [PATCH 3/7] lavc/pngdec: remove unnecessary context variables

2021-04-02 Thread Anton Khirnov
Do not store the image buffer pointer/linesize in the context, just access them directly from the frame. Stop assuming that linesize is the same for the current and last frame. --- libavcodec/pngdec.c | 36 +--- 1 file changed, 17 insertions(+), 19 deletions(-) dif

Re: [FFmpeg-devel] 4.4 Release Name

2021-04-02 Thread Lynne
Apr 2, 2021, 12:34 by ad...@radsl.net: > > On 4/2/2021 2:59 AM, Michael Niedermayer wrote: > >> Hi all >> >> We still need to choose the name for 4.4 >> previous unused suggestions where: >> Von Neumann, Lorentz, Poincaré, Desitter, De Broglie, Gauss, Galois, >> Viterbi, Darwin >> >> Feel free to

[FFmpeg-devel] [PATCH 2/2] avcodec/bsf: Simplify getting codec name

2021-04-02 Thread Andreas Rheinhardt
All codec ids on BSF whitelists have a codec descriptor, so one can just use avcodec_get_name() without worrying about the case of what happens when no codec descriptor is found. Signed-off-by: Andreas Rheinhardt --- libavcodec/bsf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) dif

[FFmpeg-devel] [PATCH 1/2] avcodec/bsf: Fix segfault when freeing half-allocated BSF

2021-04-02 Thread Andreas Rheinhardt
When allocating a BSF fails, it could happen that the BSF's close function has been called despite a failure to allocate the private data. Signed-off-by: Andreas Rheinhardt --- libavcodec/bsf.c | 39 --- 1 file changed, 20 insertions(+), 19 deletions(-) diff

Re: [FFmpeg-devel] 4.4 Release Name

2021-04-02 Thread Steven Liu
> 2021年4月2日 下午5:59,Michael Niedermayer 写道: > > Von Neumann Von Neumann lgtm :D Thanks Steven Liu ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email f

Re: [FFmpeg-devel] 4.4 Release Name

2021-04-02 Thread Reto Kromer
RADSL wrote: >On 4/2/2021 2:59 AM, Michael Niedermayer wrote: >> We still need to choose the name for 4.4 >> previous unused suggestions where: >> Von Neumann, Lorentz, Poincaré, Desitter, De Broglie, Gauss, >> Galois, Viterbi, Darwin Willem de Sitter? If so, then I would write it in two words.

Re: [FFmpeg-devel] 4.4 Release Name

2021-04-02 Thread Andreas Rheinhardt
Michael Niedermayer: > Hi all > > We still need to choose the name for 4.4 > previous unused suggestions where: > Von Neumann, Lorentz, Poincaré, Desitter, De Broglie, Gauss, Galois, Viterbi, > Darwin > Von Neumann sounds good to me. - Andreas ___ ff

Re: [FFmpeg-devel] 4.4 Release Name

2021-04-02 Thread Kieran Kunhya
I would like to suggest: https://en.m.wikipedia.org/wiki/Kizzmekia_Corbett Sent from my mobile device On Fri, 2 Apr 2021, 12:34 RADSL, wrote: > > On 4/2/2021 2:59 AM, Michael Niedermayer wrote: > > Hi all > > > > We still need to choose the name for 4.4 > > previous unused suggestions where: >

Re: [FFmpeg-devel] 4.4 Release Name

2021-04-02 Thread Gyan Doshi
On 2021-04-02 15:29, Michael Niedermayer wrote: Hi all We still need to choose the name for 4.4 previous unused suggestions where: Von Neumann, Lorentz, Poincaré, Desitter, De Broglie, Gauss, Galois, Viterbi, Darwin Feel free to reply with name suggestions If theres a tie then i will randoml

Re: [FFmpeg-devel] [PATCH 32/39] avcodec/msmpeg4enc: Don't use code for static init that can fail

2021-04-02 Thread Andreas Rheinhardt
On Thu, Dec 10, 2020 at 12:19 PM Andreas Rheinhardt < andreas.rheinha...@gmail.com> wrote: > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/mpegvideo_enc.c | 3 +-- > libavcodec/msmpeg4.h | 2 +- > libavcodec/msmpeg4enc.c| 23 --- > 3 files changed, 10 inser

Re: [FFmpeg-devel] 4.4 Release Name

2021-04-02 Thread RADSL
On 4/2/2021 2:59 AM, Michael Niedermayer wrote: Hi all We still need to choose the name for 4.4 previous unused suggestions where: Von Neumann, Lorentz, Poincaré, Desitter, De Broglie, Gauss, Galois, Viterbi, Darwin Feel free to reply with name suggestions If theres a tie then i will randomly

Re: [FFmpeg-devel] [PATCH 1/7] avformat/utils: Check allocations for failure

2021-04-02 Thread Andreas Rheinhardt
Andreas Rheinhardt: > There would be leaks in case of failure. > > Signed-off-by: Andreas Rheinhardt > --- > There is unfortunately more of this dynarray_add. > > libavformat/utils.c | 16 > 1 file changed, 12 insertions(+), 4 deletions(-) > > diff --git a/libavformat/utils.c

[FFmpeg-devel] 4.4 Release Name

2021-04-02 Thread Michael Niedermayer
Hi all We still need to choose the name for 4.4 previous unused suggestions where: Von Neumann, Lorentz, Poincaré, Desitter, De Broglie, Gauss, Galois, Viterbi, Darwin Feel free to reply with name suggestions If theres a tie then i will randomly pick amongth the tied, i assume all previous sugg