[FFmpeg-devel] [PATCH] modified frame timing, so that we can make sure that a frame is never forward in time with respect to the original one, when converting from VFR to CFR

2021-03-17 Thread Jerome Berclaz
--- fftools/ffmpeg.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c index 46bb014de8..8085442156 100644 --- a/fftools/ffmpeg.c +++ b/fftools/ffmpeg.c @@ -1238,8 +1238,9 @@ static void do_video_out(OutputFile *of, nb_fra

[FFmpeg-devel] [PATCH 6/6] avutil/adler32: Switch av_adler32_update() to size_t on bump

2021-03-17 Thread Andreas Rheinhardt
av_adler32_update() is used by av_hash_update() which will be switched to size_t at the next bump. So it also has to be made to use size_t. This is also necessary for framecrcenc.c, because the size of side data will become a size_t, too. Signed-off-by: Andreas Rheinhardt --- doc/APIchanges

[FFmpeg-devel] [PATCH v2 5/6] Fix printf specifiers for variables that will be switched to size_t

2021-03-17 Thread Andreas Rheinhardt
Also fix some minor stuff like switching loop counters to size_t. Signed-off-by: Andreas Rheinhardt --- Now using a special define for the specifier instead of lots of #if. libavcodec/decode.c| 3 ++- libavcodec/mpeg12enc.c | 4 ++-- libavcodec/mscc.c | 3 ++- libavfilte

Re: [FFmpeg-devel] [PATCH 2/5] avcodec/packet: Also change av_packet_pack/unpack_dictionary to size_t

2021-03-17 Thread James Almer
On 3/17/2021 8:59 PM, Andreas Rheinhardt wrote: These are auxiliary side-data functions, so they should have been switched to size_t in d79e0fe65c51491f9bf8a470bbe36fb09f3e1280, but this has been forgotten. Signed-off-by: Andreas Rheinhardt --- libavcodec/avpacket.c| 13 +

Re: [FFmpeg-devel] [PATCH 3/5] avcodec: Factor updating palette out

2021-03-17 Thread Andreas Rheinhardt
Andreas Rheinhardt: > James Almer: >> On 3/17/2021 8:59 PM, Andreas Rheinhardt wrote: >>> Because the properties of frames returned from ff_get/reget_buffer >>> are not reset at all, lots of returned frames had palette_has_changed >>> wrongly set to 1. This has been changed, too. >>> >>> Signed-off

[FFmpeg-devel] [PATCH] added parameter to dash encoder for start available time

2021-03-17 Thread Jerome Berclaz
--- libavformat/dashenc.c | 28 1 file changed, 20 insertions(+), 8 deletions(-) diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c index 24d43c34ea..81855ca8d0 100644 --- a/libavformat/dashenc.c +++ b/libavformat/dashenc.c @@ -149,6 +149,7 @@ typedef struct D

Re: [FFmpeg-devel] [PATCH 3/5] avcodec: Factor updating palette out

2021-03-17 Thread Andreas Rheinhardt
James Almer: > On 3/17/2021 8:59 PM, Andreas Rheinhardt wrote: >> Because the properties of frames returned from ff_get/reget_buffer >> are not reset at all, lots of returned frames had palette_has_changed >> wrongly set to 1. This has been changed, too. >> >> Signed-off-by: Andreas Rheinhardt >>

Re: [FFmpeg-devel] [PATCH 3/5] avcodec: Factor updating palette out

2021-03-17 Thread James Almer
On 3/17/2021 8:59 PM, Andreas Rheinhardt wrote: Because the properties of frames returned from ff_get/reget_buffer are not reset at all, lots of returned frames had palette_has_changed wrongly set to 1. This has been changed, too. Signed-off-by: Andreas Rheinhardt --- libavcodec/8bps.c

[FFmpeg-devel] [PATCH] avformat/rtpdec: attach producer reference time if available

2021-03-17 Thread Alok Priyadarshi
This produces true wallclock time at rtp source instead of the local wallclock time at rtp client. --- libavformat/internal.h | 8 libavformat/rtpdec.c | 10 ++ libavformat/utils.c| 9 + 3 files changed, 27 insertions(+) diff --git a/libavformat/internal.h b/libav

[FFmpeg-devel] [PATCH] avformat/utils: Preserve AV_PKT_FLAG_CORRUPT

2021-03-17 Thread Pavel Koshevoy
Preserve AV_PKT_FLAG_CORRUPT so the caller can decide whether to drop the packet. --- libavformat/utils.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavformat/utils.c b/libavformat/utils.c index a73f944e6e..0dc978e3d2 100644 --- a/libavformat/utils.c +++ b/libavformat/

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/adpcm_ima_cunning: support stereo

2021-03-17 Thread Zane van Iperen
On 16/3/21 4:22 pm, Zane van Iperen wrote: Changes the sample format to S16P, but was only ever mono so it affects nothing. Signed-off-by: Zane van Iperen --- libavcodec/adpcm.c | 11 +++ tests/fate/adpcm.mak | 18 +- 2 files changed, 16 insertions(+), 13 deletio

[FFmpeg-devel] [PATCH 5/5] Fix printf specifiers for variables that will be switched to size_t

2021-03-17 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- There is btw an instance in ffprobe where a variable will have to be switched to size_t when doing the bump. Hopefully it won't be forgotten. libavcodec/decode.c| 5 + libavcodec/mpeg12enc.c | 5 + libavcodec/mscc.c | 5 +

[FFmpeg-devel] [PATCH 4/5] avformat/matroskaenc: Check WebVTT subtitles for overflow

2021-03-17 Thread Andreas Rheinhardt
The destination here is an dynamic buffer which is restricted to INT_MAX, so check for that. Signed-off-by: Andreas Rheinhardt --- libavformat/matroskaenc.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/libavformat/matroskaenc.c b/libavformat/matroskaenc.c

[FFmpeg-devel] [PATCH 3/5] avcodec: Factor updating palette out

2021-03-17 Thread Andreas Rheinhardt
Because the properties of frames returned from ff_get/reget_buffer are not reset at all, lots of returned frames had palette_has_changed wrongly set to 1. This has been changed, too. Signed-off-by: Andreas Rheinhardt --- libavcodec/8bps.c | 11 +-- libavcodec/cinepak.c|

[FFmpeg-devel] [PATCH 2/5] avcodec/packet: Also change av_packet_pack/unpack_dictionary to size_t

2021-03-17 Thread Andreas Rheinhardt
These are auxiliary side-data functions, so they should have been switched to size_t in d79e0fe65c51491f9bf8a470bbe36fb09f3e1280, but this has been forgotten. Signed-off-by: Andreas Rheinhardt --- libavcodec/avpacket.c| 13 + libavcodec/packet.h | 10 +- liba

[FFmpeg-devel] [PATCH 1/5] avcodec/avpacket: Improve overflow checks when packing dictionary

2021-03-17 Thread Andreas Rheinhardt
Also avoid reallocations. Signed-off-by: Andreas Rheinhardt --- libavcodec/avpacket.c | 40 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/libavcodec/avpacket.c b/libavcodec/avpacket.c index 6840688b15..8f0850fb00 100644 --- a/libavcodec/

[FFmpeg-devel] [PATCH 3/3] avformat/mov: Check sample size for overflow in mov_parse_stsd_audio()

2021-03-17 Thread Michael Niedermayer
Fixes: signed integer overflow: 2 * 1914708000 cannot be represented in type 'int' Fixes: 31639/clusterfuzz-testcase-minimized-ffmpeg_dem_MOV_fuzzer-6303428239294464 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Nieder

[FFmpeg-devel] [PATCH 2/3] avcodec/sga: Check for array end in lzss_decompress()

2021-03-17 Thread Michael Niedermayer
Fixes: out of array access Fixes: 31640/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_SGA_fuzzer-5630883286614016 Fixes: 31619/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_SGA_fuzzer-5176667708456960 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/pr

[FFmpeg-devel] [PATCH 1/3] avformat/mpc8: check for size overflow in mpc8_get_chunk_header()

2021-03-17 Thread Michael Niedermayer
Fixes: signed integer overflow: -9223372036854775760 - 50 cannot be represented in type 'long' Fixes: 31673/clusterfuzz-testcase-minimized-ffmpeg_dem_MPC8_fuzzer-580134751869337 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Mi

[FFmpeg-devel] LZSS

2021-03-17 Thread Michael Niedermayer
Hi We seem to have 3 implementations of LZSS, i noticed while fixing a bug in one libavcodec/dsicinvideo.c:static int cin_decode_lzss(const unsigned char *src, int src_size, libavcodec/midivid.c:static ptrdiff_t lzss_uncompress(MidiVidContext *s, GetByteContext *gb, uint8_t *dst, unsigned int s

Re: [FFmpeg-devel] [PATCH 2/2] avformat: Make AVChapter.id an int64_t on next major bump

2021-03-17 Thread Andreas Rheinhardt
Andreas Rheinhardt: > 64 bits are needed in order to retain the uid values of Matroska > chapters; the type is kept signed because the semantics of NUT chapters > depend upon whether the id is > 0 or < 0. > > Signed-off-by: Andreas Rheinhardt > --- > Apologies for being so late. > > doc/APIchan

Re: [FFmpeg-devel] FFmpeg 4.4

2021-03-17 Thread James Almer
On 3/13/2021 8:29 AM, Michael Niedermayer wrote: On Wed, Mar 10, 2021 at 10:06:49AM -0300, James Almer wrote: On 3/10/2021 7:37 AM, Michael Niedermayer wrote: On Tue, Mar 09, 2021 at 05:55:55PM -0300, James Almer wrote: On 3/9/2021 5:47 PM, Michael Niedermayer wrote: Hi all I will branch rel

[FFmpeg-devel] [PATCH 3/3] avcodec/pngdec: Improve decoding text chunks

2021-03-17 Thread Andreas Rheinhardt
By checking immediately whether the first allocation was successfull one can simplify the cleanup code in case of errors. Signed-off-by: Andreas Rheinhardt --- libavcodec/pngdec.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/libavcodec/pngdec.c b/libavcodec/pngdec.c

[FFmpeg-devel] [PATCH 2/3] avcodec/pngdec: Don't use AVBPrint where inappropriate

2021-03-17 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/pngdec.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/libavcodec/pngdec.c b/libavcodec/pngdec.c index 6b9fdf5a22..21e79a24a7 100644 --- a/libavcodec/pngdec.c +++ b/libavcodec/pngdec.c @@ -1338,17 +1338,13 @@ stat

[FFmpeg-devel] [PATCH 1/3] avcodec/pngdec: Use internal AVBPrint string when parsing chunks

2021-03-17 Thread Andreas Rheinhardt
One saves an allocation in case the string fits into the buffer. Signed-off-by: Andreas Rheinhardt --- 5663301560d77486c7f7c03c1aa5f542fab23c24 caused a regression that makes some png files lose their metadata, because decode_idat_chunk() unrefs the frame that the metadata has been attached to. I

[FFmpeg-devel] [PATCH 2/2] avcodec: move core AVCodecContext functions from util.c to a new file

2021-03-17 Thread James Almer
Signed-off-by: James Almer --- Makefile | 2 +- libavcodec/Makefile | 1 + libavcodec/avcodec.c | 845 +++ libavcodec/utils.c | 828 +- 4 files changed, 850 insertions(+), 826 deletions(-) create m

[FFmpeg-devel] [PATCH 1/2] avcodec: move AVCodecParameters related functions from util.c to a new file

2021-03-17 Thread James Almer
Signed-off-by: James Almer --- libavcodec/Makefile| 1 + libavcodec/codec_par.c | 202 + libavcodec/utils.c | 173 --- 3 files changed, 203 insertions(+), 173 deletions(-) create mode 100644 libavcodec/codec_par.c

Re: [FFmpeg-devel] [PATCH] avcodec/libdavs2: unbreak compilation failure

2021-03-17 Thread Timo Rothenpieler
applied this one, since this broke my builds. smime.p7s Description: S/MIME Cryptographic Signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmp

Re: [FFmpeg-devel] [PATCH] avcodec: add Actimagine VX video decoder

2021-03-17 Thread Florian Nouwt
I found the origin of this color system. It was originally used with the first gba video paks (which used a way different codec). It is being described in this patent by Majesco (the 7th image, FIG. 4A and FIG. 4B): https://patents.google.com/patent/US7253819B1/en Later gba video paks seem to use t

Re: [FFmpeg-devel] [PATCH] avformat/mov: Handle when we have an mfra box but have not read the full sidx for a fragment

2021-03-17 Thread Derek Buitenhuis
On 15/03/2021 17:04, Derek Buitenhuis wrote: > Use the tfra timestamp if it is available and sidx timestamp is not. > > Fixes reading the entire file after seeking in a live-style DASH FMP4 > with an MFRA. > > This specifically fixes when use_mfra_for is set. > > Signed-off-by: Derek Buitenhuis

[FFmpeg-devel] [PATCH 1/2] avcodec/speedhq: Width < 8 is not supported

2021-03-17 Thread Michael Niedermayer
Fixes: out of array access Fixes: 31733/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_SPEEDHQ_fuzzer-4704307963363328 Fixes: 31736/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_SPEEDHQ_fuzzer-6190960292790272 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/m

[FFmpeg-devel] [PATCH 2/2] avformat/mov: Check offset addition for overflow

2021-03-17 Thread Michael Niedermayer
Fixes: signed integer overflow: 9223372036854775807 + 536870912 cannot be represented in type 'long' Fixes: 31678/clusterfuzz-testcase-minimized-ffmpeg_dem_MOV_fuzzer-5614204619980800 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-