Re: [FFmpeg-devel] [PATCH 1/5] avcodec/avcodec: Don't suggest calling deprecated avcodec_register_all()

2021-03-06 Thread myp...@gmail.com
Looks good On Sun, Mar 7, 2021 at 8:16 AM Andreas Rheinhardt wrote: > > Despite avcodec_register and avcodec_register_all being deprecated, > their documentation still said that one of them has to be called > before doing anything else. Clarify this confusing situation. > > Furthermore, don't use

Re: [FFmpeg-devel] [PATCH 7/7] avformat: add Changelog entry for librist and bump minor

2021-03-06 Thread Paul B Mahol
On Sun, Mar 7, 2021 at 1:57 AM James Almer wrote: > On 3/6/2021 9:51 PM, Paul B Mahol wrote: > > On Sun, Mar 7, 2021 at 1:35 AM Marton Balint wrote: > > > >> > >> > >> On Sun, 7 Mar 2021, Paul B Mahol wrote: > >> > >>> How you tested this? > >> > >> with the librist tools. > >> > >>> > >>> And w

Re: [FFmpeg-devel] [PATCH 7/7] avformat: add Changelog entry for librist and bump minor

2021-03-06 Thread James Almer
On 3/6/2021 9:51 PM, Paul B Mahol wrote: On Sun, Mar 7, 2021 at 1:35 AM Marton Balint wrote: On Sun, 7 Mar 2021, Paul B Mahol wrote: How you tested this? with the librist tools. And why you have not asked nicely before taking working on this? You wrote you have given up. It is your

Re: [FFmpeg-devel] [PATCH 7/7] avformat: add Changelog entry for librist and bump minor

2021-03-06 Thread Paul B Mahol
On Sun, Mar 7, 2021 at 1:35 AM Marton Balint wrote: > > > On Sun, 7 Mar 2021, Paul B Mahol wrote: > > > How you tested this? > > with the librist tools. > > > > > And why you have not asked nicely before taking working on this? > > You wrote you have given up. It is your behaviour which is not ve

Re: [FFmpeg-devel] [PATCH 7/7] avformat: add Changelog entry for librist and bump minor

2021-03-06 Thread Marton Balint
On Sun, 7 Mar 2021, Paul B Mahol wrote: How you tested this? with the librist tools. And why you have not asked nicely before taking working on this? You wrote you have given up. It is your behaviour which is not very nice. After your continuous ignorance of my requests, I try to help

Re: [FFmpeg-devel] [PATCH 5/5] doc/muxers.texi: Readd documentation removed accidentally

2021-03-06 Thread James Almer
On 3/6/2021 9:16 PM, Andreas Rheinhardt wrote: Happened in e7c04eaf50b4b50f2528ab2c69b76777a1862535. Signed-off-by: Andreas Rheinhardt --- doc/muxers.texi | 2 ++ 1 file changed, 2 insertions(+) diff --git a/doc/muxers.texi b/doc/muxers.texi index 1f9f2937f8..74833d7611 100644 --- a/doc/mux

[FFmpeg-devel] [PATCH 5/5] doc/muxers.texi: Readd documentation removed accidentally

2021-03-06 Thread Andreas Rheinhardt
Happened in e7c04eaf50b4b50f2528ab2c69b76777a1862535. Signed-off-by: Andreas Rheinhardt --- doc/muxers.texi | 2 ++ 1 file changed, 2 insertions(+) diff --git a/doc/muxers.texi b/doc/muxers.texi index 1f9f2937f8..74833d7611 100644 --- a/doc/muxers.texi +++ b/doc/muxers.texi @@ -242,6 +242,8 @@

[FFmpeg-devel] [PATCH 4/5] avfilter/buffersink: Postpone removal of av_[a]buffersink_params_alloc

2021-03-06 Thread Andreas Rheinhardt
They have been deprecated in 61097535cdaa91fea0d62c567b3af02a940f6c2d, yet this was less than two years ago. Removing them will therefore have to wait. Signed-off-by: Andreas Rheinhardt --- libavfilter/buffersink.c | 2 +- libavfilter/buffersink.h | 2 +- libavfilter/version.h| 3 +++ 3 file

[FFmpeg-devel] [PATCH 3/5] avfilter/avfilter: Remove avfilter_link_set_closed() on bump

2021-03-06 Thread Andreas Rheinhardt
Deprecated in 39a09e995d32d16e4f8c87a6ff5273cb9d98146e. Signed-off-by: Andreas Rheinhardt --- libavfilter/avfilter.c | 3 ++- libavfilter/avfilter.h | 4 ++-- libavfilter/version.h | 3 +++ 3 files changed, 7 insertions(+), 3 deletions(-) diff --git a/libavfilter/avfilter.c b/libavfilter/avfil

[FFmpeg-devel] [PATCH 2/5] avcodec/codec: Update init_static_data doxygen

2021-03-06 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/codec.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/codec.h b/libavcodec/codec.h index 0ccbf0eb19..d3547055e6 100644 --- a/libavcodec/codec.h +++ b/libavcodec/codec.h @@ -259,7 +259,7 @@ typedef struct AVCodec {

[FFmpeg-devel] [PATCH 1/5] avcodec/avcodec: Don't suggest calling deprecated avcodec_register_all()

2021-03-06 Thread Andreas Rheinhardt
Despite avcodec_register and avcodec_register_all being deprecated, their documentation still said that one of them has to be called before doing anything else. Clarify this confusing situation. Furthermore, don't use avcodec_register_all in sample code for a non-deprecated function. Signed-off-b

Re: [FFmpeg-devel] [PATCH 7/7] avformat: add Changelog entry for librist and bump minor

2021-03-06 Thread James Almer
On 3/6/2021 8:47 PM, Paul B Mahol wrote: How you tested this? And why you have not asked nicely before taking working on this? He took your patch, included it without changes and with proper authorship, and worked on top of it. It's no different than sending only patches 2 to 6 after you com

Re: [FFmpeg-devel] [PATCH 7/7] avformat: add Changelog entry for librist and bump minor

2021-03-06 Thread Paul B Mahol
How you tested this? And why you have not asked nicely before taking working on this? On Sun, Mar 7, 2021 at 12:28 AM Marton Balint wrote: > Signed-off-by: Marton Balint > --- > Changelog | 1 + > libavformat/version.h | 2 +- > 2 files changed, 2 insertions(+), 1 deletion(-) > >

[FFmpeg-devel] [PATCH 7/7] avformat: add Changelog entry for librist and bump minor

2021-03-06 Thread Marton Balint
Signed-off-by: Marton Balint --- Changelog | 1 + libavformat/version.h | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/Changelog b/Changelog index b28a8c59f1..b4d3258be7 100644 --- a/Changelog +++ b/Changelog @@ -81,6 +81,7 @@ version : - TTML subtitle encoder

[FFmpeg-devel] [PATCH 6/7] avformat/librist: clarify and limit buffer_size

2021-03-06 Thread Marton Balint
As suggested by librist developers. Signed-off-by: Marton Balint --- doc/protocols.texi| 4 +++- libavformat/librist.c | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/doc/protocols.texi b/doc/protocols.texi index 45ef946efd..d6ecbd5bac 100644 --- a/doc/protocols.texi +

[FFmpeg-devel] [PATCH 5/7] avformat/librist: increase default loglevel

2021-03-06 Thread Marton Balint
Also remove AV_LOG_SIMULATE from the list as it is not used directly, and do not use panic level on unknown loglevel, but make them warn. Also fix mapping of NOTICE/INFO/VERBOSE and add documentation about when the option should actually be used. Signed-off-by: Marton Balint --- doc/protocols.te

[FFmpeg-devel] [PATCH 4/7] avformat/librist: simplify secret strlcpy

2021-03-06 Thread Marton Balint
Signed-off-by: Marton Balint --- libavformat/librist.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/librist.c b/libavformat/librist.c index 3f74521cb4..2fb3162f86 100644 --- a/libavformat/librist.c +++ b/libavformat/librist.c @@ -158,7 +158,7 @@ static int libri

[FFmpeg-devel] [PATCH 3/7] avformat/librist: make packet size adjustable for writing, fix it for reading

2021-03-06 Thread Marton Balint
Maximum packet size is 1 (RIST_MAX_PACKET_SIZE, which is unfortunately private) minus the RIST protocol overhead which is 28 bytes for the unencrypted case, 36 for the encrypted case. Signed-off-by: Marton Balint --- doc/protocols.texi| 3 +++ libavformat/librist.c | 17

[FFmpeg-devel] [PATCH 2/7] avformat/librist: rework librist_read

2021-03-06 Thread Marton Balint
Queue tracking makes no difference so remove it, return EAGAIN of no data is available and rist data block needs to be freed even for zero sized packets. Signed-off-by: Marton Balint --- libavformat/librist.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/liba

[FFmpeg-devel] [PATCH 1/7] libavformat: add librist protocol

2021-03-06 Thread Marton Balint
From: Paul B Mahol This work is sponsored by Open Broadcast Systems. Signed-off-by: Paul B Mahol --- configure | 5 + doc/protocols.texi | 29 + libavformat/Makefile| 1 + libavformat/librist.c | 236 libavformat/protoc

Re: [FFmpeg-devel] [PATCH 45/48] doc/examples/vaapi_encode: use av_packet_alloc() to allocate packets

2021-03-06 Thread James Almer
On 3/6/2021 6:35 PM, Michael Niedermayer wrote: On Fri, Mar 05, 2021 at 01:33:36PM -0300, James Almer wrote: Signed-off-by: James Almer --- doc/examples/vaapi_encode.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/doc/examples/vaapi_encode.c b/doc/examp

Re: [FFmpeg-devel] [PATCH 45/48] doc/examples/vaapi_encode: use av_packet_alloc() to allocate packets

2021-03-06 Thread Michael Niedermayer
On Fri, Mar 05, 2021 at 01:33:36PM -0300, James Almer wrote: > Signed-off-by: James Almer > --- > doc/examples/vaapi_encode.c | 16 > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/doc/examples/vaapi_encode.c b/doc/examples/vaapi_encode.c > index 707939db37..66

[FFmpeg-devel] [PATCH 2/2] avformat/sbgdec: Check for overflow in last loop in expand_timestamps()

2021-03-06 Thread Michael Niedermayer
Fixes: signed integer overflow: 9223372036854775807 + 864 cannot be represented in type 'long' Fixes: 31003/clusterfuzz-testcase-minimized-ffmpeg_dem_SBG_fuzzer-6256298771480576 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-of

[FFmpeg-devel] [PATCH 1/2] avcodec/ffwavesynth: Avoid signed integer overflow in phi_at()

2021-03-06 Thread Michael Niedermayer
Fixes: signed integer overflow: 2314885530818453536 - -9070214327174160352 cannot be represented in type 'long' Fixes: 31000/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_FFWAVESYNTH_fuzzer-6558389742206976 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/

[FFmpeg-devel] [PATCH 9/9] avutil: use the buffer_size_t typedef where required

2021-03-06 Thread James Almer
Signed-off-by: James Almer --- libavutil/hwcontext_cuda.c| 2 +- libavutil/hwcontext_d3d11va.c | 2 +- libavutil/hwcontext_dxva2.c | 2 +- libavutil/hwcontext_opencl.c | 2 +- libavutil/hwcontext_qsv.c | 2 +- libavutil/hwcontext_vaapi.c | 2 +- libavutil/hwcontext_vdpau.c | 2 +-

[FFmpeg-devel] [PATCH 8/9] avfilter: use the buffer_size_t typedef where required

2021-03-06 Thread James Almer
Signed-off-by: James Almer --- libavfilter/framepool.c | 4 ++-- libavfilter/framepool.h | 5 +++-- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/libavfilter/framepool.c b/libavfilter/framepool.c index 3b178cebb8..dab8891524 100644 --- a/libavfilter/framepool.c +++ b/libavfilter/

[FFmpeg-devel] [PATCH 7/9] avdevice: use the buffer_size_t typedef where required

2021-03-06 Thread James Almer
Signed-off-by: James Almer --- libavdevice/decklink_dec.cpp | 2 +- libavdevice/decklink_enc.cpp | 3 ++- libavdevice/xcbgrab.c| 2 +- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/libavdevice/decklink_dec.cpp b/libavdevice/decklink_dec.cpp index 4f8103e614..6c0a338fca 10

[FFmpeg-devel] [PATCH 6/9] avformat: use the buffer_size_t typedef where required

2021-03-06 Thread James Almer
Signed-off-by: James Almer --- libavformat/adtsenc.c | 3 ++- libavformat/apngenc.c | 2 +- libavformat/dashenc.c | 5 +++-- libavformat/flacenc.c | 2 +- libavformat/flvenc.c | 2 +- libavformat/latmenc.c | 3 ++- libavformat/matroskaenc.c | 9 ++--- libavform

[FFmpeg-devel] [PATCH 5/9] avcodec: use the buffer_size_t typedef where required

2021-03-06 Thread James Almer
Signed-off-by: James Almer --- libavcodec/8bps.c | 2 +- libavcodec/aacdec_template.c | 4 ++-- libavcodec/adxdec.c| 2 +- libavcodec/audiotoolboxdec.c | 2 +- libavcodec/avpacket.c | 6 +++--- libavcodec/cbs_bsf.c | 2 +- libavcodec/cinepak.c

[FFmpeg-devel] [PATCH 4/9 v2] avformat/utils: change AVStream side data related public function and struct size types to size_t

2021-03-06 Thread James Almer
av_stream_add_side_data() already defines size as a size_t, so this makes it consistent across all side data functions. Signed-off-by: James Almer --- Changes since v1 is using the buffer_size_t typedef. doc/APIchanges | 4 libavformat/avformat.h | 8 libavformat/utils.c

[FFmpeg-devel] [PATCH 3/9 v2] avcodec/packet: change side data related public function and struct size types to size_t

2021-03-06 Thread James Almer
av_packet_add_side_data() already defines size as a size_t, so this makes it consistent across all side data functions. Signed-off-by: James Almer --- Changes since v1 is using the buffer_size_t typedef. doc/APIchanges| 4 libavcodec/avpacket.c | 10 +++--- libavcodec/packet.h

[FFmpeg-devel] [PATCH 2/9 v3] avutil/frame: change av_frame_new_side_data() size parameter type to size_t

2021-03-06 Thread James Almer
Signed-off-by: James Almer --- Changes since v2 is using the buffer_size_t typedef. doc/APIchanges| 6 +++--- libavutil/frame.c | 2 +- libavutil/frame.h | 8 3 files changed, 12 insertions(+), 4 deletions(-) diff --git a/doc/APIchanges b/doc/APIchanges index 7abc320db2..d2d107de78

[FFmpeg-devel] [PATCH 1/9 v3] avutil/buffer: change public function and struct size parameter types to size_t

2021-03-06 Thread James Almer
Signed-off-by: James Almer --- Changes since v2 is the addition of the buffer_size_t typedef to reduce the amount of ifdeffery required to adapt our code. doc/APIchanges | 4 libavutil/buffer.c | 14 +++--- libavutil/buffer.h | 32

Re: [FFmpeg-devel] [PATCH] avformat/http: Fix leak when using deprecated option

2021-03-06 Thread Marton Balint
On Sat, 6 Mar 2021, Andreas Rheinhardt wrote: Marton Balint: On Sat, 6 Mar 2021, Andreas Rheinhardt wrote: When the deprecated option "user-agent" was set to something different than its default value, said option would always precede and overwrite the ordinary user_agent option (regardle

Re: [FFmpeg-devel] [PATCH] avformat/http: Fix leak when using deprecated option

2021-03-06 Thread Andreas Rheinhardt
Marton Balint: > > > On Sat, 6 Mar 2021, Andreas Rheinhardt wrote: > >> When the deprecated option "user-agent" was set to something different >> than its default value, said option would always precede and overwrite >> the ordinary user_agent option (regardless of whether it was explicitly >> s

Re: [FFmpeg-devel] [PATCH] avformat/http: Fix leak when using deprecated option

2021-03-06 Thread Andreas Rheinhardt
James Almer: > On 3/6/2021 1:57 PM, Marton Balint wrote: >> >> >> On Sat, 6 Mar 2021, Andreas Rheinhardt wrote: >> >>> When the deprecated option "user-agent" was set to something different >>> than its default value, said option would always precede and overwrite >>> the ordinary user_agent option

Re: [FFmpeg-devel] [PATCH] avformat/http: Fix leak when using deprecated option

2021-03-06 Thread James Almer
On 3/6/2021 1:57 PM, Marton Balint wrote: On Sat, 6 Mar 2021, Andreas Rheinhardt wrote: When the deprecated option "user-agent" was set to something different than its default value, said option would always precede and overwrite the ordinary user_agent option (regardless of whether it was ex

Re: [FFmpeg-devel] [PATCH v2 2/5] avdevice/alsa_dec: make sure we have enough data in non-blocking mode

2021-03-06 Thread Marton Balint
On Mon, 1 Mar 2021, Marton Balint wrote: Otherwise we might return 1-2 samples per packet if av_read_frame() call rate is only sligthly less than the stream sample rate. Ping for this and the rest of the series. Note that the approach in this patch makes 1/5 unneeded because constant frame

Re: [FFmpeg-devel] [PATCH] avformat/http: Fix leak when using deprecated option

2021-03-06 Thread Marton Balint
On Sat, 6 Mar 2021, Andreas Rheinhardt wrote: When the deprecated option "user-agent" was set to something different than its default value, said option would always precede and overwrite the ordinary user_agent option (regardless of whether it was explicitly set) which leads to a leak of the

Re: [FFmpeg-devel] Custom allocation functions

2021-03-06 Thread Nicolas George
Martijn Otto (12021-03-05): > Hello all, > > I have made some changes to get custom allocation functions in ffmpeg. > This is useful to me, as the software I work with easily runs into > congestion on memory allocations in certain cases. > > I hope it is useful to others as well. It would be nice

Re: [FFmpeg-devel] Apple M1 Mac Mini Access

2021-03-06 Thread Kieran Kunhya
On Sun, 28 Feb 2021 at 13:30, Kieran Kunhya wrote: > Hi, > > Please email me privately with your ssh public key and desired username if > you would like access to the second Apple M1 Mac Mini which we bought for > development purposes. > > Regards, > Kieran Kunhya > Everyone who has requested ac

[FFmpeg-devel] [PATCH] avformat/http: Fix leak when using deprecated option

2021-03-06 Thread Andreas Rheinhardt
When the deprecated option "user-agent" was set to something different than its default value, said option would always precede and overwrite the ordinary user_agent option (regardless of whether it was explicitly set) which leads to a leak of the user_agent option (which has a default value, so th

Re: [FFmpeg-devel] Custom allocation functions

2021-03-06 Thread Carl Eugen Hoyos
Am Fr., 5. März 2021 um 15:45 Uhr schrieb Martijn Otto : > I have made some changes to get custom allocation functions in ffmpeg. > This is useful to me, as the software I work with easily runs into > congestion on memory allocations in certain cases. I thought the dynamic linker allows you to re

Re: [FFmpeg-devel] [PATCH] configure: Fix bashism in openal check. (was: [PATCH] Bugfix for #9135)

2021-03-06 Thread Carl Eugen Hoyos
Am Mi., 3. März 2021 um 00:01 Uhr schrieb Peter White : > Please see the attachment. I'll push this if there are no objections. Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubs

Re: [FFmpeg-devel] [PATCH] mov.c log qt ref extenal essence metadata

2021-03-06 Thread emcodem
Am 2021-03-06 10:48, schrieb Jan Ekström: On Sat, Mar 6, 2021 at 10:38 AM emcodem wrote: --- libavformat/mov.c | 8 1 file changed, 8 insertions(+) In quicktime reference files, exposing the parsed info for external essences location can be very handy for users Unfortunately, a

[FFmpeg-devel] [PATCH] avcodec/libxvid: Remove unnecessary header

2021-03-06 Thread Andreas Rheinhardt
Forgotten in a1c6fc773f941fd6a6ef3f12f102a7902ae69453. Signed-off-by: Andreas Rheinhardt --- Will apply this soon. libavcodec/libxvid.c | 1 - libavcodec/libxvid.h | 36 libavcodec/mpegvideo_enc.c | 1 - 3 files changed, 38 deletions(-) delete

Re: [FFmpeg-devel] [PATCH 2/2] avfilter: add msad video filter

2021-03-06 Thread Paul B Mahol
will apply this soon ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] mov.c log qt ref extenal essence metadata

2021-03-06 Thread Jan Ekström
On Sat, Mar 6, 2021 at 10:38 AM emcodem wrote: > > --- > libavformat/mov.c | 8 > 1 file changed, 8 insertions(+) > > In quicktime reference files, exposing the parsed info for external essences > location can be very handy for users > Unfortunately, as per the discussion we had yester

[FFmpeg-devel] [PATCH] avcodec/avcodec: Don't use deprecated function in sample code

2021-03-06 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- Will push this soon. libavcodec/avcodec.h | 1 - 1 file changed, 1 deletion(-) diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h index 309d9965be..8c1aee3db3 100644 --- a/libavcodec/avcodec.h +++ b/libavcodec/avcodec.h @@ -2843,7 +2843,6 @@ int avcod

Re: [FFmpeg-devel] [PATCH 48/48] fftools/ffmpeg: use av_packet_alloc() to allocate packets

2021-03-06 Thread Andreas Rheinhardt
Jack Waller: > On Sat, Mar 6, 2021 at 12:44 AM James Almer wrote: > >> Signed-off-by: James Almer >> --- >> fftools/ffmpeg.c | 318 +++ >> fftools/ffmpeg.h | 4 + >> fftools/ffmpeg_opt.c | 5 +- >> 3 files changed, 177 insertions(+), 150 delet

[FFmpeg-devel] [PATCH] mov.c log qt ref extenal essence metadata

2021-03-06 Thread emcodem
--- libavformat/mov.c | 8 1 file changed, 8 insertions(+) In quicktime reference files, exposing the parsed info for external essences location can be very handy for users diff --git a/libavformat/mov.c b/libavformat/mov.c index 1c07cff6b5..e9625c0cf9 100644 --- a/libavformat/mov.c ++