Re: [FFmpeg-devel] [PATCH] avutil/tx: Fix declaration after statement

2021-02-21 Thread Paul B Mahol
lgtm ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH V3 3/3] libavfilter: add filter dnn_detect for object detection

2021-02-21 Thread Guo, Yejun
Below are the example steps to do object detection: 1. download and install l_openvino_toolkit_p_2021.1.110.tgz from https://software.intel.com/content/www/us/en/develop/tools/openvino-toolkit/download.html or, we can get source code (tag 2021.1), build and install. 2. export LD_LIBRARY_PATH wit

[FFmpeg-devel] [PATCH V3 2/3] libavfilter/buffersink.c: unref private_ref when frame leaves libavfilter

2021-02-21 Thread Guo, Yejun
--- libavfilter/buffersink.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavfilter/buffersink.c b/libavfilter/buffersink.c index 58848941d4..837a6e9e82 100644 --- a/libavfilter/buffersink.c +++ b/libavfilter/buffersink.c @@ -98,6 +98,7 @@ static int return_or_keep_frame(BufferSinkContext

[FFmpeg-devel] [PATCH V3 1/3] libavfilter/bbox.h: add BoundingBoxHeader and BoundingBox

2021-02-21 Thread Guo, Yejun
They will be used for filters such as detect and classify. Signed-off-by: Guo, Yejun --- libavfilter/bbox.h | 45 + 1 file changed, 45 insertions(+) diff --git a/libavfilter/bbox.h b/libavfilter/bbox.h index 116158d59e..7c63dfa727 100644 --- a/libavfi

[FFmpeg-devel] [PATCH] avutil/tx: Fix declaration after statement

2021-02-21 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavutil/tx.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/libavutil/tx.c b/libavutil/tx.c index 49d5e125ae..4a5ec6975f 100644 --- a/libavutil/tx.c +++ b/libavutil/tx.c @@ -115,14 +115,13 @@ int ff_tx_gen_ptwo_inplace_revtab_idx(A

Re: [FFmpeg-devel] [PATCH 11/19] avformat/matroskadec: Support FlagOriginal

2021-02-21 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Needs a CountedElement in order to distinguish the case of the element > not being present and the element being present with a value of zero. > > Signed-off-by: Andreas Rheinhardt > --- > libavformat/matroska.h| 1 + > libavformat/matroskadec.c | 7 ++- > 2 files c

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/adpcm_ima_apm: remove old extradata format

2021-02-21 Thread Zane van Iperen
On 22/2/21 1:05 pm, Andreas Rheinhardt wrote: Zane van Iperen: Was added in error very early on, passing in only the required fields. Later, the muxer and demuxer were changed to pass the entire APMState struct as extradata. Technically a breaking change, but this was only around for a *very*

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/adpcm_ima_apm: remove old extradata format

2021-02-21 Thread Andreas Rheinhardt
Zane van Iperen: > Was added in error very early on, passing in only the required fields. > Later, the muxer and demuxer were changed to pass the entire APMState > struct as extradata. > > Technically a breaking change, but this was only around for a *very* short > time before it was updated, >

[FFmpeg-devel] [PATCH 2/2] avcodec/adpcm_ima_apm: cosmetics

2021-02-21 Thread Zane van Iperen
Signed-off-by: Zane van Iperen --- libavcodec/adpcm.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/libavcodec/adpcm.c b/libavcodec/adpcm.c index e38e81310c..3f4dccf124 100644 --- a/libavcodec/adpcm.c +++ b/libavcodec/adpcm.c @@ -165,13 +165,11 @@ static av_cold

[FFmpeg-devel] [PATCH 1/2] avcodec/adpcm_ima_apm: remove old extradata format

2021-02-21 Thread Zane van Iperen
Was added in error very early on, passing in only the required fields. Later, the muxer and demuxer were changed to pass the entire APMState struct as extradata. Technically a breaking change, but this was only around for a *very* short time before it was updated, Signed-off-by: Zane van Iperen

Re: [FFmpeg-devel] [PATCH 01/29] configure, libavcodec/Makefile: Remove spurious CAF demuxer dependencies

2021-02-21 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Forgotten in 604fbb3132e88727e496c96c92cfe02748c25a1a. > > Signed-off-by: Andreas Rheinhardt > --- > configure | 2 +- > libavcodec/Makefile | 1 - > 2 files changed, 1 insertion(+), 2 deletions(-) > > diff --git a/configure b/configure > index a76c2ec4ae..c28a74

Re: [FFmpeg-devel] [PATCH v2 18/19] fate/matroska: Test remuxing tracks for hearing/visually impaired

2021-02-21 Thread Andreas Rheinhardt
Carl Eugen Hoyos: > Am Sa., 20. Feb. 2021 um 17:00 Uhr schrieb Andreas Rheinhardt > : >> >> The tests also test the other dispositions: commentary, descriptions >> as well as dub and original language. >> >> Signed-off-by: Andreas Rheinhardt >> --- >> The first version of the matroska-wtv-remux te

Re: [FFmpeg-devel] [PATCH 2/2] avformat/microdvddec: use 64bit for durations

2021-02-21 Thread Michael Niedermayer
On Fri, Dec 11, 2020 at 11:00:02AM +0100, Michael Niedermayer wrote: > Fixes: signed integer overflow: 7 - -2147483647 cannot be represented in type > 'int' > Fixes: > 28036/clusterfuzz-testcase-minimized-ffmpeg_dem_MICRODVD_fuzzer-5171698751766528 > > Found-by: continuous fuzzing process > htt

Re: [FFmpeg-devel] [PATCH v2] avcodec: add a get_encoder_buffer() callback to AVCodecContext

2021-02-21 Thread Lynne
Feb 21, 2021, 22:04 by jamr...@gmail.com: > On 2/21/2021 5:29 PM, Mark Thompson wrote: > >> On 21/02/2021 20:00, James Almer wrote: >> >>> On 2/21/2021 4:13 PM, Mark Thompson wrote: >>> On 21/02/2021 17:35, James Almer wrote: > This callback is functionally the same as get_buffer2()

Re: [FFmpeg-devel] [PATCH v2] avcodec: add a get_encoder_buffer() callback to AVCodecContext

2021-02-21 Thread James Almer
On 2/21/2021 5:29 PM, Mark Thompson wrote: On 21/02/2021 20:00, James Almer wrote: On 2/21/2021 4:13 PM, Mark Thompson wrote: On 21/02/2021 17:35, James Almer wrote: This callback is functionally the same as get_buffer2() is for decoders, and implements for the new encode API the functionality

Re: [FFmpeg-devel] [PATCH 3/2] doc/encoders: Add documentation for the GIF encoder

2021-02-21 Thread Moritz Barsnick
On Sun, Feb 21, 2021 at 13:12:27 +, Derek Buitenhuis wrote: > +@item global_palette @var{integer} > +Writes a palette to the global GIF header whee feasible. ^ where Moritz ___ ffmpeg-devel mailing list ff

Re: [FFmpeg-devel] [PATCH] cbs_sei: Detect payload overflows when reading SEI messages

2021-02-21 Thread Michael Niedermayer
On Tue, Feb 02, 2021 at 08:58:11PM +, Mark Thompson wrote: > The top-level GetBitContext is sized for the whole NAL unit, so it fails > to detect overflows where a payload continues into the following message. > To fix that, we make a new context on the stack for reading each payload. > --- > O

Re: [FFmpeg-devel] [PATCH] cbs_h265: Detect more reference combinations which would overflow the DPB

2021-02-21 Thread Michael Niedermayer
On Wed, Feb 03, 2021 at 09:34:07PM +, Mark Thompson wrote: > In total, the number of short term references (from the selected short > term ref pic set), the number of long term references (combining both the > used candidates from the SPS and those defined in the slice header) and > the number

Re: [FFmpeg-devel] [PATCH v2] avcodec: add a get_encoder_buffer() callback to AVCodecContext

2021-02-21 Thread Mark Thompson
On 21/02/2021 20:00, James Almer wrote: On 2/21/2021 4:13 PM, Mark Thompson wrote: On 21/02/2021 17:35, James Almer wrote: This callback is functionally the same as get_buffer2() is for decoders, and implements for the new encode API the functionality of the old encode API had where the user co

Re: [FFmpeg-devel] [PATCH v2] avcodec: add a get_encoder_buffer() callback to AVCodecContext

2021-02-21 Thread James Almer
On 2/21/2021 4:13 PM, Mark Thompson wrote: On 21/02/2021 17:35, James Almer wrote: This callback is functionally the same as get_buffer2() is for decoders, and implements for the new encode API the functionality of the old encode API had where the user could provide their own buffers. Signed-

[FFmpeg-devel] [PATCH v2 17/18] vaapi_encode_h264: Support HDR metadata

2021-02-21 Thread Mark Thompson
This can now be done in exactly the same way as it is for H.265. --- libavcodec/vaapi_encode_h264.c | 66 +- 1 file changed, 65 insertions(+), 1 deletion(-) diff --git a/libavcodec/vaapi_encode_h264.c b/libavcodec/vaapi_encode_h264.c index b546ddec08..582a855586 10

[FFmpeg-devel] [PATCH v2 12/18] h264_metadata_bsf: Support HDR metadata

2021-02-21 Thread Mark Thompson
--- doc/bitstream_filters.texi | 17 + libavcodec/h264_metadata_bsf.c | 25 + 2 files changed, 42 insertions(+) diff --git a/doc/bitstream_filters.texi b/doc/bitstream_filters.texi index 60e729484d..0ff76b86f0 100644 --- a/doc/bitstream_filters.texi +++

[FFmpeg-devel] [PATCH v2 11/18] h264_metadata_bsf: Simplify display orientation handling

2021-02-21 Thread Mark Thompson
The case where the user supplies new value directly as options still requires a bit of special handling. --- libavcodec/h264_metadata_bsf.c | 118 ++--- 1 file changed, 21 insertions(+), 97 deletions(-) diff --git a/libavcodec/h264_metadata_bsf.c b/libavcodec/h264_meta

[FFmpeg-devel] [PATCH v2 18/18] cbs: Add metadata test

2021-02-21 Thread Mark Thompson
This tests insert/extract/remove for each supported codec/type combination. --- libavcodec/Makefile | 1 + libavcodec/tests/cbs_metadata.c | 390 tests/fate/libavcodec.mak | 5 + 3 files changed, 396 insertions(+) create mode 100644 libavcode

[FFmpeg-devel] [PATCH v2 16/18] vaapi_encode_h265: Ensure that HDR metadata is included with seek points

2021-02-21 Thread Mark Thompson
Save the most recent HDR side data structures and use them when generating an IDR or CRA frame. --- libavcodec/vaapi_encode_h265.c | 93 -- 1 file changed, 32 insertions(+), 61 deletions(-) diff --git a/libavcodec/vaapi_encode_h265.c b/libavcodec/vaapi_encode_h265.

[FFmpeg-devel] [PATCH v2 10/18] cbs: Add interface to allow BSFs easy access to metadata manipulation

2021-02-21 Thread Mark Thompson
--- libavcodec/cbs_bsf.c | 73 libavcodec/cbs_bsf.h | 6 2 files changed, 79 insertions(+) diff --git a/libavcodec/cbs_bsf.c b/libavcodec/cbs_bsf.c index 9b521cf111..4f8f7f499d 100644 --- a/libavcodec/cbs_bsf.c +++ b/libavcodec/cbs_bsf.c @@ -18,6

[FFmpeg-devel] [PATCH v2 15/18] vaapi_encode: Unify SEI option mask enum

2021-02-21 Thread Mark Thompson
This was in two disjoint parts in the H.264 and H.265 files. Unify them in the header to avoid any confusion, because they are really the same enum. --- libavcodec/vaapi_encode.h | 8 libavcodec/vaapi_encode_h264.c | 6 -- libavcodec/vaapi_encode_h265.c | 5 - 3 files change

[FFmpeg-devel] [PATCH v2 09/18] cbs_av1: Support manipulating HDR CLL and MDCV metadata

2021-02-21 Thread Mark Thompson
--- libavcodec/cbs_av1.c | 91 1 file changed, 91 insertions(+) diff --git a/libavcodec/cbs_av1.c b/libavcodec/cbs_av1.c index 0c958c81c2..281382c792 100644 --- a/libavcodec/cbs_av1.c +++ b/libavcodec/cbs_av1.c @@ -17,6 +17,7 @@ */ #include "libav

[FFmpeg-devel] [PATCH v2 08/18] cbs_av1: Implement metadata manipulation

2021-02-21 Thread Mark Thompson
--- libavcodec/cbs_av1.c | 142 +++ 1 file changed, 142 insertions(+) diff --git a/libavcodec/cbs_av1.c b/libavcodec/cbs_av1.c index 302e1f38f5..0c958c81c2 100644 --- a/libavcodec/cbs_av1.c +++ b/libavcodec/cbs_av1.c @@ -22,6 +22,7 @@ #include "cbs.h" #

[FFmpeg-devel] [PATCH v2 14/18] av1_metadata_bsf: Support HDR metadata

2021-02-21 Thread Mark Thompson
--- doc/bitstream_filters.texi| 17 + libavcodec/av1_metadata_bsf.c | 26 ++ 2 files changed, 43 insertions(+) diff --git a/doc/bitstream_filters.texi b/doc/bitstream_filters.texi index e739832665..6a4c0cfe5e 100644 --- a/doc/bitstream_filters.texi +++

[FFmpeg-devel] [PATCH v2 07/18] cbs_h264: Implement fill and extract for frame packing arrangement message

2021-02-21 Thread Mark Thompson
This maps from/to stereo 3D metadata. --- libavcodec/cbs_h2645.c | 83 ++ libavcodec/cbs_sei.c | 2 + 2 files changed, 85 insertions(+) diff --git a/libavcodec/cbs_h2645.c b/libavcodec/cbs_h2645.c index c01d243455..8efcd87156 100644 --- a/libavcodec/cbs_

[FFmpeg-devel] [PATCH v2 13/18] h265_metadata_bsf: Support HDR metadata

2021-02-21 Thread Mark Thompson
--- doc/bitstream_filters.texi | 17 + libavcodec/h265_metadata_bsf.c | 26 ++ 2 files changed, 43 insertions(+) diff --git a/doc/bitstream_filters.texi b/doc/bitstream_filters.texi index 0ff76b86f0..e739832665 100644 --- a/doc/bitstream_filters.texi ++

[FFmpeg-devel] [PATCH v2 06/18] cbs_h264: Implement fill and extract for display orientation SEI message

2021-02-21 Thread Mark Thompson
--- libavcodec/cbs_h2645.c | 79 ++ libavcodec/cbs_sei.c | 2 ++ 2 files changed, 81 insertions(+) diff --git a/libavcodec/cbs_h2645.c b/libavcodec/cbs_h2645.c index ecd2001816..c01d243455 100644 --- a/libavcodec/cbs_h2645.c +++ b/libavcodec/cbs_h2645.c

[FFmpeg-devel] [PATCH v2 05/18] cbs_sei: Implement fill and extract for HDR SEI messages

2021-02-21 Thread Mark Thompson
Fill and extract both mastering display colour volume and content light level info messages. --- libavcodec/cbs_h2645.c | 130 + libavcodec/cbs_sei.c | 4 ++ 2 files changed, 134 insertions(+) diff --git a/libavcodec/cbs_h2645.c b/libavcodec/cbs_h2645.c

[FFmpeg-devel] [PATCH v2 04/18] cbs_sei: Implement metadata manipulation for SEI codecs

2021-02-21 Thread Mark Thompson
--- libavcodec/cbs_h2645.c | 8 libavcodec/cbs_sei.c | 94 ++ libavcodec/cbs_sei.h | 35 3 files changed, 137 insertions(+) diff --git a/libavcodec/cbs_h2645.c b/libavcodec/cbs_h2645.c index 0c591871d4..cb0005cc1b 100644 --- a/lib

[FFmpeg-devel] [PATCH v2 03/18] cbs: Add interface for manipulating metadata in fragments

2021-02-21 Thread Mark Thompson
--- libavcodec/Makefile | 2 +- libavcodec/cbs_internal.h | 17 ++ libavcodec/cbs_metadata.c | 110 ++ libavcodec/cbs_metadata.h | 94 4 files changed, 222 insertions(+), 1 deletion(-) create mode 100644 libavcodec

[FFmpeg-devel] [PATCH v2 02/18] cbs_h264: Add support for frame packing arrangement SEI messages

2021-02-21 Thread Mark Thompson
--- libavcodec/cbs_h264.h | 23 libavcodec/cbs_h2645.c| 6 + libavcodec/cbs_h264_syntax_template.c | 39 +++ 3 files changed, 68 insertions(+) diff --git a/libavcodec/cbs_h264.h b/libavcodec/cbs_h264.h index 9eb97eae24.

[FFmpeg-devel] [PATCH v2 01/18] cbs_sei: Delete SEI NAL units containing no messages

2021-02-21 Thread Mark Thompson
When we remove the last SEI message from a NAL unit, the unit itself should also be deleted. --- libavcodec/cbs_sei.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/libavcodec/cbs_sei.c b/libavcodec/cbs_sei.c index c49830ad77..14f1cae506 100644 --- a/libavcodec/cbs_sei.c

Re: [FFmpeg-devel] [PATCH v2] avcodec: add a get_encoder_buffer() callback to AVCodecContext

2021-02-21 Thread Mark Thompson
On 21/02/2021 17:35, James Almer wrote: This callback is functionally the same as get_buffer2() is for decoders, and implements for the new encode API the functionality of the old encode API had where the user could provide their own buffers. Signed-off-by: James Almer --- Used the names Lynne

Re: [FFmpeg-devel] [PATCH 3/2] doc/encoders: Add documentation for the GIF encoder

2021-02-21 Thread Paul B Mahol
probably fine ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 2/2 v3] avcodec/gifenc: Only write frame palette entries that actually used

2021-02-21 Thread Paul B Mahol
I would prefer with memory log removed Probably fine anyway. On Sat, Feb 20, 2021 at 8:24 PM Derek Buitenhuis wrote: > GIF palette entries are not compressed, and writing 256 entries, > which can be up to every frame, uses a significant amount of > space, especially in extreme cases, where

Re: [FFmpeg-devel] [PATCH 1/2 v2] avcodec/gifenc: Add global_palette option

2021-02-21 Thread Paul B Mahol
lgtm ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH v2] avcodec: add a get_encoder_buffer() callback to AVCodecContext

2021-02-21 Thread James Almer
On 2/21/2021 2:59 PM, Lynne wrote: Feb 21, 2021, 18:35 by jamr...@gmail.com: This callback is functionally the same as get_buffer2() is for decoders, and implements for the new encode API the functionality of the old encode API had where the user could provide their own buffers. Signed-off-by:

Re: [FFmpeg-devel] [PATCH v2] avcodec: add a get_encoder_buffer() callback to AVCodecContext

2021-02-21 Thread Lynne
Feb 21, 2021, 18:35 by jamr...@gmail.com: > This callback is functionally the same as get_buffer2() is for decoders, and > implements for the new encode API the functionality of the old encode API had > where the user could provide their own buffers. > > Signed-off-by: James Almer > --- > Used th

[FFmpeg-devel] [PATCH v2] avcodec: add a get_encoder_buffer() callback to AVCodecContext

2021-02-21 Thread James Almer
This callback is functionally the same as get_buffer2() is for decoders, and implements for the new encode API the functionality of the old encode API had where the user could provide their own buffers. Signed-off-by: James Almer --- Used the names Lynne suggested this time, plus a line about how

[FFmpeg-devel] [PATCH 5/5] avdevice/pulse_audio_dec: do not read undersized frames

2021-02-21 Thread Marton Balint
Keep on reading fragments until we got fragment_size amount of data, otherwise we might get frames with 1-2 samples only if pa_stream_peek is called slightly less frequently than sample rate. Note that fragments might contain a lot less data than fragment_size, so reading multiple fragments to get

[FFmpeg-devel] [PATCH 4/5] avdevice/pulse_audio_dec: only set adjust latency flag if fragment_size is not set

2021-02-21 Thread Marton Balint
Otherwise fragment_size is ignored. Signed-off-by: Marton Balint --- libavdevice/pulse_audio_dec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavdevice/pulse_audio_dec.c b/libavdevice/pulse_audio_dec.c index 6dea332beb..0454a643dd 100644 --- a/libavdevice/pulse_audio_d

[FFmpeg-devel] [PATCH 3/5] avdevice/pulse_audio_dec: query actual fragment size

2021-02-21 Thread Marton Balint
Signed-off-by: Marton Balint --- libavdevice/pulse_audio_dec.c | 9 + 1 file changed, 9 insertions(+) diff --git a/libavdevice/pulse_audio_dec.c b/libavdevice/pulse_audio_dec.c index 50a3c971ae..6dea332beb 100644 --- a/libavdevice/pulse_audio_dec.c +++ b/libavdevice/pulse_audio_dec.c @@

[FFmpeg-devel] [PATCH 2/5] avdevice/alsa_dec: make sure we have enough data in non-blocking mode

2021-02-21 Thread Marton Balint
Otherwise we might return 1-2 samples per packet if av_read_frame() call rate is only sligthly less than the stream sample rate. Signed-off-by: Marton Balint --- libavdevice/alsa_dec.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/libavdevice/alsa_dec.c b/libavdevice/al

[FFmpeg-devel] [PATCH 1/5] avdevice/alsa_dec: do not set codecpar frame_size

2021-02-21 Thread Marton Balint
Constant frame size is not guaranteed if the read call interrupted by a signal, or if non-blocking mode is used. Signed-off-by: Marton Balint --- libavdevice/alsa_dec.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavdevice/alsa_dec.c b/libavdevice/alsa_dec.c index 36494e921c..6d568737b3

Re: [FFmpeg-devel] [PATCH] lavu/tx: support in-place FFT transforms

2021-02-21 Thread Lynne
Feb 21, 2021, 00:43 by d...@lynne.ee: > Feb 10, 2021, 21:31 by d...@lynne.ee: > >> Feb 10, 2021, 18:15 by d...@lynne.ee: >> >>> This commit adds support for in-place FFT transforms. Since our >>> internal transforms were all in-place anyway, this only changes >>> the permutation on the input. >>>

Re: [FFmpeg-devel] [PATCH 2/4] libavutil: add side data AV_FRAME_DATA_BOUNDING_BOXES

2021-02-21 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel On Behalf Of > Lynne > Sent: Saturday, February 20, 2021 11:36 PM > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH 2/4] libavutil: add side data > AV_FRAME_DATA_BOUNDING_BOXES > > Feb 20, 2

Re: [FFmpeg-devel] [PATCH]lavf/imx: Do not probe number of frames

2021-02-21 Thread Paul B Mahol
On Sun, Feb 21, 2021 at 2:23 PM Carl Eugen Hoyos wrote: > Am So., 21. Feb. 2021 um 14:12 Uhr schrieb Paul B Mahol >: > > > > On Sun, Feb 21, 2021 at 2:10 PM Carl Eugen Hoyos > wrote: > > > > > Am So., 21. Feb. 2021 um 12:35 Uhr schrieb Paul B Mahol < > one...@gmail.com > > > >: > > > > > > > >

Re: [FFmpeg-devel] [PATCH]lavf/imx: Do not probe number of frames

2021-02-21 Thread Carl Eugen Hoyos
Am So., 21. Feb. 2021 um 14:12 Uhr schrieb Paul B Mahol : > > On Sun, Feb 21, 2021 at 2:10 PM Carl Eugen Hoyos wrote: > > > Am So., 21. Feb. 2021 um 12:35 Uhr schrieb Paul B Mahol > >: > > > > > > Because there is not point in it. > > > Number of frames should always be probed. > > > > It is neit

Re: [FFmpeg-devel] [PATCH 1/2 v2] avcodec/gifenc: Add global_palette option

2021-02-21 Thread Derek Buitenhuis
On 20/02/2021 19:58, Marton Balint wrote: > docs update is missing for the new option. Seems there was no documentation at all, so I've add all of it, and sent patch 3/2. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/m

[FFmpeg-devel] [PATCH 3/2] doc/encoders: Add documentation for the GIF encoder

2021-02-21 Thread Derek Buitenhuis
Signed-off-by: Derek Buitenhuis --- doc/encoders.texi | 38 ++ 1 file changed, 38 insertions(+) diff --git a/doc/encoders.texi b/doc/encoders.texi index 8fb573c416..d7d81e070d 100644 --- a/doc/encoders.texi +++ b/doc/encoders.texi @@ -1268,6 +1268,44 @@ disabl

Re: [FFmpeg-devel] [PATCH]lavf/imx: Do not probe number of frames

2021-02-21 Thread Paul B Mahol
On Sun, Feb 21, 2021 at 2:10 PM Carl Eugen Hoyos wrote: > Am So., 21. Feb. 2021 um 12:35 Uhr schrieb Paul B Mahol >: > > > > Because there is not point in it. > > Number of frames should always be probed. > > It is neither necessary nor useful to probe it. > Both is immediately obvious: > You al

Re: [FFmpeg-devel] [PATCH]lavf/imx: Do not probe number of frames

2021-02-21 Thread Carl Eugen Hoyos
Am So., 21. Feb. 2021 um 12:35 Uhr schrieb Paul B Mahol : > > Because there is not point in it. > Number of frames should always be probed. It is neither necessary nor useful to probe it. Both is immediately obvious: You already check 48 bits, ruling out one possible value for 32bit does not impro

Re: [FFmpeg-devel] [PATCH v2 18/19] fate/matroska: Test remuxing tracks for hearing/visually impaired

2021-02-21 Thread Carl Eugen Hoyos
Am Sa., 20. Feb. 2021 um 17:00 Uhr schrieb Andreas Rheinhardt : > > The tests also test the other dispositions: commentary, descriptions > as well as dub and original language. > > Signed-off-by: Andreas Rheinhardt > --- > The first version of the matroska-wtv-remux test used the fixed-point > mp2

Re: [FFmpeg-devel] [PATCH]lavf/imx: Do not probe number of frames

2021-02-21 Thread Paul B Mahol
Because there is not point in it. Number of frames should always be probed. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org

Re: [FFmpeg-devel] [PATCH]lavf/imx: Do not probe number of frames

2021-02-21 Thread Carl Eugen Hoyos
Am So., 21. Feb. 2021 um 11:39 Uhr schrieb Paul B Mahol : > > This patch is not good. Could you elaborate? Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link abov

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/bitstream: Rewrite code to avoid triggering compiler warning

2021-02-21 Thread Paul B Mahol
probably ok ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH]lavf/imx: Do not probe number of frames

2021-02-21 Thread Paul B Mahol
This patch is not good. Probe function should not be changed. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject

[FFmpeg-devel] [PATCH]lavf/imx: Do not probe number of frames

2021-02-21 Thread Carl Eugen Hoyos
Hi! The Simbiosis IMX probe function looks strict enough, do not check for a field that does not cause decoding to fail. Please comment, Carl Eugen From 62ce4e42c1dae6696007e22cd13a8e43eabbc38d Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Sun, 21 Feb 2021 10:31:16 +0100 Subject: [PATCH]

Re: [FFmpeg-devel] [PATCH] x11grab: capture a window instead of the whole screen

2021-02-21 Thread Andriy Gelman
On Wed, 10. Feb 18:15, sgerwk-at-aol@ffmpeg.org wrote: > On Sat, 6 Feb 2021, Paul B Mahol wrote: > > > What happens if you use non-existing window? > > I added an error message for this case, but the output video is still created > (empty). Is there a value I can return to avoid this? > > On