[FFmpeg-devel] [PATCH 8/8] libavutil/opt.c: fix build warning

2021-02-19 Thread Guo, Yejun
src/libavutil/opt.c: In function ‘av_opt_child_class_iterate’: src/libavutil/opt.c:1738:15: warning: assignment discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers] *iter = parent->child_class_next(*iter); ^ --- This patch set fixes build warnings du

[FFmpeg-devel] [PATCH 7/8] libavcodec/movtextenc.c: fix build warning

2021-02-19 Thread Guo, Yejun
src/libavcodec/movtextenc.c: In function ‘mov_text_style_start’: src/libavcodec/movtextenc.c:358:26: warning: comparison is always false due to limited range of data type [-Wtype-limits] if (s->count + 1 > SIZE_MAX / sizeof(*s->style_attributes) || ^ --- libavco

[FFmpeg-devel] [PATCH 5/8] libavformat/protocols.c: fix build warning

2021-02-19 Thread Guo, Yejun
src/libavformat/protocols.c: In function ‘avio_enum_protocols’: src/libavformat/protocols.c:116:7: warning: assignment discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers] p = p ? p + 1 : url_protocols; ^ --- libavformat/protocols.c | 2 +- 1 file changed, 1 in

[FFmpeg-devel] [PATCH 6/8] libavformat/smoothstreamingenc.c: fix build warning

2021-02-19 Thread Guo, Yejun
Part of the build message: src/libavformat/smoothstreamingenc.c: In function ‘ism_flush’: src/libavformat/smoothstreamingenc.c:510:49: warning: ‘/temp’ directive output may be truncated writing 5 bytes into a region of size between 1 and 1024 [-Wformat-truncation=] snprintf(filename, siz

[FFmpeg-devel] [PATCH 4/8] libavformat/dashenc.c: fix build warning

2021-02-19 Thread Guo, Yejun
Part of warning message: src/libavformat/dashenc.c: In function ‘flush_init_segment’: src/libavformat/dashenc.c:608:49: warning: ‘%s’ directive output may be truncated writing up to 1023 bytes into a region of size between 1 and 1024 [-Wformat-truncation=] snprintf(filename, sizeof(filen

[FFmpeg-devel] [PATCH 3/8] libavfilter/vf_vif.c: fix build warning

2021-02-19 Thread Guo, Yejun
src/libavfilter/vf_vif.c: In function ‘process_frame’: src/libavfilter/vf_vif.c:542:20: warning: ‘main’ is usually a function [-Wmain] AVFrame *out, *main = NULL, *ref = NULL; ^~~~ --- libavfilter/vf_vif.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-

[FFmpeg-devel] [PATCH 2/8] libavfilter/vf_ssim.c: fix build warning

2021-02-19 Thread Guo, Yejun
The build warning message: src/libavfilter/vf_ssim.c: In function ‘ssim_plane_16bit’: src/libavfilter/vf_ssim.c:246:24: warning: ‘main’ is usually a function [-Wmain] const uint8_t *main = td->main_data[c]; ^~~~ src/libavfilter/vf_ssim.c: In function ‘ssim_plane’: s

[FFmpeg-devel] [PATCH 1/8] libavdevice/v4l2.c: fix build warning

2021-02-19 Thread Guo, Yejun
Here is the warning message: src/libavdevice/v4l2.c: In function ‘v4l2_get_device_list’: src/libavdevice/v4l2.c:1054:58: warning: ‘%s’ directive output may be truncated writing up to 255 bytes into a region of size 251 [-Wformat-truncation=] snprintf(device_name, sizeof(device_name), "/de

[FFmpeg-devel] [PATCH 32/32] avcodec/dirac_vlc: Make ff_dirac_golomb_lut static

2021-02-19 Thread Andreas Rheinhardt
Only used here. Signed-off-by: Andreas Rheinhardt --- libavcodec/dirac_vlc.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavcodec/dirac_vlc.c b/libavcodec/dirac_vlc.c index 2c07440df0..c5a0371dae 100644 --- a/libavcodec/dirac_vlc.c +++ b/libavcodec/dirac_vlc.c @

[FFmpeg-devel] [PATCH 31/32] avcodec/ac3tab: Move ff_ac3_enc_channel_map to its only user

2021-02-19 Thread Andreas Rheinhardt
and make it static. Signed-off-by: Andreas Rheinhardt --- libavcodec/ac3enc.c | 11 ++- libavcodec/ac3tab.c | 18 -- libavcodec/ac3tab.h | 9 - 3 files changed, 18 insertions(+), 20 deletions(-) diff --git a/libavcodec/ac3enc.c b/libavcodec/ac3enc.c index bae740

[FFmpeg-devel] libavfilter: build failure in vf_lensfun.c

2021-02-19 Thread Hanspeter Niederstrasser
On macOS 10.13,libavfilter/vf_lensfun.c fails like this: clang -I. -Isrc/ -D_ISOC99_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -Isrc/compat/dispatch_semaphore -DPIC -DZLIB_CONST -DHAVE_AV_CONFIG_H -DBUILDING_avfilter -I/sw/include -std=c11 -Werror=partial-availability -fomit-frame-pointer -

[FFmpeg-devel] [PATCH] avcodec/exr: simplify piz decompression

2021-02-19 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavcodec/exr.c | 212 +++ 1 file changed, 65 insertions(+), 147 deletions(-) diff --git a/libavcodec/exr.c b/libavcodec/exr.c index cacdff5774..625ee4680c 100644 --- a/libavcodec/exr.c +++ b/libavcodec/exr.c @@ -91,6 +

[FFmpeg-devel] [PATCH] avcodec/exr: simplify piz decompression

2021-02-19 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavcodec/exr.c | 209 ++- 1 file changed, 63 insertions(+), 146 deletions(-) diff --git a/libavcodec/exr.c b/libavcodec/exr.c index cacdff5774..9d86f6ea43 100644 --- a/libavcodec/exr.c +++ b/libavcodec/exr.c @@ -91,6 +

[FFmpeg-devel] [PATCH 2/3] avisynth: populate field order

2021-02-19 Thread Stephen Hutchinson
From: emcodem Fixes Trac ticket #8757 Signed-off-by: Stephen Hutchinson --- Resubmitting with my signed-off so that it's clear that I've given final approval and it shows up in Patchwork. libavformat/avisynth.c | 17 + 1 file changed, 17 insertions(+) diff --git a/libavformat/

[FFmpeg-devel] [PATCH v2] libsvtav1: Add logical_processors option

2021-02-19 Thread Christopher Degawa
From: Christopher Degawa Used for limiting the size of memory buffers and threads for a target logical processor count, but does not set thread affinity or limit the amount of threads used, although thread affinities can be controlled with an additional parameters, it is prefered to add them unti

Re: [FFmpeg-devel] [PATCH] set ulMaxDisplayDelay cuvidec parser option to zero if low_delay flag is on

2021-02-19 Thread clime
On Sat, 20 Feb 2021 at 00:38, clime wrote: > > On Sat, 20 Feb 2021 at 00:29, Timo Rothenpieler wrote: > > > > On 19.02.2021 23:33, clime wrote: > > > ctx->cuparseinfo.ulMaxNumDecodeSurfaces = ctx->nb_surfaces; > > > -ctx->cuparseinfo.ulMaxDisplayDelay = 4; > > > +ctx->cuparseinfo.ul

Re: [FFmpeg-devel] [PATCH] set ulMaxDisplayDelay cuvidec parser option to zero if low_delay flag is on

2021-02-19 Thread clime
On Sat, 20 Feb 2021 at 00:29, Timo Rothenpieler wrote: > > On 19.02.2021 23:33, clime wrote: > > ctx->cuparseinfo.ulMaxNumDecodeSurfaces = ctx->nb_surfaces; > > -ctx->cuparseinfo.ulMaxDisplayDelay = 4; > > +ctx->cuparseinfo.ulMaxDisplayDelay = avctx->flags & > > AV_CODEC_FLAG_LOW_DE

Re: [FFmpeg-devel] [PATCH] set ulMaxDisplayDelay cuvidec parser option to zero if low_delay flag is on

2021-02-19 Thread Timo Rothenpieler
On 19.02.2021 23:33, clime wrote: ctx->cuparseinfo.ulMaxNumDecodeSurfaces = ctx->nb_surfaces; -ctx->cuparseinfo.ulMaxDisplayDelay = 4; +ctx->cuparseinfo.ulMaxDisplayDelay = avctx->flags & AV_CODEC_FLAG_LOW_DELAY ? 0 : 4; I'd prefer this with proper braces, to make sure no compile

[FFmpeg-devel] [PATCH 1/2] avformat/mxfdec: change toolkit_version metadata field to toolkit_version_num

2021-02-19 Thread Marton Balint
It only got added recently, and the new name makes it consistent with product_version_num in the next patch. Signed-off-by: Marton Balint --- libavformat/mxfdec.c | 2 +- tests/ref/fate/mxf-d10-user-comments | 2 +- tests/ref/fate/mxf-probe-applehdr10 | 2 +- tests/ref/fate/mxf-

[FFmpeg-devel] [PATCH 2/2] avformat/mxfdec: add support for getting product version number metadata

2021-02-19 Thread Marton Balint
Signed-off-by: Marton Balint --- libavformat/mxfdec.c | 3 +++ tests/ref/fate/mxf-d10-user-comments | 1 + tests/ref/fate/mxf-probe-dnxhd | 1 + 3 files changed, 5 insertions(+) diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c index 3ce83dde54..bb00838a3f 100644 ---

Re: [FFmpeg-devel] [PATCH] avcodec/nvenc: Fixing default number of B frames

2021-02-19 Thread Philip Langdale
On Fri, 19 Feb 2021 18:01:42 +0100 Timo Rothenpieler wrote: > On 19.02.2021 16:29, Ricardo Monteiro wrote: > > Hello, > > > > The patch fixes a bug regarding the number of B frames being used: > > The default number of B frames is now -1 for both h264_nvenc and > > hevc_nvenc. This allows the nu

[FFmpeg-devel] [PATCH] set ulMaxDisplayDelay cuvidec parser option to zero if low_delay flag is on

2021-02-19 Thread clime
From: Michal Novotny * zero is recommended value in Nvidia coding samples for low latency use-cases Signed-off-by: Michal Novotny --- libavcodec/cuviddec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/cuviddec.c b/libavcodec/cuviddec.c index 49775b5a09..ef5acb

Re: [FFmpeg-devel] [PATCH 2/4] libavutil: add side data AV_FRAME_DATA_BOUNDING_BOXES

2021-02-19 Thread Lynne
Feb 19, 2021, 07:59 by yejun@intel.com: > Signed-off-by: Guo, Yejun > --- > doc/APIchanges | 2 ++ > libavutil/frame.c | 1 + > libavutil/frame.h | 7 +++ > libavutil/version.h | 2 +- > 4 files changed, 11 insertions(+), 1 deletion(-) > > diff --git a/doc/APIchanges b/doc/APIch

[FFmpeg-devel] Fwd: [PATCH] set ulMaxDisplayDelay cuvidec parser option to zero if low_delay flag is on

2021-02-19 Thread clime
From: Michal Novotny * zero is recommended value in Nvidia coding samples for low latency use-cases --- libavcodec/cuviddec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/cuviddec.c b/libavcodec/cuviddec.c index 49775b5a09..ef5acb6b7b 100644 --- a/libavcodec/cuv

Re: [FFmpeg-devel] [PATCH] avcodec/hapdec: Change compressed_offset to unsigned 32bit

2021-02-19 Thread Michael Niedermayer
On Fri, Feb 19, 2021 at 09:24:49PM +0100, Paul B Mahol wrote: > lgtm will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Into a blind darkness they enter who follow after the Ignorance, they as if into a greater darkness enter who devote themselves t

Re: [FFmpeg-devel] [PATCH v5] avcodec/libvpxenc: optimize parsing vpx_svc_ref_frame_config

2021-02-19 Thread James Zern
On Thu, Feb 18, 2021 at 1:17 PM James Zern wrote: > > On Thu, Feb 18, 2021 at 11:01 AM Wonkap Jang > wrote: > > > > Getting rid of unnecessary use of AVDictionary object in parsing > > vpx_svc_ref_frame_config. > > --- > > libavcodec/libvpxenc.c | 73 +++--- >

Re: [FFmpeg-devel] [PATCH 1/2] avutil/common: Add FFINCREASE_PTR()

2021-02-19 Thread Nicolas George
Andreas Rheinhardt (12021-02-19): > It is only for NULL+0; NULL+x is a real bug after all. > And the macro doesn't hide it; NULL+x can still be detected with all the > typical tools (ubsan) to detect NULL+x. Doing it this way has the > advantage of allowing the compiler to optimize the branch away

Re: [FFmpeg-devel] [PATCH 1/2] avutil/common: Add FFINCREASE_PTR()

2021-02-19 Thread Andreas Rheinhardt
Nicolas George: > Michael Niedermayer (12021-02-19): >> Suggested-by: Andreas Rheinhardt >> Signed-off-by: Michael Niedermayer >> --- >> doc/APIchanges | 3 +++ >> libavutil/common.h | 2 ++ >> 2 files changed, 5 insertions(+) > > Is it only for NULL+0 or is it for all NULL+x? > > It is ok

Re: [FFmpeg-devel] [PATCH 1/2] avutil/common: Add FFINCREASE_PTR()

2021-02-19 Thread Nicolas George
Michael Niedermayer (12021-02-19): > Suggested-by: Andreas Rheinhardt > Signed-off-by: Michael Niedermayer > --- > doc/APIchanges | 3 +++ > libavutil/common.h | 2 ++ > 2 files changed, 5 insertions(+) Is it only for NULL+0 or is it for all NULL+x? It is ok to hide NULL+0, but NULL+x is a

Re: [FFmpeg-devel] [PATCH 1/2] avutil/common: Add FFINCREASE_PTR()

2021-02-19 Thread Andreas Rheinhardt
Michael Niedermayer: > Suggested-by: Andreas Rheinhardt > Signed-off-by: Michael Niedermayer > --- > doc/APIchanges | 3 +++ > libavutil/common.h | 2 ++ > 2 files changed, 5 insertions(+) > > diff --git a/doc/APIchanges b/doc/APIchanges > index c353d2d281..e38a5cb91c 100644 > --- a/doc/APIc

[FFmpeg-devel] [PATCH 1/2] avutil/common: Add FFINCREASE_PTR()

2021-02-19 Thread Michael Niedermayer
Suggested-by: Andreas Rheinhardt Signed-off-by: Michael Niedermayer --- doc/APIchanges | 3 +++ libavutil/common.h | 2 ++ 2 files changed, 5 insertions(+) diff --git a/doc/APIchanges b/doc/APIchanges index c353d2d281..e38a5cb91c 100644 --- a/doc/APIchanges +++ b/doc/APIchanges @@ -15,6 +15,

[FFmpeg-devel] [PATCH 2/2] avfilter/vf_scale: Fix adding 0 to NULL (which is UB) in scale_slice()

2021-02-19 Thread Michael Niedermayer
Found-by: Jeremy Leconte Signed-off-by: Michael Niedermayer --- libavfilter/vf_scale.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavfilter/vf_scale.c b/libavfilter/vf_scale.c index 58eee96744..f1fbbf2978 100644 --- a/libavfilter/vf_scale.c +++ b/libavfilter/vf_sca

Re: [FFmpeg-devel] [PATCH] When using ffmpeg to record screen, set the operating system time and set the system time backward. Stop screen recording, unable to save video.

2021-02-19 Thread Marton Balint
On Fri, 19 Feb 2021, Nicolas George wrote: hou...@uniontech.com (12021-02-19): From: Hou Lei Signed-off-by: Hou Lei --- libavdevice/xcbgrab.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) NAK. The correct fix is to use the monotonic clock for syncing. I just sent a

[FFmpeg-devel] [PATCH] avdevice: use av_gettime_relative() for elapsed time calculations

2021-02-19 Thread Marton Balint
av_gettime_relative() is using the monotonic clock therefore more suitable for elapsed time calculations. Packet timestamps are still kept absolute, although that should be configurable in the future. Signed-off-by: Marton Balint --- libavdevice/bktr.c | 4 ++-- libavdevice/fbdev_dec.c | 6

Re: [FFmpeg-devel] [PATCH] avfilter: Added siti filter

2021-02-19 Thread Werner Robitza
On Fri, Feb 19, 2021 at 9:02 PM Werner Robitza wrote: > In particular, such output should be tidy [1]. For instance, you don't > want to output "frame, key, value" with lines "1, si, 53.999", but > rather "frame, si, ti". Such transformations to useful/parsable output > must be done in the filter

Re: [FFmpeg-devel] [PATCH 1/4] fftools/ffplay: get rid of flush_pkt

2021-02-19 Thread Marton Balint
On Sun, 7 Feb 2021, Marton Balint wrote: The packet serial can be used instead to detect when a flush is needed. Signed-off-by: Marton Balint --- fftools/ffplay.c | 29 +++-- 1 file changed, 11 insertions(+), 18 deletions(-) Will apply the series. Regards, Marton

Re: [FFmpeg-devel] [PATCH] avfilter: Added siti filter

2021-02-19 Thread Paul B Mahol
On Fri, Feb 19, 2021 at 9:03 PM Werner Robitza wrote: > On Mon, Feb 1, 2021 at 4:57 PM Nicolas George wrote: > > > > Werner Robitza (12021-01-22): > > > Thanks, I know this, but this is not a known format that can be easily > > > parsed like a plain CSV file. > > > > What you need to do is to ex

Re: [FFmpeg-devel] [PATCH] avcodec/hapdec: Change compressed_offset to unsigned 32bit

2021-02-19 Thread Paul B Mahol
lgtm ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH] avcodec/hapdec: Change compressed_offset to unsigned 32bit

2021-02-19 Thread Michael Niedermayer
Fixes: out of array access Fixes: 29345/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_HAP_fuzzer-5401813482340352 Fixes: 30745/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_HAP_fuzzer-5762798221131776 Suggested-by: Anton Found-by: continuous fuzzing process https://github.com/google/oss

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/hapdec: Check that compressed_offset is non negative

2021-02-19 Thread Michael Niedermayer
On Thu, Feb 04, 2021 at 12:02:07PM +0100, Anton Khirnov wrote: > Quoting Michael Niedermayer (2021-01-30 20:28:26) > > Fixes: out of array access > > Fixes: > > 29345/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_HAP_fuzzer-5401813482340352 > > > > Found-by: continuous fuzzing process > > ht

Re: [FFmpeg-devel] [PATCH] avfilter: Added siti filter

2021-02-19 Thread Werner Robitza
On Mon, Feb 1, 2021 at 4:57 PM Nicolas George wrote: > > Werner Robitza (12021-01-22): > > Thanks, I know this, but this is not a known format that can be easily > > parsed like a plain CSV file. > > What you need to do is to extend the metadata filter so that it lets > output to a file and choose

Re: [FFmpeg-devel] [RFC] Event loop

2021-02-19 Thread Kieran Kunhya
On Fri, 19 Feb 2021 at 19:04, Nicolas George wrote: > Kieran Kunhya (12021-02-19): > > I don't have a strong opinion on either. But I think you can use > > container_of on the fd. > > Thanks. I find no trace of it in the docs: > > > http://docs.libuv.org/en/v1.x/search.html?q=container_of&check_k

Re: [FFmpeg-devel] [PATCH v6 4/9] avcodec: add cbs for h266/vvc

2021-02-19 Thread Jan Ekström
On Fri, Feb 19, 2021 at 3:52 PM Nuo Mi wrote: > > >> > > >> The current logic is that we are writing an AU, so the first NAL unit in > > >> it is necessarily an AU start and subsequent NAL units are not? > > >> > > > H.266 AU contains one or more PU(3.105). One PU contains one coded > > picture. >

Re: [FFmpeg-devel] [RFC] Event loop

2021-02-19 Thread Nicolas George
Kieran Kunhya (12021-02-19): > I don't have a strong opinion on either. But I think you can use > container_of on the fd. Thanks. I find no trace of it in the docs: http://docs.libuv.org/en/v1.x/search.html?q=container_of&check_keywords=yes&area=default Can you be a little more precise? The por

[FFmpeg-devel] [PATCH] set ulMaxDisplayDelay cuviddec parser option to zero if low_delay flag is on

2021-02-19 Thread clime
From a2c5edfdbeb428935f7e12c8d78a68d45b2e598d Mon Sep 17 00:00:00 2001 From: Michal Novotny Date: Fri, 19 Feb 2021 05:11:14 -0800 Subject: [PATCH] set ulMaxDisplayDelay cuviddec parser option to zero if low_delay flag is on * zero is recommended value in Nvidia coding samples for low latency use-

Re: [FFmpeg-devel] [PATCH] [Code format dependent] : [Adjust the format of code blocks]

2021-02-19 Thread Thilo Borgmann
Hi, Am 19.02.21 um 13:43 schrieb hou...@uniontech.com: > From: Hou Lei > > Signed-off-by: Hou Lei > --- > fftools/ffmpeg.c | 8 > libavcodec/h264_loopfilter.c | 22 -- > 2 files changed, 12 insertions(+), 18 deletions(-) > > diff --git a/fftools/ffmpe

Re: [FFmpeg-devel] [PATCH] avcodec/nvenc: Fixing default number of B frames

2021-02-19 Thread Timo Rothenpieler
On 19.02.2021 16:29, Ricardo Monteiro wrote: Hello, The patch fixes a bug regarding the number of B frames being used: The default number of B frames is now -1 for both h264_nvenc and hevc_nvenc. This allows the number of B frames to be determined based on the coding preset or overwritten usi

Re: [FFmpeg-devel] [RFC] Event loop

2021-02-19 Thread Kieran Kunhya
On Fri, 19 Feb 2021 at 17:41, Nicolas George wrote: > Lynne (12021-02-19): > > You poll it in a busy loop in a thread in an event. > > Yeah. Events loop are supposed to avoid busy loops. So no. > > > Or you find a solution to use libuv's polling instead via a "hacker > > solution". > > This is wh

Re: [FFmpeg-devel] [RFC] Event loop

2021-02-19 Thread Nicolas George
Lynne (12021-02-19): > You poll it in a busy loop in a thread in an event. Yeah. Events loop are supposed to avoid busy loops. So no. > Or you find a solution to use libuv's polling instead via a "hacker > solution". This is what I am asking: can you give a good solution with libuv? It seems you

Re: [FFmpeg-devel] [RFC] Event loop

2021-02-19 Thread Lynne
Feb 19, 2021, 16:21 by geo...@nsup.org: > Lynne (12021-02-19): > >> That's okay, I'd let it read and call events as they happen on the fds. >> > > Pray tell me, how do you do that with a /dev/snd/pcmC0D0p in mmap mode? > You poll it in a busy loop in a thread in an event. Or you find a solution t

Re: [FFmpeg-devel] [PATCH] vp9dec: support exporting QP tables through the AVVideoEncParams API

2021-02-19 Thread James Almer
On 5/11/2020 6:32 AM, Anton Khirnov wrote: --- Now the nb_block_structure reset is moved to decode_frame_header(), which fixes block-structure export with frame threading. No idea how I didn't notice this before Thread sanitizer complains about a race with this change. http://fate.ffmpeg.org/r

Re: [FFmpeg-devel] [RFC] Event loop

2021-02-19 Thread Nicolas George
Lynne (12021-02-19): > That's okay, I'd let it read and call events as they happen on the fds. Pray tell me, how do you do that with a /dev/snd/pcmC0D0p in mmap mode? Sorry, but as promising as libuv looked, it is not generic enough for our use case, unless I missed something big. Regards, --

Re: [FFmpeg-devel] [RFC] Event loop

2021-02-19 Thread Lynne
Feb 19, 2021, 15:52 by geo...@nsup.org: > Lynne (12021-02-19): > >> File descriptors are reference counted. So if something takes ownership >> of an FD (completely reasonable, since it may want to clean up, seek, and >> flush+close it afterwards), then you can just dup() it before giving >> it to

Re: [FFmpeg-devel] [RFC] Event loop

2021-02-19 Thread Nicolas George
Lynne (12021-02-19): > File descriptors are reference counted. So if something takes ownership > of an FD (completely reasonable, since it may want to clean up, seek, and > flush+close it afterwards), then you can just dup() it before giving > it to libuv. You are completely misunderstanding the p

Re: [FFmpeg-devel] [PATCH 1/6] tests: add a test for LSCR

2021-02-19 Thread James Almer
On 2/19/2021 11:08 AM, Anton Khirnov wrote: Can someone with write access to FATE samples please put https://up.khirnov.net/0.avi -> /lscr/lscr_compr9_short.avi https://up.khirnov.net/q.png -> /apng/apng_out_of_order_frames.png Thanks, Done. ___ ffmp

Re: [FFmpeg-devel] [PATCH 1/2] tests/checkasm/sw_scale.c

2021-02-19 Thread James Almer
On 2/19/2021 10:55 AM, Alan Kelly wrote: Initialises each item in src and filter arrays to fix valgrind uninitialised value warning. --- casts pointers to uint8_t* and multiplies the buffer size by sizeof(uint16_t). tests/checkasm/sw_scale.c | 4 ++-- 1 file changed, 2 insertions(+), 2 delet

Re: [FFmpeg-devel] [RFC] Event loop

2021-02-19 Thread Lynne
Feb 19, 2021, 14:52 by geo...@nsup.org: > Lynne (12021-02-19): > >> https://github.com/libuv/libuv/tree/v1.x/docs/code >> Pipes, file descriptors, sockets, examples. >> The docs are even searchable: http://docs.libuv.org/en/v1.x/index.html >> > > I have found all this. Nothing allows to handle a f

Re: [FFmpeg-devel] [PATCH 1/6] tests: add a test for LSCR

2021-02-19 Thread Anton Khirnov
Can someone with write access to FATE samples please put https://up.khirnov.net/0.avi -> /lscr/lscr_compr9_short.avi https://up.khirnov.net/q.png -> /apng/apng_out_of_order_frames.png Thanks, -- Anton Khirnov ___ ffmpeg-devel mailing list ffmpeg-devel@f

[FFmpeg-devel] [PATCH 1/2] tests/checkasm/sw_scale.c

2021-02-19 Thread Alan Kelly
Initialises each item in src and filter arrays to fix valgrind uninitialised value warning. --- casts pointers to uint8_t* and multiplies the buffer size by sizeof(uint16_t). tests/checkasm/sw_scale.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/checkasm/sw_scale.

Re: [FFmpeg-devel] [RFC] Event loop

2021-02-19 Thread Nicolas George
Lynne (12021-02-19): > https://github.com/libuv/libuv/tree/v1.x/docs/code > Pipes, file descriptors, sockets, examples. > The docs are even searchable: http://docs.libuv.org/en/v1.x/index.html I have found all this. Nothing allows to handle a foreign protocol handled by existing code. It is even s

Re: [FFmpeg-devel] [PATCH v6 4/9] avcodec: add cbs for h266/vvc

2021-02-19 Thread Nuo Mi
> > > > >> > >> The current logic is that we are writing an AU, so the first NAL unit in > >> it is necessarily an AU start and subsequent NAL units are not? > >> > > H.266 AU contains one or more PU(3.105). One PU contains one coded > picture. > > Only the first NAL unit of an AU needs the zero_by

Re: [FFmpeg-devel] [RFC] Event loop

2021-02-19 Thread Lynne
Feb 19, 2021, 12:41 by geo...@nsup.org: > Lynne (12021-02-19): > >> I found this document useful: >> https://gist.github.com/andreybolonin/2413da76f088e2c5ab04df53f07659ea >> > > Thanks. But I think this document makes it clear that what we, FFmpeg, > need, is not libuv. > > In fact, after looking

Re: [FFmpeg-devel] [PATCH v4 4/4] {avcodec, avformat}: add TTML encoder and muxer

2021-02-19 Thread Anton Khirnov
Quoting Jan Ekström (2021-01-22 12:20:58) > From: Jan Ekström > > Enables encoding of other subtitle formats into TTML and writing > them out as such documents. > > Signed-off-by: Jan Ekström > --- > Changelog | 1 + > doc/general_contents.texi | 1 + > libavcodec/Makefil

[FFmpeg-devel] [PATCH V2 4/4] libavfilter: add filter dnn_detect for object detection

2021-02-19 Thread Guo, Yejun
Below are the example steps to do object detection: 1. download and install l_openvino_toolkit_p_2021.1.110.tgz from https://software.intel.com/content/www/us/en/develop/tools/openvino-toolkit/download.html or, we can get source code (tag 2021.1), build and install. 2. export LD_LIBRARY_PATH wit

[FFmpeg-devel] [PATCH V2 2/4] libavutil: add side data AV_FRAME_DATA_BOUNDING_BOXES

2021-02-19 Thread Guo, Yejun
Signed-off-by: Guo, Yejun --- doc/APIchanges | 2 ++ libavutil/frame.c | 1 + libavutil/frame.h | 7 +++ libavutil/version.h | 2 +- 4 files changed, 11 insertions(+), 1 deletion(-) diff --git a/doc/APIchanges b/doc/APIchanges index c353d2d281..3c6e9e351e 100644 --- a/doc/APIchanges

[FFmpeg-devel] [PATCH V2 3/4] libavfilter: show side data of bounding box

2021-02-19 Thread Guo, Yejun
Signed-off-by: Guo, Yejun --- libavfilter/f_sidedata.c | 2 ++ libavfilter/vf_showinfo.c | 38 ++ 2 files changed, 40 insertions(+) diff --git a/libavfilter/f_sidedata.c b/libavfilter/f_sidedata.c index 3757723375..912fb0d881 100644 --- a/libavfilter/f_sided

[FFmpeg-devel] [PATCH V2 1/4] libavfilter/bbox.h: add BoundingBoxHeader and BoundingBox

2021-02-19 Thread Guo, Yejun
They will be used for filters such as detect and classify. Signed-off-by: Guo, Yejun --- libavfilter/bbox.h | 45 + 1 file changed, 45 insertions(+) diff --git a/libavfilter/bbox.h b/libavfilter/bbox.h index 116158d59e..7c63dfa727 100644 --- a/libavfi

Re: [FFmpeg-devel] [PATCH v4 1/4] avutil/{avstring, bprint}: add XML escaping from ffprobe to avutil

2021-02-19 Thread Nicolas George
Anton Khirnov (12021-02-19): > Why not have a single ESCAPE_MODE_XML mode and use flags to tweak what > specifically is or is not escaped? I forgot the flags argument were there. You are right, it is the best choice: escape <&> by default, a flag to escape ' and a flag to escape ". > Mild perefer

Re: [FFmpeg-devel] [PATCH v4 1/4] avutil/{avstring, bprint}: add XML escaping from ffprobe to avutil

2021-02-19 Thread Anton Khirnov
Quoting Jan Ekström (2021-02-01 13:38:43) > On Mon, Feb 1, 2021 at 2:25 PM Nicolas George wrote: > > > > Jan Ekström (12021-02-01): > > > I fear that those sound way, way too generic. "This escapes all XML" > > > definitely is not what that does. > > > > > > And yes, even if it has the better defi

Re: [FFmpeg-devel] [PATCH 1/2] tests/checkasm/sw_scale.c

2021-02-19 Thread James Almer
On 2/19/2021 7:00 AM, Alan Kelly wrote: Initialises each item in src and filter arrays to fix valgrind uninitialised value warning. --- tests/checkasm/sw_scale.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tests/checkasm/sw_scale.c b/tests/checkasm/sw_scale.c inde

[FFmpeg-devel] [PATCH] [Code format dependent] : [Adjust the format of code blocks]

2021-02-19 Thread houlei
From: Hou Lei Signed-off-by: Hou Lei --- fftools/ffmpeg.c | 8 libavcodec/h264_loopfilter.c | 22 -- 2 files changed, 12 insertions(+), 18 deletions(-) diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c index add5a3e505..ed20bd3a25 100644 --- a/fftools/f

Re: [FFmpeg-devel] [PATCH 4/4] libavfilter: add filter dnn_detect for object detection

2021-02-19 Thread Guo, Yejun
> -Original Message- > From: Guo, Yejun > Sent: 2021年2月19日 15:00 > To: ffmpeg-devel@ffmpeg.org > Cc: Guo, Yejun > Subject: [PATCH 4/4] libavfilter: add filter dnn_detect for object detection > > Below are the example steps to do object detection: > > 1. download and install l_openvino

Re: [FFmpeg-devel] [RFC] Event loop

2021-02-19 Thread Nicolas George
Lynne (12021-02-19): > I found this document useful: > https://gist.github.com/andreybolonin/2413da76f088e2c5ab04df53f07659ea Thanks. But I think this document makes it clear that what we, FFmpeg, need, is not libuv. In fact, after looking in the docs and in the source, I could not even find how

Re: [FFmpeg-devel] [PATCH] Moves yuv2yuvX_sse3 to yasm, unrolls main loop and other small optimizations for ~20% speedup.

2021-02-19 Thread Alan Kelly
Thanks James for spotting this. I have sent two patches fixing the valgrind error from checkasm and the unchecked av_mallocs. I do not believe that the two remaining valgrind errors come from my patch, although I may be mistaken. Using git bisect, I have identified b94cd55155d8c061f1e1faca9076afe5

Re: [FFmpeg-devel] [PATCH] avcodec/indeo3: add support for more dimensions

2021-02-19 Thread Paul B Mahol
will apply ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH 2/2] tests/checkasm/sw_scale.c

2021-02-19 Thread Alan Kelly
Checks av_mallocs --- tests/checkasm/sw_scale.c | 4 1 file changed, 4 insertions(+) diff --git a/tests/checkasm/sw_scale.c b/tests/checkasm/sw_scale.c index a4866723d7..ef414c0a82 100644 --- a/tests/checkasm/sw_scale.c +++ b/tests/checkasm/sw_scale.c @@ -103,7 +103,11 @@ static void check_y

Re: [FFmpeg-devel] [PATCH] avfilter/vf_psnr: add support for slice threading

2021-02-19 Thread Paul B Mahol
will apply ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH 1/2] tests/checkasm/sw_scale.c

2021-02-19 Thread Alan Kelly
Initialises each item in src and filter arrays to fix valgrind uninitialised value warning. --- tests/checkasm/sw_scale.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tests/checkasm/sw_scale.c b/tests/checkasm/sw_scale.c index 7504f8b45f..a4866723d7 100644 --- a/tests/

Re: [FFmpeg-devel] [PATCH] When using ffmpeg to record screen, set the operating system time and set the system time backward. Stop screen recording, unable to save video.

2021-02-19 Thread Nicolas George
hou...@uniontech.com (12021-02-19): > From: Hou Lei > > Signed-off-by: Hou Lei > --- > libavdevice/xcbgrab.c | 11 ++- > 1 file changed, 10 insertions(+), 1 deletion(-) NAK. The correct fix is to use the monotonic clock for syncing. And make it an option to use it for frame timestamps

Re: [FFmpeg-devel] [PATCH] avfilter/vf_ssim: add slice threading

2021-02-19 Thread Paul B Mahol
will apply ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH] When using ffmpeg to record screen, set the operating system time and set the system time backward. Stop screen recording, unable to save video.

2021-02-19 Thread houlei
From: Hou Lei Signed-off-by: Hou Lei --- libavdevice/xcbgrab.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/libavdevice/xcbgrab.c b/libavdevice/xcbgrab.c index be5d5ea2cf..7e886064fe 100644 --- a/libavdevice/xcbgrab.c +++ b/libavdevice/xcbgrab.c @@ -208,7 +208