On Mon, Feb 15, 2021 at 3:45 AM Andreas Rheinhardt <
andreas.rheinha...@gmail.com> wrote:
> Nuo Mi:
> > From: Mark Thompson
> >
> >
> > -}
> > +static int cbs_h2645_replace_ps(CodedBitstreamContext *ctx,
> > +CodedBitstreamUnit *unit)
> > +{
> > +typedef struct
we keep an index in *opaque instead of a pointer.
---
libavformat/protocols.c | 19 ++-
1 file changed, 10 insertions(+), 9 deletions(-)
diff --git a/libavformat/protocols.c b/libavformat/protocols.c
index 7df18fbb3b..530e78150d 100644
--- a/libavformat/protocols.c
+++ b/libavform
Why you use pbm decoder for probing of pfm files?
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe"
Paul B Mahol:
> On Mon, Feb 15, 2021 at 2:29 AM Andreas Rheinhardt <
> andreas.rheinha...@gmail.com> wrote:
>
>> Paul B Mahol:
>>> Signed-off-by: Paul B Mahol
>>> ---
>>> libavcodec/Makefile| 1 +
>>> libavcodec/allcodecs.c | 1 +
>>> libavcodec/exrenc.c| 209
On Mon, Feb 15, 2021 at 2:29 AM Andreas Rheinhardt <
andreas.rheinha...@gmail.com> wrote:
> Paul B Mahol:
> > Signed-off-by: Paul B Mahol
> > ---
> > libavcodec/Makefile| 1 +
> > libavcodec/allcodecs.c | 1 +
> > libavcodec/exrenc.c| 209 +
> >
Paul B Mahol:
> Signed-off-by: Paul B Mahol
> ---
> libavcodec/Makefile| 1 +
> libavcodec/allcodecs.c | 1 +
> libavcodec/exrenc.c| 209 +
> libavformat/img2enc.c | 2 +-
> 4 files changed, 212 insertions(+), 1 deletion(-)
> create mode 100
Signed-off-by: Paul B Mahol
---
libavcodec/Makefile| 1 +
libavcodec/allcodecs.c | 1 +
libavcodec/exrenc.c| 209 +
libavformat/img2enc.c | 2 +-
4 files changed, 212 insertions(+), 1 deletion(-)
create mode 100644 libavcodec/exrenc.c
diff
Am Fr., 12. Feb. 2021 um 00:24 Uhr schrieb Paul B Mahol :
>
> On Fri, Feb 12, 2021 at 12:21 AM Carl Eugen Hoyos
> wrote:
>
> > Am Fr., 12. Feb. 2021 um 00:18 Uhr schrieb Paul B Mahol > >:
> > >
> > > This is variant of PFM images, PBM image format is only fixed point gray.
> >
> > Should I change
Am Mi., 10. Feb. 2021 um 19:50 Uhr schrieb Paul B Mahol :
>
> Just apply this, it is very unlikely that there are faster ways.
Thank you, patch applied.
Carl Eugen
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo
Such a scenario is undefined behaviour and would also indicate a bug
in our code.
Suggested-by: James Almer
Signed-off-by: Andreas Rheinhardt
---
libavformat/utils.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/libavformat/utils.c b/libavformat/utils.c
index cea6d4ca92..652758e98e 100644
James Almer:
> On 2/14/2021 6:28 PM, Andreas Rheinhardt wrote:
>> This is undefined behaviour in C, so use data = len ? data + len : data
>> instead if data += len. GCC optimizes the branch away in this case;
>> Clang unfortunately doesn't.
>>
>> Signed-off-by: Andreas Rheinhardt
>> ---
>> Checkin
On 2/14/2021 6:28 PM, Andreas Rheinhardt wrote:
This is undefined behaviour in C, so use data = len ? data + len : data
instead if data += len. GCC optimizes the branch away in this case;
Clang unfortunately doesn't.
Signed-off-by: Andreas Rheinhardt
---
Checking for len != 0 instead of > 0 all
probably fine
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
On 2/14/2021 6:36 PM, Andreas Rheinhardt wrote:
James Almer:
On 2/14/2021 6:23 PM, Andreas Rheinhardt wrote:
James Almer:
On 2/14/2021 6:09 PM, Paul B Mahol wrote:
Fixes following report:
libavformat/utils.c:1429:14: runtime error: applying zero offset to
null pointer
How is data NULL here?
James Almer:
> On 2/14/2021 6:23 PM, Andreas Rheinhardt wrote:
>> James Almer:
>>> On 2/14/2021 6:09 PM, Paul B Mahol wrote:
Fixes following report:
libavformat/utils.c:1429:14: runtime error: applying zero offset to
null pointer
>>>
>>> How is data NULL here? That's the input packet
On 2/14/2021 6:23 PM, Andreas Rheinhardt wrote:
James Almer:
On 2/14/2021 6:09 PM, Paul B Mahol wrote:
Fixes following report:
libavformat/utils.c:1429:14: runtime error: applying zero offset to
null pointer
How is data NULL here? That's the input packet's data pointer, and this
loop is acces
This is undefined behaviour in C, so use data = len ? data + len : data
instead if data += len. GCC optimizes the branch away in this case;
Clang unfortunately doesn't.
Signed-off-by: Andreas Rheinhardt
---
Checking for len != 0 instead of > 0 allows the compiler to optimize the
branch away; mayb
James Almer:
> On 2/14/2021 6:09 PM, Paul B Mahol wrote:
>> Fixes following report:
>> libavformat/utils.c:1429:14: runtime error: applying zero offset to
>> null pointer
>
> How is data NULL here? That's the input packet's data pointer, and this
> loop is accessed only if size is > 0. data == NUL
On 2/14/2021 6:09 PM, Paul B Mahol wrote:
Fixes following report:
libavformat/utils.c:1429:14: runtime error: applying zero offset to null pointer
How is data NULL here? That's the input packet's data pointer, and this
loop is accessed only if size is > 0. data == NULL and size != 0 doesn't
s
Fixes following report:
libavformat/utils.c:1429:14: runtime error: applying zero offset to null pointer
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior
libavformat/utils.c:1429:14
Signed-off-by: Paul B Mahol
---
libavformat/utils.c | 6 --
1 file changed, 4 insertions(+), 2 deletio
On 2/14/2021 10:16 AM, Andreas Rheinhardt wrote:
Nuo Mi:
On Mon, Feb 15, 2021 at 2:08 AM Andreas Rheinhardt <
andreas.rheinha...@gmail.com> wrote:
Nuo Mi:
---
libavutil/opt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavutil/opt.c b/libavutil/opt.c
index 590146b
Nuo Mi:
> From: Mark Thompson
>
> ---
> libavcodec/cbs_h2645.c | 171 +++--
> 1 file changed, 130 insertions(+), 41 deletions(-)
>
> diff --git a/libavcodec/cbs_h2645.c b/libavcodec/cbs_h2645.c
> index 6005d46e0d..36212d1da6 100644
> --- a/libavcodec/cbs_h264
Signed-off-by: Andreas Rheinhardt
---
libavutil/video_enc_params.c | 4
1 file changed, 4 insertions(+)
diff --git a/libavutil/video_enc_params.c b/libavutil/video_enc_params.c
index b9cdafddbb..635176ab91 100644
--- a/libavutil/video_enc_params.c
+++ b/libavutil/video_enc_params.c
@@ -63,6
This patch also fixes a -Wtautological-constant-out-of-range-compare
warning from Clang and a -Wtype-limits warning from GCC on systems
where size_t is 64bits and unsigned 32bits. The reason for this seems
to be that variable (whose value derives from sizeof() and can therefore
be known at compile-
>
> That said, if you have a general use-case where this is helpful and the
> documentation explains what it is doing (and warns about the bad cases)
> then maybe?
>
The main use case we have internally is to able to run multiple instances
of SvtAv1EncApp with `--lp 1` without worrying about poten
On Mon, Feb 15, 2021 at 2:04 AM Andreas Rheinhardt <
andreas.rheinha...@gmail.com> wrote:
> Carl Eugen Hoyos:
> > Am So., 14. Feb. 2021 um 18:00 Uhr schrieb Paul B Mahol <
> one...@gmail.com>:
> >>
> >> On Sun, Feb 14, 2021 at 5:58 PM Carl Eugen Hoyos
> wrote:
> >>
> >>> Am So., 14. Feb. 2021 um
Nuo Mi:
> On Mon, Feb 15, 2021 at 2:02 AM Carl Eugen Hoyos wrote:
>
>> Am So., 14. Feb. 2021 um 18:57 Uhr schrieb Nuo Mi :
>>
>> https://github.com/FFmpeg/FFmpeg/blob/21346672270ae723aa774a9c8b0749954a75b3df/libavcodec/movtextenc.c#L110
>>> s->count * sizeof(*s->style_attributes) never >
Nuo Mi:
> On Mon, Feb 15, 2021 at 2:08 AM Andreas Rheinhardt <
> andreas.rheinha...@gmail.com> wrote:
>
>> Nuo Mi:
>>> ---
>>> libavutil/opt.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/libavutil/opt.c b/libavutil/opt.c
>>> index 590146b5fb..c554e9c063 100644
>
Fixes #6581
Signed-off-by: Paul B Mahol
---
libavcodec/indeo3.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavcodec/indeo3.c b/libavcodec/indeo3.c
index 75113a7541..5257d983c2 100644
--- a/libavcodec/indeo3.c
+++ b/libavcodec/indeo3.c
@@ -171,7 +171,7 @@ static av_cold
On Mon, Feb 15, 2021 at 2:08 AM Andreas Rheinhardt <
andreas.rheinha...@gmail.com> wrote:
> Nuo Mi:
> > ---
> > libavutil/opt.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/libavutil/opt.c b/libavutil/opt.c
> > index 590146b5fb..c554e9c063 100644
> > --- a/libavu
On Mon, Feb 15, 2021 at 2:02 AM Carl Eugen Hoyos wrote:
> Am So., 14. Feb. 2021 um 18:57 Uhr schrieb Nuo Mi :
>
> > >
> https://github.com/FFmpeg/FFmpeg/blob/21346672270ae723aa774a9c8b0749954a75b3df/libavcodec/movtextenc.c#L110
> > > > > > s->count * sizeof(*s->style_attributes) never > 32 bits.
Nuo Mi:
> ---
> libavutil/opt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavutil/opt.c b/libavutil/opt.c
> index 590146b5fb..c554e9c063 100644
> --- a/libavutil/opt.c
> +++ b/libavutil/opt.c
> @@ -1735,7 +1735,7 @@ const AVClass *av_opt_child_class_iterate(const
Carl Eugen Hoyos:
> Am So., 14. Feb. 2021 um 18:00 Uhr schrieb Paul B Mahol :
>>
>> On Sun, Feb 14, 2021 at 5:58 PM Carl Eugen Hoyos wrote:
>>
>>> Am So., 14. Feb. 2021 um 17:53 Uhr schrieb Nuo Mi :
---
libavformat/protocols.c | 4 ++--
1 file changed, 2 insertions(+), 2 delet
Am So., 14. Feb. 2021 um 18:57 Uhr schrieb Nuo Mi :
> > https://github.com/FFmpeg/FFmpeg/blob/21346672270ae723aa774a9c8b0749954a75b3df/libavcodec/movtextenc.c#L110
> > > > > s->count * sizeof(*s->style_attributes) never > 32 bits.
> >
> > This is not correct afaict:
> > The relevant line is 369 no
On Mon, Feb 15, 2021 at 1:39 AM Carl Eugen Hoyos wrote:
> Am So., 14. Feb. 2021 um 18:15 Uhr schrieb Nuo Mi :
> >
> > On Mon, Feb 15, 2021 at 1:05 AM Carl Eugen Hoyos
> wrote:
> >
> > > Am So., 14. Feb. 2021 um 17:30 Uhr schrieb Nuo Mi >:
> > > >
> > > > On Sun, Feb 14, 2021 at 6:35 PM Anton Kh
On Sun, Feb 14, 2021 at 6:36 PM Carl Eugen Hoyos wrote:
> Am So., 14. Feb. 2021 um 18:00 Uhr schrieb Paul B Mahol >:
> >
> > On Sun, Feb 14, 2021 at 5:58 PM Carl Eugen Hoyos
> wrote:
> >
> > > Am So., 14. Feb. 2021 um 17:53 Uhr schrieb Nuo Mi >:
> > > >
> > > > ---
> > > > libavformat/protoco
Am So., 14. Feb. 2021 um 18:15 Uhr schrieb Nuo Mi :
>
> On Mon, Feb 15, 2021 at 1:05 AM Carl Eugen Hoyos wrote:
>
> > Am So., 14. Feb. 2021 um 17:30 Uhr schrieb Nuo Mi :
> > >
> > > On Sun, Feb 14, 2021 at 6:35 PM Anton Khirnov wrote:
> > >
> > > > Quoting Nuo Mi (2021-02-14 07:27:39)
> > > > > C
Am So., 14. Feb. 2021 um 18:00 Uhr schrieb Paul B Mahol :
>
> On Sun, Feb 14, 2021 at 5:58 PM Carl Eugen Hoyos wrote:
>
> > Am So., 14. Feb. 2021 um 17:53 Uhr schrieb Nuo Mi :
> > >
> > > ---
> > > libavformat/protocols.c | 4 ++--
> > > 1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > >
On Mon, Feb 15, 2021 at 1:05 AM Carl Eugen Hoyos wrote:
> Am So., 14. Feb. 2021 um 17:30 Uhr schrieb Nuo Mi :
> >
> > On Sun, Feb 14, 2021 at 6:35 PM Anton Khirnov wrote:
> >
> > > Quoting Nuo Mi (2021-02-14 07:27:39)
> > > > CC libavcodec/mpegaudiodec_common.o
> > > > libavcodec/movtextenc
Am So., 14. Feb. 2021 um 17:57 Uhr schrieb Nuo Mi :
>
> On Mon, Feb 15, 2021 at 12:41 AM Nuo Mi wrote:
>
> > This will fix following compile warning:
> >
> > libavutil/video_enc_params.c: In function ‘av_video_enc_params_alloc:
> >
> >
> >libavutil/video_enc_params.c:36:19: warning
This will fix following compile warning:
libavutil/video_enc_params.c: In function ‘av_video_enc_params_alloc:
libavutil/video_
Am So., 14. Feb. 2021 um 17:30 Uhr schrieb Nuo Mi :
>
> On Sun, Feb 14, 2021 at 6:35 PM Anton Khirnov wrote:
>
> > Quoting Nuo Mi (2021-02-14 07:27:39)
> > > CC libavcodec/mpegaudiodec_common.o
> > > libavcodec/movtextenc.c: In function ‘mov_text_style_start’:
> > > libavcodec/movtextenc.c:35
On Sun, Feb 14, 2021 at 5:58 PM Carl Eugen Hoyos wrote:
> Am So., 14. Feb. 2021 um 17:53 Uhr schrieb Nuo Mi :
> >
> > ---
> > libavformat/protocols.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/libavformat/protocols.c b/libavformat/protocols.c
> > index 7df
Am So., 14. Feb. 2021 um 17:53 Uhr schrieb Nuo Mi :
>
> ---
> libavformat/protocols.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/libavformat/protocols.c b/libavformat/protocols.c
> index 7df18fbb3b..0b43f66baf 100644
> --- a/libavformat/protocols.c
> +++ b/libavfo
On Mon, Feb 15, 2021 at 12:41 AM Nuo Mi wrote:
> This will fix following compile warning:
>
> libavutil/video_enc_params.c: In function ‘av_video_enc_params_alloc:
>
>
>libavutil/video_enc_params.c:36:19: warning: comparison is
> always false due to limited range of data type [-Wt
---
libavutil/opt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavutil/opt.c b/libavutil/opt.c
index 590146b5fb..c554e9c063 100644
--- a/libavutil/opt.c
+++ b/libavutil/opt.c
@@ -1735,7 +1735,7 @@ const AVClass *av_opt_child_class_iterate(const AVClass
*parent, void **i
Am So., 14. Feb. 2021 um 17:10 Uhr schrieb Paul B Mahol :
>
> Signed-off-by: Paul B Mahol
> ---
> libavcodec/pngdec.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/libavcodec/pngdec.c b/libavcodec/pngdec.c
> index 61642b7cbe..f0e2a0cad4 100644
> --- a/libavcodec/pn
---
libavformat/protocols.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/libavformat/protocols.c b/libavformat/protocols.c
index 7df18fbb3b..0b43f66baf 100644
--- a/libavformat/protocols.c
+++ b/libavformat/protocols.c
@@ -111,10 +111,10 @@ const AVClass *ff_urlcontext_c
On Sun, Feb 14, 2021 at 6:35 PM Anton Khirnov wrote:
> Quoting Nuo Mi (2021-02-14 07:27:39)
> > CC libavcodec/mpegaudiodec_common.o
> > libavcodec/movtextenc.c: In function ‘mov_text_style_start’:
> > libavcodec/movtextenc.c:358:26: warning: comparison is always false due
> to limited range
Signed-off-by: Paul B Mahol
---
libavcodec/pngdec.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/libavcodec/pngdec.c b/libavcodec/pngdec.c
index 61642b7cbe..f0e2a0cad4 100644
--- a/libavcodec/pngdec.c
+++ b/libavcodec/pngdec.c
@@ -1090,8 +1090,8 @@ static int handle_p_
Signed-off-by: Paul B Mahol
---
libavfilter/x86/vf_gblur.asm| 49 +
libavfilter/x86/vf_gblur_init.c | 17 ++--
2 files changed, 63 insertions(+), 3 deletions(-)
diff --git a/libavfilter/x86/vf_gblur.asm b/libavfilter/x86/vf_gblur.asm
index a25b1659f5..
Signed-off-by: Paul B Mahol
---
libavfilter/gblur.h| 2 ++
libavfilter/vf_gblur.c | 23 ++-
2 files changed, 16 insertions(+), 9 deletions(-)
diff --git a/libavfilter/gblur.h b/libavfilter/gblur.h
index 15a8167fe5..dce50671f6 100644
--- a/libavfilter/gblur.h
+++ b/libavf
On Sat, Feb 13, 2021 at 4:31 PM Jan Ekström wrote:
>
> On Sat, Feb 13, 2021 at 12:48 AM sfan5 wrote:
> >
> > 12.02.21 - 21:43 - Andreas Rheinhardt:
> > > sfan5:
> > >> Hi,
> > >>
> > >>
> > >> attached v2 patch after discussion on IRC with JEEB (as he already
> > >> mentioned).
> > >>
> > >> Only
Quoting Paul B Mahol (2021-02-14 11:48:14)
> On Sun, Feb 14, 2021 at 11:44 AM Anton Khirnov wrote:
>
> > Quoting Paul B Mahol (2021-02-14 11:41:20)
> > > On Sun, Feb 14, 2021 at 11:21 AM Anton Khirnov
> > wrote:
> > >
> > > > Quoting Paul B Mahol (2021-02-11 22:58:33)
> > > > > Fixes #9017
> > >
On Sun, Feb 14, 2021 at 11:44 AM Anton Khirnov wrote:
> Quoting Paul B Mahol (2021-02-14 11:41:20)
> > On Sun, Feb 14, 2021 at 11:21 AM Anton Khirnov
> wrote:
> >
> > > Quoting Paul B Mahol (2021-02-11 22:58:33)
> > > > Fixes #9017
> > > >
> > > > Signed-off-by: Paul B Mahol
> > > > ---
> > > >
Quoting Paul B Mahol (2021-02-14 11:41:20)
> On Sun, Feb 14, 2021 at 11:21 AM Anton Khirnov wrote:
>
> > Quoting Paul B Mahol (2021-02-11 22:58:33)
> > > Fixes #9017
> > >
> > > Signed-off-by: Paul B Mahol
> > > ---
> > > libavcodec/pngdec.c | 4 ++--
> > > 1 file changed, 2 insertions(+), 2 de
On Sun, Feb 14, 2021 at 11:21 AM Anton Khirnov wrote:
> Quoting Paul B Mahol (2021-02-11 22:58:33)
> > Fixes #9017
> >
> > Signed-off-by: Paul B Mahol
> > ---
> > libavcodec/pngdec.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/libavcodec/pngdec.c b/libavco
Quoting Nuo Mi (2021-02-14 07:26:56)
> This will fix following compile warning:
>
> libavutil/video_enc_params.c: In function ‘av_video_enc_params_alloc’:
>
>
Quoting Nuo Mi (2021-02-14 07:27:39)
> CC libavcodec/mpegaudiodec_common.o
> libavcodec/movtextenc.c: In function ‘mov_text_style_start’:
> libavcodec/movtextenc.c:358:26: warning: comparison is always false due to
> limited range of data type [-Wtype-limits]
> 358 | if (s->count +
queued, will push in a bit
--
Anton Khirnov
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Quoting Paul B Mahol (2021-02-11 22:58:33)
> Fixes #9017
>
> Signed-off-by: Paul B Mahol
> ---
> libavcodec/pngdec.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/libavcodec/pngdec.c b/libavcodec/pngdec.c
> index 395b86bbe7..61642b7cbe 100644
> --- a/libavcodec/pn
61 matches
Mail list logo
