Re: [FFmpeg-devel] [PATCH 1/4] avformat/matroskadec: Check for EOF in resync loop

2021-02-01 Thread Andreas Rheinhardt
Michael Niedermayer: > Fixes: Timeout (too long -> instantly) > Fixes: > 29136/clusterfuzz-testcase-minimized-ffmpeg_dem_WEBM_DASH_MANIFEST_fuzzer-4586141227548672 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael N

Re: [FFmpeg-devel] [PATCH] avdevice/xcbgrab: don't assume Xserver endianness

2021-02-01 Thread Andriy Gelman
On Sun, 31. Jan 23:28, Carl Eugen Hoyos wrote: > Am So., 31. Jan. 2021 um 20:51 Uhr schrieb Andriy Gelman > : > > > > From: Andriy Gelman > > > > Xserver defines the endianness of the grabbed images. Use this information > > to set the correct pixel format. > > lgtm if tested. Thanks, will apply

Re: [FFmpeg-devel] [PATCH v6 1/3] avformat/mxfdec: set toolkit version metadata

2021-02-01 Thread lance . lmwang
On Mon, Feb 01, 2021 at 08:14:25PM +0100, Tomas Härdin wrote: > mån 2021-02-01 klockan 18:23 +0100 skrev Andreas Rheinhardt: > > Tomas Härdin: > > > mån 2021-02-01 klockan 07:50 +0800 skrev lance.lmw...@gmail.com: > > > > From: Limin Wang > > > > > > > > Please check the string of toolkit version

Re: [FFmpeg-devel] [PATCH v6 1/3] avformat/mxfdec: set toolkit version metadata

2021-02-01 Thread lance . lmwang
On Mon, Feb 01, 2021 at 08:15:33PM +0100, Marton Balint wrote: > > > On Mon, 1 Feb 2021, lance.lmw...@gmail.com wrote: > > > From: Limin Wang > > > > Please check the string of toolkit version with below command: > > ./ffmpeg -i ../fate-suite/mxf/Sony-1.mxf -c:v copy -c:a copy out.mxf > >

Re: [FFmpeg-devel] [PATCH 6/8] avcodec/cri: Use ff_set_dimensions()

2021-02-01 Thread Paul B Mahol
LGTM ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH 09/10] fftools/ffplay: use av_packet_alloc() to allocate packets

2021-02-01 Thread James Almer
Signed-off-by: James Almer --- fftools/ffplay.c | 222 --- 1 file changed, 135 insertions(+), 87 deletions(-) diff --git a/fftools/ffplay.c b/fftools/ffplay.c index 9ff0425163..ef954772ed 100644 --- a/fftools/ffplay.c +++ b/fftools/ffplay.c @@ -36,6 +3

Re: [FFmpeg-devel] [PATCH] avformat/mxf: Establish register of local tags

2021-02-01 Thread Tomas Härdin
mån 2021-02-01 klockan 11:37 +0100 skrev Tomas Härdin: > fre 2021-01-29 klockan 22:06 +0100 skrev Marton Balint: > > On Thu, 28 Jan 2021, Tomas Härdin wrote: > > > > > tor 2021-01-28 klockan 14:48 +0100 skrev Tomas Härdin: > > > > tor 2021-01-28 klockan 08:56 +0100 skrev Marton Balint: > > > > > O

[FFmpeg-devel] [PATCH 05/10] doc/examples/transcode_aac: use av_packet_alloc() to allocate packets

2021-02-01 Thread James Almer
Signed-off-by: James Almer --- doc/examples/transcode_aac.c | 46 +--- 1 file changed, 27 insertions(+), 19 deletions(-) diff --git a/doc/examples/transcode_aac.c b/doc/examples/transcode_aac.c index e0c76f5b35..73786ab59b 100644 --- a/doc/examples/transcode_aac.c

[FFmpeg-devel] [PATCH 08/10] fftools/ffmpeg: use av_packet_alloc() to allocate packets

2021-02-01 Thread James Almer
Signed-off-by: James Almer --- fftools/ffmpeg.c | 318 +++ fftools/ffmpeg.h | 4 + fftools/ffmpeg_opt.c | 5 +- 3 files changed, 177 insertions(+), 150 deletions(-) diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c index d7c833be63..2667f226b4 1

[FFmpeg-devel] [PATCH 04/10] doc/examples/demuxing_decoding: use av_packet_alloc() to allocate packets

2021-02-01 Thread James Almer
Signed-off-by: James Almer --- doc/examples/demuxing_decoding.c | 25 ++--- 1 file changed, 14 insertions(+), 11 deletions(-) diff --git a/doc/examples/demuxing_decoding.c b/doc/examples/demuxing_decoding.c index 803e35d25c..db5e0cb951 100644 --- a/doc/examples/demuxing_decod

[FFmpeg-devel] [PATCH 10/10] avcodec/packet: deprecate av_init_packet()

2021-02-01 Thread James Almer
Once removed, sizeof(AVPacket) will stop being a part of the public ABI. Signed-off-by: James Almer --- libavcodec/avpacket.c | 23 +++ libavcodec/packet.h| 23 +++ libavcodec/version.h | 3 +++ libavformat/avformat.h | 4 4 files changed, 41

[FFmpeg-devel] [PATCH 07/10] fftools/ffprobe: use av_packet_alloc() to allocate packets

2021-02-01 Thread James Almer
Signed-off-by: James Almer --- fftools/ffprobe.c | 34 +++--- 1 file changed, 19 insertions(+), 15 deletions(-) diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c index 3453aa09ff..68fecd61e5 100644 --- a/fftools/ffprobe.c +++ b/fftools/ffprobe.c @@ -2465,14 +2465,12

[FFmpeg-devel] [PATCH 06/10] doc/examples/transcoding: use av_packet_alloc() to allocate packets

2021-02-01 Thread James Almer
Signed-off-by: James Almer --- doc/examples/transcoding.c | 48 ++ 1 file changed, 28 insertions(+), 20 deletions(-) diff --git a/doc/examples/transcoding.c b/doc/examples/transcoding.c index 5aff08c135..6ca3089330 100644 --- a/doc/examples/transcoding.c +++ b

[FFmpeg-devel] [PATCH 02/10] avformat/movenc: use av_packet_alloc() to allocate packets

2021-02-01 Thread James Almer
Signed-off-by: James Almer --- libavformat/movenc.c | 101 --- libavformat/movenc.h | 2 + libavformat/movenchint.c | 19 libavformat/mux.c| 4 +- 4 files changed, 77 insertions(+), 49 deletions(-) diff --git a/libavformat/movenc.

[FFmpeg-devel] [PATCH 03/10] avformat/utils: use av_packet_alloc() to allocate packets

2021-02-01 Thread James Almer
Signed-off-by: James Almer --- av_get_packet() and av_read_frame() were allowed to be called with uninitialized packets in stack, so to keep supporting that we need to leave the calls to av_init_packet() in place during the deprecation period. libavformat/internal.h | 1 + libavformat/options.

[FFmpeg-devel] [PATCH 01/10] avformat/mux: use av_packet_alloc() to allocate packets

2021-02-01 Thread James Almer
Signed-off-by: James Almer --- libavformat/internal.h | 5 + libavformat/mux.c | 40 libavformat/options.c | 6 ++ libavformat/utils.c| 1 + 4 files changed, 32 insertions(+), 20 deletions(-) diff --git a/libavformat/internal.h b/liba

[FFmpeg-devel] [PATCH 00/10] deprecate av_init_packet() and sizeof(AVPacket) as part of the ABI

2021-02-01 Thread James Almer
As the subject says, this puts AVPacket in line with AVFrame, allowing easier extensibility of the struct, and preventing potential undefined behavior in some cases when packets are used uninitialized on stack. This set adapts only a few modules, examples, and the tools, as those were the most com

[FFmpeg-devel] [PATCH 4/8] avformat/mxfdec: Fix file position addition

2021-02-01 Thread Michael Niedermayer
Not sure this is the best solution, maybe a more general solution limiting the avio_tell() output to less than 63bit would be a better option Fixes: signed integer overflow: 9223372036854775805 + 4 cannot be represented in type 'long' Fixes: 29927/clusterfuzz-testcase-minimized-ffmpeg_dem_MXF_fu

[FFmpeg-devel] [PATCH 8/8] avcodec/exr: Check col/line for integer overflow

2021-02-01 Thread Michael Niedermayer
Fixes: signed integer overflow: -2272 + -2147483360 cannot be represented in type 'int' Fixes: 30009/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_EXR_fuzzer-5005660322398208 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: M

[FFmpeg-devel] [PATCH 5/8] avcodec/cri: Stop the bitreader at the end of uncompressed input

2021-02-01 Thread Michael Niedermayer
Fixes: Timeout Fixes: 29983/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_CRI_fuzzer-6420415838814208 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/cri.c | 3 +++ 1 file changed, 3 inser

[FFmpeg-devel] [PATCH 7/8] tools/target_dec_fuzzer: Update maxpixels_per_frame for low thresholds

2021-02-01 Thread Michael Niedermayer
Fixes: Timeout Fixes: 29990/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MSS2_fuzzer-5469155073589248 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- tools/target_dec_fuzzer.c | 3 ++- 1 file change

[FFmpeg-devel] [PATCH 6/8] avcodec/cri: Use ff_set_dimensions()

2021-02-01 Thread Michael Niedermayer
Fixes: out of memory Fixes: 29985/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_CRI_fuzzer-6424425392111616 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/cri.c | 8 ++-- 1 file chang

[FFmpeg-devel] [PATCH 2/8] avformat/ipmovie: Free packets allocated in header reading

2021-02-01 Thread Michael Niedermayer
Fixes: memleaks Fixes: 29905/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-5679700745781248 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavformat/ipmovie.c | 8 ++-- 1 file changed, 6 in

[FFmpeg-devel] [PATCH 1/8] avcodec/cbs_sei_syntax_template: Check for non negativity before setting size_t bits_left

2021-02-01 Thread Michael Niedermayer
Fixes: Timeout Fixes: 29892/clusterfuzz-testcase-minimized-ffmpeg_BSF_H264_REDUNDANT_PPS_fuzzer-6310830956216320 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/cbs_sei_syntax_template.c | 2 +

[FFmpeg-devel] [PATCH 3/8] avcodec/utils: Use more bits for intermediate for AV_CODEC_ID_ADPCM_MS

2021-02-01 Thread Michael Niedermayer
Fixes: signed integer overflow: 1172577312 * 2 cannot be represented in type 'int' Fixes: 29924/clusterfuzz-testcase-minimized-ffmpeg_dem_BOA_fuzzer-4882912874594304 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Nieder

Re: [FFmpeg-devel] [RFC] Event loop

2021-02-01 Thread James Almer
On 2/1/2021 4:14 PM, Nicolas George wrote: 1.3. Implement a libev wrapper. Implement the callbacks of the event loop API with libev as back-end. Make it either an example or a build option. A build option would have the benefit of more extensive testing. I support the idea

Re: [FFmpeg-devel] [RFC] Event loop

2021-02-01 Thread Nicolas George
Paul B Mahol (12021-02-01): > Why event loop is needed for filters? > > libavcodec have frame threads and it does not need it. libavcodec has its own scheduler. Duplicated code everywhere. -- Nicolas George signature.asc Description: PGP signature ___

Re: [FFmpeg-devel] [RFC] Event loop

2021-02-01 Thread Paul B Mahol
On Mon, Feb 1, 2021 at 8:14 PM Nicolas George wrote: > Based on this discussion, I say that the need for an event loop is > confirmed. > > I will now start discussing actual plans for going forward. Since the > coding work will be significant and not incremental, I want the outcome > of this disc

Re: [FFmpeg-devel] [PATCH v6 1/3] avformat/mxfdec: set toolkit version metadata

2021-02-01 Thread Marton Balint
On Mon, 1 Feb 2021, lance.lmw...@gmail.com wrote: From: Limin Wang Please check the string of toolkit version with below command: ./ffmpeg -i ../fate-suite/mxf/Sony-1.mxf -c:v copy -c:a copy out.mxf ./ffmpeg -i out.mxf toolkit_version : 58.65.101 Signed-off-by: Limin Wang --- liba

Re: [FFmpeg-devel] [PATCH v6 1/3] avformat/mxfdec: set toolkit version metadata

2021-02-01 Thread Tomas Härdin
mån 2021-02-01 klockan 18:23 +0100 skrev Andreas Rheinhardt: > Tomas Härdin: > > mån 2021-02-01 klockan 07:50 +0800 skrev lance.lmw...@gmail.com: > > > From: Limin Wang > > > > > > Please check the string of toolkit version with below command: > > > ./ffmpeg -i ../fate-suite/mxf/Sony-1.mxf -c

Re: [FFmpeg-devel] [RFC] Event loop

2021-02-01 Thread Nicolas George
Based on this discussion, I say that the need for an event loop is confirmed. I will now start discussing actual plans for going forward. Since the coding work will be significant and not incremental, I want the outcome of this discussion to be binding: if we agree to do it a certain way, then the

Re: [FFmpeg-devel] [PATCH v6 1/3] avformat/mxfdec: set toolkit version metadata

2021-02-01 Thread Andreas Rheinhardt
Tomas Härdin: > mån 2021-02-01 klockan 07:50 +0800 skrev lance.lmw...@gmail.com: >> From: Limin Wang >> >> Please check the string of toolkit version with below command: >> ./ffmpeg -i ../fate-suite/mxf/Sony-1.mxf -c:v copy -c:a copy out.mxf >> ./ffmpeg -i out.mxf >> >> toolkit_version :

Re: [FFmpeg-devel] [PATCH 2/4] lav/dnxhd: CID 1256 is RGB, not BGR or YUV444

2021-02-01 Thread Christophe Gisquet
Hi, Le dim. 31 janv. 2021 à 14:11, Michael Niedermayer a écrit : > This transmutes the following dog into a hyperspace neon dog > ./ffplay DNxHDtest2.mov I'm not sure I prefer the correct version, but here goes. This sample is YUV444 basically, the reverse of what I've seen in another sample. -

Re: [FFmpeg-devel] [PATCH 04/13] avformat/rtmppkt: Remove ff_amf_read_bool

2021-02-01 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Added in 50468f93e3940ba78836dfdac5165c20ae75327a, but never used. > > Signed-off-by: Andreas Rheinhardt > --- > libavformat/rtmppkt.c | 8 > libavformat/rtmppkt.h | 9 - > 2 files changed, 17 deletions(-) > > diff --git a/libavformat/rtmppkt.c b/libavform

[FFmpeg-devel] [PATCH] avfilter: add colorcorrect filter

2021-02-01 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- doc/filters.texi | 33 + libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/vf_colorcorrect.c | 218 ++ 4 files changed, 253 insertions(+) create mode 100644 libavfilter/vf_co

Re: [FFmpeg-devel] [PATCH 1/5] avformat/sbgdec: Use av_sat_add64() in str_to_time()

2021-02-01 Thread Michael Niedermayer
On Mon, Feb 01, 2021 at 11:39:42AM +0100, Nicolas George wrote: > Michael Niedermayer (12021-01-31): > > Fixes: signed integer overflow: 727999279212000 + 4611686018427387904 > > cannot be represented in type 'long long' > > Fixes: > > 29744/clusterfuzz-testcase-minimized-ffmpeg_dem_SBG_fuzze

Re: [FFmpeg-devel] [PATCH] avfilter: Added siti filter

2021-02-01 Thread Nicolas George
Werner Robitza (12021-01-22): > Thanks, I know this, but this is not a known format that can be easily > parsed like a plain CSV file. What you need to do is to extend the metadata filter so that it lets output to a file and choose the format. Regards, -- Nicolas George signature.asc Descri

Re: [FFmpeg-devel] [PATCH] avdevice/avdevice: Deprecate AVDevice Capabilities API

2021-02-01 Thread Nicolas George
Mark Thompson (12021-01-27): > See for example the list of suggestions I made for improving the API a few > days ago. I intended to reply to them, but the conversation never came back to it before now. > * Handle frames as well as packets. Already possible. > * Including hardware frames - DR

Re: [FFmpeg-devel] [PATCH v6 2/3] avformat/mxf: add platform local tag

2021-02-01 Thread lance . lmwang
On Mon, Feb 01, 2021 at 04:18:08PM +0100, Tomas Härdin wrote: > mån 2021-02-01 klockan 22:54 +0800 skrev lance.lmw...@gmail.com: > > On Mon, Feb 01, 2021 at 12:01:02PM +0100, Tomas Härdin wrote: > > > mån 2021-02-01 klockan 07:50 +0800 skrev lance.lmw...@gmail.com: > > > > From: Limin Wang > > > >

Re: [FFmpeg-devel] [PATCH] libavformat: add librist protocol

2021-02-01 Thread Sergio M. Ammirata, Ph.D.
On Mon, 2021-02-01 at 16:25 +0100, Nicolas George wrote: > Sergio M. Ammirata, Ph.D. (12021-02-01): > This is a packet protocol. In your example above, > thereader will get three reads of 20, 30 and 40 > Thank you for the clarification. I looked a little in the > code in themeantime. > Considerin

Re: [FFmpeg-devel] [PATCH] libavformat: add librist protocol

2021-02-01 Thread Nicolas George
Sergio M. Ammirata, Ph.D. (12021-02-01): > This is a packet protocol. In your example above, the > reader will get three reads of 20, 30 and 40 Thank you for the clarification. I looked a little in the code in the meantime. Considering what was said, h->max_packet_size should be set to the maximu

Re: [FFmpeg-devel] [PATCH v6 2/3] avformat/mxf: add platform local tag

2021-02-01 Thread Tomas Härdin
mån 2021-02-01 klockan 22:54 +0800 skrev lance.lmw...@gmail.com: > On Mon, Feb 01, 2021 at 12:01:02PM +0100, Tomas Härdin wrote: > > mån 2021-02-01 klockan 07:50 +0800 skrev lance.lmw...@gmail.com: > > > From: Limin Wang > > > > > > Please check the string of platform with below command: > > > ./

Re: [FFmpeg-devel] [PATCH] libavformat: add librist protocol

2021-02-01 Thread Sergio M. Ammirata, Ph.D.
> Can you clarify something? Is this supposed to be a > packet protocol or astream protocol? > I.e., if the reader is waiting for 100 octets, and the > writer sent 20then 30 then 40, will the reader get three > reads of 20, 30, 40 or asingle read of 20+30+40=90? This is a packet protocol. In your

Re: [FFmpeg-devel] [PATCH v6 2/3] avformat/mxf: add platform local tag

2021-02-01 Thread lance . lmwang
On Mon, Feb 01, 2021 at 12:01:02PM +0100, Tomas Härdin wrote: > mån 2021-02-01 klockan 07:50 +0800 skrev lance.lmw...@gmail.com: > > From: Limin Wang > > > > Please check the string of platform with below command: > > ./ffmpeg -i ../fate-suite/mxf/Sony-1.mxf -c:v copy -c:a copy out.mxf > > ./

Re: [FFmpeg-devel] [PATCH v6 1/3] avformat/mxfdec: set toolkit version metadata

2021-02-01 Thread lance . lmwang
On Mon, Feb 01, 2021 at 11:56:25AM +0100, Tomas Härdin wrote: > mån 2021-02-01 klockan 07:50 +0800 skrev lance.lmw...@gmail.com: > > From: Limin Wang > > > > Please check the string of toolkit version with below command: > > ./ffmpeg -i ../fate-suite/mxf/Sony-1.mxf -c:v copy -c:a copy out.mxf

Re: [FFmpeg-devel] [PATCH] libavformat: add librist protocol

2021-02-01 Thread Nicolas George
Rodney Baker (12021-02-02): > Nagle can introduce unwanted latency which is not desirable for real-time > streaming. Mind you, tcp is inappropriate for real-time streaming anyway - > that's what rtsp was invented for. I don't think Nagle belongs at app level > anyway - it's a network stack funct

Re: [FFmpeg-devel] [PATCH] libavformat: add librist protocol

2021-02-01 Thread Rodney Baker
On Tuesday, 2 February 2021 0:52:23 ACDT Nicolas George wrote: > Sergio M. Ammirata, Ph.D. (12021-01-31): > > For writing, the data you give librist, will go out "as is" > > to the network with some added protocol overhead bytes (28 > > bytes without encryption enabled and 36 bytes with > > encrypt

Re: [FFmpeg-devel] [PATCH] libavformat: add librist protocol

2021-02-01 Thread Nicolas George
Sergio M. Ammirata, Ph.D. (12021-01-31): > For writing, the data you give librist, will go out "as is" > to the network with some added protocol overhead bytes (28 > bytes without encryption enabled and 36 bytes with > encryption enabled). Can you clarify something? Is this supposed to be a packet

Re: [FFmpeg-devel] [PATCH] libavformat: add librist protocol

2021-02-01 Thread Rodney Baker
On Monday, 1 February 2021 8:03:28 ACDT Sergio M. Ammirata, Ph.D. wrote: > librist has an internal buffer limit of 1 bytes (the > protocol has none). > > For writing, the data you give librist, will go out "as is" > to the network with some added protocol overhead bytes (28 > bytes without enc

Re: [FFmpeg-devel] [PATCH v6 3/3] avformat/mxfenc: prefer to use the configured metadta

2021-02-01 Thread lance . lmwang
On Mon, Feb 01, 2021 at 12:05:40PM +0100, Tomas Härdin wrote: > mån 2021-02-01 klockan 07:50 +0800 skrev lance.lmw...@gmail.com: > > @@ -724,9 +724,13 @@ static void mxf_write_identification(AVFormatContext > > *s) > > { > > MXFContext *mxf = s->priv_data; > > AVIOContext *pb = s->pb; >

[FFmpeg-devel] [PATCH v2] ffmpeg: add -rmax to clamp output framerate

2021-02-01 Thread Gyan Doshi
Useful when encoding in batch or with aberrant inputs. --- doc/ffmpeg.texi | 7 +++ fftools/ffmpeg.c | 7 ++- fftools/ffmpeg.h | 3 +++ fftools/ffmpeg_opt.c | 24 +--- 4 files changed, 37 insertions(+), 4 deletions(-) Forgot to nullify rmax with r set.

[FFmpeg-devel] [PATCH] ffmpeg: add -rmax to clamp output framerate

2021-02-01 Thread Gyan Doshi
Useful when encoding in batch or with aberrant inputs. --- doc/ffmpeg.texi | 7 +++ fftools/ffmpeg.c | 7 ++- fftools/ffmpeg.h | 3 +++ fftools/ffmpeg_opt.c | 22 +++--- 4 files changed, 35 insertions(+), 4 deletions(-) diff --git a/doc/ffmpeg.texi b/doc/ff

Re: [FFmpeg-devel] [PATCH v4 1/4] avutil/{avstring, bprint}: add XML escaping from ffprobe to avutil

2021-02-01 Thread Nicolas George
Jan Ekström (12021-02-01): > I don't disagree with it being ugly, just that it is what it matches > in the spec. Nobody reads the XML spec. Especially for something as trivial as the syntax to escape attributes. People learn XML from tutorials and examples, which will not have exactly the same wor

Re: [FFmpeg-devel] [PATCH v4 1/4] avutil/{avstring, bprint}: add XML escaping from ffprobe to avutil

2021-02-01 Thread Jan Ekström
On Mon, Feb 1, 2021 at 2:25 PM Nicolas George wrote: > > Jan Ekström (12021-02-01): > > I fear that those sound way, way too generic. "This escapes all XML" > > definitely is not what that does. > > > > And yes, even if it has the better definition in the Doxygen comment. > > Why? Do you expect to

Re: [FFmpeg-devel] [PATCH v4 1/4] avutil/{avstring, bprint}: add XML escaping from ffprobe to avutil

2021-02-01 Thread Nicolas George
Jan Ekström (12021-02-01): > I fear that those sound way, way too generic. "This escapes all XML" > definitely is not what that does. > > And yes, even if it has the better definition in the Doxygen comment. Why? Do you expect to add something that "escapes all XML"? What does it even mean? Thes

Re: [FFmpeg-devel] [PATCH v4 1/4] avutil/{avstring, bprint}: add XML escaping from ffprobe to avutil

2021-02-01 Thread Jan Ekström
On Mon, Feb 1, 2021 at 1:52 PM Nicolas George wrote: > > Jan Ekström (12021-02-01): > > I beg to differ, since it seemed to fully implement the cases noted in > > 2.4. Does escape double and single quotes unnecessarily in some cases, > > yes. But not invalid. > > Not invalid, but not good enough.

Re: [FFmpeg-devel] [PATCH v4 1/4] avutil/{avstring, bprint}: add XML escaping from ffprobe to avutil

2021-02-01 Thread Nicolas George
Jan Ekström (12021-02-01): > I beg to differ, since it seemed to fully implement the cases noted in > 2.4. Does escape double and single quotes unnecessarily in some cases, > yes. But not invalid. Not invalid, but not good enough. > https://github.com/jeeb/ffmpeg/commits/ttml_encoder_v5 > > - I

Re: [FFmpeg-devel] [PATCH v4 1/4] avutil/{avstring, bprint}: add XML escaping from ffprobe to avutil

2021-02-01 Thread Jan Ekström
On Mon, Jan 25, 2021 at 2:47 PM Nicolas George wrote: > > Jan Ekström (12021-01-25): > > For now I kept them separate since one is just moving Stefano's code, > > and another adds new functionality that you requested. > > Stefano's code was good enough for ffprobe, because it had to perform a > ve

Re: [FFmpeg-devel] [PATCH v6 3/3] avformat/mxfenc: prefer to use the configured metadta

2021-02-01 Thread Tomas Härdin
mån 2021-02-01 klockan 07:50 +0800 skrev lance.lmw...@gmail.com: > @@ -724,9 +724,13 @@ static void mxf_write_identification(AVFormatContext *s) > { > MXFContext *mxf = s->priv_data; > AVIOContext *pb = s->pb; > -const char *company = "FFmpeg"; > -const char *product = s->oformat

Re: [FFmpeg-devel] [PATCH v6 2/3] avformat/mxf: add platform local tag

2021-02-01 Thread Tomas Härdin
mån 2021-02-01 klockan 07:50 +0800 skrev lance.lmw...@gmail.com: > From: Limin Wang > > Please check the string of platform with below command: > ./ffmpeg -i ../fate-suite/mxf/Sony-1.mxf -c:v copy -c:a copy out.mxf > ./ffmpeg -i out.mxf > > application_platform: Lavf (linux) > > Signed-

Re: [FFmpeg-devel] [PATCH v6 1/3] avformat/mxfdec: set toolkit version metadata

2021-02-01 Thread Tomas Härdin
mån 2021-02-01 klockan 07:50 +0800 skrev lance.lmw...@gmail.com: > From: Limin Wang > > Please check the string of toolkit version with below command: > ./ffmpeg -i ../fate-suite/mxf/Sony-1.mxf -c:v copy -c:a copy out.mxf > ./ffmpeg -i out.mxf > > toolkit_version : 58.65.101 > > Signed-

Re: [FFmpeg-devel] [PATCH 1/5] avformat/sbgdec: Use av_sat_add64() in str_to_time()

2021-02-01 Thread Nicolas George
Michael Niedermayer (12021-01-31): > Fixes: signed integer overflow: 727999279212000 + 4611686018427387904 > cannot be represented in type 'long long' > Fixes: > 29744/clusterfuzz-testcase-minimized-ffmpeg_dem_SBG_fuzzer-6434060249464832 > > Found-by: continuous fuzzing process > https://gi

Re: [FFmpeg-devel] [PATCH] avformat/mxf: Establish register of local tags

2021-02-01 Thread Tomas Härdin
fre 2021-01-29 klockan 22:06 +0100 skrev Marton Balint: > > On Thu, 28 Jan 2021, Tomas Härdin wrote: > > > tor 2021-01-28 klockan 14:48 +0100 skrev Tomas Härdin: > > > tor 2021-01-28 klockan 08:56 +0100 skrev Marton Balint: > > > > On Thu, 28 Jan 2021, Tomas Härdin wrote: > > > > > ons 2021-01-27

Re: [FFmpeg-devel] [PATCH] lavf/utils: reset event_flags if extradata is not extracted correctly

2021-02-01 Thread Anton Khirnov
Quoting Linjie Fu (2021-01-30 07:44:09) > On Mon, Jan 25, 2021 at 9:08 PM Anton Khirnov wrote: > > > > Quoting Linjie Fu (2021-01-25 04:49:21) > > > On Mon, Jan 25, 2021 at 12:49 AM Anton Khirnov wrote: > > > > > > > > Quoting Linjie Fu (2021-01-24 16:05:56) > > > > > Regression since 87f0c8280.

Re: [FFmpeg-devel] [PATCH v2 1/6] avcodec/qsv_h2645: fix memory leak for plugin load

2021-02-01 Thread Anton Khirnov
Quoting Guangxin Xu (2021-01-30 04:19:27) > Hi Anton, Haihao > If this is the case, we allocated the string in caller, free and reallocate > it in callee. > It's not a good practice. > 1. It will make the user confused, The original qsvdec_other.c author and I > are both confused about this. > htt

Re: [FFmpeg-devel] [PATCH] Populate field order returned by avs script, Trac Ticket 8757

2021-02-01 Thread emcodem
Am 2021-01-21 19:08, schrieb emco...@ffastrans.com: On 2021-01-21 14:10, Stephen Hutchinson wrote: Yeah, never mind about that. I didn't notice that those are declared AVSC_INLINE, not AVSC_API, so they don't get used through the dynamic API loader. The comment formatting seems to have been me