Re: [FFmpeg-devel] [PATCH v2] avformat/hlsenc: use AV_OPT_TYPE_DURATION

2021-01-29 Thread lance . lmwang
On Sun, Jan 17, 2021 at 10:13:20AM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > doc/muxers.texi | 15 +++ > libavformat/hlsenc.c | 18 +- > 2 files changed, 20 insertions(+), 13 deletions(-) > > diff --git a/doc/

[FFmpeg-devel] [PATCH v5 2/2] avformat/mxfenc: prefer to use the configured metadta

2021-01-29 Thread lance . lmwang
From: Limin Wang The metadata company_name, product_name, product_version from input file will be deleted to avoid overwriting information Please to test with below command: ./ffmpeg -i ../fate-suite/mxf/Sony-1.mxf -c:v copy -c:a copy out.mxf and ./ffmpeg -i ../fate-suite/mxf/Sony-1.mxf -

[FFmpeg-devel] [PATCH v5 1/2] avformat/mxf: add platform local tag

2021-01-29 Thread lance . lmwang
From: Limin Wang Please check the string of platform with below command: ./ffmpeg -i ../fate-suite/mxf/Sony-1.mxf -c:v copy -c:a copy out.mxf ./ffmpeg -i out.mxf application_platform: Lavf58.65.101 (linux) Signed-off-by: Limin Wang --- configure | 1 + li

Re: [FFmpeg-devel] [PATCH v4 3/3] avformat/mxfenc: prefer to use the configured metadta

2021-01-29 Thread lance . lmwang
On Thu, Jan 28, 2021 at 02:41:46PM +0100, Tomas Härdin wrote: > tor 2021-01-28 klockan 21:08 +0800 skrev lance.lmw...@gmail.com: > > On Thu, Jan 28, 2021 at 10:26:03AM +0100, emco...@ffastrans.com wrote: > > > Am 2021-01-28 02:21, schrieb lance.lmw...@gmail.com: > > > > I haven't found the s337m fr

[FFmpeg-devel] [PATCH] lavc/hevc_parser: remove repeated profile/level settings

2021-01-29 Thread Linjie Fu
Since avctx->profile/level would be set in export_stream_params() in set_sps(), identical codes here seem to be redundant. Signed-off-by: Linjie Fu --- libavcodec/hevc_parser.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/libavcodec/hevc_parser.c b/libavcodec/hevc_parser.c index 463d3520

Re: [FFmpeg-devel] [PATCH] lavf/utils: reset event_flags if extradata is not extracted correctly

2021-01-29 Thread Linjie Fu
On Mon, Jan 25, 2021 at 9:08 PM Anton Khirnov wrote: > > Quoting Linjie Fu (2021-01-25 04:49:21) > > On Mon, Jan 25, 2021 at 12:49 AM Anton Khirnov wrote: > > > > > > Quoting Linjie Fu (2021-01-24 16:05:56) > > > > Regression since 87f0c8280. > > > > > > > > If the extradata of a stream could not

Re: [FFmpeg-devel] [PATCH v3 2/2] fate: Add test for namespace prefixes in libraries

2021-01-29 Thread Andreas Rheinhardt
Mark Thompson: > Ensures that external symbols in the built static libraries either have > correct namespace prefixes or are on a known list of exceptions. > --- > tests/Makefile | 1 + > tests/fate/namespace.mak| 19 ++ > tests/fate/namespace.sh

[FFmpeg-devel] [PATCH 6/6] swscale: Make nonstatic identifiers respect the naming conventions

2021-01-29 Thread Andreas Rheinhardt
swscale had several nonstatic functions and function pointers without the proper ff_-prefix; this has been fixed. Signed-off-by: Andreas Rheinhardt --- Tested on x86 and x64; I hope I did everything correct for the other arches, but I am not sure about that, therefore people with the necessary ha

[FFmpeg-devel] [PATCH 5/6] avformat/qtpalette: Use better headers

2021-01-29 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavformat/qtpalette.c | 3 ++- libavformat/qtpalette.h | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/libavformat/qtpalette.c b/libavformat/qtpalette.c index 2ac079a23c..9bcc3c6c38 100644 --- a/libavformat/qtpalette.c +++ b/libavform

[FFmpeg-devel] [PATCH 4/6] avformat/rtsp: Fix build failure when RTP demuxers are disabled

2021-01-29 Thread Andreas Rheinhardt
rtsp.c uses a check of the form "if (CONFIG_RTSP_DEMUXER && ...) {}" with the intent to make the code compilable even though the part guarded by this check contains calls to functions that don't exist when the RTSP demuxer is disabled. Yet even then compilers still need a declaration of all the fun

[FFmpeg-devel] [PATCH 3/6] avformat/Makefile: Only compile qtpalette.c when needed

2021-01-29 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavformat/Makefile | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavformat/Makefile b/libavformat/Makefile index c820dd35f4..bf1e56fc0a 100644 --- a/libavformat/Makefile +++ b/libavformat/Makefile @@ -16,7 +16,6 @@ OBJS = allfo

[FFmpeg-devel] [PATCH 2/6] avformat/qtpalette: Move default palette to their only user

2021-01-29 Thread Andreas Rheinhardt
Namely qtpalette.c itself. Signed-off-by: Andreas Rheinhardt --- libavformat/qtpalette.c | 300 +++- libavformat/qtpalette.h | 292 -- 2 files changed, 296 insertions(+), 296 deletions(-) diff --git a/libavformat/qtpalette.

[FFmpeg-devel] [PATCH 1/6] avformat/cutils, dvenc: Move ff_brktimegm to its only user

2021-01-29 Thread Andreas Rheinhardt
This also allows to completely remove cutils.c. Signed-off-by: Andreas Rheinhardt --- libavformat/Makefile | 1 - libavformat/cutils.c | 39 --- libavformat/dvenc.c| 13 +++-- libavformat/internal.h | 2 -- 4 files changed, 11 insertions(+),

Re: [FFmpeg-devel] [PATCH 1/3] avfilter/vf_pseudocolor: add presets

2021-01-29 Thread Nuo Mi
> > +#define RGB_TO_Y_BT709(r, g, b) \ > +((0.21260*219.0/255.0) * (r) + (0.71520*219.0/255.0) * (g) + \ > + (0.07220*219.0/255.0) * (b)) > + > +#define RGB_TO_U_BT709(r1, g1, b1, max) \ > +(-(0.11457*224.0/255.0) * r1 - (0.38543*224.0/255.0) * g1 + \ > +(0.5*224.0/255.0) * b1 + max * 0.5)

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/hevc: set field_order=progressive when SPS makes it straightforward

2021-01-29 Thread Nuo Mi
Hi Nicolas, One related question, do we have a deinterlace filter to handle hevc SAFF? thanks On Sat, Jan 30, 2021 at 1:24 AM Nicolas Gaullier wrote: > --- > libavcodec/hevcdec.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/libavcodec/hevcdec.c b/libavcodec/hevcdec.c > index 92eb8

Re: [FFmpeg-devel] [PATCH v2 1/6] avcodec/qsv_h2645: fix memory leak for plugin load

2021-01-29 Thread Guangxin Xu
Hi Anton, Haihao If this is the case, we allocated the string in caller, free and reallocate it in callee. It's not a good practice. 1. It will make the user confused, The original qsvdec_other.c author and I are both confused about this. https://github.com/FFmpeg/FFmpeg/blob/399c1f923574234e899be

Re: [FFmpeg-devel] [PATCH] avformat/rtpdec: Avoid allocations of small dynamic buffers

2021-01-29 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Besides avoiding allocations this also fixes a design defect of > ff_rtp_send_punch_packets: It did not return an error in case of > these allocations failed. > > Signed-off-by: Andreas Rheinhardt > --- > libavformat/rtpdec.c | 38 +- > 1

Re: [FFmpeg-devel] [PATCH 1/2] avformat/mov: always parse video headers

2021-01-29 Thread Nicolas Gaullier
>De : Paul B Mahol >Envoyé : vendredi 29 janvier 2021 23:46 >À : FFmpeg development discussions and patches >Cc : Nicolas Gaullier >Objet : Re: [FFmpeg-devel] [PATCH 1/2] avformat/mov: always parse video headers > >Why is AV1 touched? Well, AV1 is supposed to be left untouched but follows now t

Re: [FFmpeg-devel] [PATCH 1/2] avformat/mov: always parse video headers

2021-01-29 Thread Paul B Mahol
Why is AV1 touched? On Fri, Jan 29, 2021 at 6:24 PM Nicolas Gaullier wrote: > This is aligned with current code of matroskadec. > Fixes field_order reported by ffprobe for MP4 H264, for example. > --- > libavformat/mov.c | 7 --- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --

Re: [FFmpeg-devel] [PATCH] avformat/mxf: Establish register of local tags

2021-01-29 Thread Marton Balint
On Thu, 28 Jan 2021, Tomas Härdin wrote: tor 2021-01-28 klockan 14:48 +0100 skrev Tomas Härdin: tor 2021-01-28 klockan 08:56 +0100 skrev Marton Balint: On Thu, 28 Jan 2021, Tomas Härdin wrote: ons 2021-01-27 klockan 23:50 +0100 skrev Marton Balint: On Wed, 27 Jan 2021, Tomas Härdin wrote:

Re: [FFmpeg-devel] [PATCH 01/13] avfilter/drawutils: Remove remnants of old API

2021-01-29 Thread Gyan Doshi
On 30-01-2021 12:47 am, Andreas Rheinhardt wrote: Gyan Doshi: Are there replacements or substitutes for these? The new API was introduced in 8ec0832743d73c5de4c4978ea5f65b54cfa07625; ff_copy_rectangle is replaced by ff_copy_rectangle2, ff_draw_rectangle by ff_fill_rectangle; there is no dire

Re: [FFmpeg-devel] [PATCH 01/13] avfilter/drawutils: Remove remnants of old API

2021-01-29 Thread Andreas Rheinhardt
Gyan Doshi: > Are there replacements or substitutes for these? > The new API was introduced in 8ec0832743d73c5de4c4978ea5f65b54cfa07625; ff_copy_rectangle is replaced by ff_copy_rectangle2, ff_draw_rectangle by ff_fill_rectangle; there is no direct replacement for ff_fill_line_with_color, as said

Re: [FFmpeg-devel] [PATCH 01/13] avfilter/drawutils: Remove remnants of old API

2021-01-29 Thread Gyan Doshi
Are there replacements or substitutes for these? On 29-01-2021 10:52 am, Andreas Rheinhardt wrote: ff_fill_line_with_color and ff_draw_rectangle are unused since 19c8f2271423281c9b876b984076a6467c455904; ff_copy_rectangle is unused since 53b7a3fe081ec56c5706228eb6431bb943ad471a. Signed-off-by:

Re: [FFmpeg-devel] [PATCH 3/3] avformat/aiffdec: Check size before subtraction in get_aiff_header()

2021-01-29 Thread Michael Niedermayer
On Wed, Nov 11, 2020 at 05:01:02PM +0100, Michael Niedermayer wrote: > Fixes: Infinite loop > Fixes: > 27235/clusterfuzz-testcase-minimized-ffmpeg_dem_AIFF_fuzzer-5761398380167168 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-o

[FFmpeg-devel] [PATCH 0/2] Enhance progressive content detection

2021-01-29 Thread Nicolas Gaullier
These are two completely independant patchs. My use case is that I have many progressive materials and only a few interlaced, and I just want to avoid inserting a deinterlacing filter if it is not required. Thank you for the review Nicolas Nicolas Gaullier (2): avformat/mov: always parse video

[FFmpeg-devel] [PATCH 2/2] avcodec/hevc: set field_order=progressive when SPS makes it straightforward

2021-01-29 Thread Nicolas Gaullier
--- libavcodec/hevcdec.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavcodec/hevcdec.c b/libavcodec/hevcdec.c index 92eb888033..2eaa683399 100644 --- a/libavcodec/hevcdec.c +++ b/libavcodec/hevcdec.c @@ -330,6 +330,8 @@ static void export_stream_params(HEVCContext *s, const HEVCSPS *

[FFmpeg-devel] [PATCH 1/2] avformat/mov: always parse video headers

2021-01-29 Thread Nicolas Gaullier
This is aligned with current code of matroskadec. Fixes field_order reported by ffprobe for MP4 H264, for example. --- libavformat/mov.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index ad0b9a58d3..b5e012190b 100644 --- a/libavf

Re: [FFmpeg-devel] [PATCH 1/3] avformat/utils: Use av_sat_sub64() in max_analyze_duration check

2021-01-29 Thread Michael Niedermayer
On Wed, Nov 11, 2020 at 05:01:00PM +0100, Michael Niedermayer wrote: > Fixes: signed integer overflow: 9223372036854710272 - -541165944832 cannot be > represented in type 'long' > Fixes: > 27000/clusterfuzz-testcase-minimized-ffmpeg_dem_IVF_fuzzer-5643670608674816 > > Found-by: continuous fuzzin

Re: [FFmpeg-devel] [PATCH 1/4] avformat/asfdec_o: Check size vs. offset in detect_unknown_subobject()

2021-01-29 Thread Michael Niedermayer
On Tue, Jan 12, 2021 at 10:51:13PM +0100, Michael Niedermayer wrote: > Fixes: signed integer overflow: 2314885530818453566 + 7503032301549264928 > cannot be represented in type 'long' > Fixes: > 26639/clusterfuzz-testcase-minimized-ffmpeg_dem_ASF_O_fuzzer-6024222100684800 > > Alternatively this

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/cfhd: check peak.offset

2021-01-29 Thread Michael Niedermayer
On Sun, Dec 20, 2020 at 10:15:23PM +0100, Michael Niedermayer wrote: > Fixes: signed integer overflow: -2147483648 - 4 cannot be represented in type > 'int' > Fixes: > 26907/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_CFHD_fuzzer-5746202330267648 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH 1/5] avformat/tedcaptionsdec: Check for overflow in parse_int()

2021-01-29 Thread Michael Niedermayer
On Sun, Nov 08, 2020 at 12:17:06AM +0100, Michael Niedermayer wrote: > Fixes: signed integer overflow: 111 * 10 cannot be > represented in type 'long' > Fixes: > 26892/clusterfuzz-testcase-minimized-ffmpeg_dem_TEDCAPTIONS_fuzzer-5756045055754240 > > Found-by: continuous fuzzing p

[FFmpeg-devel] [PATCH v3] flac: add GIF image support

2021-01-29 Thread leo60228
The FLAC specification requires GIF images to contain their number of colors. While I can't find a specific reference to that effect, I'm assuming that's why GIF images were previously unsupported. This was implemented by just writing AVPALETTE_COUNT for paletted images. --- This version no longer

[FFmpeg-devel] [PATCH] flac: add GIF image support

2021-01-29 Thread leo60228
The FLAC specification requires GIF images to contain their number of colors. While I can't find a specific reference to that effect, I'm assuming that's why GIF images were previously unsupported. This was implemented by just writing AVPALETTE_COUNT for paletted images. --- libavformat/flacenc.c

[FFmpeg-devel] [PATCH v2] flac: add GIF image support

2021-01-29 Thread leo60228
This patch no longer makes an (accidental) change to adjacent code and isn't included in the changelog. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffm

Re: [FFmpeg-devel] [PATCH] libavformat: add librist protocol

2021-01-29 Thread Paul B Mahol
Will apply soon. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 01/13] avfilter/drawutils: Remove remnants of old API

2021-01-29 Thread Paul B Mahol
LGTM ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 6/6] avcodec/aacps_fixed_tablegen: Don't include config.h

2021-01-29 Thread Lynne
Jan 28, 2021, 17:26 by andreas.rheinha...@gmail.com: > It is only valid for the target, not the host and therefore it must not > be included when building the tables when hardcoded tables are enabled. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/aacps_fixed_tablegen.h| 6 +- >

Re: [FFmpeg-devel] [PATCH 1/6] avcodec/aac_defines: Make macro more general

2021-01-29 Thread Lynne
Jan 28, 2021, 17:26 by andreas.rheinha...@gmail.com: > The floating point AAC decoder shares lots of stuff (mainly tables) > with other components; this is not so much true for the fixed point > AAC decoder: There are tables for which the fixed point decoder is the > only user whereas the floating

Re: [FFmpeg-devel] [PATCH 3/6] avcodec/aacdec_fixed: Move fixed-point sinewin tables to its only user

2021-01-29 Thread Lynne
Jan 28, 2021, 17:26 by andreas.rheinha...@gmail.com: > The fixed-point AAC decoder is the only user of the fixed-point sinewin > tables from sinewin; and it only uses a few of them (about 10% when > counting by size). This means that guarding initializing these tables by > an AVOnce (as done in 37

Re: [FFmpeg-devel] [PATCH 02/13] avcodec/fft_template: Avoid useless function

2021-01-29 Thread Lynne
Jan 29, 2021, 06:22 by andreas.rheinha...@gmail.com: > ff_init_ff_cos_tabs is only used for the floating point FFT and only > if hardcoded tables are disabled. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/fft.h | 16 > libavcodec/fft_template.c | 10

Re: [FFmpeg-devel] [PATCH 03/13] avcodec/vorbis_data: Move encoder-related table to its only user

2021-01-29 Thread Lynne
Jan 29, 2021, 06:22 by andreas.rheinha...@gmail.com: > Said table was unused in case libvorbis was disabled. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/libvorbisenc.c | 13 - > libavcodec/vorbis.h | 1 - > libavcodec/vorbis_data.c | 11 --- > 3 files cha