[FFmpeg-devel] [PATCH v4] avcodec/libvpxenc: add a way to set VP9E_SET_SVC_REF_FRAME_CONFIG

2021-01-07 Thread Wonkap Jang
In order to fine-control referencing schemes in VP9 encoding, there is a need to use VP9E_SET_SVC_REF_FRAME_CONFIG method. This commit provides a way to use the API through frame metadata. --- doc/encoders.texi | 32 +++ libavcodec/libvpxenc.c | 88

[FFmpeg-devel] [PATCH v3 3/3] avformat/mxfenc: prefer to use the existing metadata

2021-01-07 Thread lance . lmwang
From: Limin Wang Please check metadata with below command: ./ffmpeg -i ../fate-suite/mxf/Sony-1.mxf -c:v copy -c:a copy out.mxf ./ffmpeg -i out.mxf company_name: FFmpeg product_name: OP1a Muxer product_version : 58.65.101o => company_name: SONY product_nam

[FFmpeg-devel] [PATCH v3 2/3] avformat/udp: add memory alloc checks

2021-01-07 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavformat/udp.c | 4 1 file changed, 4 insertions(+) diff --git a/libavformat/udp.c b/libavformat/udp.c index 28987e0..333a612 100644 --- a/libavformat/udp.c +++ b/libavformat/udp.c @@ -892,6 +892,10 @@ static int udp_open(URLContext *h, co

[FFmpeg-devel] [PATCH v3 1/3] avformat/udp: return the error code instead of generic EIO

2021-01-07 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavformat/udp.c | 42 ++ 1 file changed, 22 insertions(+), 20 deletions(-) diff --git a/libavformat/udp.c b/libavformat/udp.c index 13c346a..28987e0 100644 --- a/libavformat/udp.c +++ b/libavformat/udp.c @

Re: [FFmpeg-devel] [PATCH v2 2/3] avformat/udp: add memory alloc checks

2021-01-07 Thread lance . lmwang
On Thu, Jan 07, 2021 at 05:32:35PM -0800, Chad Fraleigh wrote: > > > On 1/7/2021 2:43 AM, lance.lmw...@gmail.com wrote: > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > libavformat/udp.c | 4 > > 1 file changed, 4 insertions(+) > > > > diff --git a/libavformat/udp.c

Re: [FFmpeg-devel] [PATCH v2 2/3] avformat/udp: add memory alloc checks

2021-01-07 Thread Chad Fraleigh
On 1/7/2021 2:43 AM, lance.lmw...@gmail.com wrote: From: Limin Wang Signed-off-by: Limin Wang --- libavformat/udp.c | 4 1 file changed, 4 insertions(+) diff --git a/libavformat/udp.c b/libavformat/udp.c index 798b789..e6d1235 100644 --- a/libavformat/udp.c +++ b/libavformat/udp.c @

[FFmpeg-devel] [PATCH 5/5] avcodec/Makefile: Make H.263 encoder compilable without MPEG4 encoder

2021-01-07 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/Makefile| 3 ++- libavcodec/mpeg4videoenc.c | 3 --- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/libavcodec/Makefile b/libavcodec/Makefile index c1c2322eb6..c5605ef92c 100644 --- a/libavcodec/Makefile +++ b/libavcodec/Mak

[FFmpeg-devel] [PATCH 4/5] avcodec/Makefile: Make H.263 decoder compilable without H.263I

2021-01-07 Thread Andreas Rheinhardt
The only call to ff_intel_h263_decode_picture_header() is already behind "if (CONFIG_H263I_DECODER)". Signed-off-by: Andreas Rheinhardt --- libavcodec/Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/Makefile b/libavcodec/Makefile index 4c1044a281..c1c232

[FFmpeg-devel] [PATCH 3/5] avcodec/Makefile: Remove FLAC dependencies on vorbis_data

2021-01-07 Thread Andreas Rheinhardt
2ef2496cd19eb833f4ad22a5051c11be80d09598 used ff_vorbis_channel_layouts in flac.c, but added a dependency to the FLAC decoder only; lateron aba0278e9fe8e66c078588efe66f6af4db432770 added the dependency of the FLAC parser and encoder on vorbis_data.o. Yet when the original commit was reverted in aba

[FFmpeg-devel] [PATCH 2/5] avcodec/Makefile: Remove dependency of H.263 on FLV codecs

2021-01-07 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/Makefile | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/libavcodec/Makefile b/libavcodec/Makefile index 36891bbb57..a711eeeb81 100644 --- a/libavcodec/Makefile +++ b/libavcodec/Makefile @@ -336,6 +336,8 @@ OBJS-$(CONFIG_F

[FFmpeg-devel] [PATCH 1/5] avcodec/Makefile: Remove unnecessary cbrt_data dependency

2021-01-07 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/Makefile b/libavcodec/Makefile index fea37ef3c9..36891bbb57 100644 --- a/libavcodec/Makefile +++ b/libavcodec/Makefile @@ -174,7 +174,7 @@ OBJS-$(CONFIG_AAC_ENC

Re: [FFmpeg-devel] [PATCH v2 1/3] avformat/udp: return the error code instead of generic EIO

2021-01-07 Thread lance . lmwang
On Thu, Jan 07, 2021 at 05:07:32PM +0100, Marton Balint wrote: > > > On Thu, 7 Jan 2021, lance.lmw...@gmail.com wrote: > > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > libavformat/udp.c | 47 +++ > > 1 file changed, 23 insertions(

[FFmpeg-devel] [PATCH] avformat/mxfdec: Free all types for both Descriptors

2021-01-07 Thread Michael Niedermayer
Fixes: memleak Fixes: 26352/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-5201158714687488 Suggested-by: Tomas Härdin Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavformat/mxfdec.c | 3 +--

Re: [FFmpeg-devel] [PATCH 2/6] avcodec: add h266 codec id and profiles

2021-01-07 Thread Mark Thompson
On 22/12/2020 10:37, Nuo Mi wrote: Hi James, thanks for the review. On Mon, Dec 21, 2020 at 11:14 PM James Almer wrote: On 12/21/2020 3:07 AM, Nuo Mi wrote: --- libavcodec/avcodec.h| 2 ++ libavcodec/codec_desc.c | 8 libavcodec/codec_id.h | 2 ++ libavcodec/profiles.

Re: [FFmpeg-devel] [PATCH 3/5] avcodec/fft_fixed: Hardcode cosine tables to save space

2021-01-07 Thread Lynne
Jan 7, 2021, 21:26 by h.lepp...@gmail.com: > On Thu, Jan 7, 2021 at 5:32 PM Lynne wrote: > >> >> Jan 7, 2021, 17:05 by andreas.rheinha...@gmail.com: >> >> > Lynne: >> > >> >> Jan 7, 2021, 00:13 by andreas.rheinha...@gmail.com: >> >> >> >>> The tables that are used take 256B; the code to initializ

Re: [FFmpeg-devel] [PATCH] avcodec/libopusenc: Fix for header pre-skip value

2021-01-07 Thread Lynne
Jan 7, 2021, 21:55 by a...@ified.ca: > The Opus header initial padding preskip amount is always to be expressed > relative to 48kHz. However, the encoder delay returned from querying > libopus is relative to the encoding samplerate. Multiply by the > samplerate conversion factor to correct. > > Si

[FFmpeg-devel] [PATCH] avcodec/libopusenc: Fix for header pre-skip value

2021-01-07 Thread Arthur Taylor
The Opus header initial padding preskip amount is always to be expressed relative to 48kHz. However, the encoder delay returned from querying libopus is relative to the encoding samplerate. Multiply by the samplerate conversion factor to correct. Signed-off-by: Arthur Taylor --- libavcodec/libop

Re: [FFmpeg-devel] [PATCH v4] avcodec/libvpxenc: add a way to set VP9E_SET_SVC_REF_FRAME_CONFIG

2021-01-07 Thread James Zern
Hi, On Wed, Jan 6, 2021 at 8:59 AM Wonkap Jang wrote: > > HI JAmes, > > On Tue, Dec 29, 2020 at 11:54 AM Wonkap Jang < > wonkap-at-google@ffmpeg.org> wrote: > > > Hi James, > > > > On Tue, Dec 29, 2020 at 11:51 AM Wonkap Jang wrote: > > > > > In order to fine-control referencing schemes in V

Re: [FFmpeg-devel] [PATCH 3/5] avcodec/fft_fixed: Hardcode cosine tables to save space

2021-01-07 Thread Hendrik Leppkes
On Thu, Jan 7, 2021 at 5:32 PM Lynne wrote: > > Jan 7, 2021, 17:05 by andreas.rheinha...@gmail.com: > > > Lynne: > > > >> Jan 7, 2021, 00:13 by andreas.rheinha...@gmail.com: > >> > >>> The tables that are used take 256B; the code to initialize them uses > >>> 281B here (GCC 9.3, x64, -O3, but in a

[FFmpeg-devel] [PATCH] avformat/hlsenc: hls output optimisation Currently the output of the segment is delayed by 1 packet since the check condition compares the pts of the beginning of packet insted

2021-01-07 Thread Bartosz Ziemski
From: Bartosz Ziemski Signed-off-by: Bartosz Ziemski --- libavformat/hlsenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index cafe0e8c69..bac1e681f3 100644 --- a/libavformat/hlsenc.c +++ b/libavformat/hlsenc.c @@ -2497,7 +249

Re: [FFmpeg-devel] [PATCH 2/5] avcodec/fft_template: Remove unused fixed-point cosine tables

2021-01-07 Thread Lynne
Jan 7, 2021, 00:13 by andreas.rheinha...@gmail.com: > There are three types of FFTs: floating-point, 32-bit fixed-point and > 16-bit fixed-point. The latter has exactly one user: The fixed-point > AC-3-encoder; the cosine tables used by it use up to seven bits. The > tables corresponding to eight

Re: [FFmpeg-devel] [PATCH 4/5] avcodec/fft_template: Only check for FF_FFT_PERM_AVX on ARCH_X86

2021-01-07 Thread Lynne
Jan 7, 2021, 17:38 by andreas.rheinha...@gmail.com: > Lynne: > >> Jan 7, 2021, 00:13 by andreas.rheinha...@gmail.com: >> >>> Also do it for FFT_FLOAT only, as this is the only combination for which >>> it can be set. >>> >>> Signed-off-by: Andreas Rheinhardt >>> --- >>> libavcodec/fft_template.c

Re: [FFmpeg-devel] [PATCH 4/5] avcodec/fft_template: Only check for FF_FFT_PERM_AVX on ARCH_X86

2021-01-07 Thread Andreas Rheinhardt
Lynne: > Jan 7, 2021, 00:13 by andreas.rheinha...@gmail.com: > >> Also do it for FFT_FLOAT only, as this is the only combination for which >> it can be set. >> >> Signed-off-by: Andreas Rheinhardt >> --- >> libavcodec/fft_template.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >>

Re: [FFmpeg-devel] [PATCH 3/5] avcodec/fft_fixed: Hardcode cosine tables to save space

2021-01-07 Thread Lynne
Jan 7, 2021, 17:05 by andreas.rheinha...@gmail.com: > Lynne: > >> Jan 7, 2021, 00:13 by andreas.rheinha...@gmail.com: >> >>> The tables that are used take 256B; the code to initialize them uses >>> 281B here (GCC 9.3, x64, -O3, but in av_cold functions). On top of that, >>> removing this code also

Re: [FFmpeg-devel] [PATCH v2 1/3] avformat/udp: return the error code instead of generic EIO

2021-01-07 Thread Marton Balint
On Thu, 7 Jan 2021, lance.lmw...@gmail.com wrote: From: Limin Wang Signed-off-by: Limin Wang --- libavformat/udp.c | 47 +++ 1 file changed, 23 insertions(+), 24 deletions(-) diff --git a/libavformat/udp.c b/libavformat/udp.c index 13c346a..798b78

Re: [FFmpeg-devel] [PATCH 3/5] avcodec/fft_fixed: Hardcode cosine tables to save space

2021-01-07 Thread Andreas Rheinhardt
Lynne: > Jan 7, 2021, 00:13 by andreas.rheinha...@gmail.com: > >> The tables that are used take 256B; the code to initialize them uses >> 281B here (GCC 9.3, x64, -O3, but in av_cold functions). On top of that, >> removing this code also allows to remove the array of AVOnce used to >> guard the co

Re: [FFmpeg-devel] [PATCH 5/5] avcodec/fft_template: Perform some checks at compile-time

2021-01-07 Thread Lynne
Jan 7, 2021, 00:13 by andreas.rheinha...@gmail.com: > The fixed point FFT never uses the 32bit revtab; this commit adds > some compile-time checks to make sure that dead code doesn't get > compiled in. > > Also, while just at it, fix the indentation in ff_fft_init() and make sure > that a do {} wh

Re: [FFmpeg-devel] [PATCH 4/5] avcodec/fft_template: Only check for FF_FFT_PERM_AVX on ARCH_X86

2021-01-07 Thread Lynne
Jan 7, 2021, 00:13 by andreas.rheinha...@gmail.com: > Also do it for FFT_FLOAT only, as this is the only combination for which > it can be set. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/fft_template.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavco

Re: [FFmpeg-devel] [PATCH 3/5] avcodec/fft_fixed: Hardcode cosine tables to save space

2021-01-07 Thread Lynne
Jan 7, 2021, 00:13 by andreas.rheinha...@gmail.com: > The tables that are used take 256B; the code to initialize them uses > 281B here (GCC 9.3, x64, -O3, but in av_cold functions). On top of that, > removing this code also allows to remove the array of AVOnce used to > guard the cosine tables aga

Re: [FFmpeg-devel] [PATCH 03/27] cbs_h2645: Merge SEI message handling in common between codecs

2021-01-07 Thread Nuo Mi
> > >> ... > > On reviewing, it really helps to trim irrelevant context from replies so > that we aren't searching through long messages looking for comments. (And > apologies if I missed anything.) > No, you address all my concerns. thanks for the suggstion. > > Thanks, > > - Mark > ___

[FFmpeg-devel] [PATCH 4/4] checkasm: add hevc_pel tests

2021-01-07 Thread Josh Dekker
Co-authored-by: Niklas Haas Signed-off-by: Josh Dekker --- tests/checkasm/Makefile | 2 +- tests/checkasm/checkasm.c | 10 + tests/checkasm/checkasm.h | 10 + tests/checkasm/hevc_pel.c | 523 ++ 4 files changed, 544 insertions(+), 1 deletion(-) create m

[FFmpeg-devel] [PATCH 3/4] lavc/aarch64: add HEVC sao_band NEON

2021-01-07 Thread Josh Dekker
Only works for 8x8. Signed-off-by: Josh Dekker --- libavcodec/aarch64/Makefile | 3 +- libavcodec/aarch64/hevcdsp_init.c | 7 +++ libavcodec/aarch64/hevcdsp_sao_neon.S | 87 +++ 3 files changed, 96 insertions(+), 1 deletion(-) create mode 100644 libavcode

[FFmpeg-devel] [PATCH 2/4] lavc/aarch64: add HEVC idct_dc NEON

2021-01-07 Thread Josh Dekker
Signed-off-by: Josh Dekker --- libavcodec/aarch64/Makefile| 3 +- libavcodec/aarch64/hevcdsp_idct_neon.S | 74 ++ libavcodec/aarch64/hevcdsp_init.c | 19 +++ 3 files changed, 95 insertions(+), 1 deletion(-) create mode 100644 libavcodec/aarch64/hevcd

[FFmpeg-devel] [PATCH 1/4] lavc/aarch64: add HEVC add_residual NEON

2021-01-07 Thread Josh Dekker
Signed-off-by: Josh Dekker --- libavcodec/aarch64/Makefile | 2 + libavcodec/aarch64/hevcdsp_add_res_neon.S | 298 ++ libavcodec/aarch64/hevcdsp_init.c | 59 + libavcodec/hevcdsp.c | 2 + libavcodec/hevcdsp.h

[FFmpeg-devel] [PATCH 0/4] AArch64 NEON for HEVC

2021-01-07 Thread Josh Dekker
checkasm: all 657 tests passed hevc_add_res_4x4_8_c: 49.7 hevc_add_res_4x4_8_neon: 20.5 hevc_add_res_4x4_10_c: 45.7 hevc_add_res_4x4_10_neon: 18.7 hevc_add_res_8x8_8_c: 211.0 hevc_add_res_8x8_8_neon: 24.5 hevc_add_res_8x8_10_c: 195.7 hevc_add_res_8x8_10_neon: 24.0 hevc_add_res_16x16_8_c: 787.2 hevc

Re: [FFmpeg-devel] [PATCH 2/6] avcodec: add h266 codec id and profiles

2021-01-07 Thread Nuo Mi
On Sat, Jan 2, 2021 at 10:06 AM Nuo Mi wrote: > Hi Mark & all, > Happy new year! > I have implemented the h266 metadata bsf. For all vvdec decodable clips, > the metadata pass-through mode can get a bit matched result. > Could you align with James about the name convention, so I can send the > se

[FFmpeg-devel] [PATCH] lavc/aarch64: add HEVC add_residual NEON

2021-01-07 Thread Josh Dekker
Signed-off-by: Josh Dekker --- checkasm: all 648 tests passed hevc_add_res_4x4_8_c: 49.7 hevc_add_res_4x4_8_neon: 20.5 hevc_add_res_4x4_10_c: 46.0 hevc_add_res_4x4_10_neon: 19.0 hevc_add_res_8x8_8_c: 209.0 hevc_add_res_8x8_8_neon: 24.5 hevc_add_res_8x8_10_c: 192.7 hevc_add_res_8x8_10_neon: 27.0 h

[FFmpeg-devel] [PATCH v2 2/3] avformat/udp: add memory alloc checks

2021-01-07 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavformat/udp.c | 4 1 file changed, 4 insertions(+) diff --git a/libavformat/udp.c b/libavformat/udp.c index 798b789..e6d1235 100644 --- a/libavformat/udp.c +++ b/libavformat/udp.c @@ -891,6 +891,10 @@ static int udp_open(URLContext *h, co

[FFmpeg-devel] [PATCH v2 1/3] avformat/udp: return the error code instead of generic EIO

2021-01-07 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavformat/udp.c | 47 +++ 1 file changed, 23 insertions(+), 24 deletions(-) diff --git a/libavformat/udp.c b/libavformat/udp.c index 13c346a..798b789 100644 --- a/libavformat/udp.c +++ b/libavformat/ud

[FFmpeg-devel] [PATCH v2 3/3] avformat/mxfenc: prefer to use the existing metadata

2021-01-07 Thread lance . lmwang
From: Limin Wang Please check metadata with below command: ./ffmpeg -i ../fate-suite/mxf/Sony-1.mxf -c:v copy -c:a copy out.mxf ./ffmpeg -i out.mxf company_name: FFmpeg product_name: OP1a Muxer product_version : 58.65.101o => company_name: SONY product_nam

Re: [FFmpeg-devel] Issue with ogg page termination on full last page with even last segment size

2021-01-07 Thread Peter Zebühr
> On 5 Jan 2021, at 16:22, Lynne wrote: > > Was going to respond to this but forgot. > Opus can have 0 byte packets to signal silence. So you'll have to fix this > for real. Ok, sounds reasonable. Was also thinking that 0 byte packets would be reasonable to support from the containers perspect

Re: [FFmpeg-devel] [PATCH] Moves yuv2yuvX_sse3 to yasm, unrolls main loop and other small optimizations for ~20% speedup.

2021-01-07 Thread Alan Kelly
Thanks for your patience with this, I have replaced mova with movdqu - movu generated a compile error on ssse3. What system did this crash on? On Wed, Jan 6, 2021 at 9:10 PM Michael Niedermayer wrote: > On Tue, Jan 05, 2021 at 01:31:25PM +0100, Alan Kelly wrote: > > Ping! > > crashes (due to ali

[FFmpeg-devel] [PATCH] Moves yuv2yuvX_sse3 to yasm, unrolls main loop and other small optimizations for ~20% speedup.

2021-01-07 Thread Alan Kelly
--- Replaces mova with movdqu due to alignment issues libswscale/x86/Makefile | 1 + libswscale/x86/swscale.c| 106 +--- libswscale/x86/yuv2yuvX.asm | 117 tests/checkasm/sw_scale.c | 98 ++