[FFmpeg-devel] Contribution: remove commented lines from filtergraph

Hello everyone, I was heavily using the -filter_script option lately and was missing a way to put comments into the filtergraph file. So here’s a proposal to add that functionality. Happy new year! From 067cb553e5ad5e47c0cbad3c78a55f3aa5c4fe7e Mon Sep 17 00:00:00 2001 From: Daniel Musketa <=> Dat

[FFmpeg-devel] [PATCH] avcodec/cbs_h265: fix undef SEI_TYPE_X

--- libavcodec/cbs_h265_syntax_template.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavcodec/cbs_h265_syntax_template.c b/libavcodec/cbs_h265_syntax_template.c index 48fae82d04..c0e94683a2 100644 --- a/libavcodec/cbs_h265_syntax_template.c +++ b/libavcodec/cbs_h265_

Re: [FFmpeg-devel] [PATCH 02/30] avfilter/vf_addroi: Use chars instead of strings for one-char strings

> -Original Message- > From: ffmpeg-devel On Behalf Of > Andreas Rheinhardt > Sent: 2020年12月31日 7:31 > To: ffmpeg-devel@ffmpeg.org > Cc: Andreas Rheinhardt > Subject: [FFmpeg-devel] [PATCH 02/30] avfilter/vf_addroi: Use chars instead of > strings for one-char strings > > Signed-off-by:

[FFmpeg-devel] [PATCH] dnn_interface.h: fix redefining typedefs

Signed-off-by: Guo, Yejun --- will push soon libavfilter/dnn_interface.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/dnn_interface.h b/libavfilter/dnn_interface.h index 1e2842425a..9533c88829 100644 --- a/libavfilter/dnn_interface.h +++ b/libavfilter/dnn_interf

[FFmpeg-devel] [PATCH v2] mpeg2_metadata: support inverse (soft) telecine

Signed-off-by: Tom Yan --- doc/bitstream_filters.texi | 6 ++ libavcodec/mpeg2_metadata_bsf.c | 27 +++ 2 files changed, 33 insertions(+) diff --git a/doc/bitstream_filters.texi b/doc/bitstream_filters.texi index 8a2f55cc41..7e178a6912 100644 --- a/doc/bitstream

Re: [FFmpeg-devel] [PATCH V2 1/3] dnn: fix redefining typedefs and also refine naming with correct prefix

> -Original Message- > From: ffmpeg-devel On Behalf Of > Michael Niedermayer > Sent: 2020年12月31日 8:26 > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH V2 1/3] dnn: fix redefining typedefs and > also refine naming with correct prefix > > On Wed, Dec

Re: [FFmpeg-devel] [PATCH 05/30] Replace arrays of pointers to strings by arrays of strings

On 12/30/2020 9:19 PM, Andreas Rheinhardt wrote: James Almer: On 12/30/2020 8:31 PM, Andreas Rheinhardt wrote: When the difference of the longest size and the average size of collection of strings is smaller than the size of a pointer, it makes sense to store the strings directly in an array in

Re: [FFmpeg-devel] [PATCH V2 1/3] dnn: fix redefining typedefs and also refine naming with correct prefix

On Wed, Dec 30, 2020 at 11:35:06PM +0800, Guo, Yejun wrote: > The prefix for symbols not exported from the library and not > local to one translation unit is ff_ (or FF for types). > > Signed-off-by: Guo, Yejun > --- > libavfilter/dnn/dnn_backend_openvino.c | 32 ++--- > libavfilter/dnn/

Re: [FFmpeg-devel] [PATCH 09/30] avcodec/atrac3plus_data: Mark array as const

On Thu, Dec 31, 2020 at 12:31:36AM +0100, Andreas Rheinhardt wrote: > Forgotten in a7dbeb77c3c30ac4904928978938b209ff6e1ab1. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/atrac3plus_data.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) LGTM thx [...] -- Michael GnuPG

Re: [FFmpeg-devel] [PATCH 12/30] avcodec/mpegvideo: Don't zero-initialize unnecessarily

On Thu, Dec 31, 2020 at 12:31:39AM +0100, Andreas Rheinhardt wrote: > mbintra_table will be memset to 1 a few lines after its allocation. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/mpegvideo.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) should be ok thx [...] -- Mic

Re: [FFmpeg-devel] [PATCH 05/30] Replace arrays of pointers to strings by arrays of strings

James Almer: > On 12/30/2020 8:31 PM, Andreas Rheinhardt wrote: >> When the difference of the longest size and the average size of >> collection of strings is smaller than the size of a pointer, it makes >> sense to store the strings directly in an array instead of using an >> array of pointers to

Re: [FFmpeg-devel] [PATCH 17/30] avcodec/opusdec: Return error upon error

On Thu, Dec 31, 2020 at 12:31:44AM +0100, Andreas Rheinhardt wrote: > The Opus decoder forgot to return an error when allocating an > SwrContext fails. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/opusdec.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) LGTM thx [...]

Re: [FFmpeg-devel] [PATCH 29/30] avcodec/svq1dec: Increment nb_bits of VLC to read it in one go

On Thu, Dec 31, 2020 at 12:31:56AM +0100, Andreas Rheinhardt wrote: > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/svq1dec.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/libavcodec/svq1dec.c b/libavcodec/svq1dec.c > index 7aea138060..e9c068de19 100644 >

Re: [FFmpeg-devel] [PATCH 05/30] Replace arrays of pointers to strings by arrays of strings

On 12/30/2020 8:31 PM, Andreas Rheinhardt wrote: When the difference of the longest size and the average size of collection of strings is smaller than the size of a pointer, it makes sense to store the strings directly in an array instead of using an array of pointers to strings (unless doing so

Re: [FFmpeg-devel] [PATCH 14/30] avcodec/rtpdec: Constify RTPDynamicProtocolHandlers

Andreas Rheinhardt: > Also constify the list of pointers to said RTPDynamicProtocolHandlers. > > Signed-off-by: Andreas Rheinhardt > --- > libavformat/rdt.c | 2 +- > libavformat/rtpdec.c| 22 +++--- > libavformat/rtpdec_qt.c | 2 +- > 3 files changed, 13 insertions(+

[FFmpeg-devel] [PATCH 30/30] avcodec/dvenc: Make encoder init-threadsafe

Signed-off-by: Andreas Rheinhardt --- The above depends upon ff_check_alignment() being removed first. libavcodec/dvenc.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/libavcodec/dvenc.c b/libavcodec/dvenc.c index 21a8b841f6..35b6f71e46 100644 --- a/libavcodec/d

[FFmpeg-devel] [PATCH 29/30] avcodec/svq1dec: Increment nb_bits of VLC to read it in one go

Signed-off-by: Andreas Rheinhardt --- libavcodec/svq1dec.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavcodec/svq1dec.c b/libavcodec/svq1dec.c index 7aea138060..e9c068de19 100644 --- a/libavcodec/svq1dec.c +++ b/libavcodec/svq1dec.c @@ -456,7 +456,7 @@ static int

[FFmpeg-devel] [PATCH 28/30] avcodec/dvdec: Make decoder init-threadsafe

Signed-off-by: Andreas Rheinhardt --- libavcodec/dvdec.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/libavcodec/dvdec.c b/libavcodec/dvdec.c index 85619a42a8..e36df10d1b 100644 --- a/libavcodec/dvdec.c +++ b/libavcodec/dvdec.c @@ -39,6 +39,7 @@ #include "libav

[FFmpeg-devel] [PATCH 27/30] avcodec/dv: Don't initialize RL VLC for encoder

Said RL VLC is only used by the decoder, ergo don't initialize it for the encoder and move the whole code and the RL VLC table itself to dvdec.c. Signed-off-by: Andreas Rheinhardt --- libavcodec/dv.c| 59 libavcodec/dv.h| 4 --- libavcodec/dvdec.c |

[FFmpeg-devel] [PATCH 26/30] avcodec/dv: Don't pretend VLC allocation can't fail

It can and therefore we switch from a heap allocated VLC table to a VLC initialized via the mechanism for static VLCs, but without an actual static VLC. Signed-off-by: Andreas Rheinhardt --- libavcodec/dv.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavcodec/dv.c

[FFmpeg-devel] [PATCH 25/30] avcodec/dirac_arith: Make table only used here static

Signed-off-by: Andreas Rheinhardt --- libavcodec/dirac_arith.c | 6 +++--- libavcodec/dirac_arith.h | 1 - 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/libavcodec/dirac_arith.c b/libavcodec/dirac_arith.c index 36142fe198..69b6280230 100644 --- a/libavcodec/dirac_arith.c +++ b/li

[FFmpeg-devel] [PATCH 24/30] avcodec/wmalosslessdec: Mark decoder as init-threadsafe

Signed-off-by: Andreas Rheinhardt --- libavcodec/wmalosslessdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/wmalosslessdec.c b/libavcodec/wmalosslessdec.c index a8fd99774e..15ceb74f67 100644 --- a/libavcodec/wmalosslessdec.c +++ b/libavcodec/wmalosslessdec.c @

[FFmpeg-devel] [PATCH 23/30] avcodec/qdmc: Mark decoder as init-threadsafe

It already uses ff_thread_once() to initialize its static data. Signed-off-by: Andreas Rheinhardt --- libavcodec/qdmc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/qdmc.c b/libavcodec/qdmc.c index 94681a0b6b..a8c930f0e7 100644 --- a/libavcodec/qdmc.c +++ b/libavcodec/qdmc.c @@

[FFmpeg-devel] [PATCH 22/30] avcodec/wmavoice: Mark decoder as init-threadsafe

It is init-threadsafe since b9c1ab89078d862e0146c9d7ed277addd770e3a3 and except on MIPS even before that due to its use of ff_thread_once() for static initialization. Signed-off-by: Andreas Rheinhardt --- libavcodec/wmavoice.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/l

[FFmpeg-devel] [PATCH 21/30] avcodec/qcelpdec: Mark decoder as init-threadsafe

Signed-off-by: Andreas Rheinhardt --- libavcodec/qcelpdec.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/qcelpdec.c b/libavcodec/qcelpdec.c index 4878af5a2c..823205bf55 100644 --- a/libavcodec/qcelpdec.c +++ b/libavcodec/qcelpdec.c @@ -799,4 +799,5 @@ AVCodec ff_qcelp_decoder =

[FFmpeg-devel] [PATCH 20/30] avcodec/opusdec: Mark decoder as init-threadsafe

Signed-off-by: Andreas Rheinhardt --- libavcodec/opusdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/opusdec.c b/libavcodec/opusdec.c index 24e90a3761..f0d7ed62a1 100644 --- a/libavcodec/opusdec.c +++ b/libavcodec/opusdec.c @@ -716,5 +716,5 @@ AVCodec ff_opus_

[FFmpeg-devel] [PATCH 19/30] avcodec/opusdec: Cleanup generically in init failure

Signed-off-by: Andreas Rheinhardt --- libavcodec/opusdec.c | 33 +++-- 1 file changed, 11 insertions(+), 22 deletions(-) diff --git a/libavcodec/opusdec.c b/libavcodec/opusdec.c index b09a542c86..24e90a3761 100644 --- a/libavcodec/opusdec.c +++ b/libavcodec/opusdec.c

[FFmpeg-devel] [PATCH 18/30] avcodec/opusdec: Move per-stream fields to OpusStreamContext

Besides being more natural it also avoids allocations for separate arrays of decoded samples/output buffers/ Signed-off-by: Andreas Rheinhardt --- libavcodec/opus.h| 24 +- libavcodec/opusdec.c | 111 +++ 2 files changed, 62 insertions(+),

[FFmpeg-devel] [PATCH 17/30] avcodec/opusdec: Return error upon error

The Opus decoder forgot to return an error when allocating an SwrContext fails. Signed-off-by: Andreas Rheinhardt --- libavcodec/opusdec.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavcodec/opusdec.c b/libavcodec/opusdec.c index 86a3181e9d..462d70b3bf 100644 --- a/

[FFmpeg-devel] [PATCH 16/30] avcodec/aacps_common: Use minimal VLC nb_bits/max_depth

Signed-off-by: Andreas Rheinhardt --- libavcodec/aacps_common.c | 36 ++-- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/libavcodec/aacps_common.c b/libavcodec/aacps_common.c index ecc220f94b..8653b871ca 100644 --- a/libavcodec/aacps_common.c +++

[FFmpeg-devel] [PATCH 15/30] avcodec/aacps: Factor out code shared by float and fixed point decoder

Saves about 7KiB. Signed-off-by: Andreas Rheinhardt --- libavcodec/Makefile | 4 +- libavcodec/aacps.c | 383 --- libavcodec/aacps.h | 18 +- libavcodec/aacps_common.c| 336 ++ libavcodec/aacpsdata.c

[FFmpeg-devel] [PATCH 14/30] avcodec/rtpdec: Constify RTPDynamicProtocolHandlers

Also constify the list of pointers to said RTPDynamicProtocolHandlers. Signed-off-by: Andreas Rheinhardt --- libavformat/rdt.c | 2 +- libavformat/rtpdec.c| 22 +++--- libavformat/rtpdec_qt.c | 2 +- 3 files changed, 13 insertions(+), 13 deletions(-) diff --git a/lib

[FFmpeg-devel] [PATCH 13/30] avformat/rtpdec: Remove next pointer from Protocol Handlers

Forgotten in 61974537610d82bd35b6e3ac91ccd270c6bdc711 (notice that RTPDynamicProtocolHandler is not a public struct, so one can remove the linked-list pointer immediately (unlike in most other patches of this kind)). Signed-off-by: Andreas Rheinhardt --- libavformat/rtpdec.h | 2 -- 1 file chang

[FFmpeg-devel] [PATCH 08/30] avcodec/truespeech: Avoid indirection for truespeech codebooks

Signed-off-by: Andreas Rheinhardt --- libavcodec/truespeech.c | 16 libavcodec/truespeech_data.h | 4 2 files changed, 8 insertions(+), 12 deletions(-) diff --git a/libavcodec/truespeech.c b/libavcodec/truespeech.c index 3cdae8c556..d28779a610 100644 --- a/libavcodec/

[FFmpeg-devel] [PATCH 07/30] avcodec/truemotion1data: Avoid indirection for delta-table init

Up until arrays of pointers to other arrays have been used, yet these other arrays all have the same number of elements and the same underlying type, so one can use an array of arrays. This also avoids relocations. Signed-off-by: Andreas Rheinhardt --- On 64bit systems it would also make sense to

[FFmpeg-devel] [PATCH 12/30] avcodec/mpegvideo: Don't zero-initialize unnecessarily

mbintra_table will be memset to 1 a few lines after its allocation. Signed-off-by: Andreas Rheinhardt --- libavcodec/mpegvideo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/mpegvideo.c b/libavcodec/mpegvideo.c index c28d1adef7..f487864de6 100644 --- a/libavcode

[FFmpeg-devel] [PATCH 06/30] Mark some pointers as const

Signed-off-by: Andreas Rheinhardt --- fftools/ffmpeg_opt.c| 86 - libavcodec/aacenctab.c | 4 +- libavcodec/aacenctab.h | 4 +- libavcodec/cbs.c| 2 +- libavcodec/h2645_parse.c| 4 +- libavcodec/opustab.c

[FFmpeg-devel] [PATCH 11/30] avcodec/aacsbr_template: Remove pointless runtime initialization

The sbr_qmf_window_us array is basically symmetric around its middle element and therefore the latter half is currently initialized from the first half at runtime. Yet because the first half is initialized, the array can't be placed in .bss at all, so that one gains nothing from not already initial

[FFmpeg-devel] [PATCH 05/30] Replace arrays of pointers to strings by arrays of strings

When the difference of the longest size and the average size of collection of strings is smaller than the size of a pointer, it makes sense to store the strings directly in an array instead of using an array of pointers to strings (unless doing so precludes deduplicating strings); doing so also avo

[FFmpeg-devel] [PATCH 10/30] avcodec/aacsbr: Remove remnants of tablegen

These tables are always initialized at runtime since commit cb93df0dcbd34107c64ec053504fa294b728a9c9. Signed-off-by: Andreas Rheinhardt --- libavcodec/aacsbr.c | 1 - libavcodec/aacsbr_fixed.c | 1 - libavcodec/aacsbr_fixed_tablegen.h | 28 --- libavcodec/aacs

[FFmpeg-devel] [PATCH 04/30] avcodec/mlpenc: Simplify finding best codebook

Finding the best codebook involves comparing different paths, where each path is a sequence of several decisions (namely which codebook to use). Up until now, these sequence was encoded in a NUL-terminated string and the actual decisions were encoded as ’\0'..'\3' (which encoded 0..3). This commit

[FFmpeg-devel] [PATCH 09/30] avcodec/atrac3plus_data: Mark array as const

Forgotten in a7dbeb77c3c30ac4904928978938b209ff6e1ab1. Signed-off-by: Andreas Rheinhardt --- libavcodec/atrac3plus_data.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/atrac3plus_data.h b/libavcodec/atrac3plus_data.h index 7039936ba3..b0b85c4368 100644 --- a/liba

[FFmpeg-devel] [PATCH 03/30] avcodec/opusdec: Remove always-true check

The celt_delay AVAudioFifo is always allocated during init, so checking for its existence in .flush is unnecessary. Signed-off-by: Andreas Rheinhardt --- libavcodec/opusdec.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libavcodec/opusdec.c b/libavcodec/opusdec.c index a

[FFmpeg-devel] [PATCH 02/30] avfilter/vf_addroi: Use chars instead of strings for one-char strings

Signed-off-by: Andreas Rheinhardt --- libavfilter/vf_addroi.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/libavfilter/vf_addroi.c b/libavfilter/vf_addroi.c index 489998ce73..d6b83ee854 100644 --- a/libavfilter/vf_addroi.c +++ b/libavfilter/vf_addroi.c @@ -26,8 +

[FFmpeg-devel] [PATCH 01/30] avcodec/opustab: Make array static

Signed-off-by: Andreas Rheinhardt --- libavcodec/opustab.c | 12 ++-- libavcodec/opustab.h | 1 - 2 files changed, 6 insertions(+), 7 deletions(-) diff --git a/libavcodec/opustab.c b/libavcodec/opustab.c index 64070f8299..7276dad793 100644 --- a/libavcodec/opustab.c +++ b/libavcodec/opu

Re: [FFmpeg-devel] [PATCH] hwcontext_drm: make dependency on Linux kernel headers optional

Dec 30, 2020, 22:23 by d...@lynne.ee: > This was introduced sometimes in between 4.4 and 4.15. And may not exist > at all without an optional package. So to prevent a hard dependency > on needing the Linux kernel headers to compile, make this optional. > > Patch attached. > After some discussion

Re: [FFmpeg-devel] [PATCH] mpeg2_metadata: support inverse (soft) telecine

Tom Yan: > Hi Andreas, > > (Somehow I didn't receive your reply and only found it on the mailing > list archive) > > Can you be more specific about the "smaller scope" on the use of > `MPEG2RawPictureCodingExtension`? Not sure what you mean. > The actual scope of pce is the "if (ctx->ivtc) { }"

[FFmpeg-devel] [PATCH] hwcontext_drm: make dependency on Linux kernel headers optional

This was introduced sometimes in between 4.4 and 4.15. And may not exist at all without an optional package. So to prevent a hard dependency on needing the Linux kernel headers to compile, make this optional. Patch attached. >From 6f241c3ba8dfda622f51ff1b0bb19dfb4fe18e45 Mon Sep 17 00:00:00 2001

Re: [FFmpeg-devel] [PATCH 02/39] avcodec/mpeg12: Don't initialize encoder-only parts of RLTable

Quoting Andreas Rheinhardt (2020-12-30 20:01:08) > Anton Khirnov: > > Quoting Andreas Rheinhardt (2020-12-10 12:16:20) > >> ff_mpeg12_init_vlcs() currently initializes index_run, max_level and > >> max_run of ff_rl_mpeg1/2; yet the only user of these fields is the > >> MPEG-1/2 encoder which alread

Re: [FFmpeg-devel] [PATCH 02/39] avcodec/mpeg12: Don't initialize encoder-only parts of RLTable

Anton Khirnov: > Quoting Andreas Rheinhardt (2020-12-10 12:16:20) >> ff_mpeg12_init_vlcs() currently initializes index_run, max_level and >> max_run of ff_rl_mpeg1/2; yet the only user of these fields is the >> MPEG-1/2 encoder which already initializes these tables on its own. >> So remove the ini

Re: [FFmpeg-devel] Fwd: [PATCH] libavformat: add librist protocol

Sergio M. Ammirata, Ph.D. (12020-12-30): > Is there else blocking the integration of the library based > module into ffmpeg? The comments made by James and me need to be addressed. > We would prefer not to have it in "experimental mode". For that, you need to be really really sure that the API i

Re: [FFmpeg-devel] Patch to libavc/opus to create extradata if missing

On 12/30/2020 3:00 PM, Jonathan Baudanza wrote: On Tue, Dec 29, 2020, at 3:25 PM, Jonathan Baudanza wrote: Thank you for all the feedback everyone. I've updated the patch to build the opus header inside of ff_rtp_parse_open in libavformat/rtpdec.c. I set the mapping_family to 0, since I belie

Re: [FFmpeg-devel] [PATCH 15/39] avcodec/mpegvideo: Merge ff_mpv_decode_defaults into ff_mpv_decode_init

Quoting Andreas Rheinhardt (2020-12-10 12:16:33) > These two are always called directly after each other (with the > exception of the calls in mpeg_decode_init() where some irrelevant > modifications of the avctx (which could just as well be done before > ff_mpv_decode_defaults(), because it doesn'

Re: [FFmpeg-devel] Patch to libavc/opus to create extradata if missing

On Tue, Dec 29, 2020, at 3:25 PM, Jonathan Baudanza wrote: > Thank you for all the feedback everyone. I've updated the patch to build the > opus header inside of ff_rtp_parse_open in libavformat/rtpdec.c. > > I set the mapping_family to 0, since I believe Opus/RTP only supports 2 > channels. I

Re: [FFmpeg-devel] [PATCH 06/39] avcodec/speedhq: Remove cast

Quoting Andreas Rheinhardt (2020-12-10 12:16:24) > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/speedhq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Looks good -- Anton Khirnov ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg

Re: [FFmpeg-devel] [PATCH 04/39] avcodec/mpeg12: Reindentation

Quoting Andreas Rheinhardt (2020-12-10 12:16:22) > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/mpeg12.c | 50 ++--- > 1 file changed, 25 insertions(+), 25 deletions(-) Trivially ok -- Anton Khirnov ___

Re: [FFmpeg-devel] [PATCH 03/39] avcodec/mpeg12: Make initializing VLCs thread-safe

Quoting Andreas Rheinhardt (2020-12-10 12:16:21) > This automatically makes the eamad, eatqi, ipu and mdec decoders > init-threadsafe; in addition to the actual mpeg[12]video decoders, > of course. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/eamad.c | 1 + > libavcodec/eatqi.c

Re: [FFmpeg-devel] [PATCH 02/39] avcodec/mpeg12: Don't initialize encoder-only parts of RLTable

Quoting Andreas Rheinhardt (2020-12-10 12:16:20) > ff_mpeg12_init_vlcs() currently initializes index_run, max_level and > max_run of ff_rl_mpeg1/2; yet the only user of these fields is the > MPEG-1/2 encoder which already initializes these tables on its own. > So remove the initializations in ff_mp

Re: [FFmpeg-devel] [PATCH 01/39] avcodec/rl: Remove nonstatic storage of RL tables

Quoting Andreas Rheinhardt (2020-12-10 12:16:19) > ff_rl_free() was added in 324e50ee95929a9491b855c5e15451145bd5d1ec, > but never used; nonstatic storage was not used long before that. > > Signed-off-by: Andreas Rheinhardt > --- Looks ok. -- Anton Khirnov _

Re: [FFmpeg-devel] FW: [PATCH] http: support retry on connection error

On Wed, 30 Dec 2020, Eran Kornblau wrote: It's been 2 months since I submitted this patch (25/10), got a single reply to which I answered below... Can this be merged? I will apply in a few days if no futher comments are received. Thanks, Marton Thanks, Eran -Original Message-

[FFmpeg-devel] [PATCH V2 3/3] dnn/queue: add error check and cleanup

Signed-off-by: Guo, Yejun --- libavfilter/dnn/dnn_backend_openvino.c | 16 --- libavfilter/dnn/queue.c| 28 -- libavfilter/dnn/queue.h| 4 ++-- libavfilter/dnn/safe_queue.c | 16 ++- libavfilter/dnn/safe_qu

[FFmpeg-devel] [PATCH V2 2/3] dnn: fix issue when pthread is not supported

Signed-off-by: Guo, Yejun --- libavfilter/dnn/safe_queue.c| 50 ++--- libavfilter/vf_dnn_processing.c | 7 + 2 files changed, 41 insertions(+), 16 deletions(-) diff --git a/libavfilter/dnn/safe_queue.c b/libavfilter/dnn/safe_queue.c index 52a60982b5..559b939e

[FFmpeg-devel] [PATCH V2 1/3] dnn: fix redefining typedefs and also refine naming with correct prefix

The prefix for symbols not exported from the library and not local to one translation unit is ff_ (or FF for types). Signed-off-by: Guo, Yejun --- libavfilter/dnn/dnn_backend_openvino.c | 32 ++--- libavfilter/dnn/queue.c| 66 +- libavfilter/dnn/qu

Re: [FFmpeg-devel] Fwd: [PATCH] libavformat: add librist protocol

Understood ... thanks for the advice. Is there else blocking the integration of the library based module into ffmpeg? We would prefer not to have it in "experimental mode". Regards, Sergio On Tue, 2020-12-29 at 23:03 +0100, Nicolas George wrote: > Sergio M. Ammirata, Ph.D. (12020-12-28): > > W

Re: [FFmpeg-devel] [PATCH 1/3] dnn/queue: fix redefining typedefs

> -Original Message- > From: ffmpeg-devel On Behalf Of > Andreas Rheinhardt > Sent: 2020年12月30日 21:03 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH 1/3] dnn/queue: fix redefining typedefs > > Guo, Yejun: > > > > > >> -Original Message- > >> From: ffmpeg-deve

Re: [FFmpeg-devel] [PATCH 1/3] dnn/queue: fix redefining typedefs

> -Original Message- > From: ffmpeg-devel On Behalf Of Guo, > Yejun > Sent: 2020年12月30日 20:58 > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH 1/3] dnn/queue: fix redefining typedefs > > > > > -Original Message- > > From: ffmpeg-devel On

Re: [FFmpeg-devel] [PATCH 1/3] dnn/queue: fix redefining typedefs

Guo, Yejun: > > >> -Original Message- >> From: ffmpeg-devel On Behalf Of >> Andreas Rheinhardt >> Sent: 2020年12月30日 18:04 >> To: ffmpeg-devel@ffmpeg.org >> Subject: Re: [FFmpeg-devel] [PATCH 1/3] dnn/queue: fix redefining typedefs >> >> Guo, Yejun: >>> Signed-off-by: Guo, Yejun >>> ---

Re: [FFmpeg-devel] [PATCH 1/3] dnn/queue: fix redefining typedefs

> -Original Message- > From: ffmpeg-devel On Behalf Of > Andreas Rheinhardt > Sent: 2020年12月30日 18:04 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH 1/3] dnn/queue: fix redefining typedefs > > Guo, Yejun: > > Signed-off-by: Guo, Yejun > > --- > > libavfilter/dnn/qu

Re: [FFmpeg-devel] [PATCH] patcheck: warn missing whitespace between ) and {

> 2020年12月30日 下午6:54，Andreas Rheinhardt 写道： > > liuqi05: >> Signed-off-by: liuqi05 >> --- >> tools/patcheck | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/tools/patcheck b/tools/patcheck >> index fe52938f29..ca7b57f29f 100755 >> --- a/tools/patcheck >> +++ b/tools/patcheck >> @@ -

Re: [FFmpeg-devel] [PATCH] patcheck: warn missing whitespace between ) and {

liuqi05: > Signed-off-by: liuqi05 > --- > tools/patcheck | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tools/patcheck b/tools/patcheck > index fe52938f29..ca7b57f29f 100755 > --- a/tools/patcheck > +++ b/tools/patcheck > @@ -101,6 +101,7 @@ hiegrep2 "$ERE_TYPES" > '(static|av_|ff_|ty

[FFmpeg-devel] [PATCH] patcheck: warn missing whitespace between ) and {

Signed-off-by: liuqi05 --- tools/patcheck | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/patcheck b/tools/patcheck index fe52938f29..ca7b57f29f 100755 --- a/tools/patcheck +++ b/tools/patcheck @@ -101,6 +101,7 @@ hiegrep2 "$ERE_TYPES" '(static|av_|ff_|typedef|:\+[^a-zA-Z_])' 'Non stat

Re: [FFmpeg-devel] [PATCH 1/3] dnn/queue: fix redefining typedefs

Guo, Yejun: > Signed-off-by: Guo, Yejun > --- > libavfilter/dnn/queue.c | 8 > libavfilter/dnn/safe_queue.c | 4 ++-- > 2 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/libavfilter/dnn/queue.c b/libavfilter/dnn/queue.c > index 0a07c5473d..da0517968d 100644 > --- a/

[FFmpeg-devel] FW: [PATCH] http: support retry on connection error

It's been 2 months since I submitted this patch (25/10), got a single reply to which I answered below... Can this be merged? Thanks, Eran -Original Message- From: Eran Kornblau Sent: Wednesday, December 23, 2020 8:14 PM To: FFmpeg development discussions and patches Subject: FW: [FFmp