Re: [FFmpeg-devel] [PATCH] avfilter: add stereoupmix

2020-12-13 Thread Lingjiang Fang
On Wed, 9 Dec 2020 18:20:07 +0100 Paul B Mahol wrote: >Signed-off-by: Paul B Mahol >--- > doc/filters.texi | 34 > libavfilter/Makefile | 1 + > libavfilter/af_stereoupmix.c | 352 +++ > libavfilter/allfilters.c | 1 + > 4 files chan

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/cuviddec: unref output frame on failure

2020-12-13 Thread Philip Langdale
On Sun, 13 Dec 2020 15:51:04 -0300 James Almer wrote: > Signed-off-by: James Almer > --- > libavcodec/cuviddec.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/libavcodec/cuviddec.c b/libavcodec/cuviddec.c > index 331851231f..49775b5a09 100644 > --- a/libavcodec/cuviddec.c > +++ b

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/cuviddec: check for av_buffer_ref() failure

2020-12-13 Thread Philip Langdale
On Sun, 13 Dec 2020 15:51:03 -0300 James Almer wrote: > Signed-off-by: James Almer > --- > libavcodec/cuviddec.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/libavcodec/cuviddec.c b/libavcodec/cuviddec.c > index 61d7f36c79..331851231f 100644 > --- a/libavcodec/cuviddec.c > ++

Re: [FFmpeg-devel] Call for maintainers: vf_uspp, vf_mcdeint

2020-12-13 Thread Michael Niedermayer
On Sun, Dec 13, 2020 at 06:22:08PM +0100, Anton Khirnov wrote: > Quoting Michael Niedermayer (2020-12-13 15:03:19) > > On Sun, Dec 13, 2020 at 02:02:33PM +0100, Anton Khirnov wrote: > > > Quoting Paul B Mahol (2020-12-13 13:40:15) > > > > Why? Is it so hard to fix them work with latest API? > > >

[FFmpeg-devel] [PATCH 2/2] avcodec/cuviddec: unref output frame on failure

2020-12-13 Thread James Almer
Signed-off-by: James Almer --- libavcodec/cuviddec.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavcodec/cuviddec.c b/libavcodec/cuviddec.c index 331851231f..49775b5a09 100644 --- a/libavcodec/cuviddec.c +++ b/libavcodec/cuviddec.c @@ -634,6 +634,9 @@ FF_ENABLE_DEPRECATION_WARNINGS

[FFmpeg-devel] [PATCH 1/2] avcodec/cuviddec: check for av_buffer_ref() failure

2020-12-13 Thread James Almer
Signed-off-by: James Almer --- libavcodec/cuviddec.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/libavcodec/cuviddec.c b/libavcodec/cuviddec.c index 61d7f36c79..331851231f 100644 --- a/libavcodec/cuviddec.c +++ b/libavcodec/cuviddec.c @@ -553,6 +553,12 @@ static int cuvid_output_fra

Re: [FFmpeg-devel] [PATCH 1/1] avformat/mov: fix timecode with counter mode flag set

2020-12-13 Thread Mark Reid
On Sun, Dec 13, 2020 at 2:05 AM Anton Khirnov wrote: > Quoting mindm...@gmail.com (2020-11-29 05:08:38) > > From: Mark Reid > > > > The current behaviour ends up squaring the avg_frame_rate if the conter > mode flag is set. > > This messes up the timecode calculation, and looks to me as a regres

Re: [FFmpeg-devel] Call for maintainers: vf_uspp, vf_mcdeint

2020-12-13 Thread Anton Khirnov
Quoting Michael Niedermayer (2020-12-13 15:03:19) > On Sun, Dec 13, 2020 at 02:02:33PM +0100, Anton Khirnov wrote: > > Quoting Paul B Mahol (2020-12-13 13:40:15) > > > Why? Is it so hard to fix them work with latest API? > > > > It is not exactly obvious, since coded_frame is gone. I suppose you >

Re: [FFmpeg-devel] [PATCH 1/2] ffmpeg: use sigaction() instead of signal() on linux

2020-12-13 Thread Andriy Gelman
On Sat, 28. Nov 14:46, Andriy Gelman wrote: > From: Andriy Gelman > > As per signal() help (man 2 signal) the semantics of using signal may > vary across platforms. It is suggested to use sigaction() instead. > > On my system, the capture signal is reset to the default handler after > the first

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/decode: set best_effort_timestamp on output frames for all decoders

2020-12-13 Thread James Almer
On 12/13/2020 6:38 AM, Anton Khirnov wrote: Quoting James Almer (2020-12-13 04:15:22) Fixes a decoding regression introduced by e9a2a87773, and as a side effect also fixes bogus values set to certain audio frames that had some samples discarded, where the offsets added to pts, pkt_dts and pkt_du

Re: [FFmpeg-devel] Call for maintainers: vf_uspp, vf_mcdeint

2020-12-13 Thread Paul B Mahol
On Sun, Dec 13, 2020 at 3:03 PM Michael Niedermayer wrote: > On Sun, Dec 13, 2020 at 02:02:33PM +0100, Anton Khirnov wrote: > > Quoting Paul B Mahol (2020-12-13 13:40:15) > > > Why? Is it so hard to fix them work with latest API? > > > > It is not exactly obvious, since coded_frame is gone. I sup

Re: [FFmpeg-devel] Call for maintainers: vf_uspp, vf_mcdeint

2020-12-13 Thread Michael Niedermayer
On Sun, Dec 13, 2020 at 02:02:33PM +0100, Anton Khirnov wrote: > Quoting Paul B Mahol (2020-12-13 13:40:15) > > Why? Is it so hard to fix them work with latest API? > > It is not exactly obvious, since coded_frame is gone. I suppose you > could instantiate an encoder and a decoder to work around t

Re: [FFmpeg-devel] [NUT-devel] [PATCH] Add st_sd_displaymatrix for storing the stream display matrix

2020-12-13 Thread Michael Niedermayer
On Fri, Nov 20, 2020 at 12:28:59PM +0100, Matthias Neugebauer wrote: > See FFmpeg patch: > https://patchwork.ffmpeg.org/project/ffmpeg/patch/f7848cee-46c1-4caf-9191-a7babf5d6...@mailbox.org/ > --- > docs/nut.txt | 8 +++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/docs/n

Re: [FFmpeg-devel] Call for maintainers: vf_uspp, vf_mcdeint

2020-12-13 Thread Anton Khirnov
Quoting Paul B Mahol (2020-12-13 13:40:15) > Why? Is it so hard to fix them work with latest API? It is not exactly obvious, since coded_frame is gone. I suppose you could instantiate an encoder and a decoder to work around that, but it all seems terribly inefficient. Lavfi seems to have some ME c

Re: [FFmpeg-devel] Call for maintainers: vf_uspp, vf_mcdeint

2020-12-13 Thread Paul B Mahol
Why? Is it so hard to fix them work with latest API? On Sat, Dec 12, 2020 at 5:05 PM Anton Khirnov wrote: > Hi, > as we are approaching the next major bump, vf_mcdeint and vf_uspp > filters are still using deprecated libavcodec APIs. > > Does anyone care about preserving and maintaining them? If

Re: [FFmpeg-devel] [PATCH v3] avformat/framecrcenc: Make side-data checksums endian-independent

2020-12-13 Thread Anton Khirnov
IMO checksumming side data contents is a bad idea and should not be done at all. It's supposed to be an in-memory representation, which is inherently platform-dependent - besides endianness there are potential issues with padding or type sizes. If we want to test side data, we should use some other

Re: [FFmpeg-devel] [PATCH 1/1] avformat/mov: fix timecode with counter mode flag set

2020-12-13 Thread Anton Khirnov
Quoting mindm...@gmail.com (2020-11-29 05:08:38) > From: Mark Reid > > The current behaviour ends up squaring the avg_frame_rate if the conter mode > flag is set. > This messes up the timecode calculation, and looks to me as a regression that > seems to have been introduced 428b4aac. > > The n

Re: [FFmpeg-devel] [PATCH]lavd/decklink_dec: Use correct case for codec point / fourcc v210

2020-12-13 Thread Carl Eugen Hoyos
Am Sa., 12. Dez. 2020 um 10:57 Uhr schrieb Marton Balint : > > On Fri, 11 Dec 2020, Carl Eugen Hoyos wrote: > > > Attached patch fixes ticket #9005. > > Why are the codec_tags set at all? Can't we simply remove setting of all > the codec tags in decklink? They hold no additional information to > co

Re: [FFmpeg-devel] [PATCH 7/7] Handle AVID MJPEG streams directly in the MJPEG decoder.

2020-12-13 Thread Anton Khirnov
Quoting James Almer (2020-12-13 01:17:52) > On 12/12/2020 12:45 PM, Anton Khirnov wrote: > > AVID streams, currently handled by the AVRN decoder can be (depending on > > extradata contents) either MJPEG or raw video. To decode the MJPEG > > variant, the AVRN decoder currently instantiates a MJPEG d

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/mjpegdec: stop setting AVFrame->best_effort_timestamp

2020-12-13 Thread Anton Khirnov
Quoting James Almer (2020-12-13 04:15:23) > It's now set by the generic decode code. > > Signed-off-by: James Almer > --- > libavcodec/mjpegdec.c | 1 - > 1 file changed, 1 deletion(-) This and next one obviously ok -- Anton Khirnov ___ ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/decode: set best_effort_timestamp on output frames for all decoders

2020-12-13 Thread Anton Khirnov
Quoting James Almer (2020-12-13 04:15:22) > Fixes a decoding regression introduced by e9a2a87773, and as a side effect > also > fixes bogus values set to certain audio frames that had some samples > discarded, > where the offsets added to pts, pkt_dts and pkt_duration were not reflected in > best