Re: [FFmpeg-devel] [PATCH] avformat/dv: fix timestamps of audio packets in case of dropped corrupt audio frames

2020-11-09 Thread Dave Rice
> On Nov 6, 2020, at 4:03 PM, Michael Niedermayer > wrote: > > On Wed, Nov 04, 2020 at 10:44:56PM +0100, Marton Balint wrote: >> >> On Wed, 4 Nov 2020, Michael Niedermayer wrote: >> >>> we have "millisecond" based formats, rounded timestamps >>> we have "exact" cases, maybe the timebase bein

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/av1dec: expose skip mode frame index

2020-11-09 Thread James Almer
On 11/9/2020 8:02 PM, Mark Thompson wrote: On 09/11/2020 22:50, Timo Rothenpieler wrote: On 09.11.2020 23:30, Mark Thompson wrote: On 09/11/2020 16:30, Timo Rothenpieler wrote: Signed-off-by: Timo Rothenpieler Co-authored-by: James Almer ---   libavcodec/av1dec.c | 89 ++

Re: [FFmpeg-devel] [PATCH 7/7] avcodec/cri: check for available input in unpack_10bit()

2020-11-09 Thread Andreas Rheinhardt
Michael Niedermayer: > Fixes: Timeout (>20sec -> 56ms) > Fixes: > 26995/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_CRI_fuzzer-5107217080254464 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael Niedermayer >

Re: [FFmpeg-devel] [PATCH 1/6] avformat/rtsp: 16384 -> SDP_MAX_SIZE

2020-11-09 Thread lance . lmwang
On Mon, Nov 09, 2020 at 10:51:05PM +0800, Zhao Zhili wrote: > > > > On Nov 4, 2020, at 9:37 PM, lance.lmw...@gmail.com wrote: > > > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > libavformat/rtsp.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git

[FFmpeg-devel] [PATCH 4/4] avformat/dvenc: check the format before vst and ast[i] are initialized

2020-11-09 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavformat/dvenc.c | 25 - 1 file changed, 12 insertions(+), 13 deletions(-) diff --git a/libavformat/dvenc.c b/libavformat/dvenc.c index 1c38673..6c0d40f 100644 --- a/libavformat/dvenc.c +++ b/libavformat/dvenc.c @@ -311,

[FFmpeg-devel] [PATCH 1/4] avfilter/vf_fade: simplify code to use pts timebase for time check

2020-11-09 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavfilter/vf_fade.c | 23 +-- 1 file changed, 13 insertions(+), 10 deletions(-) diff --git a/libavfilter/vf_fade.c b/libavfilter/vf_fade.c index 58d7f8c..af4795c 100644 --- a/libavfilter/vf_fade.c +++ b/libavfilter/vf_fade.c

[FFmpeg-devel] [PATCH 3/4] avformat/dvenc: s->streams[i] -> st

2020-11-09 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavformat/dvenc.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/libavformat/dvenc.c b/libavformat/dvenc.c index b04d604..1c38673 100644 --- a/libavformat/dvenc.c +++ b/libavformat/dvenc.c @@ -307,14 +307,15 @@ static

[FFmpeg-devel] [PATCH 2/4] avfilter/vf_fade: config_props -> config_input

2020-11-09 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavfilter/vf_fade.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavfilter/vf_fade.c b/libavfilter/vf_fade.c index af4795c..51eea04 100644 --- a/libavfilter/vf_fade.c +++ b/libavfilter/vf_fade.c @@ -404,7 +404,7 @@ st

[FFmpeg-devel] [PATCH 7/7] avcodec/cri: check for available input in unpack_10bit()

2020-11-09 Thread Michael Niedermayer
Fixes: Timeout (>20sec -> 56ms) Fixes: 26995/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_CRI_fuzzer-5107217080254464 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/cri.c | 11 +++---

[FFmpeg-devel] [PATCH 5/7] avformat/wavdec: Avoid zeroing written to array

2020-11-09 Thread Michael Niedermayer
Fixes: OOM Fixes: 26934/clusterfuzz-testcase-minimized-ffmpeg_dem_W64_fuzzer-5996784213819392 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavformat/wavdec.c | 2 +- 1 file changed, 1 insertion(+),

Re: [FFmpeg-devel] [PATCH 4/5] avformat/lvfdec: Check stream_index before use

2020-11-09 Thread Michael Niedermayer
On Sun, Nov 08, 2020 at 09:21:45PM +0100, Paul B Mahol wrote: > LGTM will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Complexity theory is the science of finding the exact solution to an approximation. Benchmarking OTOH is finding an approximation

[FFmpeg-devel] [PATCH 4/7] avformat/dhav: Break out of infinite dhav search loop

2020-11-09 Thread Michael Niedermayer
Fixes: Infinite loop Fixes: 26922/clusterfuzz-testcase-minimized-ffmpeg_dem_DHAV_fuzzer-5794549613723648 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavformat/dhav.c | 2 ++ 1 file changed, 2 inser

Re: [FFmpeg-devel] [PATCH 4/7] avformat/au: cleanup on EOF return in au_read_annotation()

2020-11-09 Thread Michael Niedermayer
On Fri, Nov 06, 2020 at 12:29:37AM +0100, Andreas Rheinhardt wrote: > Michael Niedermayer: > > Fixes: memleak > > Fixes: > > 26841/clusterfuzz-testcase-minimized-ffmpeg_dem_AU_fuzzer-5174166309044224 > > > > Found-by: continuous fuzzing process > > https://github.com/google/oss-fuzz/tree/master/

[FFmpeg-devel] [PATCH 1/7] avformat/sbgdec: Check that end is not before start

2020-11-09 Thread Michael Niedermayer
Fixes: signed integer overflow: -9223372036854775808 + -5279949906739200 cannot be represented in type 'long' Fixes: 26908/clusterfuzz-testcase-minimized-ffmpeg_dem_SBG_fuzzer-6329610851319808 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Si

[FFmpeg-devel] [PATCH 3/7] libavformat/utils: consider avio_size() failure in ffio_limit()

2020-11-09 Thread Michael Niedermayer
Fixes: Timeout (>20sec -> 3ms) Fixes: 26918/clusterfuzz-testcase-minimized-ffmpeg_dem_THP_fuzzer-5750425191710720 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavformat/utils.c | 9 ++--- 1 file

[FFmpeg-devel] [PATCH 6/7] avformat/avidec: dv does not support palettes

2020-11-09 Thread Michael Niedermayer
Fixes: memleak Fixes: 26937/clusterfuzz-testcase-minimized-ffmpeg_dem_AVI_fuzzer-5763003338981376 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavformat/avidec.c | 5 +++-- 1 file changed, 3 inserti

[FFmpeg-devel] [PATCH 2/7] avcodec/vp3dsp: Use unsigned constant to avoid undefined integer overflow in ff_vp3dsp_set_bounding_values()

2020-11-09 Thread Michael Niedermayer
Fixes: signed integer overflow: 64 * 33686018 cannot be represented in type 'int' Fixes: 26911/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_THEORA_fuzzer-4904975073017856 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Mich

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/av1dec: expose skip mode frame index

2020-11-09 Thread Mark Thompson
On 09/11/2020 22:50, Timo Rothenpieler wrote: On 09.11.2020 23:30, Mark Thompson wrote: On 09/11/2020 16:30, Timo Rothenpieler wrote: Signed-off-by: Timo Rothenpieler Co-authored-by: James Almer ---   libavcodec/av1dec.c | 89 +   libavcodec/av1dec.h

Re: [FFmpeg-devel] build ffmpeg.so with h264 and h265 codec support

2020-11-09 Thread Budi
I tried to build libffmpeg.so with h264 and h265 codec so go to compile as on: https://trac.ffmpeg.org/wiki/CompilationGuide/Ubuntu but cannot find the exact need of this dynamic link build as all refer to build standalone executable binary How is actually the definitive way to compile/build libff

Re: [FFmpeg-devel] [PATCH v4] Unbreak av_malloc_max(0) API/ABI

2020-11-09 Thread Joakim Tjernlund
On Sun, 2020-11-08 at 15:13 +0100, Michael Niedermayer wrote: > CAUTION: This email originated from outside of the organization. Do not click > links or open attachments unless you recognize the sender and know the > content is safe. > > > On Sun, Nov 08, 2020 at 11:35:43AM +0100, Andreas Rhein

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/av1dec: expose skip mode frame index

2020-11-09 Thread Timo Rothenpieler
On 09.11.2020 23:30, Mark Thompson wrote: On 09/11/2020 16:30, Timo Rothenpieler wrote: Signed-off-by: Timo Rothenpieler Co-authored-by: James Almer ---   libavcodec/av1dec.c | 89 +   libavcodec/av1dec.h |  3 ++   2 files changed, 92 insertions(+) d

Re: [FFmpeg-devel] [PATCH 4/4] avcodec/nvdec: add av1 hwaccel

2020-11-09 Thread Mark Thompson
On 09/11/2020 16:30, Timo Rothenpieler wrote: Signed-off-by: Timo Rothenpieler Co-authored-by: James Almer --- Changelog | 1 + configure | 2 + libavcodec/Makefile| 1 + libavcodec/av1dec.c| 11 +- libavcodec/hwaccels.h | 1 + libavcodec/nvdec

Re: [FFmpeg-devel] [PATCH 2/4] avcodec/av1dec: expose coded_lossless

2020-11-09 Thread Mark Thompson
On 09/11/2020 16:30, Timo Rothenpieler wrote: Signed-off-by: Timo Rothenpieler Co-authored-by: James Almer --- libavcodec/av1dec.c | 32 +++- libavcodec/av1dec.h | 2 ++ 2 files changed, 33 insertions(+), 1 deletion(-) diff --git a/libavcodec/av1dec.c b/libavco

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/av1dec: expose skip mode frame index

2020-11-09 Thread Mark Thompson
On 09/11/2020 16:30, Timo Rothenpieler wrote: Signed-off-by: Timo Rothenpieler Co-authored-by: James Almer --- libavcodec/av1dec.c | 89 + libavcodec/av1dec.h | 3 ++ 2 files changed, 92 insertions(+) diff --git a/libavcodec/av1dec.c b/libavcode

Re: [FFmpeg-devel] [PATCH] Add enable_keyframe_filtering option for libaom-av1 encoder.

2020-11-09 Thread Bohan Li
I have added a feature request in the libaom issue tracker for the key & value api, although it may take some time for the api to land. Meanwhile I still suggest that we apply this patch to ffmpeg since as mentioned this option can be quite important for subjective quality control. Please let me kn

Re: [FFmpeg-devel] [PATCH] avcodec/utils: clear the packet props queue on flushing

2020-11-09 Thread James Almer
On 11/9/2020 2:20 PM, Jan Ekström wrote: On Mon, Nov 9, 2020 at 4:16 PM James Almer wrote: This ensures no queued timestamps or side data are kept and used after seeking, preventing potential desyncs. Signed-off-by: James Almer --- I can verify this patch fixes seeking issues reported down

Re: [FFmpeg-devel] [FFmpeg-cvslog] avformat/rtsp: support infinite initial_timeout for rtsp option

2020-11-09 Thread Andriy Gelman
On Mon, 09. Nov 12:52, Andriy Gelman wrote: > Hi Limin, > > On Sat, 07. Nov 02:14, Limin Wang wrote: > > ffmpeg | branch: master | Limin Wang | Tue Nov 3 > > 18:15:21 2020 +0800| [c8101aabee654f6d147a4d89f77fa73e18908610] | > > committer: Limin Wang > > > > avformat/rtsp: support infinite in

Re: [FFmpeg-devel] [PATCH] avformat/mov: adjust skip_samples according to seek timestamp

2020-11-09 Thread Matthieu Bouron
On Mon, Nov 02, 2020 at 12:42:19PM +0100, Matthieu Bouron wrote: > Currently skip_samples is set to start_pad if sample_time is lesser or > equal to 0. This can cause issues if the stream starts with packets that > have negative pts. Calling avformat_seek_file() with ts set to 0 on such > streams m

Re: [FFmpeg-devel] [PATCH] avcodec/utils: clear the packet props queue on flushing

2020-11-09 Thread Jan Ekström
On Mon, Nov 9, 2020 at 4:16 PM James Almer wrote: > > This ensures no queued timestamps or side data are kept and used after > seeking, preventing potential desyncs. > > Signed-off-by: James Almer > --- I can verify this patch fixes seeking issues reported downstream with ASF+WMApro. Patchwork

Re: [FFmpeg-devel] [FFmpeg-cvslog] avformat/rtsp: support infinite initial_timeout for rtsp option

2020-11-09 Thread Andriy Gelman
Hi Limin, On Sat, 07. Nov 02:14, Limin Wang wrote: > ffmpeg | branch: master | Limin Wang | Tue Nov 3 > 18:15:21 2020 +0800| [c8101aabee654f6d147a4d89f77fa73e18908610] | committer: > Limin Wang > > avformat/rtsp: support infinite initial_timeout for rtsp option > > Signed-off-by: Limin Wang

[FFmpeg-devel] [PATCH 2/4] avcodec/av1dec: expose coded_lossless

2020-11-09 Thread Timo Rothenpieler
Signed-off-by: Timo Rothenpieler Co-authored-by: James Almer --- libavcodec/av1dec.c | 32 +++- libavcodec/av1dec.h | 2 ++ 2 files changed, 33 insertions(+), 1 deletion(-) diff --git a/libavcodec/av1dec.c b/libavcodec/av1dec.c index 83295699e1..bde1124434 100644 --

[FFmpeg-devel] [PATCH 4/4] avcodec/nvdec: add av1 hwaccel

2020-11-09 Thread Timo Rothenpieler
Signed-off-by: Timo Rothenpieler Co-authored-by: James Almer --- Changelog | 1 + configure | 2 + libavcodec/Makefile| 1 + libavcodec/av1dec.c| 11 +- libavcodec/hwaccels.h | 1 + libavcodec/nvdec.c | 4 + libavcodec/nvdec.h | 1 + libavc

[FFmpeg-devel] [PATCH 3/4] avcodec/nvdec: add support for separate reference frame

2020-11-09 Thread Timo Rothenpieler
Signed-off-by: Timo Rothenpieler --- libavcodec/nvdec.c | 40 ++-- libavcodec/nvdec.h | 3 +++ 2 files changed, 41 insertions(+), 2 deletions(-) diff --git a/libavcodec/nvdec.c b/libavcodec/nvdec.c index 6168a7e3f1..52a431c54d 100644 --- a/libavcodec/nvdec.c

[FFmpeg-devel] [PATCH 0/4] Add NVDEC AV1 hwaccel

2020-11-09 Thread Timo Rothenpieler
Timo Rothenpieler (4): avcodec/av1dec: expose skip mode frame index avcodec/av1dec: expose coded_lossless avcodec/nvdec: add support for separate reference frame avcodec/nvdec: add av1 hwaccel Changelog | 1 + configure | 2 + libavcodec/Makefile| 1 +

[FFmpeg-devel] [PATCH 1/4] avcodec/av1dec: expose skip mode frame index

2020-11-09 Thread Timo Rothenpieler
Signed-off-by: Timo Rothenpieler Co-authored-by: James Almer --- libavcodec/av1dec.c | 89 + libavcodec/av1dec.h | 3 ++ 2 files changed, 92 insertions(+) diff --git a/libavcodec/av1dec.c b/libavcodec/av1dec.c index 56712279aa..83295699e1 100644 ---

Re: [FFmpeg-devel] [PATCH] avcodec/utils: clear the packet props queue on flushing

2020-11-09 Thread James Almer
On 11/9/2020 1:14 PM, Paul B Mahol wrote: Is this fixing known bugs? https://github.com/mpv-player/mpv/issues/8248 in theory. On Mon, Nov 9, 2020 at 3:16 PM James Almer wrote: This ensures no queued timestamps or side data are kept and used after seeking, preventing potential desyncs. Si

Re: [FFmpeg-devel] [PATCH] avcodec/utils: clear the packet props queue on flushing

2020-11-09 Thread Paul B Mahol
Is this fixing known bugs? On Mon, Nov 9, 2020 at 3:16 PM James Almer wrote: > This ensures no queued timestamps or side data are kept and used after > seeking, preventing potential desyncs. > > Signed-off-by: James Almer > --- > libavcodec/utils.c | 4 > 1 file changed, 4 insertions(+) >

Re: [FFmpeg-devel] [PATCH] avcodec: add SpeedHQ encoder

2020-11-09 Thread Paul B Mahol
On Mon, Nov 9, 2020 at 4:11 PM Derek Buitenhuis wrote: > On 09/11/2020 12:02, Paul B Mahol wrote: > > +.caps_internal = FF_CODEC_CAP_INIT_CLEANUP, > > I think you can add FF_CODEC_CAP_INIT_THREADSAFE since ff_thread_once is > used properly. > What about the rest of the mpv init code that ca

Re: [FFmpeg-devel] [PATCH] avcodec: add SpeedHQ encoder

2020-11-09 Thread Derek Buitenhuis
On 09/11/2020 12:02, Paul B Mahol wrote: > +.caps_internal = FF_CODEC_CAP_INIT_CLEANUP, I think you can add FF_CODEC_CAP_INIT_THREADSAFE since ff_thread_once is used properly. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ff

Re: [FFmpeg-devel] [PATCH 1/6] avformat/rtsp: 16384 -> SDP_MAX_SIZE

2020-11-09 Thread Zhao Zhili
> On Nov 4, 2020, at 9:37 PM, lance.lmw...@gmail.com wrote: > > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavformat/rtsp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c > index 49c2d52..1b876c9 100644 > --- a/li

[FFmpeg-devel] [PATCH] avcodec/utils: clear the packet props queue on flushing

2020-11-09 Thread James Almer
This ensures no queued timestamps or side data are kept and used after seeking, preventing potential desyncs. Signed-off-by: James Almer --- libavcodec/utils.c | 4 1 file changed, 4 insertions(+) diff --git a/libavcodec/utils.c b/libavcodec/utils.c index db51512e15..a8599b3936 100644 ---

Re: [FFmpeg-devel] build ffmpeg.so with h264 and h265 codec support

2020-11-09 Thread Timo Rothenpieler
On 09.11.2020 12:59, Budi wrote: I tried to build ffmpeg.so with h264 and h265 codec so go to compile as on: https://trac.ffmpeg.org/wiki/CompilationGuide/Ubuntu but cannot find the exact need of this dynamic link build as all refer to build standalone executable binary How is actually the defin

[FFmpeg-devel] [PATCH] avcodec: add SpeedHQ encoder

2020-11-09 Thread Paul B Mahol
From: Jean-Baptiste Kempf Signed-off-by: Paul B Mahol --- Changelog | 1 + doc/general_contents.texi | 2 +- libavcodec/Makefile| 1 + libavcodec/allcodecs.c | 1 + libavcodec/mpegutils.h | 1 + libavcodec/mpegvideo.h | 3 + libavcodec/mpegvideo

Re: [FFmpeg-devel] [PATCH] avcodec: add SpeedHQ encoder

2020-11-09 Thread Andreas Rheinhardt
Paul B Mahol: > From: Jean-Baptiste Kempf > > Signed-off-by: Paul B Mahol > --- > Changelog | 1 + > doc/general_contents.texi | 2 +- > libavcodec/Makefile| 1 + > libavcodec/allcodecs.c | 1 + > libavcodec/mpegutils.h | 1 + > libavcodec/mpegvideo.h

[FFmpeg-devel] build ffmpeg.so with h264 and h265 codec support

2020-11-09 Thread Budi
I tried to build ffmpeg.so with h264 and h265 codec so go to compile as on: https://trac.ffmpeg.org/wiki/CompilationGuide/Ubuntu but cannot find the exact need of this dynamic link build as all refer to build standalone executable binary How is actually the definitive way to compile/build ffmpeg.s

[FFmpeg-devel] [PATCH] avcodec: add SpeedHQ encoder

2020-11-09 Thread Paul B Mahol
From: Jean-Baptiste Kempf Signed-off-by: Paul B Mahol --- Changelog | 1 + doc/general_contents.texi | 2 +- libavcodec/Makefile| 1 + libavcodec/allcodecs.c | 1 + libavcodec/mpegutils.h | 1 + libavcodec/mpegvideo.h | 5 +- libavcodec/mpegvide

Re: [FFmpeg-devel] [PATCH] avfilter/af_asoftclip: add oversampling support

2020-11-09 Thread Paul B Mahol
Will apply soon. On Thu, Nov 5, 2020 at 1:36 PM Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > configure | 1 + > doc/filters.texi | 3 ++ > libavfilter/af_asoftclip.c | 106 ++--- > 3 files changed, 103 insertions(+), 7

Re: [FFmpeg-devel] [PATCH v5 0/9] avformat: wav-s337m support + new probe_stream option

2020-11-09 Thread Nicolas Gaullier
>Nicolas Gaullier (12020-11-09): >> > doc/formats.texi| 3 ++ >> > libavcodec/dolby_e.c| 1 + >> > libavformat/avformat.h | 9 - >> > libavformat/options_table.h | 1 + >> > libavformat/s337m.c | 73 - >> > libavformat/s337m.h

Re: [FFmpeg-devel] [PATCH v5 0/9] avformat: wav-s337m support + new probe_stream option

2020-11-09 Thread Nicolas George
Nicolas Gaullier (12020-11-09): > > doc/formats.texi| 3 ++ > > libavcodec/dolby_e.c| 1 + > > libavformat/avformat.h | 9 - > > libavformat/options_table.h | 1 + > > libavformat/s337m.c | 73 - > > libavformat/s337m.h

[FFmpeg-devel] [PATCH v5 0/9] avformat: wav-s337m support + new probe_stream option

2020-11-09 Thread Nicolas Gaullier
>Updates: >* patch 1 : commit msg amended (anton) >* patch 3 : 'if' line split (tomas) > >Everthing else: unchanged since v4 > >For remembering: the test sample 512.wav can be downloaded here: >https://0x0.st/zdW-.wav > >Nicolas Gaullier (9): > avcodec/dolby_e: set constant frame_size > avformat/